[GitHub] codecov-io edited a comment on issue #304: KYLIN-3617 Use job's cache in job scheduler
codecov-io edited a comment on issue #304: KYLIN-3617 Use job's cache in job scheduler URL: https://github.com/apache/kylin/pull/304#issuecomment-431669562 # [Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@a0c662c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `27.45%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/304/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/304?src=pr=tree) ```diff @@ Coverage Diff@@ ## master#304 +/- ## Coverage ? 21.3% Complexity?4448 Files ?1089 Lines ? 70017 Branches ? 10103 Hits ? 14917 Misses? 53695 Partials ?1405 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/304?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lin/job/impl/threadpool/PriorityFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvUHJpb3JpdHlGZXRjaGVyUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `68.53% <100%> (ø)` | `10 <1> (?)` | | | [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `33.17% <13.63%> (ø)` | `24 <2> (?)` | | | [.../apache/kylin/job/execution/ExecutableManager.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRXhlY3V0YWJsZU1hbmFnZXIuamF2YQ==) | `34.5% <33.33%> (ø)` | `35 <2> (?)` | | | [...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==) | `72.72% <85.71%> (ø)` | `10 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=footer). Last update [a0c662c...bb0f0da](https://codecov.io/gh/apache/kylin/pull/304?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3617) Reduce number of visiting metastore for job scheduler
[ https://issues.apache.org/jira/browse/KYLIN-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660155#comment-16660155 ] ASF GitHub Bot commented on KYLIN-3617: --- codecov-io edited a comment on issue #304: KYLIN-3617 Use job's cache in job scheduler URL: https://github.com/apache/kylin/pull/304#issuecomment-431669562 # [Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@a0c662c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `27.45%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/304/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/304?src=pr=tree) ```diff @@ Coverage Diff@@ ## master#304 +/- ## Coverage ? 21.3% Complexity?4448 Files ?1089 Lines ? 70017 Branches ? 10103 Hits ? 14917 Misses? 53695 Partials ?1405 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/304?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lin/job/impl/threadpool/PriorityFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvUHJpb3JpdHlGZXRjaGVyUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `68.53% <100%> (ø)` | `10 <1> (?)` | | | [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `33.17% <13.63%> (ø)` | `24 <2> (?)` | | | [.../apache/kylin/job/execution/ExecutableManager.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRXhlY3V0YWJsZU1hbmFnZXIuamF2YQ==) | `34.5% <33.33%> (ø)` | `35 <2> (?)` | | | [...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/304/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==) | `72.72% <85.71%> (ø)` | `10 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/304?src=pr=footer). Last update [a0c662c...bb0f0da](https://codecov.io/gh/apache/kylin/pull/304?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce number of visiting metastore for job scheduler > - > > Key: KYLIN-3617 > URL: https://issues.apache.org/jira/browse/KYLIN-3617 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.4.1 >Reporter: nichunen >Assignee: nichunen >Priority: Major > Fix For: v2.6.0 > > > For KYLIN-3470 introduced cache for jobs' metadata, it's also can be used in > job scheduler to reduce the pressure on metastore -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3643) Derived column from windowSpec not working in where
May Zhou created KYLIN-3643: --- Summary: Derived column from windowSpec not working in where Key: KYLIN-3643 URL: https://issues.apache.org/jira/browse/KYLIN-3643 Project: Kylin Issue Type: Bug Environment: Kylin 2.5.0 Reporter: May Zhou Derived column from windowSpec not working in where with error message of > -1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, ``` SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ``` works good. But ``` SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 ``` throws error messages -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3638) cube operator doc
[ https://issues.apache.org/jira/browse/KYLIN-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660225#comment-16660225 ] shenqiong commented on KYLIN-3638: -- [~Shaofengshi] I had test company email, 163 email , none is passed. how could this happended! > cube operator doc > - > > Key: KYLIN-3638 > URL: https://issues.apache.org/jira/browse/KYLIN-3638 > Project: Kylin > Issue Type: Wish > Components: Documentation >Affects Versions: v2.4.1 >Reporter: shenqiong >Priority: Minor > Attachments: image-2018-10-22-14-30-09-899.png, > image-2018-10-22-14-33-42-515.png, 微信截图_20181022143414.png, > 微信截图_20181022143516.png > > > I can not find any instruction to delete a cube with status of "DESCBROKEN" 。 > it can not be deleted by GUI, with error of null. can you show it in > document ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3643) Derived column from windowSpec not working in where
[ https://issues.apache.org/jira/browse/KYLIN-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] May Zhou updated KYLIN-3643: Description: Derived column from windowSpec not working in where with error message of {quote} -1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {{SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES}} works good. But {{SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1}} throws error messages was: Derived column from windowSpec not working in where with error message of > -1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, ``` SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ``` works good. But ``` SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 ``` throws error messages > Derived column from windowSpec not working in where > --- > > Key: KYLIN-3643 > URL: https://issues.apache.org/jira/browse/KYLIN-3643 > Project: Kylin > Issue Type: Bug > Environment: Kylin 2.5.0 >Reporter: May Zhou >Priority: Critical > > Derived column from windowSpec not working in where with error message of > {quote} > -1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID > ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 > LIMIT 5" > taking kylin sample dataset as an example, > {quote} > > > {{SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES}} > > works good. > > But > > {{SELECT * > FROM ( > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > ) T > WHERE T.ROW_NUM =1}} > throws error messages > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nichunen commented on issue #304: KYLIN-3617 Use job's cache in job scheduler
nichunen commented on issue #304: KYLIN-3617 Use job's cache in job scheduler URL: https://github.com/apache/kylin/pull/304#issuecomment-432147039 It test passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (KYLIN-3643) Derived column from windowSpec not working in where
[ https://issues.apache.org/jira/browse/KYLIN-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] May Zhou updated KYLIN-3643: Description: Derived column from windowSpec not working in where with error message of {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {quote} SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES {quote} works good. But {quote}SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 {quote} throws error messages was: Derived column from windowSpec not working in where with error message of {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {{ }} {{ {{SELECT ROW_NUMBER() OVER (}} {{ PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE}} {{ ) AS ROW_NUM}} {{ ,TRANS_ID}} {{ ,BUYER_ID}} {{ ,PRICE}} {{ ,SELLER_ID}} {{ ,PART_DT}} {{ FROM KYLIN_SALES {{ }} works good. But {{SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1}} throws error messages > Derived column from windowSpec not working in where > --- > > Key: KYLIN-3643 > URL: https://issues.apache.org/jira/browse/KYLIN-3643 > Project: Kylin > Issue Type: Bug > Environment: Kylin 2.5.0 >Reporter: May Zhou >Priority: Critical > > Derived column from windowSpec not working in where with error message of > {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID > ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 > LIMIT 5" > taking kylin sample dataset as an example, > {quote} > > {quote} > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > > {quote} > works good. > > But > > {quote}SELECT * > FROM ( > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > ) T > WHERE T.ROW_NUM =1 > {quote} > throws error messages > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3643) Derived column from windowSpec not working in where
[ https://issues.apache.org/jira/browse/KYLIN-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] May Zhou updated KYLIN-3643: Description: Derived column from windowSpec not working in where with error message of {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {{ }} {{ {{SELECT ROW_NUMBER() OVER (}} {{ PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE}} {{ ) AS ROW_NUM}} {{ ,TRANS_ID}} {{ ,BUYER_ID}} {{ ,PRICE}} {{ ,SELLER_ID}} {{ ,PART_DT}} {{ FROM KYLIN_SALES {{ }} works good. But {{SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1}} throws error messages was: Derived column from windowSpec not working in where with error message of {quote} -1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {{SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES}} works good. But {{SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1}} throws error messages > Derived column from windowSpec not working in where > --- > > Key: KYLIN-3643 > URL: https://issues.apache.org/jira/browse/KYLIN-3643 > Project: Kylin > Issue Type: Bug > Environment: Kylin 2.5.0 >Reporter: May Zhou >Priority: Critical > > Derived column from windowSpec not working in where with error message of > {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID > ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 > LIMIT 5" > taking kylin sample dataset as an example, > {quote} > > {{ }} > {{ {{SELECT ROW_NUMBER() OVER (}} > {{ PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE}} > {{ ) AS ROW_NUM}} > {{ ,TRANS_ID}} > {{ ,BUYER_ID}} > {{ ,PRICE}} > {{ ,SELLER_ID}} > {{ ,PART_DT}} > {{ FROM KYLIN_SALES > {{ }} > works good. > > But > > {{SELECT * > FROM ( > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > ) T > WHERE T.ROW_NUM =1}} > throws error messages > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3617) Reduce number of visiting metastore for job scheduler
[ https://issues.apache.org/jira/browse/KYLIN-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660261#comment-16660261 ] ASF GitHub Bot commented on KYLIN-3617: --- nichunen commented on issue #304: KYLIN-3617 Use job's cache in job scheduler URL: https://github.com/apache/kylin/pull/304#issuecomment-432147039 It test passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce number of visiting metastore for job scheduler > - > > Key: KYLIN-3617 > URL: https://issues.apache.org/jira/browse/KYLIN-3617 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.4.1 >Reporter: nichunen >Assignee: nichunen >Priority: Major > Fix For: v2.6.0 > > > For KYLIN-3470 introduced cache for jobs' metadata, it's also can be used in > job scheduler to reduce the pressure on metastore -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3643) Derived column from windowSpec not working in where
[ https://issues.apache.org/jira/browse/KYLIN-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] May Zhou updated KYLIN-3643: Description: Derived column from windowSpec not working in where with error message of {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} Here I've taken kylin sample dataset as example. {quote} SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES {quote} works good. But {quote}SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 {quote} throws error messages was: Derived column from windowSpec not working in where with error message of {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 LIMIT 5" taking kylin sample dataset as an example, {quote} {quote} SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES {quote} works good. But {quote}SELECT * FROM ( SELECT ROW_NUMBER() OVER ( PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 {quote} throws error messages > Derived column from windowSpec not working in where > --- > > Key: KYLIN-3643 > URL: https://issues.apache.org/jira/browse/KYLIN-3643 > Project: Kylin > Issue Type: Bug > Environment: Kylin 2.5.0 >Reporter: May Zhou >Priority: Critical > > Derived column from windowSpec not working in where with error message of > {quote}-1 while executing SQL: "SELECT * FROM ( SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE ) AS ROW_NUM ,TRANS_ID > ,BUYER_ID ,PRICE ,SELLER_ID ,PART_DT FROM KYLIN_SALES ) T WHERE T.ROW_NUM =1 > LIMIT 5" > taking kylin sample dataset as an example, > {quote} > Here I've taken kylin sample dataset as example. > {quote} > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > > {quote} > works good. > > But > > {quote}SELECT * > FROM ( > SELECT ROW_NUMBER() OVER ( > PARTITION BY BUYER_ID,SELLER_ID ORDER BY PRICE > ) AS ROW_NUM > ,TRANS_ID > ,BUYER_ID > ,PRICE > ,SELLER_ID > ,PART_DT > FROM KYLIN_SALES > ) T > WHERE T.ROW_NUM =1 > {quote} > throws error messages > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3579) entrySet iterator should be used in BPUSCalculator
[ https://issues.apache.org/jira/browse/KYLIN-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3579: --- Assignee: Chao Long Fix Version/s: v2.6.0 > entrySet iterator should be used in BPUSCalculator > --- > > Key: KYLIN-3579 > URL: https://issues.apache.org/jira/browse/KYLIN-3579 > Project: Kylin > Issue Type: Bug >Reporter: Ted Yu >Assignee: Chao Long >Priority: Minor > Fix For: v2.6.0 > > > BPUSCalculator.calculateBenefitTotal and BPUSCalculator.initCuboidAggCostMap > use keySet iterator where entrySet iterator should be used. > {code} > for (Long cuboid : cuboidAggCostMapCopy.keySet()) { > if (cuboidAggCostMapCopy.get(cuboid) < > processCuboidAggCostMap.get(cuboid)) { > {code} > CubeCodeSystem.newMetricsAggregators has similar issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3579) entrySet iterator should be used in BPUSCalculator
[ https://issues.apache.org/jira/browse/KYLIN-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3579. - Resolution: Fixed > entrySet iterator should be used in BPUSCalculator > --- > > Key: KYLIN-3579 > URL: https://issues.apache.org/jira/browse/KYLIN-3579 > Project: Kylin > Issue Type: Bug >Reporter: Ted Yu >Assignee: Chao Long >Priority: Minor > Fix For: v2.6.0 > > > BPUSCalculator.calculateBenefitTotal and BPUSCalculator.initCuboidAggCostMap > use keySet iterator where entrySet iterator should be used. > {code} > for (Long cuboid : cuboidAggCostMapCopy.keySet()) { > if (cuboidAggCostMapCopy.get(cuboid) < > processCuboidAggCostMap.get(cuboid)) { > {code} > CubeCodeSystem.newMetricsAggregators has similar issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3608) Move dependency versions to top level pom properties
[ https://issues.apache.org/jira/browse/KYLIN-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3608: --- Assignee: zhoujie > Move dependency versions to top level pom properties > > > Key: KYLIN-3608 > URL: https://issues.apache.org/jira/browse/KYLIN-3608 > Project: Kylin > Issue Type: Task >Reporter: Ted Yu >Assignee: zhoujie >Priority: Minor > > There are some non-top level pom.xml files where dependency version is > referenced directly. > core-common/pom.xml is an example. > We should move all dependency versions to top level pom properties -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3611) Upgrade Tomcat to 7.0.91, 8.5.34 or later
[ https://issues.apache.org/jira/browse/KYLIN-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3611: --- Assignee: zhoujie > Upgrade Tomcat to 7.0.91, 8.5.34 or later > - > > Key: KYLIN-3611 > URL: https://issues.apache.org/jira/browse/KYLIN-3611 > Project: Kylin > Issue Type: Improvement >Reporter: Shaofeng SHI >Assignee: zhoujie >Priority: Major > Fix For: v2.6.0, v2.5.1 > > > h2. [SECURITY] CVE-2018-11784 Apache Tomcat - Open Redirect > > > > CVE-2018-11784 Apache Tomcat - Open Redirect > Severity: Moderate > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 9.0.0.M1 to 9.0.11 > Apache Tomcat 8.5.0 to 8.5.33 > Apache Tomcat 7.0.23 to 7.0.90 > The unsupported 8.0.x release line has not been analysed but is likely > to be affected. > Description: > When the default servlet returned a redirect to a directory (e.g. > redirecting to '/foo/' when the user requested '/foo') a specially > crafted URL could be used to cause the redirect to be generated to any > URI of the attackers choice. > Mitigation: > Users of the affected versions should apply one of the following > mitigations: > - Upgrade to Apache Tomcat 9.0.12 or later. > - Upgrade to Apache Tomcat 8.5.34 or later. > - Upgrade to Apache Tomcat 7.0.91 or later. > - Use mapperDirectoryRedirectEnabled="true" and > mapperContextRootRedirectEnabled="true" on the Context to ensure that > redirects are issued by the Mapper rather than the default Servlet. > See the Context configuration documentation for further important > details. > Credit: > This vulnerability was found by Sergey Bobrov and reported responsibly > to the Apache Tomcat Security Team. > History: > 2018-10-03 Original advisory > References: > [1] [http://tomcat.apache.org/security-9.html] > [2] [http://tomcat.apache.org/security-8.html] > [3] [http://tomcat.apache.org/security-7.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3585) Ineffective declaration of volatile field in SparkFactDistinct
[ https://issues.apache.org/jira/browse/KYLIN-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Long resolved KYLIN-3585. -- Resolution: Resolved Assignee: Chao Long > Ineffective declaration of volatile field in SparkFactDistinct > -- > > Key: KYLIN-3585 > URL: https://issues.apache.org/jira/browse/KYLIN-3585 > Project: Kylin > Issue Type: Bug >Reporter: Ted Yu >Assignee: Chao Long >Priority: Minor > > In CuboidStatCalculator : > {code} > private volatile HLLCounter[] cuboidsHLL; > {code} > Though the array is declared volatile, the array elements are not. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3583) Integer multiplication is performed where Long result is expected
[ https://issues.apache.org/jira/browse/KYLIN-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Long resolved KYLIN-3583. -- Resolution: Resolved Assignee: Chao Long > Integer multiplication is performed where Long result is expected > - > > Key: KYLIN-3583 > URL: https://issues.apache.org/jira/browse/KYLIN-3583 > Project: Kylin > Issue Type: Bug >Reporter: Ted Yu >Assignee: Chao Long >Priority: Minor > > In RecordEventTimeDetail : > {code} > long timeStampForWeekBegin = timeStamp; > timeStampForWeekBegin -= 360 * 24 * > (calendar.get(Calendar.DAY_OF_WEEK) - 1); > {code} > Casting to long should be done first before multiplication. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit commented on issue #306: Update FAQ and Kylin Configuration
asfgit commented on issue #306: Update FAQ and Kylin Configuration URL: https://github.com/apache/kylin/pull/306#issuecomment-432156720 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GinaZhai opened a new pull request #306: Update FAQ and Kylin Configuration
GinaZhai opened a new pull request #306: Update FAQ and Kylin Configuration URL: https://github.com/apache/kylin/pull/306 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660405#comment-16660405 ] Zhong Yanghong commented on KYLIN-2898: --- If a distributed cache is adopted, it's better to set the bar *kylin.query.cache-threshold-duration* for query cache to 0, which means to put query result to cache as much as possible. > Introduce memcached as a distributed cache for queries > -- > > Key: KYLIN-2898 > URL: https://issues.apache.org/jira/browse/KYLIN-2898 > Project: Kylin > Issue Type: Sub-task > Components: Query Engine >Affects Versions: v2.1.0 >Reporter: Zhong Yanghong >Assignee: Wang Ken >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] coveralls edited a comment on issue #301: KYLIN-3633 Avoid potential dead lock when building global dictionary
coveralls edited a comment on issue #301: KYLIN-3633 Avoid potential dead lock when building global dictionary URL: https://github.com/apache/kylin/pull/301#issuecomment-431662392 ## Pull Request Test Coverage Report for [Build 3797](https://coveralls.io/builds/19669769) * **6** of **20** **(30.0%)** changed or added relevant lines in **3** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.004%**) to **23.333%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-dictionary/src/main/java/org/apache/kylin/dict/global/SegmentAppendTrieDictBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Fglobal%2FSegmentAppendTrieDictBuilder.java#L85) | 0 | 1 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FGlobalDictionaryBuilder.java#L109) | 0 | 3 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FDictionaryGenerator.java#L87) | 6 | 16 | 37.5% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19669769/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [![Coverage Status](https://coveralls.io/builds/19669769/badge)](https://coveralls.io/builds/19669769) | | :-- | --: | | Change from base [Build 3795](https://coveralls.io/builds/19664534): | 0.004% | | Covered Lines: | 16332 | | Relevant Lines: | 69996 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3633) Dead lock may happen in building global dictionary
[ https://issues.apache.org/jira/browse/KYLIN-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660627#comment-16660627 ] ASF GitHub Bot commented on KYLIN-3633: --- coveralls edited a comment on issue #301: KYLIN-3633 Avoid potential dead lock when building global dictionary URL: https://github.com/apache/kylin/pull/301#issuecomment-431662392 ## Pull Request Test Coverage Report for [Build 3797](https://coveralls.io/builds/19669769) * **6** of **20** **(30.0%)** changed or added relevant lines in **3** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.004%**) to **23.333%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-dictionary/src/main/java/org/apache/kylin/dict/global/SegmentAppendTrieDictBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Fglobal%2FSegmentAppendTrieDictBuilder.java#L85) | 0 | 1 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FGlobalDictionaryBuilder.java#L109) | 0 | 3 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FDictionaryGenerator.java#L87) | 6 | 16 | 37.5% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19669769/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [![Coverage Status](https://coveralls.io/builds/19669769/badge)](https://coveralls.io/builds/19669769) | | :-- | --: | | Change from base [Build 3795](https://coveralls.io/builds/19664534): | 0.004% | | Covered Lines: | 16332 | | Relevant Lines: | 69996 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dead lock may happen in building global dictionary > -- > > Key: KYLIN-3633 > URL: https://issues.apache.org/jira/browse/KYLIN-3633 > Project: Kylin > Issue Type: Bug > Components: Measure - Count Distinct >Affects Versions: v2.4.1 >Reporter: nichunen >Assignee: nichunen >Priority: Major > Fix For: v2.5.1 > > > During the building of global dict, if an error happens, the builder's lock > maybe un-released. This will block all other building jobs with global dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3644) NumberFormatExcetion on null values when building cube with Spark
[ https://issues.apache.org/jira/browse/KYLIN-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hubert STEFANI updated KYLIN-3644: -- Attachment: 00_zeppelin_notebook.jpg > NumberFormatExcetion on null values when building cube with Spark > - > > Key: KYLIN-3644 > URL: https://issues.apache.org/jira/browse/KYLIN-3644 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: v2.5.0 >Reporter: Hubert STEFANI >Priority: Major > Attachments: 00_zeppelin_notebook.jpg, 01_overview_table.jpg, > 02_dimension_cube.jpg, 03_measure_cube.jpg, sortieData.csv > > > We encounter an error any time we try to build a cube with the following > steps : > * upload a csv on AWS S3 with following characteristics : the column on > which the measure will be defined has some null values (Cf. attachment) > * create a hive table with spark > * create a model on top of this table, > * create a cube with a SUM measure > * chose Spark as Engine > * Launch build > Result : The build process fails at '{color:#4383b4}#7 Step Name: > {color}Build Cube with Spark' with the following error : > > "" > 18/10/23 09:25:39 INFO scheduler.DAGScheduler: Job 0 failed: > saveAsNewAPIHadoopDataset at SparkCubingByLayer.java:253, took 7,277136 s > Exception in thread "main" java.lang.RuntimeException: error execute > org.apache.kylin.engine.spark.SparkCubingByLayer. Root cause: Job aborted due > to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: > Lost task 0.3 in stage 0.0 (TID 4, > ip-172-31-35-113.eu-west-1.compute.internal, executor 4): > java.lang.NumberFormatException: For input string: "\N" > at > sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043) > at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110) > at java.lang.Double.parseDouble(Double.java:538) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:38) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:28) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueOf(BaseCuboidBuilder.java:162) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueObjects(BaseCuboidBuilder.java:127) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:297) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:257) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > " > Note 1: the build process is OK when run with Map/Reduce Engine. > Note 2: the error doesn't seem to be related to AWS environment. > > Sample of csv : > ID;CATEGORIE;TEL;MONTANT;MAGASIN;MATRICULE;VILLE; > 970;161;6-98-6-6-42;838.47034;Magasin_19;Client_Matricule_28;MARSEILLE; > 971;89;62-15-2-64-86;;;Client_Matricule_1;LYON; > 972;87;17-64-97-74-42;;;Client_Matricule_105;ORBEC; > 973;174;79-33-90-0-55;;Magasin_7;Client_Matricule_55;AJACCIO; > 974;172;89-95-71-6-49;141.64174;Magasin_9;Client_Matricule_105;BASTIA; > 975;83;7-27-95-28-7;897.28204;;Client_Matricule_199;AJACCIO; > 976;170;67-72-18-29-34;164.07967;Magasin_3;Client_Matricule_137;LILLE; > 977;130;14-69-4-23-27;1928.9557;Magasin_1;Client_Matricule_17;NOMNOM; > 978;43;55-91-84-98-49;891.2691;Magasin_0;Client_Matricule_22;NOMNOM; > 979;117;98-96-0-54-39;1636.3994;Magasin_9;Client_Matricule_142;MARSEILLE; > 980;163;37-55-76-53-38;;;Client_Matricule_64;NEWYORK; > 981;106;32-40-6-46-15;;Magasin_2;Client_Matricule_158;NOMNOM; > 982;56;95-60-83-89-90;;;Client_Matricule_102;NOMNOM; > 983;168;21-56-62-0-58;;;Client_Matricule_160;NOMNOM; > 984;154;92-67-37-94-60;;;Client_Matricule_137;PARIS; > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3644) NumberFormatExcetion on null values when building cube with Spark
[ https://issues.apache.org/jira/browse/KYLIN-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hubert STEFANI updated KYLIN-3644: -- Attachment: sortieData.csv > NumberFormatExcetion on null values when building cube with Spark > - > > Key: KYLIN-3644 > URL: https://issues.apache.org/jira/browse/KYLIN-3644 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: v2.5.0 >Reporter: Hubert STEFANI >Priority: Major > Attachments: 01_overview_table.jpg, 02_dimension_cube.jpg, > 03_measure_cube.jpg, sortieData.csv > > > We encounter an error any time we try to build a cube with the following > steps : > * upload a csv on AWS S3 with following characteristics : the column on > which the measure will be defined has some null values (Cf. attachment) > * create a hive table with spark > * create a model on top of this table, > * create a cube with a SUM measure > * chose Spark as Engine > * Launch build > Result : The build process fails at '{color:#4383b4}#7 Step Name: > {color}Build Cube with Spark' with the following error : > > "" > 18/10/23 09:25:39 INFO scheduler.DAGScheduler: Job 0 failed: > saveAsNewAPIHadoopDataset at SparkCubingByLayer.java:253, took 7,277136 s > Exception in thread "main" java.lang.RuntimeException: error execute > org.apache.kylin.engine.spark.SparkCubingByLayer. Root cause: Job aborted due > to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: > Lost task 0.3 in stage 0.0 (TID 4, > ip-172-31-35-113.eu-west-1.compute.internal, executor 4): > java.lang.NumberFormatException: For input string: "\N" > at > sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043) > at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110) > at java.lang.Double.parseDouble(Double.java:538) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:38) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:28) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueOf(BaseCuboidBuilder.java:162) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueObjects(BaseCuboidBuilder.java:127) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:297) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:257) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > " > Note 1: the build process is OK when run with Map/Reduce Engine. > Note 2: the error doesn't seem to be related to AWS environment. > > Sample of csv : > ID;CATEGORIE;TEL;MONTANT;MAGASIN;MATRICULE;VILLE; > 970;161;6-98-6-6-42;838.47034;Magasin_19;Client_Matricule_28;MARSEILLE; > 971;89;62-15-2-64-86;;;Client_Matricule_1;LYON; > 972;87;17-64-97-74-42;;;Client_Matricule_105;ORBEC; > 973;174;79-33-90-0-55;;Magasin_7;Client_Matricule_55;AJACCIO; > 974;172;89-95-71-6-49;141.64174;Magasin_9;Client_Matricule_105;BASTIA; > 975;83;7-27-95-28-7;897.28204;;Client_Matricule_199;AJACCIO; > 976;170;67-72-18-29-34;164.07967;Magasin_3;Client_Matricule_137;LILLE; > 977;130;14-69-4-23-27;1928.9557;Magasin_1;Client_Matricule_17;NOMNOM; > 978;43;55-91-84-98-49;891.2691;Magasin_0;Client_Matricule_22;NOMNOM; > 979;117;98-96-0-54-39;1636.3994;Magasin_9;Client_Matricule_142;MARSEILLE; > 980;163;37-55-76-53-38;;;Client_Matricule_64;NEWYORK; > 981;106;32-40-6-46-15;;Magasin_2;Client_Matricule_158;NOMNOM; > 982;56;95-60-83-89-90;;;Client_Matricule_102;NOMNOM; > 983;168;21-56-62-0-58;;;Client_Matricule_160;NOMNOM; > 984;154;92-67-37-94-60;;;Client_Matricule_137;PARIS; > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3617) Reduce number of visiting metastore for job scheduler
[ https://issues.apache.org/jira/browse/KYLIN-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660356#comment-16660356 ] Zhong Yanghong commented on KYLIN-3617: --- The commit 52307bab46db6240169492f240a8b69bde5110d8 blocks IT *ITDistributedSchedulerTakeOverTest*. Could you help have a check? > Reduce number of visiting metastore for job scheduler > - > > Key: KYLIN-3617 > URL: https://issues.apache.org/jira/browse/KYLIN-3617 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.4.1 >Reporter: nichunen >Assignee: nichunen >Priority: Major > Fix For: v2.6.0 > > > For KYLIN-3470 introduced cache for jobs' metadata, it's also can be used in > job scheduler to reduce the pressure on metastore -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3644) NumberFormatExcetion on null values when building cube with Spark
Hubert STEFANI created KYLIN-3644: - Summary: NumberFormatExcetion on null values when building cube with Spark Key: KYLIN-3644 URL: https://issues.apache.org/jira/browse/KYLIN-3644 Project: Kylin Issue Type: Bug Components: Spark Engine Affects Versions: v2.5.0 Reporter: Hubert STEFANI Attachments: 01_overview_table.jpg, 02_dimension_cube.jpg, 03_measure_cube.jpg We encounter an error any time we try to build a cube with the following steps : * upload a csv on AWS S3 with following characteristics : the column on which the measure will be defined has some null values (Cf. attachment) * create a hive table with spark * create a model on top of this table, * create a cube with a SUM measure * chose Spark as Engine * Launch build Result : The build process fails at '{color:#4383b4}#7 Step Name: {color}Build Cube with Spark' with the following error : "" 18/10/23 09:25:39 INFO scheduler.DAGScheduler: Job 0 failed: saveAsNewAPIHadoopDataset at SparkCubingByLayer.java:253, took 7,277136 s Exception in thread "main" java.lang.RuntimeException: error execute org.apache.kylin.engine.spark.SparkCubingByLayer. Root cause: Job aborted due to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: Lost task 0.3 in stage 0.0 (TID 4, ip-172-31-35-113.eu-west-1.compute.internal, executor 4): java.lang.NumberFormatException: For input string: "\N" at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043) at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110) at java.lang.Double.parseDouble(Double.java:538) at org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:38) at org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:28) at org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueOf(BaseCuboidBuilder.java:162) at org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueObjects(BaseCuboidBuilder.java:127) at org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:297) at org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:257) at org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) at org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) " Note 1: the build process is OK when run with Map/Reduce Engine. Note 2: the error doesn't seem to be related to AWS environment. Sample of csv : ID;CATEGORIE;TEL;MONTANT;MAGASIN;MATRICULE;VILLE; 970;161;6-98-6-6-42;838.47034;Magasin_19;Client_Matricule_28;MARSEILLE; 971;89;62-15-2-64-86;;;Client_Matricule_1;LYON; 972;87;17-64-97-74-42;;;Client_Matricule_105;ORBEC; 973;174;79-33-90-0-55;;Magasin_7;Client_Matricule_55;AJACCIO; 974;172;89-95-71-6-49;141.64174;Magasin_9;Client_Matricule_105;BASTIA; 975;83;7-27-95-28-7;897.28204;;Client_Matricule_199;AJACCIO; 976;170;67-72-18-29-34;164.07967;Magasin_3;Client_Matricule_137;LILLE; 977;130;14-69-4-23-27;1928.9557;Magasin_1;Client_Matricule_17;NOMNOM; 978;43;55-91-84-98-49;891.2691;Magasin_0;Client_Matricule_22;NOMNOM; 979;117;98-96-0-54-39;1636.3994;Magasin_9;Client_Matricule_142;MARSEILLE; 980;163;37-55-76-53-38;;;Client_Matricule_64;NEWYORK; 981;106;32-40-6-46-15;;Magasin_2;Client_Matricule_158;NOMNOM; 982;56;95-60-83-89-90;;;Client_Matricule_102;NOMNOM; 983;168;21-56-62-0-58;;;Client_Matricule_160;NOMNOM; 984;154;92-67-37-94-60;;;Client_Matricule_137;PARIS; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3644) NumberFormatExcetion on null values when building cube with Spark
[ https://issues.apache.org/jira/browse/KYLIN-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hubert STEFANI updated KYLIN-3644: -- Attachment: 01_overview_table.jpg 02_dimension_cube.jpg 03_measure_cube.jpg > NumberFormatExcetion on null values when building cube with Spark > - > > Key: KYLIN-3644 > URL: https://issues.apache.org/jira/browse/KYLIN-3644 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: v2.5.0 >Reporter: Hubert STEFANI >Priority: Major > Attachments: 01_overview_table.jpg, 02_dimension_cube.jpg, > 03_measure_cube.jpg > > > We encounter an error any time we try to build a cube with the following > steps : > * upload a csv on AWS S3 with following characteristics : the column on > which the measure will be defined has some null values (Cf. attachment) > * create a hive table with spark > * create a model on top of this table, > * create a cube with a SUM measure > * chose Spark as Engine > * Launch build > Result : The build process fails at '{color:#4383b4}#7 Step Name: > {color}Build Cube with Spark' with the following error : > > "" > 18/10/23 09:25:39 INFO scheduler.DAGScheduler: Job 0 failed: > saveAsNewAPIHadoopDataset at SparkCubingByLayer.java:253, took 7,277136 s > Exception in thread "main" java.lang.RuntimeException: error execute > org.apache.kylin.engine.spark.SparkCubingByLayer. Root cause: Job aborted due > to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: > Lost task 0.3 in stage 0.0 (TID 4, > ip-172-31-35-113.eu-west-1.compute.internal, executor 4): > java.lang.NumberFormatException: For input string: "\N" > at > sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043) > at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110) > at java.lang.Double.parseDouble(Double.java:538) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:38) > at > org.apache.kylin.measure.basic.DoubleIngester.valueOf(DoubleIngester.java:28) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueOf(BaseCuboidBuilder.java:162) > at > org.apache.kylin.engine.mr.common.BaseCuboidBuilder.buildValueObjects(BaseCuboidBuilder.java:127) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:297) > at > org.apache.kylin.engine.spark.SparkCubingByLayer$EncodeBaseCuboid.call(SparkCubingByLayer.java:257) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > at > org.apache.spark.api.java.JavaPairRDD$$anonfun$pairFunToScalaFun$1.apply(JavaPairRDD.scala:1043) > " > Note 1: the build process is OK when run with Map/Reduce Engine. > Note 2: the error doesn't seem to be related to AWS environment. > > Sample of csv : > ID;CATEGORIE;TEL;MONTANT;MAGASIN;MATRICULE;VILLE; > 970;161;6-98-6-6-42;838.47034;Magasin_19;Client_Matricule_28;MARSEILLE; > 971;89;62-15-2-64-86;;;Client_Matricule_1;LYON; > 972;87;17-64-97-74-42;;;Client_Matricule_105;ORBEC; > 973;174;79-33-90-0-55;;Magasin_7;Client_Matricule_55;AJACCIO; > 974;172;89-95-71-6-49;141.64174;Magasin_9;Client_Matricule_105;BASTIA; > 975;83;7-27-95-28-7;897.28204;;Client_Matricule_199;AJACCIO; > 976;170;67-72-18-29-34;164.07967;Magasin_3;Client_Matricule_137;LILLE; > 977;130;14-69-4-23-27;1928.9557;Magasin_1;Client_Matricule_17;NOMNOM; > 978;43;55-91-84-98-49;891.2691;Magasin_0;Client_Matricule_22;NOMNOM; > 979;117;98-96-0-54-39;1636.3994;Magasin_9;Client_Matricule_142;MARSEILLE; > 980;163;37-55-76-53-38;;;Client_Matricule_64;NEWYORK; > 981;106;32-40-6-46-15;;Magasin_2;Client_Matricule_158;NOMNOM; > 982;56;95-60-83-89-90;;;Client_Matricule_102;NOMNOM; > 983;168;21-56-62-0-58;;;Client_Matricule_160;NOMNOM; > 984;154;92-67-37-94-60;;;Client_Matricule_137;PARIS; > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] shaofengshi closed pull request #301: KYLIN-3633 Avoid potential dead lock when building global dictionary
shaofengshi closed pull request #301: KYLIN-3633 Avoid potential dead lock when building global dictionary URL: https://github.com/apache/kylin/pull/301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java index db0c302970..7c33b4a1e4 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java @@ -75,13 +75,19 @@ public static IDictionaryBuilder newDictionaryBuilder(DataType dataType) { builder.init(dictInfo, baseId, null); // add values -while (valueEnumerator.moveNext()) { -String value = valueEnumerator.current(); +try { +while (valueEnumerator.moveNext()) { +String value = valueEnumerator.current(); -boolean accept = builder.addValue(value); +boolean accept = builder.addValue(value); -if (accept && samples.size() < nSamples && samples.contains(value) == false) -samples.add(value); +if (accept && samples.size() < nSamples && samples.contains(value) == false) +samples.add(value); +} +} catch (IOException e) { +logger.error("Error during adding dict value.", e); +builder.clear(); +throw e; } // build @@ -149,6 +155,12 @@ public boolean addValue(String value) { return new DateStrDictionary(datePattern, baseId); } + + +@Override +public void clear() { +// do nothing +} } private static class TimeDictBuilder implements IDictionaryBuilder { @@ -171,6 +183,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return new TimeStrDictionary(); // base ID is always 0 } + +@Override +public void clear() { + +} } private static class StringTrieDictBuilder implements IDictionaryBuilder { @@ -196,6 +213,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(baseId); } + +@Override +public void clear() { + +} } private static class StringTrieDictForestBuilder implements IDictionaryBuilder { @@ -219,6 +241,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(); } + +@Override +public void clear() { + +} } @SuppressWarnings("deprecation") @@ -245,6 +272,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(baseId); } + +@Override +public void clear() { + +} } private static class NumberTrieDictForestBuilder implements IDictionaryBuilder { @@ -268,6 +300,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(); } + +@Override +public void clear() { + +} } } diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java b/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java index 9168ca4a1a..d813793ea1 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java @@ -19,8 +19,8 @@ package org.apache.kylin.dict; import java.io.IOException; - import java.util.Locale; + import org.apache.kylin.common.KylinConfig; import org.apache.kylin.common.lock.DistributedLock; import org.apache.kylin.common.util.Dictionary; @@ -104,6 +104,13 @@ public boolean addValue(String value) { return new AppendTrieDictionary<>(); } +@Override +public void clear() { +if (lock.isLocked(getLockPath(sourceColumn))) { +lock.unlock(getLockPath(sourceColumn)); +} +} + private String getLockPath(String pathName) { return "/dict/" + pathName + "/lock"; } diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/IDictionaryBuilder.java b/core-dictionary/src/main/java/org/apache/kylin/dict/IDictionaryBuilder.java index e2a643dbd0..771bfb42c6 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/IDictionaryBuilder.java +++
[jira] [Commented] (KYLIN-3633) Dead lock may happen in building global dictionary
[ https://issues.apache.org/jira/browse/KYLIN-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660643#comment-16660643 ] ASF GitHub Bot commented on KYLIN-3633: --- shaofengshi closed pull request #301: KYLIN-3633 Avoid potential dead lock when building global dictionary URL: https://github.com/apache/kylin/pull/301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java index db0c302970..7c33b4a1e4 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java @@ -75,13 +75,19 @@ public static IDictionaryBuilder newDictionaryBuilder(DataType dataType) { builder.init(dictInfo, baseId, null); // add values -while (valueEnumerator.moveNext()) { -String value = valueEnumerator.current(); +try { +while (valueEnumerator.moveNext()) { +String value = valueEnumerator.current(); -boolean accept = builder.addValue(value); +boolean accept = builder.addValue(value); -if (accept && samples.size() < nSamples && samples.contains(value) == false) -samples.add(value); +if (accept && samples.size() < nSamples && samples.contains(value) == false) +samples.add(value); +} +} catch (IOException e) { +logger.error("Error during adding dict value.", e); +builder.clear(); +throw e; } // build @@ -149,6 +155,12 @@ public boolean addValue(String value) { return new DateStrDictionary(datePattern, baseId); } + + +@Override +public void clear() { +// do nothing +} } private static class TimeDictBuilder implements IDictionaryBuilder { @@ -171,6 +183,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return new TimeStrDictionary(); // base ID is always 0 } + +@Override +public void clear() { + +} } private static class StringTrieDictBuilder implements IDictionaryBuilder { @@ -196,6 +213,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(baseId); } + +@Override +public void clear() { + +} } private static class StringTrieDictForestBuilder implements IDictionaryBuilder { @@ -219,6 +241,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(); } + +@Override +public void clear() { + +} } @SuppressWarnings("deprecation") @@ -245,6 +272,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(baseId); } + +@Override +public void clear() { + +} } private static class NumberTrieDictForestBuilder implements IDictionaryBuilder { @@ -268,6 +300,11 @@ public boolean addValue(String value) { public Dictionary build() throws IOException { return builder.build(); } + +@Override +public void clear() { + +} } } diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java b/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java index 9168ca4a1a..d813793ea1 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java @@ -19,8 +19,8 @@ package org.apache.kylin.dict; import java.io.IOException; - import java.util.Locale; + import org.apache.kylin.common.KylinConfig; import org.apache.kylin.common.lock.DistributedLock; import org.apache.kylin.common.util.Dictionary; @@ -104,6 +104,13 @@ public boolean addValue(String value) { return new AppendTrieDictionary<>(); } +@Override +public void clear() { +if (lock.isLocked(getLockPath(sourceColumn))) { +lock.unlock(getLockPath(sourceColumn)); +} +} + private String getLockPath(String pathName) { return "/dict/" + pathName + "/lock"; } diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/IDictionaryBuilder.java
[jira] [Issue Comment Deleted] (KYLIN-2898) Introduce memcached as a distributed cache for queries
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-2898: -- Comment: was deleted (was: If a distributed cache is adopted, it's better to set the bar *kylin.query.cache-threshold-duration* for query cache to 0, which means to put query result to cache as much as possible.) > Introduce memcached as a distributed cache for queries > -- > > Key: KYLIN-2898 > URL: https://issues.apache.org/jira/browse/KYLIN-2898 > Project: Kylin > Issue Type: Sub-task > Components: Query Engine >Affects Versions: v2.1.0 >Reporter: Zhong Yanghong >Assignee: Wang Ken >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660483#comment-16660483 ] Zhong Yanghong commented on KYLIN-2898: --- If a distributed cache is adopted, small query results are also better to be put into the cache. > Introduce memcached as a distributed cache for queries > -- > > Key: KYLIN-2898 > URL: https://issues.apache.org/jira/browse/KYLIN-2898 > Project: Kylin > Issue Type: Sub-task > Components: Query Engine >Affects Versions: v2.1.0 >Reporter: Zhong Yanghong >Assignee: Wang Ken >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3633) Dead lock may happen in building global dictionary
[ https://issues.apache.org/jira/browse/KYLIN-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660644#comment-16660644 ] ASF subversion and git services commented on KYLIN-3633: Commit 8b51d4a0cd8c33ded5bb380885a731c381da710d in kylin's branch refs/heads/master from [~nichunen] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=8b51d4a ] KYLIN-3633 Avoid potential dead lock when building global dictionary > Dead lock may happen in building global dictionary > -- > > Key: KYLIN-3633 > URL: https://issues.apache.org/jira/browse/KYLIN-3633 > Project: Kylin > Issue Type: Bug > Components: Measure - Count Distinct >Affects Versions: v2.4.1 >Reporter: nichunen >Assignee: nichunen >Priority: Major > Fix For: v2.5.1 > > > During the building of global dict, if an error happens, the builder's lock > maybe un-released. This will block all other building jobs with global dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] codecov-io commented on issue #302: KYLIN-3620 resolve "--" is treated as comment marker between singe qu…
codecov-io commented on issue #302: KYLIN-3620 resolve "--" is treated as comment marker between singe qu… URL: https://github.com/apache/kylin/pull/302#issuecomment-432266197 # [Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8b51d4a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/302/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/302?src=pr=tree) ```diff @@Coverage Diff@@ ## master #302 +/- ## = Coverage ? 21.32% Complexity? 4446 = Files ? 1089 Lines ?69996 Branches ?10098 = Hits ?14925 Misses?53668 Partials ? 1403 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/302?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/302/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.44% <100%> (ø)` | `19 <2> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=footer). Last update [8b51d4a...f5e89c2](https://codecov.io/gh/apache/kylin/pull/302?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3620) "--" should not be a comment marker use between single quotes in SQL
[ https://issues.apache.org/jira/browse/KYLIN-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660721#comment-16660721 ] ASF GitHub Bot commented on KYLIN-3620: --- codecov-io commented on issue #302: KYLIN-3620 resolve "--" is treated as comment marker between singe qu… URL: https://github.com/apache/kylin/pull/302#issuecomment-432266197 # [Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8b51d4a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/302/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/302?src=pr=tree) ```diff @@Coverage Diff@@ ## master #302 +/- ## = Coverage ? 21.32% Complexity? 4446 = Files ? 1089 Lines ?69996 Branches ?10098 = Hits ?14925 Misses?53668 Partials ? 1403 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/302?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/302/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.44% <100%> (ø)` | `19 <2> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr=footer). Last update [8b51d4a...f5e89c2](https://codecov.io/gh/apache/kylin/pull/302?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > "--" should not be a comment marker use between single quotes in SQL > > > Key: KYLIN-3620 > URL: https://issues.apache.org/jira/browse/KYLIN-3620 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v2.4.1 >Reporter: Scott Fan >Assignee: Lijun Cao >Priority: Major > Fix For: v2.6.0 > > > Hi, > When I exec a SQL like below, there was an error. > SELECT * FROM TABLEA WHERE NAME='Jason--Arthur' > Seems like KYLIN use the – as a comment marker. > It should not be that between single quotes, I think. > > Even I send a REST POST contains SQL like that, or do an ODBC query, there > was an error too. > You may tell me that I can use a \ as escape, but I can't change the SQL > generated by BI tools like tableau. > Thanks > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-2894) Change the query cache expiration strategy by signature checking
[ https://issues.apache.org/jira/browse/KYLIN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong reassigned KYLIN-2894: - Assignee: Wang Ken (was: Zhong Yanghong) > Change the query cache expiration strategy by signature checking > > > Key: KYLIN-2894 > URL: https://issues.apache.org/jira/browse/KYLIN-2894 > Project: Kylin > Issue Type: Sub-task > Components: Query Engine >Reporter: Zhong Yanghong >Assignee: Wang Ken >Priority: Major > > Currently to invalid query cache, {{CacheService}} will either invoke > {{cleanDataCache}} or {{cleanAllDataCache}}. Both methods will clear all of > the query cache, which is very inefficient. In eBay PROD environment, there's > around 400 cubing jobs per day, which means the query cache will be cleared > very 4 minutes. Then we introduced a signature based cache invalidation > strategy. The basic idea is as follows: > * Add a signature for {{SQLResponse}}, here we choose the cube last build time > * When fetch {{SQLResponse}} for cache, first check whether the signature is > consistent. If not, this cached value is overdue and will be invalidate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
[ https://issues.apache.org/jira/browse/KYLIN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rongchuan.jin reassigned KYLIN-3645: Assignee: rongchuan.jin > Kylin does not clean table metadata when drop project(Kafka Source) > --- > > Key: KYLIN-3645 > URL: https://issues.apache.org/jira/browse/KYLIN-3645 > Project: Kylin > Issue Type: Bug > Components: Metadata, Streaming >Affects Versions: v2.4.1 > Environment: jdk1.8 > MacOS >Reporter: rongchuan.jin >Assignee: rongchuan.jin >Priority: Minor > Fix For: v2.5.1 > > > When I use Kafka streaming,there is a bug. My steps: > 1.Create a project named p1 > 2.Import a kafka table named DEFAULT.T1 > 3.drop project p1 > 4.create project p2 > 5.Import a kafka table named DEFAULT.T1 > It comes out an error: > The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2200) CompileException on UNION ALL query when result only contains one column
[ https://issues.apache.org/jira/browse/KYLIN-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661539#comment-16661539 ] ASF GitHub Bot commented on KYLIN-2200: --- asfgit commented on issue #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl… URL: https://github.com/apache/kylin/pull/307#issuecomment-432473261 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CompileException on UNION ALL query when result only contains one column > > > Key: KYLIN-2200 > URL: https://issues.apache.org/jira/browse/KYLIN-2200 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v1.5.4.1 >Reporter: Dayue Gao >Assignee: Dayue Gao >Priority: Major > Fix For: v2.5.1 > > Attachments: KYLIN-2200.patch > > > {code:sql} > select count(*) from kylin_sales > union all > select count(*) from kylin_sales > {code} > got following exception > {noformat} > Caused by: org.codehaus.commons.compiler.CompileException: Line 82, Column > 32: Cannot determine simple type name "Record11_1" > at > org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:10092) > at > org.codehaus.janino.UnitCompiler.getReferenceType(UnitCompiler.java:5375) > at > org.codehaus.janino.UnitCompiler.getReferenceType(UnitCompiler.java:5184) > at org.codehaus.janino.UnitCompiler.getType2(UnitCompiler.java:5165) > at > org.codehaus.janino.UnitCompiler.access$12600(UnitCompiler.java:183) > at > org.codehaus.janino.UnitCompiler$16.visitReferenceType(UnitCompiler.java:5096) > at org.codehaus.janino.Java$ReferenceType.accept(Java.java:2880) > at org.codehaus.janino.UnitCompiler.getType(UnitCompiler.java:5136) > at org.codehaus.janino.UnitCompiler.getType2(UnitCompiler.java:5598) > at > org.codehaus.janino.UnitCompiler.access$13300(UnitCompiler.java:183) > at > org.codehaus.janino.UnitCompiler$16.visitCast(UnitCompiler.java:5104) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit commented on issue #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl…
asfgit commented on issue #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl… URL: https://github.com/apache/kylin/pull/307#issuecomment-432473261 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GinaZhai opened a new pull request #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl…
GinaZhai opened a new pull request #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl… URL: https://github.com/apache/kylin/pull/307 …y contains one column and add IT. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
[ https://issues.apache.org/jira/browse/KYLIN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661651#comment-16661651 ] ASF GitHub Bot commented on KYLIN-3645: --- woyumen4597 opened a new pull request #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kylin does not clean table metadata when drop project(Kafka Source) > --- > > Key: KYLIN-3645 > URL: https://issues.apache.org/jira/browse/KYLIN-3645 > Project: Kylin > Issue Type: Bug > Components: Metadata, Streaming >Affects Versions: v2.4.1 > Environment: jdk1.8 > MacOS >Reporter: rongchuan.jin >Assignee: rongchuan.jin >Priority: Minor > Fix For: v2.5.1 > > > When I use Kafka streaming,there is a bug. My steps: > 1.Create a project named p1 > 2.Import a kafka table named DEFAULT.T1 > 3.drop project p1 > 4.create project p2 > 5.Import a kafka table named DEFAULT.T1 > It comes out an error: > The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] woyumen4597 opened a new pull request #308: #KYLIN-3645 clean table metadata when drop project
woyumen4597 opened a new pull request #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #308: #KYLIN-3645 clean table metadata when drop project
asfgit commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432495070 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-2200) CompileException on UNION ALL query when result only contains one column
[ https://issues.apache.org/jira/browse/KYLIN-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661537#comment-16661537 ] ASF GitHub Bot commented on KYLIN-2200: --- GinaZhai opened a new pull request #307: KYLIN-2200 Verify CompileException on UNION ALL query when result onl… URL: https://github.com/apache/kylin/pull/307 …y contains one column and add IT. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CompileException on UNION ALL query when result only contains one column > > > Key: KYLIN-2200 > URL: https://issues.apache.org/jira/browse/KYLIN-2200 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v1.5.4.1 >Reporter: Dayue Gao >Assignee: Dayue Gao >Priority: Major > Fix For: v2.5.1 > > Attachments: KYLIN-2200.patch > > > {code:sql} > select count(*) from kylin_sales > union all > select count(*) from kylin_sales > {code} > got following exception > {noformat} > Caused by: org.codehaus.commons.compiler.CompileException: Line 82, Column > 32: Cannot determine simple type name "Record11_1" > at > org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:10092) > at > org.codehaus.janino.UnitCompiler.getReferenceType(UnitCompiler.java:5375) > at > org.codehaus.janino.UnitCompiler.getReferenceType(UnitCompiler.java:5184) > at org.codehaus.janino.UnitCompiler.getType2(UnitCompiler.java:5165) > at > org.codehaus.janino.UnitCompiler.access$12600(UnitCompiler.java:183) > at > org.codehaus.janino.UnitCompiler$16.visitReferenceType(UnitCompiler.java:5096) > at org.codehaus.janino.Java$ReferenceType.accept(Java.java:2880) > at org.codehaus.janino.UnitCompiler.getType(UnitCompiler.java:5136) > at org.codehaus.janino.UnitCompiler.getType2(UnitCompiler.java:5598) > at > org.codehaus.janino.UnitCompiler.access$13300(UnitCompiler.java:183) > at > org.codehaus.janino.UnitCompiler$16.visitCast(UnitCompiler.java:5104) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
[ https://issues.apache.org/jira/browse/KYLIN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661652#comment-16661652 ] ASF GitHub Bot commented on KYLIN-3645: --- asfgit commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432495070 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kylin does not clean table metadata when drop project(Kafka Source) > --- > > Key: KYLIN-3645 > URL: https://issues.apache.org/jira/browse/KYLIN-3645 > Project: Kylin > Issue Type: Bug > Components: Metadata, Streaming >Affects Versions: v2.4.1 > Environment: jdk1.8 > MacOS >Reporter: rongchuan.jin >Assignee: rongchuan.jin >Priority: Minor > Fix For: v2.5.1 > > > When I use Kafka streaming,there is a bug. My steps: > 1.Create a project named p1 > 2.Import a kafka table named DEFAULT.T1 > 3.drop project p1 > 4.create project p2 > 5.Import a kafka table named DEFAULT.T1 > It comes out an error: > The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
rongchuan.jin created KYLIN-3645: Summary: Kylin does not clean table metadata when drop project(Kafka Source) Key: KYLIN-3645 URL: https://issues.apache.org/jira/browse/KYLIN-3645 Project: Kylin Issue Type: Bug Components: Metadata, Streaming Affects Versions: v2.4.1 Environment: jdk1.8 MacOS Reporter: rongchuan.jin Fix For: v2.5.1 When I use Kafka streaming,there is a bug. My steps: 1.Create a project named p1 2.Import a kafka table named DEFAULT.T1 3.drop project p1 4.create project p2 5.Import a kafka table named DEFAULT.T1 It comes out an error: The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] codecov-io commented on issue #299: Apache kylin 2895 updated
codecov-io commented on issue #299: Apache kylin 2895 updated URL: https://github.com/apache/kylin/pull/299#issuecomment-432494678 # [Codecov](https://codecov.io/gh/apache/kylin/pull/299?src=pr=h1) Report > Merging [#299](https://codecov.io/gh/apache/kylin/pull/299?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/8b51d4a0cd8c33ded5bb380885a731c381da710d?src=pr=desc) will **increase** coverage by `0.25%`. > The diff coverage is `34.38%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/299/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/299?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #299 +/- ## + Coverage 21.31% 21.57% +0.25% - Complexity 4448 4580 +132 Files 1089 +22 Lines 6999671151+1155 Branches 1009810281 +183 + Hits 1492215353 +431 - Misses5367154326 +655 - Partials 1403 1472 +69 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/299?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/kylin/cache/cachemanager/CacheConstants.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9DYWNoZUNvbnN0YW50cy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.39% <0%> (-0.25%)` | `36 <0> (ø)` | | | [.../kylin/cache/ehcache/InstrumentedEhCacheCache.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2VoY2FjaGUvSW5zdHJ1bWVudGVkRWhDYWNoZUNhY2hlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...org/apache/kylin/common/debug/BackdoorToggles.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9kZWJ1Zy9CYWNrZG9vclRvZ2dsZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/cache/memcached/CacheStats.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9DYWNoZVN0YXRzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...in/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL0N1YmVIQmFzZUVuZHBvaW50UlBDLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/kylin/cache/memcached/MemcachedMetrics.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRNZXRyaWNzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...kylin/storage/hbase/cube/v2/SegmentQueryCache.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL1NlZ21lbnRRdWVyeUNhY2hlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ain/java/org/apache/kylin/common/QueryContext.java](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [48 more](https://codecov.io/gh/apache/kylin/pull/299/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/299?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/299?src=pr=footer). Last update [8b51d4a...b2e0f0e](https://codecov.io/gh/apache/kylin/pull/299?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message,
[GitHub] coveralls commented on issue #299: Apache kylin 2895 updated
coveralls commented on issue #299: Apache kylin 2895 updated URL: https://github.com/apache/kylin/pull/299#issuecomment-432494780 ## Pull Request Test Coverage Report for [Build 3802](https://coveralls.io/builds/19685691) * **484** of **1201** **(40.3%)** changed or added relevant lines in **29** files are covered. * **9** unchanged lines in **5** files lost coverage. * Overall coverage increased (+**0.3%**) to **23.65%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [cache/src/main/java/org/apache/kylin/cache/cachemanager/CacheConstants.java](https://coveralls.io/builds/19685691/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fcachemanager%2FCacheConstants.java#L21) | 0 | 1 | 0.0% | [cache/src/main/java/org/apache/kylin/cache/cachemanager/RemoteLocalFailOverCacheManager.java](https://coveralls.io/builds/19685691/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fcachemanager%2FRemoteLocalFailOverCacheManager.java#L49) | 12 | 13 | 92.31% | [core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/19685691/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L90) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/response/SQLResponse.java](https://coveralls.io/builds/19685691/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fresponse%2FSQLResponse.java#L227) | 7 | 8 | 87.5% | [server-base/src/main/java/org/apache/kylin/rest/signature/SegmentSignature.java](https://coveralls.io/builds/19685691/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsignature%2FSegmentSignature.java#L31) | 17 | 18 | 94.44% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/SegmentQueryResult.java](https://coveralls.io/builds/19685691/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FSegmentQueryResult.java#L48) | 28 | 29 | 96.55% | [cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedConnectionFactoryBuilder.java](https://coveralls.io/builds/19685691/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fmemcached%2FMemcachedConnectionFactoryBuilder.java#L69) | 25 | 28 | 89.29% | [server-base/src/main/java/org/apache/kylin/rest/service/CacheService.java](https://coveralls.io/builds/19685691/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCacheService.java#L120) | 0 | 4 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/signature/RealizationSetCalculator.java](https://coveralls.io/builds/19685691/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsignature%2FRealizationSetCalculator.java#L46) | 28 | 34 | 82.35% | [cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedCacheConfig.java](https://coveralls.io/builds/19685691/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcache%2Fmemcached%2FMemcachedCacheConfig.java#L63) | 20 | 28 | 71.43% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-common/src/main/java/org/apache/kylin/common/QueryContext.java](https://coveralls.io/builds/19685691/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FQueryContext.java#L273) | 1 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://coveralls.io/builds/19685691/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FCubeHBaseEndpointRPC.java#L247) | 1 | 0.0% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19685691/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19685691/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/19685691/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L448) | 3 | 0.0% | | Totals | [![Coverage Status](https://coveralls.io/builds/19685691/badge)](https://coveralls.io/builds/19685691) | | :-- | --: | | Change from base [Build 3801](https://coveralls.io/builds/19685049): | 0.3% | | Covered Lines: | 16827 | | Relevant Lines: | 71151 | --- # -
[GitHub] codecov-io commented on issue #308: #KYLIN-3645 clean table metadata when drop project
codecov-io commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432498572 # [Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=h1) Report > Merging [#308](https://codecov.io/gh/apache/kylin/pull/308?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/8b51d4a0cd8c33ded5bb380885a731c381da710d?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/308/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/308?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #308 +/- ## + Coverage 21.31% 21.32% +<.01% + Complexity 4448 4447 -1 Files 1089 1089 Lines 699967 +4 Branches 1009810099 +1 + Hits 1492214926 +4 - Misses5367153672 +1 + Partials 1403 1402 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/308?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/kylin/rest/service/ProjectService.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Qcm9qZWN0U2VydmljZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (+0.3%)` | `7% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=footer). Last update [8b51d4a...a4f0744](https://codecov.io/gh/apache/kylin/pull/308?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
[ https://issues.apache.org/jira/browse/KYLIN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661671#comment-16661671 ] ASF GitHub Bot commented on KYLIN-3645: --- codecov-io commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432498572 # [Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=h1) Report > Merging [#308](https://codecov.io/gh/apache/kylin/pull/308?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/8b51d4a0cd8c33ded5bb380885a731c381da710d?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/308/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/308?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #308 +/- ## + Coverage 21.31% 21.32% +<.01% + Complexity 4448 4447 -1 Files 1089 1089 Lines 699967 +4 Branches 1009810099 +1 + Hits 1492214926 +4 - Misses5367153672 +1 + Partials 1403 1402 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/308?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/kylin/rest/service/ProjectService.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Qcm9qZWN0U2VydmljZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (+0.3%)` | `7% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/308/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/308?src=pr=footer). Last update [8b51d4a...a4f0744](https://codecov.io/gh/apache/kylin/pull/308?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kylin does not clean table metadata when drop project(Kafka Source) > --- > > Key: KYLIN-3645 > URL: https://issues.apache.org/jira/browse/KYLIN-3645 > Project: Kylin > Issue Type: Bug > Components: Metadata, Streaming >Affects Versions: v2.4.1 > Environment: jdk1.8 > MacOS >Reporter: rongchuan.jin >Assignee: rongchuan.jin >Priority: Minor > Fix For: v2.5.1 > > > When I use Kafka streaming,there is a bug. My steps: > 1.Create a project named p1 > 2.Import a kafka table named DEFAULT.T1 > 3.drop project p1 > 4.create project p2 > 5.Import a kafka table named DEFAULT.T1 > It comes out an error: > The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3645) Kylin does not clean table metadata when drop project(Kafka Source)
[ https://issues.apache.org/jira/browse/KYLIN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661673#comment-16661673 ] ASF GitHub Bot commented on KYLIN-3645: --- coveralls commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432498959 ## Pull Request Test Coverage Report for [Build 3803](https://coveralls.io/builds/19685945) * **0** of **4** **(0.0%)** changed or added relevant lines in **1** file are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.003%**) to **23.329%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/19685945/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L139) | 0 | 4 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19685945/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/19685945/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L143) | 2 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19685945/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [![Coverage Status](https://coveralls.io/builds/19685945/badge)](https://coveralls.io/builds/19685945) | | :-- | --: | | Change from base [Build 3801](https://coveralls.io/builds/19685049): | 0.003% | | Covered Lines: | 16330 | | Relevant Lines: | 7 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kylin does not clean table metadata when drop project(Kafka Source) > --- > > Key: KYLIN-3645 > URL: https://issues.apache.org/jira/browse/KYLIN-3645 > Project: Kylin > Issue Type: Bug > Components: Metadata, Streaming >Affects Versions: v2.4.1 > Environment: jdk1.8 > MacOS >Reporter: rongchuan.jin >Assignee: rongchuan.jin >Priority: Minor > Fix For: v2.5.1 > > > When I use Kafka streaming,there is a bug. My steps: > 1.Create a project named p1 > 2.Import a kafka table named DEFAULT.T1 > 3.drop project p1 > 4.create project p2 > 5.Import a kafka table named DEFAULT.T1 > It comes out an error: > The Streaming Config DEFAULT.T1 already exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] coveralls commented on issue #308: #KYLIN-3645 clean table metadata when drop project
coveralls commented on issue #308: #KYLIN-3645 clean table metadata when drop project URL: https://github.com/apache/kylin/pull/308#issuecomment-432498959 ## Pull Request Test Coverage Report for [Build 3803](https://coveralls.io/builds/19685945) * **0** of **4** **(0.0%)** changed or added relevant lines in **1** file are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.003%**) to **23.329%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/19685945/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L139) | 0 | 4 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19685945/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/19685945/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L143) | 2 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19685945/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [![Coverage Status](https://coveralls.io/builds/19685945/badge)](https://coveralls.io/builds/19685945) | | :-- | --: | | Change from base [Build 3801](https://coveralls.io/builds/19685049): | 0.003% | | Covered Lines: | 16330 | | Relevant Lines: | 7 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services