[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #316: Bump guice from 5.1.0 to 7.0.0
dependabot[bot] opened a new pull request, #316:
URL: https://github.com/apache/maven-indexer/pull/316
Bumps [guice](https://github.com/google/guice) from 5.1.0 to 7.0.0.
Release notes
Sourced from https://github.com/google/guice/releases";>guice's releases.
Guice 7.0.0
See https://github.com/google/guice/wiki/Guice700";>https://github.com/google/guice/wiki/Guice700
for release notes.
Guice 7.0.0-rc1
See https://github.com/google/guice/wiki/Guice700";>https://github.com/google/guice/wiki/Guice700
for release notes.
Guice 6.0.0
See https://github.com/google/guice/wiki/Guice600";>https://github.com/google/guice/wiki/Guice600
for release notes.
Guice 6.0.0-rc2
See https://github.com/google/guice/wiki/Guice600";>https://github.com/google/guice/wiki/Guice600
for release notes.
Commits
https://github.com/google/guice/commit/b0e1d0fab0167cd555ab8d262333c1a32db7d492";>b0e1d0f
set 7.0.0 release #s.
https://github.com/google/guice/commit/f4a66b797ecc05d80406d6c8fb11e6cc0e5c6d21";>f4a66b7
Make error_prone_annotations dependency optional
https://github.com/google/guice/commit/654032a954d55a00fc5ee90da815da98cb6676a1";>654032a
Internal change.
https://github.com/google/guice/commit/bee813b7cc15e46695ca1baf5041a00e0a612f91";>bee813b
Improve MissingImplementationError to lazily calculate suggestions and
standa...
https://github.com/google/guice/commit/2d64067e99401e50404c6e05a819bce891b725de";>2d64067
Use linked bindings for MapBinder/Multibinder/OptionalBinder aliases,
instead...
https://github.com/google/guice/commit/be0141cc0d01763a13ec0b2fcd32ddbe0748ad6d";>be0141c
Internal change
https://github.com/google/guice/commit/40a5bcfab5cfe45c3b6c5ffc9309b310df82775b";>40a5bcf
Avoid re-initializing factories that are already initialized. This is
necessa...
https://github.com/google/guice/commit/9ac476784e88f4481f8211dcb19ac536f5f2b32d";>9ac4767
Change the way we reference what 6.0 supports in the README, so it doesn't
ge...
https://github.com/google/guice/commit/24324ca6c61f64872376ed7f4ed22a3f1f0724f1";>24324ca
Prepare for the Guice 6.0 & 7.0 releases. This change does the
following:
https://github.com/google/guice/commit/49b1a33c594fd92ad0d1d013fa91d689e8814a6c";>49b1a33
Remove redundant references to javax.{inject,persistence,servlet} and
replace...
Additional commits viewable in https://github.com/google/guice/compare/5.1.0...7.0.0";>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722643#comment-17722643
]
Henning Schmiedehausen commented on MPMD-368:
-
The build tool throwing warnings fails CI builds in a lot of organizations (it
does so in mine and in previous places that I worked). It may not fail at the
actual tool level but the CI harness detects warnings and fails the build.
Upgrading the tools in the tool chain is independent from the actual code.
Often the code developers don't even have control over the build pipeline or
the tools that are used. Having a build suddenly throw warnings that are
completely unrelated to the code itself but because of the combination of build
tool and build plugins without any actionable advice *and* doing so in a patch
level change is problematic from my PoV.
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final
CrazyHZM commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193303091
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -383,4 +390,15 @@ void testMng7644() {
checkVersionsEqual("2.0." + x, "2.0.0." + x); // previously
ordered, now equals
}
}
+
+@Test
+public void testMng7714() {
+String f = "1.0.final-redhat";
+String sp1 = "1.0-sp1-redhat";
+String sp2 = "1.0-sp-1-redhat";
+String sp3 = "1.0-sp.1-redhat";
+checkVersionsOrder(f, sp1);
Review Comment:
I think it's possible to restandardize and redefine the approach to these
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final
CrazyHZM commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193301912
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -147,10 +154,10 @@ void testVersionsEqual() {
checkVersionsEqual("1.0.0x", "1-x");
// aliases
-checkVersionsEqual("1ga", "1");
-checkVersionsEqual("1release", "1");
-checkVersionsEqual("1final", "1");
-checkVersionsEqual("1cr", "1rc");
+checkVersionsEqualOrder("1ga", "1");
Review Comment:
Because there was a previous case where `final` was replaced with an empty
string and the hash comparison was different, I don't think this change will
affect anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final
CrazyHZM commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193300875
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -619,7 +748,13 @@ public final void parseVersion(String version) {
}
private static Item parseItem(boolean isDigit, String buf) {
-if (isDigit) {
+return parseItem(false, isDigit, buf);
+}
+
+private static Item parseItem(boolean isCombination, boolean isDigit,
String buf) {
Review Comment:
This is the previous name, I think try not to change this name in this
change, it will cause trouble to code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final
CrazyHZM commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193299946
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -422,6 +436,106 @@ public String toString() {
}
}
+/**
+ * Represents a combination in the version item list.
+ * It is usually a combination of a string and a number, with the string
first and the number second
+ */
+private static class CombinationItem implements Item {
+
+StringItem stringValue;
+
+Item digitValue;
+
+CombinationItem(String v) {
+int index = 0;
+for (int i = 0; i < v.length(); i++) {
+char c = v.charAt(i);
+if (Character.isDigit(c)) {
Review Comment:
It is part of the CombinationItem, as well as part of the version, and
should not be discarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final
CrazyHZM commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193297450
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -199,6 +202,7 @@ public int compareTo(Item item) {
return -1;
case STRING_ITEM:
+case COMBINATION_ITEM:
Review Comment:
What does `every case` mean, it's just a comparison of `LONG_ITEM` and
`COMBINATION_ITEM`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722624#comment-17722624
]
Lenny Primak commented on MRELEASE-1123:
[~michael-o] Doesn't work with alpha-2 either. Alpha 1 is not available in the
archives.
So, it doesn't work with any of the maven 4 alphas.
Thank you!
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run
[ https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722604#comment-17722604 ] Olivier Lamy commented on MINVOKER-336: --- [~sjaranowski] yes sounds like a good workaround idea. > .mvn/extensions.xml from main project is used in it projects run > > > Key: MINVOKER-336 > URL: https://issues.apache.org/jira/browse/MINVOKER-336 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.5.1 >Reporter: Olivier Lamy >Priority: Major > > if the main project contains some extensions in the top directory > .mvn/extensions.xml this directory will be used in IT projects run. > sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat > algorithm to find .mvn directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1547011760 I'm OK with the first two bullets. Third one I don't understand what do you mean by colspan. Do you mean to center vertically the result to cover compile,runtime and provided rows? like HTML table "rowspan" attribute? I'm OK if it shows clearly and there is no confusion regarding if it is a total covering the 3 non-test scopes, or it is just one of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCHECKSTYLE-436) Replace CheckstyleReportGenerator with a new CheckstyleReportRenderer
Michael Osipov created MCHECKSTYLE-436: -- Summary: Replace CheckstyleReportGenerator with a new CheckstyleReportRenderer Key: MCHECKSTYLE-436 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-436 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 3.2.2 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPMD-375) Replace *ReportGenerators with new *ReportRenderers
[ https://issues.apache.org/jira/browse/MPMD-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPMD-375: Summary: Replace *ReportGenerators with new *ReportRenderers (was: Replace *ReportGenerators with a new *ReportRenderers) > Replace *ReportGenerators with new *ReportRenderers > --- > > Key: MPMD-375 > URL: https://issues.apache.org/jira/browse/MPMD-375 > Project: Maven PMD Plugin > Issue Type: Improvement >Affects Versions: 3.20.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.21.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-checkstyle-plugin] michael-o opened a new pull request, #117: [MCHECKSTYLE-435] Remove deprecated RSS feature
michael-o opened a new pull request, #117: URL: https://github.com/apache/maven-checkstyle-plugin/pull/117 This closes #117 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINVOKER-338) Bump groovy-bom from 4.0.10 to 4.0.12
[ https://issues.apache.org/jira/browse/MINVOKER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-338. Resolution: Fixed > Bump groovy-bom from 4.0.10 to 4.0.12 > - > > Key: MINVOKER-338 > URL: https://issues.apache.org/jira/browse/MINVOKER-338 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MCHECKSTYLE-435) Remove deprecated RSS feature
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MPMD-378 to MCHECKSTYLE-435: - Fix Version/s: 3.3.0 (was: 3.21.0) Key: MCHECKSTYLE-435 (was: MPMD-378) Affects Version/s: 3.2.2 (was: 3.20.0) Project: Maven Checkstyle Plugin (was: Maven PMD Plugin) > Remove deprecated RSS feature > - > > Key: MCHECKSTYLE-435 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-435 > Project: Maven Checkstyle Plugin > Issue Type: Task >Affects Versions: 3.2.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINVOKER-338) Bump groovy-bom from 4.0.10 to 4.0.12
Slawomir Jaranowski created MINVOKER-338: Summary: Bump groovy-bom from 4.0.10 to 4.0.12 Key: MINVOKER-338 URL: https://issues.apache.org/jira/browse/MINVOKER-338 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run
[ https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722597#comment-17722597 ] Slawomir Jaranowski commented on MINVOKER-336: -- As workaround for algorithm in Maven scripts we can create empty dir .mvn in each test project if not exist > .mvn/extensions.xml from main project is used in it projects run > > > Key: MINVOKER-336 > URL: https://issues.apache.org/jira/browse/MINVOKER-336 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.5.1 >Reporter: Olivier Lamy >Priority: Major > > if the main project contains some extensions in the top directory > .mvn/extensions.xml this directory will be used in IT projects run. > sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat > algorithm to find .mvn directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINVOKER-337) Plugin depends on plexus-container-default, which is EOL
Slawomir Jaranowski created MINVOKER-337:
Summary: Plugin depends on plexus-container-default, which is EOL
Key: MINVOKER-337
URL: https://issues.apache.org/jira/browse/MINVOKER-337
Project: Maven Invoker Plugin
Issue Type: Bug
Reporter: Slawomir Jaranowski
We should exclude {{plexus-container-default}} from dependencies to avoid
warning by Maven 3.9.2
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPMD-378) Remove deprecated RSS feature
Michael Osipov created MPMD-378: --- Summary: Remove deprecated RSS feature Key: MPMD-378 URL: https://issues.apache.org/jira/browse/MPMD-378 Project: Maven PMD Plugin Issue Type: Task Affects Versions: 3.20.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.21.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722595#comment-17722595
]
Michael Osipov commented on MPMD-368:
-
[~henning], I don't understand why this warning is a pain? Have you set
"fail-on-warning"?
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722594#comment-17722594
]
Michael Osipov edited comment on MPMD-368 at 5/14/23 5:39 PM:
--
I have removed the fix version because it cannot be solved w/o upgrading to the
entire Doxia 2.0.0 stack. The field is in Maven Reporting Impl. One needs to
wait until I have prepared all of our plugins. Here is the actual change:
MSHARED-1210
was (Author: michael-o):
I have removed the fix version because it cannot be solved w/o upgrading to the
entire Doxia 2.0.0 stack. The field is in Maven Reporting Impl. One needs to
wait until I have prepared all of our plugins.
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722594#comment-17722594
]
Michael Osipov commented on MPMD-368:
-
I have removed the fix version because it cannot be solved w/o upgrading to the
entire Doxia 2.0.0 stack. The field is in Maven Reporting Impl. One needs to
wait until I have prepared all of our plugins.
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MPMD-368:
Fix Version/s: (was: 3.21.1)
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1546954576 Here is my counter-proposal based on your output:  We will keep one column for the Java version, but here is the diff: * Total `test` row will have its own value, it will change position with `compile` * Grand total will contain Java version of all scopes * Non-`test` scopes will colspan with max Java version WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MPMD-368:
---
Fix Version/s: 3.21.1
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.21.1
>
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MPMD-368:
---
Affects Version/s: 3.20.0
3.21.0
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPIR-437) 'Java version' is set to 0.0 when no JDK details are detected in dependencies
[ https://issues.apache.org/jira/browse/MPIR-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-437. --- Resolution: Fixed Fixed with [9209a7a175041ba1b2e6902f6f2dbb247a96529d|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=9209a7a175041ba1b2e6902f6f2dbb247a96529d]. > 'Java version' is set to 0.0 when no JDK details are detected in dependencies > - > > Key: MPIR-437 > URL: https://issues.apache.org/jira/browse/MPIR-437 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.3 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > Attachments: image-2023-05-11-22-20-45-789.png > > > Column 'Java version' in the summary row prints '0.0' when no JDK details are > detected in dependencies. Should print a '-' to be uniform with the remainder > of items in the table. > !image-2023-05-11-22-20-45-789.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] asfgit closed pull request #51: [MPIR-437] 'Java version' is set to 0.0 when no JDK details are detected
asfgit closed pull request #51: [MPIR-437] 'Java version' is set to 0.0 when no JDK details are detected URL: https://github.com/apache/maven-project-info-reports-plugin/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Moved] (MCHECKSTYLE-434) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MPMD-377 to MCHECKSTYLE-434: - Fix Version/s: 3.3.0 (was: 3.21.0) Key: MCHECKSTYLE-434 (was: MPMD-377) Project: Maven Checkstyle Plugin (was: Maven PMD Plugin) > Upgrade plugins and components (in ITs) > --- > > Key: MCHECKSTYLE-434 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-434 > Project: Maven Checkstyle Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.3.0 > > > * Upgrade to Maven Compiler Plugin 3.11.0 > * Upgrade to Build Helper Maven Plugin 3.4.0 > * Upgrade to Plexus Utils 3.5.1 > * Upgrade to Maven Wagon 3.5.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPMD-377) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MPMD-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-377. --- Resolution: Fixed Fixed with [71bc1ff6201bb437a6440b097a6e30ec5bcc55be|https://gitbox.apache.org/repos/asf?p=maven-checkstyle-plugin.git;a=commit;h=71bc1ff6201bb437a6440b097a6e30ec5bcc55be]. > Upgrade plugins and components (in ITs) > --- > > Key: MPMD-377 > URL: https://issues.apache.org/jira/browse/MPMD-377 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.21.0 > > > * Upgrade to Maven Compiler Plugin 3.11.0 > * Upgrade to Build Helper Maven Plugin 3.4.0 > * Upgrade to Plexus Utils 3.5.1 > * Upgrade to Maven Wagon 3.5.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPMD-377) Upgrade plugins and components (in ITs)
Michael Osipov created MPMD-377: --- Summary: Upgrade plugins and components (in ITs) Key: MPMD-377 URL: https://issues.apache.org/jira/browse/MPMD-377 Project: Maven PMD Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.21.0 * Upgrade to Maven Compiler Plugin 3.11.0 * Upgrade to Build Helper Maven Plugin 3.4.0 * Upgrade to Plexus Utils 3.5.1 * Upgrade to Maven Wagon 3.5.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shade-plugin] timtebeek commented on pull request #187: [MNG-6829] Replace StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek commented on PR #187: URL: https://github.com/apache/maven-shade-plugin/pull/187#issuecomment-1546950212 Interesting failure mode here: ``` Running post-build script: /home/runner/work/maven-shade-plugin/maven-shade-plugin/target/it/MSHADE-36-inject-dep-reduced-pom-in-final/verify.bsh java.lang.IllegalStateException: wanted path is missing: com/example/shaded/org/codehaus/plexus/util/StringUtils.class ``` https://github.com/apache/maven-shade-plugin/blob/f15f26b1b8100d0c3bfa15b9e8b233922432ee15/src/it/projects/MSHADE-36-inject-dep-reduced-pom-in-final/verify.bsh#L62-L64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pdf-plugin] elharo merged pull request #40: Bump maven-shared-utils from 3.3.4 to 3.4.1
elharo merged PR #40: URL: https://github.com/apache/maven-pdf-plugin/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-linkcheck-plugin] dependabot[bot] closed pull request #3: Bump commons-io from 2.5 to 2.7
dependabot[bot] closed pull request #3: Bump commons-io from 2.5 to 2.7 URL: https://github.com/apache/maven-linkcheck-plugin/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] elharo commented on pull request #166: [SECURITY] Fix Temporary File Information Disclosure Vulnerability
elharo commented on PR #166: URL: https://github.com/apache/maven-shade-plugin/pull/166#issuecomment-1546945315 If you merge with head, I can approve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHADE-443) Fix problems with shadeSourcesContent
[
https://issues.apache.org/jira/browse/MSHADE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MSHADE-443:
-
Fix Version/s: 3.5.0
> Fix problems with shadeSourcesContent
> -
>
> Key: MSHADE-443
> URL: https://issues.apache.org/jira/browse/MSHADE-443
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0, 3.4.1
>Reporter: Alexander Kriegisch
>Priority: Major
> Fix For: 3.5.0
>
>
> *History:* Initially, I improved {{shadeSourcesContent}} in MSHADE-252. In
> MSHADE-396, [~Reamer] suggested some improvements, which I picked up and
> improved. Alas, I did not improve his PR enough, but it went unnoticed,
> because my other project was until today still using a private release of
> Maven Shade, which contained some of my other fixes which I was at the time
> waiting to be merged. Now they have been merged, so I switched to 3.4.1, only
> to notice that now some code which was shaded correctly with MSHADE-252,
> broke due to MSHADE-396.
> Source code shading being an imperfect, heuristic search & replace process,
> there will never be a perfect solution, unless we create full parsers for
> different JVM languages, Java being but one of them. Anyway, for one of my
> Java projects which creates Javadoc for relocated sources, I noticed several
> shortcomings and improved source shading for them.
> Fully qualified names are now matched correctly
> * after keywords {{extends}}, {{implements}} and {{throws}}, in addition to
> the keywords already matched previously,
> * after any of opening curly brace, opening parenthesis, comma, equals,
> semicolon, closing curly brace, closing multi-line comment, if whitespace
> follows (without whitespace there was no problem).
> All of the above were problems I met in real life when shading and relocating
> packages from Eclipse JDT Core for use in AspectJ.
> I also adjusted the existing {{SimpleRelocatorTest}} in order to test some of
> these cases at least in smoke test fashion. All other tests are still green,
> so I can reasonably hope not to have broken anything in a serious way. Like I
> said, souce relocation is a best-effort thing anyway, nobody should rely on
> it 100%.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSHADE-443) Fix problems with shadeSourcesContent
[
https://issues.apache.org/jira/browse/MSHADE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MSHADE-443.
> Fix problems with shadeSourcesContent
> -
>
> Key: MSHADE-443
> URL: https://issues.apache.org/jira/browse/MSHADE-443
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0, 3.4.1
>Reporter: Alexander Kriegisch
>Priority: Major
> Fix For: 3.5.0
>
>
> *History:* Initially, I improved {{shadeSourcesContent}} in MSHADE-252. In
> MSHADE-396, [~Reamer] suggested some improvements, which I picked up and
> improved. Alas, I did not improve his PR enough, but it went unnoticed,
> because my other project was until today still using a private release of
> Maven Shade, which contained some of my other fixes which I was at the time
> waiting to be merged. Now they have been merged, so I switched to 3.4.1, only
> to notice that now some code which was shaded correctly with MSHADE-252,
> broke due to MSHADE-396.
> Source code shading being an imperfect, heuristic search & replace process,
> there will never be a perfect solution, unless we create full parsers for
> different JVM languages, Java being but one of them. Anyway, for one of my
> Java projects which creates Javadoc for relocated sources, I noticed several
> shortcomings and improved source shading for them.
> Fully qualified names are now matched correctly
> * after keywords {{extends}}, {{implements}} and {{throws}}, in addition to
> the keywords already matched previously,
> * after any of opening curly brace, opening parenthesis, comma, equals,
> semicolon, closing curly brace, closing multi-line comment, if whitespace
> follows (without whitespace there was no problem).
> All of the above were problems I met in real life when shading and relocating
> packages from Eclipse JDT Core for use in AspectJ.
> I also adjusted the existing {{SimpleRelocatorTest}} in order to test some of
> these cases at least in smoke test fashion. All other tests are still green,
> so I can reasonably hope not to have broken anything in a serious way. Like I
> said, souce relocation is a best-effort thing anyway, nobody should rely on
> it 100%.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MSHADE-443) Fix problems with shadeSourcesContent
[
https://issues.apache.org/jira/browse/MSHADE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MSHADE-443.
--
Resolution: Fixed
> Fix problems with shadeSourcesContent
> -
>
> Key: MSHADE-443
> URL: https://issues.apache.org/jira/browse/MSHADE-443
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0, 3.4.1
>Reporter: Alexander Kriegisch
>Priority: Major
>
> *History:* Initially, I improved {{shadeSourcesContent}} in MSHADE-252. In
> MSHADE-396, [~Reamer] suggested some improvements, which I picked up and
> improved. Alas, I did not improve his PR enough, but it went unnoticed,
> because my other project was until today still using a private release of
> Maven Shade, which contained some of my other fixes which I was at the time
> waiting to be merged. Now they have been merged, so I switched to 3.4.1, only
> to notice that now some code which was shaded correctly with MSHADE-252,
> broke due to MSHADE-396.
> Source code shading being an imperfect, heuristic search & replace process,
> there will never be a perfect solution, unless we create full parsers for
> different JVM languages, Java being but one of them. Anyway, for one of my
> Java projects which creates Javadoc for relocated sources, I noticed several
> shortcomings and improved source shading for them.
> Fully qualified names are now matched correctly
> * after keywords {{extends}}, {{implements}} and {{throws}}, in addition to
> the keywords already matched previously,
> * after any of opening curly brace, opening parenthesis, comma, equals,
> semicolon, closing curly brace, closing multi-line comment, if whitespace
> follows (without whitespace there was no problem).
> All of the above were problems I met in real life when shading and relocating
> packages from Eclipse JDT Core for use in AspectJ.
> I also adjusted the existing {{SimpleRelocatorTest}} in order to test some of
> these cases at least in smoke test fashion. All other tests are still green,
> so I can reasonably hope not to have broken anything in a serious way. Like I
> said, souce relocation is a best-effort thing anyway, nobody should rely on
> it 100%.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #167: Bump maven-dependency-tree from 3.2.0 to 3.2.1
dependabot[bot] closed pull request #167: Bump maven-dependency-tree from 3.2.0 to 3.2.1 URL: https://github.com/apache/maven-shade-plugin/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCHECKSTYLE-428) Upgrade parent POM to version 39
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-428. -- Resolution: Fixed Fixed with [d96baba4df00e3e0f254445e21bbaf3560438f55|https://gitbox.apache.org/repos/asf?p=maven-checkstyle-plugin.git;a=commit;h=d96baba4df00e3e0f254445e21bbaf3560438f55]. > Upgrade parent POM to version 39 > > > Key: MCHECKSTYLE-428 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-428 > Project: Maven Checkstyle Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #51: [MPIR-437] 'Java version' is set to 0.0 when no JDK details are detected
belingueres commented on PR #51: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/51#issuecomment-1546940119 No objections. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] michael-o opened a new pull request, #116: Mcheckstyle 428
michael-o opened a new pull request, #116: URL: https://github.com/apache/maven-checkstyle-plugin/pull/116 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MCHECKSTYLE-428) Upgrade parent POM to version 39
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MCHECKSTYLE-428: -- Assignee: Michael Osipov > Upgrade parent POM to version 39 > > > Key: MCHECKSTYLE-428 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-428 > Project: Maven Checkstyle Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #51: [MPIR-437] 'Java version' is set to 0.0 when no JDK details are detected
michael-o commented on PR #51: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/51#issuecomment-1546911711 I am going to merge this later this day or tomorrow if you don't have any objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] timtebeek opened a new pull request, #318: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek opened a new pull request, #318: URL: https://github.com/apache/maven-dependency-plugin/pull/318 Continuation of https://issues.apache.org/jira/browse/MNG-6829 Use this link to re-run the recipe: https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk?organizationId=QXBhY2hlIE1hdmVu Review requested of @elharo Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722473#comment-17722473
]
Slawomir Jaranowski commented on MRELEASE-1123:
---
There are more problem when I try build with Maven 4 - I have created a draft PR
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] slawekjaranowski opened a new pull request, #186: Try build with Maven 4
slawekjaranowski opened a new pull request, #186: URL: https://github.com/apache/maven-release/pull/186 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRELEASE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MRELEASE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski merged pull request #148: [MPOM-406] Bump surefire.version from 3.0.0 to 3.1.0
slawekjaranowski merged PR #148: URL: https://github.com/apache/maven-apache-parent/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] timtebeek commented on a diff in pull request #146: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek commented on code in PR #146:
URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122378
##
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/creation/DefaultArchetypeCreationConfigurator.java:
##
@@ -144,7 +144,7 @@ public Properties configureArchetypeCreation( MavenProject
project, Boolean inte
getLogger().debug( "Asking for project's package" );
archetypeConfiguration.setProperty(
Constants.PACKAGE,
-
archetypeCreationQueryer.getPackage( StringUtils.isEmpty( resolvedPackage ) ?
archetypeConfiguration.getDefaultValue( Constants.PACKAGE )
+
archetypeCreationQueryer.getPackage( (resolvedPackage == null ||
resolvedPackage.isEmpty()) ? archetypeConfiguration.getDefaultValue(
Constants.PACKAGE )
Review Comment:
```suggestion
archetypeCreationQueryer.getPackage( ( resolvedPackage == null ||
resolvedPackage.isEmpty() ) ? archetypeConfiguration.getDefaultValue(
Constants.PACKAGE )
```
##
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java:
##
@@ -210,7 +210,7 @@ else if ( archetypeArtifactManager.isOldArchetype(
ad.getGroupId(), ad.getArtifa
{
String defaultValue =
archetypeConfiguration.getDefaultValue( requiredProperty );
-if ( Constants.PACKAGE.equals( requiredProperty )
&& StringUtils.isEmpty( defaultValue ) )
+if ( Constants.PACKAGE.equals( requiredProperty )
&& (defaultValue == null || defaultValue.isEmpty()) )
Review Comment:
```suggestion
if ( Constants.PACKAGE.equals( requiredProperty
) && ( defaultValue == null || defaultValue.isEmpty() ) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-archetype] timtebeek commented on a diff in pull request #146: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek commented on code in PR #146: URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122274 ## archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java: ## @@ -569,7 +569,7 @@ private void processFilesetModule( final String rootArtifactId, final String art processFilesetModule( rootArtifactId, moduleArtifactId, archetypeResources, new File( moduleOutputDirectoryFile, Constants.ARCHETYPE_POM ), archetypeZipFile, - ( StringUtils.isEmpty( moduleOffset ) ? "" : ( moduleOffset + "/" ) ) + ( (moduleOffset == null || moduleOffset.isEmpty()) ? "" : ( moduleOffset + "/" ) ) Review Comment: ```suggestion ( ( moduleOffset == null || moduleOffset.isEmpty() ) ? "" : ( moduleOffset + "/" ) ) ``` ## archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java: ## @@ -415,7 +414,7 @@ static boolean matchesLayout( String repoLayout, String mirrorLayout ) boolean result = false; // simple checks first to short circuit processing below. -if ( StringUtils.isEmpty( mirrorLayout ) || WILDCARD.equals( mirrorLayout ) ) +if ( (mirrorLayout == null || mirrorLayout.isEmpty()) || WILDCARD.equals( mirrorLayout ) ) Review Comment: ```suggestion if ( ( mirrorLayout == null || mirrorLayout.isEmpty() ) || WILDCARD.equals( mirrorLayout ) ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request, #73: Maven 3.9.2 as default
slawekjaranowski opened a new pull request, #73: URL: https://github.com/apache/maven-gh-actions-shared/pull/73 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] timtebeek commented on a diff in pull request #146: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek commented on code in PR #146:
URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122130
##
archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeFilesResolver.java:
##
@@ -71,7 +71,7 @@ public List getFilteredFiles( List files,
String filtered )
public List filterFiles( String moduleOffset, FileSet fileSet,
List archetypeResources )
{
ListScanner scanner = new ListScanner();
-scanner.setBasedir( ( StringUtils.isEmpty( moduleOffset ) ? "" : (
moduleOffset + File.separatorChar ) )
+scanner.setBasedir( ( (moduleOffset == null || moduleOffset.isEmpty())
? "" : ( moduleOffset + File.separatorChar ) )
Review Comment:
```suggestion
scanner.setBasedir( ( ( moduleOffset == null ||
moduleOffset.isEmpty() ) ? "" : ( moduleOffset + File.separatorChar ) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722463#comment-17722463
]
Herve Boutemy commented on MRELEASE-1123:
-
download page updated https://maven.apache.org/download.cgi : I hope it will be
easier to use (feedback appreciated, even if I know that it's not really the
objective of this Jira issue...)
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722460#comment-17722460
]
Herve Boutemy commented on MRELEASE-1123:
-
oh, working on improving that page, I just saw that I sent wrong link for Maven
4 releases: good one is https://archive.apache.org/dist/maven/maven-4/
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722457#comment-17722457
]
Herve Boutemy edited comment on MRELEASE-1123 at 5/14/23 8:04 AM:
--
https://archive.apache.org/dist/maven/maven-3/
(it's the "archives link" in "Older Previous Releases"
https://maven.apache.org/download.cgi#older-previous-releases , but you're
right that it's not really easy to find in the page
having 3 full blown download sections for Maven 3.8, 3.9 and 4 alpha is too
chatty, IMHO. Any idea/PR on improving the situation is welcome)
was (Author: hboutemy):
https://archive.apache.org/dist/maven/maven-3/
(it's the "archives link" in "Older Previous Releases"
https://maven.apache.org/download.cgi#older-previous-releases , but you're
right that it's not really easy to find in the page
having 2 download sections for Maven 3.8 and 3.9 is too chatty, IMHO. Any
idea/PR on improving the situation is welcome)
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1123) Maven Release plugin doesn't work in maven 4
[
https://issues.apache.org/jira/browse/MRELEASE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722457#comment-17722457
]
Herve Boutemy commented on MRELEASE-1123:
-
https://archive.apache.org/dist/maven/maven-3/
(it's the "archives link" in "Older Previous Releases"
https://maven.apache.org/download.cgi#older-previous-releases , but you're
right that it's not really easy to find in the page
having 2 download sections for Maven 3.8 and 3.9 is too chatty, IMHO. Any
idea/PR on improving the situation is welcome)
> Maven Release plugin doesn't work in maven 4
>
>
> Key: MRELEASE-1123
> URL: https://issues.apache.org/jira/browse/MRELEASE-1123
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.0.0
> Environment: Any
>Reporter: Lenny Primak
>Priority: Blocker
>
> {code:java}
> mvn -B -ntp -C release:prepare release:perform{code}
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare (default-cli) on
> project flowlogix: Unable to parse configuration of mojo
> org.apache.maven.plugins:maven-release-plugin:3.0.0:prepare for parameter
> projectVersionPolicyConfig: Cannot set 'projectVersionPolicyConfig' in class
> org.apache.maven.plugins.release.PrepareReleaseMojo: Can not set
> org.codehaus.plexus.configuration.xml.XmlPlexusConfiguration field
> org.apache.maven.plugins.release.PrepareReleaseMojo.projectVersionPolicyConfig
> to org.apache.maven.internal.xml.XmlPlexusConfiguration -> [Help 1]{code}
> Maven 4.0.0-alpha-5 and release plugin 3.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
