Re: [PR] Bump org.junit.jupiter:junit-jupiter-api from 5.10.1 to 5.10.2 [maven-wrapper]
slachiewicz merged PR #122: URL: https://github.com/apache/maven-wrapper/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.26.0 to 1.26.1 [maven-shade-plugin]
slachiewicz merged PR #217: URL: https://github.com/apache/maven-shade-plugin/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.2 [maven-surefire]
dependabot[bot] commented on PR #720: URL: https://github.com/apache/maven-surefire/pull/720#issuecomment-2003047125 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.2 [maven-surefire]
slachiewicz closed pull request #720: Bump org.junit:junit-bom from 5.9.3 to 5.10.2 URL: https://github.com/apache/maven-surefire/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit5Version from 5.9.3 to 5.10.2 [maven-surefire]
dependabot[bot] commented on PR #726: URL: https://github.com/apache/maven-surefire/pull/726#issuecomment-2003046736 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit5Version from 5.9.3 to 5.10.2 [maven-surefire]
slachiewicz closed pull request #726: Bump junit5Version from 5.9.3 to 5.10.2 URL: https://github.com/apache/maven-surefire/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-remote-resources-plugin]
slachiewicz merged PR #56: URL: https://github.com/apache/maven-remote-resources-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:extra-enforcer-rules from 1.7.0 to 1.8.0 [maven-site]
slachiewicz merged PR #502: URL: https://github.com/apache/maven-site/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jmock:jmock from 2.12.0 to 2.13.0 [maven-indexer]
dependabot[bot] closed pull request #355: Bump org.jmock:jmock from 2.12.0 to 2.13.0 URL: https://github.com/apache/maven-indexer/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jmock:jmock from 2.12.0 to 2.13.0 [maven-indexer]
dependabot[bot] commented on PR #355: URL: https://github.com/apache/maven-indexer/pull/355#issuecomment-2002914814 Superseded by #357. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.jmock:jmock from 2.12.0 to 2.13.1 [maven-indexer]
dependabot[bot] opened a new pull request, #357: URL: https://github.com/apache/maven-indexer/pull/357 Bumps [org.jmock:jmock](https://github.com/jmock-developers/jmock-library) from 2.12.0 to 2.13.1. Release notes Sourced from https://github.com/jmock-developers/jmock-library/releases";>org.jmock:jmock's releases. 2.13.1 Catchup on versions and PRs What's Changed Update README.md by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/246";>jmock-developers/jmock-library#246 Updated README instructions for using JMock in Gradle 7.0+. by https://github.com/jbrains";>@jbrains in https://redirect.github.com/jmock-developers/jmock-library/pull/233";>jmock-developers/jmock-library#233 Reduce logging by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/247";>jmock-developers/jmock-library#247 Fix https://redirect.github.com/jmock-developers/jmock-library/issues/155";>#155 by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/250";>jmock-developers/jmock-library#250 Upgrade junit4 by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/251";>jmock-developers/jmock-library#251 Bump junit.jupiter.version from 5.5.2 to 5.6.2 by https://github.com/dependabot-preview";>@dependabot-preview in https://redirect.github.com/jmock-developers/jmock-library/pull/183";>jmock-developers/jmock-library#183 Upgrade to GitHub-native Dependabot by https://github.com/dependabot-preview";>@dependabot-preview in https://redirect.github.com/jmock-developers/jmock-library/pull/218";>jmock-developers/jmock-library#218 Prepare for merge queue by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/262";>jmock-developers/jmock-library#262 DeterministicScheduler: Future is done if cancelled by https://github.com/leonz";>@leonz in https://redirect.github.com/jmock-developers/jmock-library/pull/237";>jmock-developers/jmock-library#237 Bump org.apache.maven.plugins:maven-jar-plugin from 2.5 to 3.3.0 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/256";>jmock-developers/jmock-library#256 Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.0.0-M2 to 3.4.1 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/257";>jmock-developers/jmock-library#257 Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.2.0 to 3.6.3 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/258";>jmock-developers/jmock-library#258 Bump org.apache.maven.plugins:maven-failsafe-plugin from 2.22.2 to 3.2.5 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/261";>jmock-developers/jmock-library#261 Dependabot ignore old junit runners by https://github.com/olibye";>@olibye in https://redirect.github.com/jmock-developers/jmock-library/pull/263";>jmock-developers/jmock-library#263 Bump net.bytebuddy:byte-buddy from 1.10.9 to 1.14.12 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/252";>jmock-developers/jmock-library#252 Bump org.objenesis:objenesis from 3.1 to 3.3 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/255";>jmock-developers/jmock-library#255 Bump org.codehaus.mojo:versions-maven-plugin from 2.7 to 2.16.2 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/253";>jmock-developers/jmock-library#253 Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/259";>jmock-developers/jmock-library#259 Bump org.sonatype.plugins:nexus-staging-maven-plugin from 1.6.8 to 1.6.13 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/260";>jmock-developers/jmock-library#260 Bump junit.jupiter.version from 5.6.2 to 5.10.2 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/264";>jmock-developers/jmock-library#264 Bump com.thoughtworks.qdox:qdox from 2.0-M10 to 2.1.0 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/265";>jmock-developers/jmock-library#265 Bump org.apache.maven.plugins:maven-surefire-plugin from 2.22.2 to 3.2.5 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/jmock-developers/jmock-library/pull/267";>jmock-developers/
[jira] [Commented] (MNG-8069) Message "This project has been banned from the build due to previous failures." is too unspecific
[
https://issues.apache.org/jira/browse/MNG-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827822#comment-17827822
]
ASF GitHub Bot commented on MNG-8069:
-
elharo commented on code in PR #1435:
URL: https://github.com/apache/maven/pull/1435#discussion_r1527655423
##
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+MavenSession session = event.getSession();
+MavenExecutionResult result = session.getResult();
+ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+List upstreamProjects;
+if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+&& projectDependencyGraph != null) {
+
+// the project is blacklisted only so one of its upstreams
must have failed here...
+upstreamProjects =
projectDependencyGraph.getUpstreamProjects(event.getProject(), true);
+} else {
+// any other failure must have lead to this so any projects is
eligible
Review Comment:
are eligible
##
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+MavenSession session = event.getSession();
+MavenExecutionResult result = session.getResult();
+ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+List upstreamProjects;
+if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+&& projectDependencyGraph != null) {
+
+// the project is blacklisted only so one of its upstreams
must have failed here...
Review Comment:
I can't quite follow this comment, please rephrase
> Message "This project has been banned from the build due to previous
> failures." is too unspecific
> -
>
> Key: MNG-8069
> URL: https://issues.apache.org/jira/browse/MNG-8069
> Project: Maven
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently if a multimodule build fails (either fast or at the end), the user
> gets a message in the log that reads:
> {quote}This project has been banned from the build due to previous
> failures.{quote}
>
> this is correct but does not give a hint *what* has failed and one needs to
> investigate the build logs to get more details.
> Instead the message should show the actual project that make it impossible to
> build this and is the reason fro this project being banned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8069] add failing projects if a project is banned from reactor [maven]
elharo commented on code in PR #1435:
URL: https://github.com/apache/maven/pull/1435#discussion_r1527655423
##
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+MavenSession session = event.getSession();
+MavenExecutionResult result = session.getResult();
+ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+List upstreamProjects;
+if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+&& projectDependencyGraph != null) {
+
+// the project is blacklisted only so one of its upstreams
must have failed here...
+upstreamProjects =
projectDependencyGraph.getUpstreamProjects(event.getProject(), true);
+} else {
+// any other failure must have lead to this so any projects is
eligible
Review Comment:
are eligible
##
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+MavenSession session = event.getSession();
+MavenExecutionResult result = session.getResult();
+ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+List upstreamProjects;
+if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+&& projectDependencyGraph != null) {
+
+// the project is blacklisted only so one of its upstreams
must have failed here...
Review Comment:
I can't quite follow this comment, please rephrase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Typo fixes: remove repetitive words [maven]
elharo merged PR #1436: URL: https://github.com/apache/maven/pull/1436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ognl:ognl from 2.5.1 to 3.0.12 in /maven-compat/src/test/resources [maven]
elharo merged PR #1439: URL: https://github.com/apache/maven/pull/1439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8078) BOM warnings are emitted on scopes and exclusions
Lenny Primak created MNG-8078:
-
Summary: BOM warnings are emitted on scopes and exclusions
Key: MNG-8078
URL: https://issues.apache.org/jira/browse/MNG-8078
Project: Maven
Issue Type: Bug
Components: Core, Errors
Affects Versions: 4.0.0-alpha-13
Environment: Any
Reporter: Lenny Primak
There a couple of scenarios that are generating warnings that should not:
* BOM dependency entries that have a different scope
* BOM dependency entries that have exclusions
There are many scenarios where multiple BOMs declare the same dependency
versions, although in slightly different ways. Many of these are transient, and
very hard to figure out in the first place. Warnings lead to multiple
unnecessary exclusions and are forcing modifications to POM where they are not
needed.
The above entries should not generate a warning, because the dependencies are
not conflicting.
Examples (BOM):
{code:java}
...
org.junit.jupiter
junit-jupiter-api
${junit.version}
test
org.junit.jupiter
junit-jupiter-params
${junit.version}
test
org.junit.jupiter
junit-jupiter-engine
${junit.version}
test
...
{code}
Warnings:
{code:java}
[WARNING] Some problems were encountered while building the effective model for
'com.flowlogix:hope-website:war:1.x-SNAPSHOT'
[WARNING] Ignored POM import for: org.slf4j:jcl-over-slf4j:jar:2.0.12@test as
already imported org.slf4j:jcl-over-slf4j:jar:2.0.12@compile. Add a the
conflicting managed dependency directly to the dependencyManagement section of
the POM.
WARNING] Ignored POM import for: net.bytebuddy:byte-buddy:jar:1.14.12@compile[1
exclusions] as already imported net.bytebuddy:byte-buddy:jar:1.14.12@compile.
Add a the conflicting managed dependency directly to the dependencyManagement
section of the POM.
[WARNING] Ignored POM import for:
net.bytebuddy:byte-buddy-agent:jar:1.14.12@compile[1 exclusions] as already
imported net.bytebuddy:byte-buddy-agent:jar:1.14.12@compile. Add a the
conflicting managed dependency directly to the dependencyManagement section of
the POM.
[WARNING] Ignored POM import for:
org.junit.jupiter:junit-jupiter-api:jar:5.10.2@compile[1 exclusions] as already
imported org.junit.jupiter:junit-jupiter-api:jar:5.10.2@test. Add a the
conflicting managed dependency directly to the dependencyManagement section of
the POM.
[WARNING] Ignored POM import for:
org.junit.jupiter:junit-jupiter-engine:jar:5.10.2@compile[1 exclusions] as
already imported org.junit.jupiter:junit-jupiter-engine:jar:5.10.2@test. Add a
the conflicting managed dependency directly to the dependencyManagement section
of the POM.
[WARNING] Ignored POM import for:
org.junit.jupiter:junit-jupiter-params:jar:5.10.2@compile[1 exclusions] as
already imported org.junit.jupiter:junit-jupiter-params:jar:5.10.2@test. Add a
the conflicting managed dependency directly to the dependencyManagement section
of the POM. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.commons:commons-compress from 1.23.0 to 1.26.0 [maven-mvnd]
dependabot[bot] closed pull request #918: Bump org.apache.commons:commons-compress from 1.23.0 to 1.26.0 URL: https://github.com/apache/maven-mvnd/pull/918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.23.0 to 1.26.0 [maven-mvnd]
dependabot[bot] commented on PR #918: URL: https://github.com/apache/maven-mvnd/pull/918#issuecomment-2002537000 Looks like org.apache.commons:commons-compress is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update commons-compress to 1.26.1 [maven-mvnd]
slachiewicz merged PR #927: URL: https://github.com/apache/maven-mvnd/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-build-cache-extension]
slachiewicz merged PR #135: URL: https://github.com/apache/maven-build-cache-extension/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-wrapper]
slachiewicz merged PR #121: URL: https://github.com/apache/maven-wrapper/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-resources-plugin]
slachiewicz merged PR #67: URL: https://github.com/apache/maven-resources-plugin/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.26.0 to 1.26.1 [maven-surefire]
slachiewicz merged PR #727: URL: https://github.com/apache/maven-surefire/pull/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prefer https [maven-remote-resources-plugin]
slachiewicz merged PR #54: URL: https://github.com/apache/maven-remote-resources-plugin/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update commons-compress to 1.26.1 [maven-mvnd]
slachiewicz opened a new pull request, #927: URL: https://github.com/apache/maven-mvnd/pull/927 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.18 to 4.0.20 [maven-invoker-plugin]
slachiewicz merged PR #219: URL: https://github.com/apache/maven-invoker-plugin/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.activemq:apache-activemq from 5.16.0 to 5.16.6 in /integration-tests/src/test/projects/concurrent-downloads/mod1 [maven-mvnd]
slachiewicz merged PR #926: URL: https://github.com/apache/maven-mvnd/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-plugin-tools]
slachiewicz merged PR #267: URL: https://github.com/apache/maven-plugin-tools/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [maven-invoker-plugin]
slachiewicz merged PR #216: URL: https://github.com/apache/maven-invoker-plugin/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-116) Create interface method to catch exceptions
[
https://issues.apache.org/jira/browse/MCLEAN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1782#comment-1782
]
Slawomir Jaranowski commented on MCLEAN-116:
[~bukama] thanks for issue and PR
I assume that you PR resolve problem with propagating source exception in
{{Cleaner}} class.
So maybe we should change issue and commit subject to show what we do and what
is the problem.
Simply something like: "Propagate exception in Cleaner class"
> Create interface method to catch exceptions
> ---
>
> Key: MCLEAN-116
> URL: https://issues.apache.org/jira/browse/MCLEAN-116
> Project: Maven Clean Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.2
>Reporter: Matthias Bünger
>Priority: Minor
>
> As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface
> of this class does not provide a method to log exceptions and needs a
> refactoring
> {code:java}
> // ...
> if (logDebug != null) {
> // TODO: this Logger interface cannot log exceptions and
> needs refactoring
> logDebug.log("Unable to fast delete directory: " + e);
> }
> // ...
> private interface Logger {
> void log(CharSequence message);
> }
> {code}
> However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
> {{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
> interface instead an own could be a better solution than adding a new method
> to the interface in the {{Cleaner}} class.
> _This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
