[jira] [Created] (MJARSIGNER-76) Print names of processed files
Marcono1234 created MJARSIGNER-76:
-
Summary: Print names of processed files
Key: MJARSIGNER-76
URL: https://issues.apache.org/jira/browse/MJARSIGNER-76
Project: Maven Jar Signer Plugin
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Marcono1234
h2. Problem
Currently the plugin just prints the number of processed artifacts once it is
done, for example:
{quote}
2 archive(s) processed
{quote}
This has these disadvantages:
- It is not immediately obvious if the intended file has been signed (e.g. when
using wildcards)
- If the number is higher than expected, it is not obvious which additional
files were signed redundantly
In both cases it is necessary to manually inspect the artifacts of the project
and check if they have been signed (or use {{jarsigner}} to verify them).
h2. Improvement
By default the plugin should print the file names of the signed artifacts. This
information is already available in {{AbstractJarsignerMojo#execute}}, but
currently only {{archives.size()}} is logged.
- Ideally each file should be logged in a separate line to be easier to read.
- The relative file path (and not only the file name) should be logged.
Otherwise there might be confusion if the same file exists in multiple
directories, e.g. if it is copied by another plugin during the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Add `defaultValue` for all boolean Mojo parameters [maven-shade-plugin]
Marcono1234 commented on code in PR #219:
URL:
https://github.com/apache/maven-shade-plugin/pull/219#discussion_r1554398907
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -197,7 +197,7 @@ public class ShadeMojo extends AbstractMojo {
*
* If you like to change the name of the native artifact, you may use the
build>finalName> setting. If this
* is set to something different than build>finalName>, no file
replacement will be performed, even if
- * shadedArtifactAttached is being used.
+ * {@link #shadedArtifactAttached} is false.
Review Comment:
Is this change correct? If I understood it correctly, if
`` and the Mojo `` differ then the main project
artifact will not be replaced, even if `shadedArtifactAttached=false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Add `defaultValue` for all boolean Mojo parameters [maven-shade-plugin]
Marcono1234 opened a new pull request, #219: URL: https://github.com/apache/maven-shade-plugin/pull/219 Currently the Mojo documentation does not mention the default for these parameters, which will be confusing for the user. Have for example a look at the current https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html documentation; you will see that for all the changed parameters no default value is currently documented. So it is not clear whether these parameters apply by default. Please let me know if I forget to consider something and this change has any undesired side effects. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834415#comment-17834415
]
ASF GitHub Bot commented on MPMD-379:
-
adangel commented on code in PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1553758485
##
src/site/apt/examples/upgrading-PMD-at-runtime.apt.vm:
##
@@ -88,6 +88,8 @@ Upgrading PMD at Runtime
**--*
| <>
| <> |
**--*
+|
{{{https://maven.apache.org/plugins-archives/maven-pmd-plugin-3.22.0/}3.22.0}}
| {{{https://pmd.github.io/pmd-7.0.0/}7.0.0}} |
Review Comment:
```suggestion
|
{{{https://maven.apache.org/plugins-archives/maven-pmd-plugin-3.22.0/}3.22.0}}
| {{{https://docs.pmd-code.org/pmd-doc-7.0.0/}7.0.0}} |
```
##
src/site/apt/index.apt.vm:
##
@@ -89,6 +89,11 @@ ${project.name}
* Upgrading Notes
+ <> Starting with Maven PMD Plugin 3.22.0, the plugin requires PDM
version 7.0.0 or higher.
Review Comment:
```suggestion
<> Starting with Maven PMD Plugin 3.22.0, the plugin requires PMD
version 7.0.0 or higher.
```
##
src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java:
##
@@ -190,7 +189,7 @@ private PmdResult run() throws MavenReportException {
configuration.setRuleSets(request.getRulesets());
configuration.setMinimumPriority(RulePriority.valueOf(request.getMinimumPriority()));
if (request.getBenchmarkOutputLocation() != null) {
-configuration.setBenchmark(true);
+TimeTracker.startGlobalTracking();
Review Comment:
Alright, we have even ITs
(https://github.com/apache/maven-pmd-plugin/tree/master/src/it/MPMD-181-benchmark).
So, this should be fine.
##
src/site/apt/index.apt.vm:
##
@@ -89,6 +89,11 @@ ${project.name}
* Upgrading Notes
+ <> Starting with Maven PMD Plugin 3.22.0, the plugin requires PDM
version 7.0.0 or higher.
+ The PMD 7.0.0 switched to the SLF4J and since Maven 3.1.0+ the SLF4J is the
default logging API,
+ because of that the <<>> makes no sense to exist. See
+ {{{}https://maven.apache.org/ref/3.9.6/maven-embedder/logging.html}}Maven
Logging for more details.
Review Comment:
We also should mention, that the switch from PMD 6.x to PMD 7 is a major
version change... That's the biggest impact on end-users, who innocently update
m-pmd-p version from 3.21.2 to 3.22.0...
Maybe something along these lines?
```
* The upgrade from PMD 6 to PMD 7.0.0 is a major version change. If you
use the default ruleset
from Maven PMD Plugin, then everything should just work. But if you
use a custom ruleset, you
most likely need to review your ruleset and migrate it to PMD 7. Rules
might have been renamed or
replaced. See
{{{https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html}Detailed
Release Notes for PMD 7}}
and
{{{https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html}Migration
Guide for PMD 7}}.
```
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +152,53 @@ private CpdResult run() throws MavenReportException {
CPDConfiguration cpdConfiguration = new CPDConfiguration();
cpdConfiguration.setMinimumTileSize(request.getMinimumTokens());
+cpdConfiguration.setIgnoreAnnotations(request.isIgnoreAnnotations());
+cpdConfiguration.setIgnoreLiterals(request.isIgnoreLiterals());
+cpdConfiguration.setIgnoreIdentifiers(request.isIgnoreIdentifiers());
Language cpdLanguage;
if ("java".equals(request.getLanguage()) || null ==
request.getLanguage()) {
-cpdLanguage = new JavaLanguage(request.getLanguageProperties());
+cpdLanguage = new JavaLanguageModule();
} else if ("javascript".equals(request.getLanguage())) {
-cpdLanguage = new EcmascriptLanguage();
+cpdLanguage = new EcmascriptLanguageModule();
} else if ("jsp".equals(request.getLanguage())) {
-cpdLanguage = new JSPLanguage();
+cpdLanguage = new JspLanguageModule();
} else {
-cpdLanguage =
LanguageFactory.createLanguage(request.getLanguage(),
request.getLanguageProperties());
+cpdLanguage =
cpdConfiguration.getLanguageRegistry().getLanguageById(request.getLanguage());
}
-cpdConfiguration.setLanguage(cpdLanguage);
-cpdConfiguration.setSourceEncoding(request.getSourceEncoding());
+
Re: [PR] [MPMD-379] PMD 7.0.0 support [maven-pmd-plugin]
adangel commented on code in PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1553758485
##
src/site/apt/examples/upgrading-PMD-at-runtime.apt.vm:
##
@@ -88,6 +88,8 @@ Upgrading PMD at Runtime
**--*
| <>
| <> |
**--*
+|
{{{https://maven.apache.org/plugins-archives/maven-pmd-plugin-3.22.0/}3.22.0}}
| {{{https://pmd.github.io/pmd-7.0.0/}7.0.0}} |
Review Comment:
```suggestion
|
{{{https://maven.apache.org/plugins-archives/maven-pmd-plugin-3.22.0/}3.22.0}}
| {{{https://docs.pmd-code.org/pmd-doc-7.0.0/}7.0.0}} |
```
##
src/site/apt/index.apt.vm:
##
@@ -89,6 +89,11 @@ ${project.name}
* Upgrading Notes
+ <> Starting with Maven PMD Plugin 3.22.0, the plugin requires PDM
version 7.0.0 or higher.
Review Comment:
```suggestion
<> Starting with Maven PMD Plugin 3.22.0, the plugin requires PMD
version 7.0.0 or higher.
```
##
src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java:
##
@@ -190,7 +189,7 @@ private PmdResult run() throws MavenReportException {
configuration.setRuleSets(request.getRulesets());
configuration.setMinimumPriority(RulePriority.valueOf(request.getMinimumPriority()));
if (request.getBenchmarkOutputLocation() != null) {
-configuration.setBenchmark(true);
+TimeTracker.startGlobalTracking();
Review Comment:
Alright, we have even ITs
(https://github.com/apache/maven-pmd-plugin/tree/master/src/it/MPMD-181-benchmark).
So, this should be fine.
##
src/site/apt/index.apt.vm:
##
@@ -89,6 +89,11 @@ ${project.name}
* Upgrading Notes
+ <> Starting with Maven PMD Plugin 3.22.0, the plugin requires PDM
version 7.0.0 or higher.
+ The PMD 7.0.0 switched to the SLF4J and since Maven 3.1.0+ the SLF4J is the
default logging API,
+ because of that the <<>> makes no sense to exist. See
+ {{{}https://maven.apache.org/ref/3.9.6/maven-embedder/logging.html}}Maven
Logging for more details.
Review Comment:
We also should mention, that the switch from PMD 6.x to PMD 7 is a major
version change... That's the biggest impact on end-users, who innocently update
m-pmd-p version from 3.21.2 to 3.22.0...
Maybe something along these lines?
```
* The upgrade from PMD 6 to PMD 7.0.0 is a major version change. If you
use the default ruleset
from Maven PMD Plugin, then everything should just work. But if you
use a custom ruleset, you
most likely need to review your ruleset and migrate it to PMD 7. Rules
might have been renamed or
replaced. See
{{{https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html}Detailed
Release Notes for PMD 7}}
and
{{{https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html}Migration
Guide for PMD 7}}.
```
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +152,53 @@ private CpdResult run() throws MavenReportException {
CPDConfiguration cpdConfiguration = new CPDConfiguration();
cpdConfiguration.setMinimumTileSize(request.getMinimumTokens());
+cpdConfiguration.setIgnoreAnnotations(request.isIgnoreAnnotations());
+cpdConfiguration.setIgnoreLiterals(request.isIgnoreLiterals());
+cpdConfiguration.setIgnoreIdentifiers(request.isIgnoreIdentifiers());
Language cpdLanguage;
if ("java".equals(request.getLanguage()) || null ==
request.getLanguage()) {
-cpdLanguage = new JavaLanguage(request.getLanguageProperties());
+cpdLanguage = new JavaLanguageModule();
} else if ("javascript".equals(request.getLanguage())) {
-cpdLanguage = new EcmascriptLanguage();
+cpdLanguage = new EcmascriptLanguageModule();
} else if ("jsp".equals(request.getLanguage())) {
-cpdLanguage = new JSPLanguage();
+cpdLanguage = new JspLanguageModule();
} else {
-cpdLanguage =
LanguageFactory.createLanguage(request.getLanguage(),
request.getLanguageProperties());
+cpdLanguage =
cpdConfiguration.getLanguageRegistry().getLanguageById(request.getLanguage());
}
-cpdConfiguration.setLanguage(cpdLanguage);
-cpdConfiguration.setSourceEncoding(request.getSourceEncoding());
+cpdConfiguration.setOnlyRecognizeLanguage(cpdLanguage);
+
cpdConfiguration.setSourceEncoding(Charset.forName(request.getSourceEncoding()));
-CPD cpd = new CPD(cpdConfiguration);
-try {
-
[jira] [Updated] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel updated MPMD-379:
Description:
Add support for the new major version of PMD.
This gives support for analyzing Java 21 code.
The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact
end-users, if they use custom rulesets (see
[https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html])
or if they override the dependencies to upgrade PMD at runtime and currently
use PMD 6.x (see
[https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]).
Most likely, end-users have to review their rulesets and migrate them to PMD 7.
Rules might have been renamed or replaced. See
[https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and
[https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] .
was:
Add support for the new major version of PMD.
This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7 most
likely means, that only PMD 7 will be supported onwards (no backwards
compatibility supported).
wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
A snapshot version that is compatible with the current 7.0.0 release candidates
is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
{code:java}
apache.snapshots
Apache Snapshot Repository
https://repository.apache.org/snapshots
false
true
{code}
> Upgrade to use PMD 7.0.0 by default
> ---
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This gives support for analyzing Java 21 code.
> The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact
> end-users, if they use custom rulesets (see
> [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html])
> or if they override the dependencies to upgrade PMD at runtime and currently
> use PMD 6.x (see
> [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]).
>
> Most likely, end-users have to review their rulesets and migrate them to PMD
> 7. Rules might have been renamed or replaced. See
> [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and
> [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] .
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSHARED-1378) Cleanup of test code
[ https://issues.apache.org/jira/browse/MSHARED-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1378. Resolution: Fixed > Cleanup of test code > > > Key: MSHARED-1378 > URL: https://issues.apache.org/jira/browse/MSHARED-1378 > Project: Maven Shared Components > Issue Type: Task > Components: maven-script-interpreter >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1378) Cleanup of test code
[ https://issues.apache.org/jira/browse/MSHARED-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834410#comment-17834410 ] ASF GitHub Bot commented on MSHARED-1378: - slawekjaranowski merged PR #117: URL: https://github.com/apache/maven-script-interpreter/pull/117 > Cleanup of test code > > > Key: MSHARED-1378 > URL: https://issues.apache.org/jira/browse/MSHARED-1378 > Project: Maven Shared Components > Issue Type: Task > Components: maven-script-interpreter >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1378] Cleanup of test code [maven-script-interpreter]
slawekjaranowski merged PR #117: URL: https://github.com/apache/maven-script-interpreter/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MPOM-477] Skip empty PMD reports [maven-parent]
slawekjaranowski opened a new pull request, #168: URL: https://github.com/apache/maven-parent/pull/168 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-477) Skip empty PMD reports
Slawomir Jaranowski created MPOM-477: Summary: Skip empty PMD reports Key: MPOM-477 URL: https://issues.apache.org/jira/browse/MPOM-477 Project: Maven POMs Issue Type: Improvement Components: maven Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: MAVEN-42 Empty reports can be skipped at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1378) Cleanup of test code
[ https://issues.apache.org/jira/browse/MSHARED-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834404#comment-17834404 ] ASF GitHub Bot commented on MSHARED-1378: - slawekjaranowski opened a new pull request, #117: URL: https://github.com/apache/maven-script-interpreter/pull/117 - remove public classifier - use try with resources > Cleanup of test code > > > Key: MSHARED-1378 > URL: https://issues.apache.org/jira/browse/MSHARED-1378 > Project: Maven Shared Components > Issue Type: Task > Components: maven-script-interpreter >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel updated MPMD-379:
Summary: Upgrade to use PMD 7.0.0 by default (was: Support PMD 7.0.0)
> Upgrade to use PMD 7.0.0 by default
> ---
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7
> most likely means, that only PMD 7 will be supported onwards (no backwards
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>
> A snapshot version that is compatible with the current 7.0.0 release
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
>
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
>
> false
>
>
> true
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSHARED-1378) Cleanup of test code
Slawomir Jaranowski created MSHARED-1378: Summary: Cleanup of test code Key: MSHARED-1378 URL: https://issues.apache.org/jira/browse/MSHARED-1378 Project: Maven Shared Components Issue Type: Task Components: maven-script-interpreter Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: maven-script-interpreter-1.5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Remove property keywords because of conflict in inline command configration parameters [maven-checkstyle-plugin]
slawekjaranowski commented on PR #132: URL: https://github.com/apache/maven-checkstyle-plugin/pull/132#issuecomment-2040096457 Please create JIRA issue for it with sample projects and instruction how to execute, what result is and what result is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8093) Support profile id alias(es)
Konrad Windszus created MNG-8093: Summary: Support profile id alias(es) Key: MNG-8093 URL: https://issues.apache.org/jira/browse/MNG-8093 Project: Maven Issue Type: Improvement Components: Profiles Reporter: Konrad Windszus Currently each profile may only have exactly one id which is used to enable/disable it on CLI (https://maven.apache.org/pom.html#Profiles). For certain edge cases it would be useful to define aliases (similar to https://maven.apache.org/ref/3.9.6/maven-plugin-api/plugin.html#parameter). So that multiple different ids can be used to activate the same profile. This requires a new POM schema version though. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOURCES-237) Resource plugin's handling of symbolic links changed in 3.0.x, broke existing behavior
[
https://issues.apache.org/jira/browse/MRESOURCES-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834293#comment-17834293
]
Frank Leja commented on MRESOURCES-237:
---
I had exactly the same problem and expect a configuration to steer the
behaviour at least in the same manner as in v2.x (mean resolving the file,
instead of just copy the link itself, what is useless).
I used the symlink of the share library (ABC_api.so) pointing to the current
version of this library (ABC_api.so.2.2.0.3).
My workaround is to include the symlink target file in the resource plugin
config, skipping the link and its benefits completely.
{code:java}
ABC_api.so.*
{code}
> Resource plugin's handling of symbolic links changed in 3.0.x, broke existing
> behavior
> --
>
> Key: MRESOURCES-237
> URL: https://issues.apache.org/jira/browse/MRESOURCES-237
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1, 3.0.2, 3.1.0, 3.2.0
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.11-200.fc25.x86_64", arch: "amd64", family:
> "unix"
>Reporter: Brian D. Johnson
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: a.tgz
>
>
> It looks like the handling of symbolic links in the
> {{maven-resources-plugin}} has changed in version 3.0.x. I'm submitting a
> JIRA because it breaks the previous behavior and I have not been able to find
> this documented anywhere as an intended change.
> *Use case:* Multi-module maven project. We have a custom log4j2
> configuration file we use during testing. Instead of maintaining this file
> in multiple {{src/test/resources}} directories, we instead maintain a single
> copy of the file at the project's root level and create symbolic links from
> each module's {{src/test/resources}} directory to the file using relative
> paths.
> *2.7 Behavior:* the symlink was evaluated and the target file was copied to
> {{target/test-classes/}}.
> *3.0.x Behavior:* the symlink is copied to {{target/test-classes/}} verbatim.
> The symlink's relative path results in the symlink pointing to the wrong
> file location. The log4j2 configuration is not found.
> *Requested Change:* Either revert to the original 2.7 behavior, or document
> the change and provide a configuration parameter to allow the legacy behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJLINK-83) Allow adding multiple launchers to a jlink'ed image
[
https://issues.apache.org/jira/browse/MJLINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834239#comment-17834239
]
ASF GitHub Bot commented on MJLINK-83:
--
pedro-w opened a new pull request, #202:
URL: https://github.com/apache/maven-jlink-plugin/pull/202
This is a simple change to allow the Maven plugin to generate more than one
launcher in a `jlink` image. The `jlink` tool itself already supports this, but
there was no way to pass the required invocation onto it from Maven.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Allow adding multiple launchers to a jlink'ed image
> ---
>
> Key: MJLINK-83
> URL: https://issues.apache.org/jira/browse/MJLINK-83
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Affects Versions: 3.2.0
> Environment: (applies to all platforms)
>Reporter: Peter Hull
>Priority: Minor
>
> The {{jlink}} command line tool allows the {{--launcher}} argument to be
> specified multiple times to create multiple launcher scripts in the image.
> However the maven plugin only passes on one {{}} element from its
> configuration section to the tool. If multiple are specified, the last one
> takes precedence. I would like to improve this so the plugin will pass
> multiple launcher specs on to the {{jlink}} tool. I suggest the config should
> look like:
> {noformat}
> command=module/main{noformat}
> (as before, for backward compatibility and the common case where there is
> only one)
> or
>
> {noformat}
>
> command1=module1/main1
> command2=module2/main2
> ...
>
> {noformat}
>
> where {{}} can contain zero or more {{}} elements with
> the same syntax as the existing element.
> One remaining question - what do do if the config specifies both
> {{}} and {{}} - combine the two or signal an error?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]
pedro-w opened a new pull request, #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202 This is a simple change to allow the Maven plugin to generate more than one launcher in a `jlink` image. The `jlink` tool itself already supports this, but there was no way to pass the required invocation onto it from Maven. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJLINK) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Support PMD 7.0.0
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834214#comment-17834214
]
ASF GitHub Bot commented on MPMD-379:
-
lapostoj commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2039303886
@adangel any blocker still with this one or could the plugin be released
with the PMD 7 support?
> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7
> most likely means, that only PMD 7 will be supported onwards (no backwards
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>
> A snapshot version that is compatible with the current 7.0.0 release
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
>
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
>
> false
>
>
> true
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPMD-379] PMD 7.0.0 support [maven-pmd-plugin]
lapostoj commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2039303886 @adangel any blocker still with this one or could the plugin be released with the PMD 7 support? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update artifact-handlers.apt [maven]
kwin opened a new pull request, #1466: URL: https://github.com/apache/maven/pull/1466 Clarify that the extension used outside repositories for pom files usually differs Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834147#comment-17834147 ] ASF GitHub Bot commented on MNG-8084: - gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2039015662 Fwiw, this will be outdated with https://github.com/apache/maven/pull/1465 and later https://github.com/apache/maven/pull/1457 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2039015662 Fwiw, this will be outdated with https://github.com/apache/maven/pull/1465 and later https://github.com/apache/maven/pull/1457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
