[jira] [Commented] (MSKINS-161) Upgrade Facebook Like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517837#comment-17517837 ] Swarup Patra commented on MSKINS-161: - There Are Method Of Completecity Are There Behind More Away Took Up Look At an Time Happy Preeding Luck Are Better Then Walked Belong More Propose That Tasks Happy Ness News Are All Member That Was Belong More Crakly Thaen Ehen Happy More Tuning Talked Us Every Time Help Us That Was a More Craply Point I am Here Now Won This Tricks That Try it > Upgrade Facebook Like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > Time Spent: 20m > Remaining Estimate: 0h > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSKINS-161) Upgrade Facebook Like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067543#comment-17067543 ] Hudson commented on MSKINS-161: --- Build succeeded in Jenkins: Maven TLP » maven-fluido-skin » master #47 See https://builds.apache.org/job/maven-box/job/maven-fluido-skin/job/master/47/ > Upgrade Facebook Like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > Time Spent: 20m > Remaining Estimate: 0h > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066155#comment-17066155 ] Slawomir Jaranowski commented on MSKINS-161: PR ready, I'm waiting for your review > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > Time Spent: 10m > Remaining Estimate: 0h > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[
https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065958#comment-17065958
]
Slawomir Jaranowski commented on MSKINS-161:
What do you think about replace maven-resources-plugin by maven-assembly-plugin
for copying it tests results to site.
Instead of:
{code}
copy-sidebar
site
copy-resources
${project.build.directory}/it/sidebar/target/site/
${project.build.directory}/site/sidebar/
{code}
in pom.xml we can have (something like) in assembly.xml:
{code}
${project.build.directory}/it/sidebar/target/site/
${project.build.directory}/site/sidebar/
{code}
It will be more readable and easier to maintenance.
> Upgrade Facebook like button integration
>
>
> Key: MSKINS-161
> URL: https://issues.apache.org/jira/browse/MSKINS-161
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Slawomir Jaranowski
>Priority: Major
> Attachments: Screenshot 2020-03-22 at 10.31.29.png
>
>
> Current Facebook integration use iframe and "Like button" is cropped.
> Upgrading to newer facebook sdk can help in cropping "like button".
>
> We also have some configurations for "like button"
> - action type like or recommend
> - share button visibility
> - layout
> - button size
> - ...
> some of those should have possibility to configured by site.xml
> [https://developers.facebook.com/docs/plugins/like-button/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065757#comment-17065757 ] Slawomir Jaranowski commented on MSKINS-161: I will have ready change today evening (CET). I'm waiting for review for other my changes. > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064308#comment-17064308 ] Michael Osipov commented on MSKINS-161: --- Usually we do in separate ones. > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064307#comment-17064307 ] Slawomir Jaranowski commented on MSKINS-161: Can be on ticket for all project dependency refresh, or separate ticket for each dependency? > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064303#comment-17064303 ] Michael Osipov commented on MSKINS-161: --- Separate tickets please. > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[
https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064302#comment-17064302
]
Slawomir Jaranowski commented on MSKINS-161:
I see some more work connected with usually project maintenance, so:
- update parent pom 30 -> 34
- update plugins:
{code}
[INFO] com.samaxes.maven:maven-minify-plugin 1.3.5 -> 1.3.5.1
[INFO] maven-invoker-plugin 1.10 -> 3.1.0
[INFO] maven-resources-plugin ... 2.7 -> 3.1.0
{code}
Do I should create separate task for each of those task ... or can I prepare
many PR connected with this issue?
> Upgrade Facebook like button integration
>
>
> Key: MSKINS-161
> URL: https://issues.apache.org/jira/browse/MSKINS-161
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Slawomir Jaranowski
>Priority: Major
> Attachments: Screenshot 2020-03-22 at 10.31.29.png
>
>
> Current Facebook integration use iframe and "Like button" is cropped.
> Upgrading to newer facebook sdk can help in cropping "like button".
>
> We also have some configurations for "like button"
> - action type like or recommend
> - share button visibility
> - layout
> - button size
> - ...
> some of those should have possibility to configured by site.xml
> [https://developers.facebook.com/docs/plugins/like-button/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064290#comment-17064290 ] Slawomir Jaranowski commented on MSKINS-161: ok. I will try to do it > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064255#comment-17064255 ] Michael Osipov commented on MSKINS-161: --- Feel free to provide a PR. > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
