[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539006#comment-16539006
]
Till Toenshoff commented on MESOS-7397:
---
{noformat}
commit 997e280b57232b5f9b12e0e9dfd0abfc9d6c1085 (HEAD -> master)
Author: Till Toenshoff toensh...@me.com
Date: Tue Jul 10 19:33:58 2018 +0200
Updated apply-reviews.py messaging for submitted reviews.
Review: https://reviews.apache.org/r/67859/
{noformat}
> apply-reviews.py silently fails when using chain mode.
> --
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
>Reporter: Till Toenshoff
>Priority: Minor
> Fix For: 1.7.0
>
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537771#comment-16537771
]
Till Toenshoff commented on MESOS-7397:
---
No, that is not what I meant to explain --- use any review that has not yet
landed and try my walkthrough.
> apply-reviews.py silently fails when using chain mode.
> --
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
>Reporter: Till Toenshoff
>Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535835#comment-16535835
]
Till Toenshoff commented on MESOS-7397:
---
Nope, still fails for me.
# Do a {{git show}}.
# Note the review request number (WHATEVER_RR_THAT_WAS).
# Do a {{git reset --hard HEAD^}}
# Do a {{support/apply-reviews.sh -c -r WHATEVER_RR_THAT_WAS}}
You will get a warning that this review had already been applied while nothing
was applied.
> apply-reviews.py silently fails when using chain mode.
> --
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
>Reporter: Till Toenshoff
>Assignee: Shubham Kumar
>Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375890#comment-16375890
]
Andrew Schwartzmeyer commented on MESOS-7397:
-
With the patch for MESOS-8586, the edge case of attempting to apply a submitted
patch results in a warning (and the patch not being applied).
The slightly different case of applying a submitted review without the --chain
option results in an immediate error, because no "is submitted" test is
performed on the review.
For the case of a patch that is unsubmitted, it results in a "failed to apply"
error regardless of --chain.
> apply-reviews.py silently fails when using chain mode.
> --
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
>Reporter: Till Toenshoff
>Assignee: Shubham Kumar
>Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375852#comment-16375852
]
Andrew Schwartzmeyer commented on MESOS-7397:
-
This appears to only be a bug for single reviews. That is, it does not
reproduce for a chain (2 or more) of reviews that have been applied (or a
partially applied chain): with and without -c, it properly reports that the
patches failed to apply.
But in the case of a _single_ review being applied as a chain (like #57764
which has no dependencies), this bug reproduces.
> apply-reviews.py silently fails when using chain mode.
> --
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
>Reporter: Till Toenshoff
>Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
