[jira] [Updated] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread Andy LoPresto (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-3269:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.1.1
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread Andy LoPresto (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-3269:

Fix Version/s: 1.2.0

> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.1.1
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread Andy LoPresto (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-3269:

Affects Version/s: 1.1.1

> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.1.1
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796665#comment-15796665
 ] 

ASF GitHub Bot commented on NIFI-3269:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1374
  
I added a [unit 
test](https://github.com/alopresto/nifi/commit/cf36bedb28021c73d4ea1be06a61057063366ca6#diff-9fffe09b7ce89a09c89a748fb7417b92)
 which failed without this change and passes with it (just verifies that the 
`onPropertyModified` method is invoked on the `ControllerService` by 
`StandardProcessorTestRunner`). 


> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1374: NIFI-3269 added call to onPropertyModified when updating c...

2017-01-03 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1374
  
I added a [unit 
test](https://github.com/alopresto/nifi/commit/cf36bedb28021c73d4ea1be06a61057063366ca6#diff-9fffe09b7ce89a09c89a748fb7417b92)
 which failed without this change and passes with it (just verifies that the 
`onPropertyModified` method is invoked on the `ControllerService` by 
`StandardProcessorTestRunner`). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796656#comment-15796656
 ] 

ASF GitHub Bot commented on NIFI-3269:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1374


> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796655#comment-15796655
 ] 

ASF subversion and git services commented on NIFI-3269:
---

Commit 41189b055f3f23010db5b1f410adc55d052805f2 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=41189b0 ]

NIFI-3269 Added call to onPropertyModified when updating controller services in 
StandardProcessorTestRunner.
Added unit test to demonstrate change.

This closes #1374.

Signed-off-by: Andy LoPresto 


> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1374: NIFI-3269 added call to onPropertyModified when upd...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #20: Adding an initial GitHub PR template.

2017-01-03 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/20
  
+1 to @jdye64 's comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #30: MINIFI-165 Updating licensing terms to inc...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-3274) Add complete WriteAheadLog configurations to WriteAheadLocalStateProvider

2017-01-03 Thread Joseph Percivall (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Percivall updated NIFI-3274:
---
Status: Patch Available  (was: Open)

> Add complete WriteAheadLog configurations to WriteAheadLocalStateProvider
> -
>
> Key: NIFI-3274
> URL: https://issues.apache.org/jira/browse/NIFI-3274
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Percivall
>
> Originally brought up due to NIFI-3273, the WriteAheadLocalStateProvider 
> should expose the same customizations that the WriteAheadFlowFileRepository 
> does. This should probably be done in the file specified by 
> "nifi.state.management.configuration.file".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1386: NIFI-3274 Adding WriteAheadLog configuration option...

2017-01-03 Thread JPercivall
GitHub user JPercivall opened a pull request:

https://github.com/apache/nifi/pull/1386

NIFI-3274 Adding WriteAheadLog configuration options to WriteAheadLog…

…LocalStateProvider


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JPercivall/nifi NIFI-3274

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1386


commit 6bfe460fcf604d02a29eacc893737cab59abe687
Author: jpercivall 
Date:   2017-01-03T23:13:54Z

NIFI-3274 Adding WriteAheadLog configuration options to 
WriteAheadLogLocalStateProvider




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #30: MINIFI-165 Updating licensing terms to include fi...

2017-01-03 Thread jdye64
Github user jdye64 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/30
  
reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3269) StandardProcessorTestRunner not calling onPropertyModified when updating controller services

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796339#comment-15796339
 ] 

ASF GitHub Bot commented on NIFI-3269:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1374
  
Reviewing...


> StandardProcessorTestRunner not calling onPropertyModified when updating 
> controller services
> 
>
> Key: NIFI-3269
> URL: https://issues.apache.org/jira/browse/NIFI-3269
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> While looking at NIFI-3004, I noticed that {{StandardProcessorTestRunner}} is 
> not calling {{onPropertyModified}} method when updating properties in 
> controller service. This should be fixed to match the real behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1374: NIFI-3269 added call to onPropertyModified when updating c...

2017-01-03 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1374
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3259) Ambari Reporting Task - Allow process group level reporting

2017-01-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796209#comment-15796209
 ] 

ASF subversion and git services commented on NIFI-3259:
---

Commit 2c0f1c348e15b35355ec2a1e2ff5503c331c7ad9 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2c0f1c3 ]

NIFI-3259 - Process group level option in Ambari reporting task

This closes #1360.

Signed-off-by: Bryan Bende 


> Ambari Reporting Task - Allow process group level reporting
> ---
>
> Key: NIFI-3259
> URL: https://issues.apache.org/jira/browse/NIFI-3259
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> In a multi-tenant use of NiFi, each project using NiFi can be allocated a 
> given process group to work with. With such an approach it should be possible 
> to specify a process group id in the reporting task definition to send 
> metrics of this specific process group.
> This will give the opportunity to add low-level widgets in Ambari to monitor 
> specific parts of the canvas. This could also be used to create Grafana 
> dashboards at project level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3259) Ambari Reporting Task - Allow process group level reporting

2017-01-03 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3259:
--
Fix Version/s: 1.2.0

> Ambari Reporting Task - Allow process group level reporting
> ---
>
> Key: NIFI-3259
> URL: https://issues.apache.org/jira/browse/NIFI-3259
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> In a multi-tenant use of NiFi, each project using NiFi can be allocated a 
> given process group to work with. With such an approach it should be possible 
> to specify a process group id in the reporting task definition to send 
> metrics of this specific process group.
> This will give the opportunity to add low-level widgets in Ambari to monitor 
> specific parts of the canvas. This could also be used to create Grafana 
> dashboards at project level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3259) Ambari Reporting Task - Allow process group level reporting

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796211#comment-15796211
 ] 

ASF GitHub Bot commented on NIFI-3259:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1360


> Ambari Reporting Task - Allow process group level reporting
> ---
>
> Key: NIFI-3259
> URL: https://issues.apache.org/jira/browse/NIFI-3259
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> In a multi-tenant use of NiFi, each project using NiFi can be allocated a 
> given process group to work with. With such an approach it should be possible 
> to specify a process group id in the reporting task definition to send 
> metrics of this specific process group.
> This will give the opportunity to add low-level widgets in Ambari to monitor 
> specific parts of the canvas. This could also be used to create Grafana 
> dashboards at project level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3259) Ambari Reporting Task - Allow process group level reporting

2017-01-03 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3259:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Ambari Reporting Task - Allow process group level reporting
> ---
>
> Key: NIFI-3259
> URL: https://issues.apache.org/jira/browse/NIFI-3259
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> In a multi-tenant use of NiFi, each project using NiFi can be allocated a 
> given process group to work with. With such an approach it should be possible 
> to specify a process group id in the reporting task definition to send 
> metrics of this specific process group.
> This will give the opportunity to add low-level widgets in Ambari to monitor 
> specific parts of the canvas. This could also be used to create Grafana 
> dashboards at project level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1360: NIFI-3259 - Process group level option in Ambari re...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1360


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1360: NIFI-3259 - Process group level option in Ambari reporting...

2017-01-03 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1360
  
+1 Tested this out with Ambari and was able to run two instances of the 
reporting task, one for all of NiFi and one for a specific process group, then 
created a second dashboard in Grafana for the specific process group. I'll 
merge to master, thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3259) Ambari Reporting Task - Allow process group level reporting

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796205#comment-15796205
 ] 

ASF GitHub Bot commented on NIFI-3259:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1360
  
+1 Tested this out with Ambari and was able to run two instances of the 
reporting task, one for all of NiFi and one for a specific process group, then 
created a second dashboard in Grafana for the specific process group. I'll 
merge to master, thanks! 


> Ambari Reporting Task - Allow process group level reporting
> ---
>
> Key: NIFI-3259
> URL: https://issues.apache.org/jira/browse/NIFI-3259
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> In a multi-tenant use of NiFi, each project using NiFi can be allocated a 
> given process group to work with. With such an approach it should be possible 
> to specify a process group id in the reporting task definition to send 
> metrics of this specific process group.
> This will give the opportunity to add low-level widgets in Ambari to monitor 
> specific parts of the canvas. This could also be used to create Grafana 
> dashboards at project level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-3274) Add complete WriteAheadLog configurations to WriteAheadLocalStateProvider

2017-01-03 Thread Joseph Percivall (JIRA)
Joseph Percivall created NIFI-3274:
--

 Summary: Add complete WriteAheadLog configurations to 
WriteAheadLocalStateProvider
 Key: NIFI-3274
 URL: https://issues.apache.org/jira/browse/NIFI-3274
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Joseph Percivall
Assignee: Joseph Percivall


Originally brought up due to NIFI-3273, the WriteAheadLocalStateProvider should 
expose the same customizations that the WriteAheadFlowFileRepository does. This 
should probably be done in the file specified by 
"nifi.state.management.configuration.file".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3118) UI - Inconsistent order of garbage collection statistics

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796125#comment-15796125
 ] 

ASF GitHub Bot commented on NIFI-3118:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1337
  
The PR has been updated. Discovered a separate issue that I've created 
another JIRA [1] for which can be addressed later.

[1] https://issues.apache.org/jira/browse/NIFI-3272


> UI - Inconsistent order of garbage collection statistics
> 
>
> Key: NIFI-3118
> URL: https://issues.apache.org/jira/browse/NIFI-3118
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> In the system diagnostics, the ordering of the garbage collection statistics 
> is inconsistent. The ordering appears to shuffle with each refresh.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1337: NIFI-3118: Inconsistent order of garbage collection statis...

2017-01-03 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1337
  
The PR has been updated. Discovered a separate issue that I've created 
another JIRA [1] for which can be addressed later.

[1] https://issues.apache.org/jira/browse/NIFI-3272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (NIFI-3273) MinimalLockingWriteAheadLog doesn't properly handle corrupted journals

2017-01-03 Thread Joseph Percivall (JIRA)
Joseph Percivall created NIFI-3273:
--

 Summary: MinimalLockingWriteAheadLog doesn't properly handle 
corrupted journals 
 Key: NIFI-3273
 URL: https://issues.apache.org/jira/browse/NIFI-3273
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Joseph Percivall
Priority: Critical


When NiFi is running if the system dies abruptly (sudden power loss) without 
flushing writes then anything that was being written to disk can become 
corrupted. A ticket for the provenance repository is already created here[1]. 
The content repo handles this automatically since the content claim won't be 
valid if it hasn't been written out yet. The database repo is just a cache and 
is rebuilt anyway. The logs are handled by logback. The flow.xml.gz can be 
rolled back to one the last archive (manually).

This ticket is for the MinimalLockingWriteAheadLog which backs the FlowFile 
repo and local state. Originally brought up here[2] for MiNiFi, it will also 
affect NiFi.

One possible solution is to restore transactions up until the corrupted id and 
then ignore the rest. This could cause state to become out of sync with the 
processed flowfiles (if FF repo is restored but local state cannot be fully 
restored) but given the rarity of the event I think it is an appropriate risk 
to accept.

The workaround for the FF repo is to set "nifi.flowfile.repository.always.sync" 
but currently there is no way to set "alway sync" for the local state provider.

[1] https://issues.apache.org/jira/browse/NIFI-2890
[2] 
https://community.hortonworks.com/questions/75280/why-does-my-minifi-flow-fail-to-run-when-turning-o.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2759) TestListDatabaseTables.testListTablesMultipleRefresh consistently failing

2017-01-03 Thread Joe Skora (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796079#comment-15796079
 ] 

Joe Skora commented on NIFI-2759:
-

[~pvillard], I do not recall seeing it lately but I will test tonight were it 
was most persistent and let  you know.

> TestListDatabaseTables.testListTablesMultipleRefresh consistently failing
> -
>
> Key: NIFI-2759
> URL: https://issues.apache.org/jira/browse/NIFI-2759
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0
>Reporter: Joe Skora
>Priority: Critical
>
> Running this test repeatedly produces errors.
> {code}
> Running org.apache.nifi.processors.standard.TestListDatabaseTables
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.114 sec 
> <<< FAILURE! - in org.apache.nifi.processors.standard.TestListDatabaseTables
> testListTablesMultipleRefresh(org.apache.nifi.processors.standard.TestListDatabaseTables)
>   Time elapsed: 0.794 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.nifi.util.StandardProcessorTestRunner.assertTransferCount(StandardProcessorTestRunner.java:318)
> at 
> org.apache.nifi.processors.standard.TestListDatabaseTables.testListTablesMultipleRefresh(TestListDatabaseTables.java:216)
> {code}
> followed by 
> {code}
> Failed tests:
>   TestListDatabaseTables.testListTablesMultipleRefresh:216 expected:<1> but 
> was:<2>
> {code}
> I tried removing the 
> [runner.clearTransferState();|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java#L210]
>  thinking the reset was causing both tables to show but that did not make a 
> difference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2890) Provenance Repository corruption

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796074#comment-15796074
 ] 

ASF GitHub Bot commented on NIFI-2890:
--

Github user jskora commented on the issue:

https://github.com/apache/nifi/pull/1201
  
@JPercivall, no problem.  I'll take a look at this and 
[https://github.com/apache/nifi/pull/1203](1203)


> Provenance Repository corruption
> 
>
> Key: NIFI-2890
> URL: https://issues.apache.org/jira/browse/NIFI-2890
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Brandon DeVries
>Assignee: Joe Skora
>
> It looks as thought there was a ticket to address this\[1\], but it appears 
> to not have completely addressed the issue. On an 0.6.1 instance (that 
> crashed hard), I'm getting a stack trace on startup indicating a corrupt prov 
> repo. The relevant part of the stack trace (unfortunately typed by hand, so 
> forgive the inevitable typos) is:
> {quote}
> ...
> Caused By java.lang.IllegalArgumentException: No enum constant 
> org.apahe.nifi.provenance.ProvenenceEventType.
> at java.lang/.Enum.valueOf...
> at 
> org.apache.nifi.provenance.ProvenanaceEventType.valueOf(ProvenanaceEventType.java:19)
> at
> org.apache.nifi.provenance.StandardRecordReader.nextRecord(StandardRecordReader.java:284)
> at 
> org.apache.nifi.provenance.PersistentProvenanceRepository.mergeJournals(PersistentProvenanceRepository.java:1678)
>  \[2\]
> ...
> {quote}
> In 0.x HEAD, this appears to have moved a bit\[3\]. Same is true for 
> 1.x\[4\]. In both 0.x\[5\] and 1.x\[6\], code was added to check for "bad" 
> records coming from the reader, and skip them. However, this appears to only 
> address the issue if the corrupt / bad record is the *first* record coming 
> out of a reader. If it is a subsequent record, the corruption remains.
> \[1\] https://issues.apache.org/jira/browse/NIFI-803
> \[2\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[3\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1711
> \[4\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[5\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1564-L1578
> \[6\] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1658-L1672



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption

2017-01-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1201
  
Hey @jskora, sorry this has sat for so long, this PR review should have 
been prioritized. That said, there appear to be merge conflicts and checkstyle 
issues. I could resolve them for you if you wanted but, if able, I'd prefer you 
fix them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2890) Provenance Repository corruption

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796026#comment-15796026
 ] 

ASF GitHub Bot commented on NIFI-2890:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1201
  
Hey @jskora, sorry this has sat for so long, this PR review should have 
been prioritized. That said, there appear to be merge conflicts and checkstyle 
issues. I could resolve them for you if you wanted but, if able, I'd prefer you 
fix them.


> Provenance Repository corruption
> 
>
> Key: NIFI-2890
> URL: https://issues.apache.org/jira/browse/NIFI-2890
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Brandon DeVries
>Assignee: Joe Skora
>
> It looks as thought there was a ticket to address this\[1\], but it appears 
> to not have completely addressed the issue. On an 0.6.1 instance (that 
> crashed hard), I'm getting a stack trace on startup indicating a corrupt prov 
> repo. The relevant part of the stack trace (unfortunately typed by hand, so 
> forgive the inevitable typos) is:
> {quote}
> ...
> Caused By java.lang.IllegalArgumentException: No enum constant 
> org.apahe.nifi.provenance.ProvenenceEventType.
> at java.lang/.Enum.valueOf...
> at 
> org.apache.nifi.provenance.ProvenanaceEventType.valueOf(ProvenanaceEventType.java:19)
> at
> org.apache.nifi.provenance.StandardRecordReader.nextRecord(StandardRecordReader.java:284)
> at 
> org.apache.nifi.provenance.PersistentProvenanceRepository.mergeJournals(PersistentProvenanceRepository.java:1678)
>  \[2\]
> ...
> {quote}
> In 0.x HEAD, this appears to have moved a bit\[3\]. Same is true for 
> 1.x\[4\]. In both 0.x\[5\] and 1.x\[6\], code was added to check for "bad" 
> records coming from the reader, and skip them. However, this appears to only 
> address the issue if the corrupt / bad record is the *first* record coming 
> out of a reader. If it is a subsequent record, the corruption remains.
> \[1\] https://issues.apache.org/jira/browse/NIFI-803
> \[2\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[3\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1711
> \[4\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[5\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1564-L1578
> \[6\] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1658-L1672



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-3272) UI - GC stats in Cluster view

2017-01-03 Thread Matt Gilman (JIRA)
Matt Gilman created NIFI-3272:
-

 Summary: UI - GC stats in Cluster view
 Key: NIFI-3272
 URL: https://issues.apache.org/jira/browse/NIFI-3272
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core UI
Reporter: Matt Gilman
 Fix For: 1.2.0


The GC stats in the Cluster view assume the garbage collector is set to G1 as 
the column headers are hard coded. This needs to be updated to utilize the name 
of the garbage collector in the response. Since a JVM can return 1 or more 
garbage collection beans, it is not possible to guarantee the same column model 
for each row in the table (node in the cluster). We likely need to break this 
out into a single GC column which shows all the garbage collections probably in 
a dialog (since there can be many).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2890) Provenance Repository corruption

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795877#comment-15795877
 ] 

ASF GitHub Bot commented on NIFI-2890:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1201
  
Reviewing


> Provenance Repository corruption
> 
>
> Key: NIFI-2890
> URL: https://issues.apache.org/jira/browse/NIFI-2890
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Brandon DeVries
>Assignee: Joe Skora
>
> It looks as thought there was a ticket to address this\[1\], but it appears 
> to not have completely addressed the issue. On an 0.6.1 instance (that 
> crashed hard), I'm getting a stack trace on startup indicating a corrupt prov 
> repo. The relevant part of the stack trace (unfortunately typed by hand, so 
> forgive the inevitable typos) is:
> {quote}
> ...
> Caused By java.lang.IllegalArgumentException: No enum constant 
> org.apahe.nifi.provenance.ProvenenceEventType.
> at java.lang/.Enum.valueOf...
> at 
> org.apache.nifi.provenance.ProvenanaceEventType.valueOf(ProvenanaceEventType.java:19)
> at
> org.apache.nifi.provenance.StandardRecordReader.nextRecord(StandardRecordReader.java:284)
> at 
> org.apache.nifi.provenance.PersistentProvenanceRepository.mergeJournals(PersistentProvenanceRepository.java:1678)
>  \[2\]
> ...
> {quote}
> In 0.x HEAD, this appears to have moved a bit\[3\]. Same is true for 
> 1.x\[4\]. In both 0.x\[5\] and 1.x\[6\], code was added to check for "bad" 
> records coming from the reader, and skip them. However, this appears to only 
> address the issue if the corrupt / bad record is the *first* record coming 
> out of a reader. If it is a subsequent record, the corruption remains.
> \[1\] https://issues.apache.org/jira/browse/NIFI-803
> \[2\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[3\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1711
> \[4\] 
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[5\] 
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1564-L1578
> \[6\] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1658-L1672



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption

2017-01-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1201
  
Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (NIFI-2637) Allow CreateHadoopSequenceFile compression codec to be configurable

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard resolved NIFI-2637.
--
Resolution: Duplicate

> Allow CreateHadoopSequenceFile compression codec to be configurable
> ---
>
> Key: NIFI-2637
> URL: https://issues.apache.org/jira/browse/NIFI-2637
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Caleb Fenton
>Priority: Minor
>
> Currently, when creating a Hadoop Sequence File, the compression codec is 
> hardcoded as DefaultCodec, which is deflate. It would be better if this was 
> configurable or the codec is inferred from the Hadoop configuration.
> Here's the relevant line in code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java#L100
> Here's the relevant block of code where the writer is created with the 
> DefaultCodec:
> {noformat}
> final SequenceFile.Writer writer = SequenceFile.createWriter(configuration,
> 
> SequenceFile.Writer.stream(fsDataOutputStream),
> SequenceFile.Writer.keyClass(Text.class),
> 
> SequenceFile.Writer.valueClass(InputStreamWritable.class),
> 
> SequenceFile.Writer.compression(compressionType, new DefaultCodec(
> {noformat}
> Basically, I want to use Snappy for certain sequence files, and I can't do 
> that by changing Hadoop or processor configuration. It looks like I'll have 
> to change the source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2759) TestListDatabaseTables.testListTablesMultipleRefresh consistently failing

2017-01-03 Thread Pierre Villard (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795569#comment-15795569
 ] 

Pierre Villard commented on NIFI-2759:
--

Hey [~jskora], do you still have issues with this test? I've not been able to 
reproduce the error after a lot of builds.

> TestListDatabaseTables.testListTablesMultipleRefresh consistently failing
> -
>
> Key: NIFI-2759
> URL: https://issues.apache.org/jira/browse/NIFI-2759
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0
>Reporter: Joe Skora
>Priority: Critical
>
> Running this test repeatedly produces errors.
> {code}
> Running org.apache.nifi.processors.standard.TestListDatabaseTables
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.114 sec 
> <<< FAILURE! - in org.apache.nifi.processors.standard.TestListDatabaseTables
> testListTablesMultipleRefresh(org.apache.nifi.processors.standard.TestListDatabaseTables)
>   Time elapsed: 0.794 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.nifi.util.StandardProcessorTestRunner.assertTransferCount(StandardProcessorTestRunner.java:318)
> at 
> org.apache.nifi.processors.standard.TestListDatabaseTables.testListTablesMultipleRefresh(TestListDatabaseTables.java:216)
> {code}
> followed by 
> {code}
> Failed tests:
>   TestListDatabaseTables.testListTablesMultipleRefresh:216 expected:<1> but 
> was:<2>
> {code}
> I tried removing the 
> [runner.clearTransferState();|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java#L210]
>  thinking the reset was causing both tables to show but that did not make a 
> difference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2761) BootstrapCodec can throw exceptions with unintended message

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795558#comment-15795558
 ] 

ASF GitHub Bot commented on NIFI-2761:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1385

NIFI-2761 Fixed error message in bootstrap

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1385


commit fe1adec7eb98eb755480f6aff8fe989ef456e5f0
Author: Pierre Villard 
Date:   2017-01-03T17:09:53Z

NIFI-2761 Fixed error message in bootstrap




> BootstrapCodec can throw exceptions with unintended message
> ---
>
> Key: NIFI-2761
> URL: https://issues.apache.org/jira/browse/NIFI-2761
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Priority: Minor
>
> In BootstrapCodec.java, when the following tertiary expression gets 
> evaluated, it never will be null, due to the string concatination.  This 
> causes the IOException message to always be "Details: " with the 
> InvalidCommandException's toString result.
> {code}
> try {
> processRequest(cmd, args);
> } catch (final InvalidCommandException ice) {
> throw new IOException("Received invalid command from NiFi: " + line + " : 
> " + ice.getMessage() == null ? "" : "Details: " + ice.toString());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2761) BootstrapCodec can throw exceptions with unintended message

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2761:
-
Assignee: Pierre Villard
  Status: Patch Available  (was: Open)

> BootstrapCodec can throw exceptions with unintended message
> ---
>
> Key: NIFI-2761
> URL: https://issues.apache.org/jira/browse/NIFI-2761
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Pierre Villard
>Priority: Minor
>
> In BootstrapCodec.java, when the following tertiary expression gets 
> evaluated, it never will be null, due to the string concatination.  This 
> causes the IOException message to always be "Details: " with the 
> InvalidCommandException's toString result.
> {code}
> try {
> processRequest(cmd, args);
> } catch (final InvalidCommandException ice) {
> throw new IOException("Received invalid command from NiFi: " + line + " : 
> " + ice.getMessage() == null ? "" : "Details: " + ice.toString());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1385: NIFI-2761 Fixed error message in bootstrap

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1385

NIFI-2761 Fixed error message in bootstrap

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1385


commit fe1adec7eb98eb755480f6aff8fe989ef456e5f0
Author: Pierre Villard 
Date:   2017-01-03T17:09:53Z

NIFI-2761 Fixed error message in bootstrap




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795554#comment-15795554
 ] 

ASF GitHub Bot commented on NIFI-3231:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1361


> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
> Fix For: 1.2.0
>
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3231:
--
Fix Version/s: 1.2.0

> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
> Fix For: 1.2.0
>
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795552#comment-15795552
 ] 

ASF subversion and git services commented on NIFI-3231:
---

Commit 9b47961d1c0dcc29f91c083e0affb99e1db07084 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9b47961 ]

NIFI-3231 Added EL support to hostname and port in PutTCP/UDP

This closes #1361.

Signed-off-by: Bryan Bende 


> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1361: NIFI-3231 Added EL support to hostname and port in ...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1361


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2017-01-03 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1361
  
+1 looks good now, will merge to master, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795549#comment-15795549
 ] 

ASF GitHub Bot commented on NIFI-3231:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1361
  
+1 looks good now, will merge to master, thanks!


> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795448#comment-15795448
 ] 

ASF GitHub Bot commented on NIFI-3231:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1361
  
Looks good, was able to use EL for all three processors modified. 

While testing this I noticed that PutUDP does not report a SEND event for 
provenance. It would likely be a small fix to make PutUDP do this in onTrigger:

```
StopWatch stopWatch = new StopWatch(true);
sender.send(content.toByteArray());
session.getProvenanceReporter().send(flowFile, transitUri, 
stopWatch.getElapsed(TimeUnit.MILLISECONDS));
```
Do you want to add that to this PR, or we can create another JIRA since 
technically it is an existing problem?


> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2839) Add a confirmation dialog when deleting a Controller Service

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795440#comment-15795440
 ] 

ASF GitHub Bot commented on NIFI-2839:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1384

NIFI-2839 Add a confirmation dialog when deleting a Controller Service

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2839

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1384


commit 6eb592bfd032404d402ccc9d83e2c4d524399b16
Author: Pierre Villard 
Date:   2017-01-03T16:24:12Z

NIFI-2839 Add a confirmation dialog when deleting a Controller Service




> Add a confirmation dialog when deleting a Controller Service
> 
>
> Key: NIFI-2839
> URL: https://issues.apache.org/jira/browse/NIFI-2839
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Priority: Minor
>  Labels: UI
>
> As soon as the user selects a Controller Service for deletion it is 
> immediately deleted.  There should be a warning/confirmation dialog to make 
> sure this is the user's intended selection/action.
> This is especially needed because it is possible in the UI to create 
> Controller Services with the same name, so it can be ambiguous which one is 
> being selected for deletion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1384: NIFI-2839 Add a confirmation dialog when deleting a...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1384

NIFI-2839 Add a confirmation dialog when deleting a Controller Service

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2839

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1384


commit 6eb592bfd032404d402ccc9d83e2c4d524399b16
Author: Pierre Villard 
Date:   2017-01-03T16:24:12Z

NIFI-2839 Add a confirmation dialog when deleting a Controller Service




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1893) Add processor for validating JSON

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795375#comment-15795375
 ] 

ASF GitHub Bot commented on NIFI-1893:
--

Github user basvank commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@pvillard31 @mattyb149 thanks for the information, that didn't become clear 
from this PR.
It seems to be possible to implement in an ASF-friendly way using 
https://github.com/daveclayton/json-schema-validator (ASL 2.0), which depends 
on https://github.com/FasterXML/jackson-core (Apache 2.0) instead of json.org.
I will see if I can find the time to do this myself, but if not it can 
serve as a pointer for others.


> Add processor for validating JSON
> -
>
> Key: NIFI-1893
> URL: https://issues.apache.org/jira/browse/NIFI-1893
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Matt Burgess
>
> NiFi has a ValidateXml processor to validate incoming XML files against a 
> schema. It would be good to have one to validate JSON files as well.
> For example, an input JSON of:
> {
>   name: "Test",
>   timestamp: 1463499695,
>   tags: {
>"host": "Test_1",
>"ip" : "1.1.1.1"
>   },
>   fields: {
> "cpu": 10.2,
> "load": 15.6
>   }
> }
> Could be validated successfully against the following "schema":
> {
>   "type": "object",
>   "required": ["name", "tags", "timestamp", "fields"],
>   "properties": {
> "name": {"type": "string"},
> "timestamp": {"type": "integer"},
> "tags": {"type": "object", "items": {"type": "string"}},
> "fields": { "type": "object"}
>   }
> }
> There is at least one ASF-friendly library that could be used for 
> implementation: https://github.com/everit-org/json-schema



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1037: NIFI-1893 Add processor for validating JSON

2017-01-03 Thread basvank
Github user basvank commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@pvillard31 @mattyb149 thanks for the information, that didn't become clear 
from this PR.
It seems to be possible to implement in an ASF-friendly way using 
https://github.com/daveclayton/json-schema-validator (ASL 2.0), which depends 
on https://github.com/FasterXML/jackson-core (Apache 2.0) instead of json.org.
I will see if I can find the time to do this myself, but if not it can 
serve as a pointer for others.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1037: NIFI-1893 Add processor for validating JSON

2017-01-03 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@basvank 
Due to licensing issues:
https://issues.apache.org/jira/browse/NIFI-2991

We unfortunately had to remove this processor... we are looking for a new 
solution using another library. However, in the meantime, you can manually 
build this processor using this PR, and add the generated NAR to your NiFi 
instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1037: NIFI-1893 Add processor for validating JSON

2017-01-03 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1037
  
I believe it had to be removed because it uses or has a dependency on 
JSON.org-licensed JARs, which was determined to be Category X for the Apache 
Software Foundation. It was removed in #1230 under 
[NIFI-2991](https://issues.apache.org/jira/browse/NIFI-2991). I encourage you 
to change the underlying JSON libraries such that the licensing is 
ASF-friendly, then we can review and merge the updated PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1893) Add processor for validating JSON

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795338#comment-15795338
 ] 

ASF GitHub Bot commented on NIFI-1893:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1037
  
I believe it had to be removed because it uses or has a dependency on 
JSON.org-licensed JARs, which was determined to be Category X for the Apache 
Software Foundation. It was removed in #1230 under 
[NIFI-2991](https://issues.apache.org/jira/browse/NIFI-2991). I encourage you 
to change the underlying JSON libraries such that the licensing is 
ASF-friendly, then we can review and merge the updated PR.


> Add processor for validating JSON
> -
>
> Key: NIFI-1893
> URL: https://issues.apache.org/jira/browse/NIFI-1893
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Matt Burgess
>
> NiFi has a ValidateXml processor to validate incoming XML files against a 
> schema. It would be good to have one to validate JSON files as well.
> For example, an input JSON of:
> {
>   name: "Test",
>   timestamp: 1463499695,
>   tags: {
>"host": "Test_1",
>"ip" : "1.1.1.1"
>   },
>   fields: {
> "cpu": 10.2,
> "load": 15.6
>   }
> }
> Could be validated successfully against the following "schema":
> {
>   "type": "object",
>   "required": ["name", "tags", "timestamp", "fields"],
>   "properties": {
> "name": {"type": "string"},
> "timestamp": {"type": "integer"},
> "tags": {"type": "object", "items": {"type": "string"}},
> "fields": { "type": "object"}
>   }
> }
> There is at least one ASF-friendly library that could be used for 
> implementation: https://github.com/everit-org/json-schema



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1893) Add processor for validating JSON

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795335#comment-15795335
 ] 

ASF GitHub Bot commented on NIFI-1893:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@basvank 
Due to licensing issues:
https://issues.apache.org/jira/browse/NIFI-2991

We unfortunately had to remove this processor... we are looking for a new 
solution using another library. However, in the meantime, you can manually 
build this processor using this PR, and add the generated NAR to your NiFi 
instance.


> Add processor for validating JSON
> -
>
> Key: NIFI-1893
> URL: https://issues.apache.org/jira/browse/NIFI-1893
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Matt Burgess
>
> NiFi has a ValidateXml processor to validate incoming XML files against a 
> schema. It would be good to have one to validate JSON files as well.
> For example, an input JSON of:
> {
>   name: "Test",
>   timestamp: 1463499695,
>   tags: {
>"host": "Test_1",
>"ip" : "1.1.1.1"
>   },
>   fields: {
> "cpu": 10.2,
> "load": 15.6
>   }
> }
> Could be validated successfully against the following "schema":
> {
>   "type": "object",
>   "required": ["name", "tags", "timestamp", "fields"],
>   "properties": {
> "name": {"type": "string"},
> "timestamp": {"type": "integer"},
> "tags": {"type": "object", "items": {"type": "string"}},
> "fields": { "type": "object"}
>   }
> }
> There is at least one ASF-friendly library that could be used for 
> implementation: https://github.com/everit-org/json-schema



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1037: NIFI-1893 Add processor for validating JSON

2017-01-03 Thread basvank
Github user basvank commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@pvillard31 (and @bartoszjkwozniak) is it possible that something went 
wrong when merging this feature, maybe because the checks failed? It seems the 
ValidateJson processor did not end up in the master branch or any of the 
releases (I'm on 1.1.1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1893) Add processor for validating JSON

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795326#comment-15795326
 ] 

ASF GitHub Bot commented on NIFI-1893:
--

Github user basvank commented on the issue:

https://github.com/apache/nifi/pull/1037
  
@pvillard31 (and @bartoszjkwozniak) is it possible that something went 
wrong when merging this feature, maybe because the checks failed? It seems the 
ValidateJson processor did not end up in the master branch or any of the 
releases (I'm on 1.1.1).


> Add processor for validating JSON
> -
>
> Key: NIFI-1893
> URL: https://issues.apache.org/jira/browse/NIFI-1893
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Matt Burgess
>
> NiFi has a ValidateXml processor to validate incoming XML files against a 
> schema. It would be good to have one to validate JSON files as well.
> For example, an input JSON of:
> {
>   name: "Test",
>   timestamp: 1463499695,
>   tags: {
>"host": "Test_1",
>"ip" : "1.1.1.1"
>   },
>   fields: {
> "cpu": 10.2,
> "load": 15.6
>   }
> }
> Could be validated successfully against the following "schema":
> {
>   "type": "object",
>   "required": ["name", "tags", "timestamp", "fields"],
>   "properties": {
> "name": {"type": "string"},
> "timestamp": {"type": "integer"},
> "tags": {"type": "object", "items": {"type": "string"}},
> "fields": { "type": "object"}
>   }
> }
> There is at least one ASF-friendly library that could be used for 
> implementation: https://github.com/everit-org/json-schema



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2853) Improve ListHDFS state tracking

2017-01-03 Thread Pierre Villard (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795308#comment-15795308
 ] 

Pierre Villard commented on NIFI-2853:
--

With NIFI-1526, it is now possible to define a default scheduling strategy in 
the processors. I think it would make sense to add:

{{@DefaultSchedule(strategy = SchedulingStrategy.PRIMARY_NODE_ONLY)}}

in the concerned processors. Thoughts?

> Improve ListHDFS state tracking
> ---
>
> Key: NIFI-2853
> URL: https://issues.apache.org/jira/browse/NIFI-2853
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bryan Bende
>Priority: Minor
>
> Currently ListHDFS tracks two properties in state management, 
> "listing.timestamp" and "emitted.timestamp". In the 1.0.0 release, the 
> directory property now supports expression language which means the directory 
> being listed could dynamically change on any execution of the processor. 
> The processor should be changed to store state specific to the directory that 
> was listed, for example "listing.timestamp.dir1" and "emitted.timestamp.dir1".
> This would also help in a clustered scenario... currently ListHDFS has to be 
> run on primary node only, otherwise each node will be overwriting each others 
> state and producing unexpected results. With the above improvement, if the 
> directory evaluated to a unique path for each node, it would store the state 
> of each of those path separately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3231) PutTCP and PutUDP should support EL for host and port

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795311#comment-15795311
 ] 

ASF GitHub Bot commented on NIFI-3231:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1361
  
Reviewing...


> PutTCP and PutUDP should support EL for host and port
> -
>
> Key: NIFI-3231
> URL: https://issues.apache.org/jira/browse/NIFI-3231
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0, 1.1.0, 1.1.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>
> PutTCP and PutUDP should support expression language (without a flow file) 
> for host and port in order to make use of the variable registry and reference 
> different hosts and ports per environment.
> Relevant code:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java#L110
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutUDP.java#L94



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2017-01-03 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1361
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

2017-01-03 Thread Matt Gilman (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman reassigned NIFI-3251:
-

Assignee: Matt Gilman

> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2857) Document Site 2 Site protocol

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2857:
-
Component/s: Documentation & Website
 Issue Type: Improvement  (was: Bug)

> Document Site 2 Site protocol
> -
>
> Key: NIFI-2857
> URL: https://issues.apache.org/jira/browse/NIFI-2857
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Reporter: Andre
>
> It would be great if we could document the Site 2 Site protocol, in special, 
> the ability to publish content to RPGs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende resolved NIFI-3240.
---
Resolution: Fixed

> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2859) List + Fetch HDFS processors are reading part files from HDFS

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795294#comment-15795294
 ] 

ASF GitHub Bot commented on NIFI-2859:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1383

NIFI-2859 - Ignore files starting with a dot in ListHDFS

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2859

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1383


commit 7c412bea46ea568b24e6589759054a8babcd1a5e
Author: Pierre Villard 
Date:   2017-01-03T15:22:11Z

NIFI-2859 - Ignore files starting with a dot in ListHDFS




> List + Fetch HDFS processors are reading part files from HDFS
> -
>
> Key: NIFI-2859
> URL: https://issues.apache.org/jira/browse/NIFI-2859
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Mahesh Nayak
>
> Create the following ProcessGroups
> GetFile --> PutHdfs --> PutFile
> ListHDFS --> FetchHdfs --> putFile
> 2. Now start both the processGroups
> 3. Write lots of files into HDFS so that ListHDFS keeps listing and FetchHdfs 
> fetches.
> 4. An exception is thrown because the processor reads the part file from the 
> putHdfs folder
> {code:none}
> java.io.FileNotFoundException: File does not exist: 
> /tmp/HDFSProcessorsTest_visjJMcHORUwigw/.ycnVSpBOzEaoTWk_7f37d5af-d4a4-4521-b60d-c3c11ae19669
> at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:71)
> at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:61)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInt(FSNamesystem.java:1860)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1831)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1744)
> {code}
> Note that eventually the file is copied to the output successfully, but at 
> the same time there are some files in the failure/comms failure relationship



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3240:
--
Fix Version/s: 1.2.0

> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1383

NIFI-2859 - Ignore files starting with a dot in ListHDFS

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2859

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1383


commit 7c412bea46ea568b24e6589759054a8babcd1a5e
Author: Pierre Villard 
Date:   2017-01-03T15:22:11Z

NIFI-2859 - Ignore files starting with a dot in ListHDFS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2859) List + Fetch HDFS processors are reading part files from HDFS

2017-01-03 Thread Pierre Villard (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795291#comment-15795291
 ] 

Pierre Villard commented on NIFI-2859:
--

The problem is that PutHDFS is using a dot as a prefix when putting files into 
HDFS and then the processor renames the files. The easiest fix is to remove 
files starting with a "." from the listed files (I'll issue a PR implementing 
this change). However, one could say that this is a breaking change even though 
I believe that listing such files is a bug. If this change is not acceptable, 
another option is to add a true/false property ("ignore temp files") to let the 
user choose the behavior but it seems like an overkill and users would 
certainly ask why this property is defaulted to false.

> List + Fetch HDFS processors are reading part files from HDFS
> -
>
> Key: NIFI-2859
> URL: https://issues.apache.org/jira/browse/NIFI-2859
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Mahesh Nayak
>
> Create the following ProcessGroups
> GetFile --> PutHdfs --> PutFile
> ListHDFS --> FetchHdfs --> putFile
> 2. Now start both the processGroups
> 3. Write lots of files into HDFS so that ListHDFS keeps listing and FetchHdfs 
> fetches.
> 4. An exception is thrown because the processor reads the part file from the 
> putHdfs folder
> {code:none}
> java.io.FileNotFoundException: File does not exist: 
> /tmp/HDFSProcessorsTest_visjJMcHORUwigw/.ycnVSpBOzEaoTWk_7f37d5af-d4a4-4521-b60d-c3c11ae19669
> at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:71)
> at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:61)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInt(FSNamesystem.java:1860)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1831)
> at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1744)
> {code}
> Note that eventually the file is copied to the output successfully, but at 
> the same time there are some files in the failure/comms failure relationship



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795286#comment-15795286
 ] 

ASF GitHub Bot commented on NIFI-3240:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1352


> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1352: NIFI-3240 - AttributesToJson performance improvemen...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1352


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795284#comment-15795284
 ] 

ASF subversion and git services commented on NIFI-3240:
---

Commit 1b4729e448394177cddeccb700f9215d6ec7b570 in nifi's branch 
refs/heads/master from [~bryanrosan...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1b4729e ]

NIFI-3240 - AttributesToJson performance improvements

This closes #1352.

Signed-off-by: Bryan Bende 


> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795281#comment-15795281
 ] 

ASF GitHub Bot commented on NIFI-3240:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1352
  
+1 Looks good, I'll get this merged in, thanks!


> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1352: NIFI-3240 - AttributesToJson performance improvements

2017-01-03 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1352
  
+1 Looks good, I'll get this merged in, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1352: NIFI-3240 - AttributesToJson performance improvements

2017-01-03 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1352
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3240) AttributesToJson performance improvements

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795235#comment-15795235
 ] 

ASF GitHub Bot commented on NIFI-3240:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1352
  
Reviewing...


> AttributesToJson performance improvements
> -
>
> Key: NIFI-3240
> URL: https://issues.apache.org/jira/browse/NIFI-3240
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
> Attachments: after.png, before.png
>
>
> AttributesToJson does a lot of work in every onTrigger() that it doesn't need 
> to.
> A lot of the attributes map logic can be done at schedule time so that it 
> doesn't need to be done on every trigger.
> Also, all of the properties gotten from the process context can be fetched in 
> onSchedule()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2860) Use different properties for JVM Heap Max and Min values

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2860:
-
Assignee: Pierre Villard
  Status: Patch Available  (was: Open)

> Use different properties for JVM Heap Max and Min values
> 
>
> Key: NIFI-2860
> URL: https://issues.apache.org/jira/browse/NIFI-2860
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Configuration
>Affects Versions: 0.6.1
>Reporter: Andrew Festa
>Assignee: Pierre Villard
>
> In the bootstrap.conf, the JVM memory settings are using maven filtering to 
> set the default values.  Currently the JVM memory settings (java.arg.2 and 
> java.arg.3) are using the same property.  These should be using different 
> values so we can override them to different values.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf#L35-L36



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2860) Use different properties for JVM Heap Max and Min values

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795204#comment-15795204
 ] 

ASF GitHub Bot commented on NIFI-2860:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1382

NIFI-2860 Use different properties for JVM Heap Max and Min values

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1382


commit fc002f7eee869544d09da9f6684bc53fdd4c2358
Author: Pierre Villard 
Date:   2017-01-03T14:35:00Z

NIFI-2860 Use different properties for JVM Heap Max and Min values




> Use different properties for JVM Heap Max and Min values
> 
>
> Key: NIFI-2860
> URL: https://issues.apache.org/jira/browse/NIFI-2860
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Configuration
>Affects Versions: 0.6.1
>Reporter: Andrew Festa
>
> In the bootstrap.conf, the JVM memory settings are using maven filtering to 
> set the default values.  Currently the JVM memory settings (java.arg.2 and 
> java.arg.3) are using the same property.  These should be using different 
> values so we can override them to different values.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf#L35-L36



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1382: NIFI-2860 Use different properties for JVM Heap Max...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1382

NIFI-2860 Use different properties for JVM Heap Max and Min values

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1382


commit fc002f7eee869544d09da9f6684bc53fdd4c2358
Author: Pierre Villard 
Date:   2017-01-03T14:35:00Z

NIFI-2860 Use different properties for JVM Heap Max and Min values




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2871) nifi-app.log disappears after being tailed by "TailFile" for a while

2017-01-03 Thread Pierre Villard (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795167#comment-15795167
 ] 

Pierre Villard commented on NIFI-2871:
--

Hey [~h_liu],
I tried to reproduce the error by tailing NiFi log files (both in single file 
and multiple files modes) and generating lots of messages in the log files 
(changed the rollover frequency to every minute) but everything worked as 
expected. By any chance do you have a template to reproduce the issue? or 
details about the environment?

> nifi-app.log disappears after being tailed by "TailFile" for a while
> 
>
> Key: NIFI-2871
> URL: https://issues.apache.org/jira/browse/NIFI-2871
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Haimo Liu
>
> If NIFI tries to roll “nifi-app.log” into “nifi-app-timestamp.log”, while the 
> log file is being tailed, nifi-app.log will be gone…not sure if this happens 
> 100% of time, but I am able to reproduce the issue consistently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-3248) GetSolr can miss recently updated documents

2017-01-03 Thread Bryan Bende (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795156#comment-15795156
 ] 

Bryan Bende commented on NIFI-3248:
---

[~ijokarumawak] thanks for writing this up! I like the idea of the commit 
lag-time, not sure the best name for it but maybe something like "Time Range 
Overlap"?

I was thinking that if we add that, we might also need to keep track of all the 
document ids from the previous iteration to avoid duplicates, in case someone 
sets the overlap greater than the actual commit lag. We could compare each id 
against the last batch and only emit the document if it wasn't in the last 
batch. Thoughts?

> GetSolr can miss recently updated documents
> ---
>
> Key: NIFI-3248
> URL: https://issues.apache.org/jira/browse/NIFI-3248
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.5.1, 0.7.0, 0.6.1, 1.1.0, 0.7.1, 
> 1.0.1
>Reporter: Koji Kawamura
> Attachments: nifi-flow.png, query-result-with-curly-bracket.png, 
> query-result-with-square-bracket.png
>
>
> GetSolr holds the last query timestamp so that it only fetches documents 
> those have been added or updated since the last query.
> However, GetSolr misses some of those updated documents, and once the 
> documents date field value becomes older than last query timestamp, the 
> document won't be able to be queried by GetSolr any more.
> This JIRA is for tracking the process of investigating this behavior, and 
> discussion on them.
> Here are things that can be a cause of this behavior:
> |#|Short description|Should we address it?|
> |1|Timestamp range filter, curly or square bracket?|No|
> |2|Timezone difference between update and query|Additional docs might be 
> helpful|
> |3|Lag comes from NearRealTIme nature of Solr|Should be documented at least, 
> add 'commit lag-time'?|
> h2. 1. Timestamp range filter, curly or square bracket?
> At the first glance, using curly and square bracket in mix looked strange 
> ([source 
> code|https://github.com/apache/nifi/blob/support/nifi-0.5.x/nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java#L202]).
>  But these difference has a meaning.
> The square bracket on the range query is inclusive and the curly bracket is 
> exclusive. If we use inclusive on both sides and a document has a time stamp 
> exactly on the boundary then it could be returned in two consecutive 
> executions, and we only want it in one.
> This is intentional, and it should be as it is.
> h2. 2. Timezone difference between update and query
> Solr treats date fields as [UTC 
> representation|https://cwiki.apache.org/confluence/display/solr/Working+with+Dates|].
>  If date field String value of an updated document represents time without 
> timezone, and NiFi is running on an environment using timezone other than 
> UTC, GetSolr can't perform date range query as users expect.
> Let's say NiFi is running with JST(UTC+9). A process added a document to Solr 
> at 15:00 JST. But the date field doesn't have timezone. So, Solr indexed it 
> as 15:00 UTC. Then GetSolr performs range query at 15:10 JST, targeting any 
> documents updated from 15:00 to 15:10 JST. GetSolr formatted dates using UTC, 
> i.e. 6:00 to 6:10 UTC. The updated document won't be matched with the date 
> range filter.
> To avoid this, updated documents must have proper timezone in date field 
> string representation.
> If one uses NiFi expression language to set current timestamp to that date 
> field, following NiFi expression can be used:
> {code}
> ${now():format("-MM-dd'T'HH:mm:ss.SSSZ")}
> {code}
> It will produce a result like:
> {code}
> 2016-12-27T15:30:04.895+0900
> {code}
> Then it will be indexed in Solr with UTC and will be queried by GetSolr as 
> expected.
> h2. 3. Lag comes from NearRealTIme nature of Solr
> Solr provides Near Real Time search capability, that means, the recently 
> updated documents can be queried in Near Real Time, but it's not real time. 
> This latency can be controlled by either on client side which requests the 
> update operation by specifying "commitWithin" parameter, or on the Solr 
> server side, "autoCommit" and "autoSoftCommit" in 
> [solrconfig.xml|https://cwiki.apache.org/confluence/display/solr/UpdateHandlers+in+SolrConfig#UpdateHandlersinSolrConfig-Commits].
> Since commit and updating index can be costly, it's recommended to set this 
> interval long enough up to the maximum tolerable latency.
> However, this can be problematic with GetSolr. For instance, as shown in the 
> simple NiFi flow below, GetSolr can miss updated documents:
> {code}
> t1: GetSolr queried
> t2: GenerateFlowFile set date = t2
> t3: PutSolrContentStream stored new doc
> t4: GetSolr queried again, from t1 

[jira] [Resolved] (NIFI-2870) Allow to set replication factor in Kafka Consume Processor

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard resolved NIFI-2870.
--
Resolution: Not A Problem

> Allow to set replication factor in Kafka Consume Processor
> --
>
> Key: NIFI-2870
> URL: https://issues.apache.org/jira/browse/NIFI-2870
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0
> Environment: standard installation
>Reporter: Stephane Maarek
>
> I deployed a Kafka cluster with one broker only (I know it's bad), but then 
> when trying to read from the ConsumeKafka0.10, I came across this error:
> replication factor: 3 larger than available brokers: 1
> I believe the replication factor should be a parameter in the processor?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2908) Add TimeZone support to EL date functions

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2908:
-
Issue Type: Improvement  (was: Bug)

> Add TimeZone support to EL date functions
> -
>
> Key: NIFI-2908
> URL: https://issues.apache.org/jira/browse/NIFI-2908
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Dave Torok
>Assignee: Pierre Villard
>Priority: Minor
>
> Currently the toDate() and format() functions under the hood use a 
> SimpleDateFormat with the current system timezone.  This leads to hard to 
> locate data inconsistency errors when parsing and then generating date 
> strings when the date strings are not in the same or current time zone.
> Even the example given in the documentation
> ${time:format("/MM/dd HH:mm:ss.SSS'Z'")}
> will give an incorrect output when the system timezone is not set to GMT.
> suggestion is to add a variant to toDate(String tz) and format(String tz) 
> which accepts a timezone of Java nomenclature which can be set with 
> "SimpleDateFormat.setTimeZone(TimeZone.getTimeZone(tz))"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2908) Add TimeZone support to EL date functions

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2908:
-
Assignee: Pierre Villard
  Status: Patch Available  (was: Open)

> Add TimeZone support to EL date functions
> -
>
> Key: NIFI-2908
> URL: https://issues.apache.org/jira/browse/NIFI-2908
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Dave Torok
>Assignee: Pierre Villard
>Priority: Minor
>
> Currently the toDate() and format() functions under the hood use a 
> SimpleDateFormat with the current system timezone.  This leads to hard to 
> locate data inconsistency errors when parsing and then generating date 
> strings when the date strings are not in the same or current time zone.
> Even the example given in the documentation
> ${time:format("/MM/dd HH:mm:ss.SSS'Z'")}
> will give an incorrect output when the system timezone is not set to GMT.
> suggestion is to add a variant to toDate(String tz) and format(String tz) 
> which accepts a timezone of Java nomenclature which can be set with 
> "SimpleDateFormat.setTimeZone(TimeZone.getTimeZone(tz))"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2908) Add TimeZone support to EL date functions

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794930#comment-15794930
 ] 

ASF GitHub Bot commented on NIFI-2908:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1381

NIFI-2908 Added TimeZone to toDate() and format() EL

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2908

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1381


commit 92336f0551516cf2d2ea9c9e6b1b2a235f1a1c62
Author: Pierre Villard 
Date:   2017-01-03T12:16:40Z

NIFI-2908 Added TimeZone to toDate() and format() EL




> Add TimeZone support to EL date functions
> -
>
> Key: NIFI-2908
> URL: https://issues.apache.org/jira/browse/NIFI-2908
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Dave Torok
>Priority: Minor
>
> Currently the toDate() and format() functions under the hood use a 
> SimpleDateFormat with the current system timezone.  This leads to hard to 
> locate data inconsistency errors when parsing and then generating date 
> strings when the date strings are not in the same or current time zone.
> Even the example given in the documentation
> ${time:format("/MM/dd HH:mm:ss.SSS'Z'")}
> will give an incorrect output when the system timezone is not set to GMT.
> suggestion is to add a variant to toDate(String tz) and format(String tz) 
> which accepts a timezone of Java nomenclature which can be set with 
> "SimpleDateFormat.setTimeZone(TimeZone.getTimeZone(tz))"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1381: NIFI-2908 Added TimeZone to toDate() and format() E...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1381

NIFI-2908 Added TimeZone to toDate() and format() EL

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2908

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1381


commit 92336f0551516cf2d2ea9c9e6b1b2a235f1a1c62
Author: Pierre Villard 
Date:   2017-01-03T12:16:40Z

NIFI-2908 Added TimeZone to toDate() and format() EL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2914) Wrong name in ERROR message

2017-01-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794604#comment-15794604
 ] 

ASF GitHub Bot commented on NIFI-2914:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1380

NIFI-2914 Fixed log message in AbstractMongoProcessor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2914

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1380


commit bfcd4e829e6e2c87b9e4f19516448905fb98691f
Author: Pierre Villard 
Date:   2017-01-03T09:17:15Z

NIFI-2914 Fixed message error in AbstractMongoProcessor




> Wrong name in ERROR message
> ---
>
> Key: NIFI-2914
> URL: https://issues.apache.org/jira/browse/NIFI-2914
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Priority: Trivial
>
> AbstractMongoProcessor has an ERROR message "Failed to schedule PutMongo due 
> to {}"\[1].  Change to not reference PutMongo...
> \[1] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java#L134



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2914) Wrong name in ERROR message

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2914:
-
Assignee: Pierre Villard
  Status: Patch Available  (was: Open)

> Wrong name in ERROR message
> ---
>
> Key: NIFI-2914
> URL: https://issues.apache.org/jira/browse/NIFI-2914
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Pierre Villard
>Priority: Trivial
>
> AbstractMongoProcessor has an ERROR message "Failed to schedule PutMongo due 
> to {}"\[1].  Change to not reference PutMongo...
> \[1] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java#L134



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1380: NIFI-2914 Fixed log message in AbstractMongoProcess...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1380

NIFI-2914 Fixed log message in AbstractMongoProcessor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-2914

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1380


commit bfcd4e829e6e2c87b9e4f19516448905fb98691f
Author: Pierre Villard 
Date:   2017-01-03T09:17:15Z

NIFI-2914 Fixed message error in AbstractMongoProcessor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-2917) Release capture of keyboard shortcuts when UI client is disconnected from server to allow Ctrl/Cmd + R for refresh

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2917:
-
Fix Version/s: 1.2.0

> Release capture of keyboard shortcuts when UI client is disconnected from 
> server to allow Ctrl/Cmd + R for refresh
> --
>
> Key: NIFI-2917
> URL: https://issues.apache.org/jira/browse/NIFI-2917
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andy LoPresto
>Assignee: Scott Aslan
>Priority: Trivial
>  Labels: easyfix
> Fix For: 1.2.0
>
>
> When a browser window is open and the NiFi UI is loaded, and then the server 
> is stopped, the UI displays a page explaining that the connection is not 
> available. 
> This UI page captures keyboard commands, so when the server is restarted, 
> pressing Ctrl/Cmd + R does not execute the browser's refresh function. 
> Rather, the refresh menu or toolbar item must be invoked using the mouse. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2944) Validate the configured remote input hostname

2017-01-03 Thread Pierre Villard (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-2944:
-
Fix Version/s: 1.2.0

> Validate the configured remote input hostname
> -
>
> Key: NIFI-2944
> URL: https://issues.apache.org/jira/browse/NIFI-2944
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Joseph Percivall
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.2.0
>
>
> Currently NiFi doesn't do any validation on what is set for 
> "nifi.remote.input.host". For example, I ran across 1 node cluster configured 
> with a remote input hostname that started with a "http:// ...". This cluster 
> started up and everything seemed fine on it's end but on the client side it 
> failed.
> After the initial connection it received "http:// ..." as the hostname for it 
> to connect to causing UnknownHostExceptions.
> NiFi should validate that the value set for the remote input host is valid in 
> order to avoid this issue.
> Example:
> 2016-10-25 11:18:29,132 ERROR [Timer-Driven Process Thread-6] 
> o.a.nifi.remote.StandardRemoteGroupPort RemoteGroupPort[name=From 
> MiNiFi,target=http://:9090/nifi/] failed to communicate with 
> http://:9090/nifi/ due to java.net.UnknownHostException
> 2016-10-25 11:18:29,136 ERROR [Timer-Driven Process Thread-6] 
> o.a.nifi.remote.StandardRemoteGroupPort 
> java.net.UnknownHostException: null
>   at sun.nio.ch.Net.translateException(Net.java:155) ~[na:1.8.0_74]
>   at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:127) ~[na:1.8.0_74]
>   at 
> org.apache.nifi.remote.client.socket.EndpointConnectionPool.establishSiteToSiteConnection(EndpointConnectionPool.java:712)
>  ~[nifi-site-to-site-client-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.remote.client.socket.EndpointConnectionPool.establishSiteToSiteConnection(EndpointConnectionPool.java:685)
>  ~[nifi-site-to-site-client-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.remote.client.socket.EndpointConnectionPool.getEndpointConnection(EndpointConnectionPool.java:301)
>  ~[nifi-site-to-site-client-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.remote.client.socket.SocketClient.createTransaction(SocketClient.java:129)
>  ~[nifi-site-to-site-client-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.remote.StandardRemoteGroupPort.onTrigger(StandardRemoteGroupPort.java:171)
>  ~[nifi-site-to-site-0.6.1.jar:0.6.1]
>   at org.apache.nifi.controller.AbstractPort.onTrigger(AbstractPort.java:227) 
> [nifi-framework-core-api-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.controller.tasks.ContinuallyRunConnectableTask.call(ContinuallyRunConnectableTask.java:81)
>  [nifi-framework-core-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.controller.tasks.ContinuallyRunConnectableTask.call(ContinuallyRunConnectableTask.java:40)
>  [nifi-framework-core-0.6.1.jar:0.6.1]
>   at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:123)
>  [nifi-framework-core-0.6.1.jar:0.6.1]
>   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_74]
>   at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
> [na:1.8.0_74]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_74]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>  [na:1.8.0_74]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_74]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_74]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_74]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)