[GitHub] [nifi] levilentz commented on a change in pull request #5444: NIFI-9286: Add expression language to JOLT processors and fixes the custom module implementation to use custom jars in the proces
levilentz commented on a change in pull request #5444:
URL: https://github.com/apache/nifi/pull/5444#discussion_r738861611
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
##
@@ -208,7 +209,7 @@
final ClassLoader customClassLoader;
try {
-if (modulePath != null) {
+if (modulePath != null &&
!validationContext.isExpressionLanguagePresent(modulePath)) {
Review comment:
Removed this code because of the comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a change in pull request #5444: NIFI-9286: Add expression language to JOLT processors and fixes the custom module implementation to use custom jars in the proces
levilentz commented on a change in pull request #5444:
URL: https://github.com/apache/nifi/pull/5444#discussion_r738861493
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
##
@@ -306,26 +316,33 @@ public void process(OutputStream out) throws IOException {
logger.info("Transformed {}", new Object[]{original});
}
-private JoltTransform getTransform(final ProcessContext context, final
FlowFile flowFile) throws Exception {
+private JoltTransform getTransform(final ProcessContext context, final
FlowFile flowFile) {
final Optional specString;
if (context.getProperty(JOLT_SPEC).isSet()) {
specString =
Optional.of(context.getProperty(JOLT_SPEC).evaluateAttributeExpressions(flowFile).getValue());
} else {
specString = Optional.empty();
}
-return transformCache.get(specString);
+return transformCache.get(specString, currString -> {
+try {
+return createTransform(context, currString.orElse(null),
flowFile);
+} catch (Exception e) {
+getLogger().error("Problem getting transform", e);
+}
+return null;
+});
}
@OnScheduled
public void setup(final ProcessContext context) {
int maxTransformsToCache =
context.getProperty(TRANSFORM_CACHE_SIZE).asInteger();
transformCache = Caffeine.newBuilder()
.maximumSize(maxTransformsToCache)
-.build(specString -> createTransform(context,
specString.orElse(null)));
+.build();
try {
-if (context.getProperty(MODULES).isSet()) {
+if (context.getProperty(MODULES).isSet() &&
!context.getProperty(MODULES).isExpressionLanguagePresent()) {
Review comment:
Good catch. After review, I actually think the modules should only be
```ExpressionLanguageScope.VARIABLE_REGISTRY``` for the MODULES properties. The
overhead associated with each flowfile having its own associated jar would be
very large and an unlikely use case. Therefore I changed that association and
removed the complex (and worrisome) expression language exclusions that were
being done on the validate step in both the JSON jolt processor and the Jolt
Record processor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a change in pull request #5471: NIFI-9308: Created EmailRecordSinkService for Reporting Tasks
Lehel44 commented on a change in pull request #5471:
URL: https://github.com/apache/nifi/pull/5471#discussion_r738858084
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-sink-service-bundle/nifi-record-sink-service/src/main/java/org/apache/nifi/record/sink/EmailRecordSink.java
##
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink;
+
+import jakarta.mail.Authenticator;
+import jakarta.mail.Message;
+import jakarta.mail.MessagingException;
+import jakarta.mail.PasswordAuthentication;
+import jakarta.mail.Session;
+import jakarta.mail.Transport;
+import jakarta.mail.internet.AddressException;
+import jakarta.mail.internet.InternetAddress;
+import jakarta.mail.internet.MimeMessage;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.WriteResult;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordSet;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+public class EmailRecordSink extends AbstractControllerService implements
RecordSinkService {
+
+public static final PropertyDescriptor FROM = new
PropertyDescriptor.Builder()
+.name("from")
+.displayName("From")
+.description("Specifies the Email address to use as the sender. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor TO = new
PropertyDescriptor.Builder()
+.name("to")
+.displayName("To")
+.description("The recipients to include in the To-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor CC = new
PropertyDescriptor.Builder()
+.name("cc")
+.displayName("CC")
+.description("The recipients to include in the CC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor BCC = new
PropertyDescriptor.Builder()
+.name("bcc")
+.displayName("BCC")
+.description("The recipients to include in the BCC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor SUBJECT = new
PropertyDescriptor.Builder()
+
[GitHub] [nifi] Lehel44 commented on a change in pull request #5471: NIFI-9308: Created EmailRecordSinkService for Reporting Tasks
Lehel44 commented on a change in pull request #5471:
URL: https://github.com/apache/nifi/pull/5471#discussion_r738854734
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-sink-service-bundle/nifi-record-sink-service/src/main/java/org/apache/nifi/record/sink/EmailRecordSink.java
##
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink;
+
+import jakarta.mail.Authenticator;
+import jakarta.mail.Message;
+import jakarta.mail.MessagingException;
+import jakarta.mail.PasswordAuthentication;
+import jakarta.mail.Session;
+import jakarta.mail.Transport;
+import jakarta.mail.internet.AddressException;
+import jakarta.mail.internet.InternetAddress;
+import jakarta.mail.internet.MimeMessage;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.WriteResult;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordSet;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+public class EmailRecordSink extends AbstractControllerService implements
RecordSinkService {
+
+public static final PropertyDescriptor FROM = new
PropertyDescriptor.Builder()
+.name("from")
+.displayName("From")
+.description("Specifies the Email address to use as the sender. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor TO = new
PropertyDescriptor.Builder()
+.name("to")
+.displayName("To")
+.description("The recipients to include in the To-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor CC = new
PropertyDescriptor.Builder()
+.name("cc")
+.displayName("CC")
+.description("The recipients to include in the CC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor BCC = new
PropertyDescriptor.Builder()
+.name("bcc")
+.displayName("BCC")
+.description("The recipients to include in the BCC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor SUBJECT = new
PropertyDescriptor.Builder()
+
[GitHub] [nifi] levilentz commented on a change in pull request #5444: NIFI-9286: Add expression language to JOLT processors and fixes the custom module implementation to use custom jars in the proces
levilentz commented on a change in pull request #5444:
URL: https://github.com/apache/nifi/pull/5444#discussion_r738852722
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
##
@@ -208,7 +209,7 @@
final ClassLoader customClassLoader;
try {
-if (modulePath != null) {
+if (modulePath != null &&
!validationContext.isExpressionLanguagePresent(modulePath)) {
Review comment:
That is effectively taken care of at JoltTransformRecord lines 259-266.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #5366: NIFI-9194: Upsert for Oracle12+
mattyb149 commented on a change in pull request #5366:
URL: https://github.com/apache/nifi/pull/5366#discussion_r738790838
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/Oracle12DatabaseAdapter.java
##
@@ -93,4 +100,98 @@ public String getSelectStatement(String tableName, String
columnNames, String wh
public String getTableAliasClause(String tableName) {
return tableName;
}
+
+@Override
+public boolean supportsUpsert() {
+ return true;
+}
+
+@Override
+public String getUpsertStatement(String table, List columnNames,
Collection uniqueKeyColumnNames) {
+Preconditions.checkArgument(!StringUtils.isEmpty(table), "Table name
cannot be null or blank");
Review comment:
These should throw an `IllegalArgumentException` rather than using the
`Preconditions` class from an Avro shaded JAR. The conditions are simple enough
that the code will still be readable but without the possible performance hit
of using `Preconditions`
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/Oracle12DatabaseAdapter.java
##
@@ -16,9 +16,16 @@
*/
package org.apache.nifi.processors.standard.db.impl;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.stream.Collectors;
+
import org.apache.commons.lang3.StringUtils;
import org.apache.nifi.processors.standard.db.DatabaseAdapter;
+import avro.shaded.com.google.common.base.Preconditions;
+
/**
* A database adapter that generates MS SQL Compatible SQL.
Review comment:
Do you mind updating this comment? It was an oversight by copying from
another adapter. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] greyp9 commented on pull request #5307: NIFI-8917: add profiles for excluding minifi, nifi-registry, nifi-too…
greyp9 commented on pull request #5307: URL: https://github.com/apache/nifi/pull/5307#issuecomment-954263083 Hi @markobean. Nifty idea to break things out in this way. I like the idea of building only needed parts of the project for a given task, and I've also looked at this issue some. Have you thought about leveraging built-in Maven functionality to achieve a similar effect? The [-pl] and [-am] command-line switches provide the ability to build a given module, as well as any declared module dependencies. `mvn clean install -pl :nifi-assembly -am` - [builds 432 modules; excludes anything not declared as a "nifi-assembly" dependency] `mvn clean install -pl :minifi-c2-assembly -am` - [builds 75 modules...] `mvn clean install -pl :nifi-registry-assembly -am` - [builds 43 modules...] `mvn clean install -pl :nifi-stateless-assembly -am` - [builds 55 modules...] `mvn clean install -pl :nifi-registry-toolkit-assembly -pl :nifi-toolkit-assembly -pl :minifi-toolkit-assembly -am` - [builds 90 modules...] There appears to be some module dependency duplication with the toolkits, it might make sense to nest each of these under the appropriate "*-assembly", or new meta-modules could be introduced to build everything associated with minifi, for example (meta-modules might also be a good home for the docker modules). Rather than changing the root POM, maybe this could be expressed by adding some documentation, perhaps a section in README.MD. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-9194) Upsert for Oracle12+
[ https://issues.apache.org/jira/browse/NIFI-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-9194: -- Assignee: (was: Matt Burgess) > Upsert for Oracle12+ > > > Key: NIFI-9194 > URL: https://issues.apache.org/jira/browse/NIFI-9194 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework > Environment: All OS >Reporter: ROBERTO SANTOS >Priority: Major > Labels: features > Original Estimate: 168h > Time Spent: 20m > Remaining Estimate: 23h 50m > > I have implemented Upsert capability for Oracle12+ in PutDatabaseRecord and > it’s Unity tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NIFI-9194) Upsert for Oracle12+
[ https://issues.apache.org/jira/browse/NIFI-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-9194: -- Assignee: Matt Burgess > Upsert for Oracle12+ > > > Key: NIFI-9194 > URL: https://issues.apache.org/jira/browse/NIFI-9194 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework > Environment: All OS >Reporter: ROBERTO SANTOS >Assignee: Matt Burgess >Priority: Major > Labels: features > Original Estimate: 168h > Time Spent: 20m > Remaining Estimate: 23h 50m > > I have implemented Upsert capability for Oracle12+ in PutDatabaseRecord and > it’s Unity tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 commented on pull request #5366: NIFI-9194: Upsert for Oracle12+
mattyb149 commented on pull request #5366: URL: https://github.com/apache/nifi/pull/5366#issuecomment-954239270 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1207: MINIFICPP-1674 fix azure-sdk target name, use install dir
szaszm commented on a change in pull request #1207: URL: https://github.com/apache/nifi-minifi-cpp/pull/1207#discussion_r738782522 ## File path: cmake/BundledAzureSdkCpp.cmake ## @@ -56,6 +63,7 @@ function(use_bundled_libazure SOURCE_DIR BINARY_DIR) URL_HASH "SHA256=d4e80ea5e786dc689ddd04825d97ab91f5e1ef2787fa88a3d5ee00f0b820433f" BUILD_IN_SOURCE true Review comment: I think this is a MAX_PATH issue. The build failed for me too locally, but when I moved the repo to a short path (`C:\a\m`), it worked fine. Probably related to removing BUILD_IN_SOURCE. A few ideas: - rename the cmake target to something shorter, like "asdkext" to save a few characters on the ExternalProject build dir names - move the build directory outside GITHUB_WORKSPACE (== `D:\a\nifi-minifi-cpp\nifi-minifi-cpp`). I don't want to go more than one level up. - revert to BUILD_IN_SOURCE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9194) Upsert for Oracle12+
[ https://issues.apache.org/jira/browse/NIFI-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-9194: --- Affects Version/s: (was: 1.14.0) Status: Patch Available (was: Open) > Upsert for Oracle12+ > > > Key: NIFI-9194 > URL: https://issues.apache.org/jira/browse/NIFI-9194 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework > Environment: All OS >Reporter: ROBERTO SANTOS >Priority: Major > Labels: features > Original Estimate: 168h > Time Spent: 10m > Remaining Estimate: 24h > > I have implemented Upsert capability for Oracle12+ in PutDatabaseRecord and > it’s Unity tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-8684) sensitive property not working for InvokeScriptedProcessor
[ https://issues.apache.org/jira/browse/NIFI-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-8684. Fix Version/s: 1.15.0 Assignee: Matt Burgess Resolution: Fixed Closing as fixed by NIFI-7012 > sensitive property not working for InvokeScriptedProcessor > -- > > Key: NIFI-8684 > URL: https://issues.apache.org/jira/browse/NIFI-8684 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.13.2 >Reporter: Jul Tomten >Assignee: Matt Burgess >Priority: Major > Labels: InvokeScriptedProcessor, property, sensitive > Fix For: 1.15.0 > > > I use InvokeScriptedProcessor > I'm trying to read a sensitive property from the process context > > before restarting NiFi it was working fine > after restarting NiFi - NiFi fails to startup with the error below > see https://issues.apache.org/jira/browse/NIFI-7012 > > > 2021-06-11 11:22:09,673 WARN [main] org.apache.nifi.web.server.JettyServer > Failed to start web server... shutting down. > org.apache.nifi.controller.serialization.FlowSynchronizationException: > java.lang.IllegalArgumentException: The property 'Password3' cannot reference > Parameter 'password3' because Sensitive Parameters may only be referenced by > Sensitive Properties. > at > org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:306) > at > org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1413) > at > org.apache.nifi.persistence.StandardXMLFlowConfigurationDAO.load(StandardXMLFlowConfigurationDAO.java:89) > at > org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:810) > at > org.apache.nifi.controller.StandardFlowService.load(StandardFlowService.java:539) > at > org.apache.nifi.web.contextlistener.ApplicationStartupContextListener.contextInitialized(ApplicationStartupContextListener.java:72) > at > org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1068) > at > org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572) > at > org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:997) > at > org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746) > at > org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379) > at > org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1449) > at > org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1414) > at > org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:911) > at > org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288) > at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) > at > org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:426) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) > at org.eclipse.jetty.server.Server.start(Server.java:423) > at >
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5493: NIFI-8806 - Refactoring ListenTCP to use netty.
exceptionfactory commented on a change in pull request #5493:
URL: https://github.com/apache/nifi/pull/5493#discussion_r738754015
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##
@@ -112,15 +121,121 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("Messages received successfully will be sent out this
relationship.")
+.build();
+
+protected static final String RECEIVED_COUNTER = "Messages Received";
+
+protected List descriptors;
+protected Set relationships;
+protected volatile int port;
+protected volatile Charset charset;
+protected volatile BlockingQueue events;
+protected volatile BlockingQueue errorEvents;
+protected volatile InetAddress hostname;
+protected volatile EventServer eventServer;
+protected volatile byte[] messageDemarcatorBytes;
+protected volatile EventBatcher eventBatcher;
+
+@Override
+protected void init(final ProcessorInitializationContext context) {
+final List descriptors = new ArrayList<>();
+descriptors.add(ListenerProperties.PORT);
+descriptors.add(ListenerProperties.RECV_BUFFER_SIZE);
+descriptors.add(ListenerProperties.MAX_MESSAGE_QUEUE_SIZE);
+descriptors.add(ListenerProperties.MAX_SOCKET_BUFFER_SIZE);
+descriptors.add(ListenerProperties.CHARSET);
+descriptors.add(ListenerProperties.MAX_CONNECTIONS);
+descriptors.add(ListenerProperties.MAX_BATCH_SIZE);
+descriptors.add(ListenerProperties.MESSAGE_DELIMITER);
+descriptors.add(MAX_RECV_THREAD_POOL_SIZE);
+descriptors.add(POOL_RECV_BUFFERS);
+descriptors.add(ListenerProperties.NETWORK_INTF_NAME);
+descriptors.add(CLIENT_AUTH);
+descriptors.add(SSL_CONTEXT_SERVICE);
+this.descriptors = Collections.unmodifiableList(descriptors);
+
+final Set relationships = new HashSet<>();
+relationships.add(REL_SUCCESS);
+this.relationships = Collections.unmodifiableSet(relationships);
+}
+
+@OnScheduled
+public void onScheduled(ProcessContext context) throws IOException {
+int maxConnections =
context.getProperty(ListenerProperties.MAX_CONNECTIONS).asInteger();
+int bufferSize =
context.getProperty(ListenerProperties.RECV_BUFFER_SIZE).asDataSize(DataUnit.B).intValue();
+final String networkInterface =
context.getProperty(ListenerProperties.NETWORK_INTF_NAME).evaluateAttributeExpressions().getValue();
+InetAddress hostname =
NetworkUtils.getInterfaceAddress(networkInterface);
+Charset charset =
Charset.forName(context.getProperty(ListenerProperties.CHARSET).getValue());
+port =
context.getProperty(ListenerProperties.PORT).evaluateAttributeExpressions().asInteger();
+events = new
LinkedBlockingQueue<>(context.getProperty(ListenerProperties.MAX_MESSAGE_QUEUE_SIZE).asInteger());
+errorEvents = new LinkedBlockingQueue<>();
+final String msgDemarcator = getMessageDemarcator(context);
+messageDemarcatorBytes = msgDemarcator.getBytes(charset);
+final NettyEventServerFactory eventFactory = new
ByteArrayMessageNettyEventServerFactory(getLogger(), hostname, port,
TransportProtocol.TCP, messageDemarcatorBytes, bufferSize, events);
+
+final SSLContextService sslContextService =
context.getProperty(SSL_CONTEXT_SERVICE).asControllerService(SSLContextService.class);
+if (sslContextService != null) {
+final String clientAuthValue =
context.getProperty(CLIENT_AUTH).getValue();
+ClientAuth clientAuth = ClientAuth.valueOf(clientAuthValue);
+SSLContext sslContext = sslContextService.createContext();
+if (sslContext != null) {
Review comment:
This null check should not be necessary, the service should throw an
exception if it cannot create an SSLContext.
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##
@@ -112,15 +121,121 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("Messages received successfully will be sent out this
relationship.")
+.build();
+
+protected static final String RECEIVED_COUNTER = "Messages Received";
+
+protected List descriptors;
+protected Set relationships;
+protected volatile int port;
+protected volatile Charset charset;
+protected volatile BlockingQueue events;
+protected volatile BlockingQueue errorEvents;
+protected volatile
[GitHub] [nifi] gresockj opened a new pull request #5494: NIFI-9343: Adding config verification to GCP processors
gresockj opened a new pull request #5494:
URL: https://github.com/apache/nifi/pull/5494
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds config verification support to:
- `GCPCredentialsControllerService` - failure can be seen if providing valid
but incomplete JSON
- `ConsumeGCPubSub` - Added steps for parsing the subscriber name from the
Subscription, and creating the Subscriber
- `PublishGCPubSub` - Added step for creating the Publisher
- `PutBigQueryBatch/PutBigQueryStreaming` - Added a step for creating the
BigQuery client service
- `DeleteGCSObject/PutGCSObject` - Added a step for creating the Storage
client service
- `FetchGCSObject` - Added steps for creating the Storage client service and
actually fetching the object (the fetched bytes are displayed in a success
message)
- `ListGCSBucket` - Added steps for creating the Storage client service and
actually listing the bucket, displaying the number of listed blobs in the
success message.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] thenatog opened a new pull request #5493: NIFI-8806 - Refactoring ListenTCP to use netty.
thenatog opened a new pull request #5493:
URL: https://github.com/apache/nifi/pull/5493
NIFI-8806 - Cleanup and correcting an issue with batching.
NIFI-8806 - Updated netty sender in test to close after each use.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9347) Unreliable or brittle persistent provenance repo test
Joe Witt created NIFI-9347: -- Summary: Unreliable or brittle persistent provenance repo test Key: NIFI-9347 URL: https://issues.apache.org/jira/browse/NIFI-9347 Project: Apache NiFi Issue Type: Test Reporter: Joe Witt --- Test set: org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex --- Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.368 s <<< FAILURE! - in org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex.testGetMinimumIdToReindex Time elapsed: 7.284 s <<< ERROR! java.util.concurrent.TimeoutException: testGetMinimumIdToReindex() timed out after 5 seconds -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9346) Unreliable or brittle test in TestListenRELP
[ https://issues.apache.org/jira/browse/NIFI-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435568#comment-17435568 ] ASF subversion and git services commented on NIFI-9346: --- Commit 16e6045d13452cbff7da9685f0da4e2278a06434 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=16e6045 ] NIFI-9346 Added closing of EventSender to TestListenRELP Signed-off-by: Nathan Gough This closes #5492. > Unreliable or brittle test in TestListenRELP > > > Key: NIFI-9346 > URL: https://issues.apache.org/jira/browse/NIFI-9346 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.672 > s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenRELP > [ERROR] org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls > Time elapsed: 0.501 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: <3> but was: <1> > at > org.apache.nifi.processors.standard.TestListenRELP.run(TestListenRELP.java:219) > at > org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls(TestListenRELP.java:182) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-9346) Unreliable or brittle test in TestListenRELP
[ https://issues.apache.org/jira/browse/NIFI-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough updated NIFI-9346: --- Fix Version/s: 1.15.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Unreliable or brittle test in TestListenRELP > > > Key: NIFI-9346 > URL: https://issues.apache.org/jira/browse/NIFI-9346 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Fix For: 1.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.672 > s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenRELP > [ERROR] org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls > Time elapsed: 0.501 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: <3> but was: <1> > at > org.apache.nifi.processors.standard.TestListenRELP.run(TestListenRELP.java:219) > at > org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls(TestListenRELP.java:182) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] thenatog closed pull request #5492: NIFI-9346 Add closing of EventSender to TestListenRELP
thenatog closed pull request #5492: URL: https://github.com/apache/nifi/pull/5492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5492: NIFI-9346 Add closing of EventSender to TestListenRELP
thenatog commented on pull request #5492: URL: https://github.com/apache/nifi/pull/5492#issuecomment-954036889 +1 looks good to me, will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-9346) Unreliable or brittle test in TestListenRELP
[ https://issues.apache.org/jira/browse/NIFI-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-9346: -- Assignee: David Handermann > Unreliable or brittle test in TestListenRELP > > > Key: NIFI-9346 > URL: https://issues.apache.org/jira/browse/NIFI-9346 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.672 > s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenRELP > [ERROR] org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls > Time elapsed: 0.501 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: <3> but was: <1> > at > org.apache.nifi.processors.standard.TestListenRELP.run(TestListenRELP.java:219) > at > org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls(TestListenRELP.java:182) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-9346) Unreliable or brittle test in TestListenRELP
[ https://issues.apache.org/jira/browse/NIFI-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9346: --- Status: Patch Available (was: Open) > Unreliable or brittle test in TestListenRELP > > > Key: NIFI-9346 > URL: https://issues.apache.org/jira/browse/NIFI-9346 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.672 > s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenRELP > [ERROR] org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls > Time elapsed: 0.501 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: <3> but was: <1> > at > org.apache.nifi.processors.standard.TestListenRELP.run(TestListenRELP.java:219) > at > org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls(TestListenRELP.java:182) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] exceptionfactory opened a new pull request #5492: NIFI-9346 Add closing of EventSender to TestListenRELP
exceptionfactory opened a new pull request #5492:
URL: https://github.com/apache/nifi/pull/5492
Description of PR
NIFI-9346 Adds a try-with-resources block for the `EventSender` used to send
messages to `ListenRELP` so that the `sendMessages` method closes the sender
after completion.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9346) Unreliable or brittle test in TestListenRELP
Joe Witt created NIFI-9346: -- Summary: Unreliable or brittle test in TestListenRELP Key: NIFI-9346 URL: https://issues.apache.org/jira/browse/NIFI-9346 Project: Apache NiFi Issue Type: Test Reporter: Joe Witt [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.672 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenRELP [ERROR] org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls Time elapsed: 0.501 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <3> but was: <1> at org.apache.nifi.processors.standard.TestListenRELP.run(TestListenRELP.java:219) at org.apache.nifi.processors.standard.TestListenRELP.testRunMutualTls(TestListenRELP.java:182) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9322) OIDC and SAML Access Resources Produce Invalid Documentation
[
https://issues.apache.org/jira/browse/NIFI-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435533#comment-17435533
]
ASF subversion and git services commented on NIFI-9322:
---
Commit 9865ea2bfbb50682f322377dbd42830c15e5915f in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9865ea2 ]
NIFI-9322 Refactored OIDC and SAML Access Resources
- Removed parent AccessResource from OIDCAccessResource and SAMLAccessResource
to avoid unexpected inherited methods
- Moved Token Expiration validation from AccessResource to
StandardBearerTokenProvider
Signed-off-by: Nathan Gough
This closes #5489.
> OIDC and SAML Access Resources Produce Invalid Documentation
>
>
> Key: NIFI-9322
> URL: https://issues.apache.org/jira/browse/NIFI-9322
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0
>Reporter: Dheeraj Joshi
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Nifi API guide at
> [https://nifi.apache.org/docs/nifi-docs/rest-api/index.html] has an API
> {code:java}
> /access/oidc/token{code}
> However this API is missing from the actual code at
> {code:java}
> OIDCAccessResource.java{code}
> Exposed API's are defined as constants in
> {code:java}
> OIDCEndpoints.java{code}
> And the constants are
> {code:java}
> package org.apache.nifi.web.security.oidc;
> public interface OIDCEndpoints {
> String OIDC_ACCESS_ROOT = "/access/oidc";
> String LOGIN_REQUEST_RELATIVE = "/request";
> String LOGIN_REQUEST = OIDC_ACCESS_ROOT + LOGIN_REQUEST_RELATIVE;
> String LOGIN_CALLBACK_RELATIVE = "/callback";
> String LOGIN_CALLBACK = OIDC_ACCESS_ROOT + LOGIN_CALLBACK_RELATIVE;
> String TOKEN_EXCHANGE_RELATIVE = "/exchange";
> String TOKEN_EXCHANGE = OIDC_ACCESS_ROOT + TOKEN_EXCHANGE_RELATIVE;
> String LOGOUT_REQUEST_RELATIVE = "/logout";
> String LOGOUT_REQUEST = OIDC_ACCESS_ROOT + LOGOUT_REQUEST_RELATIVE;
> String LOGOUT_CALLBACK_RELATIVE = "/logoutCallback";
> String LOGOUT_CALLBACK = OIDC_ACCESS_ROOT + LOGOUT_CALLBACK_RELATIVE;
> }
> {code}
> We were trying to execute the API
> {code:java}
> /access/oidc/token{code}
> to no avail only to realize no such API is exposed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-9322) OIDC and SAML Access Resources Produce Invalid Documentation
[
https://issues.apache.org/jira/browse/NIFI-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Gough updated NIFI-9322:
---
Fix Version/s: 1.15.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> OIDC and SAML Access Resources Produce Invalid Documentation
>
>
> Key: NIFI-9322
> URL: https://issues.apache.org/jira/browse/NIFI-9322
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0
>Reporter: Dheeraj Joshi
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Nifi API guide at
> [https://nifi.apache.org/docs/nifi-docs/rest-api/index.html] has an API
> {code:java}
> /access/oidc/token{code}
> However this API is missing from the actual code at
> {code:java}
> OIDCAccessResource.java{code}
> Exposed API's are defined as constants in
> {code:java}
> OIDCEndpoints.java{code}
> And the constants are
> {code:java}
> package org.apache.nifi.web.security.oidc;
> public interface OIDCEndpoints {
> String OIDC_ACCESS_ROOT = "/access/oidc";
> String LOGIN_REQUEST_RELATIVE = "/request";
> String LOGIN_REQUEST = OIDC_ACCESS_ROOT + LOGIN_REQUEST_RELATIVE;
> String LOGIN_CALLBACK_RELATIVE = "/callback";
> String LOGIN_CALLBACK = OIDC_ACCESS_ROOT + LOGIN_CALLBACK_RELATIVE;
> String TOKEN_EXCHANGE_RELATIVE = "/exchange";
> String TOKEN_EXCHANGE = OIDC_ACCESS_ROOT + TOKEN_EXCHANGE_RELATIVE;
> String LOGOUT_REQUEST_RELATIVE = "/logout";
> String LOGOUT_REQUEST = OIDC_ACCESS_ROOT + LOGOUT_REQUEST_RELATIVE;
> String LOGOUT_CALLBACK_RELATIVE = "/logoutCallback";
> String LOGOUT_CALLBACK = OIDC_ACCESS_ROOT + LOGOUT_CALLBACK_RELATIVE;
> }
> {code}
> We were trying to execute the API
> {code:java}
> /access/oidc/token{code}
> to no avail only to realize no such API is exposed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] thenatog closed pull request #5489: NIFI-9322 Correct Inheritance for OIDC and SAML Access Resources
thenatog closed pull request #5489: URL: https://github.com/apache/nifi/pull/5489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5489: NIFI-9322 Correct Inheritance for OIDC and SAML Access Resources
thenatog commented on pull request #5489: URL: https://github.com/apache/nifi/pull/5489#issuecomment-953993948 Looks like this PR has fixed the inheritance issue that caused issues with docs, and I verified that SAML and OIDC authentication are all working for log in/log out with some of the other minor changes. +1, will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9345) /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode
[ https://issues.apache.org/jira/browse/NIFI-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435524#comment-17435524 ] ASF subversion and git services commented on NIFI-9345: --- Commit 28cd5d1300f9d2c9fd957a9d92a9096b5cd0edfb in nifi's branch refs/heads/main from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=28cd5d1 ] NIFI-9345: Resolving NPE in ProcessorEntityMerger (#5491) NIFI-9345: Resolving NPE in ProcessorEntityMerger, Streamlining forEach calls > /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode > --- > > Key: NIFI-9345 > URL: https://issues.apache.org/jira/browse/NIFI-9345 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Joe Gresock >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > A NPE is thrown on ProcessorEntityMerger:89 when clustered mode is used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-9345) /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode
[ https://issues.apache.org/jira/browse/NIFI-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-9345. -- Fix Version/s: 1.15.0 Resolution: Fixed > /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode > --- > > Key: NIFI-9345 > URL: https://issues.apache.org/jira/browse/NIFI-9345 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Joe Gresock >Priority: Major > Fix For: 1.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > A NPE is thrown on ProcessorEntityMerger:89 when clustered mode is used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] markap14 merged pull request #5491: NIFI-9345: Resolving NPE in ProcessorEntityMerger
markap14 merged pull request #5491: URL: https://github.com/apache/nifi/pull/5491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #5491: NIFI-9345: Resolving NPE in ProcessorEntityMerger
markap14 commented on pull request #5491: URL: https://github.com/apache/nifi/pull/5491#issuecomment-953989833 Thanks @gresockj great catch! Fix looks good to me. Was able to verify locally. +1 will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] gresockj opened a new pull request #5491: NIFI-9345: Resolving NPE in ProcessorEntityMerger
gresockj opened a new pull request #5491:
URL: https://github.com/apache/nifi/pull/5491
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds a null check during ProcessorEntity merging in clustered mode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9345) /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode
Joe Gresock created NIFI-9345: - Summary: /nifi-api/flow/process-groups/[id]?uiOnly=true throws NPE in clustered mode Key: NIFI-9345 URL: https://issues.apache.org/jira/browse/NIFI-9345 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Joe Gresock A NPE is thrown on ProcessorEntityMerger:89 when clustered mode is used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9344) Conduct 1.15 Release
[ https://issues.apache.org/jira/browse/NIFI-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435502#comment-17435502 ] ASF subversion and git services commented on NIFI-9344: --- Commit 74151eab1f87e12cff01de2744c2cdd1f74ce578 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=74151ea ] NIFI-9344 updating docker versions for nifi release > Conduct 1.15 Release > > > Key: NIFI-9344 > URL: https://issues.apache.org/jira/browse/NIFI-9344 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] kevdoran commented on a change in pull request #5458: NIFI-7865 amqp$header is splitted in the wrong way for "," and "}"
kevdoran commented on a change in pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#discussion_r738512134
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -510,4 +514,27 @@ public static String toTitleCase(String input) {
.map(word -> Character.toTitleCase(word.charAt(0)) +
word.substring(1))
.collect(Collectors.joining(" "));
}
+
+/**
+ * Escape {@code str} by replacing occurrences of {@code charToEscape}
with {@code escapeChar+charToEscape}
+ * @param str the input string
+ * @param escapeChar the character used for escaping
+ * @param charToEscape the character that needs to be escaped
+ * @return the escaped string
+ */
+public static String escapeString(String str, char escapeChar, char
charToEscape) {
+if (str == null || str.isEmpty()) {
+return null;
+}
+StringBuilder result = new StringBuilder();
+for (int i=0; i
[jira] [Created] (NIFI-9344) Conduct 1.15 Release
Joe Witt created NIFI-9344: -- Summary: Conduct 1.15 Release Key: NIFI-9344 URL: https://issues.apache.org/jira/browse/NIFI-9344 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt Fix For: 1.15.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8760) VolatileContentRepository fails to retrieve content from claims with several processors
[
https://issues.apache.org/jira/browse/NIFI-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435488#comment-17435488
]
Joe Witt commented on NIFI-8760:
Removed fix version until progress on review/discussion is made.
> VolatileContentRepository fails to retrieve content from claims with several
> processors
> ---
>
> Key: NIFI-8760
> URL: https://issues.apache.org/jira/browse/NIFI-8760
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0, 1.13.1, 1.13.2, 1.15.0
>Reporter: Matthieu RÉ
>Priority: Major
> Labels: content-repository, volatile
> Attachments:
> 0001-fix-2-set-VolatileContentRepository-as-non-supportiv.patch,
> 0001-fix-2-set-VolatileContentRepository-as-non-supportiv.patch, flow.xml.gz,
> nifi.properties
>
>
> For several processors such as MergeRecord, QueryRecord, SplitJson, the use
> of VolatileContentRepository implementation infers errors while retrieving
> Flowfiles from claims. The following logs are generated using NiFi 1.13.1
> from Docker and the flow.xml.gz and nifi.properties file attached.
> MergeRecord (with JsonTreeReader, JsonRecordSetWriter with default
> configuration):
> {{2021-07-06 10:15:09,170 ERROR [Timer-Driven Process Thread-1]
> o.a.nifi.processors.standard.MergeRecord
> MergeRecord[id=7b425cff-017a-1000-6a20-58c4e064df3d] Failed to bin
> StandardFlowFileRecord[uuid=3e894a96-883a-4ac2-8121-b8200964cf20,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0,
> length=5655],offset=0,name=b2c7cf61-b421-477d-902e-daeb2ed58f0d,size=5655]
> due to org.apache.nifi.controller.repository.ContentNotFoundException: Could
> not find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]:
> org.apache.nifi.controller.repository.ContentNotFoundException: Could not
> find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]}}
> {{org.apache.nifi.controller.repository.ContentNotFoundException: Could not
> find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.getContent(VolatileContentRepository.java:445)}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.read(VolatileContentRepository.java:468)}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.read(VolatileContentRepository.java:473)}}
> {{at
> org.apache.nifi.controller.repository.StandardProcessSession.getInputStream(StandardProcessSession.java:2302)}}
> {{at
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2409)}}
> {{at
> org.apache.nifi.processors.standard.MergeRecord.binFlowFile(MergeRecord.java:383)}}
> {{at
> org.apache.nifi.processors.standard.MergeRecord.onTrigger(MergeRecord.java:346)}}
> {{at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1173)}}
> {{at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)}}
> {{at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)}}
> {{at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)}}
> {{at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)}}
> {{at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)}}
> {{at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)}}
> {{at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)}}
> {{at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)}}
> {{at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)}}
> {{at java.lang.Thread.run(Thread.java:748)}}
> QueryRecord:
> {{2021-07-06 10:15:09,174 ERROR [Timer-Driven Process Thread-4]
> o.a.nifi.processors.standard.QueryRecord
> QueryRecord[id=673fe9f6-017a-1000-8041-dfde9d02d976] Failed to determine
> Record Schema from
> StandardFlowFileRecord[uuid=090e3058-67e6-4436-bea9-d511132848e3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=2, container=in-memory,
> section=section], offset=0,
> length=5655],offset=0,name=090e3058-67e6-4436-bea9-d511132848e3,size=5655];
> routing to failure:
> org.apache.nifi.controller.repository.ContentNotFoundException: Could
[jira] [Updated] (NIFI-8760) VolatileContentRepository fails to retrieve content from claims with several processors
[
https://issues.apache.org/jira/browse/NIFI-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-8760:
---
Fix Version/s: (was: 1.15.0)
> VolatileContentRepository fails to retrieve content from claims with several
> processors
> ---
>
> Key: NIFI-8760
> URL: https://issues.apache.org/jira/browse/NIFI-8760
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0, 1.13.1, 1.13.2, 1.15.0
>Reporter: Matthieu RÉ
>Priority: Major
> Labels: content-repository, volatile
> Attachments:
> 0001-fix-2-set-VolatileContentRepository-as-non-supportiv.patch,
> 0001-fix-2-set-VolatileContentRepository-as-non-supportiv.patch, flow.xml.gz,
> nifi.properties
>
>
> For several processors such as MergeRecord, QueryRecord, SplitJson, the use
> of VolatileContentRepository implementation infers errors while retrieving
> Flowfiles from claims. The following logs are generated using NiFi 1.13.1
> from Docker and the flow.xml.gz and nifi.properties file attached.
> MergeRecord (with JsonTreeReader, JsonRecordSetWriter with default
> configuration):
> {{2021-07-06 10:15:09,170 ERROR [Timer-Driven Process Thread-1]
> o.a.nifi.processors.standard.MergeRecord
> MergeRecord[id=7b425cff-017a-1000-6a20-58c4e064df3d] Failed to bin
> StandardFlowFileRecord[uuid=3e894a96-883a-4ac2-8121-b8200964cf20,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0,
> length=5655],offset=0,name=b2c7cf61-b421-477d-902e-daeb2ed58f0d,size=5655]
> due to org.apache.nifi.controller.repository.ContentNotFoundException: Could
> not find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]:
> org.apache.nifi.controller.repository.ContentNotFoundException: Could not
> find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]}}
> {{org.apache.nifi.controller.repository.ContentNotFoundException: Could not
> find content for StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=6, container=in-memory,
> section=section], offset=0, length=-1]}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.getContent(VolatileContentRepository.java:445)}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.read(VolatileContentRepository.java:468)}}
> {{at
> org.apache.nifi.controller.repository.VolatileContentRepository.read(VolatileContentRepository.java:473)}}
> {{at
> org.apache.nifi.controller.repository.StandardProcessSession.getInputStream(StandardProcessSession.java:2302)}}
> {{at
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2409)}}
> {{at
> org.apache.nifi.processors.standard.MergeRecord.binFlowFile(MergeRecord.java:383)}}
> {{at
> org.apache.nifi.processors.standard.MergeRecord.onTrigger(MergeRecord.java:346)}}
> {{at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1173)}}
> {{at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)}}
> {{at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)}}
> {{at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)}}
> {{at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)}}
> {{at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)}}
> {{at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)}}
> {{at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)}}
> {{at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)}}
> {{at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)}}
> {{at java.lang.Thread.run(Thread.java:748)}}
> QueryRecord:
> {{2021-07-06 10:15:09,174 ERROR [Timer-Driven Process Thread-4]
> o.a.nifi.processors.standard.QueryRecord
> QueryRecord[id=673fe9f6-017a-1000-8041-dfde9d02d976] Failed to determine
> Record Schema from
> StandardFlowFileRecord[uuid=090e3058-67e6-4436-bea9-d511132848e3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=2, container=in-memory,
> section=section], offset=0,
> length=5655],offset=0,name=090e3058-67e6-4436-bea9-d511132848e3,size=5655];
> routing to failure:
> org.apache.nifi.controller.repository.ContentNotFoundException: Could not
> find content for StandardContentClaim
>
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5471: NIFI-9308: Created EmailRecordSinkService for Reporting Tasks
exceptionfactory commented on a change in pull request #5471:
URL: https://github.com/apache/nifi/pull/5471#discussion_r738424864
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-sink-service-bundle/nifi-record-sink-service/src/main/java/org/apache/nifi/record/sink/EmailRecordSink.java
##
@@ -0,0 +1,381 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink;
+
+import jakarta.mail.Authenticator;
+import jakarta.mail.Message;
+import jakarta.mail.MessagingException;
+import jakarta.mail.PasswordAuthentication;
+import jakarta.mail.Session;
+import jakarta.mail.Transport;
+import jakarta.mail.internet.AddressException;
+import jakarta.mail.internet.InternetAddress;
+import jakarta.mail.internet.MimeMessage;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.WriteResult;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordSet;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+public class EmailRecordSink extends AbstractControllerService implements
RecordSinkService {
+
+public static final PropertyDescriptor FROM = new
PropertyDescriptor.Builder()
+.name("from")
+.displayName("From")
+.description("Specifies the Email address to use as the sender. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor TO = new
PropertyDescriptor.Builder()
+.name("to")
+.displayName("To")
+.description("The recipients to include in the To-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor CC = new
PropertyDescriptor.Builder()
+.name("cc")
+.displayName("CC")
+.description("The recipients to include in the CC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor BCC = new
PropertyDescriptor.Builder()
+.name("bcc")
+.displayName("BCC")
+.description("The recipients to include in the BCC-Line of the
email. "
++ "Comma separated sequence of addresses following RFC822
syntax.")
+.required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+public static final PropertyDescriptor SUBJECT = new
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738409844 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: removed the license dialog step for "Change" action -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-1667) Add Azure SDK logging to Minifi
[ https://issues.apache.org/jira/browse/MINIFICPP-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-1667. -- Fix Version/s: 0.11.0 Resolution: Fixed > Add Azure SDK logging to Minifi > --- > > Key: MINIFICPP-1667 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1667 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > Fix For: 0.11.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Azure SDK logs are not part of Minifi logs which could help with debugging > issues with Azure processors. This should be added to Minifi. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MINIFICPP-1614) Some SFTP unit tests don't clean up temp directories after themselves
[
https://issues.apache.org/jira/browse/MINIFICPP-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1614:
-
Fix Version/s: 0.11.0
> Some SFTP unit tests don't clean up temp directories after themselves
> -
>
> Key: MINIFICPP-1614
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1614
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Ferenc Gerlits
>Assignee: Gábor Gyimesi
>Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
> Fix For: 0.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{ListSFTPTests}} and {{FetchSFTPTests}} create some files/directories with
> limited permissions which prevents them from getting cleaned up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MINIFICPP-1614) Some SFTP unit tests don't clean up temp directories after themselves
[
https://issues.apache.org/jira/browse/MINIFICPP-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-1614.
--
Resolution: Fixed
> Some SFTP unit tests don't clean up temp directories after themselves
> -
>
> Key: MINIFICPP-1614
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1614
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Ferenc Gerlits
>Assignee: Gábor Gyimesi
>Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{ListSFTPTests}} and {{FetchSFTPTests}} create some files/directories with
> limited permissions which prevents them from getting cleaned up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1205: MINIFICPP-1614 Cleanup limited permission directories in SFTP tests
fgerlits closed pull request #1205: URL: https://github.com/apache/nifi-minifi-cpp/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1202: MINIFICPP-1667 Add Azure SDK logging to Minifi
fgerlits closed pull request #1202: URL: https://github.com/apache/nifi-minifi-cpp/pull/1202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1172: MINIFICPP-977 MQTT tests added
fgerlits closed pull request #1172: URL: https://github.com/apache/nifi-minifi-cpp/pull/1172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1165: MINIFICPP-1634 remove namespace aliases from Core.h
fgerlits closed pull request #1165: URL: https://github.com/apache/nifi-minifi-cpp/pull/1165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1207: MINIFICPP-1674 fix azure-sdk target name, use install dir
lordgamez commented on a change in pull request #1207: URL: https://github.com/apache/nifi-minifi-cpp/pull/1207#discussion_r738195515 ## File path: cmake/BundledAzureSdkCpp.cmake ## @@ -56,6 +63,7 @@ function(use_bundled_libazure SOURCE_DIR BINARY_DIR) URL_HASH "SHA256=d4e80ea5e786dc689ddd04825d97ab91f5e1ef2787fa88a3d5ee00f0b820433f" BUILD_IN_SOURCE true Review comment: It seems this change caused some problems with the Windows build that needs to be checked. I rerun the build locally to see if it was some transient failure, but it fails consistently, but it needs to be investigated what the root cause of this is. ```FileTracker : error FTK1011: could not create the new file tracking log file: D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\azure-sdk-cpp-external-prefix\src\azure-sdk-cpp-external-build\sdk\keyvault\azure-security-keyvault-certificates\azure-security-keyvault-certificates.dir\Release\azure-se.9DB92436.tlog\CL-cl_original.6536.write.1.tlog. The system cannot find the path specified.``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-9265) Fixing path handling for FetchHDFS when there are multiple separators in the path
[
https://issues.apache.org/jira/browse/NIFI-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-9265.
--
Fix Version/s: 1.15.0
Resolution: Fixed
> Fixing path handling for FetchHDFS when there are multiple separators in the
> path
> -
>
> Key: NIFI-9265
> URL: https://issues.apache.org/jira/browse/NIFI-9265
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Simon Bence
>Assignee: Simon Bence
>Priority: Major
> Fix For: 1.15.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In some cases, FetchHDFS's default "HDFS Filename" value (which is
> ${path}/${filename}) might end up with double separator in the evaluated
> value. For example if the ${path} is the root, then the value will start with
> "//". In most cases this cause no issue, but there are some scenarios it
> might behave unexpectedly. Like for example: if the storage is backed with S3
> or Azure, this path leads to an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-9265) Fixing path handling for FetchHDFS when there are multiple separators in the path
[
https://issues.apache.org/jira/browse/NIFI-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435254#comment-17435254
]
ASF subversion and git services commented on NIFI-9265:
---
Commit 75d1d7f6e7a6a11dbe404a347937187fbc51b72e in nifi's branch
refs/heads/main from Bence Simon
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=75d1d7f ]
NIFI-9265 Fixing path handling for HDFS processors when there are multiplied
separators in the path
Signed-off-by: Pierre Villard
This closes #5437.
> Fixing path handling for FetchHDFS when there are multiple separators in the
> path
> -
>
> Key: NIFI-9265
> URL: https://issues.apache.org/jira/browse/NIFI-9265
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Simon Bence
>Assignee: Simon Bence
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In some cases, FetchHDFS's default "HDFS Filename" value (which is
> ${path}/${filename}) might end up with double separator in the evaluated
> value. For example if the ${path} is the root, then the value will start with
> "//". In most cases this cause no issue, but there are some scenarios it
> might behave unexpectedly. Like for example: if the storage is backed with S3
> or Azure, this path leads to an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #5437: NIFI-9265 Fixing path handling for HDFS processors when there are multiplied separators in the path
asfgit closed pull request #5437: URL: https://github.com/apache/nifi/pull/5437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #5437: NIFI-9265 Fixing path handling for HDFS processors when there are multiplied separators in the path
pvillard31 commented on pull request #5437: URL: https://github.com/apache/nifi/pull/5437#issuecomment-953640744 Merged, thanks @simonbence @Lehel44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
fgerlits commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738172463 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: I don't know either; let's keep this thread open for a while, maybe someone who knows the answer will comment -- if not, I agree that it's safer to show the license -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738156449 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: since the user might select new extension to be added I felt like the same legal requirements apply as during a fresh install, IANAL so if it is not required I'll remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
fgerlits commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738138779 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: do we need to redisplay the `ApacheLicenseDlg`? I would expect to be taken to `CustomizeDlg` directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#issuecomment-953592311 > Some of these changes seem to have broken the tests by not finding the processors with the names previously defined: > > ``` > [2021-10-26 13:35:16.656] [org::apache::nifi::minifi::core::FlowConfiguration] [error] No Processor defined for org.apache.nifi.processors.standard.GenerateFlowFile > [2021-10-26 13:51:26.999] [org::apache::nifi::minifi::core::FlowConfiguration] [error] No Processor defined for org.apache.nifi.processors.standard.ListenHTTP > [2021-10-26 14:06:39.040] [org::apache::nifi::minifi::core::FlowConfiguration] [error] No Processor defined for org.apache.nifi.processors.standard.GetFile > [2021-10-26 14:08:43.518] [org::apache::nifi::minifi::core::FlowConfiguration] [error] No Processor defined for org.apache.nifi.processors.standard.ConsumeKafka > ``` added a directive to produce a single archive with all the components, also changed the references to the artifact by removing the `-bin` suffix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-9342) Upgrade Netty to 4.1.69 and 3.10.6
[
https://issues.apache.org/jira/browse/NIFI-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-9342.
--
Fix Version/s: 1.15.0
Resolution: Fixed
> Upgrade Netty to 4.1.69 and 3.10.6
> --
>
> Key: NIFI-9342
> URL: https://issues.apache.org/jira/browse/NIFI-9342
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: dependency-upgrade
> Fix For: 1.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Several standard processors depend on Netty 4.1 through the
> {{nifi-event-transport}} module, and other core components have direct
> dependencies on Netty 4.1.65 and 4.1.63. These dependencies should be
> updated to Netty 4.1.69.
> Several older components have transitive dependencies on Netty 3, which
> should be upgraded to the latest 3.10.6 version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #5490: NIFI-9342 Upgrade to Netty 3.10.6 and 4.1.69
asfgit closed pull request #5490: URL: https://github.com/apache/nifi/pull/5490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9342) Upgrade Netty to 4.1.69 and 3.10.6
[
https://issues.apache.org/jira/browse/NIFI-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435217#comment-17435217
]
ASF subversion and git services commented on NIFI-9342:
---
Commit 60d6d469bff511c8a890209ef60f58034792a5f6 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=60d6d46 ]
NIFI-9342 Upgraded to Netty 3.10.6 and 4.1.69
- Replaced Netty 3.6.9 and 3.7.1 with 3.10.6
- Replaced Netty 4.1 with 4.1.69
Signed-off-by: Pierre Villard
This closes #5490.
> Upgrade Netty to 4.1.69 and 3.10.6
> --
>
> Key: NIFI-9342
> URL: https://issues.apache.org/jira/browse/NIFI-9342
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: dependency-upgrade
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Several standard processors depend on Netty 4.1 through the
> {{nifi-event-transport}} module, and other core components have direct
> dependencies on Netty 4.1.65 and 4.1.63. These dependencies should be
> updated to Netty 4.1.69.
> Several older components have transitive dependencies on Netty 3, which
> should be upgraded to the latest 3.10.6 version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] pvillard31 commented on pull request #5490: NIFI-9342 Upgrade to Netty 3.10.6 and 4.1.69
pvillard31 commented on pull request #5490: URL: https://github.com/apache/nifi/pull/5490#issuecomment-953579260 Merged, thanks @exceptionfactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] illion20 removed a comment on pull request #5482: NIFI-9334 Add support for upsert in 'PutMongoRecord'.
illion20 removed a comment on pull request #5482:
URL: https://github.com/apache/nifi/pull/5482#issuecomment-952418705
Suggestion:
Add a multi boolean and support UpdateManyModel
```java
if(multi){
writeModel = new UpdateManyModel<>(
Filters.and(filters),
new Document("$set", readyToUpsert),
new UpdateOptions().upsert(true)
);
} else {
writeModel = new UpdateOneModel<>(
Filters.and(filters),
new Document("$set", readyToUpsert),
new UpdateOptions().upsert(true)
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
