[jira] [Updated] (NIFI-9629) Avro Writer Schema Default Value not correctly being set

[Mark Payne (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-9629:
-
Assignee: Mark Payne
  Status: Patch Available  (was: Open)

> Avro Writer Schema Default Value not correctly being set
> 
>
> Key: NIFI-9629
> URL: https://issues.apache.org/jira/browse/NIFI-9629
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.15.3, 1.15.2, 1.15.1, 1.15.0, 1.16.0
> Environment: WSL Ubuntu, Java 11 Open JDK
>Reporter: Nathan English
>Assignee: Mark Payne
>Priority: Major
> Attachments: Avro_Default_Value_Conversion_Issue_-_20220125.xml
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Using the Avro Record Set Writer to create fields that don't exist and set 
> default values is currently causing issues. I haven't tested all the possible 
> types, but below are the ones I have tested:
>  * String with string default value - OK
>  * String with null - {color:#FF}Error{color}
>  * Byte with null - {color:#FF}Error{color}
>  * Int with 0 Default value - OK
>  * Long with 0 default value - {color:#FF}Error{color}
> {color:#172b4d}Looking at the AvroTypeUtil class when the field is put with 
> its default value the null, is actually an 
> org.apache.avro.JsonProperties$Null instead of an actual null value. The long 
> is actually a default of an int value. These both throw errors when being 
> encoded to the Avro Format.{color}
> {color:#172b4d}The attached flow successfully reproduces the errors.{color}
>  
> {color:#172b4d}I have tested the flow and it successfully works in v1.12.1, 
> but not a build from the main branch.{color}
>  
> {color:#172b4d}This issue leads on from NIFI-9594{color}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] markap14 opened a new pull request #5716: NIFI-9629: Ensure that when we are setting default values on Avro Gen…

[GitBox]

markap14 opened a new pull request #5716:
URL: https://github.com/apache/nifi/pull/5716


   …ericRecord objects that we convert from the schema's default value to the 
proper type
   
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-6494) Upgrade to latest LTS release of Node (and npm)

[Scott Aslan (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6494:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Upgrade to latest LTS release of Node (and npm)
> ---
>
> Key: NIFI-6494
> URL: https://issues.apache.org/jira/browse/NIFI-6494
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Rob Fellows
>Assignee: Scott Aslan
>Priority: Major
> Fix For: fds-0.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> nifi-fds currently requires node 8.10.0 and npm 5.6.0. The current LTS for 
> node is v10 and based on the scheduled release, v12 will be in October of 
> 2019.
> One driving factor behind this is to get to a version of npm that includes 
> npm audit. npm v6+ includes it (which is packaged with Node v10).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9630) Migrate NiFi Registry to swagger-codegen-maven-plugin

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9630:
---
Status: Patch Available  (was: Open)

> Migrate NiFi Registry to swagger-codegen-maven-plugin
> -
>
> Key: NIFI-9630
> URL: https://issues.apache.org/jira/browse/NIFI-9630
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> NiFi Registry REST API documentation uses a combination of the 
> {{swagger2markup-maven-plugin}} and the {{asciidoctor-maven-plugin}} to 
> generate the REST API documentation HTML for embedding and publication. The 
> [Swagger2Markup|https://github.com/Swagger2Markup/swagger2markup] project is 
> no longer maintained, and the last version was released in 2018. In addition, 
> the transitive dependencies for Swagger2Markup are no available in Maven 
> Central, but can be found in the read-only JCenter repository.
> The [Swagger 
> Codegen|https://swagger.io/docs/open-source-tools/swagger-codegen/] library, 
> and associated Maven plugin, support generating static HTML documentation 
> from Swagger definitions. The library and Maven plugin are actively 
> maintained and provides a replacement for the current REST API documentation 
> approach in NiFi Registry. Although the styling is different than the current 
> approach, the generated HTML contains the same information.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5582: NIFI-9455 Add aggregated predictions to Prometheus

[GitBox]

exceptionfactory commented on a change in pull request #5582:
URL: https://github.com/apache/nifi/pull/5582#discussion_r792103838



##
File path: 
nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-reporting-task/src/test/java/org/apache/nifi/reporting/prometheus/TestPrometheusMetricsUtil.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.reporting.prometheus;
+
+import org.apache.nifi.controller.status.ConnectionStatus;
+import org.apache.nifi.controller.status.ProcessGroupStatus;
+import org.apache.nifi.prometheus.util.AbstractMetricsRegistry;
+import org.apache.nifi.prometheus.util.ConnectionAnalyticsMetricsRegistry;
+import org.apache.nifi.prometheus.util.NiFiMetricsRegistry;
+import org.apache.nifi.prometheus.util.PrometheusMetricsUtil;
+import org.hamcrest.CoreMatchers;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.everyItem;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+public class TestPrometheusMetricsUtil {
+private static final long DEFAULT_PREDICTION_VALUE = -1L;
+private static final double EXPECTED_DEFAULT_PREDICTION_VALUE = -1.0;
+private static final double EXPECTED_BACKPRESSURE_PREDICTION_VALUE = 0.0;
+private static final double EXPECTED_FALSE_BACKPRESSURE = 0.0;
+private static final double EXPECTED_TRUE_BACKPRESSURE = 1.0;
+private static final double EXPECTED_DEFAULT_PERCENT_USED_VALUE = 0.0;
+private static final double EXPECTED_BACKPRESSURE_PERCENT_USED_VALUE = 
100.0;
+private static final double EXPECTED_NESTED_BYTES_PERCENT_VALUE = 150.0 / 
200.0 * 100.0;
+private static final double EXPECTED_NESTED_COUNT_PERCENT_VALUE = 5.0 / 
30.0 * 100.0;
+private static final String NIFI_PERCENT_USED_BYTES = 
"nifi_percent_used_bytes";
+private static final String NIFI_PERCENT_USED_COUNT = 
"nifi_percent_used_count";
+private static final String BYTES_AT_BACKPRESSURE = "bytesAtBackpressure";
+private static final String COUNT_AT_BACKPRESSURE = "countAtBackpressure";
+private static final String NIFI_TIME_TO_BYTES_BACKPRESSURE_PREDICTION = 
"nifi_time_to_bytes_backpressure_prediction";
+private static final String NIFI_TIME_TO_COUNT_BACKPRESSURE_PREDICTION = 
"nifi_time_to_count_backpressure_prediction";
+private static final String CONNECTION_1 = "Connection1";
+private static final String CONNECTION_2 = "Connection2";
+private static final String CONNECTION_3 = "Connection3";
+private static final String CONNECTION_4 = "Connection4";
+private static final String TIME_TO_BYTES_BACKPRESSURE_MILLIS = 
"timeToBytesBackpressureMillis";
+private static final String TIME_TO_COUNT_BACKPRESSURE_MILLIS = 
"timeToCountBackpressureMillis";
+
+private static ProcessGroupStatus singleProcessGroupStatus;
+private static ProcessGroupStatus nestedProcessGroupStatus;
+private static ProcessGroupStatus 
singleProcessGroupStatusWithBytesBackpressure;
+private static ProcessGroupStatus 
nestedProcessGroupStatusWithCountBackpressure;
+private static Set connections;
+private static Map> mixedValuedPredictions;
+private static Map> defaultValuedPredictions;
+
+@BeforeAll
+public static void setup() {
+singleProcessGroupStatus = createSingleProcessGroupStatus(0, 1, 0, 1);
+nestedProcessGroupStatus = createNestedProcessGroupStatus();
+singleProcessGroupStatusWithBytesBackpressure = 
createSingleProcessGroupStatus(1, 1, 0, 1);
+nestedProcessGroupStatusWithCountBackpressure = 
createNestedProcessGroupStatusWithCountBackpressure();
+connections = createConnections();
+mixedValuedPredictions = createPredictionsWithMixedValue();
+defaultValuedPredictions = createPredictionsWithDefaultValuesOnly();
+}
+
+@Test
+

[GitHub] [nifi] guimou commented on pull request #5684: NIFI-9605: Docker Images for OpenShift

[GitBox]

guimou commented on pull request #5684:
URL: https://github.com/apache/nifi/pull/5684#issuecomment-1021556910


   Hey @kevdoran! This is definitely not an urgent thing. And if it's the 
occasion to rethink other aspects of the container images building process that 
may be a good occasion and I'd be happy to help. Meanwhile I can keep a 
separate project (in my repo or another Red Hat repo) only for the OpenShift 
building recipes, not keeping the whole NiFi tree.
   Apart from the source image and the installed packages that differ a little 
bit because it's not the same base distro, the changes are all related to the 
way the NiFi files are installed: ownership (for OpenShift GID has to be set to 
zero to support arbitrary UID) and access writes. In fact this could even be 
applied to the way the images are currently built without that many 
consequences (although it would require some more reflexion).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9578) The Nifi User List in the UI will not populate if they are syncing a username and a group name that are the same

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482076#comment-17482076
 ] 

ASF subversion and git services commented on NIFI-9578:
---

Commit 3eef7e0a3e9e68b0acb5129416a1bc824a124baf in nifi's branch 
refs/heads/main from Adam Kocsis
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3eef7e0 ]

NIFI-9578 NiFi user list no longer breaks if a user and group have the same id 
(#5695)

- ids of the entities are prefixed by their types to avoid id conflict in 3rd 
party table library
   For some authorizers the UUID calculation for users and groups based only on 
the name of the entity and a global seed.
   This results the same UUID for a group and a user with the same name. The 
same ids are no longer causing any issue on the UI.
- group icon alignment is fixed for edit user dialog

This closes #5695 

> The Nifi User List in the UI will not populate if they are syncing a username 
> and a group name that are the same
> 
>
> Key: NIFI-9578
> URL: https://issues.apache.org/jira/browse/NIFI-9578
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: Timea Barna
>Assignee: Adam Kocsis
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> The Nifi User List in the UI will not populate if they are syncing a username 
> and a group name that are the same
> Recreation Steps:
> I have a user name 'kevin'
> I created a group named 'kevin'
> When I open Nifi, the user list is blank and when I check the browser 
> console, I see the error:
> slick.dataview.js:191 Uncaught Error: [SlickGrid DataView] Each data element 
> must implement a unique 'id' property
> Nifi uses a combined user list even though they come from different endpoints 
> /tenant
> The UI only support searching for users so the 'id' (identity fields within 
> the response json) will match which will throw the error because the code 
> expects the id fields to be unique
> Reproduced in 1.13.2



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9578) The Nifi User List in the UI will not populate if they are syncing a username and a group name that are the same

[Matt Gilman (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-9578:
--
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> The Nifi User List in the UI will not populate if they are syncing a username 
> and a group name that are the same
> 
>
> Key: NIFI-9578
> URL: https://issues.apache.org/jira/browse/NIFI-9578
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: Timea Barna
>Assignee: Adam Kocsis
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> The Nifi User List in the UI will not populate if they are syncing a username 
> and a group name that are the same
> Recreation Steps:
> I have a user name 'kevin'
> I created a group named 'kevin'
> When I open Nifi, the user list is blank and when I check the browser 
> console, I see the error:
> slick.dataview.js:191 Uncaught Error: [SlickGrid DataView] Each data element 
> must implement a unique 'id' property
> Nifi uses a combined user list even though they come from different endpoints 
> /tenant
> The UI only support searching for users so the 'id' (identity fields within 
> the response json) will match which will throw the error because the code 
> expects the id fields to be unique
> Reproduced in 1.13.2



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] mcgilman merged pull request #5695: NIFI-9578 NiFi user list no longer breaks if a user and group have the same id

[GitBox]

mcgilman merged pull request #5695:
URL: https://github.com/apache/nifi/pull/5695


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory opened a new pull request #5715: NIFI-9630 Migrate Registry REST API docs to swagger-codegen

[GitBox]

exceptionfactory opened a new pull request #5715:
URL: https://github.com/apache/nifi/pull/5715


    Description of PR
   
   NIFI-9630 Migrates the NiFi Registry REST API documentation generation from 
`swagger2markup-maven-plugin` to `swagger-codegen-maven-plugin`.
   
   The [Swagger2Markup](https://github.com/Swagger2Markup/swagger2markup) 
project is no longer maintained and the last release of the Maven plugin was in 
2018.  These changes also remove the need for the `asciidoctor-maven-plugin`, 
which converts the documentation to HTML.  Although the styling is somewhat 
different, the generated HTML documentation contains the same information and 
the `swagger-codegen-maven-plugin` is actively maintained.
   
   Additional changes include removing the templates associated with the 
generation of other unused REST API documentation for NiFi Registry.
   
   This migration also supports removing dependence on the read-only JCenter 
repository since Maven Central does not contain all of the transitive 
dependencies that Swagger2Markup requires.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [X] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [X] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan merged pull request #62: [NIFI-9627] prepare 0.3.0 release

[GitBox]

scottyaslan merged pull request #62:
URL: https://github.com/apache/nifi-fds/pull/62


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-6494) Upgrade to latest LTS release of Node (and npm)

[Scott Aslan (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6494:
--
Fix Version/s: fds-0.3

> Upgrade to latest LTS release of Node (and npm)
> ---
>
> Key: NIFI-6494
> URL: https://issues.apache.org/jira/browse/NIFI-6494
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Rob Fellows
>Assignee: Scott Aslan
>Priority: Major
> Fix For: fds-0.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> nifi-fds currently requires node 8.10.0 and npm 5.6.0. The current LTS for 
> node is v10 and based on the scheduled release, v12 will be in October of 
> 2019.
> One driving factor behind this is to get to a version of npm that includes 
> npm audit. npm v6+ includes it (which is packaged with Node v10).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (NIFI-6739) UI - include hammerJS with unit tests

[Scott Aslan (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan resolved NIFI-6739.
---
Resolution: Fixed

fixed in https://github.com/apache/nifi-fds/pull/60

> UI - include hammerJS with unit tests
> -
>
> Key: NIFI-6739
> URL: https://issues.apache.org/jira/browse/NIFI-6739
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Labels: ui
> Fix For: fds-0.3
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We see 
> WARN LOG: 'The "longpress" event cannot be bound because Hammer.JS is not 
> loaded and no custom loader has been specified.'
> in the logs when running JS unit tests. Including hammerJS will clean up 
> these warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-6739) UI - include hammerJS with unit tests

[Scott Aslan (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6739:
--
Fix Version/s: fds-0.3

> UI - include hammerJS with unit tests
> -
>
> Key: NIFI-6739
> URL: https://issues.apache.org/jira/browse/NIFI-6739
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Labels: ui
> Fix For: fds-0.3
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We see 
> WARN LOG: 'The "longpress" event cannot be bound because Hammer.JS is not 
> loaded and no custom loader has been specified.'
> in the logs when running JS unit tests. Including hammerJS will clean up 
> these warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

exceptionfactory commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021522662


   Is there a reason this class is unable to use the `getDriver()` method from 
`DBCPConnectionPool`? The methods appear to be the same.  Although there may 
not be business logic duplication in `onConfigured()`, there is still a lot of 
setup code that should be shared.  The same applies to the property descriptor 
definitions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan opened a new pull request #62: [NIFI-9627] prepare 0.3.0 release

[GitBox]

scottyaslan opened a new pull request #62:
URL: https://github.com/apache/nifi-fds/pull/62


   Thank you for submitting a contribution to Apache NiFi Flow Design System.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
   - [ ] Have you written or updated the Apache NiFi Flow Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-9630) Migrate NiFi Registry to swagger-codegen-maven-plugin

[David Handermann (Jira)]

David Handermann created NIFI-9630:
--

 Summary: Migrate NiFi Registry to swagger-codegen-maven-plugin
 Key: NIFI-9630
 URL: https://issues.apache.org/jira/browse/NIFI-9630
 Project: Apache NiFi
  Issue Type: Improvement
  Components: NiFi Registry
Reporter: David Handermann
Assignee: David Handermann


NiFi Registry REST API documentation uses a combination of the 
{{swagger2markup-maven-plugin}} and the {{asciidoctor-maven-plugin}} to 
generate the REST API documentation HTML for embedding and publication. The 
[Swagger2Markup|https://github.com/Swagger2Markup/swagger2markup] project is no 
longer maintained, and the last version was released in 2018. In addition, the 
transitive dependencies for Swagger2Markup are no available in Maven Central, 
but can be found in the read-only JCenter repository.

The [Swagger 
Codegen|https://swagger.io/docs/open-source-tools/swagger-codegen/] library, 
and associated Maven plugin, support generating static HTML documentation from 
Swagger definitions. The library and Maven plugin are actively maintained and 
provides a replacement for the current REST API documentation approach in NiFi 
Registry. Although the styling is different than the current approach, the 
generated HTML contains the same information.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] tpalfy commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

tpalfy commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021512187


   I thought it's a good idea to separate ```.name()```  and 
```.displayName()```. With that I'd leave the ```onConfigured()``` as well. 
There's no real business logic duplication just straightforward configuration. 
I think that is fine.
   I can remove the ```getSupportedDynamicPropertyDescriptor``` but I left the 
```getDriver``` method intentionally because the ```Class.forName``` needs to 
be called there, otherwise it's not be able to find the driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5530: NIFI-9341 Adding record reader for CEF events

[GitBox]

exceptionfactory commented on a change in pull request #5530:
URL: https://github.com/apache/nifi/pull/5530#discussion_r791996926



##
File path: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/cef/CEFSchemaUtil.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.cef;
+
+import org.apache.nifi.serialization.record.DataType;
+import org.apache.nifi.serialization.record.RecordField;
+import org.apache.nifi.serialization.record.RecordFieldType;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+final class CEFSchemaUtil {
+
+private static final List HEADER_FIELDS = new ArrayList<>();
+
+static {
+// Reference states that severity might be represented by integer 
values (0-10) and string values (like High) too
+HEADER_FIELDS.add(new RecordField("version", 
RecordFieldType.INT.getDataType()));
+HEADER_FIELDS.add(new RecordField("deviceVendor", 
RecordFieldType.STRING.getDataType()));
+HEADER_FIELDS.add(new RecordField("deviceProduct", 
RecordFieldType.STRING.getDataType()));
+HEADER_FIELDS.add(new RecordField("deviceVersion", 
RecordFieldType.STRING.getDataType()));
+HEADER_FIELDS.add(new RecordField("deviceEventClassId", 
RecordFieldType.STRING.getDataType()));
+HEADER_FIELDS.add(new RecordField("name", 
RecordFieldType.STRING.getDataType()));
+HEADER_FIELDS.add(new RecordField("severity", 
RecordFieldType.STRING.getDataType()));
+}
+
+// Fields known by the CEF Extension Dictionary in version 23
+private static final Set EXTENSIONS_STRING = new 
HashSet<>(Arrays.asList("act", "app", "c6a1Label", "c6a2Label", "c6a3Label",

Review comment:
   It would be very helpful to declare these values one per line, ideally 
alphabetized.  Although it would take some effort, it would make it much easier 
to maintain. On the other hand, would it be better to make String the default 
fallback type and avoid having to declare all of these fields?

##
File path: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/cef/ValidateLocale.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.cef;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.Locale;
+
+/**
+ * This class is identical to {@code 
org.apache.nifi.processors.standard.ParseCEF.ValidateLocale}.

Review comment:
   In light of this comment, did you consider creating a new module under 
`nifi-commons` to avoid duplicating this Validator class?

##
File path: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/cef/TestCEFReader.java
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses 

[jira] [Commented] (NIFI-8549) Upgrade MiNiFi default sensitive properties algorithm

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482036#comment-17482036
 ] 

ASF subversion and git services commented on NIFI-8549:
---

Commit a2cfbe4ac70d9d73bd3ab5bbfd702eaebb524c71 in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a2cfbe4 ]

NIFI-8549 Upgraded MiNiFi sensitive properties algorithm

- Replaced PBEWITHMD5AND256BITAES-CBC-OPENSSL with NIFI_PBKDF2_AES_GCM_256

NIFI-8549 Removed unused provider property from MiNiFi Admin Guide

Signed-off-by: Matthew Burgess 

This closes #5687


> Upgrade MiNiFi default sensitive properties algorithm
> -
>
> Key: NIFI-8549
> URL: https://issues.apache.org/jira/browse/NIFI-8549
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: MiNiFi
>Reporter: Andy LoPresto
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {quote}
> * Could we please change the default algorithm for protecting sensitive 
> property values to something stronger than the current selection? I would 
> open a Jira if necessary, but this is one of those things that is really 
> better to do before the first release so users have a backward-compatible 
> config.yml file moving forward. If we change it in a subsequent release, we 
> will need to do significant migration hand-holding. My suggestion would be 
> "PBEWITHSHA256AND256BITAES-CBC-BC” which is significantly stronger, but after 
> trying a few BC options, I continue to get EncryptionExceptions even though I 
> have the JCE unlimited cryptographic strength jurisdiction policy files 
> installed, so this may be a 0.0.2 fix. Is BouncyCastle not enabled by default?
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-8549) Upgrade MiNiFi default sensitive properties algorithm

[Matt Burgess (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-8549:
---
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Upgrade MiNiFi default sensitive properties algorithm
> -
>
> Key: NIFI-8549
> URL: https://issues.apache.org/jira/browse/NIFI-8549
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: MiNiFi
>Reporter: Andy LoPresto
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {quote}
> * Could we please change the default algorithm for protecting sensitive 
> property values to something stronger than the current selection? I would 
> open a Jira if necessary, but this is one of those things that is really 
> better to do before the first release so users have a backward-compatible 
> config.yml file moving forward. If we change it in a subsequent release, we 
> will need to do significant migration hand-holding. My suggestion would be 
> "PBEWITHSHA256AND256BITAES-CBC-BC” which is significantly stronger, but after 
> trying a few BC options, I continue to get EncryptionExceptions even though I 
> have the JCE unlimited cryptographic strength jurisdiction policy files 
> installed, so this may be a 0.0.2 fix. Is BouncyCastle not enabled by default?
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] mattyb149 closed pull request #5687: NIFI-8549 Upgrade MiNiFi sensitive properties algorithm

[GitBox]

mattyb149 closed pull request #5687:
URL: https://github.com/apache/nifi/pull/5687


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #5687: NIFI-8549 Upgrade MiNiFi sensitive properties algorithm

[GitBox]

mattyb149 commented on pull request #5687:
URL: https://github.com/apache/nifi/pull/5687#issuecomment-1021488524


   +1 LGTM, thanks for the improvement! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5676: NIFI-9589: Support initial loading from the current max values in Que…

[GitBox]

asfgit closed pull request #5676:
URL: https://github.com/apache/nifi/pull/5676


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] kevdoran commented on pull request #5684: NIFI-9605: Docker Images for OpenShift

[GitBox]

kevdoran commented on pull request #5684:
URL: https://github.com/apache/nifi/pull/5684#issuecomment-1021406693


   Hi @guimou @dmnewber,
   
   This is a nice contribution and good discussion. I agree with you @guimou 
that there are real benefits to making NiFi images easier to deploy directly on 
OpenShift. I also agree with @dmnewber that it would be best not to duplicate 
the entire directory of files. While it may leave things more decoupled, it 
does increase the maintenance burden, as any any improvements to the default 
NiFi image would not also have to be done in more places (as we would probably 
want those same enhancements everywhere). We already have this problem today 
across docker hub and dockermaven variants, and plan to try to combine those so 
that they only differ one way, which is how the assembly artifacts are provided.
   
   I've started collecting ideas for how to improve our project structure for 
Docker images produced from the NiFi repository here, and I've added some of 
the goals of this PR to that list: 
https://cwiki.apache.org/confluence/display/NIFI/NiFi+Docker+Container+Improvements
   
   If this is not urgent, I would suggest we tackle some of those goals, such 
as image build consolidation and then figure out how to incorporate base image 
variants as part of that, to take another look at this. I haven't looked at the 
PR closely yet, but aside from basing on ubi8/OpenJDK11, are there any other 
significant changes from the current NiFi Dockerfile?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] pvillard31 commented on pull request #5676: NIFI-9589: Support initial loading from the current max values in Que…

[GitBox]

pvillard31 commented on pull request #5676:
URL: https://github.com/apache/nifi/pull/5676#issuecomment-1021418872


   Merged, thanks @turcsanyip - this is a nice improvement!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (NIFI-9589) QueryDatabaseTableRecord should support initial loading from the current max values

[Pierre Villard (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard resolved NIFI-9589.
--
Fix Version/s: 1.16.0
   Resolution: Fixed

> QueryDatabaseTableRecord should support initial loading from the current max 
> values
> ---
>
> Key: NIFI-9589
> URL: https://issues.apache.org/jira/browse/NIFI-9589
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> QueryDatabaseTableRecord provides dynamic properties to configure initial 
> values for the Maximum-value columns. It can be used to control where the 
> initial loading (starting the processor for the first time) should start off 
> and which rows should be loaded from the database table.
> In the special case, when the user wants to start from the current max values 
> (that is to load only the newly created rows), it would be a better user 
> experience if they did not have to select the max values from the database 
> and then configure the dynamic properties but the processor did it 
> automatically.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (NIFI-9589) QueryDatabaseTableRecord should support initial loading from the current max values

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481977#comment-17481977
 ] 

ASF subversion and git services commented on NIFI-9589:
---

Commit 96b53d894375e98370d2bc41c8f4b3a9a1f1881d in nifi's branch 
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=96b53d8 ]

NIFI-9589: Support initial loading from the current max values in 
QueryDatabaseTable* processors

Signed-off-by: Pierre Villard 

This closes #5676.


> QueryDatabaseTableRecord should support initial loading from the current max 
> values
> ---
>
> Key: NIFI-9589
> URL: https://issues.apache.org/jira/browse/NIFI-9589
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> QueryDatabaseTableRecord provides dynamic properties to configure initial 
> values for the Maximum-value columns. It can be used to control where the 
> initial loading (starting the processor for the first time) should start off 
> and which rows should be loaded from the database table.
> In the special case, when the user wants to start from the current max values 
> (that is to load only the newly created rows), it would be a better user 
> experience if they did not have to select the max values from the database 
> and then configure the dynamic properties but the processor did it 
> automatically.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1242: MINIFICPP-1631 Create ListAzureDataLakeStorage processor

[GitBox]

lordgamez commented on pull request #1242:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1242#issuecomment-1021103973


   > There is a relevant test failure in the windows job.
   
   Fixed in 6bf91f2449d187c57a1c38a3904e230647c2b6e8. Only unrelated SQL tests 
are failing now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan closed pull request #61: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

scottyaslan closed pull request #61:
URL: https://github.com/apache/nifi-fds/pull/61


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement

[GitBox]

szaszm commented on a change in pull request #1248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1248#discussion_r791648848



##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  std::hash hasher;
+  seed ^= hasher(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
+  (hash_combine(seed, rest), ...);
+}
+}

Review comment:
   The linter should complain here that anonymous namespaces should be 
terminated with a `  // namespace` comment. Is it not running for some reason?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5691: NIFI-9569: SNMP manager UDP transportmapping changed to 0.0.0.0

[GitBox]

asfgit closed pull request #5691:
URL: https://github.com/apache/nifi/pull/5691


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan edited a comment on pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

scottyaslan edited a comment on pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57#issuecomment-1020508687






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] davyam edited a comment on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via

[GitBox]

davyam edited a comment on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020539193






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

scottyaslan commented on a change in pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57#discussion_r791123612



##
File path: webapp/fds-bootstrap.js
##
@@ -54,6 +54,27 @@ if (!locale || locale === 'en-us') {
 }
 platformBrowserDynamic().bootstrapModule(FdsModule, {providers: 
providers});
 }).fail(function () {
-platformBrowserDynamic().bootstrapModule(FdsModule, {providers: 
providers});
+// was this a country specific locale? if so, try to get the generic 
version of the language
+const localeTokens = locale.split('-');
+if (localeTokens.length === 2) {
+translationFile = './webapp/locale/messages.' + localeTokens[0] + 
'.xlf';
+$.ajax({
+url: translationFile,
+dataType: 'text'
+}).done(function (translations) {
+// add providers if translation file for locale is loaded
+if (translations) {
+providers.push({provide: TRANSLATIONS, useValue: 
translations});
+providers.push({provide: TRANSLATIONS_FORMAT, useValue: 
'xlf'});
+providers.push({provide: LOCALE_ID, useValue: 
localeTokens[0]});
+}
+platformBrowserDynamic().bootstrapModule(FdsModule, 
{providers: providers});
+}).fail(function () {
+platformBrowserDynamic().bootstrapModule(FdsModule, 
{providers: providers});

Review comment:
   > nifi-fds@0.3.0-SNAPSHOT eslint
   > eslint webapp platform
   
   
   
/Users/jaslan/Development/nifi-fds/target/frontend-working-directory/webapp/fds-bootstrap.js
 73:16  error  Block must not be padded by blank lines  padded-blocks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement

[GitBox]

martinzink commented on a change in pull request #1248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1248#discussion_r791826948



##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  std::hash hasher;
+  seed ^= hasher(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
+  (hash_combine(seed, rest), ...);
+}
+}

Review comment:
   you are right and I even found invalid indents in the file (e.g. line 
325) which should also set off the linter.
   So I checked but it is indeed running, and if I remove the comment in the 
last line `}  // namespace org::apache::nifi::minifi::processors` it does 
complain...
   
   I also ran the linter directly on this file, and still no errors
   `python ../thirdparty/google-styleguide/cpplint.py --linelength=200 
../extensions/standard-processors/processors/DefragmentText.cpp`
   I even tried it with the up-to-date version from 
https://github.com/cpplint/cpplint/blob/develop/cpplint.py but it still doesnt 
catch this style violation

##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  

[GitHub] [nifi] joewitt commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

[GitBox]

joewitt commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020624652






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] davyam commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logica

[GitBox]

davyam commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020539193






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logic

[GitBox]

joewitt commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020569739


   Fired off the workflow run for new contributor (thanks!) and closed the old 
referenced PR as requested. Hopoefully this one makes quick progress into a 
merge/release.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] joewitt closed pull request #4065: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Replication.

[GitBox]

joewitt closed pull request #4065:
URL: https://github.com/apache/nifi/pull/4065


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

turcsanyip commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412


   @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the 
following should work:
   - declare `nifi-dbcp-service-nar` as the parent nar of the new 
`nifi-snowflake-service-nar` bundle (all classes in jars bundled in the parent 
will be available for the child at runtime)
   - add `nifi-dbcp-service` (jar) dependency in `nifi-snowflake-service` as 
`provided` (=> you can inherit from the class but ServiceLoader will not 
initialize duplicated service classes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] mtien-apache commented on pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

mtien-apache commented on pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57#issuecomment-1020518908


   Reviewing now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] scottyaslan commented on pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

scottyaslan commented on pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57#issuecomment-1020508605






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory closed pull request #5699: NIFI-7840: Upgrade to Groovy 3.0.8 and Spock 2.1

[GitBox]

exceptionfactory closed pull request #5699:
URL: https://github.com/apache/nifi/pull/5699


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] davyam commented on pull request #4065: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Replication

[GitBox]

davyam commented on pull request #4065:
URL: https://github.com/apache/nifi/pull/4065#issuecomment-1020534864


   Guys, as the code was refactored and the processor behavior was changed, we 
decided to start a new PR #5710. Then, we avoid misunderstandings with old 
messages.
   
   There are several improvements in this new PR #5710 and we hope that all the 
contributors keep doing tests and giving us feedback from there.
   
   ASAP this PR can be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory closed pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…

[GitBox]

exceptionfactory closed pull request #5668:
URL: https://github.com/apache/nifi/pull/5668


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1245: MINIFICPP-1733 Remove debian buster docker build target

[GitBox]

martinzink closed pull request #1245:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

[GitBox]

exceptionfactory commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020641887






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1237: MINIFICPP-1224 Add module directory support to script execution

[GitBox]

martinzink closed pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] rfellows closed pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

rfellows closed pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-fds] rfellows commented on pull request #57: NIFI-6732 - Attempt to look up messages locale file without country d…

[GitBox]

rfellows commented on pull request #57:
URL: https://github.com/apache/nifi-fds/pull/57#issuecomment-1020525073


   Closing in favor of https://github.com/apache/nifi-fds/pull/61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] davyam edited a comment on pull request #4065: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Repl

[GitBox]

davyam edited a comment on pull request #4065:
URL: https://github.com/apache/nifi/pull/4065#issuecomment-1020534864


   Guys, as the code was refactored and the processor behavior was changed, we 
decided to start a new PR #5710. Then, we avoid misunderstandings with old 
messages.
   
   There are several improvements in this new PR #5710 and we hope that all the 
contributors keep doing tests and giving us feedback from there.
   
   **ASAP this PR can be closed.**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

exceptionfactory commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1020456025






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5706: NIFI-9293: Ensure that we properly set the scheduled flag in the Life…

[GitBox]

asfgit closed pull request #5706:
URL: https://github.com/apache/nifi/pull/5706


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

[GitBox]

asfgit closed pull request #5711:
URL: https://github.com/apache/nifi/pull/5711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] tpalfy commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

tpalfy commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1020451641






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] joewitt edited a comment on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

[GitBox]

joewitt edited a comment on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020636039


   [ERROR] Errors:
   [ERROR]   TestDistributedMapServerAndClient.setRunner:70 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedMapServerAndClient.setRunner:70 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedMapServerAndClient.setRunner:70 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedMapServerAndClient.setRunner:70 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedSetServerAndClient.setRunner:63 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedSetServerAndClient.setRunner:63 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedSetServerAndClient.setRunner:63 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedSetServerAndClient.setRunner:63 » IllegalArgument 
File system e...
   [ERROR]   TestDistributedSetServerAndClient.setRunner:63 » IllegalArgument 
File system e...
   [INFO]
   [ERROR] Tests run: 22, Failures: 0, Errors: 9, Skipped: 0
   
   failed locally on Java11 for me and appears to have done so on github ci as 
well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] gerdansantos commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via

[GitBox]

gerdansantos commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020644890


   I have tested this code.
   
   ✅ Build without exceptions
   ✅ The mock tests seem enough
   ✅ The CDC start without problems including PostgreSQL slots
   ✅ The Syncing Turn On process runs fine
   ❌ The recovery process, dont conect and recovery from abrutal shutdown of 
PostgreSQL of NiFi. I beleive the processor stat came be definied before 
PostgreSQL lsn Commit, so the PostgreSQL cannot resync with the last past LSN.
   ✅If the stop process, the processor restart from last step without problems.
   ❌ The connection with a slot previously created don't run.
   
   
   Congrats for the evolution of this processor code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] markap14 closed pull request #5713: Fixed issue that caused system test not to wait for processor to stop…

[GitBox]

markap14 closed pull request #5713:
URL: https://github.com/apache/nifi/pull/5713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (MINIFICPP-1733) Remove debian buster docker build target

[Jira]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi resolved MINIFICPP-1733.
--
Fix Version/s: 0.12.0
   Resolution: Fixed

> Remove debian buster docker build target
> 
>
> Key: MINIFICPP-1733
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1733
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Gábor Gyimesi
>Priority: Minor
> Fix For: 0.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GCC version 11 is not supported on Debian Buster, so building the project 
> with that docker target is currently not possible. Testing on Debian can 
> continue by using the binaries built on the CentOS image.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1245: MINIFICPP-1733 Remove debian buster docker build target

[GitBox]

martinzink closed pull request #1245:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-9625) Unstable Distributed Cache test

[Joe Witt (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Witt updated NIFI-9625:
---
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

+1 merged to main.

Happy on multiple previous failing Java 8 builds.  Happy on Java 11.  Happy on 
GithubCI.   Good stuff thanks

> Unstable Distributed Cache test
> ---
>
> Key: NIFI-9625
> URL: https://issues.apache.org/jira/browse/NIFI-9625
> Project: Apache NiFi
>  Issue Type: Bug
> Environment: Maven home: /development/tools/apache-maven-3.8.4
> Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: 
> /usr/lib/jvm/zulu8.60.0.21-ca-jdk8.0.322-linux_x64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.15.14-200.fc35.x86_64", arch: "amd64", family: 
> "unix"
>Reporter: Joe Witt
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> [ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 4.788 s <<< FAILURE! - in 
> org.apache.nifi.distributed.cache.server.TestServerAndClient
> [ERROR] 
> org.apache.nifi.distributed.cache.server.TestServerAndClient.testClientTermination
>   Time elapsed: 0.021 s  <<< ERROR!
> java.net.BindException: Address already in use
>   at 
> org.apache.nifi.distributed.cache.server.TestServerAndClient.testClientTermination(TestServerAndClient.java:477)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] asfgit closed pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

[GitBox]

asfgit closed pull request #5711:
URL: https://github.com/apache/nifi/pull/5711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9625) Unstable Distributed Cache test

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481917#comment-17481917
 ] 

ASF subversion and git services commented on NIFI-9625:
---

Commit b40b5a7c96d973f08a04a8d382e8c9fbce9f758a in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b40b5a7 ]

NIFI-9625 This closes #5711. Refactored Distributed Cache Server and Client 
Tests
- Replaced TestServerAndClient with separate classes for Set Server and Map 
Server
- Implemented before and after annotations for starting and stopping server 
instances
NIFI-9625 Added check for cache directory existence before clean
NIFI-9625 Updated Map and Set Cache Server Tests to use random port

Signed-off-by: Joe Witt 


> Unstable Distributed Cache test
> ---
>
> Key: NIFI-9625
> URL: https://issues.apache.org/jira/browse/NIFI-9625
> Project: Apache NiFi
>  Issue Type: Bug
> Environment: Maven home: /development/tools/apache-maven-3.8.4
> Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: 
> /usr/lib/jvm/zulu8.60.0.21-ca-jdk8.0.322-linux_x64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.15.14-200.fc35.x86_64", arch: "amd64", family: 
> "unix"
>Reporter: Joe Witt
>Assignee: David Handermann
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> [ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 4.788 s <<< FAILURE! - in 
> org.apache.nifi.distributed.cache.server.TestServerAndClient
> [ERROR] 
> org.apache.nifi.distributed.cache.server.TestServerAndClient.testClientTermination
>   Time elapsed: 0.021 s  <<< ERROR!
> java.net.BindException: Address already in use
>   at 
> org.apache.nifi.distributed.cache.server.TestServerAndClient.testClientTermination(TestServerAndClient.java:477)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (NIFI-7840) ExecuteScript - Groovy 3.0

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481906#comment-17481906
 ] 

ASF subversion and git services commented on NIFI-7840:
---

Commit bb24030f4ad0a97b7156916531c20226891a3400 in nifi's branch 
refs/heads/main from Matt Burgess
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=bb24030 ]

NIFI-7840: Upgrade to Groovy 3.0.8 and Spock 2.1

This closes #5699

Signed-off-by: David Handermann 


> ExecuteScript - Groovy 3.0
> --
>
> Key: NIFI-7840
> URL: https://issues.apache.org/jira/browse/NIFI-7840
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mermillod
>Assignee: Matt Burgess
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features 
> like lambdas.
> (ExecuteScript is using Groov 2.5.4)
> New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html]
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-7840) Upgrade to Groovy 3

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-7840:
---
Summary: Upgrade to Groovy 3  (was: ExecuteScript - Groovy 3.0)

> Upgrade to Groovy 3
> ---
>
> Key: NIFI-7840
> URL: https://issues.apache.org/jira/browse/NIFI-7840
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mermillod
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.16.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features 
> like lambdas.
> (ExecuteScript is using Groov 2.5.4)
> New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html]
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-7840) ExecuteScript - Groovy 3.0

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-7840:
---
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> ExecuteScript - Groovy 3.0
> --
>
> Key: NIFI-7840
> URL: https://issues.apache.org/jira/browse/NIFI-7840
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mermillod
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.16.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features 
> like lambdas.
> (ExecuteScript is using Groov 2.5.4)
> New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html]
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory closed pull request #5699: NIFI-7840: Upgrade to Groovy 3.0.8 and Spock 2.1

[GitBox]

exceptionfactory closed pull request #5699:
URL: https://github.com/apache/nifi/pull/5699


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9570) NiFi Registry fails to start with S3BundlePersistenceProvider

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481901#comment-17481901
 ] 

ASF subversion and git services commented on NIFI-9570:
---

Commit 4000b01909a790195a744d48f8f08f214d1f0ef2 in nifi's branch 
refs/heads/main from Bryan Bende
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4000b01 ]

NIFI-9570 Separate classpath for NiFi Registry sensitive property providers

This closes #5668

Signed-off-by: David Handermann 


> NiFi Registry fails to start with S3BundlePersistenceProvider
> -
>
> Key: NIFI-9570
> URL: https://issues.apache.org/jira/browse/NIFI-9570
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.0, 1.15.1, 1.15.2
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> {code:java}
> Caused by: java.lang.NoSuchFieldError: TLS_TRUST_MANAGERS_PROVIDER
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.getSslContext(UrlConnectionHttpClient.java:165)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.(UrlConnectionHttpClient.java:82)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.(UrlConnectionHttpClient.java:67)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient$DefaultBuilder.buildWithDefaults(UrlConnectionHttpClient.java:364)
>         at 
> software.amazon.awssdk.core.internal.http.loader.DefaultSdkHttpClientBuilder.lambda$buildWithDefaults$0(DefaultSdkHttpClientBuilder.java:42)
>         at java.util.Optional.map(Optional.java:215)
>         at 
> software.amazon.awssdk.core.internal.http.loader.DefaultSdkHttpClientBuilder.buildWithDefaults(DefaultSdkHttpClientBuilder.java:42)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.lambda$resolveSyncHttpClient$4(SdkDefaultClientBuilder.java:245)
>         at java.util.Optional.orElseGet(Optional.java:267)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.resolveSyncHttpClient(SdkDefaultClientBuilder.java:245)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.finalizeSyncConfiguration(SdkDefaultClientBuilder.java:210)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.syncClientConfiguration(SdkDefaultClientBuilder.java:148)
>         at 
> software.amazon.awssdk.services.s3.DefaultS3ClientBuilder.buildClient(DefaultS3ClientBuilder.java:27)
>         at 
> software.amazon.awssdk.services.s3.DefaultS3ClientBuilder.buildClient(DefaultS3ClientBuilder.java:22)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.build(SdkDefaultClientBuilder.java:119)
>         at 
> org.apache.nifi.registry.aws.S3BundlePersistenceProvider.createS3Client(S3BundlePersistenceProvider.java:105)
>         at 
> org.apache.nifi.registry.aws.S3BundlePersistenceProvider.onConfigured(S3BundlePersistenceProvider.java:91)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory.getBundlePersistenceProvider(StandardProviderFactory.java:261)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d.CGLIB$getBundlePersistenceProvider$2()
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d$$FastClassBySpringCGLIB$$a9053f3f.invoke()
>         at 
> org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:244)
>         at 
> org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:331)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d.getBundlePersistenceProvider()
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at 
> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
>         ... 86 common frames omitted {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9570) NiFi Registry fails to start with S3BundlePersistenceProvider

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9570:
---
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> NiFi Registry fails to start with S3BundlePersistenceProvider
> -
>
> Key: NIFI-9570
> URL: https://issues.apache.org/jira/browse/NIFI-9570
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.0, 1.15.1, 1.15.2
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
> Fix For: 1.16.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> {code:java}
> Caused by: java.lang.NoSuchFieldError: TLS_TRUST_MANAGERS_PROVIDER
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.getSslContext(UrlConnectionHttpClient.java:165)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.(UrlConnectionHttpClient.java:82)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.(UrlConnectionHttpClient.java:67)
>         at 
> software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient$DefaultBuilder.buildWithDefaults(UrlConnectionHttpClient.java:364)
>         at 
> software.amazon.awssdk.core.internal.http.loader.DefaultSdkHttpClientBuilder.lambda$buildWithDefaults$0(DefaultSdkHttpClientBuilder.java:42)
>         at java.util.Optional.map(Optional.java:215)
>         at 
> software.amazon.awssdk.core.internal.http.loader.DefaultSdkHttpClientBuilder.buildWithDefaults(DefaultSdkHttpClientBuilder.java:42)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.lambda$resolveSyncHttpClient$4(SdkDefaultClientBuilder.java:245)
>         at java.util.Optional.orElseGet(Optional.java:267)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.resolveSyncHttpClient(SdkDefaultClientBuilder.java:245)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.finalizeSyncConfiguration(SdkDefaultClientBuilder.java:210)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.syncClientConfiguration(SdkDefaultClientBuilder.java:148)
>         at 
> software.amazon.awssdk.services.s3.DefaultS3ClientBuilder.buildClient(DefaultS3ClientBuilder.java:27)
>         at 
> software.amazon.awssdk.services.s3.DefaultS3ClientBuilder.buildClient(DefaultS3ClientBuilder.java:22)
>         at 
> software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.build(SdkDefaultClientBuilder.java:119)
>         at 
> org.apache.nifi.registry.aws.S3BundlePersistenceProvider.createS3Client(S3BundlePersistenceProvider.java:105)
>         at 
> org.apache.nifi.registry.aws.S3BundlePersistenceProvider.onConfigured(S3BundlePersistenceProvider.java:91)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory.getBundlePersistenceProvider(StandardProviderFactory.java:261)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d.CGLIB$getBundlePersistenceProvider$2()
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d$$FastClassBySpringCGLIB$$a9053f3f.invoke()
>         at 
> org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:244)
>         at 
> org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:331)
>         at 
> org.apache.nifi.registry.provider.StandardProviderFactory$$EnhancerBySpringCGLIB$$e342653d.getBundlePersistenceProvider()
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at 
> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
>         ... 86 common frames omitted {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory closed pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…

[GitBox]

exceptionfactory closed pull request #5668:
URL: https://github.com/apache/nifi/pull/5668


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement

[GitBox]

martinzink commented on a change in pull request #1248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1248#discussion_r791826948



##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  std::hash hasher;
+  seed ^= hasher(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
+  (hash_combine(seed, rest), ...);
+}
+}

Review comment:
   you are right and I even found invalid indents in the file (e.g. line 
325) which should also set off the linter(although I'm not sure if that the 
linter checks that).
   So I checked but it is indeed running, and if I remove the comment in the 
last line `}  // namespace org::apache::nifi::minifi::processors` it does 
complain...
   
   I also ran the linter directly on this file, and still no errors
   `python ../thirdparty/google-styleguide/cpplint.py --linelength=200 
../extensions/standard-processors/processors/DefragmentText.cpp`
   I even tried it with the up-to-date version from 
https://github.com/cpplint/cpplint/blob/develop/cpplint.py but it still doesnt 
catch this style violation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement

[GitBox]

martinzink commented on a change in pull request #1248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1248#discussion_r791826948



##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  std::hash hasher;
+  seed ^= hasher(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
+  (hash_combine(seed, rest), ...);
+}
+}

Review comment:
   you are right and I even found invalid indents in the file (e.g. line 
325) which should also set off the linter.
   So I checked but it is indeed running, and if I remove the comment in the 
last line `}  // namespace org::apache::nifi::minifi::processors` it does 
complain...
   
   I also ran the linter directly on this file, and still no errors
   `python ../thirdparty/google-styleguide/cpplint.py --linelength=200 
../extensions/standard-processors/processors/DefragmentText.cpp`
   I even tried it with the up-to-date version from 
https://github.com/cpplint/cpplint/blob/develop/cpplint.py but it still doesnt 
catch this style violation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

exceptionfactory commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021271665


   Thanks @turcsanyip, that sounds like a good solution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MINIFICPP-1736) Add MiNiFi agent C2 operation capabilities to agent manifest

[Jira]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi updated MINIFICPP-1736:
-
Description: 
 

Agent manifest should be extended in the following format with the agent's 
capabilities:
{code:java}
{
  ...
  "supportedOperations": [
    {
      "type": OperationType,
      "properties": [
{
          "operand": OperandType,
          "metaData": [
            {
              "key": String,
              "value": Object
            }
          ]
}
      ]
    }
  ]
  ...
} {code}
 

 

  was:
 

Agent manifest should be extended in the following format with the agent's 
capabilities:
{code:java}
{
  ...
  "supportedOperations": [
    {
      "type": OperationType,
      "properties": [
        "operand": OperandType,
        "metaData": [
          {
            "key": String,
            "value": Object
          }
        ]
      ]
    }
  ]
  ...
} {code}
 

 


> Add MiNiFi agent C2 operation capabilities to agent manifest
> 
>
> Key: MINIFICPP-1736
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1736
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
>
>  
> Agent manifest should be extended in the following format with the agent's 
> capabilities:
> {code:java}
> {
>   ...
>   "supportedOperations": [
>     {
>       "type": OperationType,
>       "properties": [
> {
>           "operand": OperandType,
>           "metaData": [
>             {
>               "key": String,
>               "value": Object
>             }
>           ]
> }
>       ]
>     }
>   ]
>   ...
> } {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (MINIFICPP-1215) Document and test SQL extension

[Marton Szasz (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated MINIFICPP-1215:

Fix Version/s: 0.10.0
   (was: 0.11.0)

> Document and test SQL extension
> ---
>
> Key: MINIFICPP-1215
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1215
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Marton Szasz
>Priority: Major
>  Labels: MiNiFi-CPP-Hygiene
> Fix For: 0.10.0
>
>
> The SQL extension lacks documentation and test coverage. The purpose of this 
> ticket is to fix that.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (MINIFICPP-1215) Document and test SQL extension

[Marton Szasz (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz resolved MINIFICPP-1215.
-
Resolution: Duplicate

> Document and test SQL extension
> ---
>
> Key: MINIFICPP-1215
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1215
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Marton Szasz
>Priority: Major
>  Labels: MiNiFi-CPP-Hygiene
> Fix For: 0.11.0
>
>
> The SQL extension lacks documentation and test coverage. The purpose of this 
> ticket is to fix that.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (MINIFICPP-1718) Keep case of column names in SQL processors

[Adam Debreceni (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Debreceni resolved MINIFICPP-1718.
---
Resolution: Fixed

> Keep case of column names in SQL processors
> ---
>
> Key: MINIFICPP-1718
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1718
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Adam Debreceni
>Assignee: Adam Debreceni
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently we transform all column names to lowercase, in some sql agents 
> column/table names are case-sensitive so we should respect the case.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (MINIFICPP-1215) Document and test SQL extension

[Adam Debreceni (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Debreceni reassigned MINIFICPP-1215:
-

Assignee: (was: Adam Debreceni)

> Document and test SQL extension
> ---
>
> Key: MINIFICPP-1215
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1215
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Marton Szasz
>Priority: Major
>  Labels: MiNiFi-CPP-Hygiene
> Fix For: 0.11.0
>
>
> The SQL extension lacks documentation and test coverage. The purpose of this 
> ticket is to fix that.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (MINIFICPP-1224) Implement runtime module-directory extension for ExecutePythonScript

[Jira]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi resolved MINIFICPP-1224.
--
Fix Version/s: 0.12.0
   Resolution: Fixed

> Implement runtime module-directory extension for ExecutePythonScript
> 
>
> Key: MINIFICPP-1224
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1224
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.7.0
>Reporter: Adam Hunyadi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Fix For: 0.12.0
>
> Attachments: Screenshot 2020-05-13 at 16.49.35.png
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> *Background:*
> Having no runtime extension should be a convenience feature only, one could 
> both use the python code itself.
> It should be possible to access {{{color:#403294}{{sys.path}}{color}}} from 
> the cpp wrapper like this: 
> [https://pybind11.readthedocs.io/en/stable/advanced/embedding.html#importing-modules]
> !Screenshot 2020-05-13 at 16.49.35.png|width=631,height=142!
> Having this code called before the script-engines start causes crash even 
> under gil.
> *Proposal:*
> Extend the python script engine with an interface that handles module imports 
> and call to it before any {{{color:#403294}{{eval}}{color}}} call happens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1237: MINIFICPP-1224 Add module directory support to script execution

[GitBox]

martinzink closed pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MINIFICPP-1741) Docker-based integration tests should only test features which are available

[Ferenc Gerlits (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ferenc Gerlits updated MINIFICPP-1741:
--
Description: 
To run the docker-based integration tests, you
 # run {{cmake}} with some set of flags to enable or disable certain features;
 # run {{make docker}} to create the minifi image;
 # run {{make docker-verify}} to run the tests.

The problem is that the image created in (2) will only contain the features 
selected in (1), but (3) will run all tests, even those which require a feature 
not included in the image – these tests will fail.

We should find a way to only run tests for features enabled in the {{cmake}} 
step, as it is done in the case of unit tests.

  was:
To run the docker-based integration tests, you
 # run {{cmake}} with some set of flags to enable or disable certain features;
 # run {{make docker}} to create the minifi image;
 # run {{make docker-verify}} to run the tests.

The problem is that the image created in (2) will only contain the features 
selected in (1), but (3) will run all tests, even those which require feature 
not included in the image – these tests will fail.

We should find a way to only run tests for features enabled in the {{cmake}} 
step, as it is done in the case of unit tests.


> Docker-based integration tests should only test features which are available
> 
>
> Key: MINIFICPP-1741
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1741
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Priority: Minor
>  Labels: MiNiFi-CPP-Hygiene
>
> To run the docker-based integration tests, you
>  # run {{cmake}} with some set of flags to enable or disable certain features;
>  # run {{make docker}} to create the minifi image;
>  # run {{make docker-verify}} to run the tests.
> The problem is that the image created in (2) will only contain the features 
> selected in (1), but (3) will run all tests, even those which require a 
> feature not included in the image – these tests will fail.
> We should find a way to only run tests for features enabled in the {{cmake}} 
> step, as it is done in the case of unit tests.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (MINIFICPP-1741) Docker-based integration tests should only test features which are available

[Ferenc Gerlits (Jira)]

Ferenc Gerlits created MINIFICPP-1741:
-

 Summary: Docker-based integration tests should only test features 
which are available
 Key: MINIFICPP-1741
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1741
 Project: Apache NiFi MiNiFi C++
  Issue Type: Improvement
Reporter: Ferenc Gerlits


To run the docker-based integration tests, you
 # run {{cmake}} with some set of flags to enable or disable certain features;
 # run {{make docker}} to create the minifi image;
 # run {{make docker-verify}} to run the tests.

The problem is that the image created in (2) will only contain the features 
selected in (1), but (3) will run all tests, even those which require feature 
not included in the image – these tests will fail.

We should find a way to only run tests for features enabled in the {{cmake}} 
step, as it is done in the case of unit tests.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9629) Avro Writer Schema Default Value not correctly being set

[Nathan English (Jira)]

Nathan English created NIFI-9629:


 Summary: Avro Writer Schema Default Value not correctly being set
 Key: NIFI-9629
 URL: https://issues.apache.org/jira/browse/NIFI-9629
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.15.3, 1.15.2, 1.15.1, 1.15.0, 1.16.0
 Environment: WSL Ubuntu, Java 11 Open JDK
Reporter: Nathan English
 Attachments: Avro_Default_Value_Conversion_Issue_-_20220125.xml

Using the Avro Record Set Writer to create fields that don't exist and set 
default values is currently causing issues. I haven't tested all the possible 
types, but below are the ones I have tested:
 * String with string default value - OK
 * String with null - {color:#FF}Error{color}
 * Byte with null - {color:#FF}Error{color}
 * Int with 0 Default value - OK
 * Long with 0 default value - {color:#FF}Error{color}

{color:#172b4d}Looking at the AvroTypeUtil class when the field is put with its 
default value the null, is actually an org.apache.avro.JsonProperties$Null 
instead of an actual null value. The long is actually a default of an int 
value. These both throw errors when being encoded to the Avro Format.{color}

{color:#172b4d}The attached flow successfully reproduces the errors.{color}

 

{color:#172b4d}I have tested the flow and it successfully works in v1.12.1, but 
not a build from the main branch.{color}

 

{color:#172b4d}This issue leads on from NIFI-9594{color}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement

[GitBox]

szaszm commented on a change in pull request #1248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1248#discussion_r791648848



##
File path: extensions/standard-processors/processors/DefragmentText.cpp
##
@@ -297,29 +297,34 @@ void DefragmentText::Buffer::store(core::ProcessSession* 
session, const std::sha
   }
 }
 
-bool DefragmentText::Buffer::isCompatible(const core::FlowFile& fragment) 
const {
+std::optional DefragmentText::Buffer::getNextFragmentOffset() const {
   if (empty())
-return true;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE)) {
-return false;
-  }
-  if (buffered_flow_file_->getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)
-  != fragment.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE)) {
-return false;
-  }
-  std::string current_offset_str, append_offset_str;
-  if (buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
current_offset_str)
-  != fragment.getAttribute(textfragmentutils::OFFSET_ATTRIBUTE, 
append_offset_str)) {
-return false;
-  }
-  if (!current_offset_str.empty() && !append_offset_str.empty()) {
-size_t current_offset = std::stoi(current_offset_str);
-size_t append_offset = std::stoi(append_offset_str);
-if (current_offset + buffered_flow_file_->getSize() != append_offset)
-  return false;
-  }
-  return true;
+return std::nullopt;
+  if (auto offset_attribute = 
buffered_flow_file_->getAttribute(textfragmentutils::OFFSET_ATTRIBUTE))
+return std::stoi(*offset_attribute) + buffered_flow_file_->getSize();
+  return std::nullopt;
+}
+
+DefragmentText::FragmentSource::Id::Id(const core::FlowFile& flow_file) {
+  if (auto base_name_attribute = 
flow_file.getAttribute(textfragmentutils::BASE_NAME_ATTRIBUTE))
+base_name_attribute_ = *base_name_attribute;
+  if (auto post_name_attribute = 
flow_file.getAttribute(textfragmentutils::POST_NAME_ATTRIBUTE))
+post_name_attribute_ = *post_name_attribute;
+}
+
+namespace {
+template 
+void hash_combine(size_t& seed, const T& v, Rest... rest) {
+  std::hash hasher;
+  seed ^= hasher(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
+  (hash_combine(seed, rest), ...);
+}
+}

Review comment:
   The linter should complain here that anonymous namespaces should be 
terminated with a `  // namespace` comment. Is it not running for some reason?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] davyam commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logica

[GitBox]

davyam commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1021118807


   > > Fired off the workflow run for new contributor (thanks!) and closed the 
old referenced PR as requested. Hopoefully this one makes quick progress into a 
merge/release.
   > > Thanks
   > 
   > @joewitt
   > 
   > The unit tests are failing because they are trying to validate the driver 
location. I will fix this, leaving this validation only in the integration 
tests.
   
   Hi @joewitt! The driver location validation was removed from Unit Tests. 
Please, fire off the workflow again. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1242: MINIFICPP-1631 Create ListAzureDataLakeStorage processor

[GitBox]

lordgamez commented on pull request #1242:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1242#issuecomment-1021103973


   > There is a relevant test failure in the windows job.
   
   Fixed in 6bf91f2449d187c57a1c38a3904e230647c2b6e8. Only unrelated SQL tests 
are failing now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

[GitBox]

turcsanyip commented on pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412


   @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the 
following should work:
   - declare `nifi-dbcp-service-nar` as the parent nar of the new 
`nifi-snowflake-service-nar` bundle (all classes in jars bundled in the parent 
will be available for the child at runtime)
   - add `nifi-dbcp-service` (jar) dependency in `nifi-snowflake-service` as 
`provided` (=> you can inherit from the class but ServiceLoader will not 
initialize duplicated service classes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MINIFICPP-1740) Implement FetchFile processor

[Martin Zink (Jira)]

Martin Zink created MINIFICPP-1740:
--

 Summary: Implement FetchFile processor
 Key: MINIFICPP-1740
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1740
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Martin Zink


The FetchFile has a  [nifi 
version|https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.6.0/org.apache.nifi.processors.standard.FetchFile/],
 but it is missing in MiNiFi C++.

Fetchfile could expand the capabilities of remote processing while using 
minifi. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)