[jira] [Created] (NIFI-10221) Nifi does not respect multirecord domain in hostname field.

2022-07-11 Thread Wiktor Kubicki (Jira)
Wiktor Kubicki created NIFI-10221:
-

 Summary: Nifi does not respect multirecord domain in hostname 
field.
 Key: NIFI-10221
 URL: https://issues.apache.org/jira/browse/NIFI-10221
 Project: Apache NiFi
  Issue Type: Bug
Affects Versions: 1.16.0
Reporter: Wiktor Kubicki


*Short description:*

Using DNS we are able to add multiple A records with several IP addresses to 
domain, but Nifi use always only (first?) one.

 

*Background:*

We can add multiple A records in DNS to provide round robin "load balancer", 
which can also be used as failover server in Active - Active server schema. A 
good example of that implementation is there: [How To Configure DNS Round-Robin 
Load-Balancing For High-Availability | 
DigitalOcean|https://www.digitalocean.com/community/tutorials/how-to-configure-dns-round-robin-load-balancing-for-high-availability].

We use this solution to provide address to our two sFTP servers in  different 
geographical locations.

 

{*}How it works now{*}:

When i put domain into hostname field in listSFTP, Nifi will solve DNS and 
obtain only one address (probably the first one but i cannot comfirm) and 
connect to it. But when this one IP is unreachable, NiFi will not try with 
second one nor try the second one in any next run.

 

*How it should works:*

Addresses should be used randomly (round robin), and if one is unavailable, 
then in the same run should be tried another one till end of IP's or successful 
connection.

 

{*}Example{*}:

Using sftp client (OpenSSH_7.4p1, OpenSSL 1.0.2k-fips  26 Jan 2017) i can 
connect to host by domain, even if one of IP addresses is down:

 
{code:java}
$ sftp -vvv -oPort=22 u...@example.com
OpenSSH_7.4p1, OpenSSL 1.0.2k-fips  26 Jan 2017
debug1: Reading configuration data /XXX/.ssh/config
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 58: Applying options for *
debug2: resolving "example.com" port 22
debug2: ssh_connect_direct: needpriv 0
debug1: Connecting to example.com [X.X.X.203] port 22.
debug1: connect to address X.X.X.203 port 22: Connection refused
debug1: Connecting to example.com [Y.Y.Y.123] port 22.
debug1: Connection established.{code}
As you can see, sftp tries to connect to first, when connections refused then 
it try to second one with success. And that's how it should work in NiFi

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] CloudWise-Lukemiao commented on pull request #6190: NIFI-10210 Processor supporting Apache iotdb database

2022-07-11 Thread GitBox


CloudWise-Lukemiao commented on PR #6190:
URL: https://github.com/apache/nifi/pull/6190#issuecomment-1181284533

   > 
   
   
   
   > > Thanks for the contribution @CloudWise-Lukemiao!
   > > The implementation appears to use both the JDBC and Native Java library 
for interacting with IoTDB. JDBC access is already possible using existing 
components and leveraging the `DBCPConnnectionPool` or `HikariCPConnectionPool` 
services.
   > > The [IoTDB documentation for 
JDBC](https://iotdb.apache.org/UserGuide/Master/API/Programming-JDBC.html) 
notes that using JDBC is not recommended for high throughput, so there could be 
value in new NiFi components that leverage the [Java Native 
API](https://iotdb.apache.org/UserGuide/Master/API/Programming-Java-Native-API.html).
   > > With that background, the `PutIoTDB` processor includes a direct 
dependency on JSON input, which is problematic in terms of flexibility. It 
would be much better to evaluate an approach that leverages record-oriented 
processing using NiFi Record Reader services. It may also be useful to create a 
Controller Service that provides reusable IoTDB Sessions, which could support 
multiple processors.
   > > If you are willing to work through more of these details, discussing the 
options and general design on the associate Jira issue would be a great next 
step.
   > 
   > > Thanks for the contribution @CloudWise-Lukemiao!
   > > The implementation appears to use both the JDBC and Native Java library 
for interacting with IoTDB. JDBC access is already possible using existing 
components and leveraging the `DBCPConnnectionPool` or `HikariCPConnectionPool` 
services.
   > > The [IoTDB documentation for 
JDBC](https://iotdb.apache.org/UserGuide/Master/API/Programming-JDBC.html) 
notes that using JDBC is not recommended for high throughput, so there could be 
value in new NiFi components that leverage the [Java Native 
API](https://iotdb.apache.org/UserGuide/Master/API/Programming-Java-Native-API.html).
   > > With that background, the `PutIoTDB` processor includes a direct 
dependency on JSON input, which is problematic in terms of flexibility. It 
would be much better to evaluate an approach that leverages record-oriented 
processing using NiFi Record Reader services. It may also be useful to create a 
Controller Service that provides reusable IoTDB Sessions, which could support 
multiple processors.
   > > If you are willing to work through more of these details, discussing the 
options and general design on the associate Jira issue would be a great next 
step.
   > 
   > Thanks for pointing out the problem. Next, I will change the query 
interface mode of JDBC to the session mode of iotdb, and I will remove the JDBC 
insertion mode. I hope to discuss the options and general design on the 
associate JIRA issue would be a great next step.I use record render to re 
optimize
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10219) jna-platform missing from ./lib/properties

2022-07-11 Thread Joey Frazee (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565250#comment-17565250
 ] 

Joey Frazee commented on NIFI-10219:


[~exceptionfactory] I have a fix that works just adding jna-platform as an 
include directly in the assembly common.xml. But I have no clue whether that’s 
the right solution and it seems like the intent was to have the dependencies 
come in through nifi-property-protection-factory. I messed about with adding 
the jna-platform dependency to nifi-property-protection-azure but it never 
ended up in ./lib/properties.

> jna-platform missing from ./lib/properties
> --
>
> Key: NIFI-10219
> URL: https://issues.apache.org/jira/browse/NIFI-10219
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Joey Frazee
>Assignee: David Handermann
>Priority: Major
>
> NIFI-9883 introduced classloader isolation for sensitive property providers 
> and updated the assembly config to output dependencies in ./lib/properties. 
> jna-platform, required by azure-identity, isn't getting pulled through so 
> when using an Azure sensitive properties provider startup fails with a 
> NoClassDefFoundError.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10196) JoltTransformJSON fails to validate and save specs in 1.16.2

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10196:

Affects Version/s: 1.16.0
   Status: Patch Available  (was: Open)

> JoltTransformJSON fails to validate and save specs in 1.16.2
> 
>
> Key: NIFI-10196
> URL: https://issues.apache.org/jira/browse/NIFI-10196
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.2, 1.16.0
>Reporter: Andre Araujo
>Assignee: David Handermann
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In NiFi 1.16.2 something seems to have been broken in the JoltTransformJSON 
> processor.
> When I go to the ADVANCED page in the processor properties and enter a valid 
> spec and input, the processor fails to validate them correctly, showing 
> "Error occurred during validation". If I try to save it, I get "Error 
> occurred during save properties".
> I tried the same spec and input in a 1.15.3 and the same worked correctly.
> Spec:
> {code}
> [
>   {
> "operation": "shift",
> "spec": {
>   "*": "shifted_&"
> }
>   }
> ]
> {code}
> Input:
> {code}
> {
>   "a": 123
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-10196) JoltTransformJSON fails to validate and save specs in 1.16.2

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-10196:
---

Assignee: David Handermann

> JoltTransformJSON fails to validate and save specs in 1.16.2
> 
>
> Key: NIFI-10196
> URL: https://issues.apache.org/jira/browse/NIFI-10196
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Andre Araujo
>Assignee: David Handermann
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In NiFi 1.16.2 something seems to have been broken in the JoltTransformJSON 
> processor.
> When I go to the ADVANCED page in the processor properties and enter a valid 
> spec and input, the processor fails to validate them correctly, showing 
> "Error occurred during validation". If I try to save it, I get "Error 
> occurred during save properties".
> I tried the same spec and input in a 1.15.3 and the same worked correctly.
> Spec:
> {code}
> [
>   {
> "operation": "shift",
> "spec": {
>   "*": "shifted_&"
> }
>   }
> ]
> {code}
> Input:
> {code}
> {
>   "a": 123
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6198: NIFI-10196 Correct Jolt UI CSRF Header Handling

2022-07-11 Thread GitBox


exceptionfactory opened a new pull request, #6198:
URL: https://github.com/apache/nifi/pull/6198

   # Summary
   
   [NIFI-10196](https://issues.apache.org/jira/browse/NIFI-10196) Corrects 
Cross Site Request Forgery header handling in the advanced user interface for 
the `JoltTransformJSON` Processor.
   
   Previous adjustments for CSRF handling in 
[NIFI-9339](https://issues.apache.org/jira/browse/NIFI-9339) set the 
`Request-Token` header during initialization, but the approach does not handle 
subsequent requests when the CSRF cookie value changes.
   
   The corrected approach uses [AngularJS XSRF 
Protection](https://docs.angularjs.org/api/ng/service/$http#cross-site-request-forgery-xsrf-protection)
 request interception based configuring the `xsrfCookieName` and 
`xsrfHeaderName` properties of the HTTP service. The standard AngularJS XSRF 
interceptor reads the cookie value and sets the request header for each request 
to leverage the current value.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (NIFI-9758) PutEmail processor dying when SMTP server does not respond

2022-07-11 Thread Emilio Setiadarma (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emilio Setiadarma reassigned NIFI-9758:
---

Assignee: Emilio Setiadarma

> PutEmail processor dying when SMTP server does not respond
> --
>
> Key: NIFI-9758
> URL: https://issues.apache.org/jira/browse/NIFI-9758
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.14.0
> Environment: Windows Server 2016
> JDK 11
>Reporter: Javier Fonseca
>Assignee: Emilio Setiadarma
>Priority: Major
>  Labels: easyfix, features
>
> *Bug*
> PutEmail processor dyes after _"the socked connection is established, if the 
> server response is lost for some reason (or if the server doesn't respond at 
> all) the processor thread gets stuck forever._ 
> _Apparently this is kind of by design, since the default value of the 
> mail.smtp.timeout property is infinite, as it can be see 
> [here|https://javaee.github.io/javamail/docs/api/com/sun/mail/smtp/package-summary.html]._
> _I had a look at the PutEmail processor source code and unfortunately I don't 
> think there is a way currently to set this in the processor configuration."_
> Processor must be terminated/restart in these cases.
>  
> *Potential Solution*
> Add a configurable property TimeOut to set the __ value of the 
> _mail.smtp.timeout_ property, allowing the processor to fail after certain 
> amount of time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] CloudWise-Lukemiao commented on pull request #6190: NIFI-10210 Processor supporting Apache iotdb database

2022-07-11 Thread GitBox


CloudWise-Lukemiao commented on PR #6190:
URL: https://github.com/apache/nifi/pull/6190#issuecomment-1181217095

   > Thanks for the contribution @CloudWise-Lukemiao!
   > 
   > The implementation appears to use both the JDBC and Native Java library 
for interacting with IoTDB. JDBC access is already possible using existing 
components and leveraging the `DBCPConnnectionPool` or `HikariCPConnectionPool` 
services.
   > 
   > The [IoTDB documentation for 
JDBC](https://iotdb.apache.org/UserGuide/Master/API/Programming-JDBC.html) 
notes that using JDBC is not recommended for high throughput, so there could be 
value in new NiFi components that leverage the [Java Native 
API](https://iotdb.apache.org/UserGuide/Master/API/Programming-Java-Native-API.html).
   > 
   > With that background, the `PutIoTDB` processor includes a direct 
dependency on JSON input, which is problematic in terms of flexibility. It 
would be much better to evaluate an approach that leverages record-oriented 
processing using NiFi Record Reader services. It may also be useful to create a 
Controller Service that provides reusable IoTDB Sessions, which could support 
multiple processors.
   > 
   > If you are willing to work through more of these details, discussing the 
options and general design on the associate Jira issue would be a great next 
step.
   
   
   
   > Thanks for the contribution @CloudWise-Lukemiao!
   > 
   > The implementation appears to use both the JDBC and Native Java library 
for interacting with IoTDB. JDBC access is already possible using existing 
components and leveraging the `DBCPConnnectionPool` or `HikariCPConnectionPool` 
services.
   > 
   > The [IoTDB documentation for 
JDBC](https://iotdb.apache.org/UserGuide/Master/API/Programming-JDBC.html) 
notes that using JDBC is not recommended for high throughput, so there could be 
value in new NiFi components that leverage the [Java Native 
API](https://iotdb.apache.org/UserGuide/Master/API/Programming-Java-Native-API.html).
   > 
   > With that background, the `PutIoTDB` processor includes a direct 
dependency on JSON input, which is problematic in terms of flexibility. It 
would be much better to evaluate an approach that leverages record-oriented 
processing using NiFi Record Reader services. It may also be useful to create a 
Controller Service that provides reusable IoTDB Sessions, which could support 
multiple processors.
   > 
   > If you are willing to work through more of these details, discussing the 
options and general design on the associate Jira issue would be a great next 
step.
   
   Thanks for pointing out the problem. Next, I will change the query interface 
mode of JDBC to the session mode of iotdb, and I will remove the JDBC insertion 
mode. I hope to discuss the options and general design on the associate JIRA 
issue would be a great next step


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (NIFI-10219) jna-platform missing from ./lib/properties

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-10219:
---

Assignee: David Handermann

> jna-platform missing from ./lib/properties
> --
>
> Key: NIFI-10219
> URL: https://issues.apache.org/jira/browse/NIFI-10219
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Joey Frazee
>Assignee: David Handermann
>Priority: Major
>
> NIFI-9883 introduced classloader isolation for sensitive property providers 
> and updated the assembly config to output dependencies in ./lib/properties. 
> jna-platform, required by azure-identity, isn't getting pulled through so 
> when using an Azure sensitive properties provider startup fails with a 
> NoClassDefFoundError.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10143) ListFTP/GetFTP has issues with danish special characters (UTF-8)

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10143:

Fix Version/s: 1.17.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> ListFTP/GetFTP has issues with danish special characters (UTF-8)
> 
>
> Key: NIFI-10143
> URL: https://issues.apache.org/jira/browse/NIFI-10143
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: NIFI Version 1.16.2, Java 8
>Reporter: Jens M Kofoed
>Assignee: Paul Grey
>Priority: Major
> Fix For: 1.17.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> ListFTP and GetFTP has issues listing file/directories including danish 
> charaters (æøå).
> The ftp server is MS IIS FTP, and UTF-8 has been set to true.
> with a small test flow, I used a GenerateFlowfile and added 2 Properties. 
> filename="test.txt" and path="æøå". The output is going to a PutFTP, with 
> Remote path set to ${path}
> The PutFTP does indeed create a subfolder at the ftp server, named æøå. But...
> With a ListFTP or GetFTP process, looking into the same root folder gives an 
> error. 
> ListFTP[id=e4c43ea1-2d5d-1fea--89c101ce] Unable to get listing from 
> /���; skipping: java.io.IOException: Cannot list files for non-existent 
> directory /���
>  
> Testing the old case from NIFI-8250. I got issues with the arabic charaters 
> too.
> PutFTP[id=e4c43ef3-2d5d-1fea--ea9da690] Unable to transfer 
> FlowFile[filename=اختبار] to remote host 192.168.1.2 due to IOException 
> thrown from PutFTP[id=e4c43ef3-2d5d-1fea--ea9da690]: 
> java.io.IOException: Failed to store file .اختبار to /test/اختبار due to: 550 
> The filename, directory name, or volume label syntax is incorrect. 
> : java.io.IOException: Failed to store file .اختبار to /test/اختبار due to: 
> 550 The filename, directory name, or volume label syntax is incorrect. 
> ; routing to failure: {}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10143) ListFTP/GetFTP has issues with danish special characters (UTF-8)

2022-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565209#comment-17565209
 ] 

ASF subversion and git services commented on NIFI-10143:


Commit 274e4feeaa4f8173657fe0bfdb66291ef33073ed in nifi's branch 
refs/heads/main from Paul Grey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=274e4feeaa ]

NIFI-10143 Adjusted UTF-8 auto-detection in FTP Processors

This closes #6172

Signed-off-by: David Handermann 


> ListFTP/GetFTP has issues with danish special characters (UTF-8)
> 
>
> Key: NIFI-10143
> URL: https://issues.apache.org/jira/browse/NIFI-10143
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: NIFI Version 1.16.2, Java 8
>Reporter: Jens M Kofoed
>Assignee: Paul Grey
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> ListFTP and GetFTP has issues listing file/directories including danish 
> charaters (æøå).
> The ftp server is MS IIS FTP, and UTF-8 has been set to true.
> with a small test flow, I used a GenerateFlowfile and added 2 Properties. 
> filename="test.txt" and path="æøå". The output is going to a PutFTP, with 
> Remote path set to ${path}
> The PutFTP does indeed create a subfolder at the ftp server, named æøå. But...
> With a ListFTP or GetFTP process, looking into the same root folder gives an 
> error. 
> ListFTP[id=e4c43ea1-2d5d-1fea--89c101ce] Unable to get listing from 
> /���; skipping: java.io.IOException: Cannot list files for non-existent 
> directory /���
>  
> Testing the old case from NIFI-8250. I got issues with the arabic charaters 
> too.
> PutFTP[id=e4c43ef3-2d5d-1fea--ea9da690] Unable to transfer 
> FlowFile[filename=اختبار] to remote host 192.168.1.2 due to IOException 
> thrown from PutFTP[id=e4c43ef3-2d5d-1fea--ea9da690]: 
> java.io.IOException: Failed to store file .اختبار to /test/اختبار due to: 550 
> The filename, directory name, or volume label syntax is incorrect. 
> : java.io.IOException: Failed to store file .اختبار to /test/اختبار due to: 
> 550 The filename, directory name, or volume label syntax is incorrect. 
> ; routing to failure: {}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6172: NIFI-10143 - ListFTP/GetFTP charset issues

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6172: NIFI-10143 - ListFTP/GetFTP charset 
issues
URL: https://github.com/apache/nifi/pull/6172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10217) Refactor Deprecated Usage of WebSecurityConfigurerAdapter in Registry

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10217:

Status: Patch Available  (was: Open)

> Refactor Deprecated Usage of WebSecurityConfigurerAdapter in Registry
> -
>
> Key: NIFI-10217
> URL: https://issues.apache.org/jira/browse/NIFI-10217
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: NiFi Registry, Security
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spring Security 5.7.0 deprecated {{WebSecurityConfigurerAdapter}} in favor of 
> configuring a {{SecurityFilterChain}}. The NiFi Registry Spring Security 
> Configuration should updated to avoid extending the deprecated class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10220) Upgrade Log4j 2 to 2.18.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10220:

Status: Patch Available  (was: Open)

> Upgrade Log4j 2 to 2.18.0
> -
>
> Key: NIFI-10220
> URL: https://issues.apache.org/jira/browse/NIFI-10220
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Several extension components have transitive dependencies on Log4j 2. These 
> references should be upgraded from 2.17.2 to 
> [2.18.0|https://logging.apache.org/log4j/2.x/changes-report.html#a2.18.0].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6197: NIFI-10220 Upgrade Log4j 2 from 2.17.2 to 2.18.0

2022-07-11 Thread GitBox


exceptionfactory opened a new pull request, #6197:
URL: https://github.com/apache/nifi/pull/6197

   # Summary
   
   [NIFI-10220](https://issues.apache.org/jira/browse/NIFI-10220) Upgrades 
Log4j2 dependencies for several extension components from 2.17.2 to 
[2.18.0](https://logging.apache.org/log4j/2.x/changes-report.html#a2.18.0).
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10220) Upgrade Log4j 2 to 2.18.0

2022-07-11 Thread David Handermann (Jira)
David Handermann created NIFI-10220:
---

 Summary: Upgrade Log4j 2 to 2.18.0
 Key: NIFI-10220
 URL: https://issues.apache.org/jira/browse/NIFI-10220
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions
Reporter: David Handermann
Assignee: David Handermann


Several extension components have transitive dependencies on Log4j 2. These 
references should be upgraded from 2.17.2 to 
[2.18.0|https://logging.apache.org/log4j/2.x/changes-report.html#a2.18.0].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10219) jna-platform missing from ./lib/properties

2022-07-11 Thread Joey Frazee (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joey Frazee updated NIFI-10219:
---
Description: NIFI-9883 introduced classloader isolation for sensitive 
property providers and updated the assembly config to output dependencies in 
./lib/properties. jna-platform, required by azure-identity, isn't getting 
pulled through so when using an Azure sensitive properties provider startup 
fails with a NoClassDefFoundError.  (was: NIFI-9883 introduced classloader 
isolation for sensitive property providers and updated the assembly config to 
output dependencies in ./lib/properties. jna-platform, required by 
azure-identity, isn't getting pulled through so when using an Azure sensitive 
properties provider startup fails with a NoCalssDefFoundError.)

> jna-platform missing from ./lib/properties
> --
>
> Key: NIFI-10219
> URL: https://issues.apache.org/jira/browse/NIFI-10219
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Joey Frazee
>Priority: Major
>
> NIFI-9883 introduced classloader isolation for sensitive property providers 
> and updated the assembly config to output dependencies in ./lib/properties. 
> jna-platform, required by azure-identity, isn't getting pulled through so 
> when using an Azure sensitive properties provider startup fails with a 
> NoClassDefFoundError.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10219) jna-platform missing from ./lib/properties

2022-07-11 Thread Joey Frazee (Jira)
Joey Frazee created NIFI-10219:
--

 Summary: jna-platform missing from ./lib/properties
 Key: NIFI-10219
 URL: https://issues.apache.org/jira/browse/NIFI-10219
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.16.3, 1.16.2, 1.16.1
Reporter: Joey Frazee


NIFI-9883 introduced classloader isolation for sensitive property providers and 
updated the assembly config to output dependencies in ./lib/properties. 
jna-platform, required by azure-identity, isn't getting pulled through so when 
using an Azure sensitive properties provider startup fails with a 
NoCalssDefFoundError.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] greyp9 commented on a diff in pull request #6193: NIFI-9451 add input character set property for PutEmail and additiona…

2022-07-11 Thread GitBox


greyp9 commented on code in PR #6193:
URL: https://github.com/apache/nifi/pull/6193#discussion_r918369148


##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java:
##
@@ -233,6 +232,17 @@ public class PutEmail extends AbstractProcessor {
 .allowableValues("true", "false")
 .defaultValue("false")
 .build();
+public static final PropertyDescriptor INPUT_CHARACTER_SET = new 
PropertyDescriptor.Builder()
+.name("input-character-set")
+.displayName("Input Character Set")
+.description("Specifies the character set of the FlowFile contents 
"
++ "for reading input FlowFile contents to generate the 
message body "
++ "or as an attachment to the message. "
++ "If not set, UTF-8 will be the default value.")
+.required(true)
+.addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
+.defaultValue("UTF-8")

Review Comment:
   My vote is for using a constant here; one option is 
`StandardCharsets.UTF_8.name()`.



##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java:
##
@@ -362,17 +373,26 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
 }
 this.setMessageHeader("X-Mailer", 
context.getProperty(HEADER_XMAILER).evaluateAttributeExpressions(flowFile).getValue(),
 message);
 
message.setSubject(context.getProperty(SUBJECT).evaluateAttributeExpressions(flowFile).getValue());
+message.setSentDate(new Date());
 
 final String messageText = getMessage(flowFile, context, session);
-
 final String contentType = 
context.getProperty(CONTENT_TYPE).evaluateAttributeExpressions(flowFile).getValue();
-message.setContent(messageText, contentType);
-message.setSentDate(new Date());
+final Charset charset = getCharset(context);
+final String charsetName = MimeUtility.mimeCharset(charset.name());
+final DataHandler messageDataHandler = new DataHandler(

Review Comment:
   If I understand correctly, this would unconditionally encode the body text 
into base64? 



##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java:
##
@@ -299,4 +303,55 @@ public void testOutgoingMessageWithFlowfileContent() 
throws Exception {
 assertEquals("another...@apache.org", 
message.getRecipients(RecipientType.BCC)[1].toString());
 }
 
-}
+@Test
+public void testUnrecognizedCharset() {
+runner.setProperty(PutEmail.SMTP_HOSTNAME, "smtp-host");
+runner.setProperty(PutEmail.HEADER_XMAILER, "TestingNiFi");
+runner.setProperty(PutEmail.FROM, "t...@apache.org");
+runner.setProperty(PutEmail.MESSAGE, "test message");
+runner.setProperty(PutEmail.TO, "recipi...@apache.org");
+
+// not one of the recognized charsets
+runner.setProperty(PutEmail.INPUT_CHARACTER_SET, "NOT A CHARACTER 
SET");
+
+runner.assertNotValid();
+}
+
+@Test
+public void testPutEmailWithMismatchedCharset() throws Exception {
+// String specifically chosen to have characters encoded differently 
in US_ASCII and UTF_8
+final String rawString = "SoftwÄrë Ënginëër Ön NiFi";
+final byte[] rawBytes = rawString.getBytes(StandardCharsets.US_ASCII);
+final byte[] rawBytesUTF8 = rawString.getBytes(StandardCharsets.UTF_8);
+
+// verify that the message bytes are different (some messages are not)
+assertNotEquals(rawBytes, rawBytesUTF8);
+
+runner.setProperty(PutEmail.SMTP_HOSTNAME, "smtp-host");
+runner.setProperty(PutEmail.HEADER_XMAILER, "TestingNiFi");
+runner.setProperty(PutEmail.FROM, "t...@apache.org");
+runner.setProperty(PutEmail.MESSAGE, new String(rawBytes, 
StandardCharsets.US_ASCII));
+runner.setProperty(PutEmail.TO, "recipi...@apache.org");
+runner.setProperty(PutEmail.INPUT_CHARACTER_SET, 
StandardCharsets.UTF_8.name());
+
+runner.enqueue("Some Text".getBytes());
+
+runner.run();
+
+runner.assertQueueEmpty();
+runner.assertAllFlowFilesTransferred(PutEmail.REL_SUCCESS);
+
+// Verify that the Message was populated correctly
+assertEquals("Expected a single message to be sent", 1, 
processor.getMessages().size());
+Message message = processor.getMessages().get(0);
+assertNotEquals(rawString, message.getContent());

Review Comment:
   Is it reasonable to tighten up this check?  What exactly are we expecting 
the differences to be?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on 

[GitHub] [nifi] exceptionfactory opened a new pull request, #6196: NIFI-10217 Refactor Registry Spring Security Configuration

2022-07-11 Thread GitBox


exceptionfactory opened a new pull request, #6196:
URL: https://github.com/apache/nifi/pull/6196

   # Summary
   
   [NIFI-10217](https://issues.apache.org/jira/browse/NIFI-10217) Refactors the 
NiFi Registry Spring Security Configuration, removing extension of the 
deprecated `WebSecurityConfigurerAdapter` class.
   
   The updated configuration creates a `SecurityFilterChain` bean using the 
`HttpSecurity` builder and creates an `AuthenticationManager` using the 
existing Authentication Providers in the current configuration.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-9811) QuestDB does not work on ARM

2022-07-11 Thread Kevin Doran (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565171#comment-17565171
 ] 

Kevin Doran commented on NIFI-9811:
---

Update, it looks like QuestDB v6 re-introduced arm support:
https://github.com/questdb/questdb/issues/569#issuecomment-1114570465

QuestDB was recently updated to version 6.3 as part of Java 17 compatibility 
changes, so there may actually be nothing left to do for this ticket other than 
testing to see if it is resolved.

> QuestDB does not work on ARM
> 
>
> Key: NIFI-9811
> URL: https://issues.apache.org/jira/browse/NIFI-9811
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Kevin Doran
>Priority: Major
>
> Judging from this open issue, it does not appear they will be adding support:
> https://github.com/questdb/questdb/issues/569
> so for ARM, we will need to exclude this or find an alternative.
> Here is test failure output showing the runtime issues:
> {noformat}
> [INFO] Running 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest
> [ERROR] Tests run: 3, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.026 
> s <<< FAILURE! - in 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest
> [ERROR] 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest.testReadingEmptyRepository
>   Time elapsed: 0.025 s  <<< FAILURE!
> org.opentest4j.MultipleFailuresError:
> Multiple Failures (2 failures)
>   io.questdb.log.LogError: Error creating log writer
>   java.lang.NullPointerException: 
> [ERROR] 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest.testWritingThenReadingComponents
>   Time elapsed: 0.001 s  <<< FAILURE!
> org.opentest4j.MultipleFailuresError:
> Multiple Failures (2 failures)
>   java.lang.NoClassDefFoundError: Could not initialize class 
> io.questdb.cutlass.text.types.InputFormatConfiguration
>   java.lang.NullPointerException: 
> [ERROR] 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest.testReadingLimitedByPreferredDataPoints
>   Time elapsed: 0 s  <<< FAILURE!
> org.opentest4j.MultipleFailuresError:
> Multiple Failures (2 failures)
>   java.lang.NoClassDefFoundError: Could not initialize class 
> io.questdb.cutlass.text.types.InputFormatConfiguration
>   java.lang.NullPointerException: 
> [INFO] Running 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForNodeTest
> [ERROR] Tests run: 3, Failures: 2, Errors: 0, Skipped: 1, Time elapsed: 0 s 
> <<< FAILURE! - in 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForNodeTest
> [ERROR] 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForNodeTest.testReadingEmptyRepository
>   Time elapsed: 0 s  <<< FAILURE!
> org.opentest4j.MultipleFailuresError:
> Multiple Failures (2 failures)
>   java.lang.NoClassDefFoundError: Could not initialize class 
> io.questdb.cutlass.text.types.InputFormatConfiguration
>   java.lang.NullPointerException: 
> [ERROR] 
> org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepositoryForNodeTest.testWritingThenReadingComponents
>   Time elapsed: 0 s  <<< FAILURE!
> org.opentest4j.MultipleFailuresError:
> Multiple Failures (2 failures)
>   java.lang.NoClassDefFoundError: Could not initialize class 
> io.questdb.cutlass.text.types.InputFormatConfiguration
>   java.lang.NullPointerException: 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10218) ExtractDocumentText processor does not handle certain characters when extracting from a PDF

2022-07-11 Thread Andrew M. Lim (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew M. Lim updated NIFI-10218:
-
Attachment: PDF_flow.json

> ExtractDocumentText processor does not handle certain characters when 
> extracting from a PDF
> ---
>
> Key: NIFI-10218
> URL: https://issues.apache.org/jira/browse/NIFI-10218
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: 625006.pdf, 625006_results.png, PDF_flow.json, 
> example.pdf, example_results.png
>
>
> When a PDF has special characters ("+", "=",">", "+-"), when the text is 
> extracted from the document, these characters show up with different symbols. 
> I've attached two PDFs that illustrate the issue differently:
> * 625006.pdf has multiple pages. When the text is extracted from a table, 
> certain characters show up as a ? symbol.
> * example.pdf is a single page with the same table. When the text is 
> extracted the same characters show up as " or # symbols.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10218) ExtractDocumentText processor does not handle certain characters when extracting from a PDF

2022-07-11 Thread Andrew M. Lim (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew M. Lim updated NIFI-10218:
-
Attachment: 625006_results.png
example_results.png

> ExtractDocumentText processor does not handle certain characters when 
> extracting from a PDF
> ---
>
> Key: NIFI-10218
> URL: https://issues.apache.org/jira/browse/NIFI-10218
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: 625006.pdf, 625006_results.png, example.pdf, 
> example_results.png
>
>
> When a PDF has special characters ("+", "=",">", "+-"), when the text is 
> extracted from the document, these characters show up with different symbols. 
> I've attached two PDFs that illustrate the issue differently:
> * 625006.pdf has multiple pages. When the text is extracted from a table, 
> certain characters show up as a ? symbol.
> * example.pdf is a single page with the same table. When the text is 
> extracted the same characters show up as " or # symbols.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10218) ExtractDocumentText processor does not handle certain characters when extracting from a PDF

2022-07-11 Thread Andrew M. Lim (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew M. Lim updated NIFI-10218:
-
Attachment: example.pdf

> ExtractDocumentText processor does not handle certain characters when 
> extracting from a PDF
> ---
>
> Key: NIFI-10218
> URL: https://issues.apache.org/jira/browse/NIFI-10218
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: 625006.pdf, example.pdf
>
>
> When a PDF has special characters ("+", "=",">", "+-"), when the text is 
> extracted from the document, these characters show up with different symbols. 
> I've attached two PDFs that illustrate the issue differently:
> * 625006.pdf has multiple pages. When the text is extracted from a table, 
> certain characters show up as a ? symbol.
> * example.pdf is a single page with the same table. When the text is 
> extracted the same characters show up as " or # symbols.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10218) ExtractDocumentText processor does not handle certain characters when extracting from a PDF

2022-07-11 Thread Andrew M. Lim (Jira)
Andrew M. Lim created NIFI-10218:


 Summary: ExtractDocumentText processor does not handle certain 
characters when extracting from a PDF
 Key: NIFI-10218
 URL: https://issues.apache.org/jira/browse/NIFI-10218
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Reporter: Andrew M. Lim
 Attachments: 625006.pdf, example.pdf

When a PDF has special characters ("+", "=",">", "+-"), when the text is 
extracted from the document, these characters show up with different symbols. 

I've attached two PDFs that illustrate the issue differently:

* 625006.pdf has multiple pages. When the text is extracted from a table, 
certain characters show up as a ? symbol.
* example.pdf is a single page with the same table. When the text is extracted 
the same characters show up as " or # symbols.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10218) ExtractDocumentText processor does not handle certain characters when extracting from a PDF

2022-07-11 Thread Andrew M. Lim (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew M. Lim updated NIFI-10218:
-
Attachment: 625006.pdf

> ExtractDocumentText processor does not handle certain characters when 
> extracting from a PDF
> ---
>
> Key: NIFI-10218
> URL: https://issues.apache.org/jira/browse/NIFI-10218
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: 625006.pdf, example.pdf
>
>
> When a PDF has special characters ("+", "=",">", "+-"), when the text is 
> extracted from the document, these characters show up with different symbols. 
> I've attached two PDFs that illustrate the issue differently:
> * 625006.pdf has multiple pages. When the text is extracted from a table, 
> certain characters show up as a ? symbol.
> * example.pdf is a single page with the same table. When the text is 
> extracted the same characters show up as " or # symbols.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10217) Refactor Deprecated Usage of WebSecurityConfigurerAdapter in Registry

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10217:

Summary: Refactor Deprecated Usage of WebSecurityConfigurerAdapter in 
Registry  (was: Refactored Deprecated Usage of WebSecurityConfigurerAdapter in 
Registry)

> Refactor Deprecated Usage of WebSecurityConfigurerAdapter in Registry
> -
>
> Key: NIFI-10217
> URL: https://issues.apache.org/jira/browse/NIFI-10217
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: NiFi Registry, Security
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> Spring Security 5.7.0 deprecated {{WebSecurityConfigurerAdapter}} in favor of 
> configuring a {{SecurityFilterChain}}. The NiFi Registry Spring Security 
> Configuration should updated to avoid extending the deprecated class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10217) Refactored Deprecated Usage of WebSecurityConfigurerAdapter in Registry

2022-07-11 Thread David Handermann (Jira)
David Handermann created NIFI-10217:
---

 Summary: Refactored Deprecated Usage of 
WebSecurityConfigurerAdapter in Registry
 Key: NIFI-10217
 URL: https://issues.apache.org/jira/browse/NIFI-10217
 Project: Apache NiFi
  Issue Type: Improvement
  Components: NiFi Registry, Security
Reporter: David Handermann
Assignee: David Handermann


Spring Security 5.7.0 deprecated {{WebSecurityConfigurerAdapter}} in favor of 
configuring a {{SecurityFilterChain}}. The NiFi Registry Spring Security 
Configuration should updated to avoid extending the deprecated class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10216) Refactor Deprecated Usage of WebSecurityConfigurerAdapter

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10216:

Status: Patch Available  (was: Open)

> Refactor Deprecated Usage of WebSecurityConfigurerAdapter
> -
>
> Key: NIFI-10216
> URL: https://issues.apache.org/jira/browse/NIFI-10216
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Security
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spring Security 5.7.0 deprecated {{WebSecurityConfigurerAdapter}} in favor of 
> configuring a {{SecurityFilterChain}}. The NiFi Web API Security 
> Configuration should be refactored to avoid deprecation warnings and follow 
> the updated configuration strategy.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6195: NIFI-10216 Refactor NiFi Web API Security Configuration

2022-07-11 Thread GitBox


exceptionfactory opened a new pull request, #6195:
URL: https://github.com/apache/nifi/pull/6195

   # Summary
   
   [NIFI-10216](https://issues.apache.org/jira/browse/NIFI-10216) Refactors the 
Spring Security Configuration in `nifi-web-api` and `nifi-web-security` to 
remove references to the deprecated `WebSecurityConfigurerAdapter` class.
   
   The refactored implementation provides a streamlined `SecurityFilterChain` 
configuration in `NiFiWebApiSecurityConfiguration` and moves individual 
`Filter` creation to associated configuration classes.
   
   Additional updates include setting the default Spring Security logging level 
to `INFO` and updating the Standard CSRF Token Repository to leverage the 
streamlined version of `RequestUriBuilder`, which retrieves allowed context 
path configuration from available initialization parameters.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (NIFI-10207) ProcessorRunStatusEntity does not declare RUN_ONCE in ApiModelValue

2022-07-11 Thread Otto Fowler (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Otto Fowler resolved NIFI-10207.

Fix Version/s: 1.17.0
   Resolution: Fixed

> ProcessorRunStatusEntity does not declare RUN_ONCE in ApiModelValue
> ---
>
> Key: NIFI-10207
> URL: https://issues.apache.org/jira/browse/NIFI-10207
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.14.0
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.17.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> A new run status of RUN_ONCE was added to the system in NIFI-8188.
> The ApiModelValue was not set however, so OpenApi/Swagger generations do not 
> have support for RUN_ONCE as an allowable value, and get errors.
> see: https://github.com/Chaffelson/nipyapi/issues/309



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10207) ProcessorRunStatusEntity does not declare RUN_ONCE in ApiModelValue

2022-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565163#comment-17565163
 ] 

ASF subversion and git services commented on NIFI-10207:


Commit cf4eed0224dabea3d8e739ae31f69354cc4542c6 in nifi's branch 
refs/heads/main from Otto Fowler
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cf4eed0224 ]

NIFI-10207: ensure allowableValues matches SUPPORTED_STATE in 
ProcessorRunStatusEntity

This closes #6188.

Signed-off-by: Tamas Palfy 


> ProcessorRunStatusEntity does not declare RUN_ONCE in ApiModelValue
> ---
>
> Key: NIFI-10207
> URL: https://issues.apache.org/jira/browse/NIFI-10207
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.14.0
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> A new run status of RUN_ONCE was added to the system in NIFI-8188.
> The ApiModelValue was not set however, so OpenApi/Swagger generations do not 
> have support for RUN_ONCE as an allowable value, and get errors.
> see: https://github.com/Chaffelson/nipyapi/issues/309



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] tpalfy commented on pull request #6188: NIFI-10207: ensure allowableValues matches SUPPORTED_STATE in Process…

2022-07-11 Thread GitBox


tpalfy commented on PR #6188:
URL: https://github.com/apache/nifi/pull/6188#issuecomment-1180788149

   LGTM
   Thanks for your work @ottobackwards!
   
   Pushed to main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] asfgit closed pull request #6188: NIFI-10207: ensure allowableValues matches SUPPORTED_STATE in Process…

2022-07-11 Thread GitBox


asfgit closed pull request #6188: NIFI-10207: ensure allowableValues matches 
SUPPORTED_STATE in Process…
URL: https://github.com/apache/nifi/pull/6188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10216) Refactor Deprecated Usage of WebSecurityConfigurerAdapter

2022-07-11 Thread David Handermann (Jira)
David Handermann created NIFI-10216:
---

 Summary: Refactor Deprecated Usage of WebSecurityConfigurerAdapter
 Key: NIFI-10216
 URL: https://issues.apache.org/jira/browse/NIFI-10216
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI, Security
Reporter: David Handermann
Assignee: David Handermann


Spring Security 5.7.0 deprecated {{WebSecurityConfigurerAdapter}} in favor of 
configuring a {{SecurityFilterChain}}. The NiFi Web API Security Configuration 
should be refactored to avoid deprecation warnings and follow the updated 
configuration strategy.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] greyp9 commented on a diff in pull request #6172: NIFI-10143 - ListFTP/GetFTP charset issues

2022-07-11 Thread GitBox


greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r918267934


##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharsetIT.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.ftpserver.FtpServer;
+import org.apache.ftpserver.FtpServerFactory;
+import org.apache.ftpserver.ftplet.FileSystemFactory;
+import org.apache.ftpserver.ftplet.FileSystemView;
+import org.apache.ftpserver.ftplet.FtpException;
+import org.apache.ftpserver.ftplet.FtpFile;
+import org.apache.ftpserver.ftplet.UserManager;
+import org.apache.ftpserver.listener.ListenerFactory;
+import org.apache.ftpserver.usermanager.ClearTextPasswordEncryptor;
+import org.apache.ftpserver.usermanager.PropertiesUserManagerFactory;
+import org.apache.ftpserver.usermanager.impl.BaseUser;
+import org.apache.nifi.processor.Processor;
+import org.apache.nifi.processor.util.list.AbstractListProcessor;
+import org.apache.nifi.processors.standard.util.FTPTransfer;
+import org.apache.nifi.remote.io.socket.NetworkUtils;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+import org.junit.jupiter.api.io.TempDir;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Properties;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+
+/**
+ * Seed an ASCII charset folder in FTP server with files using i18n known 
filenames.  Iterate through a set of i18n folder
+ * names, copying the known content into each new target.  Afterwards, verify 
that the last folder contains all
+ * files with the expected filenames.
+ * 
+ * To test against a live FTP server, run test with system property set
+ * TestFTPCharset=hostname,port,user,password, like
+ * TestFTPCharset=localhost,21,ftpuser,ftppassword.
+ */
+@TestMethodOrder(MethodOrderer.MethodName.class)
+public class TestFTPCharsetIT {
+private static final String SERVER_OVERRIDE = 
System.getProperty(TestFTPCharsetIT.class.getSimpleName());
+private static final boolean EMBED_FTP_SERVER = (SERVER_OVERRIDE == null);
+private static FtpServer FTP_SERVER;
+
+private static final String USE_UTF8 = Boolean.TRUE.toString();
+private static final String HOSTNAME = "localhost";
+private static final String PORT = 
Integer.toString(NetworkUtils.getAvailableTcpPort());
+private static final String USER = "ftpuser";
+private static final String PASSWORD = "admin";
+
+@TempDir
+private static File FOLDER_FTP;
+@TempDir
+private static File FOLDER_USER_PROPERTIES;
+
+public static Arguments serverParametersProvider() {
+final String override = 
System.getProperty(TestFTPCharsetIT.class.getSimpleName());
+if (override == null) {
+return arguments(HOSTNAME, PORT, USER, PASSWORD);
+} else {
+return arguments((Object[]) override.split(","));
+}
+}
+
+public static Stream folderNamesProvider() {
+return Stream.of(
+arguments("folder1", "folder2"),
+arguments("folder2", "æøå"),
+arguments("æøå", "folder3"),
+

[GitHub] [nifi] greyp9 commented on a diff in pull request #6172: NIFI-10143 - ListFTP/GetFTP charset issues

2022-07-11 Thread GitBox


greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r918266864


##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ftp/StandardFTPClientProvider.java:
##
@@ -150,12 +151,11 @@ private void setClientProperties(final FTPClient client, 
final PropertyContext c
 client.setDataTimeout(dataTimeout);
 client.setDefaultTimeout(connectionTimeout);
 client.setRemoteVerificationEnabled(false);
+client.setAutodetectUTF8(true);
 
 final boolean unicodeEnabled = 
context.getProperty(UTF8_ENCODING).isSet() ? 
context.getProperty(UTF8_ENCODING).asBoolean() : false;
-if (unicodeEnabled) {
-client.setControlEncoding(StandardCharsets.UTF_8.name());
-client.setAutodetectUTF8(true);
-}
+final Charset charset = unicodeEnabled ? StandardCharsets.UTF_8 : 
Charset.defaultCharset();

Review Comment:
   Added a comment to clarify expectation about default behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10201) Upgrade Prometheus Simpleclient to 0.16.0

2022-07-11 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565126#comment-17565126
 ] 

David Handermann commented on NIFI-10201:
-

CVE-2020-15250 is related to JUnit 4 temporary folders and does not directly 
impact NiFi use of Prometheus Simpleclient.

> Upgrade Prometheus Simpleclient to 0.16.0
> -
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10204) ListS3 with AWSCredentialsProviderControllerService cause invalid or malformed Token

2022-07-11 Thread Juan C. Sequeiros (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565143#comment-17565143
 ] 

Juan C. Sequeiros commented on NIFI-10204:
--

@davide based on your screen shot you are using CFM 2.2.4.0-153
Have you tried opening a Cloudera support case? The issue could be internal to 
that CDH / CFM release.
If you do not know how to do that you could reach out to your account manger.

 

Also curious what happens if you set:
{code:java}
Assume Role STS Endpoint = sts.eu-south-1.amazonaws.com {code}
Assuming that Controller service you screenshot is not used by other processors.
If it is they I'd advise you create a new 
AWSCredentialsProviderControllerService for testing.

> ListS3 with AWSCredentialsProviderControllerService cause invalid or 
> malformed Token
> 
>
> Key: NIFI-10204
> URL: https://issues.apache.org/jira/browse/NIFI-10204
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.2
>Reporter: davide
>Priority: Major
> Attachments: Screenshot 2022-07-08 at 12.48.29.png, Screenshot 
> 2022-07-08 at 12.49.59.png
>
>
> I set ListS3 (see listS3 image) then provided an assume role with an external 
> id and role to access on another aws account in a 
> AWSCredentialsProviderControllerService. 
> Then i get this error:
> ListS3[id=995de262----f0131a31] Failed to list contents of 
> bucket due to The provided token is malformed or otherwise invalid. (Service: 
> Amazon S3; Status Code: 400; Error Code: InvalidToken; Request ID: 
> E4Wx5G6; S3 Extended Request ID: CvR37+xxx; Proxy: null): 
> com.amazonaws.services.s3.model.AmazonS3Exception: The provided token is 
> malformed or otherwise invalid. (Service: Amazon S3; Status Code: 400; Error 
> Code: InvalidToken; Request ID: xx; S3 Extended Request ID: 
> CvxxGtArq7ak=; Proxy: null), S3 Extended Request ID: CvR37+dbdxxk=
> From the nifi nodes with the aws cli listing on that bucket does it works.
> Does anyone knows how to debug? or to solve?
> I search across internet but i do not found anything like my problem.
> thank you 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6172: NIFI-10143 - ListFTP/GetFTP charset issues

2022-07-11 Thread GitBox


exceptionfactory commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r918238256


##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ftp/StandardFTPClientProvider.java:
##
@@ -150,12 +151,11 @@ private void setClientProperties(final FTPClient client, 
final PropertyContext c
 client.setDataTimeout(dataTimeout);
 client.setDefaultTimeout(connectionTimeout);
 client.setRemoteVerificationEnabled(false);
+client.setAutodetectUTF8(true);
 
 final boolean unicodeEnabled = 
context.getProperty(UTF8_ENCODING).isSet() ? 
context.getProperty(UTF8_ENCODING).asBoolean() : false;
-if (unicodeEnabled) {
-client.setControlEncoding(StandardCharsets.UTF_8.name());
-client.setAutodetectUTF8(true);
-}
+final Charset charset = unicodeEnabled ? StandardCharsets.UTF_8 : 
Charset.defaultCharset();

Review Comment:
   This ternary changes the default behavior. The `FTPClient` defaults to 
`ISO-8859-1` for the Control Encoding property, so the approach should be 
adjusted to follow the previous approach of setting control encoding only when 
`unicodeEnabled` is `true`.



##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharsetIT.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.ftpserver.FtpServer;
+import org.apache.ftpserver.FtpServerFactory;
+import org.apache.ftpserver.ftplet.FileSystemFactory;
+import org.apache.ftpserver.ftplet.FileSystemView;
+import org.apache.ftpserver.ftplet.FtpException;
+import org.apache.ftpserver.ftplet.FtpFile;
+import org.apache.ftpserver.ftplet.UserManager;
+import org.apache.ftpserver.listener.ListenerFactory;
+import org.apache.ftpserver.usermanager.ClearTextPasswordEncryptor;
+import org.apache.ftpserver.usermanager.PropertiesUserManagerFactory;
+import org.apache.ftpserver.usermanager.impl.BaseUser;
+import org.apache.nifi.processor.Processor;
+import org.apache.nifi.processor.util.list.AbstractListProcessor;
+import org.apache.nifi.processors.standard.util.FTPTransfer;
+import org.apache.nifi.remote.io.socket.NetworkUtils;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+import org.junit.jupiter.api.io.TempDir;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Properties;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+
+/**
+ * Seed an ASCII charset folder in FTP server with files using i18n known 
filenames.  Iterate through a set of i18n folder
+ * names, copying the known content into each new target.  Afterwards, verify 
that the last folder contains all
+ * files with the expected filenames.
+ * 
+ * To test against a live FTP server, run test with system property set
+ * TestFTPCharset=hostname,port,user,password, like
+ * TestFTPCharset=localhost,21,ftpuser,ftppassword.
+ */
+@TestMethodOrder(MethodOrderer.MethodName.class)
+public class TestFTPCharsetIT {
+private static final String SERVER_OVERRIDE = 
System.getProperty(TestFTPCharsetIT.class.getSimpleName());
+ 

[jira] [Commented] (NIFI-10147) Remove Support for Java 8

2022-07-11 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565137#comment-17565137
 ] 

David Handermann commented on NIFI-10147:
-

Thanks for the comment [~Chris S]. It seems like we should consider upgrading 
Docker builds to Java 11 earlier. That will provide some opportunity for 
additional exercise of Java 11 prior to removing support for Java 8.

> Remove Support for Java 8
> -
>
> Key: NIFI-10147
> URL: https://issues.apache.org/jira/browse/NIFI-10147
> Project: Apache NiFi
>  Issue Type: Epic
>  Components: Core Framework, MiNiFi, NiFi Registry, NiFi Stateless
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Although multiple vendors have planned extended support for Java 8, a number 
> of projects are in the process of deprecating and removing support for Java 
> 8. These projects include the following:
>  - [Jetty 9.4|https://github.com/eclipse/jetty.project/issues/7958]
>  - [Spring 
> 5|https://spring.io/blog/2021/09/02/a-java-17-and-jakarta-ee-9-baseline-for-spring-framework-6]
>  - [OpenSAML 3|https://shibboleth.atlassian.net/wiki/spaces/OSAML/overview]
> Apache NiFi should also remove support for Java 8 in order to maintain active 
> support for various components.
> Removing support for Java 8 requires a new major version release and will 
> also require several build configuration changes including the following:
>  - Updating Maven source and compiler settings
>  - Updating minimum Java build version
>  - Removing optional Maven build profiles
>  - Updating GitHub workflows
> Initial discussion on a migration strategy included a tentative target of the 
> end of calendar year 2022.
> Implementation should not proceed until after a minor release of Apache NiFi 
> 1.17.0.
> Mailing list discussion: 
> [https://lists.apache.org/thread/mm1xf3b9nvrcgytb92oy3swvvc45fl34]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10215) Upgrade Apache Curator to 5.3.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10215:

Status: Patch Available  (was: Open)

> Upgrade Apache Curator to 5.3.0
> ---
>
> Key: NIFI-10215
> URL: https://issues.apache.org/jira/browse/NIFI-10215
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apache Curator 
> [5.3.0|https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425=12351883]
>  incorporates several minor bug fixes and improvements over version 5.2.1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6194: NIFI-10215 Upgrade Curator from 5.2.1 to 5.3.0

2022-07-11 Thread GitBox


exceptionfactory opened a new pull request, #6194:
URL: https://github.com/apache/nifi/pull/6194

   # Summary
   
   [NIFI-10215](https://issues.apache.org/jira/browse/NIFI-10215) Upgrades 
Apache Curator from 5.2.1 to 
[5.3.0](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425=12351883)
 in framework and ZooKeeper migrator modules.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10215) Upgrade Apache Curator to 5.3.0

2022-07-11 Thread David Handermann (Jira)
David Handermann created NIFI-10215:
---

 Summary: Upgrade Apache Curator to 5.3.0
 Key: NIFI-10215
 URL: https://issues.apache.org/jira/browse/NIFI-10215
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, Tools and Build
Reporter: David Handermann
Assignee: David Handermann


Apache Curator 
[5.3.0|https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425=12351883]
 incorporates several minor bug fixes and improvements over version 5.2.1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-10201) Upgrade Prometheus Simpleclient to 0.16.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-10201.
-
Fix Version/s: 1.17.0
   Resolution: Fixed

> Upgrade Prometheus Simpleclient to 0.16.0
> -
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Minor
> Fix For: 1.17.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10201) Upgrade Prometheus Simpleclient to 0.16.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10201:

Summary: Upgrade Prometheus Simpleclient to 0.16.0  (was: Upgrade 
Simpleclient To 0.16.0)

> Upgrade Prometheus Simpleclient to 0.16.0
> -
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10201) Upgrade Simpleclient To 0.16.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10201:

Priority: Minor  (was: Major)

> Upgrade Simpleclient To 0.16.0
> --
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10201) Upgrade Simpleclient To 0.16.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10201:

Issue Type: Improvement  (was: Bug)

> Upgrade Simpleclient To 0.16.0
> --
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10201) Upgrade Simpleclient To 0.16.0

2022-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565124#comment-17565124
 ] 

ASF subversion and git services commented on NIFI-10201:


Commit 06db7968fa0436661fac89e74e621b5b2301212d in nifi's branch 
refs/heads/main from UcanInfosec
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=06db7968fa ]

NIFI-10201 Upgraded Prometheus simpleclient from 0.3.0 to 0.16.0

This closes #6180

Signed-off-by: David Handermann 


> Upgrade Simpleclient To 0.16.0
> --
>
> Key: NIFI-10201
> URL: https://issues.apache.org/jira/browse/NIFI-10201
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Simpleclient from 0.3.0 to 0.16.0  to remediate 
> [CVE-2020-15250|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6180: NIFI-10201: Update Simpleclient To 0.16.0

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6180: NIFI-10201: Update Simpleclient To 
0.16.0
URL: https://github.com/apache/nifi/pull/6180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] emiliosetiadarma opened a new pull request, #6193: NIFI-9451 add input character set property for PutEmail and additiona…

2022-07-11 Thread GitBox


emiliosetiadarma opened a new pull request, #6193:
URL: https://github.com/apache/nifi/pull/6193

   …l tests
   
   Also fixed an issue regarding sending non US-ASCII messages in PutEmail. The 
original version had non US-ASCII messages appear as "?" in the resulting email.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-9451](https://issues.apache.org/jira/browse/NIFI-9451)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [x] Build completed using `mvn clean install -P contrib-check`
 - [x] JDK 8
 - [x] JDK 11
 - [] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6192: NIFI-10212 added ListSmb processor and SmbConnectionPoolService

2022-07-11 Thread GitBox


exceptionfactory commented on code in PR #6192:
URL: https://github.com/apache/nifi/pull/6192#discussion_r918153432


##
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-connection-pool/pom.xml:
##
@@ -0,0 +1,72 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+
+org.apache.nifi
+nifi-smb-bundle
+1.17.0-SNAPSHOT
+
+
+nifi-smb-connection-pool
+jar
+
+
+
+org.apache.nifi
+nifi-smb-connection-pool-api
+1.17.0-SNAPSHOT
+provided
+
+
+org.apache.nifi
+nifi-api
+
+
+org.apache.nifi
+nifi-distributed-cache-client-service-api
+
+
+org.apache.nifi
+nifi-record
+
+
+org.apache.nifi
+nifi-record-serialization-service-api
+
+
+org.apache.nifi
+nifi-utils
+
+
+com.hierynomus
+smbj
+
+
+net.engio
+mbassador
+
+
+commons-io
+commons-io
+
+
+commons-lang
+commons-lang

Review Comment:
   Apache Commons-Lang3 should be used instead of the older Apache Commons-Lang.



##
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-connection-pool-api/src/main/java/org/apache/nifi/services/smb/SmbConnectionPoolService.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.services.smb;
+
+import com.hierynomus.smbj.SMBClient;
+import com.hierynomus.smbj.auth.AuthenticationContext;
+import org.apache.nifi.controller.ControllerService;
+
+public interface SmbConnectionPoolService extends ControllerService {
+
+/**
+ * Returns the name of the share to connect.
+ *
+ * @return the share
+ */
+String getShareName();
+
+/**
+ * Returns the hostname to connect to.
+ *
+ * @return the hostname
+ */
+String getHostname();
+
+/**
+ * Returns the port using to connect.
+ *
+ * @return the port.
+ */
+Integer getPort();
+
+/**
+ * Returns the SmbClient to use
+ *
+ * @return the smbClient
+ */
+SMBClient getSmbClient();
+
+/**
+ * Returns the authentication context.
+ *
+ * @return the authentication context.
+ */
+AuthenticationContext getAuthenticationContext();

Review Comment:
   Instead of returning these smbj objects, access could be encapsulated in 
several ways. One option is to encapsulate the authentication process and 
return a `Session`, which would allow reuse. A better option would be to 
encapsulate the service operation and provide a method that would enumerate a 
shared directory along the following lines of:
   
   ```
   List getRemoteFiles(String directory);
   ```



##
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-connection-pool-api/src/main/java/org/apache/nifi/services/smb/SmbConnectionPoolService.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.services.smb;
+
+import com.hierynomus.smbj.SMBClient;
+import com.hierynomus.smbj.auth.AuthenticationContext;

[jira] [Commented] (NIFI-10196) JoltTransformJSON fails to validate and save specs in 1.16.2

2022-07-11 Thread Matt Burgess (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565110#comment-17565110
 ] 

Matt Burgess commented on NIFI-10196:
-

I can't reproduce this issue on 1.16.2, I used the same spec and input on 
JoltTransformJSON's Advanced UI and it validated and saved successfully. Did 
anything else change about your environment besides the NiFi version, such as 
access to ports or HTTP paths or anything? Also if you know how to open 
Developer Tools in Chrome please provide any relevant information to the error, 
the request payload, etc.

> JoltTransformJSON fails to validate and save specs in 1.16.2
> 
>
> Key: NIFI-10196
> URL: https://issues.apache.org/jira/browse/NIFI-10196
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Andre Araujo
>Priority: Major
>
> In NiFi 1.16.2 something seems to have been broken in the JoltTransformJSON 
> processor.
> When I go to the ADVANCED page in the processor properties and enter a valid 
> spec and input, the processor fails to validate them correctly, showing 
> "Error occurred during validation". If I try to save it, I get "Error 
> occurred during save properties".
> I tried the same spec and input in a 1.15.3 and the same worked correctly.
> Spec:
> {code}
> [
>   {
> "operation": "shift",
> "spec": {
>   "*": "shifted_&"
> }
>   }
> ]
> {code}
> Input:
> {code}
> {
>   "a": 123
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] tpalfy commented on a diff in pull request #6188: NIFI-10207: ensure allowableValues matches SUPPORTED_STATE in Process…

2022-07-11 Thread GitBox


tpalfy commented on code in PR #6188:
URL: https://github.com/apache/nifi/pull/6188#discussion_r918139488


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/ProcessorRunStatusEntity.java:
##
@@ -26,6 +26,9 @@
 @XmlType(name = "processorRunStatus")
 public class ProcessorRunStatusEntity extends ComponentRunStatusEntity {
 
+// SUPPORTED_STATE *MUST* match the allowableValues below
+// if it doesn't, OpenAPI/Swagger generation will generate
+// correct clients, and they will have errors when deserializing

Review Comment:
   I think a simpler but completely specific reminder comment would be better.
   
   All we really want is to make sure when the constant changes, the annotation 
is updated as well. The rest is technical detail, one that could be written to 
almost all similar places.
   
   I'd do something like this:
   
   ```suggestion
   // Must match the @ApiModelProperty.allowableValues above getState()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] kulikg opened a new pull request, #6192: NIFI-10212 added ListSmb processor and SmbConnectionPoolService

2022-07-11 Thread GitBox


kulikg opened a new pull request, #6192:
URL: https://github.com/apache/nifi/pull/6192

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   Added ListSmb processor and SmbConnectionPoolService
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [x] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6189: NIFI-10208 Create Resource Fetcher over HTTPS with Basic Authentication

2022-07-11 Thread GitBox


exceptionfactory commented on code in PR #6189:
URL: https://github.com/apache/nifi/pull/6189#discussion_r918097232


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework-external-resource-utils/src/main/java/org/apache/nifi/flow/resource/ExternalResourceListAsHtmlParser.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.flow.resource;
+
+import org.w3c.dom.Document;
+import org.w3c.dom.Node;
+import org.w3c.dom.NodeList;
+import org.xml.sax.InputSource;
+import org.xml.sax.SAXException;
+
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.xpath.XPath;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathExpression;
+import javax.xml.xpath.XPathExpressionException;
+import javax.xml.xpath.XPathFactory;
+import java.io.IOException;
+import java.io.StringReader;
+import java.time.LocalDateTime;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.ArrayList;
+import java.util.Collection;
+
+public class ExternalResourceListAsHtmlParser {
+private static final String DEFAULT_X_PATH_IDENTIFIER_FOR_FILE_LIST = 
"//tr[count(td)>2]";
+private static final String DEFAULT_X_PATH_IDENTIFIER_FOR_LOCATION = 
"./td[1]/a/text()";
+private static final String DEFAULT_X_PATH_IDENTIFIER_FOR_LAST_MODIFIED = 
"./td[2]/text()";
+private static final DateTimeFormatter FORMATTER = 
DateTimeFormatter.ofPattern("yyy-MM-dd HH:mm");
+
+private final XPathExpression xPathIdentifierForFileList;
+private final XPathExpression xPathIdentifierForLocation;
+private final XPathExpression xPathIdentifierForLastModified;
+
+public ExternalResourceListAsHtmlParser() throws XPathExpressionException {
+final XPath xPath = XPathFactory.newInstance().newXPath();
+xPathIdentifierForFileList = 
xPath.compile(DEFAULT_X_PATH_IDENTIFIER_FOR_FILE_LIST);
+xPathIdentifierForLocation = 
xPath.compile(DEFAULT_X_PATH_IDENTIFIER_FOR_LOCATION);
+xPathIdentifierForLastModified = 
xPath.compile(DEFAULT_X_PATH_IDENTIFIER_FOR_LAST_MODIFIED);
+}
+
+public Collection parseResponse(final String 
response, final String url) throws ParserConfigurationException, 
XPathExpressionException, IOException, SAXException {
+final Collection result = new 
ArrayList<>();
+final NodeList nodeList = gatherResourceNodeList(response);
+for (int i = 0; i < nodeList.getLength(); i++) {
+final Node node = nodeList.item(i);
+if (isFile(node)) {
+final ExternalResourceDescriptor descriptor = 
createDescriptor(node, url, true);
+result.add(descriptor);
+} else {
+final ExternalResourceDescriptor descriptor = 
createDescriptor(node, url, false);
+result.add(descriptor);
+}
+}
+return result;
+}
+
+private NodeList gatherResourceNodeList(final String response) throws 
ParserConfigurationException, XPathExpressionException, IOException, 
SAXException {
+final Document doc = 
DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new 
InputSource(new StringReader(response)));

Review Comment:
   The default configuration of the `DocumentBuilderFactory` is vulnerable to 
XML External Entity processing. All XML handling should leverage components 
from `nifi-xml-processing`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (NIFI-10195) Update Testcontainers to 1.17.3

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-10195.
-
Fix Version/s: 1.17.0
   Resolution: Fixed

> Update Testcontainers to 1.17.3
> ---
>
> Key: NIFI-10195
> URL: https://issues.apache.org/jira/browse/NIFI-10195
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Major
> Fix For: 1.17.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Update the use of Testcontainers from 1.11.3 to version 1.17.3 to remediate 
> dependency vulnerabilities:
> [CVE-2021-36090|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-36090]
> [CVE-2021-35517|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35517]
> [CVE-2021-35516|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35516]
> [CVE-2021-35515|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35515]
> [CVE-2019-12402|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-12402]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6179: NIFI-10195: Update Testcontainers to 1.17.3

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6179: NIFI-10195: Update Testcontainers 
to 1.17.3
URL: https://github.com/apache/nifi/pull/6179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10195) Update Testcontainers to 1.17.3

2022-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565061#comment-17565061
 ] 

ASF subversion and git services commented on NIFI-10195:


Commit 291bd40013613d38ec5df7493669c0a8bcbbcaf9 in nifi's branch 
refs/heads/main from mr1716
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=291bd40013 ]

NIFI-10195 Upgraded Testcontainers to 1.17.3

This closes #6179

Signed-off-by: David Handermann 


> Update Testcontainers to 1.17.3
> ---
>
> Key: NIFI-10195
> URL: https://issues.apache.org/jira/browse/NIFI-10195
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Mike R
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Update the use of Testcontainers from 1.11.3 to version 1.17.3 to remediate 
> dependency vulnerabilities:
> [CVE-2021-36090|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-36090]
> [CVE-2021-35517|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35517]
> [CVE-2021-35516|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35516]
> [CVE-2021-35515|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-35515]
> [CVE-2019-12402|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-12402]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-10214) Upgrade Commons Configuration to 2.8.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-10214.
-
Fix Version/s: 1.17.0
   Resolution: Fixed

> Upgrade Commons Configuration to 2.8.0
> --
>
> Key: NIFI-10214
> URL: https://issues.apache.org/jira/browse/NIFI-10214
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions, Security, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
> Fix For: 1.17.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Apache Commons Configuration should be upgraded to 2.8.0 to address 
> CVE-2022-33980 related to variable interpolation processing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10214) Upgrade Commons Configuration to 2.8.0

2022-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565055#comment-17565055
 ] 

ASF subversion and git services commented on NIFI-10214:


Commit 3a31dff76b93b05f7f8ac97fbf655ffeff0911a6 in nifi's branch 
refs/heads/main from dependabot[bot]
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3a31dff76b ]

NIFI-10214 Upgraded commons-configuration2 from 2.7 to 2.8.0

This closes #6181
This closes #6182
This closes #6183

Signed-off-by: David Handermann 


> Upgrade Commons Configuration to 2.8.0
> --
>
> Key: NIFI-10214
> URL: https://issues.apache.org/jira/browse/NIFI-10214
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions, Security, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Apache Commons Configuration should be upgraded to 2.8.0 to address 
> CVE-2022-33980 related to variable interpolation processing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] dependabot[bot] commented on pull request #6183: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-nar-bundles/nifi-accumulo-bundle

2022-07-11 Thread GitBox


dependabot[bot] commented on PR #6183:
URL: https://github.com/apache/nifi/pull/6183#issuecomment-1180553448

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] dependabot[bot] commented on pull request #6182: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-l

2022-07-11 Thread GitBox


dependabot[bot] commented on PR #6182:
URL: https://github.com/apache/nifi/pull/6182#issuecomment-1180553443

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory closed pull request #6183: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-nar-bundles/nifi-accumulo-bundle

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6183: NIFI-10214 Bump 
commons-configuration2 from 2.7 to 2.8.0 in 
/nifi-nar-bundles/nifi-accumulo-bundle
URL: https://github.com/apache/nifi/pull/6183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory closed pull request #6181: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-toolkit/nifi-toolkit-encrypt-config

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6181: NIFI-10214 Bump 
commons-configuration2 from 2.7 to 2.8.0 in 
/nifi-toolkit/nifi-toolkit-encrypt-config
URL: https://github.com/apache/nifi/pull/6181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] dependabot[bot] commented on pull request #6181: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-toolkit/nifi-toolkit-encrypt-config

2022-07-11 Thread GitBox


dependabot[bot] commented on PR #6181:
URL: https://github.com/apache/nifi/pull/6181#issuecomment-1180553444

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory closed pull request #6182: NIFI-10214 Bump commons-configuration2 from 2.7 to 2.8.0 in /nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup

2022-07-11 Thread GitBox


exceptionfactory closed pull request #6182: NIFI-10214 Bump 
commons-configuration2 from 2.7 to 2.8.0 in 
/nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services
URL: https://github.com/apache/nifi/pull/6182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10213) Shopify processor

2022-07-11 Thread Jira


 [ 
https://issues.apache.org/jira/browse/NIFI-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lehel Boér updated NIFI-10213:
--
Description: (was: Similarly to what has been done for Salesforce, we 
should provide an option to incrementally extract data out of a Shopify account.

Source of inspiration:
[https://fivetran.com/docs/applications/shopify]

Useful links:
 - [Intro to Shopify|https://help.shopify.com/en/manual/intro-to-shopify]
 - [Shopify admin|https://help.shopify.com/en/manual/shopify-admin]
 - [Custom apps|https://help.shopify.com/en/manual/apps/custom-apps]
 - [Access tokens|https://shopify.dev/apps/auth/admin-app-access-tokens]
 - [REST Admin API|https://shopify.dev/api/admin-rest]

Task details:
 - Implement a processor that can download Shopify entities (e.g Product, 
Customer, Order) from the customer's Shopify account.
 - Implement incremental loading ({{{}created_at_min{}}} parameter of the REST 
API may be used for it) but no custom queries needed in this round / in this 
processor (no GraphQL API).
 - The entity name should be chosen from a list property of the processor.
 - Shopify access / authentication: the customer has to create a [Custom 
app|https://help.shopify.com/en/manual/apps/custom-apps] and generate an 
[Access token|https://shopify.dev/apps/auth/admin-app-access-tokens] that can 
be used in NiFi.
 - Consider to implement/use a generic HTTP Client Service)

> Shopify processor
> -
>
> Key: NIFI-10213
> URL: https://issues.apache.org/jira/browse/NIFI-10213
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10214) Upgrade Commons Configuration to 2.8.0

2022-07-11 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10214:

Summary: Upgrade Commons Configuration to 2.8.0  (was: Upgraded Commons 
Configuration to 2.8.0)

> Upgrade Commons Configuration to 2.8.0
> --
>
> Key: NIFI-10214
> URL: https://issues.apache.org/jira/browse/NIFI-10214
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions, Security, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
>
> Apache Commons Configuration should be upgraded to 2.8.0 to address 
> CVE-2022-33980 related to variable interpolation processing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10214) Upgraded Commons Configuration to 2.8.0

2022-07-11 Thread David Handermann (Jira)
David Handermann created NIFI-10214:
---

 Summary: Upgraded Commons Configuration to 2.8.0
 Key: NIFI-10214
 URL: https://issues.apache.org/jira/browse/NIFI-10214
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions, Security, Tools and Build
Reporter: David Handermann
Assignee: David Handermann


Apache Commons Configuration should be upgraded to 2.8.0 to address 
CVE-2022-33980 related to variable interpolation processing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10079) Upgrade ZooKeeper to 3.8.0

2022-07-11 Thread Shawn Dorsch (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565040#comment-17565040
 ] 

Shawn Dorsch commented on NIFI-10079:
-

[~exceptionfactory] Thanks for getting back to me. We are using BCFKS keystores 
for FIPS compliance. I'd (y) for inclusion if there is a 1.16.4 release. 

> Upgrade ZooKeeper to 3.8.0
> --
>
> Key: NIFI-10079
> URL: https://issues.apache.org/jira/browse/NIFI-10079
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.16.1, 1.16.2
>Reporter: Mike R
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The version of Zookeeper .jars used has a Medium 5.8 CVE against it and there 
> is an update to Zookeeper to allow for a fix.  The CVE can be found at 
> [https://nvd.nist.gov/vuln/detail/CVE-2021-21295] and there is a more recent 
> version of Zookeeper to help mitigate this



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-site] exceptionfactory commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


exceptionfactory commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r918016591


##
layouts/_default/baseof.html:
##
@@ -0,0 +1,36 @@
+
+
+
+
+{{ .Title }}
+
+
+
+
+
+
+

Review Comment:
   The `app.js` has a couple minimal initialization functions. It looks like it 
should be carried over for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10213) Shopify processor

2022-07-11 Thread Jira
Lehel Boér created NIFI-10213:
-

 Summary: Shopify processor
 Key: NIFI-10213
 URL: https://issues.apache.org/jira/browse/NIFI-10213
 Project: Apache NiFi
  Issue Type: New Feature
Reporter: Lehel Boér
Assignee: Lehel Boér


Similarly to what has been done for Salesforce, we should provide an option to 
incrementally extract data out of a Shopify account.

Source of inspiration:
[https://fivetran.com/docs/applications/shopify]

Useful links:
 - [Intro to Shopify|https://help.shopify.com/en/manual/intro-to-shopify]
 - [Shopify admin|https://help.shopify.com/en/manual/shopify-admin]
 - [Custom apps|https://help.shopify.com/en/manual/apps/custom-apps]
 - [Access tokens|https://shopify.dev/apps/auth/admin-app-access-tokens]
 - [REST Admin API|https://shopify.dev/api/admin-rest]

Task details:
 - Implement a processor that can download Shopify entities (e.g Product, 
Customer, Order) from the customer's Shopify account.
 - Implement incremental loading ({{{}created_at_min{}}} parameter of the REST 
API may be used for it) but no custom queries needed in this round / in this 
processor (no GraphQL API).
 - The entity name should be chosen from a list property of the processor.
 - Shopify access / authentication: the customer has to create a [Custom 
app|https://help.shopify.com/en/manual/apps/custom-apps] and generate an 
[Access token|https://shopify.dev/apps/auth/admin-app-access-tokens] that can 
be used in NiFi.
 - Consider to implement/use a generic HTTP Client Service



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10212) ListSmb processor

2022-07-11 Thread Jira
Kulik Gábor created NIFI-10212:
--

 Summary: ListSmb processor
 Key: NIFI-10212
 URL: https://issues.apache.org/jira/browse/NIFI-10212
 Project: Apache NiFi
  Issue Type: New Feature
Reporter: Kulik Gábor
Assignee: Kulik Gábor


As a user I'd like to be able to list remote files shared via SMB protocol 
using a NiFi processor.

- create ListSmb processor
- add max age configurable property
- add SmbConnectionPoolService



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10204) ListS3 with AWSCredentialsProviderControllerService cause invalid or malformed Token

2022-07-11 Thread davide (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565035#comment-17565035
 ] 

davide commented on NIFI-10204:
---

Thank you [~turcsanyip].

I have nifi nodes on eu-central-1 and i am able to get files from eu-central-1 
bucket with assume role and external id on another bucket accountid, and work 
correctly.

I am sure that region is properly configured as I get files from an internal 
bucket on my accounte located on eu-south-1

So the question is Possible to get file from another aws accountid with an 
AssumeRole on cross regions in NIFI?

>From aws cli is possible because I tried from nifi nodes and it worked fine.

 

> ListS3 with AWSCredentialsProviderControllerService cause invalid or 
> malformed Token
> 
>
> Key: NIFI-10204
> URL: https://issues.apache.org/jira/browse/NIFI-10204
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.2
>Reporter: davide
>Priority: Major
> Attachments: Screenshot 2022-07-08 at 12.48.29.png, Screenshot 
> 2022-07-08 at 12.49.59.png
>
>
> I set ListS3 (see listS3 image) then provided an assume role with an external 
> id and role to access on another aws account in a 
> AWSCredentialsProviderControllerService. 
> Then i get this error:
> ListS3[id=995de262----f0131a31] Failed to list contents of 
> bucket due to The provided token is malformed or otherwise invalid. (Service: 
> Amazon S3; Status Code: 400; Error Code: InvalidToken; Request ID: 
> E4Wx5G6; S3 Extended Request ID: CvR37+xxx; Proxy: null): 
> com.amazonaws.services.s3.model.AmazonS3Exception: The provided token is 
> malformed or otherwise invalid. (Service: Amazon S3; Status Code: 400; Error 
> Code: InvalidToken; Request ID: xx; S3 Extended Request ID: 
> CvxxGtArq7ak=; Proxy: null), S3 Extended Request ID: CvR37+dbdxxk=
> From the nifi nodes with the aws cli listing on that bucket does it works.
> Does anyone knows how to debug? or to solve?
> I search across internet but i do not found anything like my problem.
> thank you 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-site] exceptionfactory commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


exceptionfactory commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917985663


##
layouts/_default/baseof.html:
##
@@ -0,0 +1,36 @@
+
+
+
+
+{{ .Title }}
+
+
+
+
+
+
+

Review Comment:
   Using Cloudflare CDN sounds good. The current Foundation version used in the 
site appears to be 5.5.3, and that also appears to be the latest version 5 
available on Cloudflare CDN.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1328: MINIFICPP-1812 - Clean up Repository threads

2022-07-11 Thread GitBox


adam-markovics commented on code in PR #1328:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r917982943


##
controller/Controller.h:
##
@@ -246,15 +247,24 @@ 
std::shared_ptr
 
   
configuration->get(org::apache::nifi::minifi::Configure::nifi_provenance_repository_class_name,
 prov_repo_class);
   // Create repos for flow record and provenance
-  const std::shared_ptr prov_repo = 
org::apache::nifi::minifi::core::createRepository(prov_repo_class, true, 
"provenance");
+  const std::shared_ptr prov_repo_base = 
org::apache::nifi::minifi::core::createRepository(prov_repo_class, true, 
"provenance");
+  const auto prov_repo = 
std::static_pointer_cast(prov_repo_base);

Review Comment:
   Good point! Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1328: MINIFICPP-1812 - Clean up Repository threads

2022-07-11 Thread GitBox


adamdebreceni commented on code in PR #1328:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r917933827


##
controller/Controller.h:
##
@@ -246,15 +247,24 @@ 
std::shared_ptr
 
   
configuration->get(org::apache::nifi::minifi::Configure::nifi_provenance_repository_class_name,
 prov_repo_class);
   // Create repos for flow record and provenance
-  const std::shared_ptr prov_repo = 
org::apache::nifi::minifi::core::createRepository(prov_repo_class, true, 
"provenance");
+  const std::shared_ptr prov_repo_base = 
org::apache::nifi::minifi::core::createRepository(prov_repo_class, true, 
"provenance");
+  const auto prov_repo = 
std::static_pointer_cast(prov_repo_base);

Review Comment:
   `createRepository` doesn't seem to guarantee that what it returns is a 
`ThreadedRepository`, a `dynamic_pointer_cast` could be more appropriate in 
these places?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MINIFICPP-1881) Add SSL support to ListenSyslog and ListenTCP processors

2022-07-11 Thread Jira
Gábor Gyimesi created MINIFICPP-1881:


 Summary: Add SSL support to ListenSyslog and ListenTCP processors
 Key: MINIFICPP-1881
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1881
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Gábor Gyimesi


Add SSLContextService property to ListenTCP and ListenSyslog processors to 
retrieve SSL information and extend them to support SSL connection. Asio 
provides SSL context for this purpose.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MINIFICPP-1881) Add SSL support to ListenSyslog and ListenTCP processors

2022-07-11 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi reassigned MINIFICPP-1881:


Assignee: Gábor Gyimesi

> Add SSL support to ListenSyslog and ListenTCP processors
> 
>
> Key: MINIFICPP-1881
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1881
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
>
> Add SSLContextService property to ListenTCP and ListenSyslog processors to 
> retrieve SSL information and extend them to support SSL connection. Asio 
> provides SSL context for this purpose.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory commented on pull request #6184: Bump jetty-server from 9.4.48.v20220622 to 10.0.10

2022-07-11 Thread GitBox


exceptionfactory commented on PR #6184:
URL: https://github.com/apache/nifi/pull/6184#issuecomment-1180387632

   Thanks for the feedback @joakime! NiFi currently supports Java 8, but 
[NIFI-10147](https://issues.apache.org/jira/browse/NIFI-10147) outlines plans 
to remove support for Java 8 in order to upgrade multiple dependencies, 
including Jetty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-6848) Migrate NiFi Site to ASF git build/deploy

2022-07-11 Thread Steven Matison (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564979#comment-17564979
 ] 

Steven Matison commented on NIFI-6848:
--

 
There is a PR for all of the bare minimum changes to roll current site in Hugo 
Framework.
{quote}https://github.com/apache/nifi-site/pull/61{quote}
If you want to roll an example of the new hugo site, follow README on my repo
{quote}https://github.com/steven-matison/nifi-site
 
 {quote}
 

> Migrate NiFi Site to ASF git build/deploy
> -
>
> Key: NIFI-6848
> URL: https://issues.apache.org/jira/browse/NIFI-6848
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Documentation  Website
>Reporter: Aldrin Piri
>Assignee: Andrew M. Lim
>Priority: Major
>
> Currently, NiFi's site is versioned in 
> https://gitbox.apache.org/repos/asf?p=nifi-site.git but a scripted process 
> via grunt, manually executed, is used to publish this site to the legacy CMS 
> (svn) system.  The CMS system is largely deprecated and targeted for EOL in 
> the upcoming months.  We should look to transition our repository/site over 
> to the new approach outlined at https://s.apache.org/asfyaml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-site] steven-matison commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


steven-matison commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917867428


##
layouts/_default/baseof.html:
##
@@ -0,0 +1,36 @@
+
+
+
+
+{{ .Title }}
+
+
+
+
+
+
+

Review Comment:
   Js Versions:
   
   `/assets/js/modernizr.js` Modernizr v2.8.3
   `/assets/js/webfontloader.js` Web Font Loader v1.5.21
   `/assets/js/jquery.min.js` jQuery v2.1.4
   `/assets/js/foundation.js` Foundation Responsive Library * 
http://foundation.zurb.com. (no version)
   `/assets/js/app.js`  this may not be needed in new site ???
   
   
   @exceptionfactory  is there a cdn host preferred? Here are the above 
which I found from cdnjs.com:
   
   https://cdnjs.cloudflare.com/ajax/libs/modernizr/2.8.3/modernizr.min.js
   https://cdnjs.cloudflare.com/ajax/libs/webfont/1.5.21/webfontloader.js
   https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js
   https://cdnjs.cloudflare.com/ajax/libs/foundation/6.7.4/js/foundation.min.js 
(this is the current version, not sure of the version on the site now)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-site] steven-matison commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


steven-matison commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917856478


##
source/security.html:
##
@@ -53,59 +53,6 @@ Reporting Methods
 
 
 
-
-
-
-Fixed in Apache NiFi 1.16.0
-
-
-
-
-
-Vulnerabilities
-
-
-
-
-CVE-2022-26850: Apache NiFi 
insufficiently protected credentials
-Severity: Low
-Versions Affected:
-
-Apache NiFi 1.14.0 - 1.15.3
-
-
-Description: When creating or updating credentials for single-user 
access, NiFi wrote a copy of the Login Identity Providers configuration to the 
operating system temporary directory. The Login Identity Providers 
configuration file contains the username and a bcrypt hash of the configured 
password. On most platforms, the operating system temporary directory has 
global read permissions. NiFi immediately moved the temporary file to the final 
configuration directory, which significantly limited the window of opportunity 
for access.
-Bcrypt is a password-hashing algorithm that incorporates a 
random salt and a specified cost factor, designed to maintain resistance to 
brute-force attacks. Use of the bcrypt algorithm minimizes the impact of 
disclosing the single-user credentials stored in Login Identity Providers.
-Mitigation: NiFi 1.16.0 includes updates to replace the Login 
Identity Providers configuration without writing a file to the operating system 
temporary directory.
-Credit: This issue was discovered by Jonathan Leitschuh 
(https://twitter.com/jlleitschuh). Report available here: https://github.com/JLLeitschuh/security-research/security/advisories/GHSA-rvp4-r3g6-8hxq;
 target="_blank">JLLeitschuh Github
-CVE Link: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-26850; 
target="_blank">Mitre Database: CVE-2022-26850
-NiFi Jira: https://issues.apache.org/jira/browse/NIFI-9785; 
target="_blank">NIFI-9785
-NiFi PR: https://github.com/apache/nifi/pull/5856; 
target="_blank">PR 5856
-Released: March 27, 2022
-
-
-
-
-
-Dependency Vulnerabilities
-
-
-
-
-CVE-2021-42392: Apache NiFi's use 
of H2 database
-Severity: Important
-Versions Affected:
-
-Apache NiFi 0.0.1 - 1.15.3
-
-
-Description: Apache NiFi uses H2 database for storing various NiFi 
runtime details. H2 database had a critical vulnerability similar to Log4Shell 
which potentially allows JNDI remote codebase loading. In NiFi, by default, 
console access to the database is restricted to local machine access only and 
remote access is disabled which limited the severity of this vulnerability. 
More detailed information on the H2 vulnerability can be found in https://thesecmaster.com/how-to-fix-cve-2021-42392-a-critical-unauthenticated-rce-in-h2-database-console/;>this
 blog post.
-Mitigation: We have upgraded the H2 version that NiFi uses from 
1.4.199 to 2.1.210. The vulnerability is also mitigated with more recent 
versions of Java (6u211 , 7u201, 8u191, 11.0.1 onwards). 
-CVE Link: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-42392; 
target="_blank">Mitre Database: CVE-2021-42392
-NiFi Jira: https://issues.apache.org/jira/browse/NIFI-9585; 
target="_blank">NIFI-9585
-Released: March 27, 2022
-
-

Review Comment:
   I think this is just content missing from the latests updates since this 
project started.
   I have reset this page with content from `src/pages/html/security.hbs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-site] steven-matison commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


steven-matison commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917851287


##
source/minifi/download.html:
##
@@ -24,7 +25,7 @@ 
 Releases
 MiNiFi (Java)
 
-  1.16.0
+  1.15.3

Review Comment:
   Adjusted in next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-site] steven-matison commented on a diff in pull request #61: Hugo Site Upgrade

2022-07-11 Thread GitBox


steven-matison commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917850566


##
.gitignore:
##
@@ -1,26 +0,0 @@
-target

Review Comment:
   Adjusted in next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] joakime commented on pull request #6184: Bump jetty-server from 9.4.48.v20220622 to 10.0.10

2022-07-11 Thread GitBox


joakime commented on PR #6184:
URL: https://github.com/apache/nifi/pull/6184#issuecomment-1180304799

   See prior comments about version range, and jetty managed advisory (the 
master database at github has not been updated yet):
   
   * 
https://github.com/eclipse/jetty.project/issues/8161#issuecomment-1178788271
   * 
https://github.com/eclipse/jetty.project/security/advisories/GHSA-8mpp-f3f7-xc28
   
   Also, Jetty 9.4.x is now at End of Community Support, you are strongly 
encouraged to upgrade to Jetty 10+ as soon as possible.
   
   See:
   
   * https://github.com/eclipse/jetty.project/issues/7958


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10204) ListS3 with AWSCredentialsProviderControllerService cause invalid or malformed Token

2022-07-11 Thread Peter Turcsanyi (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564955#comment-17564955
 ] 

Peter Turcsanyi commented on NIFI-10204:


[~vadidde] I see {{eu-south-1}} region is disabled by default (see 'Regions and 
endpoints' section 
[here|https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html]),
 so questions:
 * are you sure the region is properly enabled in your account?
 * could you please try the cross-account account access with another bucket 
which is located in a region that is enabled by default (e.g. {{eu-central-1}})?

I tested it in {{us-west-2}} and there was no issue there. I cannot enable 
{{eu-south-1}} for now so I cannot test it in that region.

> ListS3 with AWSCredentialsProviderControllerService cause invalid or 
> malformed Token
> 
>
> Key: NIFI-10204
> URL: https://issues.apache.org/jira/browse/NIFI-10204
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.2
>Reporter: davide
>Priority: Major
> Attachments: Screenshot 2022-07-08 at 12.48.29.png, Screenshot 
> 2022-07-08 at 12.49.59.png
>
>
> I set ListS3 (see listS3 image) then provided an assume role with an external 
> id and role to access on another aws account in a 
> AWSCredentialsProviderControllerService. 
> Then i get this error:
> ListS3[id=995de262----f0131a31] Failed to list contents of 
> bucket due to The provided token is malformed or otherwise invalid. (Service: 
> Amazon S3; Status Code: 400; Error Code: InvalidToken; Request ID: 
> E4Wx5G6; S3 Extended Request ID: CvR37+xxx; Proxy: null): 
> com.amazonaws.services.s3.model.AmazonS3Exception: The provided token is 
> malformed or otherwise invalid. (Service: Amazon S3; Status Code: 400; Error 
> Code: InvalidToken; Request ID: xx; S3 Extended Request ID: 
> CvxxGtArq7ak=; Proxy: null), S3 Extended Request ID: CvR37+dbdxxk=
> From the nifi nodes with the aws cli listing on that bucket does it works.
> Does anyone knows how to debug? or to solve?
> I search across internet but i do not found anything like my problem.
> thank you 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] ferencerdei opened a new pull request, #6191: NIFI-10211 Add dependencies for running minifi on java11

2022-07-11 Thread GitBox


ferencerdei opened a new pull request, #6191:
URL: https://github.com/apache/nifi/pull/6191

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   Adding java11 support for MiNiFi the same way as we do in NiFi.
   
   [NIFI-10211](https://issues.apache.org/jira/browse/NIFI-10211)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (NIFI-10204) ListS3 with AWSCredentialsProviderControllerService cause invalid or malformed Token

2022-07-11 Thread davide (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564917#comment-17564917
 ] 

davide edited comment on NIFI-10204 at 7/11/22 10:33 AM:
-

Hi!
 * EU (Milan) eu-south-1
 * I checked if there are any spaces or white lines.
 * Furthermore i check other users which have access to that bucket and I have 
the same problem.

If you need other stuff let me know.

thank you so much


was (Author: vadidde):
Hi!
 * EU (Milan) eu-south-1
 * I checked if there are any spaces or white lines.
 * Furthermore i check other users which have access to that bucket and I have 
the same problem.

> ListS3 with AWSCredentialsProviderControllerService cause invalid or 
> malformed Token
> 
>
> Key: NIFI-10204
> URL: https://issues.apache.org/jira/browse/NIFI-10204
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.2
>Reporter: davide
>Priority: Major
> Attachments: Screenshot 2022-07-08 at 12.48.29.png, Screenshot 
> 2022-07-08 at 12.49.59.png
>
>
> I set ListS3 (see listS3 image) then provided an assume role with an external 
> id and role to access on another aws account in a 
> AWSCredentialsProviderControllerService. 
> Then i get this error:
> ListS3[id=995de262----f0131a31] Failed to list contents of 
> bucket due to The provided token is malformed or otherwise invalid. (Service: 
> Amazon S3; Status Code: 400; Error Code: InvalidToken; Request ID: 
> E4Wx5G6; S3 Extended Request ID: CvR37+xxx; Proxy: null): 
> com.amazonaws.services.s3.model.AmazonS3Exception: The provided token is 
> malformed or otherwise invalid. (Service: Amazon S3; Status Code: 400; Error 
> Code: InvalidToken; Request ID: xx; S3 Extended Request ID: 
> CvxxGtArq7ak=; Proxy: null), S3 Extended Request ID: CvR37+dbdxxk=
> From the nifi nodes with the aws cli listing on that bucket does it works.
> Does anyone knows how to debug? or to solve?
> I search across internet but i do not found anything like my problem.
> thank you 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10204) ListS3 with AWSCredentialsProviderControllerService cause invalid or malformed Token

2022-07-11 Thread davide (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564917#comment-17564917
 ] 

davide commented on NIFI-10204:
---

Hi!
 * EU (Milan) eu-south-1
 * I checked if there are any spaces or white lines.
 * Furthermore i check other users which have access to that bucket and I have 
the same problem.

> ListS3 with AWSCredentialsProviderControllerService cause invalid or 
> malformed Token
> 
>
> Key: NIFI-10204
> URL: https://issues.apache.org/jira/browse/NIFI-10204
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.2
>Reporter: davide
>Priority: Major
> Attachments: Screenshot 2022-07-08 at 12.48.29.png, Screenshot 
> 2022-07-08 at 12.49.59.png
>
>
> I set ListS3 (see listS3 image) then provided an assume role with an external 
> id and role to access on another aws account in a 
> AWSCredentialsProviderControllerService. 
> Then i get this error:
> ListS3[id=995de262----f0131a31] Failed to list contents of 
> bucket due to The provided token is malformed or otherwise invalid. (Service: 
> Amazon S3; Status Code: 400; Error Code: InvalidToken; Request ID: 
> E4Wx5G6; S3 Extended Request ID: CvR37+xxx; Proxy: null): 
> com.amazonaws.services.s3.model.AmazonS3Exception: The provided token is 
> malformed or otherwise invalid. (Service: Amazon S3; Status Code: 400; Error 
> Code: InvalidToken; Request ID: xx; S3 Extended Request ID: 
> CvxxGtArq7ak=; Proxy: null), S3 Extended Request ID: CvR37+dbdxxk=
> From the nifi nodes with the aws cli listing on that bucket does it works.
> Does anyone knows how to debug? or to solve?
> I search across internet but i do not found anything like my problem.
> thank you 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] CloudWise-Lukemiao opened a new pull request, #6190: NIFI-10210 Processor supporting Apache iotdb database

2022-07-11 Thread GitBox


CloudWise-Lukemiao opened a new pull request, #6190:
URL: https://github.com/apache/nifi/pull/6190

   Iotdb process supports SQL insertion, session insertion and SQL query


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10211) Add java11+ support for MiNiFi

2022-07-11 Thread Ferenc Erdei (Jira)
Ferenc Erdei created NIFI-10211:
---

 Summary: Add java11+ support for MiNiFi
 Key: NIFI-10211
 URL: https://issues.apache.org/jira/browse/NIFI-10211
 Project: Apache NiFi
  Issue Type: Task
  Components: MiNiFi
Reporter: Ferenc Erdei
Assignee: Ferenc Erdei


Java 9 deprecated the JAXB, and Java 11 deleted the JAXB completely, so we get 
the following error during startup:
{code:java}
2022-07-11 08:34:56,637 ERROR [MiNiFi logging handler] 
org.apache.nifi.minifi.StdErr Failed to start flow service: Unable to load flow 
due to: java.lang.RuntimeException: Unable to create JAXBContext: 
Implementation of JAXB-API has not been found on module path or classpath.
2022-07-11 08:34:56,638 ERROR [MiNiFi logging handler] 
org.apache.nifi.minifi.StdErr Shutting down... {code}
To fix it, we have to include the JAXB dependencies manually (similarly as we 
do for NiFi / NiFi registry).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1362: MINIFICPP-1830 Verify regex properties in processors in case it is set to empty

2022-07-11 Thread GitBox


lordgamez commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r917690026


##
extensions/civetweb/processors/ListenHTTP.cpp:
##
@@ -108,10 +108,12 @@ void ListenHTTP::onSchedule(core::ProcessContext 
*context, core::ProcessSessionF
 
   bool randomPort = listeningPort == "0";
 
-  std::string authDNPattern;
+  std::string authDNPattern = ".*";
 
   if (context->getProperty(AuthorizedDNPattern.getName(), authDNPattern) && 
!authDNPattern.empty()) {
 logger_->log_debug("ListenHTTP using %s: %s", 
AuthorizedDNPattern.getName(), authDNPattern);
+  } else {
+logger_->log_debug("Authorized DN Pattern not set or invalid, using 
default '%s' pattern", authDNPattern);

Review Comment:
   Good catch, fixed in 780e0ce9d630ec0fd4214b676a2d19da5d840755



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10210) Processor supporting Apache iotdb database

2022-07-11 Thread luke.miao (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

luke.miao updated NIFI-10210:
-
Attachment: image-2022-07-11-16-23-46-844.png

> Processor supporting Apache iotdb database
> --
>
> Key: NIFI-10210
> URL: https://issues.apache.org/jira/browse/NIFI-10210
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: luke.miao
>Priority: Major
> Attachments: image-2022-07-11-16-23-46-844.png
>
>
> I have developed three processors based on Apache iotdb database, one query 
> processor and two insertion processors. I want to submit PR to nifi GitHub



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10210) Processor supporting Apache iotdb database

2022-07-11 Thread luke.miao (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

luke.miao updated NIFI-10210:
-
Description: I have developed three processors based on Apache iotdb 
database, one query processor and two insertion processors. I want to submit PR 
to nifi GitHub. !image-2022-07-11-16-23-46-844.png!  (was: I have developed 
three processors based on Apache iotdb database, one query processor and two 
insertion processors. I want to submit PR to nifi GitHub)

> Processor supporting Apache iotdb database
> --
>
> Key: NIFI-10210
> URL: https://issues.apache.org/jira/browse/NIFI-10210
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: luke.miao
>Priority: Major
> Attachments: image-2022-07-11-16-23-46-844.png
>
>
> I have developed three processors based on Apache iotdb database, one query 
> processor and two insertion processors. I want to submit PR to nifi GitHub. 
> !image-2022-07-11-16-23-46-844.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10210) Processor supporting Apache iotdb database

2022-07-11 Thread luke.miao (Jira)
luke.miao created NIFI-10210:


 Summary: Processor supporting Apache iotdb database
 Key: NIFI-10210
 URL: https://issues.apache.org/jira/browse/NIFI-10210
 Project: Apache NiFi
  Issue Type: New Feature
Reporter: luke.miao


I have developed three processors based on Apache iotdb database, one query 
processor and two insertion processors. I want to submit PR to nifi GitHub



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1367: MINIFICPP-1822 - Add alert capability

2022-07-11 Thread GitBox


adamdebreceni opened a new pull request, #1367:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1367

   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10209) Create a simple tool to acquire data from Status History when a node is not started

2022-07-11 Thread Jira
Kalmár Róbert created NIFI-10209:


 Summary: Create a simple tool to acquire data from Status History 
when a node is not started
 Key: NIFI-10209
 URL: https://issues.apache.org/jira/browse/NIFI-10209
 Project: Apache NiFi
  Issue Type: New Feature
Reporter: Kalmár Róbert
Assignee: Kalmár Róbert


In case of QuestDB backend, the (node and component) status history is 
persisted. This data is currently not reachable without starting the given 
node, which in some cases (especially when there are performance related 
issues) is not possible.

It would be useful to provide a possibility to provide a tool to acquire this 
data. This could be a part of NiFi toolkit



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] timeabarna commented on pull request #6159: NIFI-8248 Modify PutAzureDataLakeStorage processor to use temp file i…

2022-07-11 Thread GitBox


timeabarna commented on PR #6159:
URL: https://github.com/apache/nifi/pull/6159#issuecomment-1180054707

   Hello @jfrazee and @exceptionfactory,
   
   When you have some time can you please check this PR?
   Thanks in advance for your help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >