[jira] [Updated] (NIFI-10855) Document Cross-Site Request Forgery Protection
[
https://issues.apache.org/jira/browse/NIFI-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-10855:
Status: Patch Available (was: Open)
> Document Cross-Site Request Forgery Protection
> --
>
> Key: NIFI-10855
> URL: https://issues.apache.org/jira/browse/NIFI-10855
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI, Documentation Website
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Apache NiFi 1.15.0 included significant changes to web application security,
> including the introduction of Cross-Site Request Forgery protection using
> Spring Security Filters.
> The CSRF configuration builds on the standard Spring Security Filter and
> provides a stateless implementation based on the [Double Submit Cookie
> Pattern|https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#double-submit-cookie].
> The implementation maintains support for REST API access without cookies
> using the HTTP {{Authorization}} header, but documenting the implementation
> would provide additional background for clients integrating with the REST API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6805: NIFI-10855 Add Documentation on CSRF Protection
exceptionfactory opened a new pull request, #6805: URL: https://github.com/apache/nifi/pull/6805 # Summary [NIFI-10855](https://issues.apache.org/jira/browse/NIFI-10855) Updates the Administrator's Guide with a new section describing Cross-Site Request Forgery Protection under the User Authentication section. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …
exceptionfactory commented on code in PR #6689:
URL: https://github.com/apache/nifi/pull/6689#discussion_r1056009178
##
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class GetUriEvaluator extends StringEvaluator {
+
+private final Evaluator[] uriArgs;
+
+public GetUriEvaluator(Evaluator[] uriArgs) {
+this.uriArgs = uriArgs;
+}
+
+@Override
+public QueryResult evaluate(EvaluationContext evaluationContext) {
+List args = Arrays.stream(uriArgs)
+.map(uriArg -> uriArg.evaluate(evaluationContext).getValue())
+.map(string -> StringUtils.isBlank(string) ? null : string)
Review Comment:
The `StringUtils.isBlank()` check would convert both empty strings such as
`""` as well as strings with spaces such as `" "` to `null`. Although these
seem to be unlikely arguments, it raises a larger question about passing empty
arguments. The check should probably be simplified to check for an empty string:
```suggestion
.map(string -> string == null || string.isEmpty() ? null :
string)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11005) Add Illegal and Redundant Import Modules to Checkstyle Configuration
[
https://issues.apache.org/jira/browse/NIFI-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11005:
Status: Patch Available (was: Open)
> Add Illegal and Redundant Import Modules to Checkstyle Configuration
>
>
> Key: NIFI-11005
> URL: https://issues.apache.org/jira/browse/NIFI-11005
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Checkstyle configuration supports a number of modules for validating
> code, including [several modules for
> imports|https://checkstyle.org/config_imports.html]. The {{IllegalImport}}
> and {{RedundantImport}} modules should be added to the standard Checkstyle
> configuration to avoid unnecessary lines, and also block imports from the
> private {{sun}} namespace.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration
exceptionfactory opened a new pull request, #6804: URL: https://github.com/apache/nifi/pull/6804 # Summary [NIFI-11005](https://issues.apache.org/jira/browse/NIFI-11005) Adds `IllegalImport` and `RedundantImport` modules to the Checkstyle configuration to flag usage of classes from the `sun` namespace and detect unnecessary imports. Changes include updated several classes to remove redundant imports and removing `WebUtilsGroovyTest` due to its dependence on internal `sun.security` classes. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11005) Add Illegal and Redundant Import Modules to Checkstyle Configuration
David Handermann created NIFI-11005:
---
Summary: Add Illegal and Redundant Import Modules to Checkstyle
Configuration
Key: NIFI-11005
URL: https://issues.apache.org/jira/browse/NIFI-11005
Project: Apache NiFi
Issue Type: Improvement
Components: Tools and Build
Reporter: David Handermann
Assignee: David Handermann
The Checkstyle configuration supports a number of modules for validating code,
including [several modules for
imports|https://checkstyle.org/config_imports.html]. The {{IllegalImport}} and
{{RedundantImport}} modules should be added to the standard Checkstyle
configuration to avoid unnecessary lines, and also block imports from the
private {{sun}} namespace.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-10585) Add GenerateRecord processor to populate records with random data
[ https://issues.apache.org/jira/browse/NIFI-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10585: Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add GenerateRecord processor to populate records with random data > - > > Key: NIFI-10585 > URL: https://issues.apache.org/jira/browse/NIFI-10585 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.20.0 > > Time Spent: 5h > Remaining Estimate: 0h > > Similar to NIFI-5084, this Jira proposes a GenerateRecord processor to > generate dummy data into outgoing FlowFiles. There was a PR and plenty of > discussion in NIFI-5084, so this Jira is separate to outline the different > approach and not make the original Jira "noisy". > This processor could use the Java port of Faker to generate dummy data. Two > "modes" could be supported: 1) User-defined properties could specify various > field types supported by Faker, such as Country Code, University, Future > Date, etc. and 2) more generic dummy data (still provided by Faker) to > populate a given Avro schema, in order to support nested and pre-existing > structures. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10585) Add GenerateRecord processor to populate records with random data
[ https://issues.apache.org/jira/browse/NIFI-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651459#comment-17651459 ] ASF subversion and git services commented on NIFI-10585: Commit f38f14b363a955261d640aa214ae152a361be7c5 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f38f14b363 ] NIFI-10585 Added GenerateRecord Processor This closes #6480 Signed-off-by: David Handermann > Add GenerateRecord processor to populate records with random data > - > > Key: NIFI-10585 > URL: https://issues.apache.org/jira/browse/NIFI-10585 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Time Spent: 5h > Remaining Estimate: 0h > > Similar to NIFI-5084, this Jira proposes a GenerateRecord processor to > generate dummy data into outgoing FlowFiles. There was a PR and plenty of > discussion in NIFI-5084, so this Jira is separate to outline the different > approach and not make the original Jira "noisy". > This processor could use the Java port of Faker to generate dummy data. Two > "modes" could be supported: 1) User-defined properties could specify various > field types supported by Faker, such as Country Code, University, Future > Date, etc. and 2) more generic dummy data (still provided by Faker) to > populate a given Avro schema, in order to support nested and pre-existing > structures. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6480: NIFI-10585: Add GenerateFakeRecord processor
exceptionfactory closed pull request #6480: NIFI-10585: Add GenerateFakeRecord processor URL: https://github.com/apache/nifi/pull/6480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10996) CSV output with header - but always, even for 0 record flowfiles
[
https://issues.apache.org/jira/browse/NIFI-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651444#comment-17651444
]
Matt Burgess commented on NIFI-10996:
-
I see the issue but am still looking into it for "raw records" which do not use
the schema to write the header.
> CSV output with header - but always, even for 0 record flowfiles
>
>
> Key: NIFI-10996
> URL: https://issues.apache.org/jira/browse/NIFI-10996
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Priority: Minor
> Labels: csv, writer
> Attachments: NiFi_CSV_header_true.png
>
>
> We use a “ConvertRecord” processor where we convert an AVRO to a CSV. For
> that *CSV* output we would like to have the {*}header enabled{*}, so we tried
> to set “{{{}Include Header Line – true{}}}” for the Controller Service of the
> CSVRecordSetWriter. The issue is, *if we have zero records, the header
> doesn’t show up* (but it was there of course in the AVRO file). We need to
> have it as the columns are important for us, even if we have 0 records.
> At the moment we solve it with an extra ExecuteScript processor just before
> the ConvertRecord, there we add always an extra record with the header lines
> as string. But it feels a bit hacky as the record.count attribute is 1 record
> too high (due to the fake header record).
> !NiFi_CSV_header_true.png!
> Comment from [~joewitt] from users mailinglist: _"Makes sense what you're
> looking for. Just not sure where this 'concern' would live whether it is in
> the processors themselves or the controller services for the writers."_
> It seems that I'm not alone with that requirement, at least one other person
> (Jens M. Kofoed) uses a similar workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-10996) CSV output with header - but always, even for 0 record flowfiles
[
https://issues.apache.org/jira/browse/NIFI-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-10996:
---
Assignee: Matt Burgess
> CSV output with header - but always, even for 0 record flowfiles
>
>
> Key: NIFI-10996
> URL: https://issues.apache.org/jira/browse/NIFI-10996
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Matt Burgess
>Priority: Minor
> Labels: csv, writer
> Attachments: NiFi_CSV_header_true.png
>
>
> We use a “ConvertRecord” processor where we convert an AVRO to a CSV. For
> that *CSV* output we would like to have the {*}header enabled{*}, so we tried
> to set “{{{}Include Header Line – true{}}}” for the Controller Service of the
> CSVRecordSetWriter. The issue is, *if we have zero records, the header
> doesn’t show up* (but it was there of course in the AVRO file). We need to
> have it as the columns are important for us, even if we have 0 records.
> At the moment we solve it with an extra ExecuteScript processor just before
> the ConvertRecord, there we add always an extra record with the header lines
> as string. But it feels a bit hacky as the record.count attribute is 1 record
> too high (due to the fake header record).
> !NiFi_CSV_header_true.png!
> Comment from [~joewitt] from users mailinglist: _"Makes sense what you're
> looking for. Just not sure where this 'concern' would live whether it is in
> the processors themselves or the controller services for the writers."_
> It seems that I'm not alone with that requirement, at least one other person
> (Jens M. Kofoed) uses a similar workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6791: NIFI-6501: Refactor CaptureChangeMySQL to not use an unbounded event queue
exceptionfactory commented on code in PR #6791:
URL: https://github.com/apache/nifi/pull/6791#discussion_r1055922009
##
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java:
##
@@ -433,7 +434,7 @@ public class CaptureChangeMySQL extends
AbstractSessionFactoryProcessor {
private BinlogLifecycleListener lifecycleListener;
private GtidSet gtidSet;
-private final LinkedBlockingQueue queue = new
LinkedBlockingQueue<>();
+private final BlockingQueue queue = new
LinkedBlockingQueue<>(100);
Review Comment:
A large number of events can build up depending on the initial starting
position in the binary log, or lots of activity. The value of `100` may still
be best to avoid memory consumption, but I would have to take a closer look at
the polling behavior to see whether there is value in a larger buffer to handle
this kind of scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes
exceptionfactory commented on code in PR #6803:
URL: https://github.com/apache/nifi/pull/6803#discussion_r1055920409
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitJson.java:
##
@@ -112,6 +112,43 @@ public void testSplit_arrayResult_multipleValues() throws
Exception {
originalOut.assertContentEquals(JSON_SNIPPET);
}
+@Test
+public void testSplit_change_jsonpath() throws Exception {
+final TestRunner testRunner = TestRunners.newTestRunner(new
SplitJson());
+testRunner.setProperty(SplitJson.ARRAY_JSON_PATH_EXPRESSION,
"$[0].range");
+
+testRunner.enqueue(JSON_SNIPPET);
+testRunner.run();
+
+int numSplitsExpected = 10;
+
+testRunner.assertTransferCount(SplitJson.REL_ORIGINAL, 1);
+
testRunner.getFlowFilesForRelationship(SplitJson.REL_ORIGINAL).get(0).assertAttributeEquals(FRAGMENT_COUNT.key(),
String.valueOf(numSplitsExpected));
+testRunner.assertTransferCount(SplitJson.REL_SPLIT, numSplitsExpected);
+final MockFlowFile originalOut =
testRunner.getFlowFilesForRelationship(SplitJson.REL_ORIGINAL).get(0);
+originalOut.assertContentEquals(JSON_SNIPPET);
+
+// Change JsonPath Expression, verify it is being applied correctly
+testRunner.clearTransferState();
+testRunner.setProperty(SplitJson.ARRAY_JSON_PATH_EXPRESSION,
"$[*].name");
+
+testRunner.enqueue(JSON_SNIPPET, new HashMap<>() {
+{
+put(CoreAttributes.FILENAME.key(), "test.json");
+}
+});
Review Comment:
This can be simplified using `Collections.singletonMap`
```suggestion
testRunner.enqueue(JSON_SNIPPET,
Collections.singletonMap(CoreAttributes.FILENAME.key(), "test.json"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #6791: NIFI-6501: Refactor CaptureChangeMySQL to not use an unbounded event queue
mattyb149 commented on code in PR #6791:
URL: https://github.com/apache/nifi/pull/6791#discussion_r1055910980
##
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java:
##
@@ -433,7 +434,7 @@ public class CaptureChangeMySQL extends
AbstractSessionFactoryProcessor {
private BinlogLifecycleListener lifecycleListener;
private GtidSet gtidSet;
-private final LinkedBlockingQueue queue = new
LinkedBlockingQueue<>();
+private final BlockingQueue queue = new
LinkedBlockingQueue<>(100);
Review Comment:
Since we're blocking waiting on the event to be added to the queue,
@markap14 suggested we wouldn't need a very large buffer at all. I'm thinking
maybe a larger buffer size would be for times when the processor is scheduled
for a longer period than it should be? I welcome your and Mark's comments here,
just went with his suggestion :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6480: NIFI-10585: Add GenerateFakeRecord processor
mattyb149 commented on PR #6480: URL: https://github.com/apache/nifi/pull/6480#issuecomment-1363411973 Ah looks like I missed the property name update and your other changes look good too. thanks much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors
ChrisSamo632 commented on PR #6687: URL: https://github.com/apache/nifi/pull/6687#issuecomment-1363395679 @exceptionfactory refactored to use `DescribedValue` enums for the new and other existing properties in these processors - led to me uncovering the fact that I'd mistakenly not added the new result formatting properties to the Paginated processors, which has now been corrected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors
ChrisSamo632 commented on code in PR #6687:
URL: https://github.com/apache/nifi/pull/6687#discussion_r1055894635
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java:
##
@@ -205,19 +206,29 @@ void testVerifyFailedApiKeyAuth() {
@Test
void testBasicSearch() throws Exception {
+assertBasicSearch(null);
+}
+
+@Test
+void testBasicSearchRequestParameters() throws Exception {
+assertBasicSearch(createParameters("preference", "_local"));
+}
+
+private void assertBasicSearch(final Map
requestParameters) throws JsonProcessingException {
final Map temp = new MapBuilder()
-.of("size", 10, "query", new MapBuilder().of("match_all", new
HashMap<>()).build(),
-"aggs", new MapBuilder()
-.of("term_counts", new MapBuilder()
-.of("terms", new MapBuilder()
-.of("field", "msg", "size", 5)
-.build())
-.build())
-.build())
+.of("size", 10, "query", new MapBuilder().of("match_all", new
HashMap<>()).build(),
Review Comment:
I don't think this is required, the use of `HashMap` here (and throughout
all uses of the `MapBuilder` class in the tests) has been to create an empty
Map (i.e. JSON Object) for the `match_all` part of the Elasticsearch Query DSL
request body
I have, however, changed the `MapBuilder` to use a `LinkedHashMap`
internally instead of a `HashMap`, which might be relevant for keeping things
in order (although that shouldn't matter for the submission to Elasticsearch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-11003) PutIceberg Failes to write to S3
[ https://issues.apache.org/jira/browse/NIFI-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651413#comment-17651413 ] Adam Turley commented on NIFI-11003: I didnt do a custom build, I downloaded the 1.19.1 puticeberg and it's prerequisites to nifi 1.19.1 with openjdk11/17 download location: https://mvnrepository.com/artifact/org.apache.nifi/nifi-iceberg-processors-nar/1.19.1 > PutIceberg Failes to write to S3 > > > Key: NIFI-11003 > URL: https://issues.apache.org/jira/browse/NIFI-11003 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.19.0, 1.19.1 > Environment: Java11/17 > containerized deployment on RHEL 7.9 >Reporter: Adam Turley >Priority: Major > Attachments: iceberg.png > > > PutIceberg fails with the follow error when writing to S3. No issues when > writing to HDFS Iceberg > "PutIceberg Failed to load table from catalog: java.lang.RuntimeException: > java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found > - Caused by: java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10998) SplitJson does not honor latest setting for JsonPath Expression
[ https://issues.apache.org/jira/browse/NIFI-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-10998: Status: Patch Available (was: In Progress) > SplitJson does not honor latest setting for JsonPath Expression > --- > > Key: NIFI-10998 > URL: https://issues.apache.org/jira/browse/NIFI-10998 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Due to a behavior change in NIFI-10851 (being investigated separately as a > possible regression), SplitJson will no longer recompile the latest setting > for the JsonPath Expression property. This is due to a check in > onPropertyModified() that oldValue not be null, but the new behavior is that > oldValue is being set to null, preventing the cache from being cleared and > the new expression compiled and cached. > As this appears to be a very minor performance improvement (to not bother > clearing the cache if it's the first time this property is set), I propose to > clear the JsonPath Expression cache whenever the property is changed > (regardless of its previous value). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 opened a new pull request, #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes
mattyb149 opened a new pull request, #6803: URL: https://github.com/apache/nifi/pull/6803 # Summary [NIFI-10998](https://issues.apache.org/jira/browse/NIFI-10998) This PR removes the check for `oldValue == null` before compiling and caching the new JsonPath value # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [x] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-11003) PutIceberg Failes to write to S3
[ https://issues.apache.org/jira/browse/NIFI-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651360#comment-17651360 ] Mark Bathori edited comment on NIFI-11003 at 12/22/22 6:14 PM: --- Hi [~agturley], What profile did you use during the build? The S3 related dependencies are provided with the *_include-hadoop-aws_* and *_include-hadoop-cloud-storage_* profiles. was (Author: mbathori): Hi [~agturley], What profile did you use during the build? The S3 related dependencies are provided with the *_include-hadoop-aws_* and the *_include-hadoop-cloud-storage_* profiles. > PutIceberg Failes to write to S3 > > > Key: NIFI-11003 > URL: https://issues.apache.org/jira/browse/NIFI-11003 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.19.0, 1.19.1 > Environment: Java11/17 > containerized deployment on RHEL 7.9 >Reporter: Adam Turley >Priority: Major > Attachments: iceberg.png > > > PutIceberg fails with the follow error when writing to S3. No issues when > writing to HDFS Iceberg > "PutIceberg Failed to load table from catalog: java.lang.RuntimeException: > java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found > - Caused by: java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11003) PutIceberg Failes to write to S3
[ https://issues.apache.org/jira/browse/NIFI-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651360#comment-17651360 ] Mark Bathori commented on NIFI-11003: - Hi [~agturley], What profile did you use during the build? The S3 related dependencies are provided with the *_include-hadoop-aws_* and the *_include-hadoop-cloud-storage_* profiles. > PutIceberg Failes to write to S3 > > > Key: NIFI-11003 > URL: https://issues.apache.org/jira/browse/NIFI-11003 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.19.0, 1.19.1 > Environment: Java11/17 > containerized deployment on RHEL 7.9 >Reporter: Adam Turley >Priority: Major > Attachments: iceberg.png > > > PutIceberg fails with the follow error when writing to S3. No issues when > writing to HDFS Iceberg > "PutIceberg Failed to load table from catalog: java.lang.RuntimeException: > java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found > - Caused by: java.lang.ClassNotFoundException: Class > org.apache.hadoop.fs.s3a.S3AFileSystem not found" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11004) Add Documentation for OIDC Groups Claim Property
[ https://issues.apache.org/jira/browse/NIFI-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11004: Status: Patch Available (was: Open) > Add Documentation for OIDC Groups Claim Property > > > Key: NIFI-11004 > URL: https://issues.apache.org/jira/browse/NIFI-11004 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > NiFi 1.19.0 included support for retrieving group membership from a > configurable ID token claim as part of the OIDC authentication process. The > Administrator's Guide should be updated to describe this property and the > associated default value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6802: NIFI-11004 Add documentation for OIDC groups claim property
exceptionfactory opened a new pull request, #6802: URL: https://github.com/apache/nifi/pull/6802 # Summary [NIFI-11004](https://issues.apache.org/jira/browse/NIFI-11004) Updates the Administrator's Guide with documentation for the OIDC groups claim property and also updates the standard `nifi.properties` configuration with the default value of `groups`, matching the current internal behavior. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11004) Add Documentation for OIDC Groups Claim Property
David Handermann created NIFI-11004: --- Summary: Add Documentation for OIDC Groups Claim Property Key: NIFI-11004 URL: https://issues.apache.org/jira/browse/NIFI-11004 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: David Handermann Assignee: David Handermann NiFi 1.19.0 included support for retrieving group membership from a configurable ID token claim as part of the OIDC authentication process. The Administrator's Guide should be updated to describe this property and the associated default value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651347#comment-17651347
]
Simon Bence commented on NIFI-10973:
I'm looking into and will get back to you as soon as possible on this
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
> {color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-4572) CaptureChangeMySQL does not return database and table info without DistributedMapCache
[ https://issues.apache.org/jira/browse/NIFI-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4572: --- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > CaptureChangeMySQL does not return database and table info without > DistributedMapCache > -- > > Key: NIFI-4572 > URL: https://issues.apache.org/jira/browse/NIFI-4572 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.20.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > CaptureChangeMySQL will leverage a DistributedMapCache, when enabled, to > store database, table, and column information for the configured MySQL > instance. This is due to the possibly large amount of information needed to > be stored for large tables and large numbers of tables. > However the database and table information (not columns) is available in the > TABLE_MAP event, associated with each MySQL transaction, and it applies to > the entire transaction. So this information can be used to populate the > database and table fields in the outgoing CDC events, even if the > DistributedMapCache is not enabled/configured. This is slightly related to > NIFI-3902, although the code locations/paths are likely different. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-6498) XMLTransform processor: XSLT doesn't give detail error message with line number
[ https://issues.apache.org/jira/browse/NIFI-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-6498: --- Priority: Minor (was: Major) > XMLTransform processor: XSLT doesn't give detail error message with line > number > --- > > Key: NIFI-6498 > URL: https://issues.apache.org/jira/browse/NIFI-6498 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.10.0, 1.9.2 >Reporter: Raymond >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 1.20.0 > > Attachments: > 0001-Add-support-for-Saxon-error-messages-and-functions.patch, > 0001-Add-support-for-Saxon-error-messages-and-functions.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > When something is wrong with the XSLT in the XMLTransform processor you get > an error, but this is only a general error without any details or the line > number where the parsing error occurs. For example when using Saxon from > example I get the following error: > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element > type "xsl:tomplate" must be terminated by the matching end-tag > "". > When using NiFi the following error is printed: > 11:07:43 CEST > ERROR > 2b4c1dab-3a87-175f-f817-3f3c72af4102 > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102] Unable to transform > StandardFlowFileRecord[uuid=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,claim=StandardContentClaim > [resourceClaim=StandardResourceClaim[id=1564391260760-1, container=default, > section=1], offset=0, > length=6380],offset=0,name=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,size=6380] > due to IOException thrown from > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: java.io.IOException: > java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported: org.apache.nifi.processor.exception.ProcessException: IOException > thrown from TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: > java.io.IOException: java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported > The error in NiFi gives almost no information for debugging. Would be a big > improvement if the Saxon error message is catched and add to the NiFi error > message (bulletin board). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-6498) XMLTransform processor: XSLT doesn't give detail error message with line number
[ https://issues.apache.org/jira/browse/NIFI-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-6498: --- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > XMLTransform processor: XSLT doesn't give detail error message with line > number > --- > > Key: NIFI-6498 > URL: https://issues.apache.org/jira/browse/NIFI-6498 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.10.0, 1.9.2 >Reporter: Raymond >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 1.20.0 > > Attachments: > 0001-Add-support-for-Saxon-error-messages-and-functions.patch, > 0001-Add-support-for-Saxon-error-messages-and-functions.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > When something is wrong with the XSLT in the XMLTransform processor you get > an error, but this is only a general error without any details or the line > number where the parsing error occurs. For example when using Saxon from > example I get the following error: > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element > type "xsl:tomplate" must be terminated by the matching end-tag > "". > When using NiFi the following error is printed: > 11:07:43 CEST > ERROR > 2b4c1dab-3a87-175f-f817-3f3c72af4102 > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102] Unable to transform > StandardFlowFileRecord[uuid=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,claim=StandardContentClaim > [resourceClaim=StandardResourceClaim[id=1564391260760-1, container=default, > section=1], offset=0, > length=6380],offset=0,name=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,size=6380] > due to IOException thrown from > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: java.io.IOException: > java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported: org.apache.nifi.processor.exception.ProcessException: IOException > thrown from TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: > java.io.IOException: java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported > The error in NiFi gives almost no information for debugging. Would be a big > improvement if the Saxon error message is catched and add to the NiFi error > message (bulletin board). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-6498) XMLTransform processor: XSLT doesn't give detail error message with line number
[ https://issues.apache.org/jira/browse/NIFI-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651344#comment-17651344 ] ASF subversion and git services commented on NIFI-6498: --- Commit dde821cf713ef7d77c627586b2a1d5bcde3ac5e3 in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=dde821cf71 ] NIFI-6498 Update TransformXml to send errors to Component Log This closes #6798 Signed-off-by: David Handermann > XMLTransform processor: XSLT doesn't give detail error message with line > number > --- > > Key: NIFI-6498 > URL: https://issues.apache.org/jira/browse/NIFI-6498 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.10.0, 1.9.2 >Reporter: Raymond >Assignee: Daniel Stieglitz >Priority: Major > Attachments: > 0001-Add-support-for-Saxon-error-messages-and-functions.patch, > 0001-Add-support-for-Saxon-error-messages-and-functions.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > When something is wrong with the XSLT in the XMLTransform processor you get > an error, but this is only a general error without any details or the line > number where the parsing error occurs. For example when using Saxon from > example I get the following error: > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element > type "xsl:tomplate" must be terminated by the matching end-tag > "". > When using NiFi the following error is printed: > 11:07:43 CEST > ERROR > 2b4c1dab-3a87-175f-f817-3f3c72af4102 > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102] Unable to transform > StandardFlowFileRecord[uuid=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,claim=StandardContentClaim > [resourceClaim=StandardResourceClaim[id=1564391260760-1, container=default, > section=1], offset=0, > length=6380],offset=0,name=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,size=6380] > due to IOException thrown from > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: java.io.IOException: > java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported: org.apache.nifi.processor.exception.ProcessException: IOException > thrown from TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: > java.io.IOException: java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported > The error in NiFi gives almost no information for debugging. Would be a big > improvement if the Saxon error message is catched and add to the NiFi error > message (bulletin board). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6798: [NIFI-6498] Set error event listener on both the TransformerFactory a…
exceptionfactory closed pull request #6798: [NIFI-6498] Set error event listener on both the TransformerFactory a… URL: https://github.com/apache/nifi/pull/6798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363125181 @exceptionfactory Wondering if this could be revisited. It is functionality my team could use. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11003) PutIceberg Failes to write to S3
Adam Turley created NIFI-11003: -- Summary: PutIceberg Failes to write to S3 Key: NIFI-11003 URL: https://issues.apache.org/jira/browse/NIFI-11003 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.19.1, 1.19.0 Environment: Java11/17 containerized deployment on RHEL 7.9 Reporter: Adam Turley Attachments: iceberg.png PutIceberg fails with the follow error when writing to S3. No issues when writing to HDFS Iceberg "PutIceberg Failed to load table from catalog: java.lang.RuntimeException: java.lang.ClassNotFoundException: Class org.apache.hadoop.fs.s3a.S3AFileSystem not found - Caused by: java.lang.ClassNotFoundException: Class org.apache.hadoop.fs.s3a.S3AFileSystem not found" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines
fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1055622646
##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
class LoggerImpl : public Logger {
public:
-explicit LoggerImpl(std::string name, const std::shared_ptr
, const std::shared_ptr )
+explicit LoggerImpl(std::string name, std::optional id, const
std::shared_ptr , const
std::shared_ptr )
Review Comment:
I have changed everything to `Identifier` in
9ad1b17b7f52b497d608e1201e0b525b301595d1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-11002) Fix typo in user-guide docs
[ https://issues.apache.org/jira/browse/NIFI-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651231#comment-17651231 ] ASF subversion and git services commented on NIFI-11002: Commit ba29c3b04e194952544c330d4bd958f9fba08bb1 in nifi's branch refs/heads/main from 0xflotus [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ba29c3b04e ] NIFI-11002 - docs: fix small error Signed-off-by: Pierre Villard This closes #6795. > Fix typo in user-guide docs > --- > > Key: NIFI-11002 > URL: https://issues.apache.org/jira/browse/NIFI-11002 > Project: Apache NiFi > Issue Type: Task > Components: Documentation Website >Reporter: Pierre Villard >Priority: Major > > Fix typo in users guide documentation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11002) Fix typo in user-guide docs
[ https://issues.apache.org/jira/browse/NIFI-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-11002. --- Fix Version/s: 1.20.0 Resolution: Fixed > Fix typo in user-guide docs > --- > > Key: NIFI-11002 > URL: https://issues.apache.org/jira/browse/NIFI-11002 > Project: Apache NiFi > Issue Type: Task > Components: Documentation Website >Reporter: Pierre Villard >Priority: Major > Fix For: 1.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Fix typo in users guide documentation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6795: NIFI-11002 - docs: fix small error
asfgit closed pull request #6795: NIFI-11002 - docs: fix small error URL: https://github.com/apache/nifi/pull/6795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11002) Fix typo in user-guide docs
Pierre Villard created NIFI-11002: - Summary: Fix typo in user-guide docs Key: NIFI-11002 URL: https://issues.apache.org/jira/browse/NIFI-11002 Project: Apache NiFi Issue Type: Task Components: Documentation Website Reporter: Pierre Villard Fix typo in users guide documentation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10995) Update Jetty Version To 9.4.50.v20221201
[ https://issues.apache.org/jira/browse/NIFI-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651228#comment-17651228 ] ASF subversion and git services commented on NIFI-10995: Commit 2b0f7ac5c40cdd90b57deedcdeef32099e3b8af2 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2b0f7ac5c4 ] NIFI-10995 Update Jetty to 9.4.50.v20221201 Signed-off-by: Pierre Villard This closes #6799. > Update Jetty Version To 9.4.50.v20221201 > - > > Key: NIFI-10995 > URL: https://issues.apache.org/jira/browse/NIFI-10995 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.19.0, 1.19.1 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Upgrade Jetty [Release 9.4.50.v20221201 · eclipse/jetty.project > (github.com)|https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.50.v20221201] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10995) Update Jetty Version To 9.4.50.v20221201
[ https://issues.apache.org/jira/browse/NIFI-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-10995. --- Fix Version/s: 1.20.0 Resolution: Fixed > Update Jetty Version To 9.4.50.v20221201 > - > > Key: NIFI-10995 > URL: https://issues.apache.org/jira/browse/NIFI-10995 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.19.0, 1.19.1 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Fix For: 1.20.0 > > > Upgrade Jetty [Release 9.4.50.v20221201 · eclipse/jetty.project > (github.com)|https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.50.v20221201] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6799: NiFi-10995 Update Jetty to 9.4.50.v20221201
asfgit closed pull request #6799: NiFi-10995 Update Jetty to 9.4.50.v20221201 URL: https://github.com/apache/nifi/pull/6799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2020) Minifi main cannot run on Windows as non-service
Ferenc Gerlits created MINIFICPP-2020:
-
Summary: Minifi main cannot run on Windows as non-service
Key: MINIFICPP-2020
URL: https://issues.apache.org/jira/browse/MINIFICPP-2020
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Ferenc Gerlits
Fix For: 0.14.0
If you start the {{minifi}} executable on Windows as a non-system user, it
exits with code -1 immediately, without any error message.
Also, document generation in {{MiNiFiMain.cpp}} should be moved outside of the
complicated restarting mechanism, as it doesn't need it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651125#comment-17651125
]
Josef Zahner commented on NIFI-10973:
-
Yesterday it got even worse, during config sync (nifi registry "change
version") the GUI showed for multiple seconds a progress bar of 40% until we
saw that one of two cluster nodes lost it's connectivity. First impression was
"oh that's not good, but it will connect again" - however that did not
happened. The node tried to reconnect to the existing node but it never really
connected, it was always a connect/disconnect message in the log. At the end we
decided to stop/start everything from scratch and started one by one again the
NiFis.
{color:#de350b}To be honest, we loose more and more the trust into the config
sync via registry as it works that bad in our case at the moment. Every second
sync or so doesn't work as expect (errors that something can't be stopped ->
second try works, local changes although versions are correct, cluster
disconnects,...). I don't know whether this stuff is all related to the nested
flows, but I can't believe that we are the only ones with those issues. {color}
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
> {color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
