[jira] [Created] (NIFI-13019) ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
Ferenc Kis created NIFI-13019:
-
Summary: ClassNotFoundException when using HandleHttpRequest in
MiNiFi-2.0.0-M2
Key: NIFI-13019
URL: https://issues.apache.org/jira/browse/NIFI-13019
Project: Apache NiFi
Issue Type: Bug
Components: MiNiFi
Affects Versions: 2.0.0-M2
Reporter: Ferenc Kis
Assignee: Ferenc Kis
When using HandleHttpRequest in a MiNiFi flow in version 2.0.0-M2 it results in
an error:
{code}
2024-04-10 08:47:15,984 ERROR [Timer-Driven Process Thread-6]
o.a.n.p.standard.HandleHttpRequest
HandleHttpRequest[id=c6babdfa-018e-1000-78f6-d8fd88397126] Processing halted:
yielding [1 sec]
java.lang.NoClassDefFoundError: org/eclipse/jetty/server/handler/ContextHandler
at
org.apache.nifi.processors.standard.HandleHttpRequest.initializeServer(HandleHttpRequest.java:487)
at
org.apache.nifi.processors.standard.HandleHttpRequest.onTrigger(HandleHttpRequest.java:572)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1274)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:244)
at
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
at
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ClassNotFoundException:
org.eclipse.jetty.server.handler.ContextHandler
... 13 common frames omitted
{code}
Most probably this happens due to the Jetty 12 upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1558341192
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html:
##
@@ -0,0 +1,89 @@
+
+
+Change Version
+
+
+
+
+Registry
+{{ versionControlInformation.registryName
}}
Review Comment:
There is a lot of white space on the right hand side of this dialog... maybe
we could move the flow name and current version up to balance it out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1558337332
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html:
##
@@ -0,0 +1,51 @@
+
+
+Change Flow Version
+
+
+
+@if (flowUpdateRequest$ | async; as versionChangeRequest) {
+
+@if (versionChangeRequest.request.complete) {
+This Process Group version has changed.
+} @else {
+{{ versionChangeRequest.request.state }}
+}
+
+
+
Review Comment:
```suggestion
[mat-accent]="versionChangeRequest.request.percentCompleted"
[font-medium]="versionChangeRequest.request.percentCompleted">
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html:
##
@@ -0,0 +1,89 @@
+
+
+Change Version
+
+
+
+
+Registry
+{{ versionControlInformation.registryName
}}
Review Comment:
Since you merged my semantic color PR you need to update this to be:
```suggestion
{{
versionControlInformation.registryName }}
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/local-changes-dialog/local-changes-table/local-changes-table.html:
##
@@ -0,0 +1,80 @@
+
+
+
+
+Displaying {{ filteredCount }} of {{ totalCount
}}
+
+
+
+
+Filter
+
Review Comment:
Of course as I typed this I see that the summary tables have the filter on
the left so it is probably fine.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html:
##
@@ -0,0 +1,51 @@
+
+
+Change Flow Version
+
+
+
+@if (flowUpdateRequest$ | async; as versionChangeRequest) {
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1558332295
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/local-changes-dialog/local-changes-table/local-changes-table.html:
##
@@ -0,0 +1,80 @@
+
+
+
+
+Displaying {{ filteredCount }} of {{ totalCount
}}
+
+
+
+
+Filter
+
Review Comment:
I know that in current nifi this input field is also located on the left but
I think it would be more consistent with the other use cases like this where
users can filter a table is to have the filter on the top right. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1558329228
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/local-changes-dialog/local-changes-table/local-changes-table.ts:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { AfterViewInit, Component, DestroyRef, EventEmitter, inject, Input,
Output } from '@angular/core';
+import { MatFormField, MatLabel } from '@angular/material/form-field';
+import { MatInput } from '@angular/material/input';
+import { FormBuilder, FormGroup, ReactiveFormsModule } from '@angular/forms';
+import { MatTableDataSource, MatTableModule } from '@angular/material/table';
+import { MatSortModule, Sort } from '@angular/material/sort';
+import { NiFiCommon } from
'../../../../../../../../service/nifi-common.service';
+import { ComponentDifference, NavigateToComponentRequest } from
'../../../../../../state/flow';
+import { debounceTime } from 'rxjs';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+import { ComponentType } from '../../../../../../../../state/shared';
+
+interface LocalChange {
+componentType: ComponentType;
+componentId: string;
+componentName: string;
+processGroupId: string;
+differenceType: string;
+difference: string;
+}
+
+@Component({
+selector: 'local-changes-table',
+standalone: true,
+imports: [MatFormField, MatInput, MatLabel, ReactiveFormsModule,
MatTableModule, MatSortModule],
+templateUrl: './local-changes-table.html',
+styleUrl: './local-changes-table.scss'
+})
+export class LocalChangesTable implements AfterViewInit {
+private destroyRef: DestroyRef = inject(DestroyRef);
+initialSortColumn: 'componentName' | 'changeType' | 'difference' =
'componentName';
+initialSortDirection: 'asc' | 'desc' = 'asc';
+
+filterTerm = '';
+totalCount = 0;
+filteredCount = 0;
+
+activeSort: Sort = {
+active: this.initialSortColumn,
+direction: this.initialSortDirection
+};
+
+displayedColumns: string[] = ['componentName', 'changeType', 'difference',
'actions'];
+dataSource: MatTableDataSource = new
MatTableDataSource();
+filterForm: FormGroup;
+
+@Input() set differences(differences: ComponentDifference[]) {
+const localChanges: LocalChange[] =
this.explodeDifferences(differences);
+this.dataSource.data = this.sortEntities(localChanges,
this.activeSort);
+this.dataSource.filterPredicate = (data: LocalChange, filter: string)
=> {
+const { filterTerm } = JSON.parse(filter);
+// check the filter term in both the name and type columns
+return (
+this.nifiCommon.stringContains(data.componentName, filterTerm,
true) ||
+this.nifiCommon.stringContains(data.differenceType,
filterTerm, true)
+);
+};
+this.totalCount = localChanges.length;
+this.filteredCount = localChanges.length;
+
+// apply any filtering to the new data
+const filterTerm = this.filterForm.get('filterTerm')?.value;
+if (filterTerm?.length > 0) {
+this.applyFilter(filterTerm);
+}
+}
+
+@Output() goToChange: EventEmitter = new
EventEmitter();
+
+constructor(
+private formBuilder: FormBuilder,
+private nifiCommon: NiFiCommon
+) {
+this.filterForm = this.formBuilder.group({ filterTerm: '',
filterColumn: 'componentName' });
+}
+
+ngAfterViewInit(): void {
+this.filterForm
+.get('filterTerm')
+?.valueChanges.pipe(debounceTime(500),
takeUntilDestroyed(this.destroyRef))
+.subscribe((filterTerm: string) => {
+this.applyFilter(filterTerm);
+});
+}
+
+applyFilter(filterTerm: string) {
+this.dataSource.filter = JSON.stringify({ filterTerm });
+this.filteredCount = this.dataSource.filteredData.length;
+}
+
+formatComponentName(item: LocalChange): string {
+return item.componentName;
Review Comment:
For a fun
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on PR #8607: URL: https://github.com/apache/nifi/pull/8607#issuecomment-2046084942 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [NIFI-12956] update to mat-button on general settings and login forms [nifi]
scottyaslan opened a new pull request, #8621: URL: https://github.com/apache/nifi/pull/8621 NIFI-12956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]
exceptionfactory commented on code in PR #8620:
URL: https://github.com/apache/nifi/pull/8620#discussion_r1558294655
##
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java:
##
@@ -173,846 +120,783 @@ public interface ProcessSession {
* getDataFromSource();
* session.commitAsync( () -> acknowledgeReceiptOfData() );
*
+ *
+ * If the session cannot be committed, an error will be logged and the
session will be rolled back instead.
*
- * @throws IllegalStateException if called from within a callback (See
{@link #write(FlowFile, StreamCallback)}, {@link #write(FlowFile,
OutputStreamCallback)},
- * {@link #read(FlowFile, InputStreamCallback)}).
+ * @throws IllegalStateException if detected that this method is being
called from within a read or write callback
+ * (see {@link #read(FlowFile, InputStreamCallback)}, {@link
#write(FlowFile, StreamCallback)},
+ * {@link #write(FlowFile, OutputStreamCallback)}) or while a
read or write stream is open
+ * (see {@link #read(FlowFile)}, {@link #write(FlowFile)}).
+ * @throws FlowFileHandlingException if not all {@link FlowFile}s acted
upon within this session are accounted for
+ * such that they have a transfer identified or where marked
for removal. Automated rollback occurs.
+ */
+default void commitAsync() {
Review Comment:
This appears to be a new method.
##
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java:
##
@@ -173,846 +120,783 @@ public interface ProcessSession {
* getDataFromSource();
* session.commitAsync( () -> acknowledgeReceiptOfData() );
*
+ *
+ * If the session cannot be committed, an error will be logged and the
session will be rolled back instead.
*
- * @throws IllegalStateException if called from within a callback (See
{@link #write(FlowFile, StreamCallback)}, {@link #write(FlowFile,
OutputStreamCallback)},
- * {@link #read(FlowFile, InputStreamCallback)}).
+ * @throws IllegalStateException if detected that this method is being
called from within a read or write callback
+ * (see {@link #read(FlowFile, InputStreamCallback)}, {@link
#write(FlowFile, StreamCallback)},
+ * {@link #write(FlowFile, OutputStreamCallback)}) or while a
read or write stream is open
+ * (see {@link #read(FlowFile)}, {@link #write(FlowFile)}).
+ * @throws FlowFileHandlingException if not all {@link FlowFile}s acted
upon within this session are accounted for
+ * such that they have a transfer identified or where marked
for removal. Automated rollback occurs.
+ */
+default void commitAsync() {
+commitAsync(null, null);
+}
+
+/**
+ * Commits the current session ensuring all operations against {@link
FlowFile}s within this session are atomically persisted.
+ * All FlowFiles operated on within this session must be accounted for by
transfer or removal or the commit will fail.
+ *
+ * If the session is successfully committed, the given {@code onSuccess}
{@link Runnable} will be called.
+ * At the point that the session commit is completed, any calls to {@link
#rollback()} / {@link #rollback(boolean)}
+ * will not undo that session commit but instead roll back any changes
that may have occurred since.
+ *
+ * If, for any reason, the session could not be committed, an error-level
log message will be generated,
+ * but the caller will not have a chance to perform any cleanup logic.
+ * If such logic is necessary, use {@link #commitAsync(Runnable,
Consumer)} instead.
+ *
+ * Unlike the {@link #commit()} method, the persistence of data to the
repositories
+ * is not guaranteed to have occurred by the time that this method returns.
*
- * @throws FlowFileHandlingException if any FlowFile is not appropriately
accounted for by transferring it to a Relationship (see {@link
#transfer(FlowFile, Relationship)})
- * or removed (see {@link #remove(FlowFile)}.
+ * @param onSuccess {@link Runnable} that will be called if and when the
session is successfully committed; may be null
+ * @throws IllegalStateException if detected that this method is being
called from within a read or write callback
+ * (see {@link #read(FlowFile, InputStreamCallback)}, {@link
#write(FlowFile, StreamCallback)},
+ * {@link #write(FlowFile, OutputStreamCallback)}) or while a
read or write stream is open
+ * (see {@link #read(FlowFile)}, {@link #write(FlowFile)}).
+ * @throws FlowFileHandlingException if not all {@link FlowFile}s acted
upon within this session are accounted for
+ * such that they have a transfer identified or where marked
for removal. Automated rollback occurs.
*/
default void commitAs
Re: [PR] NIFI-13001: Allowing the user to acknowledge changes to the cluster connection state [nifi]
rfellows commented on code in PR #8606:
URL: https://github.com/apache/nifi/pull/8606#discussion_r1558281204
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/cluster-connection.service.ts:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { DestroyRef, inject, Injectable } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { ClusterSummaryState } from '../state/cluster-summary';
+import { selectDisconnectionAcknowledged } from
'../state/cluster-summary/cluster-summary.selectors';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+
+@Injectable({
+providedIn: 'root'
+})
+export class ClusterConnectionService {
+private destroyRef = inject(DestroyRef);
+private disconnectionAcknowledged = false;
Review Comment:
I think a signal would just be simpler than needing the subscription to the
selection in the constructor:
```
private _disconnectionAcknowledged =
this.store.selectSignal(selectDisconnectionAcknowledged);
```
then...
```
isDisconnectionAcknowledged(): boolean {
return this._disconnectionAcknowledged();
}
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/cluster-connection.service.ts:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { DestroyRef, inject, Injectable } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { ClusterSummaryState } from '../state/cluster-summary';
+import { selectDisconnectionAcknowledged } from
'../state/cluster-summary/cluster-summary.selectors';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+
+@Injectable({
+providedIn: 'root'
+})
+export class ClusterConnectionService {
+private destroyRef = inject(DestroyRef);
+private disconnectionAcknowledged = false;
+
+constructor(private store: Store) {
+this.store
+.select(selectDisconnectionAcknowledged)
+.pipe(takeUntilDestroyed(this.destroyRef))
Review Comment:
Shouldn't need a destroyRef in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13018) BUG - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
Rob Fellows created NIFI-13018:
--
Summary: BUG - Refreshing Node Status History when open for the
cluster, makes the incorrect backend call
Key: NIFI-13018
URL: https://issues.apache.org/jira/browse/NIFI-13018
Project: Apache NiFi
Issue Type: Sub-task
Components: Core UI
Reporter: Rob Fellows
If you open the Node Status History dialog from the global menu and then hit
the refresh icon in the corner, the API call fails as it is trying to load:
{code:java}
http://localhost:4200/nifi-api/flow/processors/undefined/status/history
{code}
and gets a 404. It should be calling:
{code:java}
http://localhost:4200/nifi-api/controller/status/history
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool [nifi]
turcsanyip commented on PR #8619: URL: https://github.com/apache/nifi/pull/8619#issuecomment-2045964945 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]
EndzeitBegins opened a new pull request, #8620: URL: https://github.com/apache/nifi/pull/8620 # Summary Adjusts JavaDoc of `ProcessSession` to fix some minor typos and and align documentation drifts between method overloads, in order to make the JavaDoc more consistent. [NIFI-12986](https://issues.apache.org/jira/browse/NIFI-12986) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13001: Allowing the user to acknowledge changes to the cluster connection state [nifi]
rfellows commented on PR #8606: URL: https://github.com/apache/nifi/pull/8606#issuecomment-2045908566 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12890) Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér updated NIFI-12890: -- Status: Patch Available (was: In Progress) > Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool > -- > > Key: NIFI-12890 > URL: https://issues.apache.org/jira/browse/NIFI-12890 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The AbstractDBCPConnectionPool was designed to avoid code duplication within > the DBCP services. It encompasses shared variables and is constructed in a > way that it contains numerous methods which can be overridden if we wish to > subclass from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool [nifi]
Lehel44 opened a new pull request, #8619: URL: https://github.com/apache/nifi/pull/8619 # Summary [NIFI-12890](https://issues.apache.org/jira/browse/NIFI-12890) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12856) BUG - Documentation looks off in dark themes
[ https://issues.apache.org/jira/browse/NIFI-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-12856. Resolution: Fixed Fixed in https://github.com/apache/nifi/pull/8601 > BUG - Documentation looks off in dark themes > > > Key: NIFI-12856 > URL: https://issues.apache.org/jira/browse/NIFI-12856 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: James Elliott >Priority: Minor > Attachments: image-2024-03-01-16-50-03-450.png > > > The documentation iframe doesn't follow the dark theme class so the title > looks off and the colors do not reflect dark mode. > !image-2024-03-01-16-50-03-450.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12905) UI - page header color
[ https://issues.apache.org/jira/browse/NIFI-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-12905. Resolution: Fixed Fixed in https://github.com/apache/nifi/pull/8608 > UI - page header color > -- > > Key: NIFI-12905 > URL: https://issues.apache.org/jira/browse/NIFI-12905 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-03-14 at 5.02.50 PM.png, Screenshot > 2024-03-14 at 5.03.01 PM.png, Screenshot 2024-03-14 at 5.03.24 PM.png > > > Currently we have the same style defined in several different places and all > used for the header on the different pages of the SPA. These can be combined > into a single `.page-header` style and applied consistently throughout the > app. > > !Screenshot 2024-03-14 at 5.03.24 PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12905) UI - page header color
[ https://issues.apache.org/jira/browse/NIFI-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-12905: -- Assignee: Scott Aslan > UI - page header color > -- > > Key: NIFI-12905 > URL: https://issues.apache.org/jira/browse/NIFI-12905 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-03-14 at 5.02.50 PM.png, Screenshot > 2024-03-14 at 5.03.01 PM.png, Screenshot 2024-03-14 at 5.03.24 PM.png > > > Currently we have the same style defined in several different places and all > used for the header on the different pages of the SPA. These can be combined > into a single `.page-header` style and applied consistently throughout the > app. > > !Screenshot 2024-03-14 at 5.03.24 PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12956) Add semantic styles for the basic theme colors
[
https://issues.apache.org/jira/browse/NIFI-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Fellows resolved NIFI-12956.
Fix Version/s: 2.0.0-M3
Resolution: Fixed
> Add semantic styles for the basic theme colors
> --
>
> Key: NIFI-12956
> URL: https://issues.apache.org/jira/browse/NIFI-12956
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We should add themed styles for the commonly used colors from the palettes.
> I'm thinking like the 3 (light, default, dark) main colors from each palette.
> Something like this:
> {code:java}
> .warn-light {
> color: $warn-palette-light
> }
> .warn-default {
> color: $warn-palette-default
> }
> .warn-dark {
> color: $warn-palette-dark
> }
> .primary-light {
> color: $primary-palette-light
> }
> .primary-default {
> color: $primary-palette-default
> }
> .primary-dark {
> color: $primary-palette-dark
> }
> .accent-light {
> color: $accent-palette-light
> }
> .accent-default {
> color: $accent-palette-default
> }
> .accent-dark {
> color: $accent-palette-dark
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12956) Add semantic styles for the basic theme colors
[
https://issues.apache.org/jira/browse/NIFI-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835508#comment-17835508
]
ASF subversion and git services commented on NIFI-12956:
Commit 40ece46e3ccc8889ba12b98ce4c4425c4f09ca2f in nifi's branch
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=40ece46e3c ]
[NIFI-12956] rename palettes and introduce semenatic color classes (#8608)
* [NIFI-12956] rename palettes and introduce semenatic color classes
* remove warn-default
* remove disabled class and replace with semantic
material-theme-primary-palette-default
* remove running class and replace with semantic
nifi-theme-success-palette-lighter
* replace up-to-date class with semantic nifi-theme-success-palette-default
* replace transmitting class and replace with semantic
nifi-theme-success-palette-default
* replace stopped class with semantic material-theme-warn-palette-lighter
* replace locall-modified and sync-failure classes with semantic
material-theme-accent-palette-lighter
* replace validating, blank, unset, and sensitive classes with semantic
nifi-theme-surface-palette-default
* cleanup and rename _canvas.component-theme.scss semantic classes
* fix typo
* more improvements and adding some documentation for utils
* shorten semantic class names
* rename mixin
* remove value and refresh-timestamp class and introduce on default surface and
on darker surface material primary/accent/warn semantic classes
* always calculate the material color based on the surface
* restore blank, unset, empty, sensitive, ghost, validating
* restore sync-failure, stale, locally-modified, locally-modified-and-stale,
and up-to-date colors. Also use nifi theme warn palette where appropriate
* remove validating, locally-modified, sync-failure, and replase with
nifi-surface-default. remove stale, locally-modified-and-stale and replace with
nifi-warn-light
* simplfy semantic material theme class names
* fix erroneous colors
* update purple theme
* update comments in theme files to accurately list light mode usage, remove
unused vars, move semantic classes from _canvas.component-theme.scss to global
_app.scss, fix a few incorrect colors
* fix typ0
* update pom to overwrite the correct file
* restore class names with no styles to assist in understanding state
* update blank, unset, ghost, sensitive, empty
* update default theme name to match renamed file
* move border to class in birdseye
* review feedback
* enabled now nifi-success-default color
* final touches
* use mat-warn for bulletin error
* fix search and flow status
This closes #8608
> Add semantic styles for the basic theme colors
> --
>
> Key: NIFI-12956
> URL: https://issues.apache.org/jira/browse/NIFI-12956
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Scott Aslan
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We should add themed styles for the commonly used colors from the palettes.
> I'm thinking like the 3 (light, default, dark) main colors from each palette.
> Something like this:
> {code:java}
> .warn-light {
> color: $warn-palette-light
> }
> .warn-default {
> color: $warn-palette-default
> }
> .warn-dark {
> color: $warn-palette-dark
> }
> .primary-light {
> color: $primary-palette-light
> }
> .primary-default {
> color: $primary-palette-default
> }
> .primary-dark {
> color: $primary-palette-dark
> }
> .accent-light {
> color: $accent-palette-light
> }
> .accent-default {
> color: $accent-palette-default
> }
> .accent-dark {
> color: $accent-palette-dark
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
rfellows merged PR #8608: URL: https://github.com/apache/nifi/pull/8608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12837) Add DFS setting to smb processors
[
https://issues.apache.org/jira/browse/NIFI-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835504#comment-17835504
]
ASF subversion and git services commented on NIFI-12837:
Commit f7cd8752ea10f92281bf126e60c320e5d449c72a in nifi's branch
refs/heads/support/nifi-1.x from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f7cd8752ea ]
NIFI-12837 - Fix checkstyle issue following a manual cherrypick
> Add DFS setting to smb processors
> -
>
> Key: NIFI-12837
> URL: https://issues.apache.org/jira/browse/NIFI-12837
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0-M3, 1.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The hierynomus/smbj library has a setting for enabling DFS which is disabled
> by default:
> https://github.com/hierynomus/smbj/blob/f25d5c5478a5b73e9ba4202dcfb365974e15367e/src/main/java/com/hierynomus/smbj/SmbConfig.java#L106C17-L106C39
> This appears to cause problems in some SMB configurations.
> Patched
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> to test in my environment with:
> {code}
> $ git diff
> nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> diff --git
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
>
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> index 0895abfae0..eac765 100644
> ---
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> +++
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> @@ -46,6 +46,8 @@ public final class SmbUtils {
> }
> }
> +configBuilder.withDfsEnabled(true);
> +
> if (context.getProperty(USE_ENCRYPTION).isSet()) {
>
> configBuilder.withEncryptData(context.getProperty(USE_ENCRYPTION).asBoolean());
> }
> {code}
> This appeared to resolve the issue.
> It would be very useful if this setting was available to toggle in the UI for
> all SMB processors.
> Without this setting, I get a *STATUS_PATH_NOT_COVERED* error.
> Somewhat related hierynomus/smbj github issues:
> https://github.com/hierynomus/smbj/issues/152
> https://github.com/hierynomus/smbj/issues/419
> This setting should be made available in the following processors and
> services:
> * GetSmbFile
> * PutSmbFile
> * SmbjClientProviderService
> Edit: It might require some more changes to handle the connections and
> sessions correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13017) [BUG] Jolt custom UI back navigation is broken
Scott Aslan created NIFI-13017: -- Summary: [BUG] Jolt custom UI back navigation is broken Key: NIFI-13017 URL: https://issues.apache.org/jira/browse/NIFI-13017 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: image-2024-04-09-14-15-51-221.png When the user navigates to the Jolt custom UI and attempts to go back to the canvas via the browser back button navigation the routing does not work and the users history is removed. !image-2024-04-09-14-15-51-221.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13010) UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup
[ https://issues.apache.org/jira/browse/NIFI-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-13010. --- Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed > UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup > - > > Key: NIFI-13010 > URL: https://issues.apache.org/jira/browse/NIFI-13010 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The UpdateDatabaseTable processor fails to execute when it is configured to > use a DBCP Connection Pool Lookup. The flow file has database.name attribute, > However, when the processor runs, it gets the following error: > org.apache.nifi.processor.exception.ProcessException: > java.lang.UnsupportedOperationException: Cannot lookup DBCPConnectionPool > without attributes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13010) UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup
[ https://issues.apache.org/jira/browse/NIFI-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835501#comment-17835501 ] ASF subversion and git services commented on NIFI-13010: Commit f15e6c73ec9ed2b5155f8a29302aa94c48e9ebc9 in nifi's branch refs/heads/main from Jim Steinebrey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f15e6c73ec ] NIFI-13010 Fix UpdateDatabaseTable to work with DBCPConnectionPoolLookup Signed-off-by: Pierre Villard This closes #8616. > UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup > - > > Key: NIFI-13010 > URL: https://issues.apache.org/jira/browse/NIFI-13010 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The UpdateDatabaseTable processor fails to execute when it is configured to > use a DBCP Connection Pool Lookup. The flow file has database.name attribute, > However, when the processor runs, it gets the following error: > org.apache.nifi.processor.exception.ProcessException: > java.lang.UnsupportedOperationException: Cannot lookup DBCPConnectionPool > without attributes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13010) UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup
[ https://issues.apache.org/jira/browse/NIFI-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835502#comment-17835502 ] ASF subversion and git services commented on NIFI-13010: Commit 8575bd52f9d7e47ca1cc6343d6cd17d8acb95c26 in nifi's branch refs/heads/support/nifi-1.x from Jim Steinebrey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8575bd52f9 ] NIFI-13010 Fix UpdateDatabaseTable to work with DBCPConnectionPoolLookup Signed-off-by: Pierre Villard This closes #8616. > UpdateDatabaseTable Processor cannot use DBCPConnectionPoolLookup > - > > Key: NIFI-13010 > URL: https://issues.apache.org/jira/browse/NIFI-13010 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The UpdateDatabaseTable processor fails to execute when it is configured to > use a DBCP Connection Pool Lookup. The flow file has database.name attribute, > However, when the processor runs, it gets the following error: > org.apache.nifi.processor.exception.ProcessException: > java.lang.UnsupportedOperationException: Cannot lookup DBCPConnectionPool > without attributes -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13010 Fix UpdateDatabaseTable to work with DBCPConnectionPoolLookup [nifi]
asfgit closed pull request #8616: NIFI-13010 Fix UpdateDatabaseTable to work with DBCPConnectionPoolLookup URL: https://github.com/apache/nifi/pull/8616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13011) contrast ratio and PG and RPG headers/icons
[ https://issues.apache.org/jira/browse/NIFI-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13011: --- Description: The following use cases do not have enough contrast in light and dark mode: * Versioned PG icons (stale, locally-modified, no up-to-date) on the PG header * Warning icons on PG and RPG headers on the canvas * Flow status icons (.zero) * Breadcrumb icons at the bottom of the canvas was:Versioned PG icons (stale, locally-modified, no up-to-date) on the PG header on the canvas do not have enough contrast in light and dark mode. Warning icons on PG and RPG headers on the canvas also do not have enough contrast. > contrast ratio and PG and RPG headers/icons > --- > > Key: NIFI-13011 > URL: https://issues.apache.org/jira/browse/NIFI-13011 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-04-08 at 4.29.41 PM.png > > > The following use cases do not have enough contrast in light and dark mode: > * Versioned PG icons (stale, locally-modified, no up-to-date) on the PG > header > * Warning icons on PG and RPG headers on the canvas > * Flow status icons (.zero) > * Breadcrumb icons at the bottom of the canvas -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13016) Retrieve groups from OIDC token
Guillaume Lhermenier created NIFI-13016: --- Summary: Retrieve groups from OIDC token Key: NIFI-13016 URL: https://issues.apache.org/jira/browse/NIFI-13016 Project: Apache NiFi Issue Type: New Feature Components: NiFi Registry Reporter: Guillaume Lhermenier As it has been done in NiFi (I guess in this [ticket|https://issues.apache.org/jira/browse/NIFI-7823]) it would be very nice to also have groups mapping directly from provider in NiFi Registry as well. This would let admins set permissions the same way for both tools instead of having to define them manually in NiFi Registry -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors (1.x version) [nifi]
mattyb149 opened a new pull request, #8618: URL: https://github.com/apache/nifi/pull/8618 # Summary [NIFI-12889](https://issues.apache.org/jira/browse/NIFI-12889) This PR is the 1.x version of #8495 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `support/nifi-1.x` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12231) Add completion strategy to FetchSmb
[ https://issues.apache.org/jira/browse/NIFI-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12231: --- Component/s: Extensions (was: Core Framework) > Add completion strategy to FetchSmb > --- > > Key: NIFI-12231 > URL: https://issues.apache.org/jira/browse/NIFI-12231 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Jens M Kofoed >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The newly added ListSmb and FetchSmb has been very much appreciated. But > sadly the FetchSmb does not have the same options like other Fetch processors. > FetchFTP and FetchSFTP process has a Completion Strategy where you can choose > to Move or Delete the file after it has been fetched. > It would be very helpfull if FetchSmb gets the same possibilities -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12231) Add completion strategy to FetchSmb
[ https://issues.apache.org/jira/browse/NIFI-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12231: --- Status: Patch Available (was: In Progress) > Add completion strategy to FetchSmb > --- > > Key: NIFI-12231 > URL: https://issues.apache.org/jira/browse/NIFI-12231 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework >Affects Versions: 1.23.2 >Reporter: Jens M Kofoed >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The newly added ListSmb and FetchSmb has been very much appreciated. But > sadly the FetchSmb does not have the same options like other Fetch processors. > FetchFTP and FetchSFTP process has a Completion Strategy where you can choose > to Move or Delete the file after it has been fetched. > It would be very helpfull if FetchSmb gets the same possibilities -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]
turcsanyip opened a new pull request, #8617: URL: https://github.com/apache/nifi/pull/8617 # Summary [NIFI-12231](https://issues.apache.org/jira/browse/NIFI-12231) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2325 Add missing compiler flags [nifi-minifi-cpp]
szaszm commented on PR #1755: URL: https://github.com/apache/nifi-minifi-cpp/pull/1755#issuecomment-2045534547 CI failure: ``` CPack: Executing pre-build script: D:/a/nifi-minifi-cpp/nifi-minifi-cpp/cmake/prep_for_win_package.cmake CMake Error at D:/a/nifi-minifi-cpp/nifi-minifi-cpp/cmake/prep_for_win_package.cmake:7 (file): file COPY cannot find "/bin//minifi.exe": File exists. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608: URL: https://github.com/apache/nifi/pull/8608#discussion_r1557839018 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss: ## @@ -126,15 +38,14 @@ $material-theme-light: mat.define-light-theme( accent: $material-accent-light, warn: $warn-light ), -//typography: mat.define-typography-config(), // TODO: typography -density: -3 +density: -1 Review Comment: UPDATE: ok so our dialogs have set sizes (for example this 'Edit Processor' dialog is a a medium dialog size with minWidth: 760px and maxWidth: 760px) and all of our buttons and tables set their own density. So it seems this setting is not such a global setting and it is not as easy as adjusting it to adjust the entire density of the app. I will revert it to `-3` for now and maybe in the future we can support adjusting the density globally via the theme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557807976
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -143,12 +143,12 @@ export class BulletinBoardList implements AfterViewInit {
getSeverity(severity: string) {
switch (severity.toLowerCase()) {
case 'error':
-return 'bulletin-error';
+return 'bulletin-error material-warn-darker';
Review Comment:
Good catch guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557805191
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -127,186 +131,274 @@
}
}
-@mixin colors($material-theme, $canvas-theme) {
+@mixin generate-material-theme($material-theme, $nifi-theme) {
// Get the color config from the theme.
-$color-config: mat.get-color-config($material-theme);
-$canvas-color-config: mat.get-color-config($canvas-theme);
-
-// Get the color palette from the color-config.
-$primary-palette: map.get($color-config, 'primary');
-$accent-palette: map.get($color-config, 'accent');
-$warn-palette: map.get($color-config, 'warn');
-$canvas-primary-palette: map.get($canvas-color-config, 'primary');
-$canvas-accent-palette: map.get($canvas-color-config, 'accent');
-
-// Get hues from palette
+$material-theme-color-config: mat.get-color-config($material-theme);
+$nifi-theme-color-config: mat.get-color-config($nifi-theme);
+
+// Get the palettes
+$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-warn-palette: map.get($nifi-theme-color-config, 'warn');
+
+// colors from the theme palettes
+$material-theme-primary-palette-A200:
mat.get-color-from-palette($material-theme-primary-palette, 'A200');
+$material-theme-primary-palette-A400:
mat.get-color-from-palette($material-theme-primary-palette, 'A400');
+$nifi-theme-warn-palette-A200:
mat.get-color-from-palette($nifi-theme-warn-palette, 'A200');
+
+// semantic classes for the material theme
+
+.mat-primary {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'primary'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'primary'
+) !important;
+}
+
+.mat-accent {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'accent'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'accent'
+) !important;
+}
+
+.mat-warn {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'warn'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'warn'
+) !important;
+}
+
+/* other classes and overriding 3rd party styles */
-// Start with the canvas theme.
-$canvas-primary-palette-A200:
mat.get-color-from-palette($canvas-primary-palette, A200);
-$canvas-primary-palette-500:
mat.get-color-from-palette($canvas-primary-palette, 500);
-$canvas-accent-palette-lighter:
mat.get-color-from-palette($canvas-accent-palette, lighter);
-$canvas-accent-palette-default:
mat.get-color-from-palette($canvas-accent-palette, default);
+a {
+// calculate the color for text on top of a material theme primary
palette default color element
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($material-theme-color-config)
+);
+// get the lighter color from the material theme primary palette
+text-decoration-color:
mat.get-color-from-palette($material-theme-primary-palette, 'lighter');
+}
-$primary-palette-lighter: mat.get-color-from-palette($primary-palette,
lighter);
-$primary-palette-default: mat.get-color-from-palette($primary-palette,
'default');
-$primary-palette-A400: mat.get-color-from-palette($primary-palette,
'A400');
+a:hover {
+// calculate the color for text on top of a material theme primary
palette default colored element
+text-decoration-color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($material-theme-color-config)
+);
+}
-$accent-palette-lighter: mat.get-color-from-palette($accent-palette,
'lighter');
+.mat-mdc-icon-button {
+// calculate the color for text on top of a nifi theme accent palette
darker colored element
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config, 'darker')
+) !important;
+}
-$warn-palette-lighter: mat.get-color-from-palette($warn-palette, lighter);
-$warn-palette-default: mat.get-color-from-palette($warn-
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557802982
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##
@@ -265,11 +199,11 @@
}
text.processor-type {
-fill: utils.get-color-on-surface($color-config, $surface,
'accent');
+fill: utils.get-color-on-surface($material-theme-color-config,
$surface, 'accent');
}
Review Comment:
@james-elliott is correct. We have a hard coded 'default' color and the user
can choose any color they like for this icon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13010 Fix UpdateDatabaseTable to work with DBCPConnectionPoolLookup [nifi]
jrsteinebrey opened a new pull request, #8616: URL: https://github.com/apache/nifi/pull/8616 # Summary [NIFI-13010](https://issues.apache.org/jira/browse/NIFI-13010) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-13010` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-13010` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing No dependencies changes ### Documentation No documentation changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557793416
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/port-manager.service.ts:
##
@@ -449,7 +449,7 @@ export class PortManager {
return '\ue80a';
}
})
-.classed('transmitting', function (d: any) {
+.classed('nifi-success-default', function (d: any) {
Review Comment:
Ok I like where this is going. @james-elliott do we want to remove the
`.enabled` class and replace it with the `.nifi-success-default` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557755170
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -143,12 +143,12 @@ export class BulletinBoardList implements AfterViewInit {
getSeverity(severity: string) {
switch (severity.toLowerCase()) {
case 'error':
-return 'bulletin-error';
+return 'bulletin-error material-warn-darker';
Review Comment:
good catch. it should probably also be `mat-warn-darker` anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
Anush008 commented on PR #8590: URL: https://github.com/apache/nifi/pull/8590#issuecomment-2045320105 Thanks for letting me know @exceptionfactory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10977) Add Documentation for Kubernetes Cluster Deployments
[ https://issues.apache.org/jira/browse/NIFI-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835433#comment-17835433 ] ASF subversion and git services commented on NIFI-10977: Commit 858d0bdf2556705279bb3e5c6ceb7c8bd60db21b in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=858d0bdf25 ] NIFI-10977 Added documentation on Kubernetes Clustering Signed-off-by: Pierre Villard This closes #8612. > Add Documentation for Kubernetes Cluster Deployments > > > Key: NIFI-10977 > URL: https://issues.apache.org/jira/browse/NIFI-10977 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Project documentation should be expanded to describe the basic features and > implementation of Kubernetes Leader Election and State Management. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10977) Add Documentation for Kubernetes Cluster Deployments
[ https://issues.apache.org/jira/browse/NIFI-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10977: -- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Add Documentation for Kubernetes Cluster Deployments > > > Key: NIFI-10977 > URL: https://issues.apache.org/jira/browse/NIFI-10977 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > Project documentation should be expanded to describe the basic features and > implementation of Kubernetes Leader Election and State Management. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-10977 Add documentation on Kubernetes Clustering [nifi]
asfgit closed pull request #8612: NIFI-10977 Add documentation on Kubernetes Clustering URL: https://github.com/apache/nifi/pull/8612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557714973
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -143,12 +143,12 @@ export class BulletinBoardList implements AfterViewInit {
getSeverity(severity: string) {
switch (severity.toLowerCase()) {
case 'error':
-return 'bulletin-error';
+return 'bulletin-error material-warn-darker';
Review Comment:
I can't seem to find where "material-warn-darker" is defined.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -127,186 +131,274 @@
}
}
-@mixin colors($material-theme, $canvas-theme) {
+@mixin generate-material-theme($material-theme, $nifi-theme) {
// Get the color config from the theme.
-$color-config: mat.get-color-config($material-theme);
-$canvas-color-config: mat.get-color-config($canvas-theme);
-
-// Get the color palette from the color-config.
-$primary-palette: map.get($color-config, 'primary');
-$accent-palette: map.get($color-config, 'accent');
-$warn-palette: map.get($color-config, 'warn');
-$canvas-primary-palette: map.get($canvas-color-config, 'primary');
-$canvas-accent-palette: map.get($canvas-color-config, 'accent');
-
-// Get hues from palette
+$material-theme-color-config: mat.get-color-config($material-theme);
+$nifi-theme-color-config: mat.get-color-config($nifi-theme);
+
+// Get the palettes
+$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-warn-palette: map.get($nifi-theme-color-config, 'warn');
+
+// colors from the theme palettes
+$material-theme-primary-palette-A200:
mat.get-color-from-palette($material-theme-primary-palette, 'A200');
+$material-theme-primary-palette-A400:
mat.get-color-from-palette($material-theme-primary-palette, 'A400');
+$nifi-theme-warn-palette-A200:
mat.get-color-from-palette($nifi-theme-warn-palette, 'A200');
+
+// semantic classes for the material theme
+
+.mat-primary {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'primary'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'primary'
+) !important;
+}
+
+.mat-accent {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'accent'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'accent'
+) !important;
+}
+
+.mat-warn {
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'warn'
+) !important;
+fill: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($nifi-theme-color-config),
+'warn'
+) !important;
+}
+
+/* other classes and overriding 3rd party styles */
-// Start with the canvas theme.
-$canvas-primary-palette-A200:
mat.get-color-from-palette($canvas-primary-palette, A200);
-$canvas-primary-palette-500:
mat.get-color-from-palette($canvas-primary-palette, 500);
-$canvas-accent-palette-lighter:
mat.get-color-from-palette($canvas-accent-palette, lighter);
-$canvas-accent-palette-default:
mat.get-color-from-palette($canvas-accent-palette, default);
+a {
+// calculate the color for text on top of a material theme primary
palette default color element
+color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($material-theme-color-config)
+);
+// get the lighter color from the material theme primary palette
+text-decoration-color:
mat.get-color-from-palette($material-theme-primary-palette, 'lighter');
+}
-$primary-palette-lighter: mat.get-color-from-palette($primary-palette,
lighter);
-$primary-palette-default: mat.get-color-from-palette($primary-palette,
'default');
-$primary-palette-A400: mat.get-color-from-palette($primary-palette,
'A400');
+a:hover {
+// calculate the color for text on top of a material theme primary
palette default colored element
+text-decoration-color: utils.get-color-on-surface(
+$material-theme-color-config,
+utils.get-surface($ma
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557682396
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/port-manager.service.ts:
##
@@ -449,7 +449,7 @@ export class PortManager {
return '\ue80a';
}
})
-.classed('transmitting', function (d: any) {
+.classed('nifi-success-default', function (d: any) {
Review Comment:
This was introduced in an earlier change from NIFI-12870. I changed it to a
green to match ".running".
"Blue means transmitting and green means running" is a much more complex,
and not super helpful use of color versus "green means it's on and working". By
connecting the concepts and reducing the number of different colors used it
makes theming more straightforward. Themes only need to consider one color for
"it's working" versus having to select multiple colors for conceptually
identical information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
exceptionfactory commented on PR #8590: URL: https://github.com/apache/nifi/pull/8590#issuecomment-2045248710 @Anush008 One procedural note: please avoid adding merge commits to a pull request as it is not required and adds a step to the final merge process. If there are conflicts with the main branch, the pull request branch should be rebased, retaining the individual pull request commits, but without introducing merge commits. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
scottyaslan commented on code in PR #8608: URL: https://github.com/apache/nifi/pull/8608#discussion_r1557680975 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss: ## @@ -126,15 +38,14 @@ $material-theme-light: mat.define-light-theme( accent: $material-accent-light, warn: $warn-light ), -//typography: mat.define-typography-config(), // TODO: typography -density: -3 +density: -1 Review Comment: I would like to leave this as is for now. I was trying it out to try to understand the 'art of the possible'. I don't think we anticipate anyone running this purple theme as a production theme but I wanted to show that it is at least possible to set a different density for a theme. Let me see what is going on with these scroll bars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10977 Add documentation on Kubernetes Clustering [nifi]
exceptionfactory commented on code in PR #8612: URL: https://github.com/apache/nifi/pull/8612#discussion_r1557678708 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -2569,21 +2625,29 @@ If `CreatorOnly` is specified, then only the user that created the data is allow In order to use the `CreatorOnly` option, NiFi must provide some form of authentication. See the <> section below for more information on how to configure authentication. -If NiFi is configured to run in a standalone mode, the `cluster-provider` element need not be populated in the _state-management.xml_ -file and will actually be ignored if they are populated. However, the `local-provider` element must always be present and populated. -Additionally, if NiFi is run in a cluster, each node must also have the `cluster-provider` element present and properly configured. -Otherwise, NiFi will fail to startup. + Kubernetes ConfigMap Cluster State Provider -While there are not many properties that need to be configured for these providers, they were externalized into a separate _state-management.xml_ -file, rather than being configured via the _nifi.properties_ file, simply because different implementations may require different properties, -and it is easier to maintain and understand the configuration in an XML-based file such as this, than to mix the properties of the Provider -in with all of the other NiFi framework-specific properties. +The Kubernetes ConfigMap State Provider supports shared cluster state when running in Kubernetes. -It should be noted that if Processors and other components save state using the Clustered scope, the Local State Provider will be used -if the instance is a standalone instance (not in a cluster) or is disconnected from the cluster. This also means that if a standalone instance -is migrated to become a cluster, then that state will no longer be available, as the component will begin using the Clustered State Provider -instead of the Local State Provider. +The provider stores component state in +link:https://kubernetes.io/docs/concepts/configuration/configmap/[Kubernetes ConfigMaps] Review Comment: Thanks for the feedback @pvillard31! I agree that it is worth calling out the limit in NiFi documentation, so I added a note mentioning the 1 MB limit for ConfigMaps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557670266
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##
@@ -265,11 +199,11 @@
}
text.processor-type {
-fill: utils.get-color-on-surface($color-config, $surface,
'accent');
+fill: utils.get-color-on-surface($material-theme-color-config,
$surface, 'accent');
}
Review Comment:
This happens with the canvas components that can be colored using the paint
brush icon on the operation panel. The default color is hard coded. The color
after is auto calculated based on the users input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12956] rename palettes and introduce semenatic color classes [nifi]
rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557642603
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##
@@ -126,15 +38,14 @@ $material-theme-light: mat.define-light-theme(
accent: $material-accent-light,
warn: $warn-light
),
-//typography: mat.define-typography-config(), // TODO: typography
-density: -3
+density: -1
Review Comment:
I think this density needs to be `-3`. We have double scrollbars on the
processor configuration dialog's properties tab without it.
https://github.com/apache/nifi/assets/713866/82250e58-33fa-455e-bcba-0da4b4eea524";>
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##
@@ -265,11 +199,11 @@
}
text.processor-type {
-fill: utils.get-color-on-surface($color-config, $surface,
'accent');
+fill: utils.get-color-on-surface($material-theme-color-config,
$surface, 'accent');
}
Review Comment:
do we need to have a similar treatment on the text.processor-icon? I noticed
in purple mode, the icon on the canvas for a processor looks like it isn't
themed and doesn't match the icon in the operation panel. The other component
types seem to have the expected color
https://github.com/apache/nifi/assets/713866/1a2fbc3c-a7d4-4ae6-8197-1e2719041052";>
https://github.com/apache/nifi/assets/713866/c0b095a9-5b5b-472e-a21c-f0e53334019a";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12837) Add DFS setting to smb processors
[
https://issues.apache.org/jira/browse/NIFI-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-12837:
--
Fix Version/s: 1.26.0
> Add DFS setting to smb processors
> -
>
> Key: NIFI-12837
> URL: https://issues.apache.org/jira/browse/NIFI-12837
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0-M3, 1.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The hierynomus/smbj library has a setting for enabling DFS which is disabled
> by default:
> https://github.com/hierynomus/smbj/blob/f25d5c5478a5b73e9ba4202dcfb365974e15367e/src/main/java/com/hierynomus/smbj/SmbConfig.java#L106C17-L106C39
> This appears to cause problems in some SMB configurations.
> Patched
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> to test in my environment with:
> {code}
> $ git diff
> nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> diff --git
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
>
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> index 0895abfae0..eac765 100644
> ---
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> +++
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> @@ -46,6 +46,8 @@ public final class SmbUtils {
> }
> }
> +configBuilder.withDfsEnabled(true);
> +
> if (context.getProperty(USE_ENCRYPTION).isSet()) {
>
> configBuilder.withEncryptData(context.getProperty(USE_ENCRYPTION).asBoolean());
> }
> {code}
> This appeared to resolve the issue.
> It would be very useful if this setting was available to toggle in the UI for
> all SMB processors.
> Without this setting, I get a *STATUS_PATH_NOT_COVERED* error.
> Somewhat related hierynomus/smbj github issues:
> https://github.com/hierynomus/smbj/issues/152
> https://github.com/hierynomus/smbj/issues/419
> This setting should be made available in the following processors and
> services:
> * GetSmbFile
> * PutSmbFile
> * SmbjClientProviderService
> Edit: It might require some more changes to handle the connections and
> sessions correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12837) Add DFS setting to smb processors
[
https://issues.apache.org/jira/browse/NIFI-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835415#comment-17835415
]
ASF subversion and git services commented on NIFI-12837:
Commit 10ce00862d1479dee1444d0da9cc48bbbd83729f in nifi's branch
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=10ce00862d ]
NIFI-12837 Added DFS support in SMB processors
Signed-off-by: Pierre Villard
This closes #8527.
> Add DFS setting to smb processors
> -
>
> Key: NIFI-12837
> URL: https://issues.apache.org/jira/browse/NIFI-12837
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The hierynomus/smbj library has a setting for enabling DFS which is disabled
> by default:
> https://github.com/hierynomus/smbj/blob/f25d5c5478a5b73e9ba4202dcfb365974e15367e/src/main/java/com/hierynomus/smbj/SmbConfig.java#L106C17-L106C39
> This appears to cause problems in some SMB configurations.
> Patched
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> to test in my environment with:
> {code}
> $ git diff
> nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> diff --git
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
>
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> index 0895abfae0..eac765 100644
> ---
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> +++
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> @@ -46,6 +46,8 @@ public final class SmbUtils {
> }
> }
> +configBuilder.withDfsEnabled(true);
> +
> if (context.getProperty(USE_ENCRYPTION).isSet()) {
>
> configBuilder.withEncryptData(context.getProperty(USE_ENCRYPTION).asBoolean());
> }
> {code}
> This appeared to resolve the issue.
> It would be very useful if this setting was available to toggle in the UI for
> all SMB processors.
> Without this setting, I get a *STATUS_PATH_NOT_COVERED* error.
> Somewhat related hierynomus/smbj github issues:
> https://github.com/hierynomus/smbj/issues/152
> https://github.com/hierynomus/smbj/issues/419
> This setting should be made available in the following processors and
> services:
> * GetSmbFile
> * PutSmbFile
> * SmbjClientProviderService
> Edit: It might require some more changes to handle the connections and
> sessions correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] MINIFICPP-2325 Add missing compiler flags [nifi-minifi-cpp]
fgerlits opened a new pull request, #1755: URL: https://github.com/apache/nifi-minifi-cpp/pull/1755 These flags are on by default when we use msbuild, but they need to be added manually when we build using ninja. Without these flags, the resulting dlls were roughly twice as large when using ninja compared to using msbuild. After adding the flags, the sizes are back to normal. I have also updated prep_for_win_package.cmake so that it works both with msbuild and ninja. https://issues.apache.org/jira/browse/MINIFICPP-2325 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12837) Add DFS setting to smb processors
[
https://issues.apache.org/jira/browse/NIFI-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-12837:
--
Fix Version/s: 2.0.0-M3
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add DFS setting to smb processors
> -
>
> Key: NIFI-12837
> URL: https://issues.apache.org/jira/browse/NIFI-12837
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The hierynomus/smbj library has a setting for enabling DFS which is disabled
> by default:
> https://github.com/hierynomus/smbj/blob/f25d5c5478a5b73e9ba4202dcfb365974e15367e/src/main/java/com/hierynomus/smbj/SmbConfig.java#L106C17-L106C39
> This appears to cause problems in some SMB configurations.
> Patched
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> to test in my environment with:
> {code}
> $ git diff
> nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> diff --git
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
>
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> index 0895abfae0..eac765 100644
> ---
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> +++
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> @@ -46,6 +46,8 @@ public final class SmbUtils {
> }
> }
> +configBuilder.withDfsEnabled(true);
> +
> if (context.getProperty(USE_ENCRYPTION).isSet()) {
>
> configBuilder.withEncryptData(context.getProperty(USE_ENCRYPTION).asBoolean());
> }
> {code}
> This appeared to resolve the issue.
> It would be very useful if this setting was available to toggle in the UI for
> all SMB processors.
> Without this setting, I get a *STATUS_PATH_NOT_COVERED* error.
> Somewhat related hierynomus/smbj github issues:
> https://github.com/hierynomus/smbj/issues/152
> https://github.com/hierynomus/smbj/issues/419
> This setting should be made available in the following processors and
> services:
> * GetSmbFile
> * PutSmbFile
> * SmbjClientProviderService
> Edit: It might require some more changes to handle the connections and
> sessions correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12837) Add DFS setting to smb processors
[
https://issues.apache.org/jira/browse/NIFI-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835372#comment-17835372
]
ASF subversion and git services commented on NIFI-12837:
Commit 928206d52f3a442b24eb5a911507af821c30ea2d in nifi's branch
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=928206d52f ]
NIFI-12837 Added DFS support in SMB processors
Signed-off-by: Pierre Villard
This closes #8527.
> Add DFS setting to smb processors
> -
>
> Key: NIFI-12837
> URL: https://issues.apache.org/jira/browse/NIFI-12837
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The hierynomus/smbj library has a setting for enabling DFS which is disabled
> by default:
> https://github.com/hierynomus/smbj/blob/f25d5c5478a5b73e9ba4202dcfb365974e15367e/src/main/java/com/hierynomus/smbj/SmbConfig.java#L106C17-L106C39
> This appears to cause problems in some SMB configurations.
> Patched
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> to test in my environment with:
> {code}
> $ git diff
> nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> diff --git
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
>
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> index 0895abfae0..eac765 100644
> ---
> a/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> +++
> b/nifi-nar-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbUtils.java
> @@ -46,6 +46,8 @@ public final class SmbUtils {
> }
> }
> +configBuilder.withDfsEnabled(true);
> +
> if (context.getProperty(USE_ENCRYPTION).isSet()) {
>
> configBuilder.withEncryptData(context.getProperty(USE_ENCRYPTION).asBoolean());
> }
> {code}
> This appeared to resolve the issue.
> It would be very useful if this setting was available to toggle in the UI for
> all SMB processors.
> Without this setting, I get a *STATUS_PATH_NOT_COVERED* error.
> Somewhat related hierynomus/smbj github issues:
> https://github.com/hierynomus/smbj/issues/152
> https://github.com/hierynomus/smbj/issues/419
> This setting should be made available in the following processors and
> services:
> * GetSmbFile
> * PutSmbFile
> * SmbjClientProviderService
> Edit: It might require some more changes to handle the connections and
> sessions correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12837 Added DFS support in SMB processors [nifi]
asfgit closed pull request #8527: NIFI-12837 Added DFS support in SMB processors URL: https://github.com/apache/nifi/pull/8527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2325) Add missing compiler flags to the Ninja build on Windows
Ferenc Gerlits created MINIFICPP-2325: - Summary: Add missing compiler flags to the Ninja build on Windows Key: MINIFICPP-2325 URL: https://issues.apache.org/jira/browse/MINIFICPP-2325 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ferenc Gerlits Assignee: Ferenc Gerlits -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12889) Retry Kerberos Login on auth failures in HDFS processors
[ https://issues.apache.org/jira/browse/NIFI-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12889: -- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) Marked as fixed for 2.0-M3 but we also want a backport into 1.x > Retry Kerberos Login on auth failures in HDFS processors > > > Key: NIFI-12889 > URL: https://issues.apache.org/jira/browse/NIFI-12889 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Currently if a Kerberos authentication failure happens (during ticket > relogin, e.g.) in the HDFS processors, the controller service must be > restarted manually in order for the processors to execute correctly. From the > processors we should reset the HDFS resources on auth failure to simulate a > "restart" of the controller service so relogin can occur correctly. > At a minimum this includes the following processors: > FetchHDFS > GetHDFS > GetHDFSFileInfo > PutHDFS > ListHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
pvillard31 commented on PR #8495: URL: https://github.com/apache/nifi/pull/8495#issuecomment-2044659154 @mattyb149 - I merged this into main but forgot to amend the commit and add the magic words to close the PR, so closing manually. Also it does not apply cleanly to 1.x can you open a PR for the support branch? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
pvillard31 closed pull request #8495: NIFI-12889: Retry Kerberos login on auth failure in HDFS processors URL: https://github.com/apache/nifi/pull/8495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12889) Retry Kerberos Login on auth failures in HDFS processors
[ https://issues.apache.org/jira/browse/NIFI-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835341#comment-17835341 ] ASF subversion and git services commented on NIFI-12889: Commit 06b0f29cad352922fbed16decabe33246a2ddc0b in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=06b0f29cad ] NIFI-12889 - Retry Kerberos login on auth failure in HDFS processors > Retry Kerberos Login on auth failures in HDFS processors > > > Key: NIFI-12889 > URL: https://issues.apache.org/jira/browse/NIFI-12889 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently if a Kerberos authentication failure happens (during ticket > relogin, e.g.) in the HDFS processors, the controller service must be > restarted manually in order for the processors to execute correctly. From the > processors we should reset the HDFS resources on auth failure to simulate a > "restart" of the controller service so relogin can occur correctly. > At a minimum this includes the following processors: > FetchHDFS > GetHDFS > GetHDFSFileInfo > PutHDFS > ListHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13015) Support Sensitive Dynamic Properties on ExecuteGroovyScript
Leon Holtmeier created NIFI-13015: - Summary: Support Sensitive Dynamic Properties on ExecuteGroovyScript Key: NIFI-13015 URL: https://issues.apache.org/jira/browse/NIFI-13015 Project: Apache NiFi Issue Type: Improvement Reporter: Leon Holtmeier The ExecuteGroovyScript processor does not currently support sensitive dynamic properties but ExecuteScript does. Sensitive Dynamic Properties should be enabled in ExecuteGroovyScript aswell. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-10977 Add documentation on Kubernetes Clustering [nifi]
pvillard31 commented on code in PR #8612: URL: https://github.com/apache/nifi/pull/8612#discussion_r1557309101 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -2569,21 +2625,29 @@ If `CreatorOnly` is specified, then only the user that created the data is allow In order to use the `CreatorOnly` option, NiFi must provide some form of authentication. See the <> section below for more information on how to configure authentication. -If NiFi is configured to run in a standalone mode, the `cluster-provider` element need not be populated in the _state-management.xml_ -file and will actually be ignored if they are populated. However, the `local-provider` element must always be present and populated. -Additionally, if NiFi is run in a cluster, each node must also have the `cluster-provider` element present and properly configured. -Otherwise, NiFi will fail to startup. + Kubernetes ConfigMap Cluster State Provider -While there are not many properties that need to be configured for these providers, they were externalized into a separate _state-management.xml_ -file, rather than being configured via the _nifi.properties_ file, simply because different implementations may require different properties, -and it is easier to maintain and understand the configuration in an XML-based file such as this, than to mix the properties of the Provider -in with all of the other NiFi framework-specific properties. +The Kubernetes ConfigMap State Provider supports shared cluster state when running in Kubernetes. -It should be noted that if Processors and other components save state using the Clustered scope, the Local State Provider will be used -if the instance is a standalone instance (not in a cluster) or is disconnected from the cluster. This also means that if a standalone instance -is migrated to become a cluster, then that state will no longer be available, as the component will begin using the Clustered State Provider -instead of the Local State Provider. +The provider stores component state in +link:https://kubernetes.io/docs/concepts/configuration/configmap/[Kubernetes ConfigMaps] Review Comment: I know this is indicated in the page that is linked here but we may want to also add the below note in our documentation as well: > Note: A ConfigMap is not designed to hold large chunks of data. The data stored in a ConfigMap cannot exceed 1 MiB. If you need to store settings that are larger than this limit, you may want to consider mounting a volume or use a separate database or file service. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12844) JASN1Reader does not recognize record
[ https://issues.apache.org/jira/browse/NIFI-12844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835320#comment-17835320 ] Josef Zahner commented on NIFI-12844: - [~tpalfy] could you support us here? > JASN1Reader does not recognize record > - > > Key: NIFI-12844 > URL: https://issues.apache.org/jira/browse/NIFI-12844 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.2 >Reporter: Beat Fuellemann >Priority: Major > Attachments: Bildschirmfoto 2024-02-26 um 17.52.01.png, > Bildschirmfoto 2024-02-26 um 17.52.17.png, > ReadLocalFile_with_JASN1Reader.png, SingleASN1Packet_Printscreen.png, > TS33128IdentityAssociation.asn, keepalive.asn > > > We would like to use NIFI 1.23.2 ListenTCPRecord Processor to read ASN1 > stream. Unfortunately NIFI does not recognize any records. > Is there a bug or do I something wrong ? > Attached you can find a testfile with 3 Packets I receive via ASN1. Attached > are also the ASN1 Schema and some printscreens from my configuration. > [~tpalfy] : Maybe you could help here ? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13014) Remove unused Calcite Avatica Versions from Code Coverage Module
[ https://issues.apache.org/jira/browse/NIFI-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-13014: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove unused Calcite Avatica Versions from Code Coverage Module > > > Key: NIFI-13014 > URL: https://issues.apache.org/jira/browse/NIFI-13014 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > The nifi-code-coverage module includes several dependency version > declarations to ensure version resolution aligns with runtime versions. > Following the removal of Hive 3 components, the version references for > Calcite Avatica can be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13014) Remove unused Calcite Avatica Versions from Code Coverage Module
[ https://issues.apache.org/jira/browse/NIFI-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835291#comment-17835291 ] ASF subversion and git services commented on NIFI-13014: Commit 63fc1aecebd6bff7478f102b6fcc489d8018bebe in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=63fc1aeceb ] NIFI-13014 Remove unused Avatica versions from code-coverage This closes #8615. Signed-off-by: Peter Turcsanyi > Remove unused Calcite Avatica Versions from Code Coverage Module > > > Key: NIFI-13014 > URL: https://issues.apache.org/jira/browse/NIFI-13014 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The nifi-code-coverage module includes several dependency version > declarations to ensure version resolution aligns with runtime versions. > Following the removal of Hive 3 components, the version references for > Calcite Avatica can be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13014 Remove unused Avatica versions from code-coverage [nifi]
asfgit closed pull request #8615: NIFI-13014 Remove unused Avatica versions from code-coverage URL: https://github.com/apache/nifi/pull/8615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
