Re: [PR] NIFI-13084 Backport Allow disabling scientific notation when writing … [nifi]
pvillard31 commented on code in PR #8686:
URL: https://github.com/apache/nifi/pull/8686#discussion_r1575552519
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/WriteJsonResult.java:
##
@@ -48,9 +49,14 @@
import java.util.Map;
import java.util.Optional;
import java.util.Set;
+
+import java.util.regex.Pattern;
import java.util.function.Supplier;
public class WriteJsonResult extends AbstractRecordSetWriter implements
RecordSetWriter, RawRecordWriter {
+//private static final FieldConverter
STRING_FIELD_CONVERTER =
StandardFieldConverterRegistry.getRegistry().getFieldConverter(String.class);
Review Comment:
is it expected to have this line as a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13086 - set jest maxWorkers to 50% for maven builds to alleviate some resource contention [nifi]
mcgilman commented on PR #8689: URL: https://github.com/apache/nifi/pull/8689#issuecomment-2071098158 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12990] close enable/disable CS dialog when go to is clicked [nifi]
mcgilman commented on PR #8690: URL: https://github.com/apache/nifi/pull/8690#issuecomment-2071097876 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12873) Time inputs don't match dark mode styling
[ https://issues.apache.org/jira/browse/NIFI-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839880#comment-17839880 ] Scott Aslan commented on NIFI-12873: I don't see any way to style these browser specific time input elements... > Time inputs don't match dark mode styling > - > > Key: NIFI-12873 > URL: https://issues.apache.org/jira/browse/NIFI-12873 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: James Elliott >Priority: Major > Attachments: Screenshot 2024-03-07 at 11.20.29 AM.png, Screenshot > 2024-03-19 at 10.40.32 AM.png, Screenshot 2024-03-19 at 10.40.42 AM.png > > > Inputs with type="time" get an icon that launches a time selection popup. > Unfortunately the icon is always dark, even in dark mode. The popup doesn't > have styling applied either. > !Screenshot 2024-03-07 at 11.20.29 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt resolved NIFI-12986.
-
Resolution: Fixed
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12986 Remove depreciation warning from ProcessSession.commit [nifi]
asfgit closed pull request #8683: NIFI-12986 Remove depreciation warning from ProcessSession.commit URL: https://github.com/apache/nifi/pull/8683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839875#comment-17839875
]
ASF subversion and git services commented on NIFI-12986:
Commit 49862d5342f5641f49ff1c2493259dd9628d92c2 in nifi's branch
refs/heads/main from Lucas
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=49862d5342 ]
NIFI-12986 Remove depreciation warning from ProcessSession.commit
Explain advantage of commitAsync in ProcessSession
This closes #8683
Signed-off-by: Joseph Witt
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13087) Referencing Components not accurate linked to Parameter using in Advanced Rules for UpdateAttribute
Mark Bean created NIFI-13087:
Summary: Referencing Components not accurate linked to Parameter
using in Advanced Rules for UpdateAttribute
Key: NIFI-13087
URL: https://issues.apache.org/jira/browse/NIFI-13087
Project: Apache NiFi
Issue Type: Bug
Reporter: Mark Bean
Parameters may be used in Advanced Rules of the UpdateAttribute processor. For
example, a condition value may be something like:
${#\{param1}:equals("value-for-param1")}
When this is used, the UpdateAttribute processor is not accurately shown as a
Referencing Component to the parameter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13085) Default Mode to Formatted when viewing content
[ https://issues.apache.org/jira/browse/NIFI-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13085: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Default Mode to Formatted when viewing content > -- > > Key: NIFI-13085 > URL: https://issues.apache.org/jira/browse/NIFI-13085 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When viewing content the UI should default the mode to formatted by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13085) Default Mode to Formatted when viewing content
[ https://issues.apache.org/jira/browse/NIFI-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839872#comment-17839872 ] ASF subversion and git services commented on NIFI-13085: Commit 7c5e6b9e14c8ffef1dc2a2e24a5f2893737a6506 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7c5e6b9e14 ] NIFI-13085: (#8687) - When viewing content, defaulting the Mode to 'Formatted'. This closes #8687 > Default Mode to Formatted when viewing content > -- > > Key: NIFI-13085 > URL: https://issues.apache.org/jira/browse/NIFI-13085 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When viewing content the UI should default the mode to formatted by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13085: When viewing content, defaulting the Mode to 'Formatted' [nifi]
scottyaslan merged PR #8687: URL: https://github.com/apache/nifi/pull/8687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12990) BUG - enable CS dialog does not close when go to parameter provider
[ https://issues.apache.org/jira/browse/NIFI-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12990: --- Status: Patch Available (was: In Progress) > BUG - enable CS dialog does not close when go to parameter provider > --- > > Key: NIFI-12990 > URL: https://issues.apache.org/jira/browse/NIFI-12990 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image-2024-04-01-21-38-39-843.png > > Time Spent: 10m > Remaining Estimate: 0h > > !image-2024-04-01-21-38-39-843.png|width=691,height=464! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-12990] close enable/disable CS dialog when go to is clicked [nifi]
scottyaslan opened a new pull request, #8690: URL: https://github.com/apache/nifi/pull/8690 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12990) BUG - enable CS dialog does not close when go to parameter provider
[ https://issues.apache.org/jira/browse/NIFI-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-12990: -- Assignee: Scott Aslan > BUG - enable CS dialog does not close when go to parameter provider > --- > > Key: NIFI-12990 > URL: https://issues.apache.org/jira/browse/NIFI-12990 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image-2024-04-01-21-38-39-843.png > > > !image-2024-04-01-21-38-39-843.png|width=691,height=464! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12990) BUG - enable CS dialog does not close when go to parameter provider
[ https://issues.apache.org/jira/browse/NIFI-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12990: --- Description: !image-2024-04-01-21-38-39-843.png|width=691,height=464! (was: !image-2024-04-01-21-38-39-843.png!) > BUG - enable CS dialog does not close when go to parameter provider > --- > > Key: NIFI-12990 > URL: https://issues.apache.org/jira/browse/NIFI-12990 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: image-2024-04-01-21-38-39-843.png > > > !image-2024-04-01-21-38-39-843.png|width=691,height=464! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13086) Set maxWorkers for jest tests
[ https://issues.apache.org/jira/browse/NIFI-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13086: --- Status: Patch Available (was: In Progress) > Set maxWorkers for jest tests > - > > Key: NIFI-13086 > URL: https://issues.apache.org/jira/browse/NIFI-13086 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13051) UI - update dialog action buttons to be 'Add' for create and 'Apply' for update
[ https://issues.apache.org/jira/browse/NIFI-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13051: --- Status: Patch Available (was: In Progress) > UI - update dialog action buttons to be 'Add' for create and 'Apply' for > update > --- > > Key: NIFI-13051 > URL: https://issues.apache.org/jira/browse/NIFI-13051 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13051] update dialog action buttons [nifi]
scottyaslan opened a new pull request, #8688: URL: https://github.com/apache/nifi/pull/8688 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13051) UI - update dialog action buttons to be 'Add' for create and 'Apply' for update
[ https://issues.apache.org/jira/browse/NIFI-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13051: -- Assignee: Scott Aslan > UI - update dialog action buttons to be 'Add' for create and 'Apply' for > update > --- > > Key: NIFI-13051 > URL: https://issues.apache.org/jira/browse/NIFI-13051 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13086) Set maxWorkers for jest tests
Rob Fellows created NIFI-13086: -- Summary: Set maxWorkers for jest tests Key: NIFI-13086 URL: https://issues.apache.org/jira/browse/NIFI-13086 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13085) Default Mode to Formatted when viewing content
[ https://issues.apache.org/jira/browse/NIFI-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13085: --- Status: Patch Available (was: In Progress) > Default Mode to Formatted when viewing content > -- > > Key: NIFI-13085 > URL: https://issues.apache.org/jira/browse/NIFI-13085 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When viewing content the UI should default the mode to formatted by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13085) Default Mode to Formatted when viewing content
Matt Gilman created NIFI-13085: -- Summary: Default Mode to Formatted when viewing content Key: NIFI-13085 URL: https://issues.apache.org/jira/browse/NIFI-13085 Project: Apache NiFi Issue Type: Improvement Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman When viewing content the UI should default the mode to formatted by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13081) Support Label Configuration
[ https://issues.apache.org/jira/browse/NIFI-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839835#comment-17839835 ] ASF subversion and git services commented on NIFI-13081: Commit 830b7443d5f311413658b0453a80db4bff92d918 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=830b7443d5 ] NIFI-13081: Adding support to edit a label (#8681) * NIFI-13081: - Adding support to edit a label. * NIFI-13081: - Fixing lint issues. This closes #8681 > Support Label Configuration > --- > > Key: NIFI-13081 > URL: https://issues.apache.org/jira/browse/NIFI-13081 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Allow labels to be configured. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13081) Support Label Configuration
[ https://issues.apache.org/jira/browse/NIFI-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13081: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Support Label Configuration > --- > > Key: NIFI-13081 > URL: https://issues.apache.org/jira/browse/NIFI-13081 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Allow labels to be configured. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13081: Adding support to edit a label [nifi]
scottyaslan merged PR #8681: URL: https://github.com/apache/nifi/pull/8681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13083) [BUG] cannot add sensitive parameter
[ https://issues.apache.org/jira/browse/NIFI-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839830#comment-17839830 ] ASF subversion and git services commented on NIFI-13083: Commit 72a3529718118d0a90070b53250d8bfae76598d8 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=72a3529718 ] NIFI-13083: (#8684) - Fixing import preventing the dialog from warning the user that they must apply changes before deleting/adding the same parameter with different sensitivities. - Allowing the sensitivity to change when deleting/adding the same parameter as long as it hasn't been saved yet. - Adding the Parameters context menu item for Process Groups. > [BUG] cannot add sensitive parameter > > > Key: NIFI-13083 > URL: https://issues.apache.org/jira/browse/NIFI-13083 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > If the user edits a parameter context, creates a non-sensitive parameter then > deletes it before applying the changes. Now the user attempts to re-add the > same parameter but this time selects for the parameter to be sensitive. The > new sensitive parameter is not displayed in the table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13083) [BUG] cannot add sensitive parameter
[ https://issues.apache.org/jira/browse/NIFI-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13083: --- Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] cannot add sensitive parameter > > > Key: NIFI-13083 > URL: https://issues.apache.org/jira/browse/NIFI-13083 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > If the user edits a parameter context, creates a non-sensitive parameter then > deletes it before applying the changes. Now the user attempts to re-add the > same parameter but this time selects for the parameter to be sensitive. The > new sensitive parameter is not displayed in the table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13083: Parameter sensitivity issue when deleting and re-adding [nifi]
scottyaslan merged PR #8684: URL: https://github.com/apache/nifi/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13083: Parameter sensitivity issue when deleting and re-adding [nifi]
scottyaslan commented on PR #8684: URL: https://github.com/apache/nifi/pull/8684#issuecomment-2070786872 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13084 Backport Allow disabling scientific notation when writing … [nifi]
krisztina-zsihovszki opened a new pull request, #8686: URL: https://github.com/apache/nifi/pull/8686 # Summary [NIFI-13084](https://issues.apache.org/jira/browse/NIFI-13084) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `support/nifi-1.x` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x ] JDK 8 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
rfellows commented on PR #8663: URL: https://github.com/apache/nifi/pull/8663#issuecomment-2070527836 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13081: Adding support to edit a label [nifi]
scottyaslan commented on PR #8681: URL: https://github.com/apache/nifi/pull/8681#issuecomment-2070517002 Can you please run prettier? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13074) Reset lineage transform
[ https://issues.apache.org/jira/browse/NIFI-13074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839810#comment-17839810 ] ASF subversion and git services commented on NIFI-13074: Commit 90506823e1848b41e800ea9330fdd99016f85d36 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=90506823e1 ] NIFI-13074: Resetting the transform when navigating from the lineage to the event listing (#8678) * NIFI-13074: - Resetting the transform when navigating from the lineage to the event listing. * NIFI-13074: - Fixing lint issues. This closes #8678 > Reset lineage transform > --- > > Key: NIFI-13074 > URL: https://issues.apache.org/jira/browse/NIFI-13074 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > When navigating from the lineage graph to the provenance event listing the > transform needs to be reset otherwise the previous translation and zoom > levels will be retained when the next graph is opened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13074) Reset lineage transform
[ https://issues.apache.org/jira/browse/NIFI-13074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13074: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Reset lineage transform > --- > > Key: NIFI-13074 > URL: https://issues.apache.org/jira/browse/NIFI-13074 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > When navigating from the lineage graph to the provenance event listing the > transform needs to be reset otherwise the previous translation and zoom > levels will be retained when the next graph is opened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13074: Resetting the transform when navigating from the lineage to the event listing [nifi]
scottyaslan merged PR #8678: URL: https://github.com/apache/nifi/pull/8678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13074: Resetting the transform when navigating from the lineage to the event listing [nifi]
scottyaslan commented on PR #8678: URL: https://github.com/apache/nifi/pull/8678#issuecomment-2070472023 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13054) Tooltip Improvements
[ https://issues.apache.org/jira/browse/NIFI-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13054: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Tooltip Improvements > > > Key: NIFI-13054 > URL: https://issues.apache.org/jira/browse/NIFI-13054 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 50m > Remaining Estimate: 0h > > Fix z-index issue with tooltips that hover over buttons. Currently the button > text is above the tooltip tip. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13053] Cluster page [nifi]
mcgilman commented on PR #8685: URL: https://github.com/apache/nifi/pull/8685#issuecomment-2070470305 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13054: Restoring Property Editor popups that provide EL Function documentation and Parameter descriptions [nifi]
scottyaslan merged PR #8676: URL: https://github.com/apache/nifi/pull/8676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13054) Tooltip Improvements
[ https://issues.apache.org/jira/browse/NIFI-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839805#comment-17839805 ] ASF subversion and git services commented on NIFI-13054: Commit 2af2a3956ef92a214bc40ac5f9874a93d86852ad in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2af2a3956e ] NIFI-13054: (#8676) - Restoring Property Editor popups that provide EL Function documentation and Parameter descriptions. This closes #8676 > Tooltip Improvements > > > Key: NIFI-13054 > URL: https://issues.apache.org/jira/browse/NIFI-13054 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 50m > Remaining Estimate: 0h > > Fix z-index issue with tooltips that hover over buttons. Currently the button > text is above the tooltip tip. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13053] Cluster page [nifi]
rfellows opened a new pull request, #8685: URL: https://github.com/apache/nifi/pull/8685 [NIFI-13053](https://issues.apache.org/jira/browse/NIFI-13053) * New Cluster page accessible from the main menu * Listings for: * Nodes * System * JVM * FlowFile Storage * Content Storage * Provenance Storage * Versions _All table here extend a base table `ClusterTable` and leverage the same filter component. The "Storage" pages all share the same same table implementation._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13083) [BUG] cannot add sensitive parameter
[ https://issues.apache.org/jira/browse/NIFI-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13083: --- Status: Patch Available (was: In Progress) > [BUG] cannot add sensitive parameter > > > Key: NIFI-13083 > URL: https://issues.apache.org/jira/browse/NIFI-13083 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > If the user edits a parameter context, creates a non-sensitive parameter then > deletes it before applying the changes. Now the user attempts to re-add the > same parameter but this time selects for the parameter to be sensitive. The > new sensitive parameter is not displayed in the table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13083: Parameter sensitivity issue when deleting and re-adding [nifi]
mcgilman opened a new pull request, #8684: URL: https://github.com/apache/nifi/pull/8684 NIFI-13083: - Fixing import preventing the dialog from warning the user that they must apply changes before deleting/adding the same parameter with different sensitivities. - Allowing the sensitivity to change when deleting/adding the same parameter as long as it hasn't been saved yet. - Adding the Parameters context menu item for Process Groups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12986 Remove depreciation warning from ProcessSession.commit [nifi]
EndzeitBegins commented on code in PR #8683:
URL: https://github.com/apache/nifi/pull/8683#discussion_r1575136767
##
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java:
##
@@ -75,10 +75,11 @@ public interface ProcessSession {
* All FlowFiles operated on within this session must be accounted for by
transfer or removal or the commit will fail.
*
* As soon as the commit completes the session is again ready to be used.
+ *
+ * As of NiFi 1.14.0, an asynchronous API was introduced, see {@link
#commitAsync()}, {@link #commitAsync(Runnable)}, and {@link
#commitAsync(Runnable, Consumer)}.
+ * In most cases, users should prefer to use the asynchronous API. The
synchronous API is less suited for execution in different runtimes, e.g. MiNiFi
or Stateless NiFi,
+ * and may cause the dataflow in such runtimes to get stuck.
Review Comment:
Thanks for the recommendation. I applied the change you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2070333872 Squashed all the commits so any further improvements can be seen more easily. Fixed the runtime-manifest-generator output which was getting conflicting log provider implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12986 Remove depreciation warning from ProcessSession.commit [nifi]
joewitt commented on code in PR #8683:
URL: https://github.com/apache/nifi/pull/8683#discussion_r1575119122
##
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java:
##
@@ -75,10 +75,11 @@ public interface ProcessSession {
* All FlowFiles operated on within this session must be accounted for by
transfer or removal or the commit will fail.
*
* As soon as the commit completes the session is again ready to be used.
+ *
+ * As of NiFi 1.14.0, an asynchronous API was introduced, see {@link
#commitAsync()}, {@link #commitAsync(Runnable)}, and {@link
#commitAsync(Runnable, Consumer)}.
+ * In most cases, users should prefer to use the asynchronous API. The
synchronous API is less suited for execution in different runtimes, e.g. MiNiFi
or Stateless NiFi,
+ * and may cause the dataflow in such runtimes to get stuck.
Review Comment:
@EndzeitBegins The 'nifi-api' is the most definitive/canonical API we have.
We do not want to be talking about how a given method would cause things to get
stuck and if that were the case we should fix that. This is 'the api' so it
should just work. The downside of commit is that it is synchronous and
immediate. The upside of asyncCommit is that it is asynchronous meaning the
framework gets to choose the optimal time to make the commit happen.
I recommend the following phrasing be considered instead of this whole block.
See {@link #commitAsync()}, {@link #commitAsync(Runnable)}, and {@link
#commitAsync(Runnable, Consumer)}. The asynchronous session commit methods are
preferable to this commit call for most cases as it defers when the actual
commit happens to the framework so that it can optimize when the commit call
takes place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839795#comment-17839795
]
endzeit commented on NIFI-12986:
I opened [PR 8683|https://github.com/apache/nifi/pull/8683] addressing the
deprecation notice.
For now, I've kept the paragraph style in unison with the other paragraphs in
the file.
I would like to address the paragraph formatting in a separate issue / PR, so
we can get this merged to main quickly and don't block release work.
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12986 Remove depreciation warning from ProcessSession.commit [nifi]
EndzeitBegins opened a new pull request, #8683: URL: https://github.com/apache/nifi/pull/8683 # Summary Removes deprecation notice as discussed in issue [NIFI-12986](https://issues.apache.org/jira/browse/NIFI-12986). # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13083) [BUG] cannot add sensitive parameter
[ https://issues.apache.org/jira/browse/NIFI-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13083: -- Assignee: Matt Gilman > [BUG] cannot add sensitive parameter > > > Key: NIFI-13083 > URL: https://issues.apache.org/jira/browse/NIFI-13083 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > > If the user edits a parameter context, creates a non-sensitive parameter then > deletes it before applying the changes. Now the user attempts to re-add the > same parameter but this time selects for the parameter to be sensitive. The > new sensitive parameter is not displayed in the table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2295 Add controller service support for NiFi python processors [nifi-minifi-cpp]
szaszm commented on code in PR #1762:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1762#discussion_r1575079441
##
extensions/python/PYTHON.md:
##
@@ -102,10 +102,12 @@ NON_BLANK = 5
PORT = 6
```
+The last parameter of addProperty is the controller service type. If the
property is a controller service, the controller service type should be
provided. It should be the non-qualified type name of the controller service.
Currently SSLContextService is the only controller service type supported.
+
```python
def onInitialize(processor):
processor.setSupportsDynamicProperties()
- processor.addProperty("property name","description","default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/)
+ processor.addProperty("property name", "description", "default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/, None /*controller service type name*/)
Review Comment:
These `/**/` style comments are not valid python. I'm assuming this comes
from the NiFi Python API. Otherwise I'd consider changing to keyword arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12973 Add Process Group scope to Flow Analysis rules [nifi]
tpalfy opened a new pull request, #8682: URL: https://github.com/apache/nifi/pull/8682 # Summary [NIFI-12973](https://issues.apache.org/jira/browse/NIFI-12973) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13081) Support Label Configuration
[ https://issues.apache.org/jira/browse/NIFI-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13081: --- Status: Patch Available (was: In Progress) > Support Label Configuration > --- > > Key: NIFI-13081 > URL: https://issues.apache.org/jira/browse/NIFI-13081 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Allow labels to be configured. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13081: Adding support to edit a label [nifi]
mcgilman opened a new pull request, #8681: URL: https://github.com/apache/nifi/pull/8681 NIFI-13081: - Adding support to edit a label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839790#comment-17839790
]
Joe Witt commented on NIFI-12986:
-
[~EndzeitBegins][~exceptionfactory] It is important to undo the heart of the
change which is declaring this thing deprecated. Subsequent
discussion/follow-up can happen in another JIRA. But we need to keep main
shippable and right now we're declaring something deprecated we don't intend to
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-5519) Allow ListDatabaseTables to accept incoming connections
[ https://issues.apache.org/jira/browse/NIFI-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-5519. Resolution: Won't Fix I think that's why this Jira has sat around for so long, most ListXYZ processors are true source processors because they mostly deal with filesystems which are hierarchical and can be recursed for a single overall resource (top-level folder, etc.) Although databases tend to be less hierarchical, I think between the Category, Schema, and Table Name properties being able to match on wildcards, we can cover all tables for a single overall resource (the top-level database). The usual convention is to have multiple instances of the processor for each top-level resource (i.e. database connection). Having said that, if we want to leverage ControllerServiceLookups to allow a single instance to perform more diverse "work", we may want to look at another set of processors that better support swapping out controller services based on attribute values. > Allow ListDatabaseTables to accept incoming connections > --- > > Key: NIFI-5519 > URL: https://issues.apache.org/jira/browse/NIFI-5519 > Project: Apache NiFi > Issue Type: Wish >Reporter: Matt Burgess >Assignee: Jim Steinebrey >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > As of [NIFI-5229|https://issues.apache.org/jira/browse/NIFI-5229], > DBCPConnectionPoolLookup allows the dynamic selection of a DBCPConnectionPool > by name. This allows processors who are to perform the same work on multiple > databases to be able to do so by providing individual flow files upstream > with the database.name attribute set. > However ListDatabaseTables does not accept incoming connections, so you > currently need 1 DBCPConnectionPool per database, plus 1 ListDatabaseTables > per database, each using a corresponding DBCPConnectionPool. It would be nice > if ListDatabaseTables could accept incoming connection(s), if only to provide > attributes for selecting the DBCPConnectionPool. > I propose the behavior be like other processors that can generate data with > or without an incoming connection (such as GenerateTableFetch, see > [NIFI-2881|https://issues.apache.org/jira/browse/NIFI-2881] for details). In > general that means if there is an incoming non-loop connection, it becomes > more "event-driven" in the sense that it will not execute if there is no > FlowFile on which to work. If there is no incoming connection, then it would > run as it always has, on its Run Schedule and with State Management, so as > not to re-list the same tables every time it executes. > However with an incoming connection and an available FlowFile, the behavior > could be that all tables for that database are listed, meaning that processor > state would not be updated nor queried, making it fully "event-driven". If > the tables for a database are not to be re-listed, the onus would be on the > upstream flow to not send a flow file for that database. This is not a > requirement, just a suggestion; it could be more flexible by honoring > processor state if the Refresh Interval is non-zero, but I think that adds > too much complexity for the user, for little payoff. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839770#comment-17839770
]
endzeit edited comment on NIFI-12986 at 4/22/24 4:43 PM:
-
As discussed with [~exceptionfactory], I've found both styles of paragraphs
throughout the codebase and contradictory recommendations online which is why I
opted for the less verbose option, see the conversation in the PR.
I agree with David, that I'm fine with either style as long as it's consistent.
If you prefer the closing tags I'd like to open a PR that aligns all comments
in the codebase to that style
I'm fine with removing the deprecation notice but would like to keep the
general explanation of why `asyncCommit` was introduced and should be preferred
most of the cases.
The TestRunner by defaults fails when using `commit`, but I wasn't able to
directly found the reasoning behind these changes. The comments I added was
based on information I found on the PR / ticket that introduced these changes
solely.
What are your thoughts on that?
was (Author: endzeitbegins):
As discussed with [~exceptionfactory], I've found both styles of paragraphs
throughout the codebase and contradictory recommendations online which is why I
opted for the less verbose option, see the conversation in the PR.
I agree with David, that I'm fine with either style as long as it's consistent.
If you prefer the closing tags I'd like to open a PR that aligns all comments
in the codebase to that style
I'm fine with removing the deprecation notice but would like to see the general
explanation of why `asyncCommit` was introduced and should be preferred most of
the cases.
The TestRunner by defaults fails when using `commit`, but I wasn't able to
directly found the reasoning behind these changes. The comments I added was
based on information I found on the PR / ticket that introduced these changes
solely.
What are your thoughts on that?
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12973) Add Process Group scope to Flow Analysis rules
[ https://issues.apache.org/jira/browse/NIFI-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy reassigned NIFI-12973: -- Assignee: Tamas Palfy > Add Process Group scope to Flow Analysis rules > -- > > Key: NIFI-12973 > URL: https://issues.apache.org/jira/browse/NIFI-12973 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Tamas Palfy >Priority: Major > > I think it'd be useful to have an optional property in all Flow Analysis > rules to scope a rule execution to a specific process group (and its embedded > process groups). > Most NiFi users are using NiFi in a multi tenant way and are dedicating a > process group to a given team. Different rules may apply across different > teams hence the advantage of scoping a rule to a process group (when it makes > sense for the rule). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]
jrsteinebrey closed pull request #8639: NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. URL: https://github.com/apache/nifi/pull/8639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1575046895
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/_new-canvas-item.component-theme.scss:
##
@@ -26,20 +26,18 @@
// Get the color palette from the color-config.
$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
// Get hues from palette
-$surface-darker: utils.get-surface($nifi-theme-color-config, darker);
$on-surface-highlight: utils.get-on-surface($nifi-theme-color-config,
highlight);
$on-surface-lighter: utils.get-on-surface($nifi-theme-color-config,
lighter);
-
-// Use the same logic as _navigation.component-theme.scss to determine the
bg color for hover
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'navbar');
-@if ($hover-bg) {
-// Nothing to do here, we have special color from the palette.
-} @else {
-// There was not a special value set for the navbar, so we use Angular
Material behavior.
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'default');
-}
+$is-dark: map-get($material-theme-color-config, is-dark);
Review Comment:
I have added the 'not-allowed' cursor for the disabled state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1575045577
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##
@@ -155,9 +155,9 @@ export class ControllerServiceTable {
return 'invalid fa fa-warning';
} else {
if (entity.status.runStatus === 'DISABLED') {
-return 'disabled primary-color icon icon-enable-false';
+return 'disabled on-surface-default icon icon-enable-false';
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839770#comment-17839770
]
endzeit commented on NIFI-12986:
As discussed with [~exceptionfactory], I've found both styles of paragraphs
throughout the codebase and contradictory recommendations online which is why I
opted for the less verbose option, see the conversation in the PR.
I agree with David, that I'm fine with either style as long as it's consistent.
If you prefer the closing tags I'd like to open a PR that aligns all comments
in the codebase to that style
I'm fine with removing the deprecation notice but would like to see the general
explanation of why `asyncCommit` was introduced and should be preferred most of
the cases.
The TestRunner by defaults fails when using `commit`, but I wasn't able to
directly found the reasoning behind these changes. The comments I added was
based on information I found on the PR / ticket that introduced these changes
solely.
What are your thoughts on that?
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]
mattyb149 commented on PR #8639: URL: https://github.com/apache/nifi/pull/8639#issuecomment-2070055327 I think that's why this Jira has sat around for so long, most ListXYZ processors are true source processors because they mostly deal with filesystems which are hierarchical and can be recursed for a single overall resource (top-level folder, etc.) Although databases tend to be less hierarchical, I think between the Category, Schema, and Table Name properties being able to match on wildcards, we can cover all tables for a single overall resource (the top-level database). The usual convention is to have multiple instances of the processor for each top-level resource (i.e. database connection). Having said that, if we want to leverage LookupServices to allow a single instance to perform more diverse "work", we may want to look at another set of processors that better support swapping out controller services based on attribute values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839766#comment-17839766
]
David Handermann commented on NIFI-12986:
-
Thanks for reopening this issue [~markap14], addressing that deprecation
warning is important.
On the comment formatting, it looked like a number of the comments had closing
paragraph tags, but not all of them. I'm glad to see it consistent one way or
the other.
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13084) Backport Allow Disabling Scientific Notation in JSON Writer
[
https://issues.apache.org/jira/browse/NIFI-13084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsihovszki Krisztina updated NIFI-13084:
Description: The changes made for NIFI-12697 were only committed on the 2.x
branch and not backported to the support/nifi-1.x branch. The purpose of this
ticket is to backport the code. (was: The changes made for NIFI-12697{-}{-}
were only committed on the 2.x branch and not backported to the
support/nifi-1.x branch. The purpose of this ticket is to backport the code.)
> Backport Allow Disabling Scientific Notation in JSON Writer
>
>
> Key: NIFI-13084
> URL: https://issues.apache.org/jira/browse/NIFI-13084
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Zsihovszki Krisztina
>Assignee: Zsihovszki Krisztina
>Priority: Major
>
> The changes made for NIFI-12697 were only committed on the 2.x branch and not
> backported to the support/nifi-1.x branch. The purpose of this ticket is to
> backport the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13079) Is there a roadmap for bundle persistence provider?
[ https://issues.apache.org/jira/browse/NIFI-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839763#comment-17839763 ] Pierre Villard commented on NIFI-13079: --- I think it's better to discuss this in the Slack channels or via the email thread. The short answer is that it is absolutely used. I'm actually in the process of adding a lot of things so that it's better represented in the NiFi Registry. There are currently two persistence providers (local file system and S3), I filed a PR a long time ago to support GCS but never got merged, I may refresh that PR since I'm spending time on those topics lately. > Is there a roadmap for bundle persistence provider? > --- > > Key: NIFI-13079 > URL: https://issues.apache.org/jira/browse/NIFI-13079 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Igor Milavec >Priority: Minor > > Hi! > Based on the admin and user guides, it feels to me that the current status of > bundle persistence providers is in limbo? > The functionality is there, but it is not clear how to use it. I have found > documentation about how to configure NiFi Registry and how to upload a bundle > (using curl). I'm left wondering how this affects deployment, what are the > triggers for deployment, does it support SemVer, ... > Also, I could find no future plans for this feature. Is this being used at > all and are there plans to develop/support it in the future? > > Thank you! Igor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13084) Backport Allow Disabling Scientific Notation in JSON Writer
Zsihovszki Krisztina created NIFI-13084:
---
Summary: Backport Allow Disabling Scientific Notation in JSON
Writer
Key: NIFI-13084
URL: https://issues.apache.org/jira/browse/NIFI-13084
Project: Apache NiFi
Issue Type: Improvement
Reporter: Zsihovszki Krisztina
Assignee: Zsihovszki Krisztina
The changes made for NIFI-12697{-}{-} were only committed on the 2.x branch and
not backported to the support/nifi-1.x branch. The purpose of this ticket is to
backport the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] MINIFICPP-2339 Fix sccache path in CI workflow [nifi-minifi-cpp]
lordgamez opened a new pull request, #1767: URL: https://github.com/apache/nifi-minifi-cpp/pull/1767 https://issues.apache.org/jira/browse/MINIFICPP-2339 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2339) Windows build fails in CI
[
https://issues.apache.org/jira/browse/MINIFICPP-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-2339:
-
Description:
{code:java}
2024-04-22T14:16:47.4438100Z (venv)
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap>call refreshenv
2024-04-22T14:16:48.3105662Z Refreshing environment variables from registry for
cmd.exe. Please wait...Finished..
2024-04-22T14:16:48.4076617Z
**
2024-04-22T14:16:48.4077352Z ** Visual Studio 2022 Developer Command Prompt
v17.9.6
2024-04-22T14:16:48.4078453Z ** Copyright (c) 2022 Microsoft Corporation
2024-04-22T14:16:48.4079396Z
**
2024-04-22T14:16:49.3084453Z already in venv
2024-04-22T14:16:49.5307232Z ninja: fatal: ReadFile: The handle is invalid.
2024-04-22T14:16:49.5309021Z [1/3806] Building CXX object
CMakeFiles\date-tz.dir\_deps\date_src-src\src\tz.cpp.obj
2024-04-22T14:16:49.5314897Z
2024-04-22T14:16:49.5315537Z FAILED:
CMakeFiles/date-tz.dir/_deps/date_src-src/src/tz.cpp.obj
2024-04-22T14:16:49.5322952Z
2024-04-22T14:16:49.5332972Z sccache
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\HostX64\x64\cl.exe
/nologo /TP -DAUTO_DOWNLOAD=0 -DHAS_REMOTE_API=0 -DINSTALL=.
-DMINIFI_USE_REAL_ODBC_TEST_DRIVER -DNOMINMAX -DUSE_OS_TZDB=0
-DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_WARNINGS
-external:ID:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\_deps\date_src-src\include
-external:W0 /DWIN32 /D_WINDOWS /EHsc /O2 /Ob2 /DNDEBUG -std:c++20 -MD /W3
/utf-8 /bigobj /MP /diagnostics:caret /MD /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /std:c++latest /permissive- /w /showIncludes
/FoCMakeFiles\date-tz.dir\_deps\date_src-src\src\tz.cpp.obj
/FdCMakeFiles\date-tz.dir\date-tz.pdb /FS -c
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\_deps\date_src-src\src\tz.cpp
2024-04-22T14:16:49.5338971Z CreateProcess failed: The system cannot find the
file specified.
2024-04-22T14:16:49.5653175Z Traceback (most recent call last):
2024-04-22T14:16:49.5654024Z Running Running choco install -y NASM with
noconfirm
2024-04-22T14:16:49.5666813Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\main.py", line 59, in
2024-04-22T14:16:49.5667879Z do_one_click_build(minifi_options,
package_manager)
2024-04-22T14:16:49.5669138Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\cli.py", line 56, in
do_one_click_build
2024-04-22T14:16:49.5670193Z assert do_build(minifi_options,
package_manager)
2024-04-22T14:16:49.5671278Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\cli.py", line 43, in do_build
2024-04-22T14:16:49.5672457Z res = package_manager.run_cmd(build_cmd)
2024-04-22T14:16:49.5673067Z Installation went smoothly
2024-04-22T14:16:49.5674240Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\package_manager.py", line 290,
in run_cmd
2024-04-22T14:16:49.5675499Z res = subprocess.run(f"{env_bat_path} &
{cmd}", check=True, text=True)
2024-04-22T14:16:49.5676274Z CMake command run successfully
2024-04-22T14:16:49.5677201Z File
"C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\subprocess.py", line 528, in
run
2024-04-22T14:16:49.6009040Z raise CalledProcessError(retcode, process.args,
2024-04-22T14:16:49.6011206Z subprocess.CalledProcessError: Command
'D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\build_environment.bat & cmake
--build D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build' returned non-zero exit
status 1.
2024-04-22T14:16:49.6203736Z ##[error]Process completed with exit code 1.
2024-04-22T14:16:49.6359332Z ##[group]Run actions/cache/save@v4 {code}
was:2024-04-22T14:16:47.4438100Z (venv)
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap>call refreshenv
2024-04-22T14:16:48.3105662Z Refreshing environment variables from registry for
cmd.exe. Please wait...Finished.. 2024-04-22T14:16:48.4076617Z
**
2024-04-22T14:16:48.4077352Z ** Visual Studio 2022 Developer Command Prompt
v17.9.6 2024-04-22T14:16:48.4078453Z ** Copyright (c) 2022 Microsoft
Corporation 2024-04-22T14:16:48.4079396Z
**
2024-04-22T14:16:49.3084453Z already in venv 2024-04-22T14:16:49.5307232Z
ninja: fatal: ReadFile: The handle is invalid. 2024-04-22T14:16:49.5309021Z
[1/3806] Building CXX object
CMakeFiles\date-tz.dir\_deps\date_src-src\src\tz.cpp.obj
2024-04-22T14:16:49.5314897Z 2024-04-22T14:16:49.5315537Z FAILED:
CMakeFiles/date-tz.dir/_deps/date_src-src/src/tz.cpp.obj
2024-04-22T14:16:49.5322952Z 2024-04-22T14:16:49.5332972Z sccache
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\HostX64\x64\cl.exe
/nologo /TP -DAUTO_DOWNLOAD=0 -DHAS_REMOTE_API=0 -DINSTALL=.
-DMINIFI_USE_REAL_ODBC_TEST_DRIVER -DNOMINMAX -DUSE_OS_TZDB=0
-DWIN32_LEAN_AND_MEAN
[jira] [Created] (MINIFICPP-2339) Windows build fails in CI
Gábor Gyimesi created MINIFICPP-2339:
Summary: Windows build fails in CI
Key: MINIFICPP-2339
URL: https://issues.apache.org/jira/browse/MINIFICPP-2339
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Gábor Gyimesi
Assignee: Gábor Gyimesi
2024-04-22T14:16:47.4438100Z (venv)
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap>call refreshenv
2024-04-22T14:16:48.3105662Z Refreshing environment variables from registry for
cmd.exe. Please wait...Finished.. 2024-04-22T14:16:48.4076617Z
**
2024-04-22T14:16:48.4077352Z ** Visual Studio 2022 Developer Command Prompt
v17.9.6 2024-04-22T14:16:48.4078453Z ** Copyright (c) 2022 Microsoft
Corporation 2024-04-22T14:16:48.4079396Z
**
2024-04-22T14:16:49.3084453Z already in venv 2024-04-22T14:16:49.5307232Z
ninja: fatal: ReadFile: The handle is invalid. 2024-04-22T14:16:49.5309021Z
[1/3806] Building CXX object
CMakeFiles\date-tz.dir\_deps\date_src-src\src\tz.cpp.obj
2024-04-22T14:16:49.5314897Z 2024-04-22T14:16:49.5315537Z FAILED:
CMakeFiles/date-tz.dir/_deps/date_src-src/src/tz.cpp.obj
2024-04-22T14:16:49.5322952Z 2024-04-22T14:16:49.5332972Z sccache
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\HostX64\x64\cl.exe
/nologo /TP -DAUTO_DOWNLOAD=0 -DHAS_REMOTE_API=0 -DINSTALL=.
-DMINIFI_USE_REAL_ODBC_TEST_DRIVER -DNOMINMAX -DUSE_OS_TZDB=0
-DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_WARNINGS
-external:ID:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\_deps\date_src-src\include
-external:W0 /DWIN32 /D_WINDOWS /EHsc /O2 /Ob2 /DNDEBUG -std:c++20 -MD /W3
/utf-8 /bigobj /MP /diagnostics:caret /MD /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /std:c++latest /permissive- /w /showIncludes
/FoCMakeFiles\date-tz.dir\_deps\date_src-src\src\tz.cpp.obj
/FdCMakeFiles\date-tz.dir\date-tz.pdb /FS -c
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\_deps\date_src-src\src\tz.cpp
2024-04-22T14:16:49.5338971Z CreateProcess failed: The system cannot find the
file specified. 2024-04-22T14:16:49.5653175Z Traceback (most recent call last):
2024-04-22T14:16:49.5654024Z Running Running choco install -y NASM with
noconfirm 2024-04-22T14:16:49.5666813Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\main.py", line 59, in
2024-04-22T14:16:49.5667879Z do_one_click_build(minifi_options,
package_manager) 2024-04-22T14:16:49.5669138Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\cli.py", line 56, in
do_one_click_build 2024-04-22T14:16:49.5670193Z assert do_build(minifi_options,
package_manager) 2024-04-22T14:16:49.5671278Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\cli.py", line 43, in do_build
2024-04-22T14:16:49.5672457Z res = package_manager.run_cmd(build_cmd)
2024-04-22T14:16:49.5673067Z Installation went smoothly
2024-04-22T14:16:49.5674240Z File
"D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\package_manager.py", line 290,
in run_cmd 2024-04-22T14:16:49.5675499Z res = subprocess.run(f"\{env_bat_path}
& \{cmd}", check=True, text=True) 2024-04-22T14:16:49.5676274Z CMake command
run successfully 2024-04-22T14:16:49.5677201Z File
"C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\subprocess.py", line 528, in
run 2024-04-22T14:16:49.6009040Z raise CalledProcessError(retcode,
process.args, 2024-04-22T14:16:49.6011206Z subprocess.CalledProcessError:
Command 'D:\a\nifi-minifi-cpp\nifi-minifi-cpp\bootstrap\build_environment.bat &
cmake --build D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build' returned non-zero
exit status 1. 2024-04-22T14:16:49.6203736Z ##[error]Process completed with
exit code 1. 2024-04-22T14:16:49.6359332Z ##[group]Run actions/cache/save@v4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2069925710 Will rebase for latest commit that landed on main. Will remove dependency:analyze-only from pom. It can be activated on the command line during builds whenever people need. Will restore usage of slf4j-simple where it appears safe to do so. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13076: reduce enum array allocation [nifi]
markap14 commented on PR #8679: URL: https://github.com/apache/nifi/pull/8679#issuecomment-2069853406 Thanks for the fix @sullis looks good to me. +1 merged to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13076) reduce enum array allocation in OpenTelemetry bundle
[ https://issues.apache.org/jira/browse/NIFI-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-13076. --- Fix Version/s: 2.0.0-M3 Resolution: Fixed > reduce enum array allocation in OpenTelemetry bundle > > > Key: NIFI-13076 > URL: https://issues.apache.org/jira/browse/NIFI-13076 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sean Sullivan >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > module: *nifi-opentelemetry-bundle* > > h2. Motivation > reduce enum array allocation > h2. Modifications > cache enum .values() in a static variable > h2. Additional context > [https://www.gamlor.info/wordpress/2017/08/javas-enum-values-hidden-allocations/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13076) reduce enum array allocation in OpenTelemetry bundle
[ https://issues.apache.org/jira/browse/NIFI-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839738#comment-17839738 ] ASF subversion and git services commented on NIFI-13076: Commit 31e1ce8f4cec10e291adeb31116194e6f445b751 in nifi's branch refs/heads/main from sullis [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=31e1ce8f4c ] NIFI-13076: reduce enum array allocation (#8679) > reduce enum array allocation in OpenTelemetry bundle > > > Key: NIFI-13076 > URL: https://issues.apache.org/jira/browse/NIFI-13076 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sean Sullivan >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > module: *nifi-opentelemetry-bundle* > > h2. Motivation > reduce enum array allocation > h2. Modifications > cache enum .values() in a static variable > h2. Additional context > [https://www.gamlor.info/wordpress/2017/08/javas-enum-values-hidden-allocations/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13076: reduce enum array allocation [nifi]
markap14 merged PR #8679: URL: https://github.com/apache/nifi/pull/8679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574937003
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##
@@ -155,9 +155,9 @@ export class ControllerServiceTable {
return 'invalid fa fa-warning';
} else {
if (entity.status.runStatus === 'DISABLED') {
-return 'disabled primary-color icon icon-enable-false';
+return 'disabled on-surface-default icon icon-enable-false';
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13083) [BUG] cannot add sensitive parameter
Scott Aslan created NIFI-13083: -- Summary: [BUG] cannot add sensitive parameter Key: NIFI-13083 URL: https://issues.apache.org/jira/browse/NIFI-13083 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan If the user edits a parameter context, creates a non-sensitive parameter then deletes it before applying the changes. Now the user attempts to re-add the same parameter but this time selects for the parameter to be sensitive. The new sensitive parameter is not displayed in the table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13082) New processor for splitting PCAP files
Jack Hinton created NIFI-13082: -- Summary: New processor for splitting PCAP files Key: NIFI-13082 URL: https://issues.apache.org/jira/browse/NIFI-13082 Project: Apache NiFi Issue Type: New Feature Reporter: Jack Hinton I created a processor that is used to split a flowfile containing a large PCAP file (in binary format) into smaller files, depending on the max size set by the user. Each of the resultant flowfiles contains a valid PCAP that may be used as normal. If the incoming PCAP is malformed, in the wrong format, or the incoming PCAP contains a packet that is larger than the maximum desired size, the incoming flowfile will be transferred to the 'failure' relationship and an 'error' attribute will be added to that flowfile stating the reason for failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574826578
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/_new-canvas-item.component-theme.scss:
##
@@ -26,20 +26,18 @@
// Get the color palette from the color-config.
$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
// Get hues from palette
-$surface-darker: utils.get-surface($nifi-theme-color-config, darker);
$on-surface-highlight: utils.get-on-surface($nifi-theme-color-config,
highlight);
$on-surface-lighter: utils.get-on-surface($nifi-theme-color-config,
lighter);
-
-// Use the same logic as _navigation.component-theme.scss to determine the
bg color for hover
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'navbar');
-@if ($hover-bg) {
-// Nothing to do here, we have special color from the palette.
-} @else {
-// There was not a special value set for the navbar, so we use Angular
Material behavior.
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'default');
-}
+$is-dark: map-get($material-theme-color-config, is-dark);
Review Comment:
Thanks for the review feedback @mcgilman! This is a particularly difficult
thing to get right. The issue is that we need to make sure we have enough
contrast with the navigation header background color and the draggable icons.
The fact we have a lighter primary color set as the color of the navigation
header background color basically forces us to use the opposite color. For
example, in light mode we use the 300 hue from the material palette to color
the navigation header background so we need to use the 700 hue from that same
palette to get enough contrast ration between the two:
Then we also have the hover state to consider:
As well as the disabled state which up to this point we have opted to just
use the default angular material disabled button styles which is a contrast
color with no hover state and no pointer mouse cursor:
And of course we need to consider the dark mode versions for any palette.
Here we have the nifi default dark mode theme where the navigation header
background color is the 800 hue to give enough contrast with the nifi logo so I
had to use the 200 hue (which is very light colored and similar to the contrast
colors used for the default state):
And then there is also the purple palette that I have been using as a sort
of validation that all of these color choices are making sense to be reused in
a general sense (meaning that these colors work well with a wide variety of
color palettes provided by the angular material team which means creating new
themes for nifi becomes much easier as well as maintaining the current themes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Parameter ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) **
[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839719#comment-17839719
]
Mark Payne commented on NIFI-12986:
---
This PR incorrect marks {{ProcessSession.commit()}} as being deprecated. It is
not deprecated. In the vast majority of cases, {{commitAsync()}} should be
preferred. However, there are still cases where {{commit()}} may make sense. It
is used, for example, in the Site-to-Site server, as it cannot respond to the
client until the commit has completed. Such code *could* be rewritten to use
commitAsync but currently has not. We should not be deprecating methods that we
are actively using and do not necessarily intend to stop using. Additionally,
while it is possible to rewrite in such a way that it uses commitAsync, there's
really no need to, as the synchronous commit is still a valid approach and is
more straight-forward.
Additionally, the PR changes the formatted of the methods from the syntax:
{code:java}
Documentation Paragraph 1
Documentation Paragraph 2
{code}
To a less explicit version of:
{code:java}
Documentation Paragraph 1
Documentation Paragraph 2 {code}
This should be undone, as the former formatting is preferred and is the
dominant formatting throughout the codebase. It also makes it more clear where
a paragraph begins and ends, and results in more consistent rendering of the
text, as the latter approach does not necessarily apply the same formatting as
the former.
It does look like the commit applies some additional documentation around
Exceptions that are thrown, but honestly it is difficult to say, as Github
shows it as if methods were added and removed, or parameters were changed, etc.
I think it gets confused by the change in formatting?
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13081) Support Label Configuration
Matt Gilman created NIFI-13081: -- Summary: Support Label Configuration Key: NIFI-13081 URL: https://issues.apache.org/jira/browse/NIFI-13081 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Allow labels to be configured. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13078) Support Enable/Disable Component
[ https://issues.apache.org/jira/browse/NIFI-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13078: --- Status: Patch Available (was: In Progress) > Support Enable/Disable Component > > > Key: NIFI-13078 > URL: https://issues.apache.org/jira/browse/NIFI-13078 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Add support to enable and disable components through the context menu and the > operation control. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (NIFI-12986) Tidy up JavaDoc of ProcessSession
[
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne reopened NIFI-12986:
---
Reopening Issue, as I do not believe it to be correct. Will elaborate more in a
separate comment.
> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}}
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current
> {{ProcessSession}} specification more consistent. The specified contract must
> not be altered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]
joewitt commented on PR #8639: URL: https://github.com/apache/nifi/pull/8639#issuecomment-2069658691 These components are quite widely used so in review it is important to carefully consider whether this degree of change is desirable vs new components more specific to the use case(s) intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]
jrsteinebrey commented on code in PR #8639:
URL: https://github.com/apache/nifi/pull/8639#discussion_r1574853643
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java:
##
@@ -270,24 +297,40 @@ public Set getRelationships() {
return relationships;
}
+@OnScheduled
+public void onScheduled(final ProcessContext context) {
+if (!context.hasNonLoopConnection() &&
context.hasConnection(REL_FAILURE)) {
+getLogger().error("The failure relationship can be used only if
there is a non-loop incoming connection to this processor.");
+}
+if (!context.hasNonLoopConnection() &&
!context.getExecutionNode().equals(ExecutionNode.PRIMARY)) {
+getLogger().error("If this processor has no incoming connection,
then it should be run on Primary Node only.");
+}
+}
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
session) throws ProcessException {
+FlowFile fileToProcess = null;
+if (context.hasIncomingConnection()) {
+fileToProcess = session.get();
+
+if (context.hasNonLoopConnection() && fileToProcess == null) {
+// Incoming non-loop connection has no FlowFile available, do
no work (see capability description)
+// hasNonLoopConnection() protects from blocked execution when
failure loops back to self and there is no other incoming connection.
+return;
+}
+}
+
final ComponentLog logger = getLogger();
final DBCPService dbcpService =
context.getProperty(DBCP_SERVICE).asControllerService(DBCPService.class);
-final String catalog = context.getProperty(CATALOG).getValue();
-final String schemaPattern =
context.getProperty(SCHEMA_PATTERN).getValue();
-final String tableNamePattern =
context.getProperty(TABLE_NAME_PATTERN).getValue();
-final String[] tableTypes = context.getProperty(TABLE_TYPES).isSet()
-?
context.getProperty(TABLE_TYPES).getValue().split("\\s*,\\s*")
-: null;
-final boolean includeCount =
context.getProperty(INCLUDE_COUNT).asBoolean();
-final long refreshInterval =
context.getProperty(REFRESH_INTERVAL).asTimePeriod(TimeUnit.MILLISECONDS);
+// Do not track refresh times if incoming flow file is non-null since
FF causes relisting table names every time
+final boolean isRefreshTracked = fileToProcess == null;
+final long refreshInterval = !isRefreshTracked ? 0 :
context.getProperty(REFRESH_INTERVAL).asTimePeriod(TimeUnit.MILLISECONDS);
final StateMap stateMap;
final Map stateMapProperties;
try {
-stateMap = session.getState(Scope.CLUSTER);
-stateMapProperties = new HashMap<>(stateMap.toMap());
+stateMap = !isRefreshTracked ? null :
session.getState(Scope.CLUSTER);
+stateMapProperties = !isRefreshTracked ? null : new
HashMap<>(stateMap.toMap());
Review Comment:
I make the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574851802
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/editors/nf-editor/_nf-editor.component-theme.scss:
##
@@ -31,17 +31,21 @@
// Get hues from palette
$material-theme-primary-palette-lighter:
mat.get-color-from-palette($material-theme-primary-palette, lighter);
$material-theme-primary-palette-default:
mat.get-color-from-palette($material-theme-primary-palette, default);
-$nifi-theme-surface-palette-400-contrast:
mat.get-color-from-palette($nifi-theme-surface-palette, '400-contrast');
+$nifi-theme-surface-palette-default-contrast: mat.get-color-from-palette(
+$nifi-theme-surface-palette,
+'default-contrast'
+);
$nifi-theme-surface-palette-default:
mat.get-color-from-palette($nifi-theme-surface-palette, default);
-$surface: utils.get-surface($nifi-theme-color-config);
+$nifi-theme-surface-palette-lighter:
mat.get-color-from-palette($nifi-theme-surface-palette, 'lighter');
$on-surface: utils.get-on-surface($nifi-theme-color-config);
+$on-surface-lighter: utils.get-on-surface($nifi-theme-color-config,
lighter);
.property-editor {
@include mat.button-density(-1);
.nf-editor {
.CodeMirror {
-background-color: $surface;
+background-color: $nifi-theme-surface-palette-lighter;
Review Comment:
We absolutely can! I have pushed some updates here in my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13080) nifi-properties and nifi-property-utils should not be part of the public api of nifi extensions such as processors, controller services and reporting tasks
Joe Witt created NIFI-13080: --- Summary: nifi-properties and nifi-property-utils should not be part of the public api of nifi extensions such as processors, controller services and reporting tasks Key: NIFI-13080 URL: https://issues.apache.org/jira/browse/NIFI-13080 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt After the great refactor of NIFI-12998 a few scenarios emerged that we should resolve. The bom/parents for NiFi extensions such as nifi-extension-bundles should enforce that a pom should not have a declared dependency on nifi-properties and nifi-property-utils. nifi-property-utils has extensive usage today due to a StringUtils class. The purpose of that StringUtils class seems to be to have a very lightweight copy of things often found in commons-lang3 but when we don't want to pull in that dependency to every module. It isn't clear how valuable that is at this point and it is worth review. But either way StringUtils of nifi-property-utils does not seem like it should be a thing or should not be where it is. The handful of remaining 'nifi-extension-bundle modules that do use NiFiProperties are extensions which also don't really belong in the nifi-extension-bundle module but instead should be in a 'nifi-framework-extensions' bundle module as these are things which are more like framework extensions that the public/intentional components of processors, controller services, and reporting tasks and these framework focused extensions have different obligations/accesses such as NiFiProperties being totally fair game. But for a processor to depend on NIFi properties is a 'config/user experience smell' -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574840795
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##
@@ -155,9 +155,9 @@ export class ControllerServiceTable {
return 'invalid fa fa-warning';
} else {
if (entity.status.runStatus === 'DISABLED') {
-return 'disabled primary-color icon icon-enable-false';
+return 'disabled on-surface-default icon icon-enable-false';
Review Comment:
Do you have a screen shot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574826578
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/_new-canvas-item.component-theme.scss:
##
@@ -26,20 +26,18 @@
// Get the color palette from the color-config.
$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
// Get hues from palette
-$surface-darker: utils.get-surface($nifi-theme-color-config, darker);
$on-surface-highlight: utils.get-on-surface($nifi-theme-color-config,
highlight);
$on-surface-lighter: utils.get-on-surface($nifi-theme-color-config,
lighter);
-
-// Use the same logic as _navigation.component-theme.scss to determine the
bg color for hover
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'navbar');
-@if ($hover-bg) {
-// Nothing to do here, we have special color from the palette.
-} @else {
-// There was not a special value set for the navbar, so we use Angular
Material behavior.
-$hover-bg: mat.get-color-from-palette($material-theme-primary-palette,
'default');
-}
+$is-dark: map-get($material-theme-color-config, is-dark);
Review Comment:
Thanks for the review feedback @mcgilman! This is a particularly difficult
thing to get right. The issue is that we need to make sure we have enough
contrast with the navigation header background color and the draggable icons.
The fact we have a lighter primary color set as the color of the navigation
header background color basically forces us to use the opposite color. For
example, in light mode we use the 300 hue from the material palette to color
the navigation header background so we need to use the 700 hue from that same
palette to get enough contrast ration between the two:
Then we also have the hover state to consider:
As well as the disabled state which up to this point we have opted to just
use the default angular material disabled button styles which is a contrast
color with no hover state and no pointer mouse cursor:
And of course we need to consider the dark mode versions for any palette:
And then there is also the purple palette that I have been using as a sort
of validation that all of these color choices are making sense to be reused in
a general sense (meaning that these colors work well with a wide variety of
color palettes provided by the angular material team which means creating new
themes for nifi becomes much easier as well as maintaining the current themes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-2338) Move ExecuteProcess out of standard processors
Martin Zink created MINIFICPP-2338: -- Summary: Move ExecuteProcess out of standard processors Key: MINIFICPP-2338 URL: https://issues.apache.org/jira/browse/MINIFICPP-2338 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Martin Zink Assignee: Martin Zink -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13079) Is there a roadmap for bundle persistence provider?
Igor Milavec created NIFI-13079: --- Summary: Is there a roadmap for bundle persistence provider? Key: NIFI-13079 URL: https://issues.apache.org/jira/browse/NIFI-13079 Project: Apache NiFi Issue Type: Improvement Reporter: Igor Milavec Hi! Based on the admin and user guides, it feels to me that the current status of bundle persistence providers is in limbo? The functionality is there, but it is not clear how to use it. I have found documentation about how to configure NiFi Registry and how to upload a bundle (using curl). I'm left wondering how this affects deployment, what are the triggers for deployment, does it support SemVer, ... Also, I could find no future plans for this feature. Is this being used at all and are there plans to develop/support it in the future? Thank you! Igor -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2337 Fix OpenSSL toggle in bootstrap.sh [nifi-minifi-cpp]
lordgamez commented on code in PR #1766:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1766#discussion_r1574690913
##
bootstrap.sh:
##
@@ -445,7 +445,8 @@ build_cmake_command(){
set_value=OFF
option_value="${!option}"
if { [[ "$option_value" = "${FALSE}" ]] && { [[ "$FOUND_VALUE" ==
"DISABLE"* ]] || [[ "$FOUND_VALUE" == *"OFF" ]]; }; } || \
- { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; }; then
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; } ||
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" != "ENABLE"*
]] && [[ "$FOUND_VALUE" != "DISABLE"* ]]; }; then
Review Comment:
Enabling OpenSSL is done with the MINIFI_OPENSSL option, but only the
ENABLE*/DISABLE* options were handled here, so the openssl was never set to ON
regardless of the option being toggled or not. The fix is that if an option
does not match the ENABLE*/DISABLE* patterns then it should be set to ON if the
value is set to "${TRUE}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2337 Fix OpenSSL toggle in bootstrap.sh [nifi-minifi-cpp]
lordgamez commented on code in PR #1766:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1766#discussion_r1574690913
##
bootstrap.sh:
##
@@ -445,7 +445,8 @@ build_cmake_command(){
set_value=OFF
option_value="${!option}"
if { [[ "$option_value" = "${FALSE}" ]] && { [[ "$FOUND_VALUE" ==
"DISABLE"* ]] || [[ "$FOUND_VALUE" == *"OFF" ]]; }; } || \
- { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; }; then
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; } ||
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" != "ENABLE"*
]] && [[ "$FOUND_VALUE" != "DISABLE"* ]]; }; then
Review Comment:
Enabling OpenSSL is done with the MINIFI_OPENSSL option, but only the
ENABLE*/DISABLE* options were handled here, so the openssl was never set to ON
regardless of the option being toggled or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Parameter ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary
[jira] [Updated] (NIFI-13074) Reset lineage transform
[ https://issues.apache.org/jira/browse/NIFI-13074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13074: --- Status: Patch Available (was: Open) > Reset lineage transform > --- > > Key: NIFI-13074 > URL: https://issues.apache.org/jira/browse/NIFI-13074 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When navigating from the lineage graph to the provenance event listing the > transform needs to be reset otherwise the previous translation and zoom > levels will be retained when the next graph is opened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2337 Fix OpenSSL toggle in bootstrap.sh [nifi-minifi-cpp]
szaszm commented on code in PR #1766:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1766#discussion_r1574682410
##
bootstrap.sh:
##
@@ -445,7 +445,8 @@ build_cmake_command(){
set_value=OFF
option_value="${!option}"
if { [[ "$option_value" = "${FALSE}" ]] && { [[ "$FOUND_VALUE" ==
"DISABLE"* ]] || [[ "$FOUND_VALUE" == *"OFF" ]]; }; } || \
- { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; }; then
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" == "ENABLE"*
]]; } ||
+ { [[ "$option_value" = "${TRUE}" ]] && [[ "$FOUND_VALUE" != "ENABLE"*
]] && [[ "$FOUND_VALUE" != "DISABLE"* ]]; }; then
Review Comment:
What is the problem that's fixed here? How did it not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13078) Support Enable/Disable Component
Matt Gilman created NIFI-13078: -- Summary: Support Enable/Disable Component Key: NIFI-13078 URL: https://issues.apache.org/jira/browse/NIFI-13078 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Add support to enable and disable components through the context menu and the operation control. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2337 Fix OpenSSL toggle in bootstrap.sh [nifi-minifi-cpp]
lordgamez opened a new pull request, #1766: URL: https://github.com/apache/nifi-minifi-cpp/pull/1766 https://issues.apache.org/jira/browse/MINIFICPP-2337 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2337) OpenSSL toggle does not work in bootstrap.sh
Gábor Gyimesi created MINIFICPP-2337: Summary: OpenSSL toggle does not work in bootstrap.sh Key: MINIFICPP-2337 URL: https://issues.apache.org/jira/browse/MINIFICPP-2337 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2336) Python bootstrap part 2
Gábor Gyimesi created MINIFICPP-2336: Summary: Python bootstrap part 2 Key: MINIFICPP-2336 URL: https://issues.apache.org/jira/browse/MINIFICPP-2336 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Gábor Gyimesi * separate menu for MiNiFi extension options and MiNiFi build options * save bt_state similarly to old bootstrap * add option for docker build with bootstrap * use make/msbuild generator instead of ninja * add SKIP_TESTS build option * fix the documentation ([https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1521747415]) * add libtool and automake as a dependency to most distributions -- This message was sent by Atlassian Jira (v8.20.10#820010)
