[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1501: MINIFICPP-1887 Add default connection size limits

2023-02-16 Thread via GitHub 


martinzink commented on code in PR #1501:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1501#discussion_r1108533223


##
libminifi/include/Connection.h:
##
@@ -58,8 +58,8 @@ class Connection : public core::Connectable {
   Connection(const Connection ) = delete;
   Connection =(const Connection ) = delete;
 
-  static constexpr uint64_t DEFAULT_BACKPRESSURE_SIZE_THRESHOLD = 1;
-  static constexpr uint64_t DEFAULT_BACKPRESSURE_DATA_THRESHOLD = 10_MB;
+  static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_COUNT = 1;
+  static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_DATA_SIZE = 10_MB;

Review Comment:
   based on our conversation I've modified it to 2000 / 100MB in 
https://github.com/apache/nifi-minifi-cpp/pull/1501/commits/75e3d93ddd845f30c8674ca03b4f62b2bf0faf97



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1501: MINIFICPP-1887 Add default connection size limits

2023-02-10 Thread via GitHub 


martinzink commented on code in PR #1501:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1501#discussion_r1102496393


##
libminifi/include/Connection.h:
##
@@ -52,86 +53,81 @@ class Connection : public core::Connectable {
   const utils::Identifier , const 
utils::Identifier );
   explicit Connection(std::shared_ptr flow_repository, 
std::shared_ptr content_repo, 
std::shared_ptr swap_manager,
   std::string name, const utils::Identifier& uuid);
-  // Destructor
   ~Connection() override = default;
 
-  // Set Source Processor UUID
+  Connection(const Connection ) = delete;
+  Connection =(const Connection ) = delete;
+
+  static constexpr uint64_t DEFAULT_BACKPRESSURE_SIZE_THRESHOLD = 1;
+  static constexpr uint64_t DEFAULT_BACKPRESSURE_DATA_THRESHOLD = 10_MB;

Review Comment:
   Good idea :+1: , I've renamed them in 
https://github.com/apache/nifi-minifi-cpp/pull/1501/commits/8cfacbd1bd5916c7366bbee7e6d86fa916b9d38d
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org