[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670601#comment-16670601 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/427 > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670002#comment-16670002 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229665932 --- Diff: docker/test/integration/minifi/test/__init__.py --- @@ -142,7 +147,7 @@ def check_output(self, timeout=5): self.wait_for_output(timeout) self.log_nifi_output() -return self.output_validator.validate() +return self.output_validator.validate() & ~self.segfault --- End diff -- I would much rather learn and do what is more generally appropriate for that language domain. Thanks! > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670001#comment-16670001
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229665609
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -117,12 +119,15 @@ def log_nifi_output(self):
for container in self.containers:
container = self.client.containers.get(container.id)
logging.info('Container logs for container \'%s\':\n%s',
container.name, container.logs())
+if b'Segmentation fault' in container.logs():
+self.segfault=true
--- End diff --
Thanks!
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669726#comment-16669726 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user arpadboda commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229595113 --- Diff: docker/test/integration/minifi/test/__init__.py --- @@ -142,7 +147,7 @@ def check_output(self, timeout=5): self.wait_for_output(timeout) self.log_nifi_output() -return self.output_validator.validate() +return self.output_validator.validate() & ~self.segfault --- End diff -- I have hardly seen, but the question was meant to ask what do we plan to achieve here. I just run through the code to understand what's going on here, this if fine, but using logical expressions are way more _pythonic_ to achieve the same: ``` return self.output_validator.validate() and not self.segfault ``` > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669723#comment-16669723
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229593381
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -117,12 +119,15 @@ def log_nifi_output(self):
for container in self.containers:
container = self.client.containers.get(container.id)
logging.info('Container logs for container \'%s\':\n%s',
container.name, container.logs())
+if b'Segmentation fault' in container.logs():
+self.segfault=true
--- End diff --
Actually this line is wrong, this should be True (capital 't')
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668686#comment-16668686 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229300368 --- Diff: docker/test/integration/minifi/test/__init__.py --- @@ -142,7 +147,7 @@ def check_output(self, timeout=5): self.wait_for_output(timeout) self.log_nifi_output() -return self.output_validator.validate() +return self.output_validator.validate() & ~self.segfault --- End diff -- I'm not a python developer ( first time were recent PRs ) -- after doing some reading I'm guessing the boolean operators are preferred here? It works due to autoboxing as it's a very simple expression; however, your statement "left argument is a boolean" implies that it is not common to use the bitwise operators here? > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1949#comment-1949 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user arpadboda commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228861915 --- Diff: docker/test/integration/test_zero_file.py --- @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the \"License\"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an \"AS IS\" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from minifi import * +from minifi.test import * --- End diff -- Not a big deal here, not sure about having pyling would be more gain than pain. :) > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1597#comment-1597
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228769742
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -40,21 +39,24 @@ def __init__(self, output_validator):
# Create test input/output directories
test_cluster_id = str(uuid.uuid4())
+
+self.segfault = False
self.tmp_test_output_dir = '/tmp/.nifi-test-output.' +
test_cluster_id
self.tmp_test_input_dir = '/tmp/.nifi-test-input.' +
test_cluster_id
self.tmp_test_resources_dir = '/tmp/.nifi-test-resources.' +
test_cluster_id
logging.info('Creating tmp test input dir: %s',
self.tmp_test_input_dir)
-os.makedirs(self.tmp_test_input_dir, mode=0777)
+os.makedirs(self.tmp_test_input_dir)
logging.info('Creating tmp test output dir: %s',
self.tmp_test_output_dir)
-os.makedirs(self.tmp_test_output_dir, mode=0777)
+os.makedirs(self.tmp_test_output_dir)
logging.info('Creating tmp test resource dir: %s',
self.tmp_test_resources_dir)
-os.makedirs(self.tmp_test_resources_dir, mode=0777)
+os.makedirs(self.tmp_test_resources_dir)
# Point output validator to ephemeral output dir
self.output_validator = output_validator
-output_validator.set_output_dir(self.tmp_test_output_dir)
+if isinstance(output_validator, SingleFileOutputValidator):
+ output_validator.set_output_dir(self.tmp_test_output_dir)
--- End diff --
thanks for pointing this out! ! I'll run re-indent.
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1596#comment-1596
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228769725
--- Diff: docker/test/integration/minifi/__init__.py ---
@@ -664,8 +674,8 @@ def nifi_flow_xml(connectable, nifi_version=None,
root=None, visited=None):
input_port_max_concurrent_tasks = Element('maxConcurrentTasks')
input_port_max_concurrent_tasks.text = '1'
input_port.append(input_port_max_concurrent_tasks)
-
-res.iterfind('rootGroup').next().append(input_port)
+next( res.iterfind('rootGroup') ).append(input_port)
+""" res.iterfind('rootGroup').next().append(input_port) """
--- End diff --
Yeah it created some invalid code for this. Thanks for pointing this out!
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1562#comment-1562 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228765232 --- Diff: docker/test/integration/test_zero_file.py --- @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the \"License\"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an \"AS IS\" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from minifi import * +from minifi.test import * --- End diff -- I say this because I approved the PRs that introduced this style into the integration test framework -- I think I made comment to this but we discussed that it wasn't a big deal for minifi and minifi.test to import everything. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1558#comment-1558 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228765124 --- Diff: docker/test/integration/test_zero_file.py --- @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the \"License\"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an \"AS IS\" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from minifi import * +from minifi.test import * --- End diff -- I think it's fair to afford a little leeway in the test frameworks ( as we have been ). Aside from the linter. Happy to see a pylint PR if you think that's of importance. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1546#comment-1546
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228763752
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -40,21 +39,24 @@ def __init__(self, output_validator):
# Create test input/output directories
test_cluster_id = str(uuid.uuid4())
+
+self.segfault = False
self.tmp_test_output_dir = '/tmp/.nifi-test-output.' +
test_cluster_id
self.tmp_test_input_dir = '/tmp/.nifi-test-input.' +
test_cluster_id
self.tmp_test_resources_dir = '/tmp/.nifi-test-resources.' +
test_cluster_id
logging.info('Creating tmp test input dir: %s',
self.tmp_test_input_dir)
-os.makedirs(self.tmp_test_input_dir, mode=0777)
+os.makedirs(self.tmp_test_input_dir)
logging.info('Creating tmp test output dir: %s',
self.tmp_test_output_dir)
-os.makedirs(self.tmp_test_output_dir, mode=0777)
+os.makedirs(self.tmp_test_output_dir)
logging.info('Creating tmp test resource dir: %s',
self.tmp_test_resources_dir)
-os.makedirs(self.tmp_test_resources_dir, mode=0777)
+os.makedirs(self.tmp_test_resources_dir)
# Point output validator to ephemeral output dir
self.output_validator = output_validator
-output_validator.set_output_dir(self.tmp_test_output_dir)
+if isinstance(output_validator, SingleFileOutputValidator):
+ output_validator.set_output_dir(self.tmp_test_output_dir)
--- End diff --
Indentation should be 4
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1544#comment-1544
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228763742
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -117,12 +119,15 @@ def log_nifi_output(self):
for container in self.containers:
container = self.client.containers.get(container.id)
logging.info('Container logs for container \'%s\':\n%s',
container.name, container.logs())
+if b'Segmentation fault' in container.logs():
+ self.segfault=true
--- End diff --
Indentation too deep here.
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1542#comment-1542 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user arpadboda commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228763729 --- Diff: docker/test/integration/minifi/test/__init__.py --- @@ -142,7 +147,7 @@ def check_output(self, timeout=5): self.wait_for_output(timeout) self.log_nifi_output() -return self.output_validator.validate() +return self.output_validator.validate() & ~self.segfault --- End diff -- What's the goal here? The left argument is a boolean. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1543#comment-1543 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user arpadboda commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228763680 --- Diff: docker/test/integration/test_zero_file.py --- @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the \"License\"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an \"AS IS\" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from minifi import * +from minifi.test import * --- End diff -- Import * is not recommended as it's difficult to find the source of the used symbols. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1545#comment-1545
]
ASF GitHub Bot commented on MINIFICPP-653:
--
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228763777
--- Diff: docker/test/integration/minifi/__init__.py ---
@@ -664,8 +674,8 @@ def nifi_flow_xml(connectable, nifi_version=None,
root=None, visited=None):
input_port_max_concurrent_tasks = Element('maxConcurrentTasks')
input_port_max_concurrent_tasks.text = '1'
input_port.append(input_port_max_concurrent_tasks)
-
-res.iterfind('rootGroup').next().append(input_port)
+next( res.iterfind('rootGroup') ).append(input_port)
+""" res.iterfind('rootGroup').next().append(input_port) """
--- End diff --
Guess these are meant to be removed.
> Log message will segfault client if no content produced
> ---
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664199#comment-16664199 ] ASF GitHub Bot commented on MINIFICPP-653: -- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/427 One of the docker tests fails -- currently debugging. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662947#comment-16662947 ] ASF GitHub Bot commented on MINIFICPP-653: -- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/427 MINIFICPP-653: Check if empty content, if so don't produce log messag… …e that can segfault client Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-653 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #427 commit b7b05b3fafeb7a23f6d5f1017ca2b9a6fea4bfb1 Author: Marc Parisi Date: 2018-10-23T15:51:19Z MINIFICPP-653: Check if empty content, if so don't produce log message that can segfault client > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-653) Log message will segfault client if no content produced
[ https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661551#comment-16661551 ] Mr TheSegfault commented on MINIFICPP-653: -- Changes are easy to apply and test, but i'm creating docker tests for further validation. > Log message will segfault client if no content produced > --- > > Key: MINIFICPP-653 > URL: https://issues.apache.org/jira/browse/MINIFICPP-653 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Blocker > > Log message will segfault client if no content produced -- This message was sent by Atlassian JIRA (v7.6.3#76005)
