[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129604#comment-16129604
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1968


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Fix For: 1.4.0
>
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129603#comment-16129603
 ] 

ASF subversion and git services commented on NIFI-3931:
---

Commit 9f23ec360acd2bf4d949f08b3eb0cea3decc5263 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9f23ec3 ]

NIFI-3931 - Added EL to properties in SFTP transfer

The properties are already evaluated against EL. Also added an
integration test that is failing without the change.

This closes #1968.

Signed-off-by: Koji Kawamura 


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129597#comment-16129597
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1968
  
Thanks for the update @pvillard31 , LGTM +1, merging to master!


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128880#comment-16128880
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1968
  
Hey @ijokarumawak, I agree the IT class is not really helpful, it was just 
something I used to test the changes on my side. Happy to remove this file: 
just pushed a commit for that.


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126714#comment-16126714
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user ijokarumawak commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1968#discussion_r133103658
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/SFTPIT.java
 ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.processors.standard.util.SFTPTransfer;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.Test;
+
+public class SFTPIT {
+
+// integration test for SFTP processors, will not be run by normal 
build
+
+final String hostname = "test.rebex.net";
--- End diff --

Do we really need this IT class? It does not look very helpful since it 
does not do anything more than connecting to a demo server.

Also, I'm not sure we can use test.rebex.net for our testing:
> The test.rebex.net address is used for testing of Rebex components.
https://test.rebex.net/

The change looks good, but I think we should omit this IT class.


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094771#comment-16094771
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1968
  
LGTM


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076918#comment-16076918
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user m-hogue commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1968#discussion_r125960083
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/SFTPIT.java
 ---
@@ -0,0  1,51 @@
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
  * this work for additional information regarding copyright ownership.
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
  * http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
 package org.apache.nifi.processors.standard;
 
 import org.apache.nifi.processors.standard.util.SFTPTransfer;
 import org.apache.nifi.util.TestRunner;
 import org.apache.nifi.util.TestRunners;
 import org.junit.Test;
 
 public class SFTPIT {
 
--- End diff --

Indeed. Thanks for the clarification. LGTM!


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076909#comment-16076909
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1968#discussion_r125958747
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/SFTPIT.java
 ---
@@ -0,0  1,51 @@
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
  * this work for additional information regarding copyright ownership.
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
  * http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
 package org.apache.nifi.processors.standard;
 
 import org.apache.nifi.processors.standard.util.SFTPTransfer;
 import org.apache.nifi.util.TestRunner;
 import org.apache.nifi.util.TestRunners;
 import org.junit.Test;
 
 public class SFTPIT {
 
--- End diff --

The tests executed during the builds are controlled by the surefire plugin 
definition in the top level pom file:

xml

**/*Test.class
**/Test*.class
**/*Spec.class



It should not be necessary to add ``@Ignore`` in this class. I believe the 
convention is to use IT (and to not use Test) in the class name when 
implementing integration tests.


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076886#comment-16076886
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

Github user m-hogue commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1968#discussion_r125955333
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/SFTPIT.java
 ---
@@ -0,0  1,51 @@
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
  * this work for additional information regarding copyright ownership.
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
  * http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
 package org.apache.nifi.processors.standard;
 
 import org.apache.nifi.processors.standard.util.SFTPTransfer;
 import org.apache.nifi.util.TestRunner;
 import org.apache.nifi.util.TestRunners;
 import org.junit.Test;
 
 public class SFTPIT {
 
--- End diff --

Should this be `@Ignore`d if it's not supposed to be run with the normal 
build?


> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073332#comment-16073332
 ] 

Pierre Villard commented on NIFI-3931:
--

OK, I just setup a workflow (attached to this JIRA) to try with FTP processors 
(it shares the same logic with SFTP processors) and, as of now, it cannot work: 
we are not passing the flow file when initializing the client. And that's 
actually the reason behind NIFI-3281. I will submit a PR for that.

Otherwise (once this problem is fixed), it seems to be OK regarding concurrent 
threads. Meaning: it works. BUT I don't think we are actually using concurrent 
threads: it's using concurrent threads but each thread will wait for previous 
thread completion before fetching data. But I believe that's the case with or 
without expression language... After fetching a file we are doing:

{code}
client.changeWorkingDirectory(homeDirectory);
{code}

And I believe this command in synchronous, previous commands have to be 
completed before this can be actually executed.
I guess, we should add {{@TriggerSerially}} to reflect that. Thoughts?

Also if we are fetching data from the same server but on different ports, it 
would be an issue since we won't recreate a client (we are just checking if the 
remote server is changing) but it sounds unlikely to me, no? Although it would 
be a fairly easy change.

> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072453#comment-16072453
 ] 

Pierre Villard commented on NIFI-3931:
--

You're right [~joewitt], that something to look into. After a quick glance I 
see, both in FTP and SFTP processors, the following logic:

=> SFTP processors
{code}
if (sftp != null) {
String sessionhost = session.getHost();
String desthost = 
ctx.getProperty(HOSTNAME).evaluateAttributeExpressions(flowFile).getValue();
if (sessionhost.equals(desthost)) {
// destination matches so we can keep our current session
return sftp;
} else {
// this flowFile is going to a different destination, reset 
session
close();
}
}
{code}

=> FTP processors
{code}
if (client != null) {
String desthost = 
ctx.getProperty(HOSTNAME).evaluateAttributeExpressions(flowFile).getValue();
if (remoteHostName.equals(desthost)) {
// destination matches so we can keep our current session
resetWorkingDirectory();
return client;
} else {
// this flowFile is going to a different destination, reset 
session
close();
}
}
{code}

But in case we are using multiple threads, we probably face some issues. Will 
try to run some tests.
And in terms of performances, re-creating a client for, potentially, each flow 
file, is not great.
That could certainly be improved with some kind of clients pool.

> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071863#comment-16071863
 ] 

Joseph Witt commented on NIFI-3931:
---

[~pvillard] I dont think it is this PR that caused it but I do suspect this 
processor now has a pretty important bug.  By enabling expression language 
support, and on a per flowfile basis, i dont think we're handling connections 
properly now.  What if there are multiple threads sending flowfiles and each 
wants a different host/port/server/password/etc..  Are we setting up/tearing 
down those properly?  This processor did not enable expression language or at 
the very least didn't have it support flowfile seeded expression language 
because the connection handling/efficiency would require a good bit of work.  
I've not personally confirmed this suspicion yet so I could be wrong. But we 
should definitely look into that.

> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Assignee: Pierre Villard
>Priority: Minor
>  Labels: easyfix
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071633#comment-16071633
 ] 

ASF GitHub Bot commented on NIFI-3931:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1968

NIFI-3931 - Added EL to properties in SFTP transfer

The properties are already evaluated against EL. Also added an
integration test that is failing without the change.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-3931

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1968


commit bdbfdfa21b1188efba2e2806c9e7381e865a553a
Author: Pierre Villard 
Date:   2017-07-02T13:24:17Z

NIFI-3931 - Added EL to properties in SFTP transfer

The properties are already evaluated against EL. Also added an
integration test that is failing without the change.




> putSftp process port property should support for expression language
> 
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Cheng Chin Tat
>Priority: Minor
>  Labels: easyfix
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)