[GitHub] [openwhisk] jiangpengcheng commented on issue #4617: Add kind "unknown" to fallback activations
jiangpengcheng commented on issue #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#issuecomment-530631327 @sven-lange-last Never mind, it's totally fine I also agree with @rabbah that add an extra field to `ActivationMessage` may introduce some costs which are not proportional to the gain This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-runtime-php] akrabat closed pull request #67: Add libssl-dev to support mongodb ssl/tls connections.
akrabat closed pull request #67: Add libssl-dev to support mongodb ssl/tls connections. URL: https://github.com/apache/openwhisk-runtime-php/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-runtime-php] falkzoll opened a new pull request #67: Add libssl-dev to support mongodb ssl/tls connections.
falkzoll opened a new pull request #67: Add libssl-dev to support mongodb ssl/tls connections. URL: https://github.com/apache/openwhisk-runtime-php/pull/67 * Current MongoDB driver does not support ssl/tls connections. It terminates the connection request with a MongoDB exception: `The "SCRAM-SHA-1" authentication mechanism requires libmongoc built with --enable-ssl`. Adding the libssl-dev package allows the mongodb driver build to automatically detect this and enables ssl/tls connections. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah edited a comment on issue #4617: Add kind "unknown" to fallback activations
rabbah edited a comment on issue #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#issuecomment-530438270 > But all code locations that initially create the ActivationMessage know the action kind. So what about adding the action kind to the ActivationMessage when creating it? I think the current change is fine as is. In the two cases affected by the change in InvokerReactive. The first case: `get` failed in the second: `namespace` is blacklisted. What you're suggesting involves sending more information over the message bus. It's OK to do that but there is a cost to continuing to grown the activation message. Is it important enough to extend the ActivationMessage (serialization and deserialization costs) to cover two corner cases? I don't think there have been any recent plots to show performance costs to cross the message bus as a function of activation message - I'm curious to see those costs, since it's easy to add fields without knowing that the drawbacks might be. We've already done that several times without careful considerations iirc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4617: Add kind "unknown" to fallback activations
rabbah commented on issue #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#issuecomment-530438270 > But all code locations that initially create the ActivationMessage know the action kind. So what about adding the action kind to the ActivationMessage when creating it? I think the current change is fine as is. In the two cases affected by the change in InvokerReactive. The first case: `get` failed in the second: `namespace` is blacklisted. What you're suggesting involves sending more information over the message bus. It's OK to do that but there is a cost to continuing to grown the activation message. Is it important enough to extend the ActivationMessage (serialization and deserialization costs) to cover two corner cases? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4619: Add ansible deploy options
rabbah commented on a change in pull request #4619: Add ansible deploy options
URL: https://github.com/apache/openwhisk/pull/4619#discussion_r323312070
##
File path: ansible/roles/zookeeper/tasks/deploy.yml
##
@@ -17,13 +17,6 @@
---
# This role will install Kafka with Zookeeper in group 'kafka' in the
environment inventory
-- name: "pull the zookeeper:{{ zookeeper.version }} image"
Review comment:
LGTM - not sure why there was a separate pull task.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1068: Auto supply a dummy API GW token
mrutkows merged pull request #1068: Auto supply a dummy API GW token URL: https://github.com/apache/openwhisk-wskdeploy/pull/1068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4619: Add ansible deploy options
codecov-io commented on issue #4619: Add ansible deploy options URL: https://github.com/apache/openwhisk/pull/4619#issuecomment-530368237 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=h1) Report > Merging [#4619](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/94f7b1450418512d4e28e852be684eadc390956d?src=pr=desc) will **decrease** coverage by `5.76%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4619 +/- ## == - Coverage 84.54% 78.77% -5.77% == Files 183 183 Lines8308 8308 Branches 571 571 == - Hits 7024 6545 -479 - Misses 1284 1763 +479 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.89%)` | :arrow_down: | | [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-94.74%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...e/database/cosmosdb/cache/ChangeFeedListener.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRMaXN0ZW5lci5zY2FsYQ==) | `0% <0%> (-86.67%)` | :arrow_down: | | [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-76.48%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: | | [...a/org/apache/openwhisk/common/ExecutorCloser.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9FeGVjdXRvckNsb3Nlci5zY2FsYQ==) | `0% <0%> (-66.67%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4% <0%> (-52%)` | :arrow_down: | | ... and [10 more](https://codecov.io/gh/apache/openwhisk/pull/4619/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4619?src=pr=footer). Last
[GitHub] [openwhisk] BillZong opened a new pull request #4619: Add ansible deploy options
BillZong opened a new pull request #4619: Add ansible deploy options URL: https://github.com/apache/openwhisk/pull/4619 Add docker image pull (or not) options to kafka and zookeeper deployment. ## Description If the docker tagged(especially the "latest") image is already in environment machine, adding this option could speed up deployment. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4617: Add kind "unknown" to fallback activations
codecov-io commented on issue #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#issuecomment-530329157 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=h1) Report > Merging [#4617](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/94f7b1450418512d4e28e852be684eadc390956d?src=pr=desc) will **decrease** coverage by `5.76%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4617 +/- ## == - Coverage 84.54% 78.78% -5.77% == Files 183 183 Lines8308 8309 +1 Branches 571 574 +3 == - Hits 7024 6546 -478 - Misses 1284 1763 +479 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/org/apache/openwhisk/core/entity/Exec.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `90.62% <100%> (+0.14%)` | :arrow_up: | | [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `80% <100%> (-0.87%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.89%)` | :arrow_down: | | [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-94.74%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...e/database/cosmosdb/cache/ChangeFeedListener.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRMaXN0ZW5lci5zY2FsYQ==) | `0% <0%> (-86.67%)` | :arrow_down: | | [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-76.48%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/openwhisk/pull/4617/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4617?src=pr=footer). Last update
[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4617: Add kind "unknown" to fallback activations
sven-lange-last commented on a change in pull request #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#discussion_r323119026 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala ## @@ -263,7 +263,10 @@ class InvokerReactive( } val context = UserContext(msg.user) -val activation = generateFallbackActivation(msg, response) +val activation = generateFallbackActivation( + msg, + response, + Parameters(WhiskActivation.kindAnnotation, JsString(Exec.UNKNOWN))) Review comment: @rabbah although I originally suggested the approach to extend the signature of `generateFallbackActivation()` to allow for passing additional annotations in #4615, I now agree with your assessment. `generateFallbackActivation()` is used exactly two times within the same compilation unit in close proximity to its definition. So it's fine to add the `kind = unknown` annotation directly within `generateFallbackActivation()`. @jiangpengcheng I suggest to add a comment to `generateFallbackActivation()` why the `kind = unknown` annotation is set, i.e. in order to support user metrics because the metrics record requires a kind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-runtime-php] falkzoll opened a new pull request #67: Add libssl-dev to support mongodb ssl/tls connections.
falkzoll opened a new pull request #67: Add libssl-dev to support mongodb ssl/tls connections. URL: https://github.com/apache/openwhisk-runtime-php/pull/67 * Current MongoDB driver does not support ssl/tls connections. It terminates the connection request with a MongoDB exception: `The "SCRAM-SHA-1" authentication mechanism requires libmongoc built with --enable-ssl`. Adding the libssl-dev package allows the mongodb driver build to automatically detect this and enables ssl/tls connections. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4617: Add kind "unknown" to fallback activations
rabbah commented on a change in pull request #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#discussion_r323088425 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala ## @@ -263,7 +263,10 @@ class InvokerReactive( } val context = UserContext(msg.user) -val activation = generateFallbackActivation(msg, response) +val activation = generateFallbackActivation( + msg, + response, + Parameters(WhiskActivation.kindAnnotation, JsString(Exec.UNKNOWN))) Review comment: since it both cases of generating a fall back activation, the action is not available, i favor not changing the function sigature and adding the unknow annotation directly in `generateFallbackActivation` instead of at the two call sites. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
