date:20170807

[GitHub] lzbj commented on issue #307: Report invalid runtimes

2017-08-07 Thread git

lzbj commented on issue #307: Report invalid runtimes
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/307#issuecomment-320840632
 
 
   @pritidesai , is it related to #306 , I suggest we combine them.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj commented on issue #306: Implicit Runtime for Java is set to nodejs:default

2017-08-07 Thread git

lzbj commented on issue #306: Implicit Runtime for Java is set to nodejs:default
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/306#issuecomment-320840486
 
 
   why default kind should be a empty string? we need to consider php also as 
it's supported now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj commented on issue #262: Adjust the code to reflect latest API gateway version.

2017-08-07 Thread git

lzbj commented on issue #262: Adjust the code to reflect latest API gateway 
version.
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-314631363
 
 
   @mrutkows , got it, I'll try to fix it, sorry it's been dangling a while. 
https://github.com/apache/incubator-openwhisk/pull/2547
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git

dubeejw commented on issue #2582: Use non-blocking techniques when interfacing 
to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#issuecomment-320835926
 
 
   @markusthoemmes, when I run this locally to invoke an action, I get the same 
error that is in your Travis log. Also, I see this in Kibana logs ` action 
activation failed: no invokers available`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git

dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320834166
 
 
   PG3 976 ? .
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ningyougang opened a new pull request #2585: Add the image filter when get invoker info

2017-08-07 Thread git

ningyougang opened a new pull request #2585: Add the image filter when get 
invoker info
URL: https://github.com/apache/incubator-openwhisk/pull/2585
 
 
   The `nodejs6action` container is created by invoker which test the invoker 
whether worked well, sometimes, 
   its name may has `invoker` substring, for example as below
   ```
   37d73d962120whisk/nodejs6action:latest   "/bin/sh -c 'node --e"   13 
minutes ago  Up 13 minutes  
wsk0_3_whisksystem_invokerHealthTestAction0
   2581c86d6adawhisk/invoker:latest "/bin/sh -c 'exec /in"   13 
minutes ago  Up 13 minutes   0.0.0.0:12001->8080/tcp
invoker0
   ```
   If above situation happens, below ansible task's revokerInfo's length will 
be greater than 1
   ```
   - name: get running invoker information
 uri: url="http://{{ inventory_hostname }}:{{ docker.port 
}}/containers/json?filters={{ '{"name":[ "invoker" ],"ancestor":[ "invoker" ]}' 
| urlencode }}" return_content=yes
 register: invokerInfo
   ```
   then, below ansible task will be failed
   ```
   TASK [invoker : determine if more than one invoker is running] 
**
   Monday 07 August 2017  22:15:36 -0400 (0:00:00.314)   0:00:02.154 
* 
   fatal: [10.34.135.216]: FAILED! => {"changed": false, "failed": true, "msg": 
"more than one invoker is running"}
   ```
   
   How to solve this problem, i think the best way is `add image filter` to 
search exactly 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] drcariel commented on issue #2547: CLI Experimental api removal

2017-08-07 Thread git

drcariel commented on issue #2547: CLI Experimental api removal
URL: 
https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320830866
 
 
   PG1~1918
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] devbv commented on issue #2557: Fix ansible script for distributed environment

2017-08-07 Thread git

devbv commented on issue #2557: Fix ansible script for distributed environment
URL: 
https://github.com/apache/incubator-openwhisk/pull/2557#issuecomment-320826738
 
 
   @rabbah I just rebased it, Hope this works.
   And I also have an Apache CLA file. Do you need it?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on issue #2584: SPI for Loadbalancer

2017-08-07 Thread git

tysonnorris commented on issue #2584: SPI for Loadbalancer
URL: 
https://github.com/apache/incubator-openwhisk/pull/2584#issuecomment-320823971
 
 
   A variety of tests are generating this exception ONLY in travis: 
`java.lang.IllegalStateException: Stream is terminated. SourceQueue is detached`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris opened a new pull request #2584: SPI for Loadbalancer

2017-08-07 Thread git

tysonnorris opened a new pull request #2584: SPI for Loadbalancer
URL: https://github.com/apache/incubator-openwhisk/pull/2584
 
 
   To allow deployments to customize the Loadbalancer impls. Currently same 
Loadbalancer is used for all traffic, but future enhancements could use 
multiple load balancers for different traffic patterns.
   
   Default is whisk.core.loadBalancer.LoadBalancerServiceProvider, which wraps 
the existing LoadBalancer impl  (Kafka + InvokerPool) behind the SPI for 
instantiation.
   
   To decouple up the SPI interface for LoadBalancer from implementation 
details, no ArtifactStore stores are passed as parameters into 
LoadBalancerService anymore. CouchDbStoreProvider caches stores by name, so 
they can be fetched via SPI in multiple places and resolve to the same store 
instance.  Now LoadBalancerService can do `WhiskEntityStore.datastore(config)` 
to acquire the entityStore.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new issue #307: Report invalid runtimes

2017-08-07 Thread git

pritidesai opened a new issue #307: Report invalid runtimes
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/307
 
 
   There are only few valid runtimes available:
   
   ```
   Runtime name | Supported versions | Default | Description
   nodejs | nodejs@6, nodejs@5 | nodejs@6 | Node.js runtime.
   java | java@8 | java@8 | Java language runtime.
   python | python@2.7 | python@2.7 | Python language runtime.
   swift | swift@3, swift@2 | swift@3 | Swift language runtime.
   language:default | N/A | N/A | Permit the OpenWhisk platform to select the 
correct default language runtime.
   ```
   
   manifest_parser should report if a runtime is set to any value outside of 
the above valid options.
   
   For example, today when I say my runtime is set to "invalid", ComposeActions 
accepts it as is and does not complain:
   
   ```
   `package:
  name: helloworld
  actions:
helloInvalidRuntime:
  location: ../tests/usecases/helloworld/actions/hello.js
  runtime: invalid`
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new issue #306: Implicit Runtime for Java is set to nodejs:default

2017-08-07 Thread git

pritidesai opened a new issue #306: Implicit Runtime for Java is set to 
nodejs:default
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/306
 
 
   In the 
[manifest_parser.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/parsers/manifest_parser.go#L248),
 default runtime is set to nodejs. 
   
   ```
kind := "nodejs:default"
   
switch ext {
case ".swift":
kind = "swift:default"
case ".js":
kind = "nodejs:default"
case ".py":
kind = "python"
}
   ``` 
   
   When an action with .jar or .java extension is specified, the runtime is set 
to nodejs:default (snippet of the unit tests I was writing)
   
   ```
   --- FAIL: TestComposeActionsForImplicitRuntimes (0.00s)
   Error Trace:manifest_parser_test.go:510
   Error:  Not equal: 
   expected: "java"
   actual: "nodejs:default"
   Messages:   Expected java but got nodejs:default
   FAIL
   ```
   
   Here, default kind should be an empty string, and specifically check for 
each file extensions (.swift, .js, .py, and .jar), action file extension 
outside of these four options should be reported instead of setting kind for it 
to nodejs:default.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git

dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315
 
 
   PG3 976. ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git

dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315
 
 
   PG3 975. ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hsane2001 commented on issue #2175: Provide a performance test-harness

2017-08-07 Thread git

hsane2001 commented on issue #2175: Provide a performance test-harness
URL: 
https://github.com/apache/incubator-openwhisk/issues/2175#issuecomment-320800370
 
 
   Thanks - that worked. Does each HTTP request from loadtest generate an 
action?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-07 Thread git

csantanapr commented on issue #305: Wondering why triggers are updated with 
overwrite set to false
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-320789710
 
 
   I think the wskdeploy needs to do more with feed actions to be able to 
updated them, it needs to delete the trigger and invoke the feed action with 
the with delete lifecycle, and then follow with normal feed creation.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris opened a new pull request #2584: SPI for Loadbalancer

2017-08-07 Thread git

tysonnorris opened a new pull request #2584: SPI for Loadbalancer
URL: https://github.com/apache/incubator-openwhisk/pull/2584
 
 
   To allow deployments to customize the Loadbalancer impls. Currently same 
Loadbalancer is used for all traffic, but future enhancements could use 
multiple load balancers for different traffic patterns.
   
   Default is whisk.core.loadBalancer.LoadBalancerServiceProvider, which wraps 
the existing LoadBalancer impl  (Kafka + InvokerPool) behind the SPI for 
instantiation.
   
   To decouple up the SPI interface for LoadBalancer from implementation 
details, no ArtifactStore stores are passed as parameters into 
LoadBalancerService anymore. CouchDbStoreProvider caches stores by name, so 
they can be fetched via SPI in multiple places and resolve to the same store 
instance.  Now LoadBalancerService can do `WhiskEntityStore.datastore(config)` 
to acquire the entityStore.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on a change in pull request #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git

mdeuser commented on a change in pull request #2435: Ensure Action Update 
Creates a Web Action (Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#discussion_r13174
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##
 @@ -473,6 +473,26 @@ func addKeyValue(key string, value interface{}, 
keyValueArr whisk.KeyValueArr) (
 return append(keyValueArr, keyValue)
 }
 
+func findKeyValue(keyValueArr whisk.KeyValueArr, key string) (int) {
+for i := 0; i < len(keyValueArr); i++ {
+if strings.ToLower(keyValueArr[i].Key) == strings.ToLower(key) {
+return i
+}
+}
+
+return -1
+}
+
+func appendKeyValueArr(origKeyValueArr whisk.KeyValueArr, appKeyValueArr 
whisk.KeyValueArr) (whisk.KeyValueArr) {
+for i := 0; i < len(appKeyValueArr); i++ {
+if findKeyValue(origKeyValueArr, appKeyValueArr[i].Key) == -1 {
 
 Review comment:
   This seems like a good function candidate to the whisk.KeyValueArr structure:
   ```
   func (kvr KeyValueArr) AppendKeyValueArr(kvrToAdd KeyValueArr) KeyValueArr {
   ...
   }
   ```
   Minor nit... I suggest renaming the arg/var `fetch` to reflect its higher 
purpose of "preserve all existing annotations"
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-07 Thread git

zachschultz commented on issue #305: Wondering why triggers are updated with 
overwrite set to false
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-320781784
 
 
   It looks like the relevant code is here and that trigger feed actions are 
treated differently: 
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/a67e7285845828510c2c6c8849c950c37ca4576d/deployers/servicedeployer.go#L415
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zachschultz opened a new issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-07 Thread git

zachschultz opened a new issue #305: Wondering why triggers are updated with 
overwrite set to false
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305
 
 
   I have a wskdeploy manifest yaml file that looks like:
   
   ```
   package:
 name: messagehub-trigger
 version: 1.0
 license: Apache-2.0
 namespace: _
 dependencies:
   openwhisk-messagehub:
 location: /whisk.system/messaging
 inputs:
   kafka_brokers_sasl: $KAFKA_BROKERS
   user: $MESSAGEHUB_USER
   password: $MESSAGEHUB_PASS
   kafka_admin_url: $KAFKA_ADMIN_URL
 actions:
   process-message:
 location: actions/process-message.js
 triggers:
   message-received-trigger:
 source: openwhisk-messagehub/messageHubFeed
 inputs:
   kafka_brokers_sasl: $KAFKA_BROKERS
   user: $MESSAGEHUB_USER
   password: $MESSAGEHUB_PASS
   isJSONData: true
   topic: $KAFKA_TOPIC
   kafka_admin_url: $KAFKA_ADMIN_URL
 rules:
 log-message-rule:
   trigger: message-received-trigger
   action: messagehub-trigger/process-message
   ```
   
   When I changed the `source` of the `message-received-trigger` and ran 
wskdeploy I noticed that OpenWhisk didn't actually change the trigger, and 
after running with `verbose` I saw that the request was:
   
   ```
   REQUEST:
   [PUT]
https://openwhisk.ng.bluemix.net:443/api/v1/namespaces/_/triggers/message-received-trigger?overwrite=false
   ```
   
   Why is it that everything else is sent with `overwrite=true` but trigger 
creations are sent with `overwrite=false`? Is it based on the assumption that 
other things may be relying on the trigger?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2557: Fix ansible script for distributed environment

2017-08-07 Thread git

rabbah commented on issue #2557: Fix ansible script for distributed environment
URL: 
https://github.com/apache/incubator-openwhisk/pull/2557#issuecomment-320778267
 
 
   Also do you have an Apache CLA on file?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2557: Fix ansible script for distributed environment

2017-08-07 Thread git

rabbah commented on issue #2557: Fix ansible script for distributed environment
URL: 
https://github.com/apache/incubator-openwhisk/pull/2557#issuecomment-320777827
 
 
   @devbv do you mind rebasing this to pick up the swift3 related fix? 
   i can't run this in jenkins otherwise.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DanLavine opened a new pull request #2583: Create Nginx image with localy built CLI, Blackbox SDK.

2017-08-07 Thread git

DanLavine opened a new pull request #2583: Create Nginx image with localy built 
CLI, Blackbox SDK.
URL: https://github.com/apache/incubator-openwhisk/pull/2583
 
 
   * Loclally builds and adds all CLI OS + arch builds to Nginx
   * builds and adds Blackbox SDK
   * Update Ansible scripts to deploy the new nginx image
   
   The main motivation for this feature is so deployment options that don't 
want to rely on Ansible's post docker creation steps can have an Nginx image 
with all the extra CLIs and SDKs built into it.
   
   **NOTE** This PR will require a new Nginx image for OpenWhisk. I'm not sure 
where this would be built and published from.
   
   **NOTE** This PR removes the ability to install the CLI from the remote 
github repo. However, when the CLI is split out of the main OpenWhisk repo it 
should be easy to pull the remote CLI. All that would need to change is not 
building the CLI locally and instead, pull the CLI binary/zip files from github.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #202: Produce action fixes

2017-08-07 Thread git

csantanapr closed pull request #202: Produce action fixes
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah closed issue #350: Provide a CLI command to get the URL needed to invoke a particular action

2017-08-07 Thread git

rabbah closed issue #350: Provide a CLI command to get the URL needed to invoke 
a particular action
URL: https://github.com/apache/incubator-openwhisk/issues/350
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131754094
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   Ok thanks for the clarification. It wasn't obvious from the test. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #2547: CLI Experimental api removal

2017-08-07 Thread git

mdeuser commented on issue #2547: CLI Experimental api removal
URL: 
https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320768561
 
 
   @rabbah - is pr OK now?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131748554
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   We put them in to test that 3 part FQN's could be used during rule creation. 
A user could enter something like
   ```
   wsk rule create ruleName triggerName namespace/packageName/actionName
   ``` 
   Is this unnecessary?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131748554
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   We put them in to test that 3 part FQN's could be used during rule creation. 
A user could enter something like ```wsk rule create ruleName triggerName 
namespace/packageName/actionName``` Is this unnecessary?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131749161
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   I believe only packaged actions can have a three part qualifying name.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131748554
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   We put them in to test that 3 part FQN's could be used during rule creation. 
A user could enter something like `wsk rule create ruleName triggerName 
namespace/packageName/actionName`. Is this unnecessary?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2557: Fix ansible script for distributed environment

2017-08-07 Thread git

rabbah commented on issue #2557: Fix ansible script for distributed environment
URL: 
https://github.com/apache/incubator-openwhisk/pull/2557#issuecomment-320757903
 
 
   pg2/1919 ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-07 Thread git

rabbah commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-320757458
 
 
   @devbv does your pr apply here perhaps? 
https://github.com/apache/incubator-openwhisk/pull/2557
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #350: Provide a CLI command to get the URL needed to invoke a particular action

2017-08-07 Thread git

rabbah commented on issue #350: Provide a CLI command to get the URL needed to 
invoke a particular action
URL: 
https://github.com/apache/incubator-openwhisk/issues/350#issuecomment-320756399
 
 
   The `--url` which was recently added allows one to get the URL for an action 
invoke (for POST and webaction).
   
   For the API gw URLs, I think this is not supported but that seems like it 
should be part of the API gw submenu and hence I'm inclined to close this issue 
which is more generally for actions. I'd expect the API gw to separately 
address this.
   
   @mdeuser @csantanapr thoughts? Shall I close this issue?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git

rabbah commented on a change in pull request #2582: Use non-blocking techniques 
when interfacing to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#discussion_r131738939
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
 ##
 @@ -31,6 +31,10 @@ import 
org.apache.kafka.common.serialization.ByteArrayDeserializer
 
 import whisk.common.Logging
 import whisk.core.connector.MessageConsumer
+import org.apache.kafka.clients.consumer.OffsetCommitCallback
+import org.apache.kafka.clients.consumer.OffsetAndMetadata
+import scala.concurrent.Promise
+import org.apache.kafka.common.TopicPartition
 
 Review comment:
   small nit can we sort these imports
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git

rabbah commented on a change in pull request #2582: Use non-blocking techniques 
when interfacing to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#discussion_r131738939
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
 ##
 @@ -31,6 +31,10 @@ import 
org.apache.kafka.common.serialization.ByteArrayDeserializer
 
 import whisk.common.Logging
 import whisk.core.connector.MessageConsumer
+import org.apache.kafka.clients.consumer.OffsetCommitCallback
+import org.apache.kafka.clients.consumer.OffsetAndMetadata
+import scala.concurrent.Promise
+import org.apache.kafka.common.TopicPartition
 
 Review comment:
   small nit can we sort these imports
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131738694
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   `val triggerName = "triggerName3ptFQN"` seems to have just one part - what 
am i missing?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131738694
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   ` val triggerName = "triggerName3ptFQN"` seems to have just one part - what 
am i missing.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131738236
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   I believe these are testing using a three part qualified name without a 
leading slash, @rabbah.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131737860
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
+Seq("action", "get", fullQualifiedName),
+Seq("rule", "create", ruleName, triggerName, fullQualifiedName),
+Seq("action", "delete", fullQualifiedName)
+)
+val cleanUp: Seq[Seq[String]] = Seq(
 
 Review comment:
   use the asset cleaner then you dont have to do this.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131737797
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   why are these here? they don't test anything not already tested (triggers 
and rules are 2 parts only and so is a package name).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131736514
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/trigger.go
 ##
 @@ -425,25 +425,27 @@ var triggerListCmd = {
 PreRunE: setupClientConfig,
 RunE: func(cmd *cobra.Command, args []string) error {
 var err error
-var qualifiedName QualifiedName
+var qualifiedName = new(QualifiedName)
 
 if whiskErr := checkArgs(args, 0, 1, "Trigger list",
 wski18n.T("An optional namespace is the only valid argument.")); 
whiskErr != nil {
 return whiskErr
 }
 
 if len(args) == 1 {
-if qualifiedName, err = parseQualifiedName(args[0]); err != nil {
-return parseQualifiedNameError(args[0], err)
+if qualifiedName, err = NewQualifiedName(args[0]); err != nil {
+return NewQualifiedNameError(args[0], err)
 }
 
-if len(qualifiedName.entityName) > 0 {
-return entityNameError(qualifiedName.entityName)
+if len(qualifiedName.GetEntityName()) > 0 {
+return entityNameError(qualifiedName.GetEntityName())
 }
 
-client.Namespace = qualifiedName.namespace
+client.Namespace = qualifiedName.GetNamespace()
 }
 
+//fmt.Println("Package name: ", qualifiedName.GetPackageName())
 
 Review comment:
   Delete comment.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2490: CLI summaries for actions without annotations

2017-08-07 Thread git

dubeejw commented on a change in pull request #2490: CLI summaries for actions 
without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131735840
 
 

 ##
 File path: docs/packages.md
 ##
 @@ -42,15 +42,21 @@ Several packages are registered with OpenWhisk. You can 
get a list of packages i
   ```
   ```
   package /whisk.system/cloudant: Cloudant database service
- (params: BluemixServiceName host username password dbname includeDoc 
overwrite)
+ (parameters: *apihost, *bluemixServiceName, *dbname, *host, overwrite, 
*password, *username)
action /whisk.system/cloudant/read: Read document from database
-   action /whisk.system/cloudant/write: Write document to database
+ (parameters: dbname, id, params)
+   action /whisk.system/cloudant/write: Write document in database
+ (parameters: dbname, doc)
feed   /whisk.system/cloudant/changes: Database change feed
+ (parameters: dbname, filter, query_params)
+  ...
   ```
 
-  This output shows that the Cloudant package provides two actions, `read` and 
`write`, and one trigger feed called `changes`. The `changes` feed causes 
triggers to be fired when documents are added to the specified Cloudant 
database.
+  **Note**: Parameters listed under the package with a prefix `*` are 
predefined, bound parameters. Parameters without a `*` are those listed under 
the [annotations](./annotations.md) for each entity. Any entity listed under a 
package inherits specific bound parameters from the package. To view the list 
of known parameters of an entity belonging to a package, you will need to run a 
`get --summary` of the individual entity.
 
 Review comment:
   Need to explain what `**` denotes in the docs.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #82: Applying filter on all db changes since 0 takes too long

2017-08-07 Thread git

csantanapr commented on a change in pull request #82: Applying filter on all db 
changes since 0 takes too long
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/pull/82#discussion_r131732914
 
 

 ##
 File path: provider/lib/utils.js
 ##
 @@ -216,25 +210,26 @@ module.exports = function(
 this.initAllTriggers = function() {
 var method = 'initAllTriggers';
 
-logger.info(method, 'resetting system from last state');
+//follow the trigger DB
+utils.setupFollow('now');
 
-triggerDB.changes({ since: 0, include_docs: true, filter: ddname + '/' 
+ filter, worker: utils.worker }, (err, changes) => {
+logger.info(method, 'resetting system from last state');
+triggerDB.view(viewDDName, triggersByWorker, {reduce: false, 
include_docs: true}, function(err, body) {
 
 Review comment:
   use `key:"worker0"` that will reduce the docs you get back only for the 
current worker
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #82: Applying filter on all db changes since 0 takes too long

2017-08-07 Thread git

csantanapr closed pull request #82: Applying filter on all db changes since 0 
takes too long
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/82
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #82: Applying filter on all db changes since 0 takes too long

2017-08-07 Thread git

csantanapr commented on a change in pull request #82: Applying filter on all db 
changes since 0 takes too long
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/pull/82#discussion_r131733024
 
 

 ##
 File path: provider/lib/utils.js
 ##
 @@ -216,25 +210,26 @@ module.exports = function(
 this.initAllTriggers = function() {
 var method = 'initAllTriggers';
 
-logger.info(method, 'resetting system from last state');
+//follow the trigger DB
+utils.setupFollow('now');
 
-triggerDB.changes({ since: 0, include_docs: true, filter: ddname + '/' 
+ filter, worker: utils.worker }, (err, changes) => {
+logger.info(method, 'resetting system from last state');
+triggerDB.view(viewDDName, triggersByWorker, {reduce: false, 
include_docs: true}, function(err, body) {
 if (!err) {
-changes.results.forEach(function (change) {
-var triggerIdentifier = change.id;
-var doc = change.doc;
+body.rows.forEach(function (trigger) {
+var triggerIdentifier = trigger.id;
+var doc = trigger.doc;
 
-if (!doc.status || doc.status.active === true) {
+if (trigger.key === utils.worker && (!doc.status || 
doc.status.active === true) && !(triggerIdentifier in utils.triggers)) {
 
 Review comment:
   by using key in the view, no need to check the worker
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjustin-ibm commented on issue #187: create development guide

2017-08-07 Thread git

bjustin-ibm commented on issue #187: create development guide
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/187#issuecomment-320747601
 
 
   @csantanapr please merge.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2490: CLI summaries for actions without annotations

2017-08-07 Thread git

dubeejw commented on a change in pull request #2490: CLI summaries for actions 
without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131725811
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -410,6 +487,98 @@ class WskBasicTests
 stdout should include regex (s"(?i)action /$ns/$name: Action 
description\\s*\\(parameters: paramName1, paramName2\\)")
 }
 
+it should "create, and get an action summary without a description and/or 
defined parameters" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val actNameNoParams = "actionNoParams"
+val actNameNoDesc = "actionNoDesc"
+val actNameNoDescOrParams = "actionNoDescOrParams"
+val desc = "Action description"
+val descFromParamsResp = "Returns a result based on parameters"
+val annotsNoParams = Map(
+"description" -> JsString(desc)
+)
+val annotsNoDesc = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString("paramName1"),
+"description" -> JsString("Parameter description 1")),
+JsObject(
+"name" -> JsString("paramName2"),
+"description" -> JsString("Parameter description 2"
+
+assetHelper.withCleaner(wsk.action, actNameNoDesc) {
+(action, _) =>
+action.create(actNameNoDesc, defaultAction, annotations = 
annotsNoDesc)
+}
+assetHelper.withCleaner(wsk.action, actNameNoParams) {
+(action, _) =>
+action.create(actNameNoParams, defaultAction, annotations 
= annotsNoParams)
+}
+assetHelper.withCleaner(wsk.action, actNameNoDescOrParams) {
+(action, _) =>
+action.create(actNameNoDescOrParams, defaultAction)
+}
+
+val stdoutNoDesc = wsk.action.get(actNameNoDesc, summary = 
true).stdout
+val stdoutNoParams = wsk.action.get(actNameNoParams, summary = 
true).stdout
+val stdoutNoDescOrParams = wsk.action.get(actNameNoDescOrParams, 
summary = true).stdout
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
+
+stdoutNoDesc should include regex (
+s"(?i)action /${ns_regex_list}/${actNameNoDesc}: 
${descFromParamsResp} paramName1 and paramName2\\s*\\(parameters: paramName1, 
paramName2\\)")
+stdoutNoParams should include regex (
+s"(?i)action /${ns_regex_list}/${actNameNoParams}: 
${desc}\\s*\\(parameters: none defined\\)")
+stdoutNoDescOrParams should include regex (
+s"(?i)action 
/${ns_regex_list}/${actNameNoDescOrParams}\\s*\\(parameters: none defined\\)")
+}
+
+it should "denote bound and finalized action parameters for action 
summaries" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val nameBoundParams = "actionBoundParams"
+val nameFinalParams = "actionFinalParams"
+val paramAnnot = "paramAnnot"
+val paramOverlap = "paramOverlap"
+val paramBound = "paramBound"
+val annots = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString(paramAnnot),
+"description" -> JsString("Annotated")),
+JsObject(
+"name" -> JsString(paramOverlap),
+"description" -> JsString("Annotated And Bound"
+val annotsFinal = Map(
+"final" -> JsBoolean(true),
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString(paramAnnot),
+"description" -> JsString("Annotated Parameter 
description")),
+JsObject(
+"name" -> JsString(paramOverlap),
+"description" -> JsString("Annotated And Bound"
+val paramsBound = Map(
+paramBound -> JsString("Bound"),
+paramOverlap -> JsString("Bound And Annotated"))
+
+assetHelper.withCleaner(wsk.action, nameBoundParams) {
+(action, _) =>
+action.create(nameBoundParams, defaultAction, annotations 
= annots, parameters = paramsBound)
+}
+assetHelper.withCleaner(wsk.action, nameFinalParams) {
+(action, _) =>
+action.create(nameFinalParams, defaultAction, annotations 
= annotsFinal, parameters = paramsBound)
+}
+
+val stdoutBound = wsk.action.get(nameBoundParams, summary = 
true).stdout
+val stdoutFinal = wsk.action.get(nameFinalParams,

[GitHub] jlost commented on issue #35: TypeScript Typings

2017-08-07 Thread git

jlost commented on issue #35: TypeScript Typings
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/35#issuecomment-320738257
 
 
   Example: 
   
   ```
   declare module OpenWhisk {
   export interface OpenWhiskActivation {
   activationId: string;
   annotations: any[];
   duration: number;
   end: number;
   logs: any[];
   name: string;
   namespace: string;
   publish: boolean;
   response: OpenWhiskResponse;
   start: number;
   subject: string;
   version: string;
   }
   
   export interface OpenWhiskResponse {
   result: T;
   status: string; //"success" / ??? 
   success: boolean;
   }
   }
   ```
   
   I created this by hand by looking at actual OpenWhisk activations. 
   
   A good halfway point for this project would be JSDoc, which would formalize 
the interfaces enough to make TS definitions easy to create and also power code 
completion within editors. That way you don't have to learn or implement any 
extra tools.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjustin-ibm commented on a change in pull request #187: create development guide

2017-08-07 Thread git

bjustin-ibm commented on a change in pull request #187: create development guide
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/187#discussion_r131723399

##
File path: README.md
##
@@ -278,8 +278,8 @@ The action caller (you, or your code) must first Base64
encode the data, for exa
### Integrating OpenWhisk with IBM Message Hub, Node Red, IBM Watson IoT, IBM
Object Storage, and IBM Data Science Experience
Example that integrates OpenWhisk with IBM Message Hub, Node Red, IBM Watson
IoT, IBM Object Storage, IBM Data Science Experience (Spark) service can be
[found
here](https://medium.com/openwhisk/transit-flexible-pipeline-for-iot-data-with-bluemix-and-openwhisk-4824cf20f1e0).

-## Testing
-An OpenWhisk deployment is required in order for the automated test suite to
be executed. To run tests locally, run ```$ ./gradlew tests:test
-Dhost= -Dport=``` from the project's root
directory. Where `` is the IP address of the service's
docker container, and `` is the port the docker container is
listening on. In addition, ```OPENWHISK_HOME``` must be set to the root of the
local OpenWhisk directory. Ex: ```export
OPENWHISK_HOME=```.
+## Development and Testing
+If you wish to deploy the feed service yourself, please refer to the
[Development Guide](devGuide.md)

Review comment:
@dubeejw fixed.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

dubeejw commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320734277
 
 
   @underwoodb-sd-ibm, may need a doc update based on @rabbah's last comment.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131719416
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/action.go
 ##
 @@ -121,7 +121,7 @@ var actionInvokeCmd = {
 RunE: func(cmd *cobra.Command, args []string) error {
 var err error
 var parameters interface{}
-var qualifiedName QualifiedName
+var qualifiedName = new(QualifiedName)
 
 Review comment:
   Please go through all of the command files and make sure the proper 
replacements have been made for the QualifiedName functions that you have added.
   
   `qualifiedName.packageName` line 235
   `printActionGetWithURL(qualifiedName.entity, actionURL)` line 236
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131717241
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,41 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
+Seq("action", "get", fullQualifiedName),
+Seq("rule", "create", ruleName, triggerName, fullQualifiedName),
+Seq("action", "delete", fullQualifiedName)
+)
+val cleanUp: Seq[Seq[String]] = Seq(
+Seq("package", "delete", packageName),
+Seq("trigger", "delete", triggerName),
+Seq("rule", "delete", ruleName)
+)
+try {
+validArgs foreach {
+cmd => val stderr = wsk.cli(cmd ++ wskprops.overrides ++ auth, 
expectedExitCode = SUCCESS_EXIT).stderr
 
 Review comment:
   `SUCCESS_EXIT` is by default the exit code that is expected.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131717044
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,41 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
+Seq("action", "get", fullQualifiedName),
+Seq("rule", "create", ruleName, triggerName, fullQualifiedName),
+Seq("action", "delete", fullQualifiedName)
+)
+val cleanUp: Seq[Seq[String]] = Seq(
+Seq("package", "delete", packageName),
+Seq("trigger", "delete", triggerName),
+Seq("rule", "delete", ruleName)
+)
+try {
+validArgs foreach {
+cmd => val stderr = wsk.cli(cmd ++ wskprops.overrides ++ auth, 
expectedExitCode = SUCCESS_EXIT).stderr
 
 Review comment:
   Should be: `cmd => wsk.cli(cmd ++ wskprops.overrides ++ auth)`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm opened a new pull request #2490: CLI summaries for actions without annotations

2017-08-07 Thread git

underwoodb-sd-ibm opened a new pull request #2490: CLI summaries for actions 
without annotations
URL: https://github.com/apache/incubator-openwhisk/pull/2490
 
 
   This update is intended to clarify the printed summary when one uses `wsk 
[ENTITY] [ENTITY_NAME] get --summary`.
   
   Here is an example of what the output of this update should look like:
   
   For entities with multiple parameters and no description:
   ```
   $ wsk action get hola -s
   action /guest/hola: Returns a result based on parameters testA, testB and 
testC
  (parameters: testA, testB, testC)
   ```
   
   For entities with a single parameter and no description:
   ```
   $ wsk action get hola -s
   action /guest/hola: Returns a result based on parameter testA
  (parameters: testA)
   ```
   
   And entities with no parameters and no description:
   ```
   $ wsk action get hello -s
   action /guest/hello
  (Warning: /guest/hello has no annotations)
   ```
   
Closes https://github.com/apache/incubator-openwhisk/issues/2270
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm closed pull request #2490: CLI summaries for actions without annotations

2017-08-07 Thread git

underwoodb-sd-ibm closed pull request #2490: CLI summaries for actions without 
annotations
URL: https://github.com/apache/incubator-openwhisk/pull/2490
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjustin-ibm commented on a change in pull request #202: Produce action fixes

2017-08-07 Thread git

bjustin-ibm commented on a change in pull request #202: Produce action fixes
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131718349
 
 

 ##
 File path: action/messageHubProduce.py
 ##
 @@ -196,7 +205,16 @@ def getProducer(validatedParams):
 logging.info("Reusing existing producer")
 return globals()["cached_producers"][connectionHash]
 
-
 def getConnectionHash(params):
 apiKey = "{}:{}".format(params['user'], params['password'])
 return apiKey
+
+# return the remaining time (in seconds) until the action will expire,
+# optionally reserving some time (also in seconds).
+def getRemainingTime(reservedTime=0):
+deadlineSeconds = int(os.getenv('__OW_DEADLINE', 6)) / 1000
 
 Review comment:
   Yes, it is epoch milliseconds.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #202: Produce action fixes

2017-08-07 Thread git

dubeejw commented on a change in pull request #202: Produce action fixes
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131716146
 
 

 ##
 File path: action/messageHubProduce.py
 ##
 @@ -196,7 +205,16 @@ def getProducer(validatedParams):
 logging.info("Reusing existing producer")
 return globals()["cached_producers"][connectionHash]
 
-
 def getConnectionHash(params):
 apiKey = "{}:{}".format(params['user'], params['password'])
 return apiKey
+
+# return the remaining time (in seconds) until the action will expire,
+# optionally reserving some time (also in seconds).
+def getRemainingTime(reservedTime=0):
+deadlineSeconds = int(os.getenv('__OW_DEADLINE', 6)) / 1000
 
 Review comment:
   `__OW_DEADLINE` is always a positive number, or empty?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #202: Produce action fixes

2017-08-07 Thread git

dubeejw commented on a change in pull request #202: Produce action fixes
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131716146
 
 

 ##
 File path: action/messageHubProduce.py
 ##
 @@ -196,7 +205,16 @@ def getProducer(validatedParams):
 logging.info("Reusing existing producer")
 return globals()["cached_producers"][connectionHash]
 
-
 def getConnectionHash(params):
 apiKey = "{}:{}".format(params['user'], params['password'])
 return apiKey
+
+# return the remaining time (in seconds) until the action will expire,
+# optionally reserving some time (also in seconds).
+def getRemainingTime(reservedTime=0):
+deadlineSeconds = int(os.getenv('__OW_DEADLINE', 6)) / 1000
 
 Review comment:
   `__OW_DEADLINE` is always a positive number?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #187: create development guide

2017-08-07 Thread git

dubeejw commented on a change in pull request #187: create development guide
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/187#discussion_r131715584

Review comment:
Missing period.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2490: CLI summaries for actions without annotations

2017-08-07 Thread git

dubeejw commented on issue #2490: CLI summaries for actions without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#issuecomment-320726609
 
 
   @underwoodb-sd-ibm, looks like Travis failed here.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-07 Thread git

underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131702597
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##
 @@ -41,13 +41,7 @@ import (
 "bytes"
 )
 
-type QualifiedName struct {
-namespace   string  // namespace. does not include leading '/'.  may be "" 
(i.e. default namespace)
-packageName string  // package.  may be "".  does not include 
leading/trailing '/'
-entity  string  // entity.  should not be ""
-entityName  string  // pkg+entity
-}
-
+// TODO: DELETE THIS BLOCK OF CODE ONCE API-EXPERIMENTAL IS 
REMOVED!
 
 Review comment:
   Sorry - I wasn't sure about the timeline for api-experimental being removed, 
and so I was trying to be proactive in case there was some chance this might 
get merged before that specific change. I reverted all api-experimental code 
back to the way it was before I made changes to it, and a added this code back 
in so that tests would still run properly in playground/travis. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: (Review) Leading Slash (CLI issue #2328)

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: (Review) Leading Slash 
(CLI issue #2328)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131698077
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##
 @@ -140,29 +134,21 @@ func getNamespace() (string) {
 return namespace
 }
 
-/*
-Return a fully qualified name given a (possibly fully qualified) resource name 
and optional namespace.
+func parseQualifiedNameError(entityName string, err error) (error) {
+whisk.Debug(whisk.DbgError, "parseQualifiedName(%s) failed: %s\n", 
entityName, err)
 
-Examples:
-  (foo, None) => /_/foo
-  (pkg/foo, None) => /_/pkg/foo
-  (foo, ns) => /ns/foo
-  (/ns/pkg/foo, None) => /ns/pkg/foo
-  (/ns/pkg/foo, otherns) => /ns/pkg/foo
-*/
-func getQualifiedName(name string, namespace string) (string) {
-if strings.HasPrefix(name, "/") {
-return name
-} else if strings.HasPrefix(namespace, "/")  {
-return fmt.Sprintf("%s/%s", namespace, name)
-} else {
-if len(namespace) == 0 {
-namespace = Properties.Namespace
-}
-return fmt.Sprintf("/%s/%s", namespace, name)
-}
+errMsg := wski18n.T(
+"'{{.name}}' is not a valid qualified name: {{.err}}",
+map[string]interface{}{
+"name": entityName,
+"err": err,
+})
+
+return whisk.MakeWskError(errors.New(errMsg), whisk.EXITCODE_ERR_GENERAL, 
whisk.DISPLAY_MSG, whisk.DISPLAY_USAGE)
 }
 
+// END OF TODO: DELETE BLOCK***
 
 Review comment:
   ???
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2424: (Review) Leading Slash (CLI issue #2328)

2017-08-07 Thread git

dubeejw commented on a change in pull request #2424: (Review) Leading Slash 
(CLI issue #2328)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131698055
 
 

 ##
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##
 @@ -41,13 +41,7 @@ import (
 "bytes"
 )
 
-type QualifiedName struct {
-namespace   string  // namespace. does not include leading '/'.  may be "" 
(i.e. default namespace)
-packageName string  // package.  may be "".  does not include 
leading/trailing '/'
-entity  string  // entity.  should not be ""
-entityName  string  // pkg+entity
-}
-
+// TODO: DELETE THIS BLOCK OF CODE ONCE API-EXPERIMENTAL IS 
REMOVED!
 
 Review comment:
   ???
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2490: Summary Update (cli issue #2270)

2017-08-07 Thread git

dubeejw commented on a change in pull request #2490: Summary Update (cli issue 
#2270)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131695713
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -520,6 +690,84 @@ class WskBasicTests
 stdout should include regex (s"trigger /$ns/$name: Trigger 
description\\s*\\(parameters: paramName1, paramName2\\)")
 }
 
+it should "create, and get a trigger summary without a description and/or 
parameters" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val trgNoDesc = "trgNoDesc"
+val trgNoParams = "trgNoParams"
+val trgNoDescOrParams = "trgNoDescOrParams"
+val trgDesc = "Package description"
+val descFromParams = "Returns a result based on parameters"
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
+val qualtrgNoDesc = s"/${ns_regex_list}/${trgNoDesc}"
+val qualtrgNoParams = s"/${ns_regex_list}/${trgNoParams}"
+val qualtrgNoDescOrParams = 
s"/${ns_regex_list}/${trgNoDescOrParams}"
+
+val trgAnnotsNoParams = Map(
+"description" -> JsString(trgDesc)
+)
+val trgAnnotsNoDesc = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString("paramName1"),
+"description" -> JsString("Parameter description 1")),
+JsObject(
+"name" -> JsString("paramName2"),
+"description" -> JsString("Parameter description 2"
+
+assetHelper.withCleaner(wsk.trigger, trgNoDesc) {
+(trigger, _) =>
+trigger.create(trgNoDesc, annotations = trgAnnotsNoDesc)
+}
+assetHelper.withCleaner(wsk.trigger, trgNoParams) {
+(trigger, _) =>
+trigger.create(trgNoParams, annotations = 
trgAnnotsNoParams)
+}
+assetHelper.withCleaner(wsk.trigger, trgNoDescOrParams) {
+(trigger, _) =>
+trigger.create(trgNoDescOrParams)
+}
+
+val stdoutNoDescPkg = wsk.trigger.get(trgNoDesc, summary = 
true).stdout
+val stdoutNoParamsPkg = wsk.trigger.get(trgNoParams, summary = 
true).stdout
+val stdoutNoDescOrParams = wsk.trigger.get(trgNoDescOrParams, 
summary = true).stdout
+
+stdoutNoDescPkg should include regex (
+s"(?i)trigger ${qualtrgNoDesc}: ${descFromParams} paramName1 
and paramName2\\s*\\(parameters: paramName1, paramName2\\)")
+stdoutNoParamsPkg should include regex (
+s"(?i)trigger ${qualtrgNoParams}: ${trgDesc}\\s*\\(parameters: 
none defined\\)")
+stdoutNoDescOrParams should include regex (
+s"(?i)trigger ${qualtrgNoDescOrParams}\\s*\\(parameters: none 
defined\\)")
+}
+
+it should "denote bound trigger parameters for trigger summaries" in 
withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val trgBoundParams = "trgBoundParams"
+val trgParamAnnot = "trgParamAnnot"
+val trgParamOverlap = "trgParamOverlap"
+val trgParamBound = "trgParamBound"
+val trgAnnots = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString(trgParamAnnot),
+"description" -> JsString("Annotated")),
+JsObject(
+"name" -> JsString(trgParamOverlap),
+"description" -> JsString("Annotated And Bound"
+val trgParamsBound = Map(
+trgParamBound -> JsString("Bound"),
+trgParamOverlap -> JsString("Bound And Annotated"))
+
+assetHelper.withCleaner(wsk.trigger, trgBoundParams) {
+(trigger, _) =>
+trigger.create(trgBoundParams, annotations = trgAnnots, 
parameters = trgParamsBound)
+}
+
+val trgStdoutBound = wsk.trigger.get(trgBoundParams, summary = 
true).stdout
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
 
 Review comment:
   ns_regex_list not used.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2490: Summary Update (cli issue #2270)

2017-08-07 Thread git

dubeejw commented on a change in pull request #2490: Summary Update (cli issue 
#2270)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131695011
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -130,6 +130,84 @@ class WskBasicTests
 stdout should include regex (s"(?i)action 
/$ns/$packageName/$actionName: Action description\\s*\\(parameters: paramName1, 
paramName2\\)")
 }
 
+it should "create, and get a package summary without a description and/or 
parameters" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val pkgNoDesc = "pkgNoDesc"
+val pkgNoParams = "pkgNoParams"
+val pkgNoDescOrParams = "pkgNoDescOrParams"
+val pkgDesc = "Package description"
+val descFromParams = "Returns a result based on parameters"
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
+val qualpkgNoDesc = s"/${ns_regex_list}/${pkgNoDesc}"
+val qualpkgNoParams = s"/${ns_regex_list}/${pkgNoParams}"
+val qualpkgNoDescOrParams = 
s"/${ns_regex_list}/${pkgNoDescOrParams}"
+
+val pkgAnnotsNoParams = Map(
+"description" -> JsString(pkgDesc)
+)
+val pkgAnnotsNoDesc = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString("paramName1"),
+"description" -> JsString("Parameter description 1")),
+JsObject(
+"name" -> JsString("paramName2"),
+"description" -> JsString("Parameter description 2"
+
+assetHelper.withCleaner(wsk.pkg, pkgNoDesc) {
+(pkg, _) =>
+pkg.create(pkgNoDesc, annotations = pkgAnnotsNoDesc)
+}
+assetHelper.withCleaner(wsk.pkg, pkgNoParams) {
+(pkg, _) =>
+pkg.create(pkgNoParams, annotations = pkgAnnotsNoParams)
+}
+assetHelper.withCleaner(wsk.pkg, pkgNoDescOrParams) {
+(pkg, _) =>
+pkg.create(pkgNoDescOrParams)
+}
+
+val stdoutNoDescPkg = wsk.pkg.get(pkgNoDesc, summary = true).stdout
+val stdoutNoParamsPkg = wsk.pkg.get(pkgNoParams, summary = 
true).stdout
+val stdoutNoDescOrParams = wsk.pkg.get(pkgNoDescOrParams, summary 
= true).stdout
+
+stdoutNoDescPkg should include regex (
+s"(?i)package ${qualpkgNoDesc}: ${descFromParams} paramName1 
and paramName2\\s*\\(parameters: paramName1, paramName2\\)")
+stdoutNoParamsPkg should include regex (
+s"(?i)package ${qualpkgNoParams}: ${pkgDesc}\\s*\\(parameters: 
none defined\\)")
+stdoutNoDescOrParams should include regex (
+s"(?i)package ${qualpkgNoDescOrParams}\\s*\\(parameters: none 
defined\\)")
+}
+
+it should "denote bound package parameters for package summaries" in 
withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val pkgBoundParams = "pkgBoundParams"
+val pkgParamAnnot = "pkgParamAnnot"
+val pkgParamOverlap = "pkgParamOverlap"
+val pkgParamBound = "pkgParamBound"
+val pkgAnnots = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString(pkgParamAnnot),
+"description" -> JsString("Annotated")),
+JsObject(
+"name" -> JsString(pkgParamOverlap),
+"description" -> JsString("Annotated And Bound"
+val pkgParamsBound = Map(
+pkgParamBound -> JsString("Bound"),
+pkgParamOverlap -> JsString("Bound And Annotated"))
+
+assetHelper.withCleaner(wsk.pkg, pkgBoundParams) {
+(pkg, _) =>
+pkg.create(pkgBoundParams, annotations = pkgAnnots, 
parameters = pkgParamsBound)
+}
+
+val pkgStdoutBound = wsk.pkg.get(pkgBoundParams, summary = 
true).stdout
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
 
 Review comment:
   ns_regex_list is not used in this test.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #2490: Summary Update (cli issue #2270)

2017-08-07 Thread git

dubeejw commented on a change in pull request #2490: Summary Update (cli issue 
#2270)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131692831
 
 

 ##
 File path: docs/packages.md
 ##
 @@ -131,11 +139,16 @@ In the following simple example, you bind to the 
`/whisk.system/samples` package
   $ wsk package get --summary valhallaSamples
   ```
   ```
-  package /myNamespace/valhallaSamples
-   action /myNamespace/valhallaSamples/greeting: Returns a friendly greeting
-   action /myNamespace/valhallaSamples/wordCount: Count words in a string
-   action /myNamespace/valhallaSamples/helloWorld: Demonstrates logging 
facilities
-   action /myNamespace/valhallaSamples/curl: Curl a host url
+  package /Brandon.Lee.Underwood_guest/valhallaSamples: Returns a result based 
on parameter place
 
 Review comment:
   Probably want to remove your name here and the references below.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm closed pull request #2490: Summary Update (cli issue #2270)

2017-08-07 Thread git

underwoodb-sd-ibm closed pull request #2490: Summary Update (cli issue #2270)
URL: https://github.com/apache/incubator-openwhisk/pull/2490
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm opened a new pull request #2490: Summary Update (cli issue #2270)

2017-08-07 Thread git

underwoodb-sd-ibm opened a new pull request #2490: Summary Update (cli issue 
#2270)
URL: https://github.com/apache/incubator-openwhisk/pull/2490
 
 
   This update is intended to clarify the printed summary when one uses `wsk 
[ENTITY] [ENTITY_NAME] get --summary`.
   
   Here is an example of what the output of this update should look like:
   
   For entities with multiple parameters and no description:
   ```
   $ wsk action get hola -s
   action /guest/hola: Returns a result based on parameters testA, testB and 
testC
  (parameters: testA, testB, testC)
   ```
   
   For entities with a single parameter and no description:
   ```
   $ wsk action get hola -s
   action /guest/hola: Returns a result based on parameter testA
  (parameters: testA)
   ```
   
   And entities with no parameters and no description:
   ```
   $ wsk action get hello -s
   action /guest/hello
  (Warning: /guest/hello has no annotations)
   ```
   
Closes https://github.com/apache/incubator-openwhisk/issues/2270
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #2578: Update dependencies and gitignore

2017-08-07 Thread git

cbickel commented on issue #2578: Update dependencies and gitignore
URL: 
https://github.com/apache/incubator-openwhisk/pull/2578#issuecomment-320690587
 
 
   PG4#641 is ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320663489
 
 
   @dubeejw: Sorry for the confusion - @mdeuser and I discussed it in person 
and over slack last week, and my understanding was to use the flag @rabbah 
suggested for `--time`, and have lists sort alphabetically by default. This 
question might still be up in the air? I can switch it back fairly easily, if 
we need to continue that conversation. :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git

dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320675253
 
 
   @mdeuser, any review comments?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jthomas commented on issue #65: feat: Support version when create / update action

2017-08-07 Thread git

jthomas commented on issue #65: feat: Support version when create / update 
action
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320671714
 
 
   I didn't know the version could be set, that's interesting @ert78gb. 
   
   Thanks for adding tests along with the code. Can you please update the 
README to document this new parameter? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes commented on a change in pull request #2338: Prepare cache to change it by configuration

2017-08-07 Thread git

markusthoemmes commented on a change in pull request #2338: Prepare cache to 
change it by configuration
URL: 
https://github.com/apache/incubator-openwhisk/pull/2338#discussion_r131658957
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/core/database/CouchDbStoreProvider.scala
 ##
 @@ -23,20 +23,25 @@ import whisk.common.Logging
 import whisk.core.WhiskConfig
 import whisk.spi.Dependencies
 import whisk.spi.SpiFactory
+import whisk.core.entity.DocInfo
 
 /**
  * A CouchDB implementation of ArtifactStoreProvider
  */
 class CouchDbStoreProvider extends ArtifactStoreProvider {
-def makeStore[D <: DocumentSerializer](config: WhiskConfig, name: 
WhiskConfig => String)(
+def makeStore[D <: DocumentSerializer, CacheAbstraction](config: 
WhiskConfig, name: WhiskConfig => String, cache: 
Option[WhiskCache[CacheAbstraction, DocInfo]])(
 implicit jsonFormat: RootJsonFormat[D],
 actorSystem: ActorSystem,
-logging: Logging): ArtifactStore[D] = {
+logging: Logging): ArtifactStore[D, CacheAbstraction] = {
 require(config != null && config.isValid, "config is undefined or not 
valid")
 require(config.dbProvider == "Cloudant" || config.dbProvider == 
"CouchDB", "Unsupported db.provider: " + config.dbProvider)
 assume(Set(config.dbProtocol, config.dbHost, config.dbPort, 
config.dbUsername, config.dbPassword, name(config)).forall(_.nonEmpty), "At 
least one expected property is missing")
 
-new CouchDbRestStore[D](config.dbProtocol, config.dbHost, 
config.dbPort.toInt, config.dbUsername, config.dbPassword, name(config))
+new CouchDbRestStore[D, CacheAbstraction](config.dbProtocol, 
config.dbHost, config.dbPort.toInt, config.dbUsername, config.dbPassword, 
name(config), cache)
+}
+
+def makeCache[CacheAbstraction](): WhiskCache[CacheAbstraction, DocInfo] = 
{
+new MultipleReadersSingleWriterCache[CacheAbstraction, DocInfo]()
 
 Review comment:
   Should we move this implementation to `ArtifactStoreProvider`? After all, 
it's not relying on implementation details.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet opened a new pull request #82: Applying filter on all db changes since 0 takes too long

2017-08-07 Thread git

jasonpet opened a new pull request #82: Applying filter on all db changes since 
0 takes too long
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/82
 
 
   Updating provider to use a view for loading all existing triggers into 
memory on startup.  Will continue to use the filter for follow.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel closed pull request #2581: Add JMX arguments to docker-machine again.

2017-08-07 Thread git

cbickel closed pull request #2581: Add JMX arguments to docker-machine again.
URL: https://github.com/apache/incubator-openwhisk/pull/2581
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

rabbah commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320665803
 
 
   FYI: Assets in the database are sorted by last update time. Activations by 
their start time. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-07 Thread git

spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-320664046
 
 
   @devbv 
   thank you for your quick response.
   Actually there are no logs under the concul folder under wsklogs folder. So 
maybe something bad happened with it.
   To install a whole system again do I just follow the steps I mentioned in my 
first issue comment. Do I need to clean this install first by running teardown 
and wipe?
   thank you again!
   regards
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320663489
 
 
   @dubeejw: Sorry for the confusion - @mdeuser and I discussed it in person 
and over slack last week, and my understanding was to use the flag @rabbah 
suggested for `--time`, and have lists sort alphabetically by default. This 
question might still be up in the air? I can switch it back fairly easily, if 
we need to continue that conversation. :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjustin-ibm commented on issue #187: create development guide

2017-08-07 Thread git

bjustin-ibm commented on issue #187: create development guide
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/187#issuecomment-320662658
 
 
   @dubeejw please review
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #2085: swift3 docker build speed boost base on image

2017-08-07 Thread git

csantanapr commented on issue #2085: swift3 docker build speed boost base on 
image
URL: 
https://github.com/apache/incubator-openwhisk/pull/2085#issuecomment-320660270
 
 
   @markusthoemmes this PR is not good as I'm afraid it will break pre-compiled 
zip actions. 
   I think you already took care by pinning the publish image
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

mdeuser commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320657070
 
 
   @underwoodb-sd-ibm - is the behavior now working per 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-316849925 ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel closed pull request #2580: Temporalily use published swift3Action.

2017-08-07 Thread git

cbickel closed pull request #2580: Temporalily use published swift3Action.
URL: https://github.com/apache/incubator-openwhisk/pull/2580
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes opened a new pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git

markusthoemmes opened a new pull request #2582: Use non-blocking techniques 
when interfacing to Kafka.
URL: https://github.com/apache/incubator-openwhisk/pull/2582
 
 
   Producing a message can be done with a callback upon receiving the message, 
effectively acting as a non-blocking API.
   
   Consuming a message is a bit trickier. Adding `blocking` instructs the 
default dispatcher to create new threads if necessary.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320644274
 
 
   @rabbah, @mdeuser, @dubeejw: I've made changes to Alphabetize (reflected in 
the top comment) as Mark helped me to better understand what we were looking 
for with this PR last week. I am going in to temporarily remove the `-t` flag 
from APIs, as we don't necessarily know if they are being returned in order of 
creation time or not, but other than that (and a few tab errors that I have 
fixed), Alphabetize has passed PG2 1908. I'm sure that another PG will need to 
be run after I adjust APIs, but what other feedback could you suggest that I 
could work on to get Alphabetize merge-ready? Thanks!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI

2017-08-07 Thread git

underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320644274
 
 
   @rabbah, @mdeuser, @dubeejw: I've made changes to Alphabetize (reflected in 
the top comment) as Mark helped me to better understand what we were looking 
for with this PR last week. I am going in to temporarily remove the `-t` flag 
from APIs, as we don't necessarily know if they are being returned in order of 
creation time or not, but other than that (and a few tab errors that I have 
fixed), Alphabetize has passed PG2 #1908. I'm sure that another PG will need to 
be run after I adjust APIs, but what other feedback could you suggest that I 
could work on to get Alphabetize merge-ready? Thanks!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes opened a new pull request #2581: Add JMX arguments to docker-machine again.

2017-08-07 Thread git

markusthoemmes opened a new pull request #2581: Add JMX arguments to 
docker-machine again.
URL: https://github.com/apache/incubator-openwhisk/pull/2581
 
 
   Apparently got lost while adding Docker for Mac.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjustin-ibm commented on issue #210: How to use message feed

2017-08-07 Thread git

bjustin-ibm commented on issue #210: How to use message feed
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/issues/210#issuecomment-320637022
 
 
   Ah ok... the most likely problem is that `localhost` does not resolve to 
what you think it does. Keep in mind that actions run inside docker containers, 
and name resolution for things like `localhost` and `127.0.0.1` get a little 
tricky. 
   
   I suggest that instead of using `localhost` as your `edgehost` and `apihost` 
argument values when installing the actions, you use a real IP address that can 
be used for cross-container communication: 
https://github.com/bjustin-ibm/openwhisk-package-kafka/blob/5f9c08daa845b7c376f236e6cc8ede9a32243138/devGuide.md#install-actions
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-07 Thread git

spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-320631100
 
 
   @devbv @rabbah ..please help. i am not able to understand why it is failing. 
the controller logs keeps showing the following  error lines.
   
   [2017-08-07T01:34:06.970Z] [INFO] [??] [WhiskConfig] reading properties from 
consul at 172.17.0.1:8500
   [2017-08-07T01:34:08.279Z] [WARN] [??] [WhiskConfig] failed to read 
properties from consul: The http server closed the connection unexpectedly 
before delivering responses for 1 outstanding requests
   [2017-08-07T01:34:08.286Z] [ERROR] [??] [Config] required property db.port 
still not set
   [2017-08-07T01:34:08.287Z] [ERROR] [??] [Controller] Bad configuration, 
cannot start.
   
   is the above error in post deployment due to above error. how to fix it? 
   
   thank you very for your time and effort
   
   regards
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Katiyman commented on issue #61: Could not get unknown property 'sourceSets' for project ':whisktests' of type org.gradle.api.Project.

2017-08-07 Thread git

Katiyman commented on issue #61: Could not get unknown property 'sourceSets' 
for project ':whisktests' of type org.gradle.api.Project.
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/issues/61#issuecomment-320600392
 
 
   @zhy989 I simply exported it as an env variable and it worked.. you can try 
same may be some user issue becoz of sudo
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes opened a new pull request #2580: Temporalily use published swift3Action.

2017-08-07 Thread git

markusthoemmes opened a new pull request #2580: Temporalily use published 
swift3Action.
URL: https://github.com/apache/incubator-openwhisk/pull/2580
 
 
   The download of Swift 3.0.2 on swift.org is broken and will only be revived 
in a couple of days. This effectively freezes the swift3Action image to the 
latest published version on Dockerhub. There are no changes imminent anyway.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes commented on issue #2085: swift3 docker build speed boost base on image

2017-08-07 Thread git

markusthoemmes commented on issue #2085: swift3 docker build speed boost base 
on image
URL: 
https://github.com/apache/incubator-openwhisk/pull/2085#issuecomment-320602043
 
 
   @csantanapr can we revive this seeing the latest build breakages due to 
swift downloads directly from swift.org.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Katiyman commented on issue #2264: Unable to connect to the controller docker: Controller docker not starting

2017-08-07 Thread git

Katiyman commented on issue #2264: Unable to connect to the controller docker: 
Controller docker not starting
URL: 
https://github.com/apache/incubator-openwhisk/issues/2264#issuecomment-320601331
 
 
   @saurabh1284 Couchdb i installed both ephemeral as well as local. both 
worked for me.
   Consul i used a the consul docker container which is the part of the 
openwhisk setup.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Katiyman commented on issue #61: Could not get unknown property 'sourceSets' for project ':whisktests' of type org.gradle.api.Project.

2017-08-07 Thread git

Katiyman commented on issue #61: Could not get unknown property 'sourceSets' 
for project ':whisktests' of type org.gradle.api.Project.
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/issues/61#issuecomment-320600392
 
 
   @zhy989 I simply export it as an env variable and it worked.. you can try 
same may be some user issue becoz of sudo
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Katiyman commented on issue #2221: Unable to create trigger

2017-08-07 Thread git

Katiyman commented on issue #2221: Unable to create trigger 
URL: 
https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320599754
 
 
   I am not sure about api-gateway... but it can be a no_proxy issue.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #65: feat: Support version when create / update action

2017-08-07 Thread git

codecov-io commented on issue #65: feat: Support version when create / update 
action
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320595097
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=h1)
 Report
   > Merging 
[#65](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65/graphs/tree.svg?height=150=j2mPEx0Tkq=650=pr)](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master  #65  +/-   ##
   ==
   + Coverage   99.37%   99.37%   +<.01% 
   ==
 Files  14   14  
 Lines 318  320   +2 
   ==
   + Hits  316  318   +2 
 Misses  22
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[lib/actions.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree#diff-bGliL2FjdGlvbnMuanM=)
 | `100% <100%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=footer).
 Last update 
[d4b69d7...e37633f](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ert78gb opened a new pull request #65: feat: Support version when create / update action

2017-08-07 Thread git

ert78gb opened a new pull request #65: feat: Support version when create / 
update action
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65
 
 
   The [REST 
API](https://console.bluemix.net/apidocs/98-ibm-bluemix-openwhisk?=undefined=node_id=ibm:yp:eu-gb#create-or-update-an-action)
 support version number, when create or update an action. The parameter is 
optional and if it is empty the system increment the patch version number.
   
   When action invoke the system store the version number in the log. Very 
useful to know what version of the action have invoked when investigating a bug.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj closed pull request #303: Upload v0.8.6 of pkging Spec. as PDF.

2017-08-07 Thread git

lzbj closed pull request #303: Upload v0.8.6 of pkging Spec. as PDF.
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/303
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj closed pull request #302: Update images.md

2017-08-07 Thread git

lzbj closed pull request #302: Update images.md
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/302
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj commented on issue #304: Support of list for openwhisk entities

2017-08-07 Thread git

lzbj commented on issue #304: Support of list for openwhisk entities
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/304#issuecomment-320591261
 
 
   @houshengbo , I remember we discussed this issue before, but let's see what 
Matt's comments.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

1 2 >

1 - 100 of 104 matches

Mail list logo