date:20180307

[GitHub] kameshsampath commented on issue #26: Multiple Distros for Java Runtimes

2018-03-07 Thread GitBox

kameshsampath commented on issue #26: Multiple Distros for Java Runtimes
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/26#issuecomment-371398396
 
 
   > But do we need to support images based on different distributions. Can't 
we have single distribution across multiple architectures. (could be 
alpine/musl based image).
   
   IMHO yes.  My thoughts:
   
   - Alpine is not suited for production env and it has some security flaws. I 
have seen some thread where they have issues with JDK  > 1.8.1 u131 - this 
where Java started to understand `cgroups` still experimental options but soon 
would be in mainstream.
   
   - When to increase user adoption we need to support popular distros e.g 
centos and debian, that makes the developer extend these images with their 
favorite distros


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ddragosd commented on a change in pull request #2: Add DC/OS universe for OpenWhisk and orchestration scripts

2018-03-07 Thread GitBox

ddragosd commented on a change in pull request #2: Add DC/OS universe for 
OpenWhisk and orchestration scripts
URL: 
https://github.com/apache/incubator-openwhisk-deploy-mesos/pull/2#discussion_r173073325
 
 

 ##
 File path: README.md
 ##
 @@ -0,0 +1,17 @@
+# OpenWhisk Deployment for Mesos
+
+[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0)
+[![Build 
Status](https://travis-ci.org/apache/incubator-openwhisk-deploy-mesos.svg?branch=master)](https://travis-ci.org/apache/incubator-openwhisk-deploy-mesos)
+
+This repository is part of [Apache 
OpenWhisk](http://openwhisk.incubator.apache.org/) and can be used to deploy 
OpenWhisk to a Mesos cluster.
+
+## Subprojects
+
+* TODO
 
 Review comment:
   will we have subprojects in this repo ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ddragosd commented on a change in pull request #2: Add DC/OS universe for OpenWhisk and orchestration scripts

2018-03-07 Thread GitBox

ddragosd commented on a change in pull request #2: Add DC/OS universe for 
OpenWhisk and orchestration scripts
URL: 
https://github.com/apache/incubator-openwhisk-deploy-mesos/pull/2#discussion_r173073819
 
 

 ##
 File path: dcos-deploy-script/Makefile
 ##
 @@ -0,0 +1,127 @@
+DCOS_ENDPOINT ?= 
+APIGATEWAY_DNS ?= 
+OPENWHISK_UNIVERSE ?= 
+WSK_NAMESPACE ?= guest
+WSK_AUTH_TOKEN ?= 
+
+cli:
 
 Review comment:
   like with the universe docker bellow, WDYT about exposing a docker image 
with the dcos CLI and potentially wsk CLI that could be used to execute these 
scripts in any environments ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Param-S commented on issue #26: Multiple Distros for Java Runtimes

2018-03-07 Thread GitBox

Param-S commented on issue #26: Multiple Distros for Java Runtimes
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/26#issuecomment-371381160
 
 
   I see, 2 requirements,
   1. Supporting different architectures
   2. Supporting different distributions
   
   Yes, I agree with supporting different architectures . But do we need to 
support images based on different distributions. Can't we have single 
distribution across multiple architectures. (could be alpine/musl based image). 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-03-07 Thread GitBox

chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect 
test coverage stats
URL: 
https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-371380551
 
 
   Rebased to latest master


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw closed pull request #67: Additional HTTP Headers

2018-03-07 Thread GitBox

dubeejw closed pull request #67: Additional HTTP Headers
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/67
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/whisk/client.go b/whisk/client.go
index d4e8afcf..7b4862ff 100644
--- a/whisk/client.go
+++ b/whisk/client.go
@@ -74,18 +74,19 @@ type Client struct {
 }
 
 type Config struct {
-   Namespacestring // NOTE :: Default is "_"
-   Cert string
-   Key  string
-   AuthTokenstring
-   Host string
-   BaseURL  *url.URL // NOTE :: Default is 
"openwhisk.ng.bluemix.net"
-   Version  string
-   Verbose  bool
-   Debugbool // For detailed tracing
-   Insecure bool
-   UserAgentstring
-   ApigwAccessToken string
+   Namespace string // NOTE :: Default is "_"
+   Cert  string
+   Key   string
+   AuthToken string
+   Host  string
+   BaseURL   *url.URL // NOTE :: Default is 
"openwhisk.ng.bluemix.net"
+   Version   string
+   Verbose   bool
+   Debug bool // For detailed tracing
+   Insecure  bool
+   UserAgent string
+   ApigwAccessToken  string
+   AdditionalHeaders http.Header
 }
 
 type ObfuscateSet struct {
@@ -283,6 +284,10 @@ func (c *Client) NewRequest(method, urlStr string, body 
interface{}, includeName
 
req.Header.Add("User-Agent", c.Config.UserAgent)
 
+   for key := range c.Config.AdditionalHeaders {
+   req.Header.Add(key, c.Config.AdditionalHeaders.Get(key))
+   }
+
return req, nil
 }
 
@@ -778,5 +783,9 @@ func (c *Client) NewRequestUrl(
 
req.Header.Add("User-Agent", c.Config.UserAgent)
 
+   for key := range c.Config.AdditionalHeaders {
+   req.Header.Add(key, c.Config.AdditionalHeaders.Get(key))
+   }
+
return req, nil
 }
diff --git a/whisk/client_test.go b/whisk/client_test.go
index 1752b40f..ec27b63f 100644
--- a/whisk/client_test.go
+++ b/whisk/client_test.go
@@ -140,3 +140,31 @@ func TestProxyHost(t *testing.T) {
assert.Contains(t, err.Error(), proxyhost, "Setting HTTPS_PROXY 
to '"+proxyhost+"' did not cause the CLI to use that proxy URL.")
}
 }
+
+func TestAdditionalHeaders(t *testing.T) {
+   config := GetValidConfigTest()
+   config.AdditionalHeaders = make(map[string][]string)
+   config.AdditionalHeaders.Add("Key1", "Value1")
+   config.AdditionalHeaders.Add("Key2", "Value2")
+
+   client, _ := NewClient(nil, config)
+   assert.NotNil(t, client)
+
+   newRequest, newRequestErr := client.NewRequest("GET", 
config.BaseURL.String(), nil, false)
+   assert.Nil(t, newRequestErr, "NewRequest for proxy test failed.")
+   if newRequestErr != nil {
+   fmt.Printf("NewRequest() error: %s\n", newRequestErr.Error())
+   }
+
+   assert.Equal(t, "Value1", newRequest.Header.Get("Key1"))
+   assert.Equal(t, "Value2", newRequest.Header.Get("Key2"))
+
+   newRequestUrl, newRequestUrlErr := client.NewRequestUrl("GET", 
config.BaseURL, nil, false, false, "", false)
+   assert.Nil(t, newRequestUrlErr, "NewRequest for proxy test failed.")
+   if newRequestUrlErr != nil {
+   fmt.Printf("NewRequest() error: %s\n", newRequestUrlErr.Error())
+   }
+
+   assert.Equal(t, "Value1", newRequestUrl.Header.Get("Key1"))
+   assert.Equal(t, "Value2", newRequestUrl.Header.Get("Key2"))
+}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #3411: refactor KubernetesClient to separate invokerAgent; add forwarding LogStoreProvider

2018-03-07 Thread GitBox

dgrove-oss commented on issue #3411: refactor KubernetesClient to separate 
invokerAgent; add forwarding LogStoreProvider
URL: 
https://github.com/apache/incubator-openwhisk/pull/3411#issuecomment-371357346
 
 
   PG3 / 1970 ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #67: Additional HTTP Headers

2018-03-07 Thread GitBox

mdeuser commented on issue #67: Additional HTTP Headers
URL: 
https://github.com/apache/incubator-openwhisk-client-go/pull/67#issuecomment-371355681
 
 
   i think i understand.  this is for setting a header that will appear in 
any/all subsequent request to the backend; not for setting header(s) on a 
per-request basis.   LGTM..  but perhaps a comment on that AdditionalHeaders 
would help clarify.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new pull request #776: Adding support for Inline Code and reading action source from URL

2018-03-07 Thread GitBox

pritidesai opened a new pull request #776: Adding support for Inline Code and 
reading action source from URL
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/776
 
 
   Closes #745 
   Closes #622 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on a change in pull request #3411: refactor KubernetesClient to separate invokerAgent; add forwarding LogStoreProvider

2018-03-07 Thread GitBox

dgrove-oss commented on a change in pull request #3411: refactor 
KubernetesClient to separate invokerAgent; add forwarding LogStoreProvider
URL: 
https://github.com/apache/incubator-openwhisk/pull/3411#discussion_r173040613
 
 

 ##
 File path: 
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContainer.scala
 ##
 @@ -110,6 +114,23 @@ class KubernetesContainer(protected[core] val id: 
ContainerId,
 
   private val stringSentinel = DockerContainer.ActivationSentinel.utf8String
 
+  def forwardLogs(sizeLimit: ByteSize,
+  sentinelledLogs: Boolean,
+  additionalMetadata: Map[String, JsValue],
+  augmentedActivation: JsObject)(implicit transid: 
TransactionId): Future[Unit] = {
+kubernetes match {
+  case client: KubernetesClientWithInvokerAgent => {
+client
+  .forwardLogs(this, lastOffset.get(), sizeLimit, sentinelledLogs, 
additionalMetadata, augmentedActivation)
 
 Review comment:
   I debated two options here.  It also would work to "inline" the forwardLogs 
code from KubernetesClientWithInvokerAgent here and use the agentCommand method 
externally.  That would mean that some knowledge of the invokerAgent REST API 
would leak into KubernetesContainer, but it would reduce the back 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on a change in pull request #3411: refactor KubernetesClient to separate invokerAgent; add forwarding LogStoreProvider

2018-03-07 Thread GitBox

dgrove-oss commented on a change in pull request #3411: refactor 
KubernetesClient to separate invokerAgent; add forwarding LogStoreProvider
URL: 
https://github.com/apache/incubator-openwhisk/pull/3411#discussion_r173040613
 
 

 ##
 File path: 
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContainer.scala
 ##
 @@ -110,6 +114,23 @@ class KubernetesContainer(protected[core] val id: 
ContainerId,
 
   private val stringSentinel = DockerContainer.ActivationSentinel.utf8String
 
+  def forwardLogs(sizeLimit: ByteSize,
+  sentinelledLogs: Boolean,
+  additionalMetadata: Map[String, JsValue],
+  augmentedActivation: JsObject)(implicit transid: 
TransactionId): Future[Unit] = {
+kubernetes match {
+  case client: KubernetesClientWithInvokerAgent => {
+client
+  .forwardLogs(this, lastOffset.get(), sizeLimit, sentinelledLogs, 
additionalMetadata, augmentedActivation)
 
 Review comment:
   I debated two options here.  It also would work to "inline" the forwardLogs 
code from KubernetesClientWithInvokerAgent here and use the agentCommand method 
externally.  That would mean that some knowledge of the invokerAgent protocol 
would leak into KubernetesContainer, but it would reduce the back 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri opened a new pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-07 Thread GitBox

jonpspri opened a new pull request #3412: Changes to runtimes variables in 
support of retiring 'whisk/*' runtimes
URL: https://github.com/apache/incubator-openwhisk/pull/3412
 
 
   Changes to ansible processes for determining and maybe pulling runtime 
images, as a preliminary to eliminating the hardcoding of the 'whisk' prefix 
for runtime docker images.
   
   ## Description
   As per discussion in #3407 , this PR contains changes to ansible processes 
that will be needed to support the removal of the need for 'whisk/*' images to 
be in place for builtin runtimes.  Instead,
   runtimes _may_ (do we eventually want _should_ or _must_?) be specified in 
the runtimes.json file.
   
   A pleasant side effect of this change is that all variables (I think) 
impacting runtimes have now been consolidated into the 'runtimes' YAML object 
in `ansible/group_vars/all`, and all overrides are tested and defaulted at that 
point.  There my be some redundant defaulting remaining in 
`ansible/roles/(controller|invoker)/tasks/deploy.yml`, but I'm trying to manage 
the number of changes and other maintenance risks that may creep in.
   
   Review and PG requested -- there may be breakage in the IBM Functions build.
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [X] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [X] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [X] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [X] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [X] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss closed pull request #3378: LogStoreProvider using invokerAgent for KubernetesContainerPool

2018-03-07 Thread GitBox

dgrove-oss closed pull request #3378: LogStoreProvider using invokerAgent for 
KubernetesContainerPool
URL: https://github.com/apache/incubator-openwhisk/pull/3378
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
 
b/common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
index 4be36a730a..0a7f9e8c14 100644
--- 
a/common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
+++ 
b/common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
@@ -22,21 +22,22 @@ import java.time.Instant
 
 import akka.NotUsed
 import akka.actor.ActorSystem
+import akka.http.scaladsl.model.HttpRequest
 import akka.stream.alpakka.file.scaladsl.LogRotatorSink
-import akka.stream.{Graph, SinkShape, UniformFanOutShape}
+import akka.stream.{ActorMaterializer, Graph, SinkShape, UniformFanOutShape}
 import akka.stream.scaladsl.{Broadcast, Flow, GraphDSL, Keep, MergeHub, Sink, 
Source}
 import akka.util.ByteString
 
 import whisk.common.TransactionId
 import whisk.core.containerpool.Container
-import whisk.core.entity.{ActivationLogs, ExecutableWhiskAction, Identity, 
WhiskActivation}
+import whisk.core.entity._
 import whisk.core.entity.size._
 import whisk.http.Messages
 
 import spray.json._
 import spray.json.DefaultJsonProtocol._
 
-import scala.concurrent.Future
+import scala.concurrent.{ExecutionContext, Future}
 
 /**
  * Docker based implementation of a LogStore.
@@ -48,7 +49,17 @@ import scala.concurrent.Future
  * Additionally writes logs to a separate file which can be processed by any 
backend service asynchronously.
  */
 class DockerToActivationFileLogStore(system: ActorSystem, 
destinationDirectory: Path = Paths.get("logs"))
-extends DockerToActivationLogStore(system) {
+extends LogDriverForwarderLogStore(system) {
+
+  implicit val ec: ExecutionContext = system.dispatcher
+  implicit val mat: ActorMaterializer = ActorMaterializer()(system)
+
+  /* "json-file" is the log-driver that writes out to file */
+  override val containerParameters = Map("--log-driver" -> Set("json-file"))
+
+  /* As logs are already part of the activation record, just return that bit 
of it */
+  override def fetchLogs(user: Identity, activation: WhiskActivation, request: 
HttpRequest): Future[ActivationLogs] =
+Future.successful(activation.logs)
 
   /**
* End of an event as written to a file. Closes the json-object and also 
appends a newline.
@@ -92,22 +103,14 @@ class DockerToActivationFileLogStore(system: ActorSystem, 
destinationDirectory:
 }))
 .run()
 
-  override def collectLogs(transid: TransactionId,
-   user: Identity,
-   activation: WhiskActivation,
-   container: Container,
-   action: ExecutableWhiskAction): 
Future[ActivationLogs] = {
-
-val logs = container.logs(action.limits.logs.asMegaBytes, 
action.exec.sentinelledLogs)(transid)
-
-// Adding the userId field to every written record, so any background 
process can properly correlate.
-val userIdField = Map("namespaceId" -> user.authkey.uuid.toJson)
-
-val additionalMetadata = Map(
-  "activationId" -> activation.activationId.asString.toJson,
-  "action" -> action.fullyQualifiedName(false).asString.toJson) ++ 
userIdField
+  def forwardLogs(transid: TransactionId,
+  container: Container,
+  sizeLimit: ByteSize,
+  sentinelledLogs: Boolean,
+  additionalMetadata: Map[String, JsValue],
+  augmentedActivation: JsObject): Future[ActivationLogs] = {
 
-val augmentedActivation = JsObject(activation.toJson.fields ++ userIdField)
+val logs = container.logs(sizeLimit, sentinelledLogs)(transid)
 
 // Manually construct JSON fields to omit parsing the whole structure
 val metadata = ByteString("," + fieldsString(additionalMetadata))
@@ -124,7 +127,7 @@ class DockerToActivationFileLogStore(system: ActorSystem, 
destinationDirectory:
 val combined = OwSink.combine(toSeq, toFile)(Broadcast[ByteString](_))
 
 logs.runWith(combined)._1.flatMap { seq =>
-  val possibleErrors = Set(Messages.logFailure, 
Messages.truncateLogs(action.limits.logs.asMegaBytes))
+  val possibleErrors = Set(Messages.logFailure, 
Messages.truncateLogs(sizeLimit))
   val errored = seq.lastOption.exists(last => 
possibleErrors.exists(last.contains))
   val logs = ActivationLogs(seq.toVector)
   if (!errored) {
diff --git

[GitHub] rabbah commented on issue #2833: MesosContainerFactory

2018-03-07 Thread GitBox

rabbah commented on issue #2833: MesosContainerFactory
URL: 
https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-371326169
 
 
   My apologies. I should?ve switched the assignee so it?s on my queue. Will 
spend the time on this tomorrow, pg etc. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #2833: MesosContainerFactory

2018-03-07 Thread GitBox

rabbah commented on issue #2833: MesosContainerFactory
URL: 
https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-371326169
 
 
   My apologies. I should?ve switched the assignee so it?s on my queue. Will 
spend the time in this tomorrow, pg etc. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-07 Thread GitBox

tysonnorris commented on issue #2833: MesosContainerFactory
URL: 
https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-371325712
 
 
   @rabbah any comments on this? I have some upcoming changes for a 
separate/new PR to deal with HA deploy scenarios in mesos, that will make more 
sense if this is merged first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

csantanapr commented on issue #3388: Update require-whisk-auth behavior to 
secure web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371324124
 
 
   pg4/1451 ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #3410: Fix typos in api gw doc

2018-03-07 Thread GitBox

csantanapr closed pull request #3410: Fix typos in api gw doc
URL: https://github.com/apache/incubator-openwhisk/pull/3410
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/apigateway.md b/docs/apigateway.md
index be149f2099..49c88bb18d 100644
--- a/docs/apigateway.md
+++ b/docs/apigateway.md
@@ -10,7 +10,7 @@ For more information on API Gateway feature you can read the 
[api management doc
 
 ### OpenWhisk CLI configuration
 
-Follow the instructions in [Configure 
CLI](https://github.com/apache/incubator-openwhisk/blob/master/docs/cli.md) on 
how to set the authentication key for your specific namespace.
+Follow the instructions in [Configure 
CLI](./README.md#setting-up-the-openwhisk-cli) on how to set the authentication 
key for your specific namespace.
 
 ### Create your first API using the CLI
 
@@ -46,7 +46,8 @@ Follow the instructions in [Configure 
CLI](https://github.com/apache/incubator-o
   ```
   $ curl 
https://${APIHOST}:9001/api/${GENERATED_API_ID}/hello/world?name=OpenWhisk
   ```
-  ```
+
+  ```json
   {
   "payload": "Hello world OpenWhisk"
   }
@@ -205,15 +206,15 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /club/books/{isbn} get for action deleteBook
-https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
-ok: created api /club/books/{isbn} put for action deleteBook
-https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
-ok: created api /club/books/{isbn} delete for action deleteBook
-https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
-ok: created api /club/books get for action deleteBook
+ok: created api /club/books/{isbn} get for action getBooks
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
+ok: created api /club/books/{isbn} put for action putBooks
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
+ok: created api /club/books/{isbn} delete for action deleteBooks
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
+ok: created api /club/books get for action getBooks
 https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
-ok: created api /club/books post for action deleteBook
+ok: created api /club/books post for action postBooks
 https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
 ```
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371279807
 
 
   PG3 1969 ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #67: Additional HTTP Headers

2018-03-07 Thread GitBox

dubeejw commented on issue #67: Additional HTTP Headers
URL: 
https://github.com/apache/incubator-openwhisk-client-go/pull/67#issuecomment-371300767
 
 
   @mdeuser, `AdditionalHeaders` is meant for consumers of client-go that do 
not have access to `requestUrl()`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #67: Additional HTTP Headers

2018-03-07 Thread GitBox

dubeejw commented on issue #67: Additional HTTP Headers
URL: 
https://github.com/apache/incubator-openwhisk-client-go/pull/67#issuecomment-371300767
 
 
   @mdeuser, AdditionalHeader is meant for consumers of client-go that do not 
have access to `requestUrl()`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser opened a new pull request #3410: Fix typos in api gw doc

2018-03-07 Thread GitBox

mdeuser opened a new pull request #3410: Fix typos in api gw doc
URL: https://github.com/apache/incubator-openwhisk/pull/3410
 
 
   
   
   ## Description
   Documentation fix
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [x] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on a change in pull request #53: Change to use RAT maven plugin to support ASF short format header

2018-03-07 Thread GitBox

houshengbo commented on a change in pull request #53: Change to use RAT maven 
plugin to support ASF short format header
URL: 
https://github.com/apache/incubator-openwhisk-release/pull/53#discussion_r172995310
 
 

 ##
 File path: tools/verify_source_code.sh
 ##
 @@ -24,13 +24,10 @@ SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
 source "$SCRIPTDIR/load_config.sh" $1
 PARENTDIR="$(dirname "$SCRIPTDIR")"
 
-REPORT_DIR=$PARENTDIR/report
-REPORT_FILE=$REPORT_DIR/apache-rat-report.txt
-
-mkdir -p $REPORT_DIR
-touch $REPORT_FILE
-
-java -jar $SCRIPTDIR/lib/apache-rat-0.13-SNAPSHOT.jar -a 
$OPENWHISK_CLEANED_SOURCE_DIR > $REPORT_FILE
+# run Apache rat to check headers
+cd $OPENWHISK_CLEANED_SOURCE_DIR
+cp $SCRIPTDIR/lib/pom.xml ./
+mvn clean apache-rat:check
 
 Review comment:
   I think it is good to change line 38 of this file
   cd $OPENWHISK_CLEANED_SOURCE_DIR/$repo_name && ls {LICENSE*,NOTICE*}
   into 
   cd $OPENWHISK_SOURCE_DIR/$repo_name && ls {LICENSE*,NOTICE*}
   
   because we do not need to package the source before running 
verify_source_code.sh.
   
   Rebase ur code with the latest master. Besides the above change, it looks 
good to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

mdeuser commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172987431
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
 
 Review comment:
   indeed :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371285212
 
 
   or pg4/1451


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hsane2001 closed issue #2570: Cannot install APIgateway if http_proxy variable set in native environment

2018-03-07 Thread GitBox

hsane2001 closed issue #2570: Cannot install APIgateway if http_proxy variable 
set in native environment 
URL: https://github.com/apache/incubator-openwhisk/issues/2570
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed issue #54: Add the missing license header to the source files in each repo to be released

2018-03-07 Thread GitBox

houshengbo closed issue #54: Add the missing license header to the source files 
in each repo to be released
URL: https://github.com/apache/incubator-openwhisk-release/issues/54
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed pull request #3383: Add the license headers

2018-03-07 Thread GitBox

houshengbo closed pull request #3383: Add the license headers
URL: https://github.com/apache/incubator-openwhisk/pull/3383
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index d5d7d2f079..9fbd802ad4 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,4 +1,19 @@
-# A Travis CI configuration file.
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
 sudo: required
 
diff --git a/README.md b/README.md
index ff8f4346af..a8aea706d3 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,21 @@
+
+
 # OpenWhisk
 
 [![Build 
Status](https://travis-ci.org/apache/incubator-openwhisk.svg?branch=master)](https://travis-ci.org/apache/incubator-openwhisk)
diff --git a/actionRuntimes/actionProxy/README.md 
b/actionRuntimes/actionProxy/README.md
index ee5d5e91af..5413382bae 100644
--- a/actionRuntimes/actionProxy/README.md
+++ b/actionRuntimes/actionProxy/README.md
@@ -1,3 +1,21 @@
+
+
 Skeleton for "docker actions"
 
 
diff --git a/actionRuntimes/javaAction/delete-build-run.sh 
b/actionRuntimes/javaAction/delete-build-run.sh
index 665800f706..8765a319b8 100755
--- a/actionRuntimes/javaAction/delete-build-run.sh
+++ b/actionRuntimes/javaAction/delete-build-run.sh
@@ -1,4 +1,20 @@
 #!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
 # Useful for local testing.
 # USE WITH CAUTION !!
diff --git a/common/scala/copyJMXFiles.sh b/common/scala/copyJMXFiles.sh
index fc5004f957..8c3175d27d 100644
--- a/common/scala/copyJMXFiles.sh
+++ b/common/scala/copyJMXFiles.sh
@@ -1,4 +1,20 @@
 #!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
 if [[ $( ls /conf/jmxremote.* 2> /dev/null ) ]]
 then
diff --git a/common/scala/transformEnvironment.sh 
b/common/scala/transformEnvironment.sh
index 96539aa6ce..005f0bd7d2 100755
--- a/common/scala/transformEnvironment.sh
+++ b/common/scala/transformEnvironment.sh
@@ -1,4 +1,20 @@
 #!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an

[GitHub] dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371279807
 
 
   PG3 1969 ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

dubeejw commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371279253
 
 
   Can't get a PG to work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lionelvillard opened a new pull request #775: add --name project name flag

2018-03-07 Thread GitBox

lionelvillard opened a new pull request #775: add --name project name flag
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/775
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #23: Add the license headers

2018-03-07 Thread GitBox

pritidesai closed pull request #23: Add the license headers
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/23
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 4ec0def..d221471 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,3 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements.  See the NOTICE file distributed with this work for 
additional
+# information regarding copyright ownership.  The ASF licenses this file to you
+# under the Apache License, Version 2.0 (the # "License"); you may not use this
+# file except in compliance with the License.  You may obtain a copy of the 
License
+# at:
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software 
distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations under the License.
+#
+
 sudo: required
 group: deprecated-2017Q3
 language: scala
diff --git a/README.md b/README.md
index 81c151e..1c92f9d 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,21 @@
+
+
 # Apache OpenWhisk runtimes for java
 
 [![Build 
Status](https://travis-ci.org/apache/incubator-openwhisk-runtime-java.svg?branch=master)](https://travis-ci.org/apache/incubator-openwhisk-runtime-java)
diff --git a/core/javaAction/delete-build-run.sh 
b/core/javaAction/delete-build-run.sh
index 665800f..8765a31 100755
--- a/core/javaAction/delete-build-run.sh
+++ b/core/javaAction/delete-build-run.sh
@@ -1,4 +1,20 @@
 #!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
 # Useful for local testing.
 # USE WITH CAUTION !!
diff --git a/gradle/README.md b/gradle/README.md
index 6de4f54..5b83fdb 100644
--- a/gradle/README.md
+++ b/gradle/README.md
@@ -1,3 +1,21 @@
+
+
 # Gradle
 
 Gradle is used to build OpenWhisk. It does not need to be pre-installed as it 
installs itself using the [Gradle 
Wrapper](https://docs.gradle.org/current/userguide/gradle_wrapper.html). To use 
it without installing, simply invoke the `gradlew` command at the root of the 
repository. You can also install `gradle` via 
[`apt`](http://linuxg.net/how-to-install-gradle-2-1-on-ubuntu-14-10-ubuntu-14-04-ubuntu-12-04-and-derivatives/)
 on Ubuntu or [`brew`](http://www.brewformulas.org/Gradle) on Mac. In the 
following we use `gradle` and `gradlew` as synonymous.
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 4852bdd..d4a6828 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -1,4 +1,21 @@
 #!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 set -ex
 
 # Build script for Travis-CI.
diff --git a/tools/travis/deploy.sh b/tools/travis/deploy.sh
index bf30063..b6ebf05 100755
--- a/tools/travis/deploy.sh
+++ b/tools/travis/deploy.sh
@@ -1,4 +1,21 @@
 #!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the

[GitHub] lue-kle commented on a change in pull request #3382: Cleanup script for unused entities in the whisks database.

2018-03-07 Thread GitBox

lue-kle commented on a change in pull request #3382: Cleanup script for unused 
entities in the whisks database.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3382#discussion_r172975758
 
 

 ##
 File path: tools/db/cleanUpWhisks.py
 ##
 @@ -0,0 +1,150 @@
+#!/usr/bin/env python
+"""Python script to delete whisks entries having none existent ns.
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+"""
+
+import argparse
+import time
+import couchdb.client
+
+skipWhisks = 0
+
+try:
+long# Python 2
+except NameError:
+long = int  # Python 3
+
+HOUR = 1000 * 60 * 60
+DAY = HOUR * 24
+
+#
+# simple ring buffer like list
+#
+class SimpleRingBuffer:
+def __init__(self, size):
+self.index = -1
+self.data = []
+self.maxsize = size * 2
+
+def append(self, ns, bool):
+
+self.index=(self.index+2)%self.maxsize
+
+if len(self.data) < self.maxsize:
+self.data.append(ns)
+self.data.append(bool)
 
 Review comment:
   sure we can use tuples, would than require two checks if the ns exists in 
the cache. I would suggest to do this change when adapting the script to be 
used also for kafka and cloudant trigger dbs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #53: Change to use RAT maven plugin to support ASF short format header

2018-03-07 Thread GitBox

houshengbo commented on issue #53: Change to use RAT maven plugin to support 
ASF short format header
URL: 
https://github.com/apache/incubator-openwhisk-release/pull/53#issuecomment-371267701
 
 
   @daisy-ycguo Please rebase it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss closed pull request #3409: Remove namespace configuration; use invoker's instead

2018-03-07 Thread GitBox

dgrove-oss closed pull request #3409: Remove namespace configuration; use 
invoker's instead
URL: https://github.com/apache/incubator-openwhisk/pull/3409
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/invoker/src/main/resources/application.conf 
b/core/invoker/src/main/resources/application.conf
index 7f85eb571c..bc651fcdfe 100644
--- a/core/invoker/src/main/resources/application.conf
+++ b/core/invoker/src/main/resources/application.conf
@@ -19,7 +19,6 @@ whisk {
   }
 
   kubernetes {
-namespace: openwhisk
 # Timeouts for k8s commands. Set to "Inf" to disable timeout.
 timeouts {
   run: 1 minute
diff --git 
a/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
 
b/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
index 5f7c7d6413..6853f66e14 100644
--- 
a/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
+++ 
b/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
@@ -79,9 +79,7 @@ case class KubernetesInvokerAgentConfig(enabled: Boolean, 
port: Int)
 /**
  * General configuration for kubernetes client
  */
-case class KubernetesClientConfig(namespace: String,
-  timeouts: KubernetesClientTimeoutConfig,
-  invokerAgent: KubernetesInvokerAgentConfig)
+case class KubernetesClientConfig(timeouts: KubernetesClientTimeoutConfig, 
invokerAgent: KubernetesInvokerAgentConfig)
 
 /**
  * Serves as interface to the kubectl CLI tool.
@@ -150,12 +148,13 @@ class KubernetesClient(
   .endSpec()
   .build()
 
-kubeRestClient.pods.inNamespace(config.namespace).create(pod)
+val namespace = kubeRestClient.getNamespace
+kubeRestClient.pods.inNamespace(namespace).create(pod)
 
 Future {
   blocking {
 val createdPod = kubeRestClient.pods
-  .inNamespace(config.namespace)
+  .inNamespace(namespace)
   .withName(name)
   .waitUntilReady(config.timeouts.run.length, config.timeouts.run.unit)
 toContainer(createdPod)
@@ -178,7 +177,7 @@ class KubernetesClient(
   Future {
 blocking {
   kubeRestClient
-.inNamespace(config.namespace)
+.inNamespace(kubeRestClient.getNamespace)
 .pods()
 .withLabel(key, value)
 .list()


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lionelvillard opened a new issue #774: support for deploying/undeploying headless managed project

2018-03-07 Thread GitBox

lionelvillard opened a new issue #774: support for deploying/undeploying 
headless managed project
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/774
 
 
   usecase: deploying assets into an existing project without updating the 
manifest. 
   
   wskdeploy should accept `--managed` for headless projects. In this mode, 
only the `__OW_PROJECT_HASH` annotation is meaningless and shouldn't be added. 
Undeploying headless projects consists of deleting all assets matching the 
project name only.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet opened a new pull request #136: do not retry a throttled alarms trigger

2018-03-07 Thread GitBox

jasonpet opened a new pull request #136: do not retry a throttled alarms trigger
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/136
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371236194
 
 
   @csantanapr The capability of putting prefix and tag are already in the 
manifest.json file.  We just need to get to the point where 'invoker' is not 
assuming `whick/` prefix, which should be happening in step 2 of the 
incremental rollout.  I'll be sure to highlight it when the PR comes out :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

pritidesai commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172931132
 
 

 ##
 File path: tests/dat/manifest_validate_multiline_params.yaml
 ##
 @@ -32,6 +32,15 @@ packages:
 param_string_type_and_value_only:
 type: string
 value: foo
+param_json_type_and_value_only_1:
+type: json
+value: '{ "name": "Sam", "place": "Shire" }'
+param_json_type_and_value_only_2:
+type: json
+value: { "name": "${USERNAME}", "password": 
"${PASSWORD}" }
+param_json_type_and_value_only_3:
+type: json
+value: { "name": "$${USERNAME}", "password": 
"$${PASSWORD}" }
 
 Review comment:
   yup we have issue #769 and #770 to update spec and doc respectively.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed issue #705: Unable to use ENV VARS in input JSON

2018-03-07 Thread GitBox

mrutkows closed issue #705: Unable to use ENV VARS in input JSON
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on a change in pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

mrutkows commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172929604
 
 

 ##
 File path: parsers/manifest_parser_test.go
 ##
 @@ -1032,7 +1054,7 @@ func TestParseManifestForJSONParams(t *testing.T) {
assert.Equal(t, expectedResult, actualResult, 
TEST_MSG_ACTION_FUNCTION_RUNTIME_MISMATCH)
 
// validate the number of inputs to this action
-   expectedResult = strconv.FormatInt(6, 10)
+   expectedResult = strconv.FormatInt(8, 10)
 
 Review comment:
   2 new unit tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

mrutkows closed pull request #766: adding support for using env. variables in 
inputs JSON
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/parsers/manifest_parser_test.go b/parsers/manifest_parser_test.go
index c66e5bbc..3bc0a5e5 100644
--- a/parsers/manifest_parser_test.go
+++ b/parsers/manifest_parser_test.go
@@ -304,7 +304,7 @@ func TestParseManifestForMultiLineParams(t *testing.T) {
assert.Equal(t, expectedResult, actualResult, 
TEST_MSG_ACTION_FUNCTION_RUNTIME_MISMATCH)
 
// test # input params
-   expectedResult = strconv.FormatInt(10, 10)
+   expectedResult = strconv.FormatInt(13, 10)
actualResult = strconv.FormatInt(int64(len(action.Inputs)), 10)
assert.Equal(t, expectedResult, actualResult, 
TEST_MSG_PARAMETER_NUMBER_MISMATCH)
 
@@ -756,6 +756,10 @@ func TestComposeActionsForSingleLineParams(t *testing.T) {
 // Test 12: validate manifest_parser.ComposeActions() method for multi line 
parameters
 // manifest_parser should be able to parse input section with different types 
of values
 func TestComposeActionsForMultiLineParams(t *testing.T) {
+   os.Setenv("USERNAME", "MY_USERNAME")
+   os.Setenv("PASSWORD", "MY_PASSWORD")
+   defer os.Unsetenv("USERNAME")
+   defer os.Unsetenv("PASSWORD")
 
p, m, _ := testLoadParseManifest(t, 
"../tests/dat/manifest_validate_multiline_params.yaml")
 
@@ -826,6 +830,24 @@ func TestComposeActionsForMultiLineParams(t *testing.T) {
expectedResult = strconv.FormatFloat(2.9, 'f', -1, 64)
actualResult = 
strconv.FormatFloat(action.Action.Parameters.GetValue(paramName).(float64), 
'f', -1, 64)
assert.Equal(t, expectedResult, actualResult, 
fmt.Sprintf(TEST_MSG_ACTION_PARAMETER_VALUE_MISMATCH, paramName))
+
+   // param_json_type_and_value_only_1 should be { "name": "Sam", 
"place": "Shire" }
+   paramName = "param_json_type_and_value_only_1"
+   expectedResult1 := map[string]interface{}{"name": "Sam", 
"place": "Shire"}
+   actualResult1 := action.Action.Parameters.GetValue(paramName)
+   assert.Equal(t, expectedResult1, actualResult1, 
fmt.Sprintf(TEST_MSG_ACTION_PARAMETER_VALUE_MISMATCH, paramName))
+
+   // param_json_type_and_value_only_2 should be { "name": 
"MY_USERNAME", "password": "MY_PASSWORD" }
+   paramName = "param_json_type_and_value_only_2"
+   expectedResult2 := map[string]interface{}{"name": 
"MY_USERNAME", "password": "MY_PASSWORD"}
+   actualResult2 := action.Action.Parameters.GetValue(paramName)
+   assert.Equal(t, expectedResult2, actualResult2, 
fmt.Sprintf(TEST_MSG_ACTION_PARAMETER_VALUE_MISMATCH, paramName))
+
+   // param_json_type_and_value_only_3 should be { "name": 
"${USERNAME}", "password": "${PASSWORD}" }
+   paramName = "param_json_type_and_value_only_3"
+   expectedResult3 := map[string]interface{}{"name": 
"${USERNAME}", "password": "${PASSWORD}"}
+   actualResult3 := action.Action.Parameters.GetValue(paramName)
+   assert.Equal(t, expectedResult3, actualResult3, 
fmt.Sprintf(TEST_MSG_ACTION_PARAMETER_VALUE_MISMATCH, paramName))
}
 }
 
@@ -1032,7 +1054,7 @@ func TestParseManifestForJSONParams(t *testing.T) {
assert.Equal(t, expectedResult, actualResult, 
TEST_MSG_ACTION_FUNCTION_RUNTIME_MISMATCH)
 
// validate the number of inputs to this action
-   expectedResult = strconv.FormatInt(6, 10)
+   expectedResult = strconv.FormatInt(8, 10)
actualResult = strconv.FormatInt(int64(len(action.Inputs)), 10)
assert.Equal(t, expectedResult, actualResult, 
TEST_MSG_PARAMETER_NUMBER_MISMATCH)
 
@@ -1065,6 +1087,14 @@ func TestParseManifestForJSONParams(t *testing.T) {
actualResult6 := 
param.Value.(map[interface{}]interface{})
expectedResult6 := 
map[interface{}]interface{}{"name": "Frodo", "place": "Undying Lands", "items": 
[]interface{}{"Sting", "Mithril mail"}}
assert.Equal(t, expectedResult6, actualResult6, 
fmt.Sprintf(TEST_MSG_ACTION_PARAMETER_VALUE_MISMATCH, input))
+   case "member7":
+   actualResult7 := 
param.Value.(map[interface{}]interface{})
+   expectedResult7 := 
map[interface{}]interface{}{"name": "${USERNAME}", "password": "${PASSWORD}"}
+   assert.Equal(t, expectedResult7, actualResult7,

[GitHub] mrutkows commented on a change in pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

mrutkows commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172930215
 
 

 ##
 File path: wskenv/environment.go
 ##
 @@ -63,15 +63,21 @@ func InterpolateStringWithEnvVar(key interface{}) 
interface{} {
return c == '$' || c == '{' || c == '}'
}
for _, substr := range strings.FieldsFunc(keystr, f) {
-   //if the substr is a $ENV_VAR
-   if strings.Contains(keystr, "$"+substr) {
+   //if the substr is a $${ENV_VAR}
+   // return ${ENV_VAR}
+   if strings.Contains(keystr, "$${"+substr+"}") {
+   keystr = strings.Replace(keystr, 
"$${"+substr+"}", "${"+substr+"}", -1)
+   //if the substr is a $ENV_VAR
 
 Review comment:
   hate gofmt and comment alignment


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on a change in pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

mrutkows commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172929780
 
 

 ##
 File path: parsers/parameters.go
 ##
 @@ -322,7 +325,7 @@ func ResolveParameter(paramName string, param *Parameter, 
filePath string) (inte
}
 
// JSON - Handle both cases, where value 1) is a string containing 
JSON, 2) is a map of JSON
-   if param.Type == "json" {
+   if param.Value != nil && param.Type == "json" {
 
 Review comment:
   good catch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on a change in pull request #766: adding support for using env. variables in inputs JSON

2018-03-07 Thread GitBox

mrutkows commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172930016
 
 

 ##
 File path: tests/dat/manifest_validate_multiline_params.yaml
 ##
 @@ -32,6 +32,15 @@ packages:
 param_string_type_and_value_only:
 type: string
 value: foo
+param_json_type_and_value_only_1:
+type: json
+value: '{ "name": "Sam", "place": "Shire" }'
+param_json_type_and_value_only_2:
+type: json
+value: { "name": "${USERNAME}", "password": 
"${PASSWORD}" }
+param_json_type_and_value_only_3:
+type: json
+value: { "name": "$${USERNAME}", "password": 
"$${PASSWORD}" }
 
 Review comment:
   Thanks for this.  Did we open an spec/docs issue to document this new syntax 
for string literals (ala Kube, etc.)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-03-07 Thread GitBox

codecov-io commented on issue #3249: #3243 - Use gradle scoverage to collect 
test coverage stats
URL: 
https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365147821
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=h1)
 Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@f3274d2`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249/graphs/tree.svg?width=650=pr=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#3249   +/-   ##
   =
 Coverage  ?   71.83%   
   =
 Files ?  119   
 Lines ? 5500   
 Branches  ?  342   
   =
 Hits  ? 3951   
 Misses? 1549   
 Partials  ?0
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=footer).
 Last update 
[f3274d2...2862c8f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #26: Multiple Distros for Java Runtimes

2018-03-07 Thread GitBox

csantanapr commented on issue #26: Multiple Distros for Java Runtimes
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/26#issuecomment-371213696
 
 
   Also need to consider architect to the matrix of images 
   s390x ppc64 arm (ie raspberry pi/edge device)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371204992
 
 
   rebased + added doc update with an example  @dubeejw 
   
   pg2/2899


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw closed pull request #3405: Install CLI with edge.yml

2018-03-07 Thread GitBox

dubeejw closed pull request #3405: Install CLI with edge.yml
URL: https://github.com/apache/incubator-openwhisk/pull/3405
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ansible/edge.yml b/ansible/edge.yml
index 6566d572ae..c541d4754a 100644
--- a/ansible/edge.yml
+++ b/ansible/edge.yml
@@ -8,3 +8,4 @@
   roles:
   - nginx
   - cli
+  - cli-install
diff --git a/ansible/routemgmt.yml b/ansible/routemgmt.yml
index 1807328b13..0c9ced2578 100644
--- a/ansible/routemgmt.yml
+++ b/ansible/routemgmt.yml
@@ -5,5 +5,4 @@
 
 - hosts: ansible
   roles:
-  - cli-install
   - routemgmt


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

csantanapr commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371208056
 
 
   I wan to see the flexibility of defining in the manifest json the runtimes 
eaxh can come different users/prefix for example ?openwhisk? or ?ibmfunctions? 
for any runtime and tag can be specified for each this metada is also already 
expose on the root of the api/v1/ 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #67: Additional HTTP Headers

2018-03-07 Thread GitBox

mdeuser commented on issue #67: Additional HTTP Headers
URL: 
https://github.com/apache/incubator-openwhisk-client-go/pull/67#issuecomment-371207019
 
 
   @dubeejw is the intent to provide per-request specific headers? if so, it 
might be more flexible to include the additional headers via the requestUrl() 
functions as opposed to the global client configuration


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

rabbah commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371206530
 
 
   I dont think you need a pg.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371204992
 
 
   rebased + added doc update with an example
   
   pg2/2899


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure web action

2018-03-07 Thread GitBox

mdeuser commented on issue #3388: Update require-whisk-auth behavior to secure 
web action
URL: 
https://github.com/apache/incubator-openwhisk/pull/3388#issuecomment-371204992
 
 
   rebased + added doc update with an example


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kameshsampath commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

kameshsampath commented on issue #15: More flexibility to parsing and passing 
JSON input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371200382
 
 
   @rabbah  @mkouba all I was trying to avoid doing via `main(String[] args)` 
is to avoid any third party deps with simple functions,  I tend see @mkouba 
style of using Function as entrypoint and use reflection then.. I am right 
now working with refactoring the javaAction to make it more simper and easier 
.. will share once its ready for you guys to comment and feedback


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on issue #67: Additional HTTP Headers

2018-03-07 Thread GitBox

dubeejw commented on issue #67: Additional HTTP Headers
URL: 
https://github.com/apache/incubator-openwhisk-client-go/pull/67#issuecomment-371200360
 
 
   @mdeuser


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

csantanapr commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371198689
 
 
   @rabbah this is similar in spirit what I?m doin in swift4 with Codable IN 
and Codable OUT?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898928
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898998
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books post for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898965
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books get for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898856
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox

jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898796
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371188993
 
 
   > I assume you also mean there is a a serializer/deserializer from Foo to 
JSON object?
   
   This functionality is provided by Gson. So the only thing we need is to 
obtain input/output `java.lang.reflect.Type` through reflection and wrap the 
function call to convert the values.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371187087
 
 
   > I'd try to avoid main(String args[]) if possible. Instead, we could allow 
user to specify a java.util.function.Function implementation as a main class.
   
   @mkouba +1, I assume you also mean there is a a serializer/deserializer from 
`Foo` to JSON object?
   
   More generally a `Function` where `T1` and `T2` could be first class 
types. This create serdes overhead but allows for better function abstractions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371187087
 
 
   > I'd try to avoid main(String args[]) if possible. Instead, we could allow 
user to specify a java.util.function.Function implementation as a main class.
   
   @mkouba +1, I assume you also mean there is a a serializer/deserializer from 
`Foo` to JSON object?
   
   Edit: ah never I misread the `getValue`, `setValue`... I mapped that to a 
`Function` where `T1` and `T2` could be first class types. This create 
serdes overhead but allows for better function abstractions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371171374
 
 
   Agreed this is pretty massive.  I'll see what I can do to break it up as it 
leaves WIP; some of the changes can be added now and still test clean.  (And 
yes, I did include one other change as I was working that deserves to be its 
own separate PR.  Too many branches going right now...)
   
   The reason for deleting the actionRuntime directories at the same time as 
changing the manifest behavior was to ensure during testing that the new 
manifest behavior didn't have some leftover dependency on the 'whisk/*' images 
and their being pulled in './gradlew distDocker'.  If we're nervous, we can put 
them back, but as other pieces move, they become unneeded and confusing.  I'd 
definitely advise following up with a second PR not too soon after.
   
   Thanks for pointing out the artifacts from those directories that are worth 
saving.  They can be moved into 'tools' and 'docs' with a little work.  We'll 
leave this PR and notes as WIP to guide the staged implementation as well as an 
opportunity to run Travis over the whole enchilada.  I'd suggest three PR's:
   
   1.  Additional configuration variables and ansible changes that can work 
with the existing codebase.
   2.  The invoker changes to use the 'openwhisk/' prefix for runtimes and 
accept directly-pulled images, including any additional ansible changes needed 
in support.
   3.  Move identified useful artifacts into `tools` and `docs`.  Document 
appropriately.
   4.  Progressively remove standalone 'actionContainer' tests to the 
repositories creating those containers and remove corresponding runtime 
directories.  Disable build of those Docker images.
   5.  Move the useful artifacts from the 'actionRuntimes' and delete the 
remaining actionRuntimes directory tree (and Travis changes to remove from the 
ignores list).
   
   Once all that is done, I can move on to my original goal of converting from 
'distDocker' to 'gradle-docker-plugin' to make multi-architecture builds more 
accessible and less of a maintenance headache.
   
   Sound good @rabbah @markusthoemmes ?  (Meanwhile, back to figuring out why 
Travis is failing, then I'll probably still want a PG to see what I broke in 
Functions.)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371187087
 
 
   > I'd try to avoid main(String args[]) if possible. Instead, we could allow 
user to specify a java.util.function.Function implementation as a main class.
   
   @mkouba +1, I assume you also mean there is a a serializer/deserializer from 
`Foo` to JSON object?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172887567
 
 

 ##
 File path: ansible/group_vars/all
 ##
 @@ -207,6 +207,9 @@ docker:
   image:
 prefix: "{{ docker_image_prefix | default('whisk') }}"
 tag: "{{ docker_image_tag | default('latest') }}"
+  runtimes:
+prefix: "{{ runtime_image_prefix | default('openwhisk') }}"
 
 Review comment:
   Yep.  Now we're going to differentiate between what's built locally by 
`./gradlew distDocker` (whisk/invoker, whisk/controller) and what's available 
for download as a "builtin" action `openwhisk/...`.  Of course, we should 
probably put some structure (tagged semver releases?) around the action 
runtimes in DockerHub.
   
   EDIT:  There are 'runtime_default_image_(prefix|tag)' hooks available in 
ansible, but they're not used anywhere that I can see as part of the scripting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371184620
 
 
   @rabbah Ok, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371183079
 
 
   @mkouba 
https://github.com/apache/incubator-openwhisk/blob/master/docs/actions.md#creating-and-invoking-openwhisk-actions
   
   ```
   The input to an action and the result of an action are a dictionary of 
key-value pairs, 
   where the key is a string and the value a valid JSON value.
   ```
   
   We should perhaps make that more prominent. The function signature 
abstractly is `dictionary -> dictionary` where the implementation of dictionary 
is language specific, e.g., JSON object for Javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371183079
 
 
   @mkouba 
https://github.com/apache/incubator-openwhisk/blob/master/docs/actions.md#creating-and-invoking-openwhisk-actions
   
   ```
   The input to an action and the result of an action are a dictionary of 
key-value pairs, where the key is a string and the value a valid JSON value.
   ```
   
   We should perhaps make that more prominent. The function signature 
abstractly is `dictionary -> dictionary` where the implementation of dictionary 
is language specific, e.g., JSON object for Javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172887567
 
 

 ##
 File path: ansible/group_vars/all
 ##
 @@ -207,6 +207,9 @@ docker:
   image:
 prefix: "{{ docker_image_prefix | default('whisk') }}"
 tag: "{{ docker_image_tag | default('latest') }}"
+  runtimes:
+prefix: "{{ runtime_image_prefix | default('openwhisk') }}"
 
 Review comment:
   Yep.  Now we're going to differentiate between what's built locally by 
`./gradlew distDocker` (whisk/invoker, whisk/controller) and what's available 
for download as a "builtin" action `openwhisk/...`.  Of course, we should 
probably put some structure (tagged semver releases?) around the action 
runtimes in DockerHub.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371171374
 
 
   Agreed this is pretty massive.  I'll see what I can do to break it up as it 
leaves WIP; some of the changes can be added now and still test clean.
   
   The reason for deleting the actionRuntime directories at the same time as 
changing the manifest behavior was to ensure during that the new manifest 
behavior didn't have some leftover dependency on the 'whisk/*' images and their 
being pulled in './gradlew distDocker'.  If we're nervous, we can put them 
back, but as other pieces move, they become unneeded and confusing.  I'd 
definitely advise following up with a second PR not too soon after.
   
   Thanks for pointing out the artifacts from those directories that are worth 
saving.  They can be moved into 'tools' and 'docs' with a little work.  We'll 
leave this PR and notes as WIP to guide the staged implementation as well as an 
opportunity to run Travis over the whole enchilada.  I'd suggest three PR's:
   
   1.  Additional configuration variables and ansible changes that can work 
with the existing codebase.
   2.  The invoker changes to use the 'openwhisk/' prefix for runtimes and 
accept directly-pulled images, including any additional ansible changes needed 
in support.
   3.  Progressively remove standalone 'actionContainer' tests to the 
repositories creating those containers and remove corresponding runtime 
directories.
   4.  Move the useful artifacts from the 'actionRuntimes' and delete the 
remaining actionRuntimes directory tree (and Travis changes to remove from the 
ignores list).
   
   Once all that is done, I can move on to my original goal of converting from 
'distDocker' to 'gradle-docker-plugin' to make multi-architecture builds more 
accessible and less of a maintenance headache.
   
   Sound good @rabbah @markusthoemmes ?  (Meanwhile, back to figuring out why 
Travis is failing, then I'll probably still want a PG to see what I broke in 
Functions.)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371179496
 
 
   @kameshsampath Yep, I've seen this code already. We can wrap the resulting 
array/primitive if necessary right there, e.g. `{result : [...]}`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #3409: Remove namespace configuration; use invoker's instead

2018-03-07 Thread GitBox

dgrove-oss commented on issue #3409: Remove namespace configuration; use 
invoker's instead
URL: 
https://github.com/apache/incubator-openwhisk/pull/3409#issuecomment-371179109
 
 
   PG1 / 2688 ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kameshsampath commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

kameshsampath commented on issue #15: More flexibility to parsing and passing 
JSON input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371179202
 
 
   > I can try to send a PR if you are interested ;-)
   
   you are most welcome


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kameshsampath commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

kameshsampath commented on issue #15: More flexibility to parsing and passing 
JSON input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371177266
 
 
   @mkouba  - this is where it needs to be fixed further 
https://github.com/apache/incubator-openwhisk-runtime-java/blob/master/core/javaAction/proxy/src/main/java/openwhisk/java/action/Proxy.java


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371171374
 
 
   Agreed this is pretty massive.  I'll see what I can do to break it up as it 
leaves WIP; some of the changes can be added now and still test clean.
   
   The reason for deleting the actionRuntime directories at the same time as 
changing the manifest behavior was to ensure during that the new manifest 
behavior didn't have some leftover dependency on the 'whisk/*' images and their 
being pulled in './gradlew distDocker'.  If we're nervous, we can put them 
back, but as other pieces move, they become unneeded and confusing.  I'd 
definitely advise following up with a second PR not too soon after.
   
   Thanks for pointing out the artifacts from those directories that are worth 
saving.  They can be moved into 'tools' and 'docs' with a little work.  We'll 
leave this PR and notes as WIP to guide the staged implementation as well as an 
opportunity to run Travis over the whole enchilada.  I'd suggest three PR's:
   
   1.  Additional configuration variables and ansible changes that can work 
with the existing codebase.
   2.  The invoker changes to use the 'openwhisk/' prefix for runtimes and 
accept directly-pulled images, including any additional ansible changes needed 
in support.
   3.  Move the useful artifacts from the 'actionRuntimes' and delete the 
actionRuntimes directory tree (and Travis changes to remove from the ignores 
list).
   
   Once all that is done, I can move on to my original goal of converting from 
'distDocker' to 'gradle-docker-plugin' to make multi-architecture builds more 
accessible and less of a maintenance headache.
   
   Sound good @rabbah @markusthoemmes ?  (Meanwhile, back to figuring out why 
Travis is failing, then I'll probably still want a PG to see what I broke in 
Functions.)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371173793
 
 
   @rabbah Why is that? Is the contract for OW actions defined somewhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3382: Cleanup script for unused entities in the whisks database.

2018-03-07 Thread GitBox

rabbah commented on issue #3382: Cleanup script for unused entities in the 
whisks database.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3382#issuecomment-371173849
 
 
   As a general note: It would be useful in the long run to consolidate this 
and scripts like it into wskadmin (and rearchitect that accordingly). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371173308
 
 
   I'd try to avoid `main(String args[])` if possible. Instead, we could allow 
user to specify a `java.util.function.Function` implementation as a main class. 
And then when initializing action inspect the actual type arguments and make 
use of `com.google.gson.Gson.fromJson(JsonElement, Type)` and 
`com.google.gson.Gson.toJsonTree(Object, Type)` to perform the conversion 
automatically. So that a user can simply write something like:
   
   java
   class ListRevertAction implements Function {
   
   @Override
   public Foo apply(Foo input) {
   Collections.reverse(input.getValue());
   return input;
   }
   }

  static class Foo {
   
   private List value;
   
   public List getValue() {
   return value;
   }
   
   public void setValue(List value) {
   this.value = value;
   }
   }
   
   I can try to send a PR if you are interested ;-)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

rabbah commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371173021
 
 
   Note: Whisk actions must return json objects. If you change the signature 
you?ll need to box the return value into an object elsewhere. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

dgrove-oss commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172875542
 
 

 ##
 File path: ansible/group_vars/all
 ##
 @@ -207,6 +207,9 @@ docker:
   image:
 prefix: "{{ docker_image_prefix | default('whisk') }}"
 tag: "{{ docker_image_tag | default('latest') }}"
+  runtimes:
+prefix: "{{ runtime_image_prefix | default('openwhisk') }}"
 
 Review comment:
   @rabbah -- this what you were thinking of 
https://github.com/apache/incubator-openwhisk/blob/f3274d2155036dbd025902353f7b77c076ad1f86/ansible/group_vars/all#L203-#L210


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172873079
 
 

 ##
 File path: actionRuntimes/actionProxy/README.md
 ##
 @@ -1,37 +0,0 @@
-Skeleton for "docker actions"
 
 Review comment:
   Makes sense.  Let's try to move to docs and direct build back to the owning 
repository.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172872933
 
 

 ##
 File path: actionRuntimes/actionProxy/invoke.py
 ##
 @@ -1,136 +0,0 @@
-#!/usr/bin/env python
 
 Review comment:
   Okay I'll find another home for it, probably over in tools.  Are the links 
deep links into github?  That's not happy :(.  I suppose I can leave a symlink 
for the foreseeable future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172872933
 
 

 ##
 File path: actionRuntimes/actionProxy/invoke.py
 ##
 @@ -1,136 +0,0 @@
-#!/usr/bin/env python
 
 Review comment:
   Okay I'll find another home for it, probably over in tools.  Are the links 
deep links into github?  That's not happy :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371171374
 
 
   Agreed this is pretty massive.  I'll see what I can do to break it up as it 
leaves WIP; some of the changes can be added now.  The reason for deleting the 
runtimes was to be able to run a 'clean' test of the other changes to ensure 
they weren't using some leftover pollution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172873290
 
 

 ##
 File path: ansible/group_vars/all
 ##
 @@ -207,6 +207,9 @@ docker:
   image:
 prefix: "{{ docker_image_prefix | default('whisk') }}"
 tag: "{{ docker_image_tag | default('latest') }}"
+  runtimes:
+prefix: "{{ runtime_image_prefix | default('openwhisk') }}"
 
 Review comment:
   Runtime manifest uses docker_image_prefix -- I wanted to avoid the 
overloading.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jcrossley3 opened a new pull request #3409: Remove namespace configuration; use invoker's instead

2018-03-07 Thread GitBox

jcrossley3 opened a new pull request #3409: Remove namespace configuration; use 
invoker's instead
URL: https://github.com/apache/incubator-openwhisk/pull/3409
 
 
   Making this configurable -- and defaulting to something that may not
   be the ns in which the invoker is running -- is more trouble than it's
   worth, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172873079
 
 

 ##
 File path: actionRuntimes/actionProxy/README.md
 ##
 @@ -1,37 +0,0 @@
-Skeleton for "docker actions"
 
 Review comment:
   Makes sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3407: WIP: No longer need to build 'whisk/*' runtimes for builtins.

2018-03-07 Thread GitBox

jonpspri commented on a change in pull request #3407: WIP: No longer need to 
build 'whisk/*' runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#discussion_r172872933
 
 

 ##
 File path: actionRuntimes/actionProxy/invoke.py
 ##
 @@ -1,136 +0,0 @@
-#!/usr/bin/env python
 
 Review comment:
   Okay I'll find another home for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes commented on a change in pull request #3382: Cleanup script for unused entities in the whisks database.

2018-03-07 Thread GitBox

markusthoemmes commented on a change in pull request #3382: Cleanup script for 
unused entities in the whisks database.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3382#discussion_r172871483
 
 

 ##
 File path: tools/db/cleanUpWhisks.py
 ##
 @@ -0,0 +1,150 @@
+#!/usr/bin/env python
+"""Python script to delete whisks entries having none existent ns.
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+"""
+
+import argparse
+import time
+import couchdb.client
+
+skipWhisks = 0
+
+try:
+long# Python 2
+except NameError:
+long = int  # Python 3
+
+HOUR = 1000 * 60 * 60
+DAY = HOUR * 24
+
+#
+# simple ring buffer like list
+#
+class SimpleRingBuffer:
+def __init__(self, size):
+self.index = -1
+self.data = []
+self.maxsize = size * 2
+
+def append(self, ns, bool):
+
+self.index=(self.index+2)%self.maxsize
+
+if len(self.data) < self.maxsize:
+self.data.append(ns)
+self.data.append(bool)
 
 Review comment:
   Python?supports tuples. Should we store tuples of (String, Boolean) instead 
of relying on a fixed order here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss opened a new issue #239: More helpful error message when unable to verify certificates

2018-03-07 Thread GitBox

dgrove-oss opened a new issue #239: More helpful error message when unable to 
verify certificates
URL: https://github.com/apache/incubator-openwhisk-cli/issues/239
 
 
   See https://github.com/apache/incubator-openwhisk-deploy-kube/issues/161.
   
   It would be helpful for new users if the error message from `wsk` when it 
can't verify a certificate would mention the need to use  `wsk -i` when using 
your own install of open whisk with self-signed certificates. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #161: x509: certificate signed by unknown authority accessing Nginx in Windows 10

2018-03-07 Thread GitBox

dgrove-oss commented on issue #161: x509: certificate signed by unknown 
authority accessing Nginx in Windows 10
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/161#issuecomment-371162716
 
 
   hi.  When using the self-signed certificate generated by certs.sh, you need 
to use `wsk -i` instead of `wsk`.   
   
   > Note: if you installed self-signed certificates when you configured Nginx, 
you will need to use wsk -i to suppress certificate checking. This works around 
cannot validate certificate errors from the wsk CLI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah closed pull request #3391: Add namespace-blacklist to invoker.

2018-03-07 Thread GitBox

rabbah closed pull request #3391: Add namespace-blacklist to invoker.
URL: https://github.com/apache/incubator-openwhisk/pull/3391
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/ansible/files/namespace_throttlings_design_document_for_subjects_db.json 
b/ansible/files/namespace_throttlings_design_document_for_subjects_db.json
new file mode 100644
index 00..23463819c4
--- /dev/null
+++ b/ansible/files/namespace_throttlings_design_document_for_subjects_db.json
@@ -0,0 +1,10 @@
+{
+  "_id": "_design/namespaceThrottlings",
+  "views": {
+"blockedNamespaces": {
+  "map": "function (doc) {\n  if (doc._id.indexOf(\"/limits\") >= 0) {\n   
 if (doc.concurrentInvocations === 0 || doc.invocationsPerMinute === 0) {\n 
 var namespace = doc._id.replace(\"/limits\", \"\");\n  emit(namespace, 
1);\n}\n  } else if (doc.subject && doc.namespaces && doc.blocked) {\n
doc.namespaces.forEach(function(namespace) {\n  emit(namespace.name, 1);\n  
  });\n  }\n}",
+  "reduce": "_sum"
+}
+  },
+  "language": "javascript"
+}
diff --git a/ansible/roles/invoker/tasks/deploy.yml 
b/ansible/roles/invoker/tasks/deploy.yml
index bf91a50b71..c113f5487c 100644
--- a/ansible/roles/invoker/tasks/deploy.yml
+++ b/ansible/roles/invoker/tasks/deploy.yml
@@ -169,6 +169,7 @@
 -e DB_PASSWORD='{{ db_password }}'
 -e DB_WHISK_ACTIONS='{{ db.whisk.actions }}'
 -e DB_WHISK_ACTIVATIONS='{{ db.whisk.activations }}'
+-e DB_WHISK_AUTHS='{{ db.whisk.auth }}'
 -e CONFIG_whisk_db_actionsDdoc='{{ db_whisk_actions_ddoc | default() 
}}'
 -e CONFIG_whisk_db_activationsDdoc='{{ db_whisk_activations_ddoc | 
default() }}'
 -e CONFIG_whisk_db_activationsFilterDdoc='{{ 
db_whisk_activations_filter_ddoc | default() }}'
diff --git a/ansible/tasks/initdb.yml b/ansible/tasks/initdb.yml
index 46db9f8900..5a8665a187 100644
--- a/ansible/tasks/initdb.yml
+++ b/ansible/tasks/initdb.yml
@@ -14,6 +14,7 @@
   with_items:
 - "{{ openwhisk_home }}/ansible/files/auth_index.json"
 - "{{ openwhisk_home }}/ansible/files/filter_design_document.json"
+- "{{ openwhisk_home 
}}/ansible/files/namespace_throttlings_design_document_for_subjects_db.json"
 
 - name: create necessary "auth" keys
   include: db/recreateDoc.yml
diff --git a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala 
b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
index 1ff53fb6c9..a5e1fe1f19 100644
--- a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
+++ b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
@@ -256,6 +256,7 @@ object ConfigKeys {
   val runcTimeouts = s"$runc.timeouts"
   val containerFactory = "whisk.container-factory"
   val containerArgs = s"$containerFactory.container-args"
+  val blacklist = "whisk.blacklist"
 
   val kubernetes = "whisk.kubernetes"
   val kubernetesTimeouts = s"$kubernetes.timeouts"
diff --git a/common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala 
b/common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
index 0a1417e842..016363a23f 100644
--- a/common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
@@ -155,7 +155,7 @@ object WhiskActivationStore {
  * @param ddoc the design document
  * @param view the view name within the design doc
  */
-protected[core] class View(ddoc: String, view: String) {
+protected[core] case class View(ddoc: String, view: String) {
 
   /** The name of the table to query. */
   val name = s"$ddoc/$view"
diff --git a/core/invoker/src/main/resources/application.conf 
b/core/invoker/src/main/resources/application.conf
index c63e1b7992..7f85eb571c 100644
--- a/core/invoker/src/main/resources/application.conf
+++ b/core/invoker/src/main/resources/application.conf
@@ -3,6 +3,10 @@ include "logging"
 include "akka-http-version"
 
 whisk {
+  blacklist {
+poll-interval: 5 minutes
+  }
+
   # Timeouts for docker commands. Set to "Inf" to disable timeout.
   docker.timeouts {
 run: 1 minute
@@ -40,6 +44,5 @@ whisk {
 network: bridge
 dns-servers: []
 extra-args: {}
-
   }
 }
diff --git a/core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala 
b/core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
index 4a9f0715f1..d6d273547f 100644
--- a/core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
+++ b/core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
@@ -22,13 +22,10 @@ import scala.concurrent.duration._
 import scala.concurrent.Future
 import scala.util.Failure
 import scala.util.Try
-
 import kamon.Kamon
-
 import org.apache.curator.retry.RetryUntilElapsed
 import org.apache.curator.framework.CuratorFrameworkFactory
 import

[GitHub] csantanapr commented on a change in pull request #24: AdoptOpenJDK Eclipse OpenJ9 as alternative Java runtime

2018-03-07 Thread GitBox

csantanapr commented on a change in pull request #24: AdoptOpenJDK Eclipse 
OpenJ9 as alternative Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r172862568
 
 

 ##
 File path: gradle/docker.gradle
 ##
 @@ -29,8 +29,8 @@ ext {
 dockerRetries = project.hasProperty('dockerRetries') ? 
dockerRetries.toInteger() : 3
 dockerBinary = project.hasProperty('dockerBinary') ? [dockerBinary] : 
['docker']
 dockerBuildArg = ['build']
+dockerFile = project.hasProperty('dockerFile') ? dockerFile : 'Dockerfile'
 
 Review comment:
   No need to change docker.gradle. 
   Please replace the current image in 
https://github.com/apache/incubator-openwhisk-runtime-java/blob/master/core/javaAction/Dockerfile


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kameshsampath commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

kameshsampath commented on issue #15: More flexibility to parsing and passing 
JSON input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371158635
 
 
   @mkouba thanks for suggestion, we are working on to adhere to standard Java 
Signature like main(String args[]) and allow internal class like a Luncher to 
parse the args and give to Launcher to fire the function


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #3402: Create '_users' database for singleton ephemeral couchdb v 2+

2018-03-07 Thread GitBox

dgrove-oss commented on issue #3402: Create '_users' database for singleton 
ephemeral couchdb v 2+
URL: 
https://github.com/apache/incubator-openwhisk/pull/3402#issuecomment-371158446
 
 
   @rabbah - Maybe you are thinking of the kube-couchdb docker image?  
@bbrowning added code to create the users table in its init.sh.
   
   
https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/docker/couchdb/init.sh#L52-#L55


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kameshsampath opened a new issue #26: Multiple Distros for Java Runtimes

2018-03-07 Thread GitBox

kameshsampath opened a new issue #26: Multiple Distros for Java Runtimes
URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/26
 
 
   It will be nice to have OpenWhisk JDK runtimes available on multiple 
distributions 
   * centos
   * debian
   * alpine
   
   The initial work of this can follow the pattern like 
https://github.com/kameshsampath/adoptopenjdk .
   
   Moving this discussion from #24  to discuss and freeze on this.
   
   @Param-S  lets continue the discussion here 
   
   @csantanapr  - we are moving this discussion into its own thread .
   
   @bbrowning - this is something we started to discuss the other day slack. 
Please add your thoughts comments here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkouba commented on issue #15: More flexibility to parsing and passing JSON input/out in Java runtime

2018-03-07 Thread GitBox

mkouba commented on issue #15: More flexibility to parsing and passing JSON 
input/out in Java runtime
URL: 
https://github.com/apache/incubator-openwhisk-runtime-java/issues/15#issuecomment-371154325
 
 
   Also the current return type (`com.google.gson.JsonObject`) of a Java action 
signature prevents from returning a JSON array. I think it should be 
`com.google.gson.JsonElement` instead. Of course, this is irrelevant if the 
parsing method is changed completely.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

1 2 >

1 - 100 of 134 matches

Mail list logo