[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071881#comment-16071881
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user lizhanhui closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/91


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.2.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004221#comment-16004221
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11449818/badge)](https://coveralls.io/builds/11449818)

Coverage increased (+0.006%) to 37.921% when pulling 
**12b03d83beccdd5e68df28bad2ab62bea6f8b1a4 on lizhanhui:ROCKETMQ-174** into 
**80aac138d905561c7a63c8e15fdfe60e958a3032 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003952#comment-16003952
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115645553
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage(
 final QueryMessageRequestHeader requestHeader,
 final long timeoutMillis,
 final InvokeCallback invokeCallback,
-final Boolean isUnqiueKey
+final Boolean isUnqueKey
--- End diff --

Thanks for point it out, unique key.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002623#comment-16002623
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user vsair commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
 ---
@@ -27,23 +27,23 @@
 
 public class TopicRouteData extends RemotingSerializable {
 private String orderTopicConf;
-private List queueDatas;
-private List brokerDatas;
+private List queueDataList;
+private List brokerDataList;
--- End diff --

It is modification of protocol, IMO, it's improper for upgrade of server or 
client.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002625#comment-16002625
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user vsair commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478367
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/QueryMessageResponseHeader.java
 ---
@@ -28,7 +28,7 @@
 @CFNotNull
 private Long indexLastUpdateTimestamp;
 @CFNotNull
-private Long indexLastUpdatePhyoffset;
+private Long indexLastUpdatePhyOffset;
--- End diff --

Protocol modification.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996414#comment-15996414
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user shroman commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
Guys, let's merge this fix after the conflicts are resolved.
I also don't like breaks in minor versions, but there are too many spelling 
mistakes and writing workarounds for each is hard. Let's do it while we are in 
incubating phase, and make an announcement in release notes.
Any other ideas?


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970709#comment-15970709
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111709175
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java
 ---
@@ -16,15 +16,15 @@
  */
 
 /**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
--- End diff --

There are many files with such lines. If you don't mind, let's have them 
removed with this commit ;)


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970697#comment-15970697
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111708191
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java
 ---
@@ -16,15 +16,15 @@
  */
 
 /**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
--- End diff --

It should not be here.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970654#comment-15970654
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704125
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeRequestHeader.java
 ---
@@ -16,15 +16,15 @@
  */
 
 /**
- * $Id: GetEarliestMsgStoretimeRequestHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
+ * $Id: GetEarliestMsgStoreTimeRequestHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
--- End diff --

Why do we need this line?


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970653#comment-15970653
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704133
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java
 ---
@@ -16,15 +16,15 @@
  */
 
 /**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 
02:00:50Z vintagew...@apache.org $
--- End diff --

Why do we need this line?


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968560#comment-15968560
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111525174
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

For cinfiguration issue, we can fix them by pointing them to the same right 
spelling config.

private int rightConfig;
   @Deprecated
public int getTypoConfig(){
 return rightConfig;
}

@Deprecated
public void setTypoConfig(int val) {
this.rightConfig = val;
}

getter/setter for right config...


But since client config and server config is working in tatolly different 
ways that server config uses reflection to load configurations so this should 
be only work for client configuration typo issue. 

I suggest we post another two typo issues for client configuration and 
server configuration.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968556#comment-15968556
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

This is why I make these changes thorough PR process instead of regarding 
them trivial and merging directly.

We can discuss to figure out an acceptable way.

You may also notice that I do not change configuration name spelling issues 
yet and I am expecting opinions too.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968547#comment-15968547
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524324
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

So in the next version, we must announce that they may face the compatible 
problem when they use  in the older version.

Before they update, they must know about this and know how to fix them , 
and then upgrade.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968535#comment-15968535
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

1) This project is still at incubation stage, if we do not correct things 
now, we may never ever get the chance to fix them afterwards.
2) Transaction related feature is not currently implemented, IMO, we may 
fix this interface before it's widely used.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968533#comment-15968533
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211195
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java
 ---
@@ -33,7 +33,7 @@
 /**
  * consume return null
  */
-RETURNNULL,
+RETURN_NULL,
--- End diff --

This is in an enum in client, we should be cautions for this since the user 
may has been using it.

Maybe we can comment in the java doc and explain that we will rename it in 
latter version?


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968532#comment-15968532
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211864
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

We can't just rename a public interface, since the user who updates will 
find it not able to compile.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968530#comment-15968530
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user Jaskey commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
@zhouxinyu @vesense 
for some public class or enum, I don't agree we rename it directly since it 
will introduce the compatibility problem for the user who upgrade from the 
older versions.


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968527#comment-15968527
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11083278/badge)](https://coveralls.io/builds/11083278)

Coverage increased (+0.0007%) to 34.626% when pulling 
**7e07b87f7124d21c69c5d61169a2c466714239eb on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968528#comment-15968528
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11083278/badge)](https://coveralls.io/builds/11083278)

Coverage increased (+0.0007%) to 34.626% when pulling 
**7e07b87f7124d21c69c5d61169a2c466714239eb on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967181#comment-15967181
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user vesense commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
Overall looks good to me. Nice job!


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967179#comment-15967179
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user vesense commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111317677
  
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
 
  If the change is non-trivial please include some unit tests that 
cover the new functionality.
  If you are introducing a completely new feature or API it is a good 
idea to start a wiki and get consensus on the basic design first.
- It is our job to follow up on patches in a timely fashion. Nag us if 
we aren't doing our job (sometimes we drop things).
+ It is our job to follow up on patches in a timely fashion. Nag us if 
we arn't doing our job timely enough (sometimes we may miss things).
--- End diff --

arn't -> aren't ?


> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>  Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966188#comment-15966188
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11057354/badge)](https://coveralls.io/builds/11057354)

Coverage increased (+0.03%) to 34.653% when pulling 
**b5604b65a269e3ba191eb0aed83b485839b5011f on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966187#comment-15966187
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11057354/badge)](https://coveralls.io/builds/11057354)

Coverage increased (+0.03%) to 34.653% when pulling 
**b5604b65a269e3ba191eb0aed83b485839b5011f on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966186#comment-15966186
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11057354/badge)](https://coveralls.io/builds/11057354)

Coverage increased (+0.03%) to 34.653% when pulling 
**b5604b65a269e3ba191eb0aed83b485839b5011f on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-174) Spelling Fix

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966164#comment-15966164
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-

GitHub user lizhanhui opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/91

[ROCKETMQ-174]Fix spelling errors

This is to fix large number of spelling errors.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-174

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit b5604b65a269e3ba191eb0aed83b485839b5011f
Author: Zhanhui Li 
Date:   2017-04-12T16:24:31Z

Spelling fix




> Spelling Fix
> 
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)