[jira] [Commented] (SCB-369) support extract publish information from spectator measurement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396529#comment-16396529
 ] 

ASF GitHub Bot commented on SCB-369:


coveralls commented on issue #575: [SCB-369] Extract info from spectator 
measurement
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#issuecomment-371080516
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15942151/badge)](https://coveralls.io/builds/15942151)
   
   Coverage increased (+0.03%) to 87.239% when pulling 
**7ab14486a7107b9be2159aedcf92434d645b98ad on 
wujimin:extract-info-from-spectator-measurement** into 
**0c2e8d55f10e55174427429f58376a06be9cf5b2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> support extract publish information from spectator measurement
> --
>
> Key: SCB-369
> URL: https://issues.apache.org/jira/browse/SCB-369
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-396) java-sdk needs to distinguish the instance belongs to the devops stage(environment)

[WeiChao (JIRA)]

WeiChao created SCB-396:
---

 Summary: java-sdk needs to distinguish the instance belongs to the 
devops stage(environment)
 Key: SCB-396
 URL: https://issues.apache.org/jira/browse/SCB-396
 Project: Apache ServiceComb
  Issue Type: Task
  Components: Java-Chassis
Reporter: WeiChao
Assignee: WeiChao
 Fix For: service-center-1.0.0-m2


sdk support registers service environment according to environment variables.

servcie center registers the service interface, requesting the field with the 
identification phase in the body,\{"service":{"serviceId":"xxx", 
"environment":"production"}}.

the name of the environment variable should be aligned with GOSDK and be 
unified.

the default value of this field is blank.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-386) Update all java chassis samples ReadMe file add "how to verify" chapter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396345#comment-16396345
 ] 

ASF GitHub Bot commented on SCB-386:


WillemJiang closed pull request #590: [SCB-386] Update all java chassis samples 
ReadMe file add "how to verify" chapter and fix small mistakes
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/590
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/samples/auth-sample/README.md b/samples/auth-sample/README.md
index fbf78217e..7f7e4b83f 100644
--- a/samples/auth-sample/README.md
+++ b/samples/auth-sample/README.md
@@ -88,4 +88,13 @@ Auth sample use `RestTemplate` to present RSA communication 
between provider and
mvn exec:java 
-Dexec.mainClass="org.apache.servicecomb.samples.springmvc.consumer.AuthConsumerMain"
```
 
-   ​
\ No newline at end of file
+4. How to verify
+   On the producer side, the output should contain the following stuffs if the 
producer starts up successfully:
+   1. *'swagger: 2.0 info: version: 1.0.0 ...'* means the producer generated 
swagger contracts
+   2. *'rest listen success. address=0.0.0.0:8080'* means the rest endpoint is 
listening on port 8080
+   3. *'highway listen success. address=0.0.0.0:7070'* means the highway 
endpoint is listening on port 7070
+   4. *'Register microservice instance success'* means the producer has 
registered successfully to service center
+   
+   On the consumer side, you can see the following outputs if the consumer can 
invoke the producer:
+   1. *'Hello Authenticate'* means the consumer calls sayhi with 
name=Authenticate successfully
+   2. *'Hello person ServiceComb/Authenticate'* means the consumer calls 
sayhello successfully
\ No newline at end of file
diff --git 
a/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java
 
b/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java
index 230ea765a..c3993dddf 100644
--- 
a/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java
+++ 
b/samples/auth-sample/auth-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/AuthConsumerMain.java
@@ -21,7 +21,6 @@
 import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
 import org.apache.servicecomb.samples.common.schema.models.Person;
 import org.springframework.stereotype.Component;
-import org.springframework.util.Assert;
 import org.springframework.web.client.RestTemplate;
 
 @Component
@@ -44,8 +43,8 @@ public static void main(String[] args) throws Exception {
 "cse://auth-provider/springmvchello/sayhello",
 person,
 String.class);
-Assert.isTrue("Hello Authenticate".equals(sayHiResult));
-Assert.isTrue("Hello person 
ServiceComb/Authenticate".equals(sayHelloResult));
+System.out.println(sayHiResult);
+System.out.println(sayHelloResult);
   }
 
   public static void init() throws Exception {
diff --git 
a/samples/auth-sample/auth-provider/src/main/resources/microservice.yaml 
b/samples/auth-sample/auth-provider/src/main/resources/microservice.yaml
index 9ea88c305..355d67df7 100644
--- a/samples/auth-sample/auth-provider/src/main/resources/microservice.yaml
+++ b/samples/auth-sample/auth-provider/src/main/resources/microservice.yaml
@@ -28,6 +28,6 @@ cse:
   Provider:
 default: auth-provider
   rest:
-address: 0.0.0.0:8082
+address: 0.0.0.0:8080
   highway:
 address: 0.0.0.0:7070
diff --git a/samples/codefirst-sample/README.md 
b/samples/codefirst-sample/README.md
index b756ae984..f74ba6468 100644
--- a/samples/codefirst-sample/README.md
+++ b/samples/codefirst-sample/README.md
@@ -48,4 +48,17 @@ For detail information please refer to 
[Doc](http://servicecomb.incubator.apache
mvn exec:java 
-Dexec.mainClass="org.apache.servicecomb.samples.codefirst.consumer.CodeFirstConsumerMain"
```
 
-   ​
\ No newline at end of file
+4. How to verify
+   On the producer side, the output should contain the following stuffs if the 
producer starts up successfully:
+   1. *'swagger: 2.0 info: version: 1.0.0 ...'* means the producer generated 
swagger contracts
+   2. *'rest listen success. address=0.0.0.0:8080'* means the rest endpoint is 
listening on port 8080
+   3. *'highway listen success. address=0.0.0.0:7070'* means the highway 
endpoint is listening on port 7070
+   4. *'Register microservice instance success'* means the producer has 
registered successfully to service center
+   
+   On the consumer side, you can see the following outputs if the consumer can 

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395344#comment-16395344
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r173796511
 
 

 ##
 File path: 
omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/ForwardRecoveryTest.java
 ##
 @@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+import static com.seanyinx.github.unit.scaffolding.AssertUtils.expectFailing;
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.fail;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+
+import javax.transaction.InvalidTransactionException;
+
+import org.apache.servicecomb.saga.common.EventType;
+import org.apache.servicecomb.saga.omega.context.IdGenerator;
+import org.apache.servicecomb.saga.omega.context.OmegaContext;
+import org.apache.servicecomb.saga.omega.transaction.annotations.Compensable;
+import org.aspectj.lang.ProceedingJoinPoint;
+import org.aspectj.lang.reflect.MethodSignature;
+import org.junit.Before;
+import org.junit.Test;
+
+public class ForwardRecoveryTest {
+  private final List messages = new ArrayList<>();
+
+  private final String globalTxId = UUID.randomUUID().toString();
+
+  private final String localTxId = UUID.randomUUID().toString();
+
+  private final String parentTxId = UUID.randomUUID().toString();
+
+  private final String newLocalTxId = UUID.randomUUID().toString();
+
+  private final RuntimeException oops = new RuntimeException("oops");
+
+  @SuppressWarnings("unchecked")
+  private final IdGenerator idGenerator = mock(IdGenerator.class);
+
+  private final OmegaContext omegaContext = new OmegaContext(idGenerator);
+
+  private final ProceedingJoinPoint joinPoint = 
mock(ProceedingJoinPoint.class);
+
+  private final MethodSignature methodSignature = mock(MethodSignature.class);
+
+  private final Compensable compensable = mock(Compensable.class);
+
+  private final MessageSender sender = e -> {
+messages.add(e);
+return new AlphaResponse(false);
+  };
+
+  private final CompensableInterceptor interceptor = new 
CompensableInterceptor(omegaContext, sender);
+
+  private final RecoveryPolicy recoveryPolicy = new ForwardRecovery();
+
+  @Before
+  public void setUp() throws Exception {
+when(idGenerator.nextId()).thenReturn(newLocalTxId);
+when(joinPoint.getSignature()).thenReturn(methodSignature);
+when(joinPoint.getTarget()).thenReturn(this);
+
+
when(methodSignature.getMethod()).thenReturn(this.getClass().getDeclaredMethod("doNothing"));
+when(compensable.compensationMethod()).thenReturn("doNothing");
+when(compensable.retries()).thenReturn(0);
+
+omegaContext.setGlobalTxId(globalTxId);
+omegaContext.setLocalTxId(localTxId);
+  }
+
+  @Test
+  public void forwardExceptionWhenGlobalTxAborted() {
+MessageSender sender = mock(MessageSender.class);
+when(sender.send(any())).thenReturn(new AlphaResponse(true));
+
+CompensableInterceptor interceptor = new 
CompensableInterceptor(omegaContext, sender);
+
+try {
+  recoveryPolicy.apply(joinPoint, compensable, interceptor, omegaContext, 
parentTxId, 0);
+  expectFailing(InvalidTransactionException.class);
+} catch (InvalidTransactionException e) {
+  assertThat(e.getMessage().contains("Abort sub transaction"), is(true));
+} catch (Throwable throwable) {
+  fail("unexpected exception throw: " + throwable);
+}
+
+verify(sender, times(1)).send(any());
+  }
+
+  @Test
+  public void throwExceptionWhenRetryReachesMaximum() throws Throwable {
+when(compensable.retries()).thenReturn(2);
+

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395342#comment-16395342
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r173795656
 
 

 ##
 File path: 
omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/TransactionAspectTest.java
 ##
 @@ -125,37 +120,88 @@ public void restoreContextOnCompensableError() throws 
Throwable {
   }
 
   @Test
-  public void returnImmediatelyWhenReceivedRejectResponse() throws Throwable {
-MessageSender sender = mock(MessageSender.class);
-when(sender.send(any())).thenReturn(new AlphaResponse(true));
+  public void retryReachesMaximumAndForwardException() throws Throwable {
+RuntimeException oops = new RuntimeException("oops");
+when(joinPoint.proceed()).thenThrow(oops);
+when(compensable.retries()).thenReturn(3);
 
-TransactionAspect aspect = new TransactionAspect(sender, omegaContext);
 try {
   aspect.advise(joinPoint, compensable);
-  expectFailing(InvalidTransactionException.class);
-} catch (InvalidTransactionException e) {
-  System.out.println(e.getMessage());
-  assertThat(e.getMessage().contains("Abort sub transaction"), is(true));
+  expectFailing(RuntimeException.class);
+} catch (RuntimeException e) {
+  assertThat(e.getMessage(), is("oops"));
 }
 
-verify(sender, times(1)).send(any());
+assertThat(messages.size(), is(6));
+
+TxEvent startedEvent1 = messages.get(0);
+assertThat(startedEvent1.globalTxId(), is(globalTxId));
+assertThat(startedEvent1.localTxId(), is(newLocalTxId));
+assertThat(startedEvent1.parentTxId(), is(localTxId));
+assertThat(startedEvent1.type(), is(EventType.TxStartedEvent));
+assertThat(startedEvent1.retries(), is(3));
+assertThat(startedEvent1.retryMethod(), 
is(this.getClass().getDeclaredMethod("doNothing").toString()));
+
+assertThat(messages.get(1).type(), is(EventType.TxAbortedEvent));
+
+TxEvent startedEvent2 = messages.get(2);
+assertThat(startedEvent2.localTxId(), is(newLocalTxId));
+assertThat(startedEvent2.type(), is(EventType.TxStartedEvent));
+assertThat(startedEvent2.retries(), is(2));
+
+assertThat(messages.get(3).type(), is(EventType.TxAbortedEvent));
+
+TxEvent startedEvent3 = messages.get(4);
+assertThat(startedEvent3.localTxId(), is(newLocalTxId));
+assertThat(startedEvent3.type(), is(EventType.TxStartedEvent));
+assertThat(startedEvent3.retries(), is(1));
+
+assertThat(messages.get(5).type(), is(EventType.TxAbortedEvent));
+
+assertThat(omegaContext.globalTxId(), is(globalTxId));
+assertThat(omegaContext.localTxId(), is(localTxId));
   }
 
   @Test
-  public void recordRetryMethodWhenRetriesIsSet() throws Throwable {
-int retries = new Random().nextInt(Integer.MAX_VALUE - 1) + 1;
-when(compensable.retries()).thenReturn(retries);
+  public void keepRetryingTillSuccess() throws Throwable {
+RuntimeException oops = new RuntimeException("oops");
+when(joinPoint.proceed()).thenThrow(oops).thenThrow(oops).thenReturn(null);
+when(compensable.retries()).thenReturn(-1);
 
-aspect.advise(joinPoint, compensable);
+try {
+  aspect.advise(joinPoint, compensable);
+} catch (Exception e) {
 
 Review comment:
   We don't need to catch the exception here, as the JUnit test failed when the 
exception is throw.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395345#comment-16395345
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r173800214
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/DefaultRecovery.java
 ##
 @@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+import java.lang.invoke.MethodHandles;
+import java.lang.reflect.Method;
+
+import javax.transaction.InvalidTransactionException;
+
+import org.apache.servicecomb.saga.omega.context.OmegaContext;
+import org.apache.servicecomb.saga.omega.transaction.annotations.Compensable;
+import org.aspectj.lang.ProceedingJoinPoint;
+import org.aspectj.lang.reflect.MethodSignature;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DefaultRecovery implements RecoveryPolicy {
 
 Review comment:
   Is it a backward recovery?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395343#comment-16395343
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r173799065
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/RecoveryPolicyFactory.java
 ##
 @@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+public class RecoveryPolicyFactory {
+  private static final RecoveryPolicy defaultRecovery = new DefaultRecovery();
+
+  private static final RecoveryPolicy forwardRecovery = new ForwardRecovery();
+
+  static RecoveryPolicy getRecoveryPolicy(int retries) {
 
 Review comment:
   How can you decide the RecoveryPolicy by using the retries parameter.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395340#comment-16395340
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r173798670
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TransactionAspect.java
 ##
 @@ -33,7 +31,7 @@
 
 @Aspect
 public class TransactionAspect {
-  private static final Logger LOG = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final Logger log = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
 Review comment:
   It's common practice to use upper case for the static constant.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-394) sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395289#comment-16395289
 ] 

ASF GitHub Bot commented on SCB-394:


weichao666 commented on issue #588: [SCB-394] framework version support SC 
which earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#issuecomment-372323643
 
 
   
![image](https://user-images.githubusercontent.com/30716999/37288597-a3461270-2642-11e8-8627-5b9279e2955d.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0
> --
>
> Key: SCB-394
> URL: https://issues.apache.org/jira/browse/SCB-394
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> for the ServiceCenter's version of 1.0.0 and above,sdk report framework's 
> version to SC,
> for SC's version below 1.0.0, such as 0.5.0, sdk doesn't report framework's 
> version



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395139#comment-16395139
 ] 

ASF GitHub Bot commented on SCB-224:


coveralls commented on issue #138: [WIP] SCB-224 retry sub-transaction on 
failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15926062/badge)](https://coveralls.io/builds/15926062)
   
   Coverage increased (+0.05%) to 95.337% when pulling 
**c1d96b209041934a277485d510025df40fc3c683 on eric-lee-ltk:SCB-224** into 
**dbac344f6e7a6e904dc6c0642c72c9539d4e5fe4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang reassigned SCB-395:


Assignee: Eric Lee  (was: Willem Jiang)

> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
>  Labels: release
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-395:
-
Labels:   (was: release)

> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-386) Update all java chassis samples ReadMe file add "how to verify" chapter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395034#comment-16395034
 ] 

ASF GitHub Bot commented on SCB-386:


zhengyangyong opened a new pull request #590: [SCB-386] Update all java chassis 
samples ReadMe file add "how to verify" chapter and fix small mistakes
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/590
 
 
   …y" chapter
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   1.Update all java chassis samples ReadMe file add "how to verify" chapter
   2.fix small mistakes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update all java chassis samples ReadMe file add "how to verify" chapter
> ---
>
> Key: SCB-386
> URL: https://issues.apache.org/jira/browse/SCB-386
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> In those files how to verify producer had correct startup and how to check 
> consumer had correct acted are missing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-395:
-
Labels: release  (was: )

> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
>  Labels: release
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-395:
-
Fix Version/s: saga-0.1.0

> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang reassigned SCB-395:


Assignee: Willem Jiang

> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-395) Add How to build into README file

[Willem Jiang (JIRA)]

Willem Jiang created SCB-395:


 Summary: Add How to build into README file
 Key: SCB-395
 URL: https://issues.apache.org/jira/browse/SCB-395
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Saga
Reporter: Willem Jiang


Current README doesn't has the section of how to build the binary from source.

As we have some docker image need to be generated, we need to tell the user 
about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395030#comment-16395030
 ] 

ASF GitHub Bot commented on SCB-387:


asifdxtreme closed pull request #303: SCB-387 Add ASF headers for 
auto-generated files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/api-docs.html b/docs/api-docs.html
index 74aa2b36..3f221c53 100644
--- a/docs/api-docs.html
+++ b/docs/api-docs.html
@@ -1,3 +1,19 @@
+
 
 
   
diff --git a/docs/release/Readme.md b/docs/release/Readme.md
index 1a06194d..09f6994c 100644
--- a/docs/release/Readme.md
+++ b/docs/release/Readme.md
@@ -27,14 +27,12 @@ cp  apache-rat-0.12/apache-rat-0.12.jar ./
 Run the Rat tool using the below command
 
 ```
-java -jar apache-rat-0.12.jar -a -d incubator-servicecomb-service-center/ -e 
*.md *.MD .gitignore .gitmodules .travis.yml *.json *.yaml *.tmpl *.conf *.html 
*.pb.go services.proto  broker.proto manifest **vendor** **licenses**
+java -jar apache-rat-0.12.jar -a -d incubator-servicecomb-service-center/ -e 
*.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses**
 ```
 
 Below is the list of the files which has been excluded from the list of RAT 
tool.
  - *.md  *.MD *.html:  Skip all the Readme and Documentation file like Api 
Docs.
  - .gitignore .gitmodules .travis.yml : Skip the git files and travis file.
- - *.json *.yaml *.tmpl *.conf : Skip all the json files , yaml files, temp 
DockerFile and configuration files.
- - *.pb.go services.proto : Skip the Protobuf auto-generated codes.
  - manifest **vendor : Skip manifest and all the files under vendor.
  
 You can access the latest RAT report [here](/docs/release/rat-report)  
diff --git a/etc/conf/app.conf b/etc/conf/app.conf
index a4fa9bfd..cae53915 100644
--- a/etc/conf/app.conf
+++ b/etc/conf/app.conf
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 component_name = service_center
 #run mode could be many options to specify the env like prod,dev
 runmode = dev
@@ -111,4 +126,4 @@ logfile = ""
 # Frontend Configurations
 ###
 frontend_host_ip=127.0.0.1
-frontend_host_port=30103
\ No newline at end of file
+frontend_host_port=30103
diff --git a/examples/service_center/body/add_dependency_request.json 
b/examples/service_center/body/add_dependency_request.json
index b8797e26..1caf38dc 100644
--- a/examples/service_center/body/add_dependency_request.json
+++ b/examples/service_center/body/add_dependency_request.json
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 {
 "dependencies": [
 {
diff --git a/examples/service_center/body/create_service_response.json 
b/examples/service_center/body/create_service_response.json
index 46ea5d03..da249e0c 100644
--- a/examples/service_center/body/create_service_response.json
+++ b/examples/service_center/body/create_service_response.json
@@ -1 +1,16 @@
-{"serviceId":"160ec1686cf911e7b7bc286ed488ff40"}
\ No newline at end of file
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the 

[jira] [Commented] (SCB-388) java chassis src kit should have base directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395026#comment-16395026
 ] 

ASF GitHub Bot commented on SCB-388:


WillemJiang closed pull request #587: SCB-388 java-chassis src kit should have 
base directory.
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/587
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java chassis src kit  should have base directory
> 
>
> Key: SCB-388
> URL: https://issues.apache.org/jira/browse/SCB-388
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: java-chassis-1.0.0-m1
>
>
> Current java-chassis src kit doesn't have the base directory, it will cause 
> some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-378) Add readme for samples so that users can run the samples code by just reading the readme doc

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395007#comment-16395007
 ] 

ASF GitHub Bot commented on SCB-378:


lijasonvip opened a new pull request #589: SCB-378 fix apllo readme
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/589
 
 
   Signed-off-by: lijasonvip 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add readme for samples so that users can run the samples code by just reading 
> the readme doc
> 
>
> Key: SCB-378
> URL: https://issues.apache.org/jira/browse/SCB-378
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis, Saga
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
> Fix For: java-chassis-1.0.0-m1, saga-0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-394) sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395000#comment-16395000
 ] 

ASF GitHub Bot commented on SCB-394:


weichao666 opened a new pull request #588: [SCB-394] framework version support 
SC which earlier than 1.0.0
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/588
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0
> --
>
> Key: SCB-394
> URL: https://issues.apache.org/jira/browse/SCB-394
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> for the ServiceCenter's version of 1.0.0 and above,sdk report framework's 
> version to SC,
> for SC's version below 1.0.0, such as 0.5.0, sdk doesn't report framework's 
> version



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-394) sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395001#comment-16395001
 ] 

ASF GitHub Bot commented on SCB-394:


weichao666 commented on issue #588: [SCB-394] framework version support SC 
which earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#issuecomment-372250996
 
 
   for the ServiceCenter's version of 1.0.0 and above,sdk report framework's 
version to SC,
   for SC's version below 1.0.0, such as 0.5.0, sdk doesn't report framework's 
version


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0
> --
>
> Key: SCB-394
> URL: https://issues.apache.org/jira/browse/SCB-394
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> for the ServiceCenter's version of 1.0.0 and above,sdk report framework's 
> version to SC,
> for SC's version below 1.0.0, such as 0.5.0, sdk doesn't report framework's 
> version



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-394) sdk report framework's version support SC which earlier than 1.0.0, e.g. 0.5.0

[WeiChao (JIRA)]

WeiChao created SCB-394:
---

 Summary: sdk report framework's version support SC which earlier 
than 1.0.0, e.g. 0.5.0
 Key: SCB-394
 URL: https://issues.apache.org/jira/browse/SCB-394
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Java-Chassis
Reporter: WeiChao
Assignee: WeiChao
 Fix For: java-chassis-1.0.0-m2


for the ServiceCenter's version of 1.0.0 and above,sdk report framework's 
version to SC,

for SC's version below 1.0.0, such as 0.5.0, sdk doesn't report framework's 
version



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-392) The stop script print error message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394981#comment-16394981
 ] 

ASF GitHub Bot commented on SCB-392:


asifdxtreme closed pull request #305: SCB-392 The stop script print error 
message
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/305
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scripts/release/start_scripts/linux/stop-service-center.sh 
b/scripts/release/start_scripts/linux/stop-service-center.sh
index 0e27b1f4..094eb9eb 100644
--- a/scripts/release/start_scripts/linux/stop-service-center.sh
+++ b/scripts/release/start_scripts/linux/stop-service-center.sh
@@ -15,4 +15,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-kill -9 $(ps aux | grep 'service-center' | awk '{print $2}')
+ps -o pid,cmd,args ax | grep 'service-center' | grep -v grep | awk '{print 
$1}' | xargs kill -9


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The stop script print error message
> ---
>
> Key: SCB-392
> URL: https://issues.apache.org/jira/browse/SCB-392
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394968#comment-16394968
 ] 

ASF GitHub Bot commented on SCB-387:


yangbor commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372232771
 
 
   For the JSON files, perhaps we can use the form {"ASF_HEADER" : "This 
product..."} to add the header without making those json files invalid.
   But as those files are just for demostration, neither our program nor 
clients' use those files directly, it can be left as is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-392) The stop script print error message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394962#comment-16394962
 ] 

ASF GitHub Bot commented on SCB-392:


coveralls commented on issue #305: SCB-392 The stop script print error message
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/305#issuecomment-372233799
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15923058/badge)](https://coveralls.io/builds/15923058)
   
   Coverage increased (+0.1%) to 74.063% when pulling 
**0bcb777e79d0209cffe3bbe7adf4db7181ea58ef on little-cui:master** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The stop script print error message
> ---
>
> Key: SCB-392
> URL: https://issues.apache.org/jira/browse/SCB-392
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-392) The stop script print error message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394961#comment-16394961
 ] 

ASF GitHub Bot commented on SCB-392:


codecov-io commented on issue #305: SCB-392 The stop script print error message
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/305#issuecomment-372233736
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=h1)
 Report
   > Merging 
[#305](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305/graphs/tree.svg?width=650=pr=GAaF7zrg8R=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #305   +/-   ##
   ===
 Coverage   70.39%   70.39%   
   ===
 Files  17   17   
 Lines3455 3455   
   ===
 Hits 2432 2432   
 Misses853  853   
 Partials  170  170
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=footer).
 Last update 
[bfe0666...0bcb777](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/305?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The stop script print error message
> ---
>
> Key: SCB-392
> URL: https://issues.apache.org/jira/browse/SCB-392
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394959#comment-16394959
 ] 

ASF GitHub Bot commented on SCB-391:


coveralls commented on issue #304: SCB-391 SC does not rotate log file
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/304#issuecomment-372233609
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15923047/badge)](https://coveralls.io/builds/15923047)
   
   Coverage increased (+0.1%) to 74.063% when pulling 
**545e00756418fd62b407576bb7da4dfff9285898 on little-cui:SCB-391** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394960#comment-16394960
 ] 

ASF GitHub Bot commented on SCB-391:


codecov-io commented on issue #304: SCB-391 SC does not rotate log file
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/304#issuecomment-372233639
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=h1)
 Report
   > Merging 
[#304](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304/graphs/tree.svg?width=650=pr=GAaF7zrg8R=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #304   +/-   ##
   ===
 Coverage   70.39%   70.39%   
   ===
 Files  17   17   
 Lines3455 3455   
   ===
 Hits 2432 2432   
 Misses853  853   
 Partials  170  170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `77.25% <0%> (+0.42%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=footer).
 Last update 
[bfe0666...545e007](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394957#comment-16394957
 ] 

ASF GitHub Bot commented on SCB-387:


yangbor commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372232771
 
 
   For the JSON files, perhaps we can use the form {"ASF_HEADER" : "This 
product..."} to add the header without making those json files invalid.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-392) The stop script print error message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394952#comment-16394952
 ] 

ASF GitHub Bot commented on SCB-392:


little-cui opened a new pull request #305: SCB-392 The stop script print error 
message
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/305
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The stop script print error message
> ---
>
> Key: SCB-392
> URL: https://issues.apache.org/jira/browse/SCB-392
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-390) [pack] Investigating the Byteman and the Cucumber with running the recovery acceptance tests

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-390:
-
Fix Version/s: saga-0.2.0

> [pack] Investigating the Byteman and the Cucumber with running the recovery 
> acceptance tests
> 
>
> Key: SCB-390
> URL: https://issues.apache.org/jira/browse/SCB-390
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Saga
>Reporter: Zheng Feng
>Assignee: Zheng Feng
>Priority: Major
> Fix For: saga-0.2.0
>
>
> [Byteman|http://byteman.jboss.org/] it a tool for injecting the fault with 
> the test by instructing some rules with the java agent. We are using the 
> Cucumber to do the acceptance tests currently, and it has to simulate some 
> situations (e.g. network failure, application crash) in the test scenario 
> especially recovering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394951#comment-16394951
 ] 

ASF GitHub Bot commented on SCB-391:


little-cui opened a new pull request #304: SCB-391 SC does not rotate log file
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/304
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394949#comment-16394949
 ] 

ASF GitHub Bot commented on SCB-387:


codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1)
 Report
   > Merging 
[#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/graphs/tree.svg?token=GAaF7zrg8R=650=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #303   +/-   ##
   ===
 Coverage   70.39%   70.39%   
   ===
 Files  17   17   
 Lines3455 3455   
   ===
 Hits 2432 2432   
 Misses853  853   
 Partials  170  170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `77.25% <0%> (+0.42%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer).
 Last update 
[bfe0666...1b3a012](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394948#comment-16394948
 ] 

ASF GitHub Bot commented on SCB-387:


coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15922904/badge)](https://coveralls.io/builds/15922904)
   
   Coverage increased (+0.2%) to 74.112% when pulling 
**1b3a0128c7a9cecea6729efd10daad1489c4a85f on asifdxtreme:master** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394945#comment-16394945
 ] 

ASF GitHub Bot commented on SCB-387:


coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15922873/badge)](https://coveralls.io/builds/15922873)
   
   Coverage increased (+0.1%) to 74.063% when pulling 
**1b3a0128c7a9cecea6729efd10daad1489c4a85f on asifdxtreme:master** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-391) SC does not rotate log file

[little-cui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

little-cui updated SCB-391:
---
Component/s: Service-Center

> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-393) SC

[little-cui (JIRA)]

little-cui created SCB-393:
--

 Summary: SC
 Key: SCB-393
 URL: https://issues.apache.org/jira/browse/SCB-393
 Project: Apache ServiceComb
  Issue Type: Bug
Reporter: little-cui






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-392) The stop script print error message

[little-cui (JIRA)]

little-cui created SCB-392:
--

 Summary: The stop script print error message
 Key: SCB-392
 URL: https://issues.apache.org/jira/browse/SCB-392
 Project: Apache ServiceComb
  Issue Type: Bug
  Components: Service-Center
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.0.0-m2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-391) SC does not rotate log file

[little-cui (JIRA)]

little-cui created SCB-391:
--

 Summary: SC does not rotate log file
 Key: SCB-391
 URL: https://issues.apache.org/jira/browse/SCB-391
 Project: Apache ServiceComb
  Issue Type: Bug
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.0.0-m2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-390) [pack] Investigating the Byteman and the Cucumber with running the recovery acceptance tests

[Zheng Feng (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394929#comment-16394929
 ] 

Zheng Feng commented on SCB-390:


The Byteman and the Cucumber both have the Junit Runner. It looks like not a 
simple way to make them work together. I'm trying to write a runner extends the 
Cucumber one to inject the rules of Byteman.

> [pack] Investigating the Byteman and the Cucumber with running the recovery 
> acceptance tests
> 
>
> Key: SCB-390
> URL: https://issues.apache.org/jira/browse/SCB-390
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Saga
>Reporter: Zheng Feng
>Assignee: Zheng Feng
>Priority: Major
>
> [Byteman|http://byteman.jboss.org/] it a tool for injecting the fault with 
> the test by instructing some rules with the java agent. We are using the 
> Cucumber to do the acceptance tests currently, and it has to simulate some 
> situations (e.g. network failure, application crash) in the test scenario 
> especially recovering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-390) [pack] Investigating the Byteman and the Cucumber with running the recovery acceptance tests

[Zheng Feng (JIRA)]

Zheng Feng created SCB-390:
--

 Summary: [pack] Investigating the Byteman and the Cucumber with 
running the recovery acceptance tests
 Key: SCB-390
 URL: https://issues.apache.org/jira/browse/SCB-390
 Project: Apache ServiceComb
  Issue Type: Task
  Components: Saga
Reporter: Zheng Feng
Assignee: Zheng Feng


[Byteman|http://byteman.jboss.org/] it a tool for injecting the fault with the 
test by instructing some rules with the java agent. We are using the Cucumber 
to do the acceptance tests currently, and it has to simulate some situations 
(e.g. network failure, application crash) in the test scenario especially 
recovering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-388) java chassis src kit should have base directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394921#comment-16394921
 ] 

ASF GitHub Bot commented on SCB-388:


WillemJiang opened a new pull request #587: SCB-388 java-chassis src kit should 
have base directory.
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/587
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java chassis src kit  should have base directory
> 
>
> Key: SCB-388
> URL: https://issues.apache.org/jira/browse/SCB-388
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: java-chassis-1.0.0-m1
>
>
> Current java-chassis src kit doesn't have the base directory, it will cause 
> some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-388) java chassis src kit should have base directory

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-388:
-
Fix Version/s: java-chassis-1.0.0-m1

> java chassis src kit  should have base directory
> 
>
> Key: SCB-388
> URL: https://issues.apache.org/jira/browse/SCB-388
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: java-chassis-1.0.0-m1
>
>
> Current java-chassis src kit doesn't have the base directory, it will cause 
> some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394920#comment-16394920
 ] 

ASF GitHub Bot commented on SCB-387:


coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15922358/badge)](https://coveralls.io/builds/15922358)
   
   Coverage increased (+0.1%) to 74.063% when pulling 
**0fdb7cf9057ec96ff99316b1de045e3d6f03c5a8 on asifdxtreme:master** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-388) java chassis src kit should have base directory

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-388:
-
Summary: java chassis src kit  should have base directory  (was: java 
chassis src kit  should has base directory)

> java chassis src kit  should have base directory
> 
>
> Key: SCB-388
> URL: https://issues.apache.org/jira/browse/SCB-388
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: Willem Jiang
>Priority: Minor
> Fix For: java-chassis-1.0.0-m1
>
>
> Current java-chassis src kit doesn't have the base directory, it will cause 
> some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394919#comment-16394919
 ] 

ASF GitHub Bot commented on SCB-387:


codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1)
 Report
   > Merging 
[#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/graphs/tree.svg?token=GAaF7zrg8R=650=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #303   +/-   ##
   ===
 Coverage   70.39%   70.39%   
   ===
 Files  17   17   
 Lines3455 3455   
   ===
 Hits 2432 2432   
 Misses853  853   
 Partials  170  170
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer).
 Last update 
[bfe0666...0fdb7cf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-330) [pack] update documents of saga pack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394906#comment-16394906
 ] 

ASF GitHub Bot commented on SCB-330:


WillemJiang closed pull request #150: SCB-330 fix guide of mysql
URL: https://github.com/apache/incubator-servicecomb-saga/pull/150
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md 
b/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
index f241b36f..0ef18abf 100644
--- a/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
+++ b/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
@@ -11,15 +11,20 @@
 
 2. 安装Saga
```bash
-   mvn clean install -Pdocker -DskipTests
+   mvn clean package -Pdocker -DskipTests
```

在命令执行完成后，会生成名为alpha-server的镜像和可执行文件`alpha/alpha-server/target/saga/alpha-server-${version}-exec.jar`。
-   **注意**: 如果不需要生成docker镜像，则直接运行`mvn clean install -DskipTests`即可。
-   **注意**: 如果您之前已生成了alpha-server的docker镜像，则需要在运行命令前将其删除。
+
+   **注意**: 如果不需要生成docker镜像，则直接运行`mvn clean package -DskipTests`即可。
+
+   **注意**: 如果您之前已生成了alpha-server的docker镜像，则需要先执行以下命令将其删除：
+   ```bash
+   docker rmi -f $(docker images | grep alpha-server | awk '{print $3}')
+   ```

 3. 运行MySQL
```bash
-   docker run -d -e "MYSQL_ROOT_PASSWORD=password" "-e "MYSQL_DATABASE=saga" 
-e "MYSQL_USER=saga" -e "MYSQL_PASSWORD=password" -p 3306:3306 
mysql/mysql-server:5.7
+   docker run -d -e "MYSQL_ROOT_PASSWORD=password" -e "MYSQL_DATABASE=saga" -e 
"MYSQL_USER=saga" -e "MYSQL_PASSWORD=password" -p 3306:3306 
mysql/mysql-server:5.7
```
 
 4. 运行alpha。请确保MySQL在此前已成功启动。alpha的运行可通过docker或可执行文件的方式。
diff --git a/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md 
b/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
index 2bb2954d..14fd5980 100644
--- a/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
+++ b/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
@@ -11,15 +11,20 @@
 
 2. install Saga
```bash
-   mvn clean install -Pdocker -DskipTests
+   mvn clean package -Pdocker -DskipTests
```
After that, you will find the generated docker image `alpha-server` and 
executable file 
`alpha/alpha-server/target/saga/alpha-server-${version}-exec.jar`.
-   **Notice**: If you do not want to build the docker image, run `mvn clean 
install -DskipTests` is enough.
+
+   **Notice**: If you do not want to build the docker image, run `mvn clean 
package -DskipTests` is enough.
+
**Notice**: If you have installed saga with docker before, you need to 
remove the alpha-server's docker image first.
+   ```bash
+   docker rmi -f $(docker images | grep alpha-server | awk '{print $3}')
+   ```
 
 3. run MySQL
```bash
-   docker run -d -e "MYSQL_ROOT_PASSWORD=password" "-e "MYSQL_DATABASE=saga" 
-e "MYSQL_USER=saga" -e "MYSQL_PASSWORD=password" -p 3306:3306 
mysql/mysql-server:5.7
+   docker run -d -e "MYSQL_ROOT_PASSWORD=password" -e "MYSQL_DATABASE=saga" -e 
"MYSQL_USER=saga" -e "MYSQL_PASSWORD=password" -p 3306:3306 
mysql/mysql-server:5.7
```
 
 4. Run alpha. Please make sure MySQL is up before this step. You can run alpha 
through docker or executable file.
@@ -31,4 +36,4 @@
   ```bash
   java -Dspring.profiles.active=mysql 
-D"spring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
-jar alpha-server-${saga_version}-exec.jar
   ```
-   **Notice**: Please change `${saga_version}` and `${host_address}` to the 
actual value before you execute the command.
\ No newline at end of file
+   **Notice**: Please change `${saga_version}` and `${host_address}` to the 
actual value before you execute the command.
diff --git a/saga-demo/booking/README.md b/saga-demo/booking/README.md
index 6a97537b..8e2dfc3f 100644
--- a/saga-demo/booking/README.md
+++ b/saga-demo/booking/README.md
@@ -35,8 +35,15 @@ You will need:
 mysql-connector-java
   
   ```
-   
-   2. start application up in `saga-demo/booking` with the following command
+   2. remove alpha server's docker image
+  ```bash
+  docker rmi -f $(docker images | grep alpha-server | awk '{print $3}')
+  ```
+   3. re-generate saga's docker images
+  ```bash
+  mvn package -DskipTests -Pdocker -Pdemo
+  ```
+   4. start application up in `saga-demo/booking` with the following command
   ```
   docker-compose -f docker-compose.yaml -f docker-compose.mysql.yaml up
   ```
diff --git a/saga-demo/booking/docker-compose.yaml 
b/saga-demo/booking/docker-compose.yaml
index e528c83a..e1e3e307 100644
--- a/saga-demo/booking/docker-compose.yaml
+++ b/saga-demo/booking/docker-compose.yaml
@@ -32,7 +32,7 @@ services:
 

[jira] [Commented] (SCB-378) Add readme for samples so that users can run the samples code by just reading the readme doc

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394903#comment-16394903
 ] 

ASF GitHub Bot commented on SCB-378:


WillemJiang closed pull request #149: SCB-378 update saga demo readme to fix 
docker-compose.yml file path
URL: https://github.com/apache/incubator-servicecomb-saga/pull/149
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/saga-demo/booking/README.md b/saga-demo/booking/README.md
index 4ceedaf4..6a97537b 100644
--- a/saga-demo/booking/README.md
+++ b/saga-demo/booking/README.md
@@ -22,7 +22,7 @@ You will need:
mvn package -DskipTests -Pdocker -Pdemo
```
 
-2. start application up in saga/saga-demo/pack-demo with the following command
+2. start application up in `saga-demo/booking/` with the following command
```
docker-compose up
```
@@ -36,7 +36,7 @@ You will need:
   
   ```

-   2. start application up in saga/saga-demo/pack-demo with the following 
command
+   2. start application up in `saga-demo/booking` with the following command
   ```
   docker-compose -f docker-compose.yaml -f docker-compose.mysql.yaml up
   ```


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add readme for samples so that users can run the samples code by just reading 
> the readme doc
> 
>
> Key: SCB-378
> URL: https://issues.apache.org/jira/browse/SCB-378
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis, Saga
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
> Fix For: java-chassis-1.0.0-m1, saga-0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-378) Add readme for samples so that users can run the samples code by just reading the readme doc

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-378:
-
Fix Version/s: saga-0.1.0
   java-chassis-1.0.0-m1

> Add readme for samples so that users can run the samples code by just reading 
> the readme doc
> 
>
> Key: SCB-378
> URL: https://issues.apache.org/jira/browse/SCB-378
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis, Saga
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
> Fix For: java-chassis-1.0.0-m1, saga-0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-378) Add readme for samples so that users can run the samples code by just reading the readme doc

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-378:
-
Component/s: Saga
 Java-Chassis

> Add readme for samples so that users can run the samples code by just reading 
> the readme doc
> 
>
> Key: SCB-378
> URL: https://issues.apache.org/jira/browse/SCB-378
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis, Saga
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
> Fix For: java-chassis-1.0.0-m1, saga-0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394898#comment-16394898
 ] 

ASF GitHub Bot commented on SCB-387:


coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15922065/badge)](https://coveralls.io/builds/15922065)
   
   Coverage remained the same at 73.961% when pulling 
**4b60ee6896259312952da4ebaf8f51c6abb3b318 on asifdxtreme:master** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394899#comment-16394899
 ] 

ASF GitHub Bot commented on SCB-387:


codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated 
files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1)
 Report
   > Merging 
[#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #303  +/-   ##
   ==
   - Coverage   70.39%   70.36%   -0.03% 
   ==
 Files  17   17  
 Lines3455 3455  
   ==
   - Hits 2432 2431   -1 
 Misses853  853  
   - Partials  170  171   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer).
 Last update 
[bfe0666...4b60ee6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394886#comment-16394886
 ] 

ASF GitHub Bot commented on SCB-387:


asifdxtreme opened a new pull request #303: SCB-387 Add ASF headers for 
auto-generated files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-387) Somefiles are lacking ASF header in Service Center

[Mohammad Asif Siddiqui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Asif Siddiqui updated SCB-387:
---
Fix Version/s: service-center-1.0.0-m1

> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCB-387) Somefiles are lacking ASF header in Service Center

[Mohammad Asif Siddiqui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Asif Siddiqui reassigned SCB-387:
--

Assignee: Mohammad Asif Siddiqui

> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-355) As a operator, when sdk config a fault ak/sk on HuaweiCloud, then will auth token fail, but it continues to register, will cause may fault in server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394862#comment-16394862
 ] 

ASF GitHub Bot commented on SCB-355:


jeho0815 closed pull request #565: [SCB-355]If auth failed,sc/cc will not 
connect server to reduce server pressure
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/565
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
index 0ca5668e9..d059dd53c 100644
--- 
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
+++ 
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
@@ -108,6 +108,8 @@
 
   private boolean isWatching = false;
 
+  private boolean authFailed = false;
+
   private static final ServiceLoader authHeaderProviders =
   ServiceLoader.load(AuthHeaderProvider.class);
 
@@ -312,6 +314,9 @@ private void sendHeartbeat(WebSocket ws) {
 }
 
 public void refreshConfig(String configcenter) {
+  if (authFailed) {
+return;
+  }
   clientMgr.findThreadBindClientPool().runOnContext(client -> {
 String path = URIConst.ITEMS + "?dimensionsInfo=" + 
StringUtils.deleteWhitespace(serviceName);
 IpPort ipPort = NetUtils.parseIpPortFromURI(configcenter);
@@ -331,6 +336,10 @@ public void refreshConfig(String configcenter) {
 });
   } else {
 rsp.bodyHandler(buf -> {
+  if (rsp.statusCode() == HttpResponseStatus.UNAUTHORIZED.code()) {
+LOGGER.error("**Auth fail, maybe ak/sk is error, will not try 
again***!");
+authFailed = true;
+  }
   LOGGER.error("fetch config fail: " + buf);
 });
 EventManager.post(new ConnFailEvent("fetch config fail"));
diff --git 
a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/client/TestConfigCenterClient.java
 
b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/client/TestConfigCenterClient.java
index 0f9013c59..8798732a7 100644
--- 
a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/client/TestConfigCenterClient.java
+++ 
b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/client/TestConfigCenterClient.java
@@ -17,6 +17,7 @@
 
 package org.apache.servicecomb.config.client;
 
+import java.lang.reflect.Field;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
@@ -231,4 +232,52 @@ public void runOnContext(RunHandler handler) {
 refresh.run();
 Assert.assertEquals("Succ event trigger", map.get("result"));
   }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void testConfigRefreshAuthFail() {
+ConfigCenterConfigurationSourceImpl impl = new 
ConfigCenterConfigurationSourceImpl();
+impl.init(ConfigUtil.createLocalConfig());
+UpdateHandler updateHandler = impl.new UpdateHandler();
+HttpClientRequest request = Mockito.mock(HttpClientRequest.class);
+
Mockito.when(request.headers()).thenReturn(MultiMap.caseInsensitiveMultiMap());
+Buffer rsp = Mockito.mock(Buffer.class);
+Mockito.when(rsp.toString())
+.thenReturn("{\"requestid\":{\"test123\"}");
+
+HttpClientResponse event = Mockito.mock(HttpClientResponse.class);
+
Mockito.when(event.bodyHandler(Mockito.any(Handler.class))).then(invocation -> {
+  Handler handler = invocation.getArgumentAt(0, Handler.class);
+  handler.handle(rsp);
+  return null;
+});
+Mockito.when(event.statusCode()).thenReturn(401);
+HttpClient httpClient = Mockito.mock(HttpClient.class);
+Mockito.when(
+httpClient.get(Mockito.anyInt(), Mockito.anyString(), 
Mockito.anyString(), Mockito.any(Handler.class)))
+.then(invocation -> {
+  Handler handler = invocation.getArgumentAt(3, 
Handler.class);
+  handler.handle(event);
+  return request;
+});
+new MockUp() {
+  @Mock
+  public void runOnContext(RunHandler handler) {
+handler.run(httpClient);
+  }
+};
+ConfigCenterClient cc = new ConfigCenterClient(updateHandler);
+ParseConfigUtils parseConfigUtils = new ParseConfigUtils(updateHandler);
+MemberDiscovery memberdis = new 
MemberDiscovery(Arrays.asList("http://configcentertest:30103;));
+ConfigRefresh refresh = cc.new ConfigRefresh(parseConfigUtils, memberdis);
+refresh.run();
+try {
+  Field filed = 

[jira] [Commented] (SCB-374) invocation publish life event

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394860#comment-16394860
 ] 

ASF GitHub Bot commented on SCB-374:


wujimin commented on issue #585: [SCB-374] Invocation publish life event
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/585#issuecomment-372205789
 
 
   
![image](https://user-images.githubusercontent.com/16874843/37268615-d3631818-2601-11e8-9e9c-c125160dca69.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> invocation publish life event
> -
>
> Key: SCB-374
> URL: https://issues.apache.org/jira/browse/SCB-374
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-388) java chassis src kit should has base directory

[Willem Jiang (JIRA)]

Willem Jiang created SCB-388:


 Summary: java chassis src kit  should has base directory
 Key: SCB-388
 URL: https://issues.apache.org/jira/browse/SCB-388
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Java-Chassis
Reporter: Willem Jiang


Current java-chassis src kit doesn't have the base directory, it will cause 
some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-374) invocation publish life event

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394841#comment-16394841
 ] 

ASF GitHub Bot commented on SCB-374:


wujimin commented on issue #585: [SCB-374] Invocation publish life event
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/585#issuecomment-372203666
 
 
   added.
   but title is very clear.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> invocation publish life event
> -
>
> Key: SCB-374
> URL: https://issues.apache.org/jira/browse/SCB-374
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-387) Somefiles are lacking ASF header in Service Center

[Yang Bo (JIRA)]

Yang Bo created SCB-387:
---

 Summary: Somefiles are lacking ASF header in Service Center
 Key: SCB-387
 URL: https://issues.apache.org/jira/browse/SCB-387
 Project: Apache ServiceComb
  Issue Type: Bug
  Components: Service-Center
Reporter: Yang Bo


The following files does not have ASF headers

src:

  ./server/broker/broker.pb.go

  ./server/broker/broker.proto

  ./server/core/proto/services.pb.go

  ./server/core/proto/services.proto 

  ./server/core/swagger/v3.yaml

  ./server/core/swagger/v4.yaml

The pb.go files are generated by protobuf utility, perhaps we can exclude it 
for checking. But the .proto files should have the ASF header.

bin:

  ./conf/app.conf

The apache policy states that only files that have no creativity and some 
simple template files for code generation can have the header omitted. Other 
files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-374) invocation publish life event

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394838#comment-16394838
 ] 

ASF GitHub Bot commented on SCB-374:


wujimin commented on a change in pull request #585: [SCB-374] Invocation 
publish life event
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/585#discussion_r173700678
 
 

 ##
 File path: 
common/common-rest/src/test/java/org/apache/servicecomb/common/rest/TestAbstractRestInvocation.java
 ##
 @@ -104,13 +110,23 @@ protected OperationLocator 
locateOperation(ServicePathManager servicePathManager
 }
 
 @Override
-protected void createInvocation(Object[] args) {
+protected void createInvocation() {
   this.invocation = TestAbstractRestInvocation.this.invocation;
 }
   }
 
   AbstractRestInvocation restInvocation = new AbstractRestInvocationForTest();
 
+  @BeforeClass
+  public static void classSetup() {
+EventManager.eventBus = new EventBus();
+  }
+
+  @AfterClass
+  public static void classTeardown() {
+EventManager.eventBus = new EventBus();
 
 Review comment:
   no
   out eventBus extend from this one, but faster.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> invocation publish life event
> -
>
> Key: SCB-374
> URL: https://issues.apache.org/jira/browse/SCB-374
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)