[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398059#comment-16398059
 ] 

ASF GitHub Bot commented on SCB-395:


coveralls commented on issue #153: SCB-395 add guides to run demo without 
docker compose
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/153#issuecomment-372895796
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15963246/badge)](https://coveralls.io/builds/15963246)
   
   Coverage increased (+0.1%) to 95.395% when pulling 
**6b3be4b0a84a29a6323f51554a30609f6a35da27 on eric-lee-ltk:SCB-395** into 
**541202272bdd5f5b76daa11c7b6cf1c1a7d9a505 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398054#comment-16398054
 ] 

ASF GitHub Bot commented on SCB-395:


eric-lee-ltk opened a new pull request #153: SCB-395 add guides to run demo 
without docker compose
URL: https://github.com/apache/incubator-servicecomb-saga/pull/153
 
 
   Signed-off-by: Eric Lee 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396793#comment-16396793
 ] 

ASF GitHub Bot commented on SCB-224:


coveralls commented on issue #138: [WIP] SCB-224 retry sub-transaction on 
failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15946765/badge)](https://coveralls.io/builds/15946765)
   
   Coverage increased (+0.3%) to 95.553% when pulling 
**390d5ac2829917fb651bb084270065ef51616a26 on eric-lee-ltk:SCB-224** into 
**541202272bdd5f5b76daa11c7b6cf1c1a7d9a505 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-397) uniform sha1sum format for release of ServiceComb

2018-03-13 Thread Mohammad Asif Siddiqui (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396788#comment-16396788
 ] 

Mohammad Asif Siddiqui commented on SCB-397:


[~njiang] then in that case we can download the zip from staging repo and use 
gpg2 command line to sign the artifacts and create SHA512 and the same we will 
publish in the apche svn.is that OKAY??

> uniform sha1sum format for release of ServiceComb
> -
>
> Key: SCB-397
> URL: https://issues.apache.org/jira/browse/SCB-397
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Service-Center
>Reporter: Eric Lee
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Currently, the sha1sum format of service center is in the form of A0B3 B1D2 
> ... . However, the sha1sum format of java chassis and saga is a0b3b1d2... . 
> We should use the same format for the whole ServiceComb project. Perfer to 
> use the second form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396779#comment-16396779
 ] 

ASF GitHub Bot commented on SCB-224:


eric-lee-ltk commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r174075643
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/ForwardRecovery.java
 ##
 @@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+import java.lang.invoke.MethodHandles;
+import java.lang.reflect.Method;
+
+import javax.transaction.InvalidTransactionException;
+
+import org.apache.servicecomb.saga.omega.context.OmegaContext;
+import org.apache.servicecomb.saga.omega.transaction.annotations.Compensable;
+import org.aspectj.lang.ProceedingJoinPoint;
+import org.aspectj.lang.reflect.MethodSignature;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ForwardRecovery extends DefaultRecovery {
+  private static final Logger log = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+  // TODO: 2018/03/10 we do not support retry with timeout yet
+  @Override
+  public Object apply(ProceedingJoinPoint joinPoint, Compensable compensable, 
CompensableInterceptor interceptor,
+  OmegaContext context, String parentTxId, int retries) throws Throwable {
+Method method = ((MethodSignature) joinPoint.getSignature()).getMethod();
+int remains = retries;
+try {
+  while (true) {
+try {
+  return super.apply(joinPoint, compensable, interceptor, context, 
parentTxId, remains);
+} catch (Throwable throwable) {
+  if (throwable instanceof InvalidTransactionException) {
+throw throwable;
+  }
+
+  remains = remains == -1 ? -1 : remains - 1;
+  if (remains == 0) {
+log.error(
+"Retried sub tx failed maximum times, global tx id: {}, local 
tx id: {}, method: {}, retried times: {}",
+context.globalTxId(), context.localTxId(), method.toString(), 
retries);
+throw throwable;
+  }
+
+  log.warn("Retrying sub tx failed, global tx id: {}, local tx id: {}, 
method: {}, remains: {}",
+  context.globalTxId(), context.localTxId(), method.toString(), 
remains);
+  Thread.sleep(compensable.retryDelayInMilliseconds());
 
 Review comment:
   Scheduler requires to implement the Callable interface to retrieve the 
return value. However, we need to construct a new instance for every execution 
to pass the paramenters. The times of execution is also hard to control. I 
guess this also introduce performance penalty.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396773#comment-16396773
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r174074224
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/RecoveryPolicyFactory.java
 ##
 @@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+public class RecoveryPolicyFactory {
+  private static final RecoveryPolicy defaultRecovery = new DefaultRecovery();
+
+  private static final RecoveryPolicy forwardRecovery = new ForwardRecovery();
+
+  static RecoveryPolicy getRecoveryPolicy(int retries) {
 
 Review comment:
   It depends on the RecoveryPolicy that you have,  maybe you need to add some 
comments for the DefaultRecovery. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-388) java chassis src kit should have base directory

2018-03-13 Thread Willem Jiang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-388.
--
Resolution: Fixed

Applied the patch into master branch.

> java chassis src kit  should have base directory
> 
>
> Key: SCB-388
> URL: https://issues.apache.org/jira/browse/SCB-388
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: java-chassis-1.0.0-m1
>
>
> Current java-chassis src kit doesn't have the base directory, it will cause 
> some trouble for the user to manage the extract src.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-397) uniform sha1sum format for release of ServiceComb

2018-03-13 Thread Willem Jiang (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396753#comment-16396753
 ] 

Willem Jiang commented on SCB-397:
--

java-chassis is using the maven plugin to do the sign.

[As Apache doesn't suggest to use 
sha1|https://www.apache.org/dev/openpgp.html#sha1], we may need to use the sign 
of  SHA256 or SHA512.

[~asifdxtreme] I guess we may leverage the gpg command to use the upper case 
for Java Chassis and ServiceCenter sign. 

 

> uniform sha1sum format for release of ServiceComb
> -
>
> Key: SCB-397
> URL: https://issues.apache.org/jira/browse/SCB-397
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Service-Center
>Reporter: Eric Lee
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Currently, the sha1sum format of service center is in the form of A0B3 B1D2 
> ... . However, the sha1sum format of java chassis and saga is a0b3b1d2... . 
> We should use the same format for the whole ServiceComb project. Perfer to 
> use the second form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-397) uniform sha1sum format for release of ServiceComb

2018-03-13 Thread Mohammad Asif Siddiqui (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396739#comment-16396739
 ] 

Mohammad Asif Siddiqui commented on SCB-397:


# gpg2 --print-md "*" 
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz 
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
   MD5 = 92 3F C7 C2 4D 35 26 F2  66 2F 53 1E D1 A1 9E 68
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
  SHA1 = E56E AB99 514E 667C 05BE  2EBA 06B7 B0AD 26E6 E3CD
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
RMD160 = 5519 A12D 32F4 59BD BF8F  2613 95E6 84D6 721B FAC9
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
SHA224 = 7FA13D61 A6ADFF58 36B6EBC0 B5FC109F 9A6BAC58 5B52D195 3C73AD8D
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
SHA256 = 55878BBB 1C504C96 8946AEF8 73F8B298 2A318F83 9CFDAB11 27EA6BB2 DCC8D9CE
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
SHA384 = 49862A49 ED40F59B 88410A81 4D5546D5 59EFAD11 79114640 2F6C6762 32434D12
 A9E68371 8556561C 5F202C4F FA5EEC5C
apache-servicecomb-incubating-service-center-1.0.0-m1-linux-amd64.tar.gz: 
SHA512 = 77C53103 CA46B1ED 8DF7FD99 596A7135 0D106694 E3A73EBF 9797AD5F CE86118D
 D64AD7D9 C9F82471 C9B8436E 50BB3F2A 3DEFD413 605CADD4 604D70F0 EF51F1A9


[~ericlee] with current set of available alogorithm, none of them is allowing 
me to create sha in lower caps..where as in java-chassis the sigining of 
the artifacts are taken care by gpg plugin.

Exploring further

> uniform sha1sum format for release of ServiceComb
> -
>
> Key: SCB-397
> URL: https://issues.apache.org/jira/browse/SCB-397
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Service-Center
>Reporter: Eric Lee
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Currently, the sha1sum format of service center is in the form of A0B3 B1D2 
> ... . However, the sha1sum format of java chassis and saga is a0b3b1d2... . 
> We should use the same format for the whole ServiceComb project. Perfer to 
> use the second form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396730#comment-16396730
 ] 

ASF GitHub Bot commented on SCB-395:


WillemJiang closed pull request #152: SCB-395 remove redudant lines
URL: https://github.com/apache/incubator-servicecomb-saga/pull/152
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/user_guide.md b/docs/user_guide.md
index 445fadc7..88858e42 100644
--- a/docs/user_guide.md
+++ b/docs/user_guide.md
@@ -32,13 +32,6 @@ Saga can be built in either of the following ways.
 
 After executing either one of the above command, you will find alpha server's 
executable file in 
`alpha/alpha-server/target/saga/alpha-server-${version}-exec.jar`.
 
-### Build executable files and docker images
-```bash
-$ git clone https://github.com/apache/incubator-servicecomb-saga.git
-$ cd incubator-servicecomb-saga
-$ mvn clean install -DskipTests -Pdocker
-```
-
 ## How to use
 ### Add saga dependencies
 ```xml


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCB-397) uniform sha1sum format for release of ServiceComb

2018-03-13 Thread Mohammad Asif Siddiqui (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Asif Siddiqui reassigned SCB-397:
--

Assignee: Mohammad Asif Siddiqui

> uniform sha1sum format for release of ServiceComb
> -
>
> Key: SCB-397
> URL: https://issues.apache.org/jira/browse/SCB-397
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Service-Center
>Reporter: Eric Lee
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Currently, the sha1sum format of service center is in the form of A0B3 B1D2 
> ... . However, the sha1sum format of java chassis and saga is a0b3b1d2... . 
> We should use the same format for the whole ServiceComb project. Perfer to 
> use the second form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396710#comment-16396710
 ] 

ASF GitHub Bot commented on SCB-395:


coveralls commented on issue #152: SCB-395 remove redudant lines
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/152#issuecomment-372593618
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15945283/badge)](https://coveralls.io/builds/15945283)
   
   Coverage increased (+0.1%) to 95.614% when pulling 
**96c95e20b02b82b810429deb5adf58bc2619b426 on eric-lee-ltk:SCB-395** into 
**26808d91b17fbe1f69a97cd08b607d185b68e0d5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-392) The stop script print error message

2018-03-13 Thread little-cui (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

little-cui resolved SCB-392.

Resolution: Fixed

> The stop script print error message
> ---
>
> Key: SCB-392
> URL: https://issues.apache.org/jira/browse/SCB-392
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396704#comment-16396704
 ] 

ASF GitHub Bot commented on SCB-395:


eric-lee-ltk opened a new pull request #152: SCB-395 remove redudant lines
URL: https://github.com/apache/incubator-servicecomb-saga/pull/152
 
 
   Signed-off-by: Eric Lee 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-210) Use map feature to design microservice yaml file to support control flag of config center

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396700#comment-16396700
 ] 

ASF GitHub Bot commented on SCB-210:


WillemJiang closed pull request #41: [SCB-210] update document for apollo 
configuration item
URL: https://github.com/apache/incubator-servicecomb-website/pull/41
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/_users/cn/dynamic-config.md b/_users/cn/dynamic-config.md
index 719854e..8a32b34 100644
--- a/_users/cn/dynamic-config.md
+++ b/_users/cn/dynamic-config.md
@@ -24,7 +24,7 @@ redirect_from:
git clone https://github.com/lijasonvip/apollo-image-for-servicecomb.git
cd apollo-image-for-servicecomb && docker-compose up
```
-等待出现 `Portal started. You can visit http://localhost:8070 now!` 
后表示系统启动完成，可以在浏览器中访问`http://localhost:8070`进入配置中心页面。 
`docker-compose`安装请参考[文档](https://docs.docker.com/compose/install/)。
+等待出现 `Portal started. You can visit http://localhost:8070 now!` 
后表示系统启动完成（启动时间基于机器性能可能需要1-3分钟），可以在浏览器中访问`http://localhost:8070`进入配置中心页面。 
`docker-compose`安装请参考[文档](https://docs.docker.com/compose/install/)。
 
 ### 通过Apollo界面配置应用获取TOKEN
 
@@ -58,21 +58,13 @@ redirect_from:
 
 ```xml
 
-  com.netflix.archaius
-  archaius-core
-   
-
-  io.servicecomb
+  org.apache.servicecomb
   config-apollo
 
 ```
 ### 添加配置项
 
```yaml
-   cse:
- config:
-   client:
-   serverUri: http://127.0.0.1:8070
apollo:
  config:
serverUri: http://127.0.0.1:8070
@@ -83,7 +75,8 @@ redirect_from:
token: testtoken
refreshInterval: 10
```
-​  
`cse.config.client.serverUri`配置项填写Apollo配置中心portal服务地址，只是表示对接配置中心，`apollo.config`下的配置项是用户创建的应用参数，包括服务地址，用户名，集群，namespace，token等参数。这些参数可以在配置中心页面项目信息栏中查到。需要注意的是`refreshInterval:
 10`表示应用会每隔10秒去配置中心查询一次最新的配置信息，不配置此项默认刷新周期为30秒。
+​  
`apollo.config`下的配置项是用户创建的应用参数，包括服务地址，用户名，集群，namespace，token等参数。这些参数可以在配置中心页面项目信息栏中查到。需要注意的是`refreshInterval:
 10`表示应用会每隔10秒去配置中心查询一次最新的配置信息，不配置此项默认刷新周期为30秒。
+  `serviceName`对应Apollo中的第三发应用ID: `AppId`.
 
 ### 获取动态属性
 
diff --git a/_users/dynamic-config.md b/_users/dynamic-config.md
index 2d61f7e..d5a0b84 100644
--- a/_users/dynamic-config.md
+++ b/_users/dynamic-config.md
@@ -24,7 +24,7 @@ Apollo services can be easily deployed and started step by 
step following its [o
git clone https://github.com/lijasonvip/apollo-image-for-servicecomb.git
cd apollo-image-for-servicecomb && docker-compose up
```
-When your console shows `Portal started. You can visit http://localhost:8070 
now!` , it means the service is started and ready for use. Visit Apollo 
configuration pages at `http://localhost:8070` in a browser. Please refer to 
[Docker document](https://docs.docker.com/compose/install/) about 
`docker-compose`.
+When your console shows `Portal started. You can visit http://localhost:8070 
now!` , it means the service is started and ready for use(It could take serval 
minutes which depends on machines). Visit Apollo configuration pages at 
`http://localhost:8070` in a browser. Please refer to [Docker 
document](https://docs.docker.com/compose/install/) about `docker-compose`.
 
 ### Configure services and get a token
 
@@ -58,21 +58,13 @@ Visit `http://192.168.199.1:8070/open/manage.html` and fill 
in application ID an
 
 ```xml
 
-  com.netflix.archaius
-  archaius-core
-   
-
-  io.servicecomb
+  org.apache.servicecomb
   config-apollo
 
 ```
 ### Add configurations in microservice.yaml
 
```yaml
-   cse:
- config:
-   client:
-   serverUri: http://127.0.0.1:8070
apollo:
  config:
serverUri: http://127.0.0.1:8070
@@ -83,7 +75,8 @@ Visit `http://192.168.199.1:8070/open/manage.html` and fill 
in application ID an
token: testtoken
refreshInterval: 10
```
-​  Configuration `cse.config.client.serverUri` is the portal address of 
Apollo configuration center just the same as `apollo.config.serverUri`. 
Configurations under `apollo.config` are parameters of the project that users 
created above, including serviceName, env, clusters, namespace, token and 
refreshInterval. Pay attention to `refreshInterval: 10`, it means service will 
fetch latest configuration items every each 10 seconds, default refresh cycle 
is 30 second if no value is configured here.
+​  Configurations under `apollo.config` are parameters of the project that 
users created above, including serviceName, env, clusters, namespace, token and 
refreshInterval. Pay attention to `refreshInterval: 10`, it means service will 
fetch latest configuration items every each 10 seconds, default refresh cycle

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396699#comment-16396699
 ] 

ASF GitHub Bot commented on SCB-395:


WillemJiang closed pull request #151: SCB-395 add guides to build executable 
files
URL: https://github.com/apache/incubator-servicecomb-saga/pull/151
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 41903393..2074ed33 100644
--- a/README.md
+++ b/README.md
@@ -23,8 +23,7 @@ See [Saga Pack Design](docs/design.md) for details.
 See [Booking Demo](saga-demo/booking/README.md) for details.
 
 ## User Guide
-See [User Guide](docs/user_guide.md) for details.
-
+How to build and use can refer to [User Guide](docs/user_guide.md).
 
 ## FAQ
 * [How to use MySQL as alpha's backend 
database?](docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md)
diff --git a/README_ZH.md b/README_ZH.md
index 1b055926..98bf460c 100644
--- a/README_ZH.md
+++ b/README_ZH.md
@@ -23,7 +23,7 @@ Saga是由 **alpha** 和 **omega**组成，其中：
 详情可浏览[出行预订示例](saga-demo/booking/README.md)。
 
 ## 用户指南
-详情可浏览[用户指南](docs/user_guide_zh.md)。
+如何构建和使用可浏览[用户指南](docs/user_guide_zh.md)。
 
 ## 常见问题
 * 
[如何使用MySQL作为alpha的后台数据库？](docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md)
diff --git a/docs/user_guide.md b/docs/user_guide.md
index 62eadc7b..445fadc7 100644
--- a/docs/user_guide.md
+++ b/docs/user_guide.md
@@ -12,7 +12,27 @@ You will need:
 [docker]: https://www.docker.com/get-docker
 
 ## Build
-To build:
+
+Retrieve the source code:
+```bash
+$ git clone https://github.com/apache/incubator-servicecomb-saga.git
+$ cd incubator-servicecomb-saga
+```
+
+Saga can be built in either of the following ways.
+* Only build the executable files.
+   ```bash
+   $ mvn clean install -DskipTests
+   ```
+
+* build the executable files along with docker image.
+   ```bash
+   $ mvn clean install -DskipTests -Pdocker
+   ```
+
+After executing either one of the above command, you will find alpha server's 
executable file in 
`alpha/alpha-server/target/saga/alpha-server-${version}-exec.jar`.
+
+### Build executable files and docker images
 ```bash
 $ git clone https://github.com/apache/incubator-servicecomb-saga.git
 $ cd incubator-servicecomb-saga
diff --git a/docs/user_guide_zh.md b/docs/user_guide_zh.md
index befc97c7..ad1247dd 100644
--- a/docs/user_guide_zh.md
+++ b/docs/user_guide_zh.md
@@ -11,13 +11,26 @@
 [docker]: https://www.docker.com/get-docker
 
 ## 编译
-编译Saga，只需以下几步：
+
+获取源码：
 ```bash
 $ git clone https://github.com/apache/incubator-servicecomb-saga.git
 $ cd incubator-servicecomb-saga
-$ mvn clean install -DskipTests -Pdocker
 ```
 
+Saga可通过以下任一方式进行构建：
+* 只构建可执行文件：
+   ```bash
+   $ mvn clean install -DskipTests
+   ```
+
+* 同时构建可执行文件和docker镜像：
+   ```bash
+   $ mvn clean install -DskipTests -Pdocker
+   ```
+
+在执行以上任一指令后，可在`alpha/alpha-server/target/saga/alpha-server-${version}-exec.jar`中找到alpha
 server的可执行文件。
+
 ## 如何使用
 ### 引入Saga的依赖
 ```xml


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396693#comment-16396693
 ] 

ASF GitHub Bot commented on SCB-224:


eric-lee-ltk commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r174047823
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/RecoveryPolicyFactory.java
 ##
 @@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+public class RecoveryPolicyFactory {
+  private static final RecoveryPolicy defaultRecovery = new DefaultRecovery();
+
+  private static final RecoveryPolicy forwardRecovery = new ForwardRecovery();
+
+  static RecoveryPolicy getRecoveryPolicy(int retries) {
 
 Review comment:
   Which parameter is more proper?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396689#comment-16396689
 ] 

ASF GitHub Bot commented on SCB-224:


eric-lee-ltk commented on a change in pull request #138: [WIP] SCB-224 retry 
sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r174047412
 
 

 ##
 File path: 
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/DefaultRecovery.java
 ##
 @@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction;
+
+import java.lang.invoke.MethodHandles;
+import java.lang.reflect.Method;
+
+import javax.transaction.InvalidTransactionException;
+
+import org.apache.servicecomb.saga.omega.context.OmegaContext;
+import org.apache.servicecomb.saga.omega.transaction.annotations.Compensable;
+import org.aspectj.lang.ProceedingJoinPoint;
+import org.aspectj.lang.reflect.MethodSignature;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DefaultRecovery implements RecoveryPolicy {
 
 Review comment:
   Not exactly. As the compensation of backward recovery is handled 
asynchronously, this place is only used to execute bussiness logic once.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396680#comment-16396680
 ] 

ASF GitHub Bot commented on SCB-391:


asifdxtreme closed pull request #304: SCB-391 SC does not rotate log file
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/304
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scripts/release/start_scripts/linux/start-service-center.sh 
b/scripts/release/start_scripts/linux/start-service-center.sh
index 758f07ba..336bed85 100644
--- a/scripts/release/start_scripts/linux/start-service-center.sh
+++ b/scripts/release/start_scripts/linux/start-service-center.sh
@@ -15,4 +15,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+set -e
+
+root_path=$(cd "$(dirname "$0")"; pwd)
+
+cd ${root_path}
+
+sed -i "s|^runmode.*=.*$|runmode = prod|g" conf/app.conf
+
 ./service-center > start-sc.log 2>&1 &


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396673#comment-16396673
 ] 

ASF GitHub Bot commented on SCB-395:


coveralls commented on issue #151: SCB-395 add guides to build executable files
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/151#issuecomment-372581975
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15944648/badge)](https://coveralls.io/builds/15944648)
   
   Coverage increased (+0.1%) to 95.395% when pulling 
**4ad8ea187e15fbed934f3bab517797a0310c640c on eric-lee-ltk:SCB-395** into 
**dbac344f6e7a6e904dc6c0642c72c9539d4e5fe4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-395) Add How to build into README file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396667#comment-16396667
 ] 

ASF GitHub Bot commented on SCB-395:


eric-lee-ltk opened a new pull request #151: SCB-395 add guides to build 
executable files
URL: https://github.com/apache/incubator-servicecomb-saga/pull/151
 
 
   Signed-off-by: Eric Lee 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add How to build into README file
> -
>
> Key: SCB-395
> URL: https://issues.apache.org/jira/browse/SCB-395
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Eric Lee
>Priority: Minor
> Fix For: saga-0.1.0
>
>
> Current README doesn't has the section of how to build the binary from source.
> As we have some docker image need to be generated, we need to tell the user 
> about it in the README.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396651#comment-16396651
 ] 

ASF GitHub Bot commented on SCB-382:


WillemJiang closed pull request #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/demo/docker-run-config/pom.xml b/demo/docker-run-config/pom.xml
index b6586803d..52ba50f83 100644
--- a/demo/docker-run-config/pom.xml
+++ b/demo/docker-run-config/pom.xml
@@ -89,7 +89,7 @@
 8080:8080
 
 
-service-center
+service-center
 
 
 
diff --git a/integration-tests/dynamic-config-tests/pom.xml 
b/integration-tests/dynamic-config-tests/pom.xml
index 5c4f65d94..f0ab7c8fb 100644
--- a/integration-tests/dynamic-config-tests/pom.xml
+++ b/integration-tests/dynamic-config-tests/pom.xml
@@ -99,7 +99,9 @@
   apollo.config:8080
   apollo.portal:8070
 
-mysql
+
+  mysql
+
   
 
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396648#comment-16396648
 ] 

ASF GitHub Bot commented on SCB-391:


codecov-io commented on issue #304: SCB-391 SC does not rotate log file
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/304#issuecomment-372233639
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=h1)
 Report
   > Merging 
[#304](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc)
 will **decrease** coverage by `0.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304/graphs/tree.svg?height=150=650=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #304  +/-   ##
   ==
   - Coverage   70.39%   69.84%   -0.55% 
   ==
 Files  17   17  
 Lines3455 3455  
   ==
   - Hits 2432 2413  -19 
   - Misses853  872  +19 
 Partials  170  170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `54.82% <0%> (-2.96%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=footer).
 Last update 
[bfe0666...c52afc5](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/304?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-391) SC does not rotate log file

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396647#comment-16396647
 ] 

ASF GitHub Bot commented on SCB-391:


coveralls commented on issue #304: SCB-391 SC does not rotate log file
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/304#issuecomment-372233609
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15944309/badge)](https://coveralls.io/builds/15944309)
   
   Coverage decreased (-0.4%) to 73.556% when pulling 
**c52afc5598357319e34b3c50e3cf52e22ac036f2 on little-cui:SCB-391** into 
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SC does not rotate log file
> ---
>
> Key: SCB-391
> URL: https://issues.apache.org/jira/browse/SCB-391
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-397) uniform sha1sum format for release of ServiceComb

2018-03-13 Thread Eric Lee (JIRA) 
Eric Lee created SCB-397:


 Summary: uniform sha1sum format for release of ServiceComb
 Key: SCB-397
 URL: https://issues.apache.org/jira/browse/SCB-397
 Project: Apache ServiceComb
  Issue Type: Task
  Components: Service-Center
Reporter: Eric Lee


Currently, the sha1sum format of service center is in the form of A0B3 B1D2 ... 
. However, the sha1sum format of java chassis and saga is a0b3b1d2... . We 
should use the same format for the whole ServiceComb project. Perfer to use the 
second form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396638#comment-16396638
 ] 

ASF GitHub Bot commented on SCB-382:


coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372017538
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15944039/badge)](https://coveralls.io/builds/15944039)
   
   Coverage decreased (-0.02%) to 87.183% when pulling 
**c96a1447e86c09cdc5ebe406f3f89d4c8fefab68 on zhengyangyong:SCB-382** into 
**0c2e8d55f10e55174427429f58376a06be9cf5b2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-363) Remove legacy code from Saga

2018-03-13 Thread Willem Jiang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-363:
-
Fix Version/s: saga-0.1.0

> Remove legacy code from Saga
> 
>
> Key: SCB-363
> URL: https://issues.apache.org/jira/browse/SCB-363
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Saga
>Reporter: Yang Bo
>Assignee: Yang Bo
>Priority: Major
> Fix For: saga-0.1.0
>
>
> We are planning on drop suuport for the legacy version of saga and supports 
> pack mode only.
> Thus we need to remove the legacy code from master branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-396) java-sdk needs to distinguish the instance belongs to the devops stage(environment)

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396627#comment-16396627
 ] 

ASF GitHub Bot commented on SCB-396:


coveralls commented on issue #591: [SCB-396] java-sdk needs to distinguish the 
instance belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#issuecomment-372568005
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15943878/badge)](https://coveralls.io/builds/15943878)
   
   Coverage decreased (-0.02%) to 87.186% when pulling 
**537b281fc44dd1546e94223000ee6a8ebf270997 on weichao666:qufendevops** into 
**0c2e8d55f10e55174427429f58376a06be9cf5b2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java-sdk needs to distinguish the instance belongs to the devops 
> stage(environment)
> ---
>
> Key: SCB-396
> URL: https://issues.apache.org/jira/browse/SCB-396
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> sdk support registers service environment according to environment variables.
> servcie center registers the service interface, requesting the field with the 
> identification phase in the body,\{"service":{"serviceId":"xxx", 
> "environment":"production"}}.
> the name of the environment variable should be aligned with GOSDK and be 
> unified.
> the default value of this field is blank.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-387) Somefiles are lacking ASF header in Service Center

2018-03-13 Thread Yang Bo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Bo resolved SCB-387.
-
Resolution: Fixed

> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it 
> for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some 
> simple template files for code generation can have the header omitted. Other 
> files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-396) java-sdk needs to distinguish the instance belongs to the devops stage(environment)

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396612#comment-16396612
 ] 

ASF GitHub Bot commented on SCB-396:


weichao666 commented on issue #591: [SCB-396] java-sdk needs to distinguish the 
instance belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#issuecomment-372562823
 
 
   
![image](https://user-images.githubusercontent.com/30716999/37326352-c0334d28-26cc-11e8-9c34-69c523567da9.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java-sdk needs to distinguish the instance belongs to the devops 
> stage(environment)
> ---
>
> Key: SCB-396
> URL: https://issues.apache.org/jira/browse/SCB-396
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> sdk support registers service environment according to environment variables.
> servcie center registers the service interface, requesting the field with the 
> identification phase in the body,\{"service":{"serviceId":"xxx", 
> "environment":"production"}}.
> the name of the environment variable should be aligned with GOSDK and be 
> unified.
> the default value of this field is blank.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-396) java-sdk needs to distinguish the instance belongs to the devops stage(environment)

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396610#comment-16396610
 ] 

ASF GitHub Bot commented on SCB-396:


weichao666 commented on issue #591: [SCB-396] java-sdk needs to distinguish the 
instance belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#issuecomment-372561817
 
 
   sdk support registers service environment according to environment variables.
   servcie center registers the service interface, requesting the field with 
the identification phase in the body,{"service":{"serviceId":"xxx", 
"environment":"production"}}.
   the name of the environment variable should be aligned with GOSDK and be 
unified.
   the default value of this field is blank.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java-sdk needs to distinguish the instance belongs to the devops 
> stage(environment)
> ---
>
> Key: SCB-396
> URL: https://issues.apache.org/jira/browse/SCB-396
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> sdk support registers service environment according to environment variables.
> servcie center registers the service interface, requesting the field with the 
> identification phase in the body,\{"service":{"serviceId":"xxx", 
> "environment":"production"}}.
> the name of the environment variable should be aligned with GOSDK and be 
> unified.
> the default value of this field is blank.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-396) java-sdk needs to distinguish the instance belongs to the devops stage(environment)

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396609#comment-16396609
 ] 

ASF GitHub Bot commented on SCB-396:


weichao666 opened a new pull request #591: [SCB-396] java-sdk needs to 
distinguish the instance belongs to the devops stage(environment)
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/591
 
 
   …evops stage(environment)
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> java-sdk needs to distinguish the instance belongs to the devops 
> stage(environment)
> ---
>
> Key: SCB-396
> URL: https://issues.apache.org/jira/browse/SCB-396
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> sdk support registers service environment according to environment variables.
> servcie center registers the service interface, requesting the field with the 
> identification phase in the body,\{"service":{"serviceId":"xxx", 
> "environment":"production"}}.
> the name of the environment variable should be aligned with GOSDK and be 
> unified.
> the default value of this field is blank.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)