[jira] [Commented] (SCB-793) run it-consumer during travis CI
[ https://issues.apache.org/jira/browse/SCB-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574313#comment-16574313 ] ASF GitHub Bot commented on SCB-793: coveralls edited a comment on issue #864: [SCB-793] Run it-consumer during travis ci URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/864#issuecomment-411630454 [](https://coveralls.io/builds/18399592) Coverage increased (+1.4%) to 86.477% when pulling **10a0be91f3be67c17e92391087550fea9b440008 on wujimin:run-it-consumer-during-travis-ci** into **3edca801fe18fd6f93805bdf97f62aae58c99284 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run it-consumer during travis CI > - > > Key: SCB-793 > URL: https://issues.apache.org/jira/browse/SCB-793 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574299#comment-16574299
]
ASF GitHub Bot commented on SCB-736:
maheshrajus commented on a change in pull request #863: [SCB-736] generate
default value to swagger for primitive type when there is no defaultValue
annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r208807621
##
File path:
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
##
@@ -64,4 +64,28 @@ public String query3(@RequestParam("a") @Min(value = 20)
int a, @RequestParam("b
return "Hello " + a + b;
}
+ @PostMapping("/javaprimitive1")
+ public String springJavaPrim1(@RequestParam(name = "a") int a,
Review comment:
yes,you are correct when we made @RequestParam(name="a", requrired=true)
then also in swagger file it is showing required field is false. Looks to be
defect in swagger generation module about springmvc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574297#comment-16574297
]
ASF GitHub Bot commented on SCB-736:
maheshrajus commented on a change in pull request #863: [SCB-736] generate
default value to swagger for primitive type when there is no defaultValue
annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r208807437
##
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
##
@@ -315,8 +315,30 @@ protected void processByParameterAnnotation(Annotation[]
paramAnnotations, int p
}
}
}
-if (parameter instanceof AbstractSerializableParameter && defaultValue !=
null) {
- ((AbstractSerializableParameter)
parameter).setDefaultValue(defaultValue);
+if (parameter instanceof AbstractSerializableParameter) {
+ if (defaultValue != null) {
+((AbstractSerializableParameter)
parameter).setDefaultValue(defaultValue);
+ } else if AbstractSerializableParameter)
parameter).getDefaultValue() == null)
+ && (false == ((AbstractSerializableParameter)
parameter).getRequired())) { //if required false then only take java primitive
values as defaults
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-732. -- Resolution: Fixed Applied PR into master branch with thanks to Yang Bo. > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Assignee: Yang Bo >Priority: Major > Fix For: saga-0.3.0 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned SCB-732: Assignee: Yang Bo > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Assignee: Yang Bo >Priority: Major > Fix For: saga-0.3.0 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-824: - Fix Version/s: saga-0.3.0 > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Fix For: saga-0.3.0 > > > Failed to build dependency-free-transaction demo and conditional-transaction > demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-824. -- Resolution: Fixed merged the patch into master branch with thanks to Ju Zhen. > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Fix For: saga-0.3.0 > > > Failed to build dependency-free-transaction demo and conditional-transaction > demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574289#comment-16574289 ] Willem Jiang commented on SCB-824: -- This issue is caused by the docker profile is not activated when there is a docker daemon. You can workaround this issue by applying the -Pdocker profile. > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > > Failed to build dependency-free-transaction demo and conditional-transaction > demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574286#comment-16574286 ] ASF GitHub Bot commented on SCB-824: WillemJiang closed pull request #244: [SCB-824] Fix the bug that demos cannot be built: add docker plugin activation tag for demos URL: https://github.com/apache/incubator-servicecomb-saga/pull/244 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/saga-demo/conditional-transaction-demo/inventory/pom.xml b/saga-demo/conditional-transaction-demo/inventory/pom.xml index ee698ef0..12fca420 100644 --- a/saga-demo/conditional-transaction-demo/inventory/pom.xml +++ b/saga-demo/conditional-transaction-demo/inventory/pom.xml @@ -56,6 +56,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/conditional-transaction-demo/membership/pom.xml b/saga-demo/conditional-transaction-demo/membership/pom.xml index b13efc3b..52b04e83 100644 --- a/saga-demo/conditional-transaction-demo/membership/pom.xml +++ b/saga-demo/conditional-transaction-demo/membership/pom.xml @@ -57,6 +57,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/conditional-transaction-demo/payment/pom.xml b/saga-demo/conditional-transaction-demo/payment/pom.xml index 1ab36a62..21ce51f4 100644 --- a/saga-demo/conditional-transaction-demo/payment/pom.xml +++ b/saga-demo/conditional-transaction-demo/payment/pom.xml @@ -57,6 +57,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/conditional-transaction-demo/supplier/pom.xml b/saga-demo/conditional-transaction-demo/supplier/pom.xml index 99f64c5b..5220e519 100644 --- a/saga-demo/conditional-transaction-demo/supplier/pom.xml +++ b/saga-demo/conditional-transaction-demo/supplier/pom.xml @@ -57,6 +57,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/dependency-free-transaction-demo/car-rental-service/pom.xml b/saga-demo/dependency-free-transaction-demo/car-rental-service/pom.xml index d49ca868..bf026731 100644 --- a/saga-demo/dependency-free-transaction-demo/car-rental-service/pom.xml +++ b/saga-demo/dependency-free-transaction-demo/car-rental-service/pom.xml @@ -67,6 +67,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/dependency-free-transaction-demo/flight-booking-service/pom.xml b/saga-demo/dependency-free-transaction-demo/flight-booking-service/pom.xml index 781b91de..2897db87 100644 --- a/saga-demo/dependency-free-transaction-demo/flight-booking-service/pom.xml +++ b/saga-demo/dependency-free-transaction-demo/flight-booking-service/pom.xml @@ -67,6 +67,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/dependency-free-transaction-demo/hotel-reservation-service/pom.xml b/saga-demo/dependency-free-transaction-demo/hotel-reservation-service/pom.xml index 4afc6914..c17db001 100644 --- a/saga-demo/dependency-free-transaction-demo/hotel-reservation-service/pom.xml +++ b/saga-demo/dependency-free-transaction-demo/hotel-reservation-service/pom.xml @@ -67,6 +67,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/dependency-free-transaction-demo/payment-service/pom.xml b/saga-demo/dependency-free-transaction-demo/payment-service/pom.xml index 6263ab41..07cd8970 100644 --- a/saga-demo/dependency-free-transaction-demo/payment-service/pom.xml +++ b/saga-demo/dependency-free-transaction-demo/payment-service/pom.xml @@ -67,6 +67,11 @@ docker + + + /var/run/docker.sock + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >
[jira] [Commented] (SCB-825) support standalone tomcat deploy
[ https://issues.apache.org/jira/browse/SCB-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574263#comment-16574263 ] ASF GitHub Bot commented on SCB-825: coveralls commented on issue #245: [SCB-825] fix SagaStartAnnotationProcessor class bug URL: https://github.com/apache/incubator-servicecomb-saga/pull/245#issuecomment-411631181 [](https://coveralls.io/builds/18398970) Coverage increased (+0.3%) to 94.175% when pulling **3fa5a1398691c84ac2d45486b76fdc29aab8b1dd on WithLin:patch-1** into **dcf9f2a28e062baacd96f22f80f08e40b485fc51 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support standalone tomcat deploy > > > Key: SCB-825 > URL: https://issues.apache.org/jira/browse/SCB-825 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-793) run it-consumer during travis CI
[ https://issues.apache.org/jira/browse/SCB-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574257#comment-16574257 ] ASF GitHub Bot commented on SCB-793: coveralls commented on issue #864: [SCB-793] Run it-consumer during travis ci URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/864#issuecomment-411630454 [](https://coveralls.io/builds/18398937) Coverage increased (+1.4%) to 86.472% when pulling **8c6b9fe5680d164ed5115e85193cab8f0af8edd2 on wujimin:run-it-consumer-during-travis-ci** into **3edca801fe18fd6f93805bdf97f62aae58c99284 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run it-consumer during travis CI > - > > Key: SCB-793 > URL: https://issues.apache.org/jira/browse/SCB-793 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-812) Change the readme under the frontend folder
[ https://issues.apache.org/jira/browse/SCB-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574254#comment-16574254 ] ASF GitHub Bot commented on SCB-812: asifdxtreme commented on a change in pull request #410: [SCB-812]Change the readme under the frontend folder URL: https://github.com/apache/incubator-servicecomb-service-center/pull/410#discussion_r208800704 ## File path: frontend/Readme.md ## @@ -39,7 +39,9 @@ bower install cd .. -go run main.go +go build + +./frontend.exe Review comment: @little-cui @xiaoyimei I suggest to put this command in a start.sh/start.bat script and handle the building and running frontend in that and give this command of running the script in Readme This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change the readme under the frontend folder > --- > > Key: SCB-812 > URL: https://issues.apache.org/jira/browse/SCB-812 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: xiaoyimei >Assignee: xiaoyimei >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-789) complete 8 index page of catalog
[ https://issues.apache.org/jira/browse/SCB-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lidian resolved SCB-789. Resolution: Done https://github.com/apache/incubator-servicecomb-docs/pull/24 > complete 8 index page of catalog > > > Key: SCB-789 > URL: https://issues.apache.org/jira/browse/SCB-789 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: website >Affects Versions: java-chassis-1.0.0-m2 >Reporter: lidian >Assignee: lidian >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-791) website integrate travis-ci make auto update
[ https://issues.apache.org/jira/browse/SCB-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lidian resolved SCB-791. Resolution: Done https://github.com/apache/incubator-servicecomb-docs/pull/26 > website integrate travis-ci make auto update > > > Key: SCB-791 > URL: https://issues.apache.org/jira/browse/SCB-791 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: website >Affects Versions: java-chassis-1.0.0-m2 >Reporter: lidian >Assignee: lidian >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-791) website integrate travis-ci make auto update
[ https://issues.apache.org/jira/browse/SCB-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574249#comment-16574249 ] lidian commented on SCB-791: https://github.com/apache/incubator-servicecomb-docs/pull/26 > website integrate travis-ci make auto update > > > Key: SCB-791 > URL: https://issues.apache.org/jira/browse/SCB-791 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: website >Affects Versions: java-chassis-1.0.0-m2 >Reporter: lidian >Assignee: lidian >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-825) support standalone tomcat deploy
[ https://issues.apache.org/jira/browse/SCB-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574247#comment-16574247 ] ASF GitHub Bot commented on SCB-825: WithLin opened a new pull request #245: [SCB-825] fix SagaStartAnnotationProcessor class bug URL: https://github.com/apache/incubator-servicecomb-saga/pull/245 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support standalone tomcat deploy > > > Key: SCB-825 > URL: https://issues.apache.org/jira/browse/SCB-825 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-825) support standalone tomcat deploy
wujimin created SCB-825: --- Summary: support standalone tomcat deploy Key: SCB-825 URL: https://issues.apache.org/jira/browse/SCB-825 Project: Apache ServiceComb Issue Type: Sub-task Components: Java-Chassis Reporter: wujimin Assignee: wujimin Fix For: java-chassis-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-793) run it-consumer during travis CI
[ https://issues.apache.org/jira/browse/SCB-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574233#comment-16574233 ] ASF GitHub Bot commented on SCB-793: wujimin opened a new pull request #864: [SCB-793] Run it-consumer during travis ci URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/864 try use SC by priority: 1.reuse existing SC 2.run SC by env "serviceCenterHome" 3.run SC by docker after move all old test case to this mechanism, no need to create microservice docker image during integration test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run it-consumer during travis CI > - > > Key: SCB-793 > URL: https://issues.apache.org/jira/browse/SCB-793 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574184#comment-16574184 ] ASF GitHub Bot commented on SCB-824: coveralls commented on issue #244: [SCB-824] Fix the bug that demos cannot be built: add docker plugin activation tag for demos URL: https://github.com/apache/incubator-servicecomb-saga/pull/244#issuecomment-411612836 [](https://coveralls.io/builds/18397981) Coverage increased (+0.4%) to 94.297% when pulling **787f00690aa05fcb682af008a1913a5e3c4c622c on crystaldust:fix/docker-plugin-activation** into **dcf9f2a28e062baacd96f22f80f08e40b485fc51 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > > Failed to build dependency-free-transaction demo and conditional-transaction > demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574180#comment-16574180
]
ASF GitHub Bot commented on SCB-736:
liubao68 commented on a change in pull request #863: [SCB-736] generate default
value to swagger for primitive type when there is no defaultValue annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r208785710
##
File path:
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
##
@@ -64,4 +64,28 @@ public String query3(@RequestParam("a") @Min(value = 20)
int a, @RequestParam("b
return "Hello " + a + b;
}
+ @PostMapping("/javaprimitive1")
+ public String springJavaPrim1(@RequestParam(name = "a") int a,
Review comment:
From this demo and I made some tests, It seems for SpringMVC, there is a
bug.
For @RequestParam and other annotations, they got a required attribute, and
default value is true. It seems that when generating swagger, we do not
consider this attribute and it is always false. Event we write
@RequestParam(name="a", requrired=true). Can you check that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-824) Failed to build saga demos
[ https://issues.apache.org/jira/browse/SCB-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574177#comment-16574177 ] ASF GitHub Bot commented on SCB-824: crystaldust opened a new pull request #244: [SCB-824] Fix the bug that demos cannot be built: add docker plugin activation tag for demos URL: https://github.com/apache/incubator-servicecomb-saga/pull/244 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - **The demos cannot be built since the essential docker images are not built without docker plugin activation being specified** - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). - **Not a large PR** --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Failed to build saga demos > -- > > Key: SCB-824 > URL: https://issues.apache.org/jira/browse/SCB-824 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > > Failed to build dependency-free-transaction demo and conditional-transaction > demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-824) Failed to build saga demos
ZhenJu created SCB-824: -- Summary: Failed to build saga demos Key: SCB-824 URL: https://issues.apache.org/jira/browse/SCB-824 Project: Apache ServiceComb Issue Type: Bug Components: Saga Reporter: ZhenJu Assignee: ZhenJu Failed to build dependency-free-transaction demo and conditional-transaction demo, mvn clean install complains "Cannot find xxx docker image" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574173#comment-16574173
]
ASF GitHub Bot commented on SCB-736:
liubao68 commented on a change in pull request #863: [SCB-736] generate default
value to swagger for primitive type when there is no defaultValue annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r208784307
##
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
##
@@ -315,8 +315,30 @@ protected void processByParameterAnnotation(Annotation[]
paramAnnotations, int p
}
}
}
-if (parameter instanceof AbstractSerializableParameter && defaultValue !=
null) {
- ((AbstractSerializableParameter)
parameter).setDefaultValue(defaultValue);
+if (parameter instanceof AbstractSerializableParameter) {
+ if (defaultValue != null) {
+((AbstractSerializableParameter)
parameter).setDefaultValue(defaultValue);
+ } else if AbstractSerializableParameter)
parameter).getDefaultValue() == null)
+ && (false == ((AbstractSerializableParameter)
parameter).getRequired())) { //if required false then only take java primitive
values as defaults
Review comment:
use !
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-690) when producer invocation prepare to run in executor, make sure not disconnect/ not time out
[
https://issues.apache.org/jira/browse/SCB-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574170#comment-16574170
]
ASF GitHub Bot commented on SCB-690:
liubao68 commented on a change in pull request #862: [SCB-690] add check if
connection is still connected before execute invocation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/862#discussion_r208783189
##
File path:
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##
@@ -95,17 +99,21 @@ public void start(Future startFuture) throws
Exception {
HttpServer httpServer = createHttpServer();
httpServer.requestHandler(mainRouter::accept);
httpServer.connectionHandler(connection -> {
+String address = connection.remoteAddress().toString();
Review comment:
How about client established multi connections to this server?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when producer invocation prepare to run in executor, make sure not
> disconnect/ not time out
> ---
>
> Key: SCB-690
> URL: https://issues.apache.org/jira/browse/SCB-690
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
> vertx rest and highway not control producer timeout
>
> note: if already running, then could do nothing, just let it go till finished.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574158#comment-16574158
]
ASF GitHub Bot commented on SCB-612:
liubao68 commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r208780448
##
File path:
core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
##
@@ -74,12 +71,22 @@ public void notifySchemaListener(List
schemaMetaList) {
}
public SchemaMeta ensureFindSchemaMeta(String microserviceName, String
schemaId) {
-MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
+ LOGGER.error("miroserviceName : {} is different from the default
microserviceName :{}",
Review comment:
This is an internally used class, will this logic happen? Or can we delete
the parameter microserviceName?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete useless MicroserviceMetaManager
> --
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574159#comment-16574159
]
ASF GitHub Bot commented on SCB-612:
liubao68 commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r208780532
##
File path:
core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
##
@@ -74,12 +71,22 @@ public void notifySchemaListener(List
schemaMetaList) {
}
public SchemaMeta ensureFindSchemaMeta(String microserviceName, String
schemaId) {
-MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
+ LOGGER.error("miroserviceName : {} is different from the default
microserviceName :{}",
+ microserviceName,
+ RegistryUtils.getMicroservice().getServiceName());
+}
+MicroserviceMeta microserviceMeta =
SCBEngine.getInstance().getProducerMicroMeta();
return microserviceMeta.ensureFindSchemaMeta(schemaId);
}
public Collection getAllSchemaMeta(String microserviceName) {
-MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
Review comment:
same as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete useless MicroserviceMetaManager
> --
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-800) Param order generated by BeanParamAnnotationProcessor is not stable
[
https://issues.apache.org/jira/browse/SCB-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574088#comment-16574088
]
ASF GitHub Bot commented on SCB-800:
liubao68 closed pull request #855: [SCB-800] params in BeanParam is generated
by declared field order
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/855
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamPojoClient.java
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamPojoClient.java
index fe15bda36..cf70f8e40 100644
---
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamPojoClient.java
+++
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamPojoClient.java
@@ -24,7 +24,7 @@
import org.apache.servicecomb.provider.pojo.Invoker;
public class BeanParamPojoClient {
- BeanParamTestServiceIntf beanParamTestServiceIntf;
+ private BeanParamTestServiceIntf beanParamTestServiceIntf;
public BeanParamPojoClient() {
beanParamTestServiceIntf = Invoker.createProxy("jaxrs", "beanParamTest",
BeanParamTestServiceIntf.class);
@@ -35,15 +35,15 @@ public void testAll() {
testUpload();
}
- public void testBeanParam() {
-String result =
beanParamTestServiceIntf.beanParameterTest("querySwaggerValue", 10, 2,
"pathSwaggerValue", "extra");
+ private void testBeanParam() {
+String result =
beanParamTestServiceIntf.beanParameterTest("querySwaggerValue", 2,
"pathSwaggerValue", 10, "extra");
TestMgr.check(
"invocationContextConsistency=true|testBeanParameter=TestBeanParameter{queryStr='querySwaggerValue',
headerInt=2, "
+ "pathStr='pathSwaggerValue', cookieLong=10}|extraQuery=extra",
result);
}
- public void testUpload() {
+ private void testUpload() {
BufferedInputStream bufferedInputStream0 = new BufferedInputStream(new
ByteArrayInputStream("up0".getBytes()));
BufferedInputStream bufferedInputStream1 = new BufferedInputStream(new
ByteArrayInputStream("up1".getBytes()));
BufferedInputStream bufferedInputStream2 = new BufferedInputStream(new
ByteArrayInputStream("up2".getBytes()));
diff --git
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamTestServiceIntf.java
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamTestServiceIntf.java
index 1d8c602e4..4149adc66 100644
---
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamTestServiceIntf.java
+++
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/beanParam/BeanParamTestServiceIntf.java
@@ -20,8 +20,8 @@
import java.io.InputStream;
public interface BeanParamTestServiceIntf {
- String beanParameterTest(String querySwaggerStr, long cookieSwaggerLong,
Integer headerSwaggerInt,
- String pathSwaggerStr, String extraQuery);
+ String beanParameterTest(String querySwaggerStr, Integer headerSwaggerInt,
String pathSwaggerStr,
+ long cookieSwaggerLong, String extraQuery);
String beanParameterTestUpload(InputStream up0, String query, InputStream
up1, InputStream up2, String extraQuery);
}
diff --git
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/beanParam/TestBeanParameter.java
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/beanParam/TestBeanParameter.java
index 9e8c319be..489b29c56 100644
---
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/beanParam/TestBeanParameter.java
+++
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/beanParam/TestBeanParameter.java
@@ -23,6 +23,8 @@
import javax.ws.rs.PathParam;
import javax.ws.rs.QueryParam;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+
public class TestBeanParameter {
@DefaultValue("defaultQueryValue")
@QueryParam("querySwaggerStr")
@@ -35,13 +37,15 @@
@CookieParam("cookieSwaggerLong")
private long cookieLong;
+ @JsonIgnore
+ private String ignoredField;
+
public String getQueryStr() {
return queryStr;
}
- public TestBeanParameter setQueryStr(String queryStr) {
+ public void setQueryStr(String queryStr) {
this.queryStr = queryStr;
-return this;
}
public Integer getHeaderInt() {
@@ -50,9 +54,8 @@ public Integer getHeaderInt() {
@DefaultValue("12")
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[
https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574086#comment-16574086
]
ASF GitHub Bot commented on SCB-782:
liubao68 closed pull request #851: [SCB-782]support revision check when use
pull mode with config center
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
index a58de4da2..09d26c484 100644
---
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
+++
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
@@ -128,14 +128,14 @@ public void connectServer() {
LOGGER.error("refreshMode must be 0 or 1.");
return;
}
-ParseConfigUtils parseConfigUtils = new ParseConfigUtils(updateHandler);
+ParseConfigUtils.getInstance().initWithUpdateHandler(updateHandler);
try {
deployConfigClient();
} catch (InterruptedException e) {
throw new IllegalStateException(e);
}
refreshMembers(memberDiscovery);
-ConfigRefresh refreshTask = new ConfigRefresh(parseConfigUtils,
memberDiscovery);
+ConfigRefresh refreshTask = new
ConfigRefresh(ParseConfigUtils.getInstance(), memberDiscovery);
refreshTask.run(true);
executor.scheduleWithFixedDelay(refreshTask,
firstRefreshInterval,
@@ -160,13 +160,14 @@ private void refreshMembers(MemberDiscovery
memberDiscovery) {
String configCenter = memberDiscovery.getConfigServer();
IpPort ipPort = NetUtils.parseIpPortFromURI(configCenter);
clientMgr.findThreadBindClientPool().runOnContext(client -> {
-HttpClientRequest request = client.get(ipPort.getPort(),
ipPort.getHostOrIp(), uriConst.MEMBERS, rsp -> {
- if (rsp.statusCode() == HttpResponseStatus.OK.code()) {
-rsp.bodyHandler(buf -> {
- memberDiscovery.refreshMembers(buf.toJsonObject());
+HttpClientRequest request =
+client.get(ipPort.getPort(), ipPort.getHostOrIp(),
uriConst.MEMBERS, rsp -> {
+ if (rsp.statusCode() == HttpResponseStatus.OK.code()) {
+rsp.bodyHandler(buf -> {
+ memberDiscovery.refreshMembers(buf.toJsonObject());
+});
+ }
});
- }
-});
SignRequest signReq = createSignRequest(request.method().toString(),
configCenter + uriConst.MEMBERS,
new HashMap<>(),
@@ -174,7 +175,8 @@ private void refreshMembers(MemberDiscovery
memberDiscovery) {
if (ConfigCenterConfig.INSTANCE.getToken() != null) {
request.headers().add("X-Auth-Token",
ConfigCenterConfig.INSTANCE.getToken());
}
-authHeaderProviders.forEach(provider ->
request.headers().addAll(provider.getSignAuthHeaders(signReq)));
+authHeaderProviders.forEach(provider -> request.headers()
+.addAll(provider.getSignAuthHeaders(signReq)));
request.exceptionHandler(e -> {
LOGGER.error("Fetch member from {} failed. Error message is [{}].",
configCenter, e.getMessage());
});
@@ -235,14 +237,15 @@ private HttpClientOptions createHttpClientOptions() {
}
public void run(boolean wait) {
- // this will be single threaded, so we don't care about concurrent
- // staffs
try {
String configCenter = memberdis.getConfigServer();
if (refreshMode == 1) {
- refreshConfig(configCenter, wait);
+ //make sure that revision is updated timely,wait sub thread to
finish it's pull task
+ refreshConfig(configCenter, true);
} else if (!isWatching) {
// 重新监听时需要先加载，避免在断开期间丢失变更
+ //we do not need worry about that the revision may not be updated
timely, because we do not need
+ //revision info in the push mode. the config-center will push the
changing to us
refreshConfig(configCenter, wait);
doWatch(configCenter);
}
@@ -302,6 +305,7 @@ public void doWatch(String configCenter)
LOGGER.info("watching config recieved {}", action);
Map mAction = action.toJsonObject().getMap();
if ("CREATE".equals(mAction.get("action"))) {
+ //event loop can not be blocked,we just keep nothing changed
in push mode
refreshConfig(configCenter, false);
} else if
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573428#comment-16573428
]
ASF GitHub Bot commented on SCB-736:
coveralls commented on issue #863: [SCB-736] generate default value to swagger
for primitive type when there is no defaultValue annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#issuecomment-411460582
[](https://coveralls.io/builds/18387365)
Coverage decreased (-0.04%) to 85.159% when pulling
**e0cde75e738a6df88b058eee74f7025e57131c94 on maheshrajus:master** into
**7abb7b12636fc9040a18778246260b9f438e4bdb on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573362#comment-16573362
]
ASF GitHub Bot commented on SCB-736:
maheshrajus opened a new pull request #863: [SCB-736] generate default value to
swagger for primitive type when there is no defaultValue annotation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/863
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-793) run it-consumer during travis CI
[ https://issues.apache.org/jira/browse/SCB-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-793: Summary: run it-consumer during travis CI (was: run it-consumer with docker during travis CI ) > run it-consumer during travis CI > - > > Key: SCB-793 > URL: https://issues.apache.org/jira/browse/SCB-793 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573238#comment-16573238 ] ASF GitHub Bot commented on SCB-823: coveralls commented on issue #243: [SCB-823] Setup the test in kubernetes URL: https://github.com/apache/incubator-servicecomb-saga/pull/243#issuecomment-411409444 [](https://coveralls.io/builds/18384456) Coverage increased (+0.3%) to 94.175% when pulling **6dabb804a48efe3ca057eebb92f674031c576511 on crystaldust:feature/kubernetes-demo** into **dcf9f2a28e062baacd96f22f80f08e40b485fc51 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-815) Support deploy in Kubernetes
[
https://issues.apache.org/jira/browse/SCB-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573146#comment-16573146
]
ASF GitHub Bot commented on SCB-815:
asifdxtreme closed pull request #411: SCB-815 Support deploy in Kubernetes
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/411
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/README.md b/docs/README.md
index 5a9f8aa1..eb144af0 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -14,9 +14,15 @@
- [Making Front-end Image](/scripts/docker/build-frontend-image)
- Deploy Service-Center
+ Deploy Service-Center Locally
-- [Cluster Deployment](/docs/sc-cluster.md)
+- [In Docker](/integration/docker)
+
+ Deploy Service-Center Cluster
+
+- [In Kubernetes Cluster](/integration/k8s)
+
+- [In VM](/docs/sc-cluster.md)
- [Deploy with TLS](/docs/security-tls.md)
diff --git a/integration/docker/README.md b/integration/docker/README.md
new file mode 100644
index ..c55d1b1c
--- /dev/null
+++ b/integration/docker/README.md
@@ -0,0 +1,20 @@
+# Integrate with Docker
+
+A simple demo to deploy ServiceCenter in docker environment.
+
+## Quick Start
+
+```bash
+cd $PROJECT_ROOT/integration/docker
+docker-compose up
+```
+This will start up ServiceCenter listening on `:30100` for handling requests
and Dashboard listening on `:30103`.
+
+## Confirm ServiceCenter is Running
+
+You can also point your browser to `http://${NODE}:30103` to view the
dashboard of ServiceCenter.
+
+## Next
+
+ServiceCenter already integrate with Prometheus,
+you can get more metrics of ServiceCenter in Grafana,
[see](/docs/integration-grafana.md)
\ No newline at end of file
diff --git a/integration/docker/docker-compose.yml
b/integration/docker/docker-compose.yml
new file mode 100644
index ..6fd50b74
--- /dev/null
+++ b/integration/docker/docker-compose.yml
@@ -0,0 +1,53 @@
+version: '3'
+services:
+ prometheus:
+depends_on:
+ - service-center
+image: 'prom/prometheus:latest'
+# restart: always
+volumes:
+ - ./prometheus.yml:/etc/prometheus/prometheus.yml
+ports:
+ - "9090:9090"
+
+ grafana:
+depends_on:
+ - prometheus
+image: 'grafana/grafana:latest'
+# restart: always
+ports:
+ - "3000:3000"
+volumes:
+ - grafana_data:/var/lib/grafana
+
+ etcd:
+image: 'quay.io/coreos/etcd:latest'
+# restart: always
+environment:
+ ETCD_ADVERTISE_CLIENT_URLS: http://etcd:2379
+ ETCD_LISTEN_CLIENT_URLS: http://0.0.0.0:2379
+ ETCD_INITIAL_ADVERTISE_PEER_URLS: http://etcd:2380
+ ETCD_LISTEN_PEER_URLS: http://0.0.0.0:2380
+ ETCD_INITIAL_CLUSTER: default=http://etcd:2380
+
+ service-center:
+depends_on:
+ - etcd
+image: 'servicecomb/service-center:latest'
+# restart: always
+ports:
+ - "30100:30100"
+environment:
+ BACKEND_ADDRESS: etcd:2379
+
+ scfrontend:
+depends_on:
+ - service-center
+image: 'servicecomb/scfrontend:latest'
+# restart: always
+ports:
+ - "30103:30103"
+environment:
+ BACKEND_ADDRESS: http://service-center:30100
+volumes:
+ grafana_data:
diff --git a/integration/docker/prometheus.yml
b/integration/docker/prometheus.yml
new file mode 100644
index ..514df3b8
--- /dev/null
+++ b/integration/docker/prometheus.yml
@@ -0,0 +1,33 @@
+# my global config
+global:
+ scrape_interval: 15s # Set the scrape interval to every 15 seconds.
Default is every 1 minute.
+ evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is
every 1 minute.
+ # scrape_timeout is set to the global default (10s).
+
+# Alertmanager configuration
+alerting:
+ alertmanagers:
+ - static_configs:
+- targets:
+ # - alertmanager:9093
+
+# Load rules once and periodically evaluate them according to the global
'evaluation_interval'.
+rule_files:
+ # - "first_rules.yml"
+ # - "second_rules.yml"
+
+# A scrape configuration containing exactly one endpoint to scrape:
+# Here it's Prometheus itself.
+scrape_configs:
+ # The job name is added as a label `job=` to any timeseries
scraped from this config.
+ - job_name: 'prometheus'
+
+# metrics_path defaults to '/metrics'
+# scheme defaults to 'http'.
+
+static_configs:
+ - targets: ['prometheus:9090']
+
+ - job_name: 'service-center'
+static_configs:
+ - targets: ['service-center:30100']
diff --git a/integration/integrationtest_suite_test.go
b/integration/integrationtest_suite_test.go
index adad6665..ae25b96d 100644
--- a/integration/integrationtest_suite_test.go
+++ b/integration/integrationtest_suite_test.go
@@ -21,15 +21,10 @@ import (
[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573143#comment-16573143
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #412: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration/integrationtest_suite_test.go
b/integration/integrationtest_suite_test.go
index adad6665..ae25b96d 100644
--- a/integration/integrationtest_suite_test.go
+++ b/integration/integrationtest_suite_test.go
@@ -21,15 +21,10 @@ import (
"github.com/onsi/ginkgo/reporters"
. "github.com/onsi/gomega"
"net/http"
+ "os"
"testing"
)
-func TestIntegration(t *testing.T) {
- RegisterFailHandler(Fail)
- junitReporter := reporters.NewJUnitReporter("model.junit.xml")
- RunSpecsWithDefaultAndCustomReporters(t, "Integration Test for SC",
[]Reporter{junitReporter})
-}
-
var scclient *http.Client
var insecurityConnection = {}
@@ -39,3 +34,16 @@ var SCURL = "http://127.0.0.1:30100;
var _ = BeforeSuite(func() {
scclient = insecurityConnection
})
+
+func init() {
+ addr, ok := os.LookupEnv("CSE_REGISTRY_ADDRESS")
+ if ok {
+ SCURL = addr
+ }
+}
+
+func TestIntegration(t *testing.T) {
+ RegisterFailHandler(Fail)
+ junitReporter := reporters.NewJUnitReporter("model.junit.xml")
+ RunSpecsWithDefaultAndCustomReporters(t, "Integration Test for SC",
[]Reporter{junitReporter})
+}
diff --git a/server/metric/calculator.go b/server/metric/calculator.go
index 8b163c6d..99fac216 100644
--- a/server/metric/calculator.go
+++ b/server/metric/calculator.go
@@ -18,17 +18,14 @@ package metric
import (
dto "github.com/prometheus/client_model/go"
- "strings"
)
var (
- calculators = make(map[string]Calculator)
- DefaultCalculator = {}
+ DefaultCalculator Calculator = {}
)
type Calculator interface {
Calc(mf *dto.MetricFamily) float64
- ReShape()
}
type CommonCalculator struct {
@@ -52,9 +49,6 @@ func (c *CommonCalculator) Calc(mf *dto.MetricFamily) float64
{
}
}
-func (c *CommonCalculator) ReShape() {
-}
-
func metricCounterOf(m []*dto.Metric) float64 {
var sum float64 = 0
for _, d := range m {
@@ -80,19 +74,10 @@ func metricSummaryOf(m []*dto.Metric) float64 {
return sum / float64(count)
}
-func RegisterCalculator(family string, c Calculator) {
- calculators[family] = c
+func RegisterCalculator(c Calculator) {
+ DefaultCalculator = c
}
func Calculate(mf *dto.MetricFamily) float64 {
- if c, ok := calculators[strings.TrimPrefix(mf.GetName(),
familyNamePrefix)]; ok {
- return c.Calc(mf)
- }
return DefaultCalculator.Calc(mf)
}
-
-func ReShape() {
- for _, c := range calculators {
- c.ReShape()
- }
-}
diff --git a/server/metric/calculator_test.go b/server/metric/calculator_test.go
new file mode 100644
index ..50bc42b3
--- /dev/null
+++ b/server/metric/calculator_test.go
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package metric
+
+import (
+ dto "github.com/prometheus/client_model/go"
+ "testing"
+)
+
+func TestCommonCalculator_Calc(t *testing.T) {
+ c := {}
+
+ mf := {}
+ mt := dto.MetricType_UNTYPED
+ v := float64(0)
+ n := uint64(0)
+
+ if c.Calc(mf) != 0 {
+ t.Fatalf("TestCommonCalculator_Calc failed")
+ }
+
+ mf = {Type: , Metric: []*dto.Metric{{}}}
+ if c.Calc(mf) != 0 {
+ t.Fatalf("TestCommonCalculator_Calc failed")
+ }
+
+ mt = dto.MetricType_GAUGE
+ v = 1
+ mf = {Type: , Metric: []*dto.Metric{
+ {Gauge: {Value: }}, {Gauge: {Value:
+ if
[jira] [Commented] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572972#comment-16572972 ] ASF GitHub Bot commented on SCB-823: crystaldust commented on issue #243: [SCB-823] Setup the test in kubernetes URL: https://github.com/apache/incubator-servicecomb-saga/pull/243#issuecomment-411354060 Further works: - [ ] Pull images from a public registry - [ ] Add a tooling service to run tests and collect the results - [ ] Simulate different scenarios with Istio, like network delay, undetected server error - [ ] More advanced test reports This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572973#comment-16572973 ] ASF GitHub Bot commented on SCB-823: crystaldust edited a comment on issue #243: [SCB-823] Setup the test in kubernetes URL: https://github.com/apache/incubator-servicecomb-saga/pull/243#issuecomment-411354060 Further works: - [x] Pull images from a public registry - [ ] Add a tooling service to run tests and collect the results - [ ] Simulate different scenarios with Istio, like network delay, undetected server error - [ ] More advanced test reports This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572974#comment-16572974 ] ASF GitHub Bot commented on SCB-823: crystaldust edited a comment on issue #243: [SCB-823] Setup the test in kubernetes URL: https://github.com/apache/incubator-servicecomb-saga/pull/243#issuecomment-411354060 Further works: - [ ] Pull images from a public registry - [ ] Add a tooling service to run tests and collect the results - [ ] Simulate different scenarios with Istio, like network delay, undetected server error - [ ] More advanced test reports This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572968#comment-16572968 ] ASF GitHub Bot commented on SCB-823: crystaldust opened a new pull request #243: [SCB-823] Setup the test in kubernetes URL: https://github.com/apache/incubator-servicecomb-saga/pull/243 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - **The JIRA issue if created: [SCB-823](https://issues.apache.org/jira/browse/SCB-823)** - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - **The PR adds the minimal resources to run the demo under a kubernetes environment. With kubernetes and service mesh solutions like [Istio](https://istio.io), it would be much easier to test saga in different size distributed systems and multiple real life senarios like: unstable networking, undetected logic errors etc.** - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - **The test is done even though the PR doesn't make any code change** - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). - **This is not a large contribution.** --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-798) GrpcMessageSender uses aync send API
[ https://issues.apache.org/jira/browse/SCB-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572966#comment-16572966 ] Willem Jiang commented on SCB-798: -- We need to make sure there is a timeout mechanism for the async invocation. > GrpcMessageSender uses aync send API > > > Key: SCB-798 > URL: https://issues.apache.org/jira/browse/SCB-798 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Assignee: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > We could leverage aync sending API to increase the performance Pack system. > Omega need to support the transaction status lookup incase the message is not > sent rightly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenJu updated SCB-823: --- Summary: Set up a fully functional test in kubernetes environment (was: Set up a fully functional test environment in kubernetes) > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test environment running the demos > in containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-823) Set up a fully functional test in kubernetes environment
[ https://issues.apache.org/jira/browse/SCB-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenJu updated SCB-823: --- Description: It would be great if we have a kubernetes test solution running the demos in containers. With the environment, it's easier to: * Scale up / down the services to test saga in different size distributed systems * Simulate the scenarios that different forms of errors would occur, like unavailable connection, internal server error, or network delay. This could be easily done by Istio was: It would be great if we have a kubernetes test environment running the demos in containers. With the environment, it's easier to: * Scale up / down the services to test saga in different size distributed systems * Simulate the scenarios that different forms of errors would occur, like unavailable connection, internal server error, or network delay. This could be easily done by Istio > Set up a fully functional test in kubernetes environment > > > Key: SCB-823 > URL: https://issues.apache.org/jira/browse/SCB-823 > Project: Apache ServiceComb > Issue Type: Test > Components: Saga >Reporter: ZhenJu >Assignee: ZhenJu >Priority: Minor > Labels: kubernetes, test > > It would be great if we have a kubernetes test solution running the demos in > containers. > With the environment, it's easier to: > * Scale up / down the services to test saga in different size distributed > systems > * Simulate the scenarios that different forms of errors would occur, like > unavailable connection, internal server error, or network delay. This could > be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-823) Set up a fully functional test environment in kubernetes
ZhenJu created SCB-823: -- Summary: Set up a fully functional test environment in kubernetes Key: SCB-823 URL: https://issues.apache.org/jira/browse/SCB-823 Project: Apache ServiceComb Issue Type: Test Components: Saga Reporter: ZhenJu Assignee: ZhenJu It would be great if we have a kubernetes test environment running the demos in containers. With the environment, it's easier to: * Scale up / down the services to test saga in different size distributed systems * Simulate the scenarios that different forms of errors would occur, like unavailable connection, internal server error, or network delay. This could be easily done by Istio -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[ https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572936#comment-16572936 ] ASF GitHub Bot commented on SCB-612: coveralls edited a comment on issue #861: [SCB-612]delete useless MicroserviceMetaManager URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#issuecomment-411266453 [](https://coveralls.io/builds/18380948) Coverage decreased (-0.06%) to 85.146% when pulling **00d8cae9246621a36fb33198de8fd402a7654744 on heyile:cse-612** into **7abb7b12636fc9040a18778246260b9f438e4bdb on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > delete useless MicroserviceMetaManager > -- > > Key: SCB-612 > URL: https://issues.apache.org/jira/browse/SCB-612 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Priority: Major > Labels: newbie > > in previous versions, consumer and producer microserviceMeta all managed by > MicroserviceMetaManager > > currently: > all consumer MicroserviceMeta managed by AppManager > only producer MicroserviceMeta remains in MicroserviceMetaManager, there is > only one MicroserviceMeta instance, so MicroserviceMetaManager is useless > just move producer MicroserviceMeta to SCBEngine is enough -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-812) Change the readme under the frontend folder
[ https://issues.apache.org/jira/browse/SCB-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572894#comment-16572894 ] ASF GitHub Bot commented on SCB-812: little-cui commented on a change in pull request #410: [SCB-812]Change the readme under the frontend folder URL: https://github.com/apache/incubator-servicecomb-service-center/pull/410#discussion_r208503908 ## File path: frontend/Readme.md ## @@ -39,7 +39,9 @@ bower install cd .. -go run main.go +go build + +./frontend.exe Review comment: @yangbor i do not mean to run go 'run' command with multi-files, i think create a new package 'server' and move the server.go into it would be a better solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change the readme under the frontend folder > --- > > Key: SCB-812 > URL: https://issues.apache.org/jira/browse/SCB-812 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: xiaoyimei >Assignee: xiaoyimei >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
