[jira] [Commented] (TS-4113) Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies

2016-01-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095372#comment-15095372
 ] 

ASF subversion and git services commented on TS-4113:
-

Commit 48c23ec742f173e79793597cedea3ac970807cff in trafficserver's branch 
refs/heads/master from [~hnakamur]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=48c23ec ]

TS-4113: add value 4 to proxy.config.http.cache.cache_responses_to_cookies

This closes #411.


> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> ---
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Docs, Documentation
>Reporter: Hiroaki Nakamura
>Assignee: Jon Sime
> Fix For: 6.2.0, Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //   # cache responses to cookies has 4 options
>   //   #
>   //   #  0 - do not cache any responses to cookies
>   //   #  1 - cache for any content-type (ignore cookies)
>   //   #  2 - cache only for image types
>   //   #  3 - cache for all but text content-types
>   //   #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4113) Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies

2016-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095373#comment-15095373
 ] 

ASF GitHub Bot commented on TS-4113:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/411


> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> ---
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Docs, Documentation
>Reporter: Hiroaki Nakamura
>Assignee: Jon Sime
> Fix For: 6.2.0, Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //   # cache responses to cookies has 4 options
>   //   #
>   //   #  0 - do not cache any responses to cookies
>   //   #  1 - cache for any content-type (ignore cookies)
>   //   #  2 - cache only for image types
>   //   #  3 - cache for all but text content-types
>   //   #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4113) Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies

2016-01-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091382#comment-15091382
 ] 

ASF GitHub Bot commented on TS-4113:


GitHub user hnakamur opened a pull request:

https://github.com/apache/trafficserver/pull/411

Doc: [TS-4113] Add value 4 to proxy.config.http.cache.cache_responses…

Please refer to https://issues.apache.org/jira/browse/TS-4113

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hnakamur/trafficserver 
add_value_4_for_proxy_config_http_cache_cache_responses_to_cookies

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #411


commit 8fc24ab19f9a26d6b672b41c7c400c6d5ccfba2b
Author: Hiroaki Nakamura 
Date:   2016-01-11T03:32:36Z

Doc: [TS-4113] Add value 4 to 
proxy.config.http.cache.cache_responses_to_cookies




> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> ---
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Docs, Documentation
>Reporter: Hiroaki Nakamura
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //   # cache responses to cookies has 4 options
>   //   #
>   //   #  0 - do not cache any responses to cookies
>   //   #  1 - cache for any content-type (ignore cookies)
>   //   #  2 - cache only for image types
>   //   #  3 - cache for all but text content-types
>   //   #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4113) Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies

2016-01-10 Thread Hiroaki Nakamura (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091383#comment-15091383
 ] 

Hiroaki Nakamura commented on TS-4113:
--

I made a pull request: https://github.com/apache/trafficserver/pull/411
Could you review this?
Thanks!

> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> ---
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Docs, Documentation
>Reporter: Hiroaki Nakamura
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //   # cache responses to cookies has 4 options
>   //   #
>   //   #  0 - do not cache any responses to cookies
>   //   #  1 - cache for any content-type (ignore cookies)
>   //   #  2 - cache only for image types
>   //   #  3 - cache for all but text content-types
>   //   #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4113) Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies

2016-01-10 Thread Leif Hedstrom (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091271#comment-15091271
 ] 

Leif Hedstrom commented on TS-4113:
---

Are you making a PR for this? If not, maybe Jon can look at this.

> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> ---
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Docs, Documentation
>Reporter: Hiroaki Nakamura
> Fix For: Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //   # cache responses to cookies has 4 options
>   //   #
>   //   #  0 - do not cache any responses to cookies
>   //   #  1 - cache for any content-type (ignore cookies)
>   //   #  2 - cache only for image types
>   //   #  3 - cache for all but text content-types
>   //   #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)