[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=30211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30211
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 06/Oct/16 00:04
Start Date: 06/Oct/16 00:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/831/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30211)
Time Spent: 1h 40m  (was: 1.5h)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=30210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30210
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 06/Oct/16 00:00
Start Date: 06/Oct/16 00:00
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/939/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30210)
Time Spent: 1.5h  (was: 1h 20m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=30209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30209
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 23:47
Start Date: 05/Oct/16 23:47
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 30209)
Time Spent: 1h 20m  (was: 1h 10m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29981=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29981
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 22:21
Start Date: 29/Sep/16 22:21
Worklog Time Spent: 10m 
  Work Description: Github user calavera commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1062#discussion_r81247196
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
 
   if (closed) {
 // Safe to initiate SSN_CLOSE if this is the last stream
-if (cross_thread_event)
-  cross_thread_event->cancel();
 // Schedule the destroy to occur after we unwind here.  IF we call 
directly, may delete with reference on the stack.
--- End diff --

If do_io_close set the event again, would it make sense to check if the 
even is cancelled rather than removing this code? In our tests, this doesn't 
happen, but I'm not familiar with the code to be sure it never happens.


Issue Time Tracking
---

Worklog Id: (was: 29981)
Time Spent: 1h 10m  (was: 1h)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29980=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29980
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 22:18
Start Date: 29/Sep/16 22:18
Worklog Time Spent: 10m 
  Work Description: Github user calavera commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1062#discussion_r81246655
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
 
   if (closed) {
 // Safe to initiate SSN_CLOSE if this is the last stream
-if (cross_thread_event)
-  cross_thread_event->cancel();
 // Schedule the destroy to occur after we unwind here.  IF we call 
directly, may delete with reference on the stack.
--- End diff --

Sorry, I agree that the title and description is misleading, I meant to say 
cancelling, not closing. Modifying title and description to be more correct.


Issue Time Tracking
---

Worklog Id: (was: 29980)
Time Spent: 1h  (was: 50m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29975=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29975
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 22:08
Start Date: 29/Sep/16 22:08
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1062#discussion_r81245130
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
 
   if (closed) {
 // Safe to initiate SSN_CLOSE if this is the last stream
-if (cross_thread_event)
-  cross_thread_event->cancel();
 // Schedule the destroy to occur after we unwind here.  IF we call 
directly, may delete with reference on the stack.
--- End diff --

This seems like a reasonable cleanup unless the earlier do_io_close could 
cause the cross_thread_event to be set again.  NULLing out cross_thread_event 
earlier and adding an assert here would be reasonable.

However this fix doesn't seem to match the title.  Canceling the event is 
not going to cause the close to happen twice.


Issue Time Tracking
---

Worklog Id: (was: 29975)
Time Spent: 50m  (was: 40m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29961
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 06:44
Start Date: 29/Sep/16 06:44
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/796/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 29961)
Time Spent: 40m  (was: 0.5h)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29960=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29960
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 06:40
Start Date: 29/Sep/16 06:40
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/901/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 29960)
Time Spent: 0.5h  (was: 20m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29959
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 06:27
Start Date: 29/Sep/16 06:27
Worklog Time Spent: 10m 
  Work Description: Github user masaori335 commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 29959)
Time Spent: 20m  (was: 10m)

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: David Calavera
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4908) HTTP2Stream tries to close a continuation twice when a transaction is done

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29944
 ]

ASF GitHub Bot logged work on TS-4908:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 00:57
Start Date: 29/Sep/16 00:57
Worklog Time Spent: 10m 
  Work Description: GitHub user calavera opened a pull request:

https://github.com/apache/trafficserver/pull/1062

[TS-4908] Remove duplicated closing continuation.

The HTTP2Stream is closing the continuation twice when the transaction
is done. In debug mode, this causes a core dump because it tries to
close a closed continuation.

Signed-off-by: David Calavera 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/calavera/trafficserver 
remove_duplicated_closing_continuation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1062.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1062


commit c3819984943bd956f54e8f3dad5372f1c4035c47
Author: David Calavera 
Date:   2016-09-29T00:52:43Z

[TS-4908] Remove duplicated closing continuation.

The HTTP2Stream is closing the continuation twice when the transaction
is done. In debug mode, this causes a core dump because it tries to
close a closed continuation.

Signed-off-by: David Calavera 




Issue Time Tracking
---

Worklog Id: (was: 29944)
Time Spent: 10m
Remaining Estimate: 0h

> HTTP2Stream tries to close a continuation twice when a transaction is done
> --
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: David Calavera
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request 
> coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)