[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34102=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34102 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:46 Start Date: 22/Dec/16 23:46 Worklog Time Spent: 10m Work Description: Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1273 Issue Time Tracking --- Worklog Id: (was: 34102) Time Spent: 4h (was: 3h 50m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 4h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34101=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34101 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:33 Start Date: 22/Dec/16 23:33 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1273 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1174/ for details. Issue Time Tracking --- Worklog Id: (was: 34101) Time Spent: 3h 50m (was: 3h 40m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34100 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:30 Start Date: 22/Dec/16 23:30 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1273 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1279/ for details. Issue Time Tracking --- Worklog Id: (was: 34100) Time Spent: 3h 40m (was: 3.5h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34099 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:18 Start Date: 22/Dec/16 23:18 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1273 Try again [approve ci] Issue Time Tracking --- Worklog Id: (was: 34099) Time Spent: 3.5h (was: 3h 20m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34098 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:09 Start Date: 22/Dec/16 23:09 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1273 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1173/ for details. Issue Time Tracking --- Worklog Id: (was: 34098) Time Spent: 3h 20m (was: 3h 10m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34097 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 23:08 Start Date: 22/Dec/16 23:08 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1273 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1278/ for details. Issue Time Tracking --- Worklog Id: (was: 34097) Time Spent: 3h 10m (was: 3h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34095 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 22:54 Start Date: 22/Dec/16 22:54 Worklog Time Spent: 10m Work Description: Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1273 [approve ci] Issue Time Tracking --- Worklog Id: (was: 34095) Time Spent: 3h (was: 2h 50m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 3h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34094 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 22:52 Start Date: 22/Dec/16 22:52 Worklog Time Spent: 10m Work Description: GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1273 TS-5030: Fixes the sizeof issues, adds a constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5030 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1273 commit da82bf79765d4a6eab4cd6b8f11a1e4e03c35447 Author: Leif HedstromDate: 2016-12-22T22:50:44Z TS-5030: Fixes the sizeof issues, adds a constant Issue Time Tracking --- Worklog Id: (was: 34094) Time Spent: 2h 50m (was: 2h 40m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34082 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 19:27 Start Date: 22/Dec/16 19:27 Worklog Time Spent: 10m Work Description: Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1184 Issue Time Tracking --- Worklog Id: (was: 34082) Time Spent: 2h 40m (was: 2.5h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 2h 40m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34081 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 19:27 Start Date: 22/Dec/16 19:27 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 I'm gonna merge this, and fix the clang-format separately. Please make an effort to always run clang-format though :). Issue Time Tracking --- Worklog Id: (was: 34081) Time Spent: 2.5h (was: 2h 20m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 2.5h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34074 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 17:49 Start Date: 22/Dec/16 17:49 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 This needs to run clang-format again. Please rebase and push the PR again, and I'll land it. Issue Time Tracking --- Worklog Id: (was: 34074) Time Spent: 2h 20m (was: 2h 10m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 2h 20m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34072 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 17:36 Start Date: 22/Dec/16 17:36 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1184 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1277/ for details. Issue Time Tracking --- Worklog Id: (was: 34072) Time Spent: 2h 10m (was: 2h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 2h 10m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34071=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34071 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 17:36 Start Date: 22/Dec/16 17:36 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1184 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1172/ for details. Issue Time Tracking --- Worklog Id: (was: 34071) Time Spent: 2h (was: 1h 50m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 2h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=34069=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34069 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 22/Dec/16 17:25 Start Date: 22/Dec/16 17:25 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 [approve ci] Issue Time Tracking --- Worklog Id: (was: 34069) Time Spent: 1h 50m (was: 1h 40m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1h 50m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=32360=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32360 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 23/Nov/16 16:43 Start Date: 23/Nov/16 16:43 Worklog Time Spent: 10m Work Description: Github user calavera commented on the issue: https://github.com/apache/trafficserver/pull/1184 I've made the changes suggested by @zwoop and rebased to have one single commit. Issue Time Tracking --- Worklog Id: (was: 32360) Time Spent: 1h 40m (was: 1.5h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1h 40m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=32003=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32003 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 13/Nov/16 01:59 Start Date: 13/Nov/16 01:59 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 I'm still not convinced this is a particularly useful API, but it's also fairly benign. However, I do feel that if we are going to do this, we should make the prototype something like: ```C TSStatusCode TSClientRequestUuidGet(TSHttpTxn txnp, char* destination) ``` or something with a fixed size array, like ```C TSStatusCode TSClientRequestUuidGet(TSHttpTxn txnp, char destination[MAX_SIZE_OF_THIS_BAD_BOY) ``` Where the caller is in charge of allocating enough storage for "destination". This allows it to in most cases be statically allocated (on the stack). Also, the patch as it is is not right, you can't return a pointer into the arena, after you released it. But that's a moot point if we change the signature as the above. Issue Time Tracking --- Worklog Id: (was: 32003) Time Spent: 1.5h (was: 1h 20m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1.5h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=32002=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32002 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 13/Nov/16 01:46 Start Date: 13/Nov/16 01:46 Worklog Time Spent: 10m Work Description: Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1184#discussion_r87703828 --- Diff: proxy/InkAPI.cc --- @@ -22,6 +22,7 @@ */ #include +#include --- End diff -- This is not needed anymore. Issue Time Tracking --- Worklog Id: (was: 32002) Time Spent: 1h 20m (was: 1h 10m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1h 20m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31877=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31877 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 09/Nov/16 16:32 Start Date: 09/Nov/16 16:32 Worklog Time Spent: 10m Work Description: Github user calavera commented on the issue: https://github.com/apache/trafficserver/pull/1184 I made some changes to not use the TS API internally and use the arena for memory allocation. I'd really appreciate another review. I tagged the issue in Jira with `TS API`, should I add any other tags? Issue Time Tracking --- Worklog Id: (was: 31877) Time Spent: 1h 10m (was: 1h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1h 10m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31750=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31750 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 07/Nov/16 23:16 Start Date: 07/Nov/16 23:16 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 Set the tags to the right please :). Issue Time Tracking --- Worklog Id: (was: 31750) Time Spent: 1h (was: 50m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 1h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31612 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 04/Nov/16 04:42 Start Date: 04/Nov/16 04:42 Worklog Time Spent: 10m Work Description: Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1184 @calavera [here](https://github.com/apache/trafficserver/blob/master/proxy/InkAPI.cc#L5743) is an arena example. Issue Time Tracking --- Worklog Id: (was: 31612) Time Spent: 50m (was: 40m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 50m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31572=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31572 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 03/Nov/16 23:05 Start Date: 03/Nov/16 23:05 Worklog Time Spent: 10m Work Description: Github user calavera commented on the issue: https://github.com/apache/trafficserver/pull/1184 1) > There are APIs to get the two components that you are asking for, all you are doing is doing the string concatenation? That doesn't seem worth an entirely new API to me. The problem is that ATS defines how to concatenate those values inside the log format. If you want to keep logs and plugins consistent, you need to look at the code to see how the log generates the client request id. From an administrator point of view, I don't care how that value in my log is generated, I do care about having the same consistent value across logs, server and plugins. From a developer point of view, the only way to keep that consistency is to replicate what ATS' log is doing. The only way to do that is by looking at the code. This breaks the purpose of having a well defined api. 2) Assuming we want this, you definitely should not use the TS APIs in the InkAPI.cc implementation of the new API. You should use the same underlying APIs that are provided by the core implementation of the UUID and HttpSM respectively. I can make the changes accordingly. Issue Time Tracking --- Worklog Id: (was: 31572) Time Spent: 40m (was: 0.5h) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 40m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31553 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 03/Nov/16 18:21 Start Date: 03/Nov/16 18:21 Worklog Time Spent: 10m Work Description: Github user calavera commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1184#discussion_r86410973 --- Diff: proxy/InkAPI.cc --- @@ -9212,6 +9213,19 @@ TSUuidStringGet(const TSUuid uuid) return nullptr; } +const char * +TSClientRequestUuidGet(TSHttpTxn txnp) +{ + TSUuid process = TSProcessUuidGet(); + if (process) { +std::ostringstream oss; +oss << TSUuidStringGet(process) << '-' << TSHttpTxnIdGet(txnp); +return oss.str().c_str(); --- End diff -- @bryancall agreed, maybe I should not use ostringstream at all to avoid that all together. @jpeach care to elaborate? I'm not completely sure what you mean with that. Issue Time Tracking --- Worklog Id: (was: 31553) Time Spent: 0.5h (was: 20m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 0.5h > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31552 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 03/Nov/16 18:13 Start Date: 03/Nov/16 18:13 Worklog Time Spent: 10m Work Description: Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1184#discussion_r86408908 --- Diff: proxy/InkAPI.cc --- @@ -9212,6 +9213,19 @@ TSUuidStringGet(const TSUuid uuid) return nullptr; } +const char * +TSClientRequestUuidGet(TSHttpTxn txnp) +{ + TSUuid process = TSProcessUuidGet(); + if (process) { +std::ostringstream oss; +oss << TSUuidStringGet(process) << '-' << TSHttpTxnIdGet(txnp); +return oss.str().c_str(); --- End diff -- You are retuning a pointer of the data inside of a locally scoped variable. I would suggest doing a ats_malloc() since you know the size of the string and a memcpy() of the values. Callers will need to call TSfree to free the memory. Issue Time Tracking --- Worklog Id: (was: 31552) Time Spent: 20m (was: 10m) > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 20m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-5030) Proposal: Add API to get the client request UUID directly from a TSHttpTx
[ https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=31534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31534 ] ASF GitHub Bot logged work on TS-5030: -- Author: ASF GitHub Bot Created on: 03/Nov/16 15:16 Start Date: 03/Nov/16 15:16 Worklog Time Spent: 10m Work Description: GitHub user calavera opened a pull request: https://github.com/apache/trafficserver/pull/1184 TS-5030: Add API to get the unique client request uuid from a transaction. The new UUID api introduced in https://github.com/apache/trafficserver/pull/736 is great for tracing operations and requests. However, the most useful information for plugin developers, the unique client request id, is not exposed as an api endpoint. People need to understand very well how TrafficServer works internally to generate this value. By not having the API directly exposed, people need to repeat the same code every time they want to generate this unique identifier. I'd like to add an API enpoint to generate this identifier based in a given http transaction for plugins to use. This is be the signature: ``` tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); ``` Signed-off-by: David CalaveraYou can merge this pull request into a Git repository by running: $ git pull https://github.com/calavera/trafficserver client_request_uuid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1184 commit 4b1a284784c93888c4d426065d9a578cd201fbd4 Author: David Calavera Date: 2016-11-03T15:04:42Z TS-5030: Add API to get the unique client request uuid from a transaction. Signed-off-by: David Calavera Issue Time Tracking --- Worklog Id: (was: 31534) Time Spent: 10m Remaining Estimate: 0h > Proposal: Add API to get the client request UUID directly from a TSHttpTx > - > > Key: TS-5030 > URL: https://issues.apache.org/jira/browse/TS-5030 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: David Calavera > Time Spent: 10m > Remaining Estimate: 0h > > The new UUID api introduced in > https://github.com/apache/trafficserver/pull/736 is great for tracing > operations and requests. However, the most useful information for plugin > developers, the unique client request id, is not exposed as an api endpoint. > People need to understand very well how TrafficServer works internally to > generate this value. By not having the API directly exposed, people need to > repeat the same code every time they want to generate this unique identifier. > I'd like to add an API enpoint to generate this identifier based in a given > http transaction for plugins to use. > This would be the signature: > tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp); -- This message was sent by Atlassian JIRA (v6.3.4#6332)