[jira] [Updated] (JDO-840) Fix changes links on JDO news site
[ https://issues.apache.org/jira/browse/JDO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-840: - Fix Version/s: (was: JDO 3.2.2) > Fix changes links on JDO news site > -- > > Key: JDO-840 > URL: https://issues.apache.org/jira/browse/JDO-840 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > The current JDO site lists the JDO release on the start page. For each > release there is a link to the Jira version listing all the changes for the > particular release. For the releases older than JDO 3.2 you must be logged in > into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 > this is not necessary. > * Change the link for the older release such that it is not necessary to be > logged into Jira to see the list. > * Releases older than 3.2 may not be downloaded anymore, so th etext "You > can download the release from ..." is misleading and shoudl be skipped. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JDO-840) Fix changes links on JDO news site
[ https://issues.apache.org/jira/browse/JDO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen closed JDO-840. > Fix changes links on JDO news site > -- > > Key: JDO-840 > URL: https://issues.apache.org/jira/browse/JDO-840 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > The current JDO site lists the JDO release on the start page. For each > release there is a link to the Jira version listing all the changes for the > particular release. For the releases older than JDO 3.2 you must be logged in > into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 > this is not necessary. > * Change the link for the older release such that it is not necessary to be > logged into Jira to see the list. > * Releases older than 3.2 may not be downloaded anymore, so th etext "You > can download the release from ..." is misleading and shoudl be skipped. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-840) Fix changes links on JDO news site
[ https://issues.apache.org/jira/browse/JDO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-840. -- Resolution: Fixed > Fix changes links on JDO news site > -- > > Key: JDO-840 > URL: https://issues.apache.org/jira/browse/JDO-840 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2 > > > The current JDO site lists the JDO release on the start page. For each > release there is a link to the Jira version listing all the changes for the > particular release. For the releases older than JDO 3.2 you must be logged in > into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 > this is not necessary. > * Change the link for the older release such that it is not necessary to be > logged into Jira to see the list. > * Releases older than 3.2 may not be downloaded anymore, so th etext "You > can download the release from ..." is misleading and shoudl be skipped. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-840) Fix changes links on JDO news site
Michael Bouschen created JDO-840: Summary: Fix changes links on JDO news site Key: JDO-840 URL: https://issues.apache.org/jira/browse/JDO-840 Project: JDO Issue Type: Improvement Components: site and infrastructure Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The current JDO site lists the JDO release on the start page. For each release there is a link to the Jira version listing all the changes for the particular release. For the releases older than JDO 3.2 you must be logged in into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 this is not necessary. * Change the link for the older release such that it is not necessary to be logged into Jira to see the list. * Releases older than 3.2 may not be downloaded anymore, so th etext "You can download the release from ..." is misleading and shoudl be skipped. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-840) Fix changes links on JDO news site
[ https://issues.apache.org/jira/browse/JDO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-840: Assignee: Michael Bouschen > Fix changes links on JDO news site > -- > > Key: JDO-840 > URL: https://issues.apache.org/jira/browse/JDO-840 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > The current JDO site lists the JDO release on the start page. For each > release there is a link to the Jira version listing all the changes for the > particular release. For the releases older than JDO 3.2 you must be logged in > into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 > this is not necessary. > * Change the link for the older release such that it is not necessary to be > logged into Jira to see the list. > * Releases older than 3.2 may not be downloaded anymore, so th etext "You > can download the release from ..." is misleading and shoudl be skipped. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-840) Fix changes links on JDO news site
[ https://issues.apache.org/jira/browse/JDO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-840: - Fix Version/s: JDO 3.2.2 > Fix changes links on JDO news site > -- > > Key: JDO-840 > URL: https://issues.apache.org/jira/browse/JDO-840 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2 > > > The current JDO site lists the JDO release on the start page. For each > release there is a link to the Jira version listing all the changes for the > particular release. For the releases older than JDO 3.2 you must be logged in > into Jira to see the list of changes. For the releases JDO 3.2.1 and JDO 3.2 > this is not necessary. > * Change the link for the older release such that it is not necessary to be > logged into Jira to see the list. > * Releases older than 3.2 may not be downloaded anymore, so th etext "You > can download the release from ..." is misleading and shoudl be skipped. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-836) TCK: QueryCancel Test class fails
[ https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823326#comment-17823326 ] Michael Bouschen commented on JDO-836: -- New branch JDO-836: * Added cancel.conf configuration file * Added log Statements in QueryCancel TCK class * Disabled second test method in QueryCancel to avaoid parallel threads > TCK: QueryCancel Test class fails > - > > Key: JDO-836 > URL: https://issues.apache.org/jira/browse/JDO-836 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Attachments: cancel.conf > > > The TCK test class QueryCancel fails. It is not part of any test > configuration so it is never executed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (JDO-836) TCK: QueryCancel Test class fails
[
https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820861#comment-17820861
]
Michael Bouschen edited comment on JDO-836 at 2/27/24 7:20 PM:
---
I added some log statements to check that query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to tck/src/main/resources/conf {{and}}
call mvn -Djdo.tck.cfglist=cancel.conf clean install in the tck subdirectory.
was (Author: mbo):
I added some log statements to check that query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to tck/src/main/resources/conf {{and}}
call mvn -Djdo.tck.cfglist=cancel.conf clean install
> TCK: QueryCancel Test class fails
> -
>
> Key: JDO-836
> URL: https://issues.apache.org/jira/browse/JDO-836
> Project: JDO
> Issue Type: Task
> Components: tck
>Affects Versions: JDO 3.2.1
>Reporter: Michael Bouschen
>Priority: Major
> Attachments: cancel.conf
>
>
> The TCK test class QueryCancel fails. It is not part of any test
> configuration so it is never executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (JDO-836) TCK: QueryCancel Test class fails
[
https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820861#comment-17820861
]
Michael Bouschen edited comment on JDO-836 at 2/27/24 7:19 PM:
---
I added some log statements to check that query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to tck/src/main/resources/conf {{and}}
call mvn -Djdo.tck.cfglist=cancel.conf clean install
was (Author: mbo):
I added some lof statement to check that query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to tck/src/main/resources/conf {{and}}
call mvn -Djdo.tck.cfglist=cancel.conf clean install
> TCK: QueryCancel Test class fails
> -
>
> Key: JDO-836
> URL: https://issues.apache.org/jira/browse/JDO-836
> Project: JDO
> Issue Type: Task
> Components: tck
>Affects Versions: JDO 3.2.1
>Reporter: Michael Bouschen
>Priority: Major
> Attachments: cancel.conf
>
>
> The TCK test class QueryCancel fails. It is not part of any test
> configuration so it is never executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (JDO-836) TCK: QueryCancel Test class fails
[
https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820861#comment-17820861
]
Michael Bouschen edited comment on JDO-836 at 2/27/24 7:18 PM:
---
I added some lof statement to check that query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to tck/src/main/resources/conf {{and}}
call mvn -Djdo.tck.cfglist=cancel.conf clean install
was (Author: mbo):
I added some lof statement to check thta query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to {{tck/src/main/resources/conf }}and call {{mvn
-Djdo.tck.cfglist=cancel.conf clean install}}
> TCK: QueryCancel Test class fails
> -
>
> Key: JDO-836
> URL: https://issues.apache.org/jira/browse/JDO-836
> Project: JDO
> Issue Type: Task
> Components: tck
>Affects Versions: JDO 3.2.1
>Reporter: Michael Bouschen
>Priority: Major
> Attachments: cancel.conf
>
>
> The TCK test class QueryCancel fails. It is not part of any test
> configuration so it is never executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (JDO-838) Clarify doc for query cancel()/cancelAll()
[ https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke resolved JDO-838. - Resolution: Fixed > Clarify doc for query cancel()/cancelAll() > -- > > Key: JDO-838 > URL: https://issues.apache.org/jira/browse/JDO-838 > Project: JDO > Issue Type: Improvement > Components: api, specification >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > The documentation (javadoc + spec) should be updated to clarify what the > argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-838) Clarify doc for query cancel()/cancelAll()
[ https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke reassigned JDO-838: --- Assignee: Tilmann Zäschke > Clarify doc for query cancel()/cancelAll() > -- > > Key: JDO-838 > URL: https://issues.apache.org/jira/browse/JDO-838 > Project: JDO > Issue Type: Improvement > Components: api, specification >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > The documentation (javadoc + spec) should be updated to clarify what the > argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-836) TCK: QueryCancel Test class fails
[
https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820861#comment-17820861
]
Michael Bouschen commented on JDO-836:
--
I added some lof statement to check thta query cancel is called after
query.execute has been called:
22:14:11,040 (Query Executor) INFO [org.apache.jdo.tck] - Start query execute
1708809251037
22:14:12,038 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - Start
query cancel 1708809252038
22:14:12,039 (ForkJoinPool-1-worker-19) INFO [org.apache.jdo.tck] - End query
cancel 1708809252039
22:15:00,860 (Query Executor) INFO [org.apache.jdo.tck] - End query execute
1708809300860
22:15:00,861 (Query Executor) INFO [org.apache.jdo.tck] - query execute took
49823ms
You can use the attched configuration cancel.conf to run the QueryCancel TCK
test.
Copy the file cancel.conf to {{tck/src/main/resources/conf }}and call {{mvn
-Djdo.tck.cfglist=cancel.conf clean install}}
> TCK: QueryCancel Test class fails
> -
>
> Key: JDO-836
> URL: https://issues.apache.org/jira/browse/JDO-836
> Project: JDO
> Issue Type: Task
> Components: tck
>Affects Versions: JDO 3.2.1
>Reporter: Michael Bouschen
>Priority: Major
> Attachments: cancel.conf
>
>
> The TCK test class QueryCancel fails. It is not part of any test
> configuration so it is never executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JDO-836) TCK: QueryCancel Test class fails
[ https://issues.apache.org/jira/browse/JDO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-836: - Attachment: cancel.conf > TCK: QueryCancel Test class fails > - > > Key: JDO-836 > URL: https://issues.apache.org/jira/browse/JDO-836 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Attachments: cancel.conf > > > The TCK test class QueryCancel fails. It is not part of any test > configuration so it is never executed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-831) tck: improve tck tests for performance
[ https://issues.apache.org/jira/browse/JDO-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-831. -- Resolution: Fixed TCK query test cases have been optimzed. > tck: improve tck tests for performance > -- > > Key: JDO-831 > URL: https://issues.apache.org/jira/browse/JDO-831 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The performance of the tck test suite might be improved by using: > * multi-threading > * parallel execution of tests that do not change the database > * setup/teardown optimization for tests that do not change the database -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-838) Clarify doc for query cancel()/cancelAll()
[ https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820392#comment-17820392 ] Eric Zoerner commented on JDO-838: -- I would change "that run in the specified thread" to "that are running in the specified thread". Otherwise, looks good to me – but I'm not actually a contributor so can't comment on your PR or approve it. > Clarify doc for query cancel()/cancelAll() > -- > > Key: JDO-838 > URL: https://issues.apache.org/jira/browse/JDO-838 > Project: JDO > Issue Type: Improvement > Components: api, specification >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > The documentation (javadoc + spec) should be updated to clarify what the > argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-838) Clarify doc for query cancel()/cancelAll()
[ https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818970#comment-17818970 ] Tilmann Zäschke commented on JDO-838: - I added a change for cancel(Thread). Could you have a look? > Clarify doc for query cancel()/cancelAll() > -- > > Key: JDO-838 > URL: https://issues.apache.org/jira/browse/JDO-838 > Project: JDO > Issue Type: Improvement > Components: api, specification >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > The documentation (javadoc + spec) should be updated to clarify what the > argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-839) Lock at XML parser factory settings
[ https://issues.apache.org/jira/browse/JDO-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke resolved JDO-839. - Resolution: Fixed > Lock at XML parser factory settings > --- > > Key: JDO-839 > URL: https://issues.apache.org/jira/browse/JDO-839 > Project: JDO > Issue Type: Bug > Components: api >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > Automatic code scanning reported the following problem: > https://github.com/apache/db-jdo/security/code-scanning/1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-838) Clarify doc for query cancel()/cancelAll()
[
https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818206#comment-17818206
]
Eric Zoerner commented on JDO-838:
--
The current javadoc for cancelAll() does sound like it cancels _all_ queries,
not just executions for this instance of Query. The spec is not any clearer
than the javadocs.
It looks like the reference implementation (datanucleus) only cancels
executions of _this_ {_}query{_}, both for cancelAll() and cancel(Thread). So I
agree with your change to the javadocs. There also should probably be a
clarification in cancel(Thread)
> Clarify doc for query cancel()/cancelAll()
> --
>
> Key: JDO-838
> URL: https://issues.apache.org/jira/browse/JDO-838
> Project: JDO
> Issue Type: Improvement
> Components: api, specification
>Affects Versions: JDO 3.2, JDO 3.2.1
>Reporter: Tilmann Zäschke
>Priority: Major
> Fix For: JDO 3.2.2
>
>
> The documentation (javadoc + spec) should be updated to clarify what the
> argument of cancel() is and what cancelAll() does.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (JDO-838) Clarify doc for query cancel()/cancelAll()
[ https://issues.apache.org/jira/browse/JDO-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818195#comment-17818195 ] Tilmann Zäschke commented on JDO-838: - After some consideration, I actually propose to *not* change the javadoc, it now seems quite clear to me. What do others think? I still created the PR, see link [here|https://github.com/apache/db-jdo/pull/92] > Clarify doc for query cancel()/cancelAll() > -- > > Key: JDO-838 > URL: https://issues.apache.org/jira/browse/JDO-838 > Project: JDO > Issue Type: Improvement > Components: api, specification >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > The documentation (javadoc + spec) should be updated to clarify what the > argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-839) Lock at XML parser factory settings
Tilmann Zäschke created JDO-839: --- Summary: Lock at XML parser factory settings Key: JDO-839 URL: https://issues.apache.org/jira/browse/JDO-839 Project: JDO Issue Type: Bug Components: api Affects Versions: JDO 3.2.1, JDO 3.2 Reporter: Tilmann Zäschke Assignee: Tilmann Zäschke Fix For: JDO 3.2.2 Automatic code scanning reported the following problem: https://github.com/apache/db-jdo/security/code-scanning/1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-838) Clarify doc for query cancel()/cancelAll()
Tilmann Zäschke created JDO-838: --- Summary: Clarify doc for query cancel()/cancelAll() Key: JDO-838 URL: https://issues.apache.org/jira/browse/JDO-838 Project: JDO Issue Type: Improvement Components: api, specification Affects Versions: JDO 3.2.1, JDO 3.2 Reporter: Tilmann Zäschke Fix For: JDO 3.2.2 The documentation (javadoc + spec) should be updated to clarify what the argument of cancel() is and what cancelAll() does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-837) TCK: add a JDO flag to enable/disable parallel execution
[ https://issues.apache.org/jira/browse/JDO-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809131#comment-17809131 ] Michael Bouschen commented on JDO-837: -- The flag jdo.tck.parallel.execution ist added to the branch JDO-831 > TCK: add a JDO flag to enable/disable parallel execution > > > Key: JDO-837 > URL: https://issues.apache.org/jira/browse/JDO-837 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > Add a flag to RunTCK to enable/disable parallel execution of the test methods > in TCK test classes: > jdo.tck.parallel.execution=false|true default true > The flag is used to set the flag junit.jupiter.execution.parallel.enabled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-837) TCK: add a JDO flag to enable/disable parallel execution
Michael Bouschen created JDO-837: Summary: TCK: add a JDO flag to enable/disable parallel execution Key: JDO-837 URL: https://issues.apache.org/jira/browse/JDO-837 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen Add a flag to RunTCK to enable/disable parallel execution of the test methods in TCK test classes: jdo.tck.parallel.execution=false|true default true The flag is used to set the flag junit.jupiter.execution.parallel.enabled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-837) TCK: add a JDO flag to enable/disable parallel execution
[ https://issues.apache.org/jira/browse/JDO-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-837: Assignee: Michael Bouschen > TCK: add a JDO flag to enable/disable parallel execution > > > Key: JDO-837 > URL: https://issues.apache.org/jira/browse/JDO-837 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > Add a flag to RunTCK to enable/disable parallel execution of the test methods > in TCK test classes: > jdo.tck.parallel.execution=false|true default true > The flag is used to set the flag junit.jupiter.execution.parallel.enabled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-836) TCK: QueryCancel Test class fails
Michael Bouschen created JDO-836: Summary: TCK: QueryCancel Test class fails Key: JDO-836 URL: https://issues.apache.org/jira/browse/JDO-836 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The TCK test class QueryCancel fails. It is not part of any test configuration so it is never executed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-835) TCK: Check ResultClassRequirementsMap when running multithreaded
Michael Bouschen created JDO-835: Summary: TCK: Check ResultClassRequirementsMap when running multithreaded Key: JDO-835 URL: https://issues.apache.org/jira/browse/JDO-835 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The test cases of ResultClassRequirementsMap return wrong results when running multithreaded, see source code for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-830) tck: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-830. -- Resolution: Fixed > tck: Migrate JUnit tests to version 5 > - > > Key: JDO-830 > URL: https://issues.apache.org/jira/browse/JDO-830 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The tck tests in the tck subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * [https://www.baeldung.com/junit-5-migration] > * > [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-834) Consider moving files instead of copying
[ https://issues.apache.org/jira/browse/JDO-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke resolved JDO-834. - Resolution: Fixed > Consider moving files instead of copying > > > Key: JDO-834 > URL: https://issues.apache.org/jira/browse/JDO-834 > Project: JDO > Issue Type: Improvement > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Minor > Fix For: JDO 3.3 > > > The RunTck class copies log and configuration files. Look into moving them > instead of copying. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-834) Consider moving files instead of copying
[ https://issues.apache.org/jira/browse/JDO-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke updated JDO-834: Priority: Minor (was: Major) > Consider moving files instead of copying > > > Key: JDO-834 > URL: https://issues.apache.org/jira/browse/JDO-834 > Project: JDO > Issue Type: Improvement > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Minor > Fix For: JDO 3.3 > > > The RunTck class copies log and configuration files. Look into moving them > instead of copying. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-830) tck: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-830: - Fix Version/s: (was: JDO 3.2.2) > tck: Migrate JUnit tests to version 5 > - > > Key: JDO-830 > URL: https://issues.apache.org/jira/browse/JDO-830 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The tck tests in the tck subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * [https://www.baeldung.com/junit-5-migration] > * > [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-834) Consider moving files instead of copying
Tilmann Zäschke created JDO-834: --- Summary: Consider moving files instead of copying Key: JDO-834 URL: https://issues.apache.org/jira/browse/JDO-834 Project: JDO Issue Type: Improvement Components: tck Affects Versions: JDO 3.2.1 Reporter: Tilmann Zäschke Assignee: Tilmann Zäschke Fix For: JDO 3.3 The RunTck class copies log and configuration files. Look into moving them instead of copying. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780029#comment-17780029 ] Andy Jefferson edited comment on JDO-822 at 11/1/23 7:58 AM: - FYI, DataNucleus v6.0.6 has latest ASM (v9.6), so supports up to and including Java 22. Plugins needed for TCK are (minimum) datanucleus-core 6.0.6, datanucleus-api-jdo 6.0.1, datanucleus-api-jpa 6.0.1, datanucleus-rdbms 6.0.6 See [https://github.com/datanucleus/datanucleus-core/issues/495] and [https://github.com/datanucleus/datanucleus-core/issues/499] was (Author: andy): FYI, DataNucleus GitHub master (unreleased) has latest ASM, so should "support" Java 21. https://github.com/datanucleus/datanucleus-core/issues/495 > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen updated JDO-822: Fix Version/s: JDO 3.2.2 (was: JDO 3.3) > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2 > > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen updated JDO-822: Fix Version/s: JDO 3.3 > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.3 > > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen resolved JDO-822. - Resolution: Fixed > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-830) tck: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781491#comment-17781491 ] Michael Bouschen commented on JDO-830: -- First version of JUnit 5 migration: https://github.com/apache/db-jdo/tree/JDO-830 > tck: Migrate JUnit tests to version 5 > - > > Key: JDO-830 > URL: https://issues.apache.org/jira/browse/JDO-830 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The tck tests in the tck subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * [https://www.baeldung.com/junit-5-migration] > * > [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780029#comment-17780029 ] Andy Jefferson commented on JDO-822: FYI, DataNucleus GitHub master (unreleased) has latest ASM, so should "support" Java 21. https://github.com/datanucleus/datanucleus-core/issues/495 > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-822) Verify compatibility with JDK 21
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-822: - Description: JDK 21 reached [General Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. Summary: Verify compatibility with JDK 21 (was: Verify compatibility with JDK 20) > Verify compatibility with JDK 21 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > > JDK 21 reached [General > Availability|https://openjdk.org/projects/jdk8/milestones#General_Availability] > on 19 September 2023, so we should go for JDK 21 instaed of JDK 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-830) tck: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-830: Assignee: Michael Bouschen > tck: Migrate JUnit tests to version 5 > - > > Key: JDO-830 > URL: https://issues.apache.org/jira/browse/JDO-830 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The tck tests in the tck subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * [https://www.baeldung.com/junit-5-migration] > * > [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-833) Use automated release infra for JDO releases
[ https://issues.apache.org/jira/browse/JDO-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-833: - Description: Signing releases using automated release infra is a possibility for us to use for the next release. See https://infra.apache.org/release-signing.html#automated-release-signing was:Signing releases using automated release infra is a possibility for us to use for the next release. > Use automated release infra for JDO releases > > > Key: JDO-833 > URL: https://issues.apache.org/jira/browse/JDO-833 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > Signing releases using automated release infra is a possibility for us to use > for the next release. > See https://infra.apache.org/release-signing.html#automated-release-signing -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-833) Use automated release infra for JDO releases
Michael Bouschen created JDO-833: Summary: Use automated release infra for JDO releases Key: JDO-833 URL: https://issues.apache.org/jira/browse/JDO-833 Project: JDO Issue Type: Task Components: site and infrastructure Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen Signing releases using automated release infra is a possibility for us to use for the next release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-833) Use automated release infra for JDO releases
[ https://issues.apache.org/jira/browse/JDO-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-833: - Fix Version/s: JDO 3.2.2 JDO 3.3 > Use automated release infra for JDO releases > > > Key: JDO-833 > URL: https://issues.apache.org/jira/browse/JDO-833 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > Signing releases using automated release infra is a possibility for us to use > for the next release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-832) Remove RunTCK option jdo.tck.skipJndi
[ https://issues.apache.org/jira/browse/JDO-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-832. -- Resolution: Fixed > Remove RunTCK option jdo.tck.skipJndi > - > > Key: JDO-832 > URL: https://issues.apache.org/jira/browse/JDO-832 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > With JDO-827 the TCK comes with its own JNDI mock implementation. > Without an JNDI implemention we needed to skip the JNDI TCK test cases when > running the tck from an automatic build. This is not necessary anymore, so we > do not need the option jdo.tck.skipJndi anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-827) Consider (re-)moving JNDI support
[
https://issues.apache.org/jira/browse/JDO-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilmann Zäschke resolved JDO-827.
-
Fix Version/s: JDO 3.2.2
JDO 3.3
Assignee: Tilmann Zäschke
Resolution: Fixed
> Consider (re-)moving JNDI support
> -
>
> Key: JDO-827
> URL: https://issues.apache.org/jira/browse/JDO-827
> Project: JDO
> Issue Type: Improvement
> Components: api
>Affects Versions: JDO 3.2, JDO 3.2.1
>Reporter: Tilmann Zäschke
>Assignee: Tilmann Zäschke
>Priority: Major
> Fix For: JDO 3.2.2, JDO 3.3
>
>
> The JDO API has two JNDI dependencies:
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context)}} and
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context, ClassLoader loader)}}
> The JNDI dependency complicates building and running the TCK (because of the
> non-free nature of the implementation). It is also the only part of the API
> that stops it being compatible with Android. The CI runs currently have all
> tests disabled that depend on JNDI (TBD, how does it compile without the
> classes???).
> There are many options for simplifying this issue:
> * Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB,
> JMS.
> * Move the two methods into a separate JDOJNDIHelper. This would (probably)
> allow us to more easily exclude it from builds when desired, for example
> using Java 9 modules.
> * Provide a dummy implementation of the JNDI classes. This would allow
> compiling the API without problems (also on Android), but we would still need
> to exclude it from tests.
> * Switch to a free leightweight implementation, e.g.
> [https://github.com/h-thurow/Simple-JNDI] or
> https://github.com/dattack/standalone-jndi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JDO-832) Remove RunTCK option jdo.tck.skipJndi
Michael Bouschen created JDO-832: Summary: Remove RunTCK option jdo.tck.skipJndi Key: JDO-832 URL: https://issues.apache.org/jira/browse/JDO-832 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen Assignee: Michael Bouschen Fix For: JDO 3.2.2, JDO 3.3 With JDO-827 the TCK comes with its own JNDI mock implementation. Without an JNDI implemention we needed to skip the JNDI TCK test cases when running the tck from an automatic build. This is not necessary anymore, so we do not need the option jdo.tck.skipJndi anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-829) api: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-829. -- Resolution: Fixed > api: Migrate JUnit tests to version 5 > - > > Key: JDO-829 > URL: https://issues.apache.org/jira/browse/JDO-829 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The unit tests in the api subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * https://www.baeldung.com/junit-5-migration -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-830) tck: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-830: - Description: The tck tests in the tck subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. Links: * [https://junit.org/junit5/docs/current/user-guide/] * [https://www.baeldung.com/junit-5] * [https://www.baeldung.com/junit-5-migration] * [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] was: The tck tests in the tck subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. Links: * [https://junit.org/junit5/docs/current/user-guide/] * [https://www.baeldung.com/junit-5] * https://www.baeldung.com/junit-5-migration > tck: Migrate JUnit tests to version 5 > - > > Key: JDO-830 > URL: https://issues.apache.org/jira/browse/JDO-830 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The tck tests in the tck subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * [https://www.baeldung.com/junit-5-migration] > * > [https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-831) tck: improve tck tests for performance
[ https://issues.apache.org/jira/browse/JDO-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-831: - Description: The performance of the tck test suite might be improved by using: * multi-threading * parallel execution of tests that do not change the database * setup/teardown optimization for tests that do not change the database was: The performance of the tck test suite might be improved by using: * multi-threading * parallel execution of tests that do not change the database * setup/teardown optimization for tests that do not change the database https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build > tck: improve tck tests for performance > -- > > Key: JDO-831 > URL: https://issues.apache.org/jira/browse/JDO-831 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The performance of the tck test suite might be improved by using: > * multi-threading > * parallel execution of tests that do not change the database > * setup/teardown optimization for tests that do not change the database -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-831) tck: improve tck tests for performance
[ https://issues.apache.org/jira/browse/JDO-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-831: - Fix Version/s: JDO 3.2.2 JDO 3.3 > tck: improve tck tests for performance > -- > > Key: JDO-831 > URL: https://issues.apache.org/jira/browse/JDO-831 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The performance of the tck test suite might be improved by using: > * multi-threading > * parallel execution of tests that do not change the database > * setup/teardown optimization for tests that do not change the database > https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-831) tck: improve tck tests for performance
Michael Bouschen created JDO-831: Summary: tck: improve tck tests for performance Key: JDO-831 URL: https://issues.apache.org/jira/browse/JDO-831 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The performance of the tck test suite might be improved by using: * multi-threading * parallel execution of tests that do not change the database * setup/teardown optimization for tests that do not change the database https://stackoverflow.com/questions/47158583/executing-junit-4-and-junit-5-tests-in-a-same-build -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-830) tck: Migrate JUnit tests to version 5
Michael Bouschen created JDO-830: Summary: tck: Migrate JUnit tests to version 5 Key: JDO-830 URL: https://issues.apache.org/jira/browse/JDO-830 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen Fix For: JDO 3.2.2, JDO 3.3 The tck tests in the tck subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. Links: * [https://junit.org/junit5/docs/current/user-guide/] * [https://www.baeldung.com/junit-5] * https://www.baeldung.com/junit-5-migration -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-829) api: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-829: - Description: The unit tests in the api subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. Links: * [https://junit.org/junit5/docs/current/user-guide/] * [https://www.baeldung.com/junit-5] * https://www.baeldung.com/junit-5-migration was:The unit tests in the api subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > api: Migrate JUnit tests to version 5 > - > > Key: JDO-829 > URL: https://issues.apache.org/jira/browse/JDO-829 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The unit tests in the api subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. > Links: > * [https://junit.org/junit5/docs/current/user-guide/] > * [https://www.baeldung.com/junit-5] > * https://www.baeldung.com/junit-5-migration -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-829) api: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-829: Assignee: Michael Bouschen > api: Migrate JUnit tests to version 5 > - > > Key: JDO-829 > URL: https://issues.apache.org/jira/browse/JDO-829 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The unit tests in the api subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-829) api: Migrate JUnit tests to version 5
[ https://issues.apache.org/jira/browse/JDO-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-829: - Fix Version/s: JDO 3.2.2 JDO 3.3 > api: Migrate JUnit tests to version 5 > - > > Key: JDO-829 > URL: https://issues.apache.org/jira/browse/JDO-829 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > The unit tests in the api subproject are using JUnit 4 and are written in a > JUnit 3.8.1 style. The tests should be migrated to JUnit 5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-829) api: Migrate JUnit tests to version 5
Michael Bouschen created JDO-829: Summary: api: Migrate JUnit tests to version 5 Key: JDO-829 URL: https://issues.apache.org/jira/browse/JDO-829 Project: JDO Issue Type: Task Components: api Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The unit tests in the api subproject are using JUnit 4 and are written in a JUnit 3.8.1 style. The tests should be migrated to JUnit 5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-827) Consider (re-)moving JNDI support
[
https://issues.apache.org/jira/browse/JDO-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Bouschen updated JDO-827:
-
Description:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB, JMS.
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
* Switch to a free leightweight implementation, e.g.
[https://github.com/h-thurow/Simple-JNDI] or
https://github.com/dattack/standalone-jndi
was:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB, JMS.
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
* Switch to a free leightweight implementation, e.g.
https://github.com/h-thurow/Simple-JNDI
> Consider (re-)moving JNDI support
> -
>
> Key: JDO-827
> URL: https://issues.apache.org/jira/browse/JDO-827
> Project: JDO
> Issue Type: Improvement
> Components: api
>Affects Versions: JDO 3.2, JDO 3.2.1
>Reporter: Tilmann Zäschke
>Priority: Major
>
> The JDO API has two JNDI dependencies:
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context)}} and
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context, ClassLoader loader)}}
> The JNDI dependency complicates building and running the TCK (because of the
> non-free nature of the implementation). It is also the only part of the API
> that stops it being compatible with Android. The CI runs currently have all
> tests disabled that depend on JNDI (TBD, how does it compile without the
> classes???).
> There are many options for simplifying this issue:
> * Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB,
> JMS.
> * Move the two methods into a separate JDOJNDIHelper. This would (probably)
> allow us to more easily exclude it from builds when desired, for example
> using Java 9 modules.
> * Provide a dummy implementation of the JNDI classes. This would allow
> compiling the API without problems (also on Android), but we would still need
> to exclude it from tests.
> * Switch to a free leightweight implementation, e.g.
> [https://github.com/h-thurow/Simple-JNDI] or
> https://github.com/dattack/standalone-jndi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (JDO-828) Set up automated mail subjects for GitHub action responses
[ https://issues.apache.org/jira/browse/JDO-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen resolved JDO-828. - Resolution: Fixed > Set up automated mail subjects for GitHub action responses > -- > > Key: JDO-828 > URL: https://issues.apache.org/jira/browse/JDO-828 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > On the general Apache community page, a range of email subjects for automated > email created for different actions on GitHub have been suggested: > [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] > These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (JDO-828) Set up automated mail subjects for GitHub action responses
[ https://issues.apache.org/jira/browse/JDO-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen reopened JDO-828: - > Set up automated mail subjects for GitHub action responses > -- > > Key: JDO-828 > URL: https://issues.apache.org/jira/browse/JDO-828 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > On the general Apache community page, a range of email subjects for automated > email created for different actions on GitHub have been suggested: > [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] > These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JDO-828) Set up automated mail subjects for GitHub action responses
[ https://issues.apache.org/jira/browse/JDO-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen closed JDO-828. --- Resolution: Fixed > Set up automated mail subjects for GitHub action responses > -- > > Key: JDO-828 > URL: https://issues.apache.org/jira/browse/JDO-828 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > On the general Apache community page, a range of email subjects for automated > email created for different actions on GitHub have been suggested: > [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] > These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-828) Set up automated mail subjects for GitHub action responses
[ https://issues.apache.org/jira/browse/JDO-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-828: - Fix Version/s: JDO 3.2.2 JDO 3.3 > Set up automated mail subjects for GitHub action responses > -- > > Key: JDO-828 > URL: https://issues.apache.org/jira/browse/JDO-828 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > On the general Apache community page, a range of email subjects for automated > email created for different actions on GitHub have been suggested: > [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] > These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-828) Set up automated mail subjects for GitHub action responses
[ https://issues.apache.org/jira/browse/JDO-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-828: - Component/s: site and infrastructure > Set up automated mail subjects for GitHub action responses > -- > > Key: JDO-828 > URL: https://issues.apache.org/jira/browse/JDO-828 > Project: JDO > Issue Type: Task > Components: site and infrastructure >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > > On the general Apache community page, a range of email subjects for automated > email created for different actions on GitHub have been suggested: > [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] > These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-822) Verify compatibility with JDK 20
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729123#comment-17729123 ] Craig L Russell commented on JDO-822: - +1 Continue to build/test on JDK20 and then change to JDK21 when available. > Verify compatibility with JDK 20 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-822) Verify compatibility with JDK 20
[ https://issues.apache.org/jira/browse/JDO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729106#comment-17729106 ] Tobias Bouschen commented on JDO-822: - I adjusted the matrix build on my fork to run with JDK 20 and the build still succeeds: [https://github.com/tobous/db-jdo/actions/runs/5170691272/jobs/9313757782] Please keep in mind that this only changes the JDK version and not the actual build target. JDO is currently still always built against the language level of Java 8. As JDK 20 is not LTS (JDK 21 will be the next LTS release), I would suggest keeping the matrix build on the main repo as it is and then jumping to JDK 21 once it is out. > Verify compatibility with JDK 20 > > > Key: JDO-822 > URL: https://issues.apache.org/jira/browse/JDO-822 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-828) Set up automated mail subjects for GitHub action responses
Tobias Bouschen created JDO-828: --- Summary: Set up automated mail subjects for GitHub action responses Key: JDO-828 URL: https://issues.apache.org/jira/browse/JDO-828 Project: JDO Issue Type: Task Reporter: Tobias Bouschen Assignee: Tobias Bouschen On the general Apache community page, a range of email subjects for automated email created for different actions on GitHub have been suggested: [https://community.apache.org/contributors/mailing-lists#configuring-the-subject-lines-of-the-emails-being-sent] These settings should be applied to the JDO repositories. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-827) Consider (re-)moving JNDI support
[
https://issues.apache.org/jira/browse/JDO-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilmann Zäschke updated JDO-827:
Description:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB, JMS.
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
* Switch to a free leightweight implementation, e.g.
https://github.com/h-thurow/Simple-JNDI
was:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used?
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
* Switch to a free leightweight implementation, e.g.
https://github.com/h-thurow/Simple-JNDI
> Consider (re-)moving JNDI support
> -
>
> Key: JDO-827
> URL: https://issues.apache.org/jira/browse/JDO-827
> Project: JDO
> Issue Type: Improvement
> Components: api
>Affects Versions: JDO 3.2, JDO 3.2.1
>Reporter: Tilmann Zäschke
>Priority: Major
>
> The JDO API has two JNDI dependencies:
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context)}} and
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context, ClassLoader loader)}}
> The JNDI dependency complicates building and running the TCK (because of the
> non-free nature of the implementation). It is also the only part of the API
> that stops it being compatible with Android. The CI runs currently have all
> tests disabled that depend on JNDI (TBD, how does it compile without the
> classes???).
> There are many options for simplifying this issue:
> * Drop JNDI support? Is JNDI still used? Probably yes, see JDBC, JPA, EJB,
> JMS.
> * Move the two methods into a separate JDOJNDIHelper. This would (probably)
> allow us to more easily exclude it from builds when desired, for example
> using Java 9 modules.
> * Provide a dummy implementation of the JNDI classes. This would allow
> compiling the API without problems (also on Android), but we would still need
> to exclude it from tests.
> * Switch to a free leightweight implementation, e.g.
> https://github.com/h-thurow/Simple-JNDI
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JDO-827) Consider (re-)moving JNDI support
[
https://issues.apache.org/jira/browse/JDO-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilmann Zäschke updated JDO-827:
Description:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used?
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
* Switch to a free leightweight implementation, e.g.
https://github.com/h-thurow/Simple-JNDI
was:
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used?
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
> Consider (re-)moving JNDI support
> -
>
> Key: JDO-827
> URL: https://issues.apache.org/jira/browse/JDO-827
> Project: JDO
> Issue Type: Improvement
> Components: api
>Affects Versions: JDO 3.2, JDO 3.2.1
>Reporter: Tilmann Zäschke
>Priority: Major
>
> The JDO API has two JNDI dependencies:
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context)}} and
> {{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
> context, ClassLoader loader)}}
> The JNDI dependency complicates building and running the TCK (because of the
> non-free nature of the implementation). It is also the only part of the API
> that stops it being compatible with Android. The CI runs currently have all
> tests disabled that depend on JNDI (TBD, how does it compile without the
> classes???).
> There are many options for simplifying this issue:
> * Drop JNDI support? Is JNDI still used?
> * Move the two methods into a separate JDOJNDIHelper. This would (probably)
> allow us to more easily exclude it from builds when desired, for example
> using Java 9 modules.
> * Provide a dummy implementation of the JNDI classes. This would allow
> compiling the API without problems (also on Android), but we would still need
> to exclude it from tests.
> * Switch to a free leightweight implementation, e.g.
> https://github.com/h-thurow/Simple-JNDI
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JDO-827) Consider (re-)moving JNDI support
Tilmann Zäschke created JDO-827:
---
Summary: Consider (re-)moving JNDI support
Key: JDO-827
URL: https://issues.apache.org/jira/browse/JDO-827
Project: JDO
Issue Type: Improvement
Components: api
Affects Versions: JDO 3.2.1, JDO 3.2
Reporter: Tilmann Zäschke
The JDO API has two JNDI dependencies:
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context
context)}} and
{{JDOHelper.getPersistenceManagerFactory(String jndiLocation, Context context,
ClassLoader loader)}}
The JNDI dependency complicates building and running the TCK (because of the
non-free nature of the implementation). It is also the only part of the API
that stops it being compatible with Android. The CI runs currently have all
tests disabled that depend on JNDI (TBD, how does it compile without the
classes???).
There are many options for simplifying this issue:
* Drop JNDI support? Is JNDI still used?
* Move the two methods into a separate JDOJNDIHelper. This would (probably)
allow us to more easily exclude it from builds when desired, for example using
Java 9 modules.
* Provide a dummy implementation of the JNDI classes. This would allow
compiling the API without problems (also on Android), but we would still need
to exclude it from tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (JDO-826) @Convert Javadoc indicates support for @Target(ElementType.TYPE,...)
[
https://issues.apache.org/jira/browse/JDO-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilmann Zäschke closed JDO-826.
---
Assignee: Tilmann Zäschke
Resolution: Fixed
> @Convert Javadoc indicates support for @Target(ElementType.TYPE,...)
>
>
> Key: JDO-826
> URL: https://issues.apache.org/jira/browse/JDO-826
> Project: JDO
> Issue Type: Bug
> Components: api
>Affects Versions: JDO 3.2
>Reporter: Tilmann Zäschke
>Assignee: Tilmann Zäschke
>Priority: Major
> Fix For: JDO 3.2.2
>
>
> The javadoc of the @Convert annotation claims that it can be placed on types,
> e.g.
> {code:java}
> @Convert(value = ConvertiblePointToStringConverter.class)
> public class ConvertiblePoint {
> ...
> }
> {code}
> While this feature is desirable, there is currently no implementation of it
> in the reference implementation.
> For now, the javadoc should be fixed by removing the section about
> @Target(ElementType.TYPE,...).
> Once the implementation is resourced (volunteers welcome!) the section can be
> put back in place.
>
> Context:
> * Original discussion:
> [JDO-709|https://issues.apache.org/jira/browse/JDO-709], starting 2022-10-17
> * PR by original problem reporter: [https://github.com/apache/db-jdo/pull/60]
> * Copy of original PR with additional TCK test:
> [https://github.com/apache/db-jdo/pull/61]
> * Tickets with problem description on reference implementation:
> [https://github.com/datanucleus/datanucleus-api-jdo/issues/127]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (JDO-709) Standardize field/property converters
[ https://issues.apache.org/jira/browse/JDO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709870#comment-17709870 ] Tilmann Zäschke commented on JDO-709: - The discussion about @Target(ElementType.TYPE,...) has been moved to a separate ticket, concluding that we remove it from the javadoc until an implementation is available: [JDO-826|https://issues.apache.org/jira/browse/JDO-826] > Standardize field/property converters > - > > Key: JDO-709 > URL: https://issues.apache.org/jira/browse/JDO-709 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Matthew T. Adams >Assignee: Craig L Russell >Priority: Minor > Labels: converstion, converter, jdo, type, type-converter > Fix For: JDO 3.2 > > Attachments: JDO-709-01.patch, JDO-709-3.patch, JDO-709-4.patch > > > This request is to standardize a user's ability to specify conversions of > fields or properties of persistence-capable classes. Currently, this is left > to vendor extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-826) @Convert Javadoc indicates support for @Target(ElementType.TYPE,...)
Tilmann Zäschke created JDO-826:
---
Summary: @Convert Javadoc indicates support for
@Target(ElementType.TYPE,...)
Key: JDO-826
URL: https://issues.apache.org/jira/browse/JDO-826
Project: JDO
Issue Type: Bug
Components: api
Affects Versions: JDO 3.2
Reporter: Tilmann Zäschke
Fix For: JDO 3.2.2
The javadoc of the @Convert annotation claims that it can be placed on types,
e.g.
{code:java}
@Convert(value = ConvertiblePointToStringConverter.class)
public class ConvertiblePoint {
...
}
{code}
While this feature is desirable, there is currently no implementation of it in
the reference implementation.
For now, the javadoc should be fixed by removing the section about
@Target(ElementType.TYPE,...).
Once the implementation is resourced (volunteers welcome!) the section can be
put back in place.
Context:
* Original discussion:
[JDO-709|https://issues.apache.org/jira/browse/JDO-709], starting 2022-10-17
* PR by original problem reporter: [https://github.com/apache/db-jdo/pull/60]
* Copy of original PR with additional TCK test:
[https://github.com/apache/db-jdo/pull/61]
* Tickets with problem description on reference implementation:
[https://github.com/datanucleus/datanucleus-api-jdo/issues/127]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JDO-825) Improve exectck classes
Michael Bouschen created JDO-825: Summary: Improve exectck classes Key: JDO-825 URL: https://issues.apache.org/jira/browse/JDO-825 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen Some exectck classes may be improved: * AbstractTCKMojo, PropertyUtils, Utilites: close reader or stream in a try-with-resource * PropertyUtils: remove unused methods * AbstractTCKMojo, Enhance, RunTCK: Replace the type specification in the constructoir call with the diamond operator (<>) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-825) Improve exectck classes
[ https://issues.apache.org/jira/browse/JDO-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-825: Assignee: Michael Bouschen > Improve exectck classes > --- > > Key: JDO-825 > URL: https://issues.apache.org/jira/browse/JDO-825 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > > Some exectck classes may be improved: > * AbstractTCKMojo, PropertyUtils, Utilites: close reader or stream in a > try-with-resource > * PropertyUtils: remove unused methods > * AbstractTCKMojo, Enhance, RunTCK: Replace the type specification in the > constructoir call with the diamond operator (<>) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-709) Standardize field/property converters
[ https://issues.apache.org/jira/browse/JDO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681744#comment-17681744 ] Tilmann Zäschke commented on JDO-709: - To keep this thread somewhat up to date, there have been three PRs/tickets concerning @Convert on types: * PR by original problem reporter: [https://github.com/apache/db-jdo/pull/60|https://github.com/apache/db-jdo/pull/60] * Copy or original PR with additional TCK test: [https://github.com/apache/db-jdo/pull/61|https://github.com/apache/db-jdo/pull/61] * Tickets with problem description on reference implementation: [https://github.com/datanucleus/datanucleus-api-jdo/issues/127|https://github.com/datanucleus/datanucleus-api-jdo/issues/127] > Standardize field/property converters > - > > Key: JDO-709 > URL: https://issues.apache.org/jira/browse/JDO-709 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Matthew T. Adams >Assignee: Craig L Russell >Priority: Minor > Labels: converstion, converter, jdo, type, type-converter > Fix For: JDO 3.2 > > Attachments: JDO-709-01.patch, JDO-709-3.patch, JDO-709-4.patch > > > This request is to standardize a user's ability to specify conversions of > fields or properties of persistence-capable classes. Currently, this is left > to vendor extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JDO-824) JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable
[ https://issues.apache.org/jira/browse/JDO-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke closed JDO-824. --- Resolution: Won't Fix It is not clear why this was implemented. However, changing this may break implementations. This is undesirable, and since we don't know the original rationale for this catch-all, we chose to leave it be. > JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable > -- > > Key: JDO-824 > URL: https://issues.apache.org/jira/browse/JDO-824 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > > The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown > Exceptions of type Throwable. > This should probably be changed to be more specific, in the current state it > would even ignore > OutOfMemoryException, which is probably not what is intended here. > All occurrences: > * nonBinaryCompatibleGet() > * nonBinaryCompatibleIs() > * nonBinaryCompatibleMakeDirty() > Otherwise we should document why this okay. > I am currently unsure why ignoring *any* exception is okay here? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-824) JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable
[ https://issues.apache.org/jira/browse/JDO-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke reassigned JDO-824: --- Assignee: Tilmann Zäschke > JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable > -- > > Key: JDO-824 > URL: https://issues.apache.org/jira/browse/JDO-824 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > > The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown > Exceptions of type Throwable. > This should probably be changed to be more specific, in the current state it > would even ignore > OutOfMemoryException, which is probably not what is intended here. > All occurrences: > * nonBinaryCompatibleGet() > * nonBinaryCompatibleIs() > * nonBinaryCompatibleMakeDirty() > Otherwise we should document why this okay. > I am currently unsure why ignoring *any* exception is okay here? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-824) JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable
[ https://issues.apache.org/jira/browse/JDO-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke updated JDO-824: Fix Version/s: (was: JDO 3.2.2) Description: The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable. This should probably be changed to be more specific, in the current state it would even ignore OutOfMemoryException, which is probably not what is intended here. All occurrences: * nonBinaryCompatibleGet() * nonBinaryCompatibleIs() * nonBinaryCompatibleMakeDirty() Otherwise we should document why this okay. I am currently unsure why ignoring *any* exception is okay here? was: The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable. This should probably be changed to be more specific, in the current state it would even ignore OutOfMemoryException, which is probably not what is intended here. > JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable > -- > > Key: JDO-824 > URL: https://issues.apache.org/jira/browse/JDO-824 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2, JDO 3.2.1 >Reporter: Tilmann Zäschke >Priority: Major > > The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown > Exceptions of type Throwable. > This should probably be changed to be more specific, in the current state it > would even ignore > OutOfMemoryException, which is probably not what is intended here. > All occurrences: > * nonBinaryCompatibleGet() > * nonBinaryCompatibleIs() > * nonBinaryCompatibleMakeDirty() > Otherwise we should document why this okay. > I am currently unsure why ignoring *any* exception is okay here? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-824) JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable
Tilmann Zäschke created JDO-824: --- Summary: JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable Key: JDO-824 URL: https://issues.apache.org/jira/browse/JDO-824 Project: JDO Issue Type: Task Components: api Affects Versions: JDO 3.2.1, JDO 3.2 Reporter: Tilmann Zäschke Fix For: JDO 3.2.2 The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable. This should probably be changed to be more specific, in the current state it would even ignore OutOfMemoryException, which is probably not what is intended here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-823) Fix sonarcloud issues of type Code Smells
[ https://issues.apache.org/jira/browse/JDO-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-823: - Fix Version/s: JDO 3.3 > Fix sonarcloud issues of type Code Smells > - > > Key: JDO-823 > URL: https://issues.apache.org/jira/browse/JDO-823 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonalcloud run lists 311 issues in the category Maintainability > (Code Smells). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-823) Fix sonarcloud issues of type Code Smells
Michael Bouschen created JDO-823: Summary: Fix sonarcloud issues of type Code Smells Key: JDO-823 URL: https://issues.apache.org/jira/browse/JDO-823 Project: JDO Issue Type: Task Components: api Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The latest sonalcloud run lists 311 issues in the category Maintainability (Code Smells). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-821) Fix sonarcloud issues of type Bugs and Security Hotspots
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-821. -- Resolution: Fixed The issues in the categories Reliability (= Bugs) and Security Review (= Security Hotspots) are fixed now. > Fix sonarcloud issues of type Bugs and Security Hotspots > > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-821) Fix sonarcloud issues of type Bugs and Security Hotspots
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-821: - Summary: Fix sonarcloud issues of type Bugs and Security Hotspots (was: Fix sonarcloud issues of type Bugs) > Fix sonarcloud issues of type Bugs and Security Hotspots > > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652249#comment-17652249 ] Michael Bouschen commented on JDO-821: -- Fixed 18 issues in the category Reliability marked as Bugs * JDOException: javadoc sentence was flagged as code in comments because of an semikolon. * JDOException: Redefined method missed a synchronized keyxword * JDOException: printStackTrace removed synchronized method qualifier, because method body is already synchronized. * package.html: missing doctype in javadoc * package.html: missing language spec in html element of javadoc * package.html: replaced by * SingleFieldIdentity: added synchronized keyword to setter because corresponding getter was already synchronized * Adapted jdo-signature.txt because of the above synchronized changes. > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648243#comment-17648243 ] Tilmann Zäschke edited comment on JDO-821 at 12/15/22 8:56 PM: --- Fixed 12 issues labelled as "security". They all involve calling printStackTrace() on an Exception ([java:S4507|https://sonarcloud.io/organizations/apache/rules?open=java%3AS4507_key=java%3AS4507]). * 8 Issues where inside 'exectck' so they can be ignored (not part of production code) * 2 issues were inside 'LegacyJava' and have been removed. * 2 Issues were in 'javax/jdo.Enhance' and are considered "safe" (I labelled them as "safe" in SonarCloud). Rationale: The Enhancer is executed before any data comes into the application so there is no risk of leaking sensitive data such as passwords. The risk of leaking domain class names is real but deemed acceptable. See [PR #66|https://github.com/apache/db-jdo/pull/66] was (Author: tilmannz): Fixed 12 issues labelled as "security". They all involve calling printStackTrace() on an Exception ([java:S4507|https://sonarcloud.io/organizations/apache/rules?open=java%3AS4507_key=java%3AS4507]). * 8 Issues where inside 'exectck' so they can be ignored (not part of production code) * 2 issues were inside 'LegacyJava' and have been removed. * 2 Issues were in 'javax/jdo.Enhance' and are considered "safe" (I labelled them as "safe" in SonarCloud). Rationale: The Enhancer is executed before any data comes into the application so there is no risk of leaking sensitive data such as passwords. The risk of leaking domain class names is real but deemed acceptable. See [PR|https://github.com/apache/db-jdo/pull/66] > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648243#comment-17648243 ] Tilmann Zäschke edited comment on JDO-821 at 12/15/22 8:56 PM: --- Fixed 12 issues labelled as "security". They all involve calling printStackTrace() on an Exception ([java:S4507|https://sonarcloud.io/organizations/apache/rules?open=java%3AS4507_key=java%3AS4507]). * 8 Issues where inside 'exectck' so they can be ignored (not part of production code) * 2 issues were inside 'LegacyJava' and have been removed. * 2 Issues were in 'javax/jdo.Enhance' and are considered "safe" (I labelled them as "safe" in SonarCloud). Rationale: The Enhancer is executed before any data comes into the application so there is no risk of leaking sensitive data such as passwords. The risk of leaking domain class names is real but deemed acceptable. See [PR|https://github.com/apache/db-jdo/pull/66] was (Author: tilmannz): Fixed 12 issues labelled as "security". They all involve calling printStackTrace() on an Exception (java:S4507). * 8 Issues where inside 'exectck' so they can be ignored (not part of production code) * 2 issues were inside 'LegacyJava' and have been removed. * 2 Issues were in 'javax/jdo.Enhance' and are considered "safe" (I labelled them as "safe" in SonarCloud). Rationale: The Enhancer is executed before any data comes into the application so there is no risk of leaking sensitive data such as passwords. The risk of leaking domain class names is real but deemed acceptable. See [PR|https://github.com/apache/db-jdo/pull/66] > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648243#comment-17648243 ] Tilmann Zäschke commented on JDO-821: - Fixed 12 issues labelled as "security". They all involve calling printStackTrace() on an Exception (java:S4507). * 8 Issues where inside 'exectck' so they can be ignored (not part of production code) * 2 issues were inside 'LegacyJava' and have been removed. * 2 Issues were in 'javax/jdo.Enhance' and are considered "safe" (I labelled them as "safe" in SonarCloud). Rationale: The Enhancer is executed before any data comes into the application so there is no risk of leaking sensitive data such as passwords. The risk of leaking domain class names is real but deemed acceptable. See [PR|https://github.com/apache/db-jdo/pull/66] > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-815) Change headers on source files to use https:// instead of http://
[ https://issues.apache.org/jira/browse/JDO-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig L Russell resolved JDO-815. - Resolution: Fixed > Change headers on source files to use https:// instead of http:// > - > > Key: JDO-815 > URL: https://issues.apache.org/jira/browse/JDO-815 > Project: JDO > Issue Type: Task > Components: api, tck >Affects Versions: JDO 3.2.1 >Reporter: Craig L Russell >Assignee: Craig L Russell >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > The license headers in all source files use > [http://www.apache.org/licenses/LICENSE-2.0] > The headers should instead use > [https://www.apache.org/licenses/LICENSE-2.0] > This change should also be made in pom.xml > We will need to wait until RAT 0.14 is released in order to pass the RAT test > for license headers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648226#comment-17648226 ] Tilmann Zäschke commented on JDO-821: - Added a SonarCloud exclusion rule for [java:S110|https://sonarcloud.io/organizations/apache/rules?open=java%3AS110_key=java%3AS110] (Inheritance tree of classes should not be too deep) for all subclasses of "Exception". > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-819) Code quality analysis
[ https://issues.apache.org/jira/browse/JDO-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-819: - Description: Many Apache projects analyze code health: [https://sonarcloud.io/organizations/apache/projects] Maybe we should do the same for JDO? Here is the sonarcloud link for db-jdo: https://sonarcloud.io/summary/overall?id=db-jdo was: Many Apache projects analyze code health: [https://sonarcloud.io/organizations/apache/projects|https://sonarcloud.io/organizations/apache/projects] Maybe we should do the same for JDO? > Code quality analysis > - > > Key: JDO-819 > URL: https://issues.apache.org/jira/browse/JDO-819 > Project: JDO > Issue Type: Improvement > Components: site and infrastructure >Reporter: Tilmann Zäschke >Priority: Minor > > Many Apache projects analyze code health: > [https://sonarcloud.io/organizations/apache/projects] > Maybe we should do the same for JDO? > Here is the sonarcloud link for db-jdo: > https://sonarcloud.io/summary/overall?id=db-jdo > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-820) Clean up copyright NOTICE and references
[ https://issues.apache.org/jira/browse/JDO-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-820. -- Resolution: Fixed > Clean up copyright NOTICE and references > > > Key: JDO-820 > URL: https://issues.apache.org/jira/browse/JDO-820 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > Remove copyright notice from tck and remove copyright references from source > files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-820) Clean up copyright NOTICE and references
[ https://issues.apache.org/jira/browse/JDO-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-820: - Fix Version/s: JDO 3.2.2 JDO 3.3 > Clean up copyright NOTICE and references > > > Key: JDO-820 > URL: https://issues.apache.org/jira/browse/JDO-820 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > Fix For: JDO 3.2.2, JDO 3.3 > > > Remove copyright notice from tck and remove copyright references from source > files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-822) Verify compatibility with JDK 20
Tilmann Zäschke created JDO-822: --- Summary: Verify compatibility with JDK 20 Key: JDO-822 URL: https://issues.apache.org/jira/browse/JDO-822 Project: JDO Issue Type: Task Components: api, tck Affects Versions: JDO 3.2.1 Reporter: Tilmann Zäschke -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-821: - Fix Version/s: JDO 3.3 > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-821) Fix sonarcloud issues of type Bugs
[ https://issues.apache.org/jira/browse/JDO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-821: Assignee: Michael Bouschen > Fix sonarcloud issues of type Bugs > -- > > Key: JDO-821 > URL: https://issues.apache.org/jira/browse/JDO-821 > Project: JDO > Issue Type: Task > Components: api >Affects Versions: JDO 3.2.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Major > Fix For: JDO 3.3 > > > The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-821) Fix sonarcloud issues of type Bugs
Michael Bouschen created JDO-821: Summary: Fix sonarcloud issues of type Bugs Key: JDO-821 URL: https://issues.apache.org/jira/browse/JDO-821 Project: JDO Issue Type: Task Components: api Affects Versions: JDO 3.2.1 Reporter: Michael Bouschen The latest sonarcloud run lists 20 bugs in the category Reliability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JDO-820) Clean up copyright NOTICE and references
[ https://issues.apache.org/jira/browse/JDO-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644963#comment-17644963 ] Tilmann Zäschke commented on JDO-820: - Fixed in [https://github.com/apache/db-jdo/pull/64|https://github.com/apache/db-jdo/pull/64] > Clean up copyright NOTICE and references > > > Key: JDO-820 > URL: https://issues.apache.org/jira/browse/JDO-820 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > > Remove copyright notice from tck and remove copyright references from source > files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JDO-820) Clean up copyright NOTICE and references
Tilmann Zäschke created JDO-820: --- Summary: Clean up copyright NOTICE and references Key: JDO-820 URL: https://issues.apache.org/jira/browse/JDO-820 Project: JDO Issue Type: Task Components: tck Affects Versions: JDO 3.2.1 Reporter: Tilmann Zäschke Remove copyright notice from tck and remove copyright references from source files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JDO-820) Clean up copyright NOTICE and references
[ https://issues.apache.org/jira/browse/JDO-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilmann Zäschke reassigned JDO-820: --- Assignee: Tilmann Zäschke > Clean up copyright NOTICE and references > > > Key: JDO-820 > URL: https://issues.apache.org/jira/browse/JDO-820 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.2.1 >Reporter: Tilmann Zäschke >Assignee: Tilmann Zäschke >Priority: Major > > Remove copyright notice from tck and remove copyright references from source > files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JDO-818) Use Google Java Style as the code format conventions for the JDO project
[ https://issues.apache.org/jira/browse/JDO-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen updated JDO-818: - Affects Version/s: JDO 3.2.1 > Use Google Java Style as the code format conventions for the JDO project > > > Key: JDO-818 > URL: https://issues.apache.org/jira/browse/JDO-818 > Project: JDO > Issue Type: Task >Affects Versions: JDO 3.2.1 >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > h4. Google Java Style > I would propose moving to Google Java Style > ([https://google.github.io/styleguide/javaguide.html]) as the code formatting > style for the JDO project. > In my opinion, it offers a sensible and compact code style that is easy to > read. An overview of the rules of this style is given in the link posted > above. > h4. Google Java Format as the formatting tool > Additionally, I would propose moving to using the Google Java Format > ([https://github.com/google/google-java-format]) tool to do the formatting. > It is an open source formatter provided by Google. It is available as a > standalone JAR as well as plugin for IntelliJ and Eclipse (the Eclipse plugin > might not be as well maintained as the IntelliJ plugin). As such, the code > can be formatted using the CLI or the formatter can be integrated into the > default formatting tools of IntelliJ/Eclipse. > One big point of contention of the Google Java Formatter plugin is that it > offers very limited room for customization in order to ensure that it always > results in a uniform code formatting for all users. This is also explained in > the FAQ of the project: > [https://github.com/google/google-java-format/wiki/FAQ#i-just-need-to-configure-it-a-bit-differently-how] > h4. Possible automated integration > As Google Java Format is available as a CLI tool, it can be used as part of > the CI. For example, we could set up a Github Action that automatically > checks the formatting of newly created code and report back if it does not > match the Google Java Format style. It would also be possible to create a CI > job that automatically formats checked-in code, but I am not a big fan of > this approach as it changes code without any oversight, possibly leading to > unwanted changes (e.g. if there is a bug in the formatter logic). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JDO-818) Use Google Java Style as the code format conventions for the JDO project
[ https://issues.apache.org/jira/browse/JDO-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bouschen resolved JDO-818. - Resolution: Fixed > Use Google Java Style as the code format conventions for the JDO project > > > Key: JDO-818 > URL: https://issues.apache.org/jira/browse/JDO-818 > Project: JDO > Issue Type: Task >Reporter: Tobias Bouschen >Assignee: Tobias Bouschen >Priority: Minor > Fix For: JDO 3.2.2, JDO 3.3 > > > h4. Google Java Style > I would propose moving to Google Java Style > ([https://google.github.io/styleguide/javaguide.html]) as the code formatting > style for the JDO project. > In my opinion, it offers a sensible and compact code style that is easy to > read. An overview of the rules of this style is given in the link posted > above. > h4. Google Java Format as the formatting tool > Additionally, I would propose moving to using the Google Java Format > ([https://github.com/google/google-java-format]) tool to do the formatting. > It is an open source formatter provided by Google. It is available as a > standalone JAR as well as plugin for IntelliJ and Eclipse (the Eclipse plugin > might not be as well maintained as the IntelliJ plugin). As such, the code > can be formatted using the CLI or the formatter can be integrated into the > default formatting tools of IntelliJ/Eclipse. > One big point of contention of the Google Java Formatter plugin is that it > offers very limited room for customization in order to ensure that it always > results in a uniform code formatting for all users. This is also explained in > the FAQ of the project: > [https://github.com/google/google-java-format/wiki/FAQ#i-just-need-to-configure-it-a-bit-differently-how] > h4. Possible automated integration > As Google Java Format is available as a CLI tool, it can be used as part of > the CI. For example, we could set up a Github Action that automatically > checks the formatting of newly created code and report back if it does not > match the Google Java Format style. It would also be possible to create a CI > job that automatically formats checked-in code, but I am not a big fan of > this approach as it changes code without any oversight, possibly leading to > unwanted changes (e.g. if there is a bug in the formatter logic). -- This message was sent by Atlassian Jira (v8.20.10#820010)
