Re: Validate Jenkinsfile while using oauth

2018-11-16 Thread Jesse Glick
On Fri, Nov 16, 2018 at 8:12 AM domi  wrote:
> I really like the way I can validate my Jenkinsfile from within VS Code now: 
> https://jenkins.io/blog/2018/11/07/Validate-Jenkinsfile/
>
> But how can I do this when I use any of the Oauth-Plugins like the one for 
> Github[1] or Bitbucket [2]?

I presume that `jenkins.pipeline.linter.connector.pass` could be an
API token rather than a password. In fact, it really should be, even
if you are using a password-based security realm. Probably this is
just a matter of fixing the documentation to clarify that.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3xpZPi6qU%2BaEg37Ov7Bxn7GLAP29tdc7S1_d4SCAr-jw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Localization plugins: Where do we go from here?

2018-11-16 Thread Jesse Glick
On Fri, Nov 16, 2018 at 6:12 AM Robert Sandell  wrote:
> Is the intention to move all translations from core and plugins into these 
> new localisation plugins?

That is my understanding.

> got some "illegal access compilation errors" because the plugin was using 
> hudson.model.Messages for some of its UI strings. I assume this was added 
> because it can break compatibility in case of refactoring in core

Yes, your plugin could get a linkage error if messages are rearranged
in a lower layer (not necessarily core).

> it will be very cumbersome to change a resource bundle key as you then need 
> to change it in 30 odd localization plugins

No, I do not think there is any expectation that developers would
rename keys in localization plugins. They would just change the
English key. In particular, `core/move-l10n.groovy` could be deleted.

Translators are responsible for keeping up: introducing translations
for recently added keys, or removing stale translations for keys which
no longer exist. If a given version of the localization plugin for a
given locale fails to supply a translation for a given key, then it
will simply be rendered in English.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0f%3Detn%2BpXpAD75n7C-qLiR10M2pXGgM1UF9TjxB_ryKA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Validate Jenkinsfile while using oauth

2018-11-16 Thread domi
Hi,
I really like the way I can validate my Jenkinsfile from within VS Code now: 
https://jenkins.io/blog/2018/11/07/Validate-Jenkinsfile/ 


But how can I do this when I use any of the Oauth-Plugins like the one for 
Github[1] or Bitbucket [2]?

/Domi

[1] https://plugins.jenkins.io/github-oauth 

[2] https://plugins.jenkins.io/bitbucket-oauth

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/85C6A2FC-AA90-4B84-8FF9-185426EA606F%40fortysix.ch.
For more options, visit https://groups.google.com/d/optout.


Re: [Build failure analyzer] Request commit access

2018-11-16 Thread Tim Jacomb
Would you like help on it?

Thanks
Tim

On Fri, 16 Nov 2018 at 10:48, Robert Sandell  wrote:

> I've been very busy with other things the last few months so I've been
> neglecting my maintainer duties, but I'm slowly coming back and working off
> my code review backlog.
>
> /B
>
> Den tis 13 nov. 2018 kl 21:36 skrev Tim Jacomb :
>
>> CC maintainers
>>
>> On Tue, 13 Nov 2018 at 20:31, Tim Jacomb  wrote:
>>
>>> Hi
>>>
>>> I would like to request commit access for the build failure analyzer
>>> plugin
>>>
>>> I would like to clean it up and do some more development on it
>>>
>>> Github: timja
>>> Jenkins infra: timja
>>>
>>> Thanks
>>> Tim
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/9b7b01f8-5252-4af7-ba9f-c303c130209c%40googlegroups.com
>>> 
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>
> --
> *Robert Sandell*
> Software Engineer
> CloudBees, Inc.
> [image: CloudBees-Logo.png] 
> E: rsand...@cloudbees.com
> Twitter: robert_sandell
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifZnsas389x-7gxGPNSFPipHJc27EKLkiVG8iD86iioNg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Localization plugins: Where do we go from here?

2018-11-16 Thread Robert Sandell
Is the intention to move all translations from core and plugins into these
new localisation plugins? Looking at
https://github.com/jenkinsci/jenkins/pull/3729 it seems so?

I started the other day to update plugin pom and core versions on one of my
older plugins and got some "illegal access compilation errors" because the
plugin was using hudson.model.Messages for some of its UI strings. I assume
this was added because it can break compatibility in case of refactoring in
core and suddenly the key is renamed or something.
But that access guard is now then somewhat void since it will be very
cumbersome to change a resource bundle key as you then need to change it in
30 odd localization plugins to not have them break, and changing them will
break older versions broken anyway.

So I'm a bit confused as to the practicality of this as the assumption
seems to be that keys are not guaranteed to be set in stone?

/B

Den ons 14 nov. 2018 kl 18:00 skrev Jon Brohauge :

> I'd go with option C. I'd love to help in Danish where needed.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/49d4147c-e984-4871-9515-59d5b423d018%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
*Robert Sandell*
Software Engineer
CloudBees, Inc.
[image: CloudBees-Logo.png] 
E: rsand...@cloudbees.com
Twitter: robert_sandell

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2_aX0hRkLhFRgmLDkwMGJOkkyDV89YJV3OZEEXvhKYXg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Jenkins-infra] Request Jenkins Docker Hub admin access

2018-11-16 Thread Baptiste Mathus
Hey Oleg,

I do not think it is needed. It's even possibly desired: not having access
there, there's less chance we use it again by mistake.

Thanks for the help!

Cheers

Le ven. 16 nov. 2018 à 11:27, Oleg Nenashev  a
écrit :

> Hi Baptiste,
>
> Apparently I have no admin access to the old jenkinsci organization in
> DockerHub.
> Do you want to have admin permissions there as well?
>
> BR, Oleg
>
>
> On Fri, Nov 16, 2018 at 10:44 AM Oleg Nenashev 
> wrote:
>
>> Got +1 from Olivier in the INFRA ticket.
>> I consider this request as approved, and I will grant permissions to
>> Baptiste.
>>
>> Best regards,
>> Oleg
>>
>>
>> On Mon, Nov 12, 2018 at 3:36 PM Oleg Nenashev 
>> wrote:
>>
>>> +1 from me. Baptiste has Jenkins core merge access and CLA signed. Also,
>>> he is a Master Docker image miantainer now. I believe this access is
>>> totally fine.
>>>
>>> BR, Oleg
>>>
>>> On Mon, Nov 12, 2018 at 3:28 PM Baptiste Mathus  wrote:
>>>
 (cross-posting to dev and infra for transparency)

 Hello,

 As per my current work on making Jenkins work on Java 11, I would like
 to request access to the Jenkins account admin on Docker hub.

 Oleg, being one of the active maintainers, just agreed about that on
 IRC.

 This would help for instance for
 https://issues.jenkins-ci.org/browse/JENKINS-51986 which I'm currently
 working on, and other JIRAs for the upcoming weeks.

 Also filed https://issues.jenkins-ci.org/browse/INFRA-1853 for
 tracking purpose.

 Thanks!
 ___
 Jenkins-infra mailing list
 jenkins-in...@lists.jenkins-ci.org
 http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra

>>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBOyX%3Dz2hvZKhybim-GGnebkNMRhGWSk33R%2B-z-rD0_Cw%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4TEFgSwD4%2BgGmsO%3DSRqq0%3DgYmFnh4500eOKSA7_ox5_Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Build failure analyzer] Request commit access

2018-11-16 Thread Robert Sandell
I've been very busy with other things the last few months so I've been
neglecting my maintainer duties, but I'm slowly coming back and working off
my code review backlog.

/B

Den tis 13 nov. 2018 kl 21:36 skrev Tim Jacomb :

> CC maintainers
>
> On Tue, 13 Nov 2018 at 20:31, Tim Jacomb  wrote:
>
>> Hi
>>
>> I would like to request commit access for the build failure analyzer
>> plugin
>>
>> I would like to clean it up and do some more development on it
>>
>> Github: timja
>> Jenkins infra: timja
>>
>> Thanks
>> Tim
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/9b7b01f8-5252-4af7-ba9f-c303c130209c%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
*Robert Sandell*
Software Engineer
CloudBees, Inc.
[image: CloudBees-Logo.png] 
E: rsand...@cloudbees.com
Twitter: robert_sandell

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2VF69gNCJhjDybNHc5aHT6NqNTBvgd%3DO8PkJ8Wd-HZLA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Jenkins-infra] Request Jenkins Docker Hub admin access

2018-11-16 Thread Oleg Nenashev
Hi Baptiste,

Apparently I have no admin access to the old jenkinsci organization in
DockerHub.
Do you want to have admin permissions there as well?

BR, Oleg


On Fri, Nov 16, 2018 at 10:44 AM Oleg Nenashev 
wrote:

> Got +1 from Olivier in the INFRA ticket.
> I consider this request as approved, and I will grant permissions to
> Baptiste.
>
> Best regards,
> Oleg
>
>
> On Mon, Nov 12, 2018 at 3:36 PM Oleg Nenashev 
> wrote:
>
>> +1 from me. Baptiste has Jenkins core merge access and CLA signed. Also,
>> he is a Master Docker image miantainer now. I believe this access is
>> totally fine.
>>
>> BR, Oleg
>>
>> On Mon, Nov 12, 2018 at 3:28 PM Baptiste Mathus  wrote:
>>
>>> (cross-posting to dev and infra for transparency)
>>>
>>> Hello,
>>>
>>> As per my current work on making Jenkins work on Java 11, I would like
>>> to request access to the Jenkins account admin on Docker hub.
>>>
>>> Oleg, being one of the active maintainers, just agreed about that on IRC.
>>>
>>> This would help for instance for
>>> https://issues.jenkins-ci.org/browse/JENKINS-51986 which I'm currently
>>> working on, and other JIRAs for the upcoming weeks.
>>>
>>> Also filed https://issues.jenkins-ci.org/browse/INFRA-1853 for tracking
>>> purpose.
>>>
>>> Thanks!
>>> ___
>>> Jenkins-infra mailing list
>>> jenkins-in...@lists.jenkins-ci.org
>>> http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBOyX%3Dz2hvZKhybim-GGnebkNMRhGWSk33R%2B-z-rD0_Cw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Jenkins-infra] Request Jenkins Docker Hub admin access

2018-11-16 Thread Oleg Nenashev
Got +1 from Olivier in the INFRA ticket.
I consider this request as approved, and I will grant permissions to
Baptiste.

Best regards,
Oleg


On Mon, Nov 12, 2018 at 3:36 PM Oleg Nenashev 
wrote:

> +1 from me. Baptiste has Jenkins core merge access and CLA signed. Also,
> he is a Master Docker image miantainer now. I believe this access is
> totally fine.
>
> BR, Oleg
>
> On Mon, Nov 12, 2018 at 3:28 PM Baptiste Mathus  wrote:
>
>> (cross-posting to dev and infra for transparency)
>>
>> Hello,
>>
>> As per my current work on making Jenkins work on Java 11, I would like to
>> request access to the Jenkins account admin on Docker hub.
>>
>> Oleg, being one of the active maintainers, just agreed about that on IRC.
>>
>> This would help for instance for
>> https://issues.jenkins-ci.org/browse/JENKINS-51986 which I'm currently
>> working on, and other JIRAs for the upcoming weeks.
>>
>> Also filed https://issues.jenkins-ci.org/browse/INFRA-1853 for tracking
>> purpose.
>>
>> Thanks!
>> ___
>> Jenkins-infra mailing list
>> jenkins-in...@lists.jenkins-ci.org
>> http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBHQt2if0-eCkpBuHk75H971K72qK3oLa%2B23FXoYe-ihg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Request cn.jenkins.io write permission

2018-11-16 Thread QIANG LAIN
Hi
There are only one Chinese speaker has the write permission in the team, so
we need two person at least to review and merge the PR timely.

As a member in Chinese-localization-sig, i would like to request the write
permission in this repo.

Github: xuesea

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAKiPr%2BGr9LpYp5tdg6cJrLZ0pd4AvodrJFQqx3prLi%3D9L8KmHg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.