Re: Guideline for upgrading plugin to JDK 9+

2019-10-22 Thread Daniel Beck



> On 21. Oct 2019, at 23:39, Damian Szczepanik  
> wrote:
> 
> I had to upgrade org.jenkins-ci.plugins:plugin what also upgrades property 
> jenkins.version so I expect that some older Jenkins installations won't be 
> able to see new version via plugin manager?

You can choose an older baseline by overriding the property, but it's probably 
not really necessary. We know from usage statistics what combinations of 
(Jenkins version x plugin version) are in use. IMO, 2.138.4 is currently a very 
conservative baseline -- Jenkins update sites don't really support anything 
older either.

For example for cucumber-reports[1], version 4.5.0 was released about 7 months 
ago, and 92% of its users are on 2.138.4 or newer, with even higher percentages 
for more recent plugin releases. People who don't update Jenkins generally 
don't update plugins either, so there's usually little reason to stick to old 
baselines.

1: https://stats.jenkins.io/pluginversions/cucumber-reports.html

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7F30EE4B-AA49-45C3-8621-68FF7C0AAE57%40beckweb.net.


Re: Guideline for upgrading plugin to JDK 9+

2019-10-21 Thread Damian Szczepanik
Title: Re: Guideline for upgrading plugin to JDK 9+


That pom.xml was helpful.

I had to upgrade org.jenkins-ci.plugins:plugin what also upgrades property jenkins.version so I expect that some older Jenkins installations won't be able to see new version via plugin manager?

Damian






Here is an example on how to suppress those files:

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922






Am 20.10.2019 um 23:37 schrieb Damian Szczepanik <damian.publicem...@gmail.com>:

Re: Guideline for upgrading plugin to JDK 9+ 
I think that's the second option:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ cucumber-reports ---
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2


but then how to skip this particular 'violation' in this dependency? Or maybe discard all such problems?

Damian





You should not change to JDK 9 if not absolutely necessary. 

Did your dependency really change the API to JDK 9? Or did they just compile with JDK 9 and add a module information file which requires the increased class file level? Those files can be ignored in the pom...





Am 20.10.2019 um 23:16 schrieb Damian Szczepanik <damian.publicem...@gmail.com>:

Hi,

After upgrading some plugin dependencies I found that dependency is compiled against JDK 9 while my plugin still uses 8 - compilation has failed.

Is there any recommendation, guideline, best practices that guide about:


Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA perspective Jenkins should be upgraded?
Jenkins does not support 9 so should I upgrade to 11 at least?
Is there any plugin that have been already upgraded and could be taken as good reference how to make it painless?
What I would loose? eg Jenkins with older JDK won't be able to install new version of my plugin


Damian

-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com.


-- 
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com.



-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com.


-- 
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/90CF7B0B-5705-4D1B-A9FE-026165B7229D%40gmail.com.






-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/275338871.20191021233952%40gmail.com.


Re: Guideline for upgrading plugin to JDK 9+

2019-10-21 Thread Matt Sicker
We had to update the enforcer plugin to work around the bug where it was
reading code from META-INF where it's not supposed to. See here for
example:
https://github.com/jenkinsci/audit-log-plugin/blob/master/pom.xml#L202-L214

On Mon, Oct 21, 2019 at 6:08 AM Oleg Nenashev 
wrote:

> Just to add some info about using Java 9+ in plugins
>
> JEP-211 requires plugins to stay on Java 8.
> If necessary, they can indeed go to higher version, but Plugin POM does
> not fully support it. https://github.com/jenkinsci/plugin-pom/pull/133 would
> need to be finished and integrated.
> Note that, even if it is landed, using Java 9+ can cause various
> disruptions for users of old Jenkins core versions before 2.164.x where the
> JDK version metadata was introduced. Also, custom update centers may not
> return this metadata.
>
> On Monday, October 21, 2019 at 10:48:05 AM UTC+2, Ullrich Hafner wrote:
>>
>> Here is an example on how to suppress those files:
>>
>> https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922
>>
>>
>> Am 20.10.2019 um 23:37 schrieb Damian Szczepanik :
>>
>> I think that's the second option:
>>
>> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @
>> cucumber-reports ---
>> [INFO] Restricted to JDK 1.8 yet
>> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile
>> contains module-info.class targeted to 53.0
>> [INFO] Restricted to JDK 1.8 yet
>> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains
>> module-info.class targeted to 53.0
>> [INFO] Restricted to JDK 1.8 yet
>> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains
>> module-info.class targeted to 53.0
>> [INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
>> [WARNING] Rule 2:
>> org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with
>> message:
>> Found Banned Dependency:
>> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
>> Found Banned Dependency:
>> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
>> Found Banned Dependency:
>> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2
>>
>>
>> but then how to skip this particular 'violation' in this dependency? Or
>> maybe discard all such problems?
>>
>> Damian
>>
>>
>> You should not change to JDK 9 if not absolutely necessary.
>>
>> Did your dependency really change the API to JDK 9? Or did they just
>> compile with JDK 9 and add a module information file which requires the
>> increased class file level? Those files can be ignored in the pom...
>>
>>
>> Am 20.10.2019 um 23:16 schrieb Damian Szczepanik :
>>
>> Hi,
>>
>> After upgrading some plugin dependencies I found that dependency is
>> compiled against JDK 9 while my plugin still uses 8 - compilation has
>> failed.
>>
>> Is there any recommendation, guideline, best practices that guide about:
>>
>>1. Should I upgrade the plugin to JDK 9+ or it's not mandatory
>>because from SLA perspective Jenkins should be upgraded?
>>2. Jenkins does not support 9 so should I upgrade to 11 at least?
>>3. Is there any plugin that have been already upgraded and could be
>>taken as good reference how to make it painless?
>>4. What I would loose? eg Jenkins with older JDK won't be able to
>>install new version of my plugin
>>
>> Damian
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkin...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com
>> 
>> . --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkin...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com
>> 
>> .
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkin...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com
>> 
>> .
>>
>>
>> --
> You receiv

Re: Guideline for upgrading plugin to JDK 9+

2019-10-21 Thread Oleg Nenashev
Just to add some info about using Java 9+ in plugins

JEP-211 requires plugins to stay on Java 8.
If necessary, they can indeed go to higher version, but Plugin POM does not 
fully support it. https://github.com/jenkinsci/plugin-pom/pull/133 would 
need to be finished and integrated.
Note that, even if it is landed, using Java 9+ can cause various 
disruptions for users of old Jenkins core versions before 2.164.x where the 
JDK version metadata was introduced. Also, custom update centers may not 
return this metadata.

On Monday, October 21, 2019 at 10:48:05 AM UTC+2, Ullrich Hafner wrote:
>
> Here is an example on how to suppress those files:
>
> https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922
>
>
> Am 20.10.2019 um 23:37 schrieb Damian Szczepanik  >:
>
> I think that's the second option:
>
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ 
> cucumber-reports ---
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile 
> contains module-info.class targeted to 53.0
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains 
> module-info.class targeted to 53.0
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains 
> module-info.class targeted to 53.0
> [INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion 
> failed with message:
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2
>
>
> but then how to skip this particular 'violation' in this dependency? Or 
> maybe discard all such problems?
>
> Damian
>
>
> You should not change to JDK 9 if not absolutely necessary. 
>
> Did your dependency really change the API to JDK 9? Or did they just 
> compile with JDK 9 and add a module information file which requires the 
> increased class file level? Those files can be ignored in the pom...
>
>
> Am 20.10.2019 um 23:16 schrieb Damian Szczepanik  >:
>
> Hi,
>
> After upgrading some plugin dependencies I found that dependency is 
> compiled against JDK 9 while my plugin still uses 8 - compilation has 
> failed.
>
> Is there any recommendation, guideline, best practices that guide about:
>
>1. Should I upgrade the plugin to JDK 9+ or it's not mandatory because 
>from SLA perspective Jenkins should be upgraded? 
>2. Jenkins does not support 9 so should I upgrade to 11 at least? 
>3. Is there any plugin that have been already upgraded and could be 
>taken as good reference how to make it painless? 
>4. What I would loose? eg Jenkins with older JDK won't be able to 
>install new version of my plugin 
>
> Damian
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkin...@googlegroups.com .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com
>  
> 
> . -- 
> You received this message because you are subscribed to a topic in the 
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> jenkin...@googlegroups.com .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com
>  
> 
> . 
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkin...@googlegroups.com .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com
>  
> 
> .
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2386d4a7-9872-478d-b56c-3f91b78

Re: Guideline for upgrading plugin to JDK 9+

2019-10-21 Thread Ullrich Hafner
Here is an example on how to suppress those files:

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922 



> Am 20.10.2019 um 23:37 schrieb Damian Szczepanik 
> :
> 
> I think that's the second option:
> 
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ 
> cucumber-reports ---
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile 
> contains module-info.class targeted to 53.0
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains 
> module-info.class targeted to 53.0
> [INFO] Restricted to JDK 1.8 yet 
> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains 
> module-info.class targeted to 53.0
> [INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion 
> failed with message:
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
> Found Banned Dependency: 
> com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2
> 
> 
> but then how to skip this particular 'violation' in this dependency? Or maybe 
> discard all such problems?
> 
> Damian
> 
> 
> You should not change to JDK 9 if not absolutely necessary. 
> 
> Did your dependency really change the API to JDK 9? Or did they just compile 
> with JDK 9 and add a module information file which requires the increased 
> class file level? Those files can be ignored in the pom...
> 
> 
> Am 20.10.2019 um 23:16 schrieb Damian Szczepanik 
> mailto:damian.publicem...@gmail.com>>:
> 
> Hi,
> 
> After upgrading some plugin dependencies I found that dependency is compiled 
> against JDK 9 while my plugin still uses 8 - compilation has failed.
> 
> Is there any recommendation, guideline, best practices that guide about:
> Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA 
> perspective Jenkins should be upgraded?
> Jenkins does not support 9 so should I upgrade to 11 at least?
> Is there any plugin that have been already upgraded and could be taken as 
> good reference how to make it painless?
> What I would loose? eg Jenkins with older JDK won't be able to install new 
> version of my plugin
> Damian
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com
>  
> .
> -- 
> You received this message because you are subscribed to a topic in the Google 
> Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe 
> .
> To unsubscribe from this group and all its topics, send an email to 
> jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/90CF7B0B-5705-4D1B-A9FE-026165B7229D%40gmail.com.


Re: Guideline for upgrading plugin to JDK 9+

2019-10-20 Thread 'Gavin Mogan' via Jenkins Developers
> Should I upgrade the plugin to JDK 9+ or it's not mandatory because from
SLA perspective Jenkins should be upgraded?
I believe jenkins core is still minimum requirement of java 8. According to
https://jenkins.io/doc/administration/requirements/java/ 9 and 10 are
explicitly not supported. So combined with your last question, you could
potentially have users that can't use your plugin. I believe there's ways
to mark your plugin as 11 only.

> Jenkins does not support 9 so should I upgrade to 11 at least?
if you use buildPlugin() jenkins ci will test using 8 and 11, you can
probably use 9, but i would personally skip 9 and goto 11

> Is there any plugin that have been already upgraded and could be taken as
good reference how to make it painless?
When I upgraded blueocean, it was mostly fixing the tests and setting the
serialization whitelist.

https://wiki.jenkins.io/display/JENKINS/Java+11+Developer+Guidelines has a
lot of info

On Sun, Oct 20, 2019 at 2:16 PM Damian Szczepanik <
damian.publicem...@gmail.com> wrote:

> Hi,
>
> After upgrading some plugin dependencies I found that dependency is
> compiled against JDK 9 while my plugin still uses 8 - compilation has
> failed.
>
> Is there any recommendation, guideline, best practices that guide about:
>
>1. Should I upgrade the plugin to JDK 9+ or it's not mandatory because
>from SLA perspective Jenkins should be upgraded?
>2. Jenkins does not support 9 so should I upgrade to 11 at least?
>3. Is there any plugin that have been already upgraded and could be
>taken as good reference how to make it painless?
>4. What I would loose? eg Jenkins with older JDK won't be able to
>install new version of my plugin
>
> Damian
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DuvXsQX_xF6gnTEoH%2B9sjVJs%3DF7VkvQfJqb2H%3DAfTYvq9w%40mail.gmail.com.


Re: Guideline for upgrading plugin to JDK 9+

2019-10-20 Thread Damian Szczepanik
Title: Re: Guideline for upgrading plugin to JDK 9+


I think that's the second option:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ cucumber-reports ---
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2


but then how to skip this particular 'violation' in this dependency? Or maybe discard all such problems?

Damian





You should not change to JDK 9 if not absolutely necessary. 

Did your dependency really change the API to JDK 9? Or did they just compile with JDK 9 and add a module information file which requires the increased class file level? Those files can be ignored in the pom...





Am 20.10.2019 um 23:16 schrieb Damian Szczepanik <damian.publicem...@gmail.com>:

Hi,

After upgrading some plugin dependencies I found that dependency is compiled against JDK 9 while my plugin still uses 8 - compilation has failed.

Is there any recommendation, guideline, best practices that guide about:


Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA perspective Jenkins should be upgraded?
Jenkins does not support 9 so should I upgrade to 11 at least?
Is there any plugin that have been already upgraded and could be taken as good reference how to make it painless?
What I would loose? eg Jenkins with older JDK won't be able to install new version of my plugin

Damian

-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com.


-- 
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com.






-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com.


Re: Guideline for upgrading plugin to JDK 9+

2019-10-20 Thread Ullrich Hafner
You should not change to JDK 9 if not absolutely necessary. 

Did your dependency really change the API to JDK 9? Or did they just compile 
with JDK 9 and add a module information file which requires the increased class 
file level? Those files can be ignored in the pom...

> Am 20.10.2019 um 23:16 schrieb Damian Szczepanik 
> :
> 
> Hi,
> 
> After upgrading some plugin dependencies I found that dependency is compiled 
> against JDK 9 while my plugin still uses 8 - compilation has failed.
> 
> Is there any recommendation, guideline, best practices that guide about:
> Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA 
> perspective Jenkins should be upgraded?
> Jenkins does not support 9 so should I upgrade to 11 at least?
> Is there any plugin that have been already upgraded and could be taken as 
> good reference how to make it painless?
> What I would loose? eg Jenkins with older JDK won't be able to install new 
> version of my plugin
> Damian
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com.