Re: ReviewBoard and our workflow
For switching to a new tool and a new workflow I would like to not simply discuss it in a somehow undefined way together with subjunctive terms (Everybody should now ...) here via mail. Please lets fix the workflow in a how-to-contribute.md in juju/doc/contributions, so that we easily can point any new internal and external contributor to it. And also let's have a well defined date for switching and communicate it early enough. If somebode is already writing this doc mentioned above please let me know. Otherwise I'll do it. thx mue On Wed, Sep 10, 2014 at 11:47 PM, Eric Snow eric.s...@canonical.com wrote: On Wed, Sep 10, 2014 at 3:34 PM, Menno Smits menno.sm...@canonical.com wrote: Thanks Eric! I've used Reviewboard at a previous job and I'm fairly sure that it aligns better with the way the Juju Core team likes to work than Github's review features. Two questions: 1. Is this what we're supposed to be doing from right now? Nope. I'm hopeful that we will switch over to reviewboard in a week or two. Until then github is still our review tool. However, in the meantime feel free to try out the Reviewboard-oriented workflow as well. :) 2. I'm pretty sure some configuration of the rbt tool is required so that it knows how to talk to the Reviewboard server. Is there a config file available? The first time in a repo you run rbt setup-repo which generates a user-agnostic, repo-specific .reviewboardrc file. I expect that before long we will commit that file in each of our repos. Once that happens, no one will have to do anything special (e.g. run rbt setup-repo) any longer. See https://www.reviewboard.org/docs/rbtools/dev/rbt/configuration/ -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev -- ** Frank Mueller frank.muel...@canonical.com ** Software Engineer - Juju Development ** Canonical -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: ReviewBoard and our workflow
On Thu, Sep 11, 2014 at 1:34 AM, Frank Mueller frank.muel...@canonical.com wrote: For switching to a new tool and a new workflow I would like to not simply discuss it in a somehow undefined way together with subjunctive terms (Everybody should now ...) here via mail. Please lets fix the workflow in a how-to-contribute.md in juju/doc/contributions, so that we easily can point any new internal and external contributor to it. And also let's have a well defined date for switching and communicate it early enough. If somebode is already writing this doc mentioned above please let me know. Otherwise I'll do it. Hi Frank, I was planning on updating https://github.com/juju/juju/blob/master/CONTRIBUTING.md once I felt comfortable with how reviewboard fit into our workflow. Do you think something in juju/doc/contributions, which perhaps elaborates on the info in CONTRIBUTING.md, would be a worthy addition? Thanks for bringing this up, by the way. :) -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: ReviewBoard and our workflow
Hi Eric, I was planning on updating https://github.com/juju/juju/blob/master/CONTRIBUTING.md once I felt comfortable with how reviewboard fit into our workflow. Do you think something in juju/doc/contributions, which perhaps elaborates on the info in CONTRIBUTING.md, would be a worthy addition? Thanks for bringing this up, by the way. :) Oh, I have to thank you. Being focussed on the doc directory I simply fogot the standard CONTRIBUTING file. Maybe, if it grows more and more, it is worth to see this document as a central and quick entry point with references into the specific and detailed documents in doc/contributions. So let's start with your idea, I'll see how the doc grows and when it makes sense to distribute the content into individual files. thx mue -- ** Frank Mueller frank.muel...@canonical.com ** Software Engineer - Juju Development ** Canonical -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: ReviewBoard and our workflow
Thanks Eric! I've used Reviewboard at a previous job and I'm fairly sure that it aligns better with the way the Juju Core team likes to work than Github's review features. Two questions: 1. Is this what we're supposed to be doing from right now? 2. I'm pretty sure some configuration of the rbt tool is required so that it knows how to talk to the Reviewboard server. Is there a config file available? On 11 September 2014 03:58, Eric Snow eric.s...@canonical.com wrote: Steps for a review of a PR: 1. create pull request in github 2. run rbt post while at your branch to create a review request [1][2] 3. open the review request in your browser and publish it [3] 4. add a comment to the PR with a link to the review request 5. address reviews until you get a Ship It! 6. add a $$merge$$ comment to the PR Both github and ReviewBoard support various triggers/hooks and both have robust HTTP APIs. So we should be able to automate those steps (e.g. PR - review request, ship it - $$merge$$). However, I don't see that automation as a prerequisite for switching over to ReviewBoard. Updating an existing review request: 1. run rbt post -u (or the explicit rbt post -r #) 2. open the review request in your browser and publish it [3] FYI, Reviewboard supports chaining review requests. Run rbt post --parent parent branch. I'll be updating the contributing doc relative to ReviewBoard (i.e. with the above info) once we settle in with the new tool. -eric [1] Make sure your branch is based on upstream master. Otherwise this will not work right. [2] Reviewboard links revision IDs to review requests. So if you already have a review request for a particular revision (e.g. your branch), then rbt post will fail. Use rbt post -u or rbt post -r # instead. [3] rbt post has some options you should consider using: - automatically publish the review request: rbt post --publish (or -p) - open a browser window with the new review request: rbt post --open (or -o) -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: ReviewBoard and our workflow
On Wed, Sep 10, 2014 at 3:34 PM, Menno Smits menno.sm...@canonical.com wrote: Thanks Eric! I've used Reviewboard at a previous job and I'm fairly sure that it aligns better with the way the Juju Core team likes to work than Github's review features. Two questions: 1. Is this what we're supposed to be doing from right now? Nope. I'm hopeful that we will switch over to reviewboard in a week or two. Until then github is still our review tool. However, in the meantime feel free to try out the Reviewboard-oriented workflow as well. :) 2. I'm pretty sure some configuration of the rbt tool is required so that it knows how to talk to the Reviewboard server. Is there a config file available? The first time in a repo you run rbt setup-repo which generates a user-agnostic, repo-specific .reviewboardrc file. I expect that before long we will commit that file in each of our repos. Once that happens, no one will have to do anything special (e.g. run rbt setup-repo) any longer. See https://www.reviewboard.org/docs/rbtools/dev/rbt/configuration/ -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
