Re: [JPP-Devel] About turning non-visible layer into non-editable
good point. so mainly we are talking prohibiting CursorTools to edit invisible layers. maybe we should think smaller and just change the way CursorTools determine the layer to edit. ..ede On 19.10.2016 11:20, Rahkonen Jukka (MML) wrote: > Hi, > > Trying to think how we actually edit layers: > > - from the map > - from attribute window > - with tools which edit attributes and geometries in place > > Isn't it only when doing edits from the map when the layer really must be > visible? > > -Jukka- > > edgar.soldin wrote: > >> Mike, > >> had a quick look. simplest approach might be just editing >> AbstractLayerable.isEditable() to always return boolean sum of editable && >> visible, no? all layerables i know are based on AbstractLayerable. > >> plugins probably all use TreeLayerNamePanel.chooseEditableLayer() *but* do >> not have to. so there is a slight chance that code would edit the layer >> anyway, because it still sees it as editable and didn't use the >> chooseEditableLayer() to retrieve it. > >> ..ede > > On 18.10.2016 21:23, Michaël Michaud wrote: >>> Hi all, >>> >>> Thank you for your feedback, >>> >>> I made a second attempt to solve the problem in a more conservative way >>> (r5083+). >>> >>> Instead of making invisible layers uneditable, I changed the method >>> chooseEditableLayer used by most editing tools so that it does not choose >>> invisible layers any more. >>> Now, you can let invisible layer editable, but editing tools will never use >>> it until you make it visible again. >>> >>> Let me know what you think, >>> >>> Michaël >>> >> >> Le 18/10/2016 à 15:06, Stefan Steiniger a écrit : >>> >>> I think I somewhat agree with Jukka. I also look once in while what is >>> underneath by shortly making it invisible... >>> >>> stefan >>> >>> >>> On 10/18/16 09:56, Rahkonen Jukka (MML) wrote: Hi, I agree that it is logically good that non-visible layer is not editable because I can't imagine a real world use case where it would be better to create features without seeing the other features of the layer. However, sometimes it is useful to switch the layer off and have a look under the existing lines and polygons which are covering the background. Now turning layer non-visible turns it also into non-editable and user must re-activate the edit mode. I am not sure if this automatic switch to non-editable is an improvement or not. With the current default "only one editable layer at a time" the risk to digitize features into a non-visible layer by accident is not so big because of the radio button behavior. If user starts to edit some other layer the non-visible layer turns into non-editable anyway. -Jukka Rahkonen- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>> >>> >>> >>> - >>> - Check out the vibrant tech community on one of the world's >>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot >>> >>> >>> ___ >>> Jump-pilot-devel mailing list >>> Jump-pilot-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> >> -- >> Check out the vibrant tech community on one of the world's >> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot >> >> >> >> ___ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> > > -- > Check out the vibrant tech community on one of the world's most engaging tech > sites, SlashDot.org! http://sdm.link/slashdot > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >
Re: [JPP-Devel] About turning non-visible layer into non-editable
Hi, Trying to think how we actually edit layers: - from the map - from attribute window - with tools which edit attributes and geometries in place Isn't it only when doing edits from the map when the layer really must be visible? -Jukka- edgar.soldin wrote: > Mike, > had a quick look. simplest approach might be just editing > AbstractLayerable.isEditable() to always return boolean sum of editable && > visible, no? all layerables i know are based on AbstractLayerable. > plugins probably all use TreeLayerNamePanel.chooseEditableLayer() *but* do > not have to. so there is a slight chance that code would edit the layer > anyway, because it still sees it as editable and didn't use the > chooseEditableLayer() to retrieve it. >..ede On 18.10.2016 21:23, Michaël Michaud wrote: >> Hi all, >> >> Thank you for your feedback, >> >> I made a second attempt to solve the problem in a more conservative way >> (r5083+). >> >> Instead of making invisible layers uneditable, I changed the method >> chooseEditableLayer used by most editing tools so that it does not choose >> invisible layers any more. >> Now, you can let invisible layer editable, but editing tools will never use >> it until you make it visible again. >> >> Let me know what you think, >> >> Michaël >> > > Le 18/10/2016 à 15:06, Stefan Steiniger a écrit : >> >> I think I somewhat agree with Jukka. I also look once in while what is >> underneath by shortly making it invisible... >> >> stefan >> >> >> On 10/18/16 09:56, Rahkonen Jukka (MML) wrote: >>> >>> Hi, >>> >>> >>> >>> I agree that it is logically good that non-visible layer is not editable >>> because I can't imagine a real world use case where it would be better to >>> create features without seeing the other features of the layer. However, >>> sometimes it is useful to switch the layer off and have a look under the >>> existing lines and polygons which are covering the background. Now turning >>> layer non-visible turns it also into non-editable and user must re-activate >>> the edit mode. I am not sure if this automatic switch to non-editable is >>> an improvement or not. With the current default "only one editable layer at >>> a time" the risk to digitize features into a non-visible layer by accident >>> is not so big because of the radio button behavior. If user starts to edit >>> some other layer the non-visible layer turns into non-editable anyway. >>> >>> >>> >>> -Jukka Rahkonen- >>> >>> >>> >>> >>> >>> >>> >>> >>> -- Check out the vibrant tech community on one of the >>> world's most engaging tech sites, SlashDot.org! >>> http://sdm.link/slashdot >>> >>> >>> ___ >>> Jump-pilot-devel mailing list >>> Jump-pilot-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> >> - >> - Check out the vibrant tech community on one of the world's >> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot >> >> >> ___ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > -- > Check out the vibrant tech community on one of the world's > most engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > > > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] About turning non-visible layer into non-editable
Mike, had a quick look. simplest approach might be just editing AbstractLayerable.isEditable() to always return boolean sum of editable && visible, no? all layerables i know are based on AbstractLayerable. plugins probably all use TreeLayerNamePanel.chooseEditableLayer() *but* do not have to. so there is a slight chance that code would edit the layer anyway, because it still sees it as editable and didn't use the chooseEditableLayer() to retrieve it. ..ede On 18.10.2016 21:23, Michaël Michaud wrote: > Hi all, > > Thank you for your feedback, > > I made a second attempt to solve the problem in a more conservative way > (r5083+). > > Instead of making invisible layers uneditable, I changed the method > chooseEditableLayer used by most editing tools so that it does not choose > invisible layers any more. > Now, you can let invisible layer editable, but editing tools will never use > it until you make it visible again. > > Let me know what you think, > > Michaël > > > Le 18/10/2016 à 15:06, Stefan Steiniger a écrit : >> >> I think I somewhat agree with Jukka. I also look once in while what is >> underneath by shortly making it invisible... >> >> stefan >> >> >> On 10/18/16 09:56, Rahkonen Jukka (MML) wrote: >>> >>> Hi, >>> >>> >>> >>> I agree that it is logically good that non-visible layer is not editable >>> because I can’t imagine a real world use case where it would be better to >>> create features without seeing the other features of the layer. However, >>> sometimes it is useful to switch the layer off and have a look under the >>> existing lines and polygons which are covering the background. Now turning >>> layer non-visible turns it also into non-editable and user must re-activate >>> the edit mode. I am not sure if this automatic switch to non-editable is >>> an improvement or not. With the current default “only one editable layer at >>> a time” the risk to digitize features into a non-visible layer by accident >>> is not so big because of the radio button behavior. If user starts to edit >>> some other layer the non-visible layer turns into non-editable anyway. >>> >>> >>> >>> -Jukka Rahkonen- >>> >>> >>> >>> >>> >>> >>> >>> -- >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot >>> >>> >>> ___ >>> Jump-pilot-devel mailing list >>> Jump-pilot-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot >> >> >> ___ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > > > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] About turning non-visible layer into non-editable
Hi all, Thank you for your feedback, I made a second attempt to solve the problem in a more conservative way (r5083+). Instead of making invisible layers uneditable, I changed the method chooseEditableLayer used by most editing tools so that it does not choose invisible layers any more. Now, you can let invisible layer editable, but editing tools will never use it until you make it visible again. Let me know what you think, Michaël Le 18/10/2016 à 15:06, Stefan Steiniger a écrit : I think I somewhat agree with Jukka. I also look once in while what is underneath by shortly making it invisible... stefan On 10/18/16 09:56, Rahkonen Jukka (MML) wrote: Hi, I agree that it is logically good that non-visible layer is not editable because I can’t imagine a real world use case where it would be better to create features without seeing the other features of the layer. However, sometimes it is useful to switch the layer off and have a look under the existing lines and polygons which are covering the background. Now turning layer non-visible turns it also into non-editable and user must re-activate the edit mode. I am not sure if this automatic switch to non-editable is an improvement or not. With the current default “only one editable layer at a time” the risk to digitize features into a non-visible layer by accident is not so big because of the radio button behavior. If user starts to edit some other layer the non-visible layer turns into non-editable anyway. -Jukka Rahkonen- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org!http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] About turning non-visible layer into non-editable
I think I somewhat agree with Jukka. I also look once in while what is underneath by shortly making it invisible... stefan On 10/18/16 09:56, Rahkonen Jukka (MML) wrote: Hi, I agree that it is logically good that non-visible layer is not editable because I can’t imagine a real world use case where it would be better to create features without seeing the other features of the layer. However, sometimes it is useful to switch the layer off and have a look under the existing lines and polygons which are covering the background. Now turning layer non-visible turns it also into non-editable and user must re-activate the edit mode. I am not sure if this automatic switch to non-editable is an improvement or not. With the current default “only one editable layer at a time” the risk to digitize features into a non-visible layer by accident is not so big because of the radio button behavior. If user starts to edit some other layer the non-visible layer turns into non-editable anyway. -Jukka Rahkonen- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] About turning non-visible layer into non-editable
On 18.10.2016 14:56, Rahkonen Jukka (MML) wrote: > Hi, > > > > I agree that it is logically good that non-visible layer is not editable > because I can’t imagine a real world use case where it would be better to > create features without seeing the other features of the layer. However, > sometimes it is useful to switch the layer off and have a look under the > existing lines and polygons which are covering the background. Now turning > layer non-visible turns it also into non-editable and user must re-activate > the edit mode. I am not sure if this automatic switch to non-editable is an > improvement or not. With the current default “only one editable layer at a > time” the risk to digitize features into a non-visible layer by accident is > not so big because of the radio button behavior. If user starts to edit some > other layer the non-visible layer turns into non-editable anyway. > i'd say this is unintuitive and turning the layer back "on" should restore the previous editable state. we do something comparable when switching a category's visibility on/off already. ..ede -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] About turning non-visible layer into non-editable
Hi, I agree that it is logically good that non-visible layer is not editable because I can't imagine a real world use case where it would be better to create features without seeing the other features of the layer. However, sometimes it is useful to switch the layer off and have a look under the existing lines and polygons which are covering the background. Now turning layer non-visible turns it also into non-editable and user must re-activate the edit mode. I am not sure if this automatic switch to non-editable is an improvement or not. With the current default "only one editable layer at a time" the risk to digitize features into a non-visible layer by accident is not so big because of the radio button behavior. If user starts to edit some other layer the non-visible layer turns into non-editable anyway. -Jukka Rahkonen- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
