[gwenview] [Bug 387784] Sidebar in fullscreen "View" mode moves buttons out of view
https://bugs.kde.org/show_bug.cgi?id=387784 --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- You certainly have not read the article in one minute ;) I think your definition is too broad. A missing button would be a usability issue. However, here we already have solved the usability design problem years ago and it was now only a task for the software engineers to fix a glitch. Usability engineering is about applying specific methods to diagnose problems and propose changes in design, not about Q Anyway, that was a bit off-topic. Thanks for your work ;) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387784] Sidebar in fullscreen "View" mode moves buttons out of view
https://bugs.kde.org/show_bug.cgi?id=387784 --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- > Keywords||usability Nate: I know you add this for tracking in https://phabricator.kde.org/T6831, but I always cringe a little because bug fixes are not always about usability in a strict sense (https://en.wikipedia.org/wiki/Usability). As far as I see it would be useful to leave this keyword for cases where input from an actual usability expert is needed and tag the goal with another keyword? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383093] [proposal] Gwenview should remember full-screen mode state
https://bugs.kde.org/show_bug.cgi?id=383093 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- Possibly related in one way or another: Bug 195046 Bug 387782 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383093] [proposal] Gwenview should remember full-screen mode state
https://bugs.kde.org/show_bug.cgi?id=383093 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- A recent patch sparked a discussion on the topic, see https://phabricator.kde.org/D10207#199393. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 389691] Ambiguous shortcut warning when pressing Ctrl+Q, Ctrl+S or Ctrl+Shift+S
https://bugs.kde.org/show_bug.cgi?id=389691 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for testing. I guess you'd have to enable "Remember last used save mode" in the settings. You are right: The first (or second, if the last used mode was different from save) Ctrl+S brings Spectacle in a bad state, after which a subsequent Ctrl+Q or Ctrl+S does not work anymore. Same thing for pressing two/three times Ctrl+Shift+S. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 372408] Option to omit shadow and transparent border from windows in Active Window and Window Under Cursor modes
https://bugs.kde.org/show_bug.cgi?id=372408 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- I agree there should be an option to disable shadows in screenshots. As a workaround, just disable compositing temporarily, e.g. by pressing Shift+Alt+F12. Alternatively, disable "Include window titlebar and borders" if applicable in your use case. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 375965] Move configure button out of the Save combo button
https://bugs.kde.org/show_bug.cgi?id=375965 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Simone: I know you have an interest in usability. Hop over to https://phabricator.kde.org/T7841 in case you'd like to contribute good ideas or even patches. (And sorry I haven't got around to your "Open With" Diff yet, I did not forget!). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 233359] Allow to start Gwenview in Browse mode showing a custom directory instead of showing the Start Page
https://bugs.kde.org/show_bug.cgi?id=233359 --- Comment #6 from Henrik Fehlauer <rk...@lab12.net> --- > But when you create a command line option, how do you tell users about it? $ gwenview -h Usage: gwenview [options] url [...] Arguments: urlA starting file or folders (Besides that, this is standard behaviour pretty much every app supports.) I'll leave the Bug open for now. Maybe we get more opinions on the matter in the meanwhile or perhaps even someone sends a patch. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 233359] Allow to start Gwenview in Browse mode showing a custom directory instead of showing the Start Page
https://bugs.kde.org/show_bug.cgi?id=233359 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Summary|Start Page needs|Allow to start Gwenview in |configuration option|Browse mode showing a ||custom directory instead of ||showing the Start Page --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Well, they're not useless. I guess the question is whether we consider starting Gwenview in a directory an expert feature (for experts creating a custom launcher is a piece of cake) or an option so important for the regular use case we have to expose a setting in the GUI. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 196017] Put all content in the tabbed sidebar into a single-non-tabbed view, and allow each section to be collapsed and re-ordered
https://bugs.kde.org/show_bug.cgi?id=196017 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- I'd rather apply the standard UI paradigm for this, which is even more flexible as it allows multiple ways to layout. See Bug 196016#c2. Having all options in a single list gets fiddly very fast, because the click targets are not in a predictable location anymore and you may end up with lots of scrolling for long lists. (Imagine Firefox would do that for its main tab bar…) -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 376799] Spectacle crashes kwin
https://bugs.kde.org/show_bug.cgi?id=376799 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- It would be helpful if you could test again with a recent version and indicate what settings you are using in Spectacle (and possibly your graphics driver). -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 371768] Screenshot of "Window under cursor" of plasma applet show other part of the desktop
https://bugs.kde.org/show_bug.cgi?id=371768 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #6 from Henrik Fehlauer <rk...@lab12.net> --- It's still not working quite right with Spectacle 17.12.1 and Qt 5.10.1, i.e. trying to capture a menu popup (2 seconds delay, "Capture the current pop-up only" checked) will show an incorrect area of the screen. See also Bug 374864#c1. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 374864] Using "Capture the current pop-up only" option causes Spectacle to disappear
https://bugs.kde.org/show_bug.cgi?id=374864 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- I noticed this too with Spectacle 17.12.1 and Qt 5.10.1. However, turning compositing off will capture something instead of getting stuck. Unfortunately it's not the area of the screen I was interested in. See also Bug 371768. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 377038] Spectacle crashes when the option "Rectangular Region" is selected.
https://bugs.kde.org/show_bug.cgi?id=377038 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- Cannot reproduce with Spectacle 17.12.1 and Qt 5.10.1. Please retest with a recent version and possibly switch to a non-proprietary driver, so we can narrow down the issue. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 389695] New: Save action should show Plasma popup just like Save & Exit
https://bugs.kde.org/show_bug.cgi?id=389695 Bug ID: 389695 Summary: Save action should show Plasma popup just like Save & Exit Product: Spectacle Version: 17.12.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: General Assignee: m...@baloneygeek.com Reporter: rk...@lab12.net Target Milestone: --- Currently clicking on "Save & Exit" results in an Plasma notification showing a thumbnail and allowing to open the corresponding folder. Hitting "Save", we don't get that. I don't get why we assume a user knows where the screenshot is saved in one case, but not in the other. Nevertheless, maybe it's not an oversight and the behaviour is intentional (did not check yet). -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 389694] New: Spectacle sometimes does not return to the shell prompt
https://bugs.kde.org/show_bug.cgi?id=389694 Bug ID: 389694 Summary: Spectacle sometimes does not return to the shell prompt Product: Spectacle Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: General Assignee: m...@baloneygeek.com Reporter: rk...@lab12.net Target Milestone: --- - $ spectacle - Save & Exit - "Configure Notifications" in Plasma popup, Cancel - spectacle keeps running in the shell (while I'd expect it to exit instead of hiding only) Even when not opening the config dialog, the shell prompt does not return immediately but only when the popup is hidden again. Is there any reason the popup is tied to Spectacle running in the background? -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 389691] New: Ambiguous shortcut warning when pressing Ctrl+Q, Ctrl+S or Ctrl+Shift+S
https://bugs.kde.org/show_bug.cgi?id=389691 Bug ID: 389691 Summary: Ambiguous shortcut warning when pressing Ctrl+Q, Ctrl+S or Ctrl+Shift+S Product: Spectacle Version: 17.12.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: General Assignee: m...@baloneygeek.com Reporter: rk...@lab12.net Target Milestone: --- Ctrl+Q should quit Spectacle instead of presenting said warning and doing nothing, same thing for saving (as) with Ctrl+S (Ctrl+Shift+S). I haven't looked too much into it, but it seems this also depends on whether you freshly started Spectacle or already saved something. Basically, Spectacle should always behave sane instead of only sometimes. See also Bug 362061 and Bug 388592, but respecting the standard shortcuts would be fine for a start. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 73620] It would be nice if it didn't go to browsing mode after fullscreen
https://bugs.kde.org/show_bug.cgi?id=73620 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED CC||rk...@lab12.net --- Comment #7 from Henrik Fehlauer <rk...@lab12.net> --- There are multiple issues here, which should not be mixed up: > I I click on an image from Konqueror it turns up nicely in Gwenview, > but when you hit Esc it should go back to Konqueror > and not to Gwenview's browsing mode. That's asking more for a "Quick Look" feature, try looking around if you can find a bug or and perhaps even an app for that. If you want Gwenview to behave like that, you have to reconfigure the shortcut for Quit, as Holger points out. This can even be Escape starting with Gwenview 18.04, because Bug 385242 was fixed recently. > I would also appreciate it if ending a slide show didn't end > up going back to the window mode too. Especially if the > slide show was started in fullscreen mode. Not sure what you mean by that. When a slideshow ends, it just sits there, independently of where it was started. You can press F11 (back to windowed view mode), Escape (back to fullscreen browse mode) or Ctrl-Q (close Gwenview). (← Note my comment applies to the revamped Gwenview UI, the KDE3 version was probably different.) > the -fq argument would tell to gwenview to quit after escape is pushed. That would mean implementing two different behaviours, making the code quite complex. As a command line option is an expert feature, an expert user could also just set the custom shortcut I just mentioned. > that -fq should also be as default setting I disagree, exiting Gwenview by accidently pressing Escape in fullscreen is not want regular users expect. > i would find it more convenient when you could go back to browsing mode > from both fullscreen and windowed viewing by pressing one key That's already implemented, you can press Enter or Escape. The patch for Bug 305659 will allow to press Escape twice to even exit from fullscreen browse to normal browse. > launch a picture directly in fullscreen (or not), from konqueror Create a custom launcher and use the "-f" option. --- Closing as FIXED for now, because as far as I can see Gwenview will support all use cases brought up here. Also, having so many different things in one bug is not really actionable. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails
https://bugs.kde.org/show_bug.cgi?id=164847
--- Comment #8 from Henrik Fehlauer <rk...@lab12.net> ---
Indeed ("Show selection marker" – TIL).
I think then I would be fine with having the config option.
Perhaps this bug is a good case to point future contributors to, as it is easy
with very tangible results? (hint, hint ;)
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails
https://bugs.kde.org/show_bug.cgi?id=164847 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Keywords||junior-jobs CC||rk...@lab12.net Summary|option for turning off |Option for turning off |toolbox |overlay buttons on ||thumbnails --- Comment #6 from Henrik Fehlauer <rk...@lab12.net> --- I'm undecided on this one. I can see why someone would find the buttons annoying. On the other hand, adding yet another config option for something we got only very few complaints about might not be worth it. After all, in Dolphin you have similar buttons to select files. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 324497] Pictures zoomed to "actual size" are distorted when Gwenview is maximized or fullscreen
https://bugs.kde.org/show_bug.cgi?id=324497 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED CC||rk...@lab12.net --- Comment #11 from Henrik Fehlauer <rk...@lab12.net> --- Tested that with a screenshot (both as PNG and JPG) which should make such distortions easily visible, but could not reproduce. I guess this was fixed a while ago. Let us know if it is still a problem with a recent version of Gwenview, then we'd have to reopen the bug. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 146243] Gwenview Preview settings vs Fullsize settings
https://bugs.kde.org/show_bug.cgi?id=146243 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||rk...@lab12.net Resolution|--- |WONTFIX --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Since the KDE3 version your are using, Gwenview's UI was totally revamped. By default, you don't even have zoom controls in fullscreen mode. In general you are expected to switch between different zoom modes in windowed mode, and use fullscreen mode mainly for presenting images (zooming and even adding the controls is still possible, of course, but less prominent). We already have options to choose between how zooming mode applies when navigating between images. Adding yet another dimension to this option by making it configurable separately for fullscreen mode is just too much, the config dialog would be very hard to understand (not even speaking about maintenance cost). We can reconsider if there is a very compelling use case to have this option, but right now I don't see it to be honest. I guess this is supported by the fact that in 11 years this bug has gained no further comments or votes. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 196016] When the thumbnail bar is set to vertical, it should swap position with the existing left panel
https://bugs.kde.org/show_bug.cgi?id=196016 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- We could think about making all sidebars and bottom bars draggable in general, by porting to QDockWidget just like in Dolphin. It's a lot of work, though. This would also improve or even solve Bug 196017 (I'm not sure the all-in-one collapsing thing mentioned there is a good idea, though). Reasons for not choosing a QDockWidget initially are described in http://agateau.com/2007/crop-this-sidebar-edition/, but possibly those are not an issue anymore by now. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 233359] Start Page needs configuration option
https://bugs.kde.org/show_bug.cgi?id=233359 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- I'm still undecided on what to do here. There are two options: 1. Delegate setting an initial directory to show on startup to the .desktop file, by indicating a command line argument (i.e. WONTFIX the bug). Creating that custom launcher works just fine today, however with a small catch: You'd have to create a duplicate launcher / start menu entry in case you still want Gwenview to open when clicking on an image in Dolphin. 2. Make it configurable in the settings, just like in Dolphin. We could design it a bit simpler though, maybe via two radio buttons: "Start page" and "Custom directory" with a directory chooser button, defaulting to ~/Pictures. OTOH, it adds clutter and the "Places" tab on the Start page is not that bad either (I'd rather improve the usability of the Start page a bit). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 359909] Color rendering intent should be user-selectable, not hardcoded to Perceptual
https://bugs.kde.org/show_bug.cgi?id=359909
--- Comment #19 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 899423ad41611b94848ed8fbdc877bd49f9cd408 by Henrik Fehlauer.
Committed on 30/01/2018 at 23:57.
Pushed by rkflx into branch 'master'.
Update view after changing rendering intent config
Summary:
This is a follow-up patch to D10076, so after changing the rendering
intent in Gwenview's config dialog the displayed image is updated
immediately after clicking on {nav OK} or {nav Apply}. Before, it was
necessary to {nav Reload} the image manually or pan around.
Currently this is only implemented for raster images. In case someone
figures out colour management for SVGs, this patch should be extended to
SVGs too.
Depends on {D10076}.
Test Plan:
Set up an ICC profile as described in D10076#197598 and open an
out-of-gamut image. Change the rendering intent in Gwenview's config
dialog, click {nav Apply} and observe that the image's colours change
immediately. Saving to the config file still works.
Reviewers: ngraham, muhlenpfordt
Reviewed By: ngraham
Differential Revision: https://phabricator.kde.org/D10187
M +11 -14 lib/documentview/rasterimageview.cpp
M +2-0lib/documentview/rasterimageview.h
M +1-0lib/documentview/rasterimageviewadapter.cpp
M +4-8lib/renderingintent.h
https://commits.kde.org/gwenview/899423ad41611b94848ed8fbdc877bd49f9cd408
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- > I don't think Escape should go back to start page. > But what about setting a default shortcut, e.g. Ctrl+Home? In "kcmshell5 standard_actions" there already is a standard action with an associated shortcut for "Home". Perhaps we could just port the "Start Page" action to that? It's still a bit hard to reach, preventing frequent usage. More ideas: - When going up in "/", instead of doing nothing switch to the Start page (a bit weird, though). - Implement proper navigation history (maybe there's already some support in KF5, still not trivially done I guess). -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 357022] Region selection screen does not take into account device pixel ratio
https://bugs.kde.org/show_bug.cgi?id=357022 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #19 from Henrik Fehlauer <rk...@lab12.net> --- Created attachment 110192 --> https://bugs.kde.org/attachment.cgi?id=110192=edit spectacle-rectangle-hidpi.png The new QML UI still has issues in HiDPI mode, even though the pixmap itself seems fine now (see screenshot). In src/QuickEditor/EditorRoot.qml, this mostly concerns "ctx" / Context2D. I wonder whether this is related to https://bugreports.qt.io/browse/QTBUG-37095, although with Qt 5.10.0 it's still problematic for me. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 381528] Unable to capture rectangular screenshot
https://bugs.kde.org/show_bug.cgi?id=381528 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC||rk...@lab12.net Status|UNCONFIRMED |NEEDSINFO --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- For ruling out this is related to your multi-monitor setup, could you just test with your laptop's internal display and report back? Next (maybe this is obvious, but better safe than sorry...), could you confirm that with "clicking is ignored" you specifically mean "press mouse button down, move the mouse both horizontally and vertically, release mouse button"? If not, we should improve the help text. Also, could you please provide some info about your hardware (type of GPU and driver in use, mostly)? Sorry for all those questions, but for me it's working fine ;) -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 378925] Keybinding for "Take a New Screenshot"
https://bugs.kde.org/show_bug.cgi?id=378925 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||rk...@lab12.net Resolution|--- |WONTFIX --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Suppose there would be a way to get what you propose, i.e. press a shortcut, wait x seconds, show the UI. Obviously this would go against pretty much any recommendations regarding UI design, which say to provide feedback to user actions as soon as possible. Thus we would need to implement another form of on-screen notification, make sure it hides early enough again etc. (IMO not worth the effort, and not sure that's what you want). I believe you can already get what you want, pretty much: Just press the launch shortcut, and then press Enter (having configured the delay beforehand). You could even automate this, i.e. bind a script to your shortcut which launches Spectacle and then sends Enter (e.g. using xdotools), or script something via DBUS. If you don't want the GUI at all, bind "spectacle -d -b" to your shortcut (more options with "spectacle --help"). As for starting faster, there is Bug 365963. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 373578] Rectangular region is broken
https://bugs.kde.org/show_bug.cgi?id=373578 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- This works fine testing with 17.12.0. Possibly one of the commits in Bug 357022 fixed it. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 383277] Add option to make screenshot of itself
https://bugs.kde.org/show_bug.cgi?id=383277 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Spectacle deliberately hides itself from being captured, which seems like the right thing to do. Adding an option to disable this might be possible, but I'd say overloading the UI with yet another option is not worth the benefit. After all, you could just open two instances of Spectacle to get a screenshot of Spectacle – not strictly of itself, though, but except for recursion in the preview area you'd gain nothing. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 297853] Smooth scroll of thumbnails
https://bugs.kde.org/show_bug.cgi?id=297853 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #8 from Henrik Fehlauer <rk...@lab12.net> --- It's still an issue for me using a mouse wheel. Basically, Gwenview's Browse mode (aka thumbnail view) uses the number of lines assigned to a scroll tick in your mouse config in "systemsettings", which is 3 by default. In case you have large thumbnails or just a small window height, this can mean a single scroll can be equivalent to a PageDown press (it's capped to never skip rows, luckily). I'm a bit unhappy in general with how jumpy scrolling works with a mouse wheel in Gwenview and also in Dolphin (it's better with a touchpad supporting pixel-perfect smooth scrolling, I guess). Items jump around too much, so I never really know where the items I was looking at are located afterwards. In Firefox, smooth scrolling, the scrolling distance and scrolling acceleration work much better (I tweaked it a bit in about:config, though), which displays both text and larger graphical elements. I wonder if we should just hardcode the scrolling distance to 1 row (+ a small offset) or provide a config option? (Firefox-like scrolling is probably out-of-scope here.) On the other hand, scrolling should not get too slow for directories with an enormous amount of images. Maybe we could base it on a fixed percentage of the viewport height? (I did not try the attached patch yet, maybe it helps already.) Nate: Thoughts? Please reopen if you can confirm. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 389558] mCurrentMainPageId == 'StartMainPageId' warning when exiting from the start page
https://bugs.kde.org/show_bug.cgi?id=389558 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- The warning is nothing serious, but I worked on a (trivial) patch for this end of last year anyway. I guess I should free some time to post it for review eventually… -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 277384] Gwenview crashes while saving a bunch of pictures [ Gwenview::JpegContent::rawData, Gwenview::JpegDocumentLoadedImpl::rawData ]
https://bugs.kde.org/show_bug.cgi?id=277384 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||pasqual...@hotmail.com --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 389486 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 389486] gwenview crached when trying to save rotated images
https://bugs.kde.org/show_bug.cgi?id=389486 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||rk...@lab12.net --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- *** This bug has been marked as a duplicate of bug 277384 *** -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 389411] New: Okular and X unresponsive when resizing Okular's sidebar
https://bugs.kde.org/show_bug.cgi?id=389411 Bug ID: 389411 Summary: Okular and X unresponsive when resizing Okular's sidebar Product: okular Version: 1.3.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-de...@kde.org Reporter: rk...@lab12.net Target Milestone: --- Open the PDF mentioned in https://phabricator.kde.org/D8379#157345 and change the width of the sidebar. Moving the mouse to a different window does not change the cursor anymore, window switching does not work until Okular finished rendering. Okular's UI is unresponsive too, while normally rendering is done in a different thread. Same behaviour when testing in IceWM, so not KWin related. Additional notes copied from https://phabricator.kde.org/D9328: I cannot switch windows (or even move window focus via focus-follows-mouse), which is odd because normally even with all CPU cores busy (here some are idle, still) that's not a problem. I can move the mouse, but the pointer does not change. Maybe Okular has a blocking mouse cursor change call, or does too many of them? When filing the bug, Bugzilla suggested Bug 155652, so maybe the problem is related to scrollbars and some Qt code path? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 306834] Inconsistent double click behaviour in tree view
https://bugs.kde.org/show_bug.cgi?id=306834 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- You cannot select multiple items in the tree view, so switching folders on first click already should be the way to go. After all, this way we'd be consistent with Dolphin. Note that after fixing this, it should be made sure that the toggling behaviour introduced in https://phabricator.kde.org/D9886 still works fine. (Expanding/Folding a folder on double click is standard behaviour in such widgets, though, and thus wanted. We won't change that.) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383850] Gwenview shows unreadable paths in Recent Folders
https://bugs.kde.org/show_bug.cgi?id=383850 --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Note that one of a whole set of patches I worked on end of last year will solve this Bug, it should even conform to DrSlony's last example. Once my review backlog shortens a bit I'll rebase, clean it up and post it on Phab. (← Bad form of cookie licking, sorry for that ;) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 389331] New: Changes to shortcuts only reflected after restart in some situations
https://bugs.kde.org/show_bug.cgi?id=389331 Bug ID: 389331 Summary: Changes to shortcuts only reflected after restart in some situations Product: gwenview Version: 17.12.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: gwenview-bugs-n...@kde.org Reporter: rk...@lab12.net Target Milestone: --- After restoring the default shortcut for Quit and switching to View mode, the old shortcut still works. Detailed STR: - Start Gwenview (Start Page should show). - Open shortcut config dialog, set ⎋ as shortcut for Quit, Reassign → OK. - ⎋ to close Gwenview. - Restart Gwenview, open shortcut config dialog again, reset shortcuts: Defaults → OK. - Switch modes (e.g. either from Start Page to Browse, or from Browse to View etc), press ⎋. - ER: Default action, e.g. mode switch or no action. - AR: Gwenview closes. (After an additional restart this does not occur anymore, though). This seems to occur only if view mode was never active. There's also a similar issue, when setting ⎋ for Quit and then switching to View mode: The shortcut is not working (no Quit, no Browse mode). Very strange - maybe a bug inside KActionCollection or in Gwenview's handling of it? (Copied from various comments in https://phabricator.kde.org/D9943) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #8 from Henrik Fehlauer <rk...@lab12.net> --- > in addition we could make ⎋ switch from (normal) Browse mode > to the "Start Page" Alternatively, this could clear the selection (just like in Dolphin). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||de...@ukn8.de --- Comment #7 from Henrik Fehlauer <rk...@lab12.net> --- Continuing the discussion from https://phabricator.kde.org/D9943#193322: > What's the desired behavior? Should ⎋ always exit fullscreen browse mode, > i.e. removing the shortcut config? This should be possible with the > ShortcutOverride event. Setting a shortcut for "Full Screen Mode" acts as a toggle, so that we probably don't need to have a separate configurable shortcut for the "Leave Fullscreen Mode" action and maybe we could remove it from the shortcut config dialog? I don't understand why we have this action, as even the context menu in Fullscreen says "Exit Fullscreen Mode" and has said toggle shortcut. "Leave Fullscreen Mode" is only used in the top right corner, we could try to change that to the normal "Exit Fullscreen Mode" action. > As far as I see, it's not possible to have two actions in the > KActionCollection with the same shortcut, even if they only trigger in > different situations. That's my understanding, too. > Ok, I'll try to do it this way: > - fullscreen view mode →fullscreen browse mode with ⎋ or whatever > configured shortcut > - fullscreen browse mode → windowed browse mode with ⎋ Yup, exactly like I would imagine how this should work. (Thinking more about that, in addition we could make ⎋ switch from (normal) Browse mode to the "Start Page", then it would be symmetrical to the Enter key, which cycles "Start Page" → Browse → View. Currently you have a hard time going back to Start, even though there are useful links to your tags, bookmarks and devices there…) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 344809] Gwenview crashes when moving forward to a video, then back
https://bugs.kde.org/show_bug.cgi?id=344809 --- Comment #26 from Henrik Fehlauer <rk...@lab12.net> --- Note the bug is marked as fixed already, nevertheless happy to discuss about how Gwenview should handle videos in general. E.g. we currently have https://phabricator.kde.org/D8753, where we are trying to find a good default wrt. space bar and arrow keys when navigating around in folders with videos in them in both normal and slideshow mode. Please let us know about how you'd prefer Gwenview to behave: - Do you want to see videos by default in Browse mode? - Should videos autoplay by default? Do you prefer an option for that? - Should your normal means of navigating between images (arrow key, space bar) keep working when hitting a video (where those keys normally have different meanings, i.e. skipping forward and pausing). - How to pause a slideshow if the shortcut is already taken? Keep in mind your suggestions will be considered, but not guaranteed to be implemented (due to other technical constraints or simply lack of time). But at least we can try to slowly make progress ;) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388611] log polluted w/ 'Empty filename passed to function'
https://bugs.kde.org/show_bug.cgi?id=388611 --- Comment #13 from Henrik Fehlauer <rk...@lab12.net> --- Someone else already posted the patch for plasma-framework, not sure whether taking advantage of my analysis or not. That's what I get from helping others instead of cleaning up my own patches in time :( > I'll try to post a follow-along how I arrived at the Plasma fix Here we go: 1. Establish which binary we can attach gdb to: That required a bit of intuition, because the xorg-session.log does not provide the source a message is coming from (journald would be better in that regard, because it shows binary and PID, see https://bugs.kde.org/show_bug.cgi?id=388389#c0). Looking at the bugs, it became pretty obvious there where different sources the message came from (Dolphin and something Plasma related which could be triggered via RSIBreak or hovering over a custom panel entry). For the next steps, let's focus on plasmashell, because we see the errors appearing in the output when starting a standalone plasmashell (after killing the original). 2. Think about what we are looking for: Essentially we need to find the source of the error message first, to be able to trace back where it was triggered in a second step, so that place can be fixed in the end. In comment 4 I already linked the commit adding the error message to Qt, but searching for "Empty filename passed to function" in qtbase is another way to lead us to https://code.woboq.org/qt5/qtbase/src/corelib/io/qfilesystemengine_unix.cpp.html#110 (code.woboq.org is an excellent site for interactively browsing through Qt and KDE sources, BTW). Sadly, emptyFileEntryWarning_() is a very simple static function, meaning with the usual compiler optimizations enabled in a stock Qt build we cannot set a breakpoint on it. As a workaround, we can set a breakpoint on something inside this function (this took me quite a while to realize, haha), in this case QMessageLogger::warning. Note that now a breakpoint could be triggered more often, i.e. also when other functions issue a warning, which we would need to ignore then. 3. Get a backtrace with gdb: - $ killall plasmashell - $ gdb plasmashell - $ run (or "r") - ctrl-c to interrupt program flow - $ break QMessageLogger::warning (or "b") - $ continue (or "c") - Move mouse over custom icon in panel, breakpoint should be hit. - $ backtrace (or "bt") - Verify that the warning was indeed triggered by something also appearing in qfilesystemengine_unix.cpp and thus belonging to emptyFileEntryWarning(). - Repeat continue + backtrace until we are at the right place. - ctrl-d to stop the debugger Note that at this point there are still some pieces missing in the backtrace, so we go to the next step to fix this. 4. Prepare debug symbols: On openSUSE, packages are split into multiple RPMs. The oss repo has the binaries and -devel packages (needed to run something and to be able to #include headers when developing, respectively). The debug repo has -debuginfo packages, those are important if you submit a backtrace to Bugzilla for example, giving you more complete backtraces. The debug repo also provides -debugsource packages, those contain the complete source code of functions, so you could step through every single line in a debugger and see where you are. Note that those packages are for system provided binaries, if you execute code compiled by yourself you'd just have to make sure to compile in debug mode (you'd still need -debuginfo packages for libraries you use). (For completeness: There is also the source repo containing .src.rpms, which include a .tar.gz of the upstream source and a spec file to build all of the other types of RPMs I mentioned from this, but that's not relevant here. If you are interested, use rpm2cpio and cpio to extract those RPMs and see what they contain.) Here, we perform the following steps: - Note the filename in the backtrace for lines you want to know more about. - Install corresponding debuginfo package using one of the following methods (make sure to have the debug repo enabled): - rpm -qf /usr/lib64/libQt5Core.so.5 (to get the package name), zypper in /usr/lib64/libQt5Core.so.5 - ctrl-shift-f search in your konsole history for the file to find complaints about the missing debuginfo, zypper install -C "debuginfo(build-id)=474186faf16585c4703a404a4fdc1bac4c03ea00" Trigger the breakpoint again, now some of the "()" should be replaced by actual function names. Repeat for more packages as needed, e.g. plasma-framework-debuginfo. Next, we want line numbers, so we need -debugsource packages. On openSUSE, for larger projects a single source RPM can be split into multiple binary/debuginfo RPMs. With "rpm -qi libQt5Core5" we get the name of the source RPM (libqt5-qtbase), so the package name would be "libqt5-qtbase-debugsource". As we are interested in fixing the lines concering pla
[okular] [Bug 389142] Save as does not work - it says "... try to save it in another ...", but annotations are not saved
https://bugs.kde.org/show_bug.cgi?id=389142 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for the report, but I'm not really sure what you are doing… So you are saying that when you "Save As" to a new filename, annotations are gone, while when you "Save" to a new filename, annotations are kept? And if you are using Okular 1.2.3, why would it warn you about unsaved changes in a PDF? (That version normally saves changes automatically to an XML file.) What type of document is this? Is it located in your home folder? Is it created by another process like pdflatex, changing it behind your back? Does it happen for every PDF or only for specific ones? Note that annotation saving was changed significantly for Okular 1.3. Now it works just like in a text editor via "Save" if you have unsaved changes. Please upgrade to that version and tell us if your problems persist. If so, provide clear steps to reproduce the problem (bullet points with as much detail as possible are best) and mention what happened vs. what you expected to happen. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 131068] When an image that's open in Gwenview is edited with another program, the thumbnail updates instantly, but the image itself doesn't
https://bugs.kde.org/show_bug.cgi?id=131068 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #11 from Henrik Fehlauer <rk...@lab12.net> --- Still an issue as of Gwenview 17.12.1. Nate's description of the symptoms is spot on. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 131068] When an image that's open in Gwenview is edited with another program, the thumbnail updates instantly, but the image itself doesn't
https://bugs.kde.org/show_bug.cgi?id=131068 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||ste...@moontwelve.com --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 275123 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 275123] Automatic reload of changed files no longer working.
https://bugs.kde.org/show_bug.cgi?id=275123 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Status|CONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- *** This bug has been marked as a duplicate of bug 131068 *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 131068] When an image that's open in Gwenview is edited with another program, the thumbnail updates instantly, but the image itself doesn't
https://bugs.kde.org/show_bug.cgi?id=131068 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||naught...@gmail.com --- Comment #9 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 388982 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388982] Main image view does not automatically refresh when the viewed file is changed in another program
https://bugs.kde.org/show_bug.cgi?id=388982 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Resolution|--- |DUPLICATE Status|CONFIRMED |RESOLVED --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for the report, turns out we already have that problem on file (and Nate even commented on it :) *** This bug has been marked as a duplicate of bug 131068 *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388611] log polluted w/ 'Empty filename passed to function'
https://bugs.kde.org/show_bug.cgi?id=388611 --- Comment #12 from Henrik Fehlauer <rk...@lab12.net> --- > Even after yesterdays update it is still [...] 5.41.0 Oops, in my comment I meant 5.41, not 5.42 – sorry for the confusion. >> Let me know if you need help with that. > Yes I do, definitely! Great, I'll try to post a follow-along how I arrived at the Plasma fix and what you need to install for that on Tumbleweed. Until that is done, you could read a bit on Wikipedia and Stackoverflow about gdb, breakpoints and the difference between a coredump and a backtrace, because I'll probably not be able to explain all of those in detail in a comment on Bugzilla ;) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 306835] Make selecting directory in directory tree to automatically enter Browse mode
https://bugs.kde.org/show_bug.cgi?id=306835 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for looking into it. Yup, ContextManager::currentDirUrlChanged(const QUrl&) still has the correct URL. Seems like switching to Browse mode was never implemented explicitly for clicking on a folder in the sidebar and this only worked because of b55420b2ac3d's side effect, i.e. an empty selection in MainWindow::openSelectedDocuments(). The fact that it works for slow DirListers is another indicator that currently we rely on unpredictable timing / signal emission behaviour. One more thing: It would be nice if clicking on the same folder you have open in View mode would switch to Browse mode (currently it does nothing at all, see the early return in MainWindow::openDirUrl). I couldn't come up with anything better than your suggestion of just triggering the switch manually. Although I wonder whether triggering the action should be done in MainWindow::openDirUrl instead (most of the other actions are triggered in this class). Do you want to submit a Diff or do you want me to do it? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388611] log polluted w/ 'Empty filename passed to function'
https://bugs.kde.org/show_bug.cgi?id=388611 --- Comment #9 from Henrik Fehlauer <rk...@lab12.net> --- I have worked on fixes for plasma-framework and kinit, will post them for review in the next days. I think those will prevent the Plasma and startup related occurrences. @Michael: I'm not sure why you still get the error in Dolphin and Kate after upgrading to KF 5.42. Did you relogin after your latest "zypper dup"? Does it also occur on a fresh user account without any custom settings? Try setting a breakpoint on QMessageLogger::warning in gdb and obtain a backtrace, so we get an idea where it still fails for you. (Let me know if you need help with that.) -- You are receiving this mail because: You are watching all bug changes.
[kfile] [Bug 258514] Shadows around thumbnails of SVGs and PNG files with alpha channel should be removed
https://bugs.kde.org/show_bug.cgi?id=258514 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Summary|Thumbnails around SVGs and |Shadows around thumbnails |PNG files with alpha|of SVGs and PNG files with |channel |alpha channel should be ||removed -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364527] Unnecessary scaling of small SVG and PNG icons leads to blurry thumbnails
https://bugs.kde.org/show_bug.cgi?id=364527 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Summary|Blurred SVG image |Unnecessary scaling of |thumbnails on Dolphin |small SVG and PNG icons ||leads to blurry thumbnails --- Comment #9 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for your additional comments. I suspect the blurs for SVG and PNG are a bit different each, caused by the icon shown too small (smaller area to render the SVG in vs. smaller area to downscale a prerendered PNG to), but nevertheless I adapted the bug title slightly. This should be solved in two steps: Remove the shadow in Bug 258514, after that check whether any additional steps are necessary for your bug. FWIW, Gwenview does not have shadows, but probably won't be good enough for you either due to lack of a precise thumbnail size control. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 388389] Spam log with plasmashell[**]: Empty filename passed to function
https://bugs.kde.org/show_bug.cgi?id=388389 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- Looked a bit into this: The error is logged by plasmashell, but it only occurs once RSIBreak is running and you either move your mouse or type on your keyboard. Note that some symptoms in Bug 388611 can be solved by upgrading to KIO 5.41, while this does not help here. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388611] log polluted w/ 'Empty filename passed to function'
https://bugs.kde.org/show_bug.cgi?id=388611 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- The problem in Gwenview and some of the Dolphin problems (I could not reproduce all of those in Comment 2 in the first place) are fixed in KIO 5.41 (549fc81e8e8a in particular). @Michael: Could you upgrade to 5.41 (Tumbleweed should have it really soon™) and observe the situation a bit? I suspect the fallout from the change in Qt still has to be fixed in a couple more places. It would be nice to make a list. E.g. there is Bug 388389, which triggers the error output in plasmashell via RSIBreak. Hovering over custom icons in the panel is still broken, too. -- You are receiving this mail because: You are watching all bug changes.
[kruler] [Bug 388796] New: Measure actual pixel size on HiDPI displays
https://bugs.kde.org/show_bug.cgi?id=388796 Bug ID: 388796 Summary: Measure actual pixel size on HiDPI displays Product: kruler Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: soe...@pprojekt.de Reporter: rk...@lab12.net Target Milestone: --- Testing KRuler with "QT_SCALE_FACTOR=1.7" (i.e. fractional scaling like on a HiDPI display) works fine in general, but shows some oddities: 1. All measurements are scaled up too, meaning the value displayed does not relate to the actual number of pixels on the screen. However, I'd argue that first and foremost users are interested in the pixel dimensions of something displayed on the screen e.g. developers measuring sizes before and after when adding HiDPI support to applications (: or web designers working with images displayed at 100% zoom (i.e. a 1:1 mapping of image pixels to screen pixels without scaling). This means KRuler should not scale the measurement. Still, sometimes you might be interested in the virtual/scaled size, e.g. a developer measuring a default window size (which would be scaled by Qt depending on scaling) or a web designer working on a layout. This could be added as an option (either replacing the other value, or as an additional measurement). 2. For fractional (non-integer) scaling factors, the tick marks on the ruler look really bad, because they do not align with the pixel grid anymore. They should not be scaled. (One more reason to default to a non-scaled measurement). -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388660] Feature Request: Increase max icon thumbnail size
https://bugs.kde.org/show_bug.cgi?id=388660 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- I cannot reproduce. Setting scaling to 2x, after a relogin I get much larger thumbnails than in your screenshot when setting the thumbnail slider to the maximum value. In fact, for a setting of 256px they are 700 to 750px wide (depending on the image), which seems strange. However, I suspect you simply forgot to relogin, because your screenshot shows a large font size with small icons everywhere in Dolphin, which is a typical symptom in this case. Could you try to relogin and report back? That said, there are still issues with Dolphin's thumbnails in HiDPI mode: - shadow and selection button overlay on previews pixelated - folders with thumbnail preview pixelated - thumbnail pixmaps itself not pixelated, but not looking good because of capped maximum thumbnail size - mismatch between reported size in size slider tooltip and actual size on screen (And even when not in HiDPI mode, someone might want to have a larger thumbnail size.) @broulik: Would it be worth pursuing a change of the FDO spec? If so, how to best approach that? See also: https://phabricator.kde.org/D9078 https://phabricator.kde.org/D6083 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364527] Blurred SVG image thumbnails on Dolphin
https://bugs.kde.org/show_bug.cgi?id=364527 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||rk...@lab12.net Summary|Blurred image thumbnails on |Blurred SVG image |Dolphin |thumbnails on Dolphin --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- It took me a while to see what you mean, so here are some steps to see the problem: - Start KMag, point it at the screenshot. - Compare accessories-notes.svg. - Note how Dolphin renders the SVG in such a way that antialiasing on the inner horizontal lines as well as the yellow outline occurs, while in Nautilus the SVG is rendered snapped to the pixel grid, so no antialiasing occurs as probably intended by the icon designer. Testing with Qt 5.10.0, KF 5.40, Dolphin 17.08.3, the problem is still there. Maybe the problem is caused by Dolphin rendering a different size than the icon is optimized for, e.g. when previewing /usr/share/icons/breeze/apps/64/ with the thumbnail size set to 64px, the blur still occurs. I see no PNGs in Dolphin in the screenshot, therefore changing the title of the bug for now to only focus on the SVG rendering problem. Also, Nautilus skips the shadow/frame for SVGs (just like Gwenview) which makes sense, there is Bug 258514 for changing that in Dolphin. -- You are receiving this mail because: You are watching all bug changes.
[kfile] [Bug 258514] Thumbnails around SVGs and PNG files with alpha channel
https://bugs.kde.org/show_bug.cgi?id=258514 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Summary|Thumbnails around png files |Thumbnails around SVGs and |with alpha channel |PNG files with alpha ||channel CC||rk...@lab12.net --- Comment #6 from Henrik Fehlauer <rk...@lab12.net> --- In Bug 364527 there is a screenshot (http://imgur.com/a/ExRCx) comparing rendering of SVG previews between Nautilus and Dolphin. The shadows in Dolphin do look quite out of place. Gwenview on the other hand does not display the frame/shadow for SVGs or raster images with an alpha channel. I think Dolphin should work the same way. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 155563] Automatic text selection in Okular
https://bugs.kde.org/show_bug.cgi?id=155563 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- @michaelweghorn: Ahh, sorry. I definitely noticed that, but somehow it's still on my list of things to review. I'll try to get back to you once I find the time. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 388611] log polluted w/ 'Empty filename passed to function'
https://bugs.kde.org/show_bug.cgi?id=388611 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1 CC||rk...@lab12.net Status|UNCONFIRMED |CONFIRMED --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Can confirm, the same happens in Gwenview when switching to "View" mode (but only the first time doing so). > A few days ago tumbleweed updated Qt (from ??? to 5.10.???) > and it is only since then I see these messages. Yep, with Qt 5.10.0 / KF 5.40 I see it, but it isn't there with Qt 5.9.3 / KF 5.40. The error message was introduced here: https://code.qt.io/cgit/qt/qtbase.git/commit/?id=0dee566e98f5ff4f224e596de1c04de4f9685df4 Still, the fix might not be in Qt. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 388389] Spam log with plasmashell[**]: Empty filename passed to function
https://bugs.kde.org/show_bug.cgi?id=388389 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- Smells like the same issue as in Bug 388611, where this message suddenly occurs after the upgrade to Qt 5.10. Not marking as a duplicate for now, though, because currently I'm not sure where this should be fixed. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 220218] Separate icons by default for the rectangle and text selection tools
https://bugs.kde.org/show_bug.cgi?id=220218 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCONFIRMED |RESOLVED CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- I don't think there is enough room (as in screen real estate, but also when looking from a usability perspective, i.e. keeping the number of buttons to choose from low) to have two separate buttons. Note that you can always configure the toolbar to show both buttons, if you wish so. We should rather fix the root cause, i.e. this: > most users would probably prefer text selection This is tracked in Bug 155563. > The dropdown appears only after delay This was fine in KDE3 (you could move the mouse down do get the menu immediately), nobody brought this back so far, though. However, you could also just use the Tools menu to get immediately to the tool in question. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 388747] Using cursor pointer rather than rectangle to select text
https://bugs.kde.org/show_bug.cgi?id=388747 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- If you long-press on the Selection button in the toolbar (or use the Tools menu), you have the option to choose the Text Selection Tool, which should do exactly what you want. Still, I agree that this is rather hard to find and it should be the default mode, too. See Bug 155563 for that. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 306886] Merge selection and browse tool functionality
https://bugs.kde.org/show_bug.cgi?id=306886 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #9 from Henrik Fehlauer <rk...@lab12.net> --- See also Bug 155563 in this context. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 155563] Automatic text selection in Okular
https://bugs.kde.org/show_bug.cgi?id=155563 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net Keywords||usability --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- There are two ways we could improve usability regarding text selection: - Make the "Text Selection Tool" the default choice for the button in the toolbar instead of (Rectangle) "Selection" (easy). - Default to selecting text rather than starting in Browse tool mode, or make it automatic (harder). See also Bug 306886 in this context. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824 --- Comment #11 from Henrik Fehlauer <rk...@lab12.net> --- I changed the test for now to handle the different number of items Gwenview gets from the PlaceTreeModel since KIO 5.41, so at least we make the CI a bit happier for 17.12.1. Any ideas how/where to track the remaining issues? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824
Henrik Fehlauer <rk...@lab12.net> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/e8d799c9b522af299f721
||dbbfcc650526ba78940
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #10 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit e8d799c9b522af299f721dbbfcc650526ba78940 by Henrik Fehlauer.
Committed on 07/01/2018 at 23:47.
Pushed by rkflx into branch 'Applications/17.12'.
Fix failing PlaceTreeModelTest autotest
Since Frameworks 5.41, `PlaceTreeModelTest` would fail. Bisecting shows
this has been caused by 7eb6333bdb48 in KIO ("Added baloo urls into
places model"), where the model now returns 4 additional entries for
"Recently Saved" and another 4 entries for "Search For".
While the fix is trivially done by changing the number of expected
items, in a way the test functioned as a canary for problems deeper in
the code. In particular it uncovered problems when accessing the newly
added virtual folders as well as various usability issues. Some of those
are fixed already (50e6fa3ffc49 and 86d754546bd1), but there is still
some work left to do.
Test Plan: `placetreemodeltest` does not fail with KF 5.41 anymore,
still works with KF 5.40.
M +6-0tests/auto/placetreemodeltest.cpp
https://commits.kde.org/gwenview/e8d799c9b522af299f721dbbfcc650526ba78940
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 388144] "Copy to" and "Move to" ignore entered filename
https://bugs.kde.org/show_bug.cgi?id=388144
Henrik Fehlauer <rk...@lab12.net> changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In||17.12.1
Latest Commit||https://commits.kde.org/gwe
||nview/119ac4186e4150467f4c3
||833d8756345b4a95191
Status|CONFIRMED |RESOLVED
--- Comment #2 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 119ac4186e4150467f4c3833d8756345b4a95191 by Henrik Fehlauer.
Committed on 07/01/2018 at 23:41.
Pushed by rkflx into branch 'Applications/17.12'.
Respect custom filename for Copy/Move/Link To operations
In `copyMoveOrLink`, 9056aa941e0d needed to strip the filename from
`destUrl`. However, this was done before the actual file operation had
been started, resulting in those being performed using the new target
directory, but with the old filename instead of a user-provided new
filename.
This regression can be fixed by moving the stripping after starting the
KIO job, because setting a new `targetUrl` in `contextManager` will only
be needed at a later point, i.e. when persisting this path to the
config.
FIXED-IN: 17.12.1
Test Plan: {nav File > Copy To}, enter custom filename, verify image is
copied to new path with new filename. Operations on multiple images
still work, as well as remembering the last used target directory in
both cases.
M +5-4app/fileoperations.cpp
https://commits.kde.org/gwenview/119ac4186e4150467f4c3833d8756345b4a95191
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 306835] Make selecting directory in directory tree to automatically enter Browse mode
https://bugs.kde.org/show_bug.cgi?id=306835 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|FIXED |--- Ever confirmed|0 |1 CC||de...@ukn8.de, ||rk...@lab12.net Status|RESOLVED|REOPENED --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- Reopening, because f29f955a164e broke this again. @Peter: Could you have a look? I suspect your patch was correct, and b55420b2ac3d fixed it only by accident (this bug was only slightly related to this patch anyway), i.e. relying on incorrect behaviour which you fixed. The actual problem might be in the way passing and receiving the directory URL is done when clicking on an entry in the sidebar. Selecting a directory should never show an image, regardless of whether we select the first image or not. I'm sure with a bit of patience this whole context/selection cleanup will settle down eventually ;) -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 372917] Saving annotations to pdf stopped working
https://bugs.kde.org/show_bug.cgi?id=372917 --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- For Okular 1.3 (KDE Applications 17.12), saving annotations now always saves to the PDF, using the XML file (which results in the behaviour you see regarding dependence on filename, but not path) is not supported anymore. Therefore I doubt this is still an issue. Nevertheless, please retest with the newest version and report back if it still fails. Then it would also be great if you provided exactly the steps you followed and attached the PDF. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 377880] Gwenview There are two actions (Cut, Delete)
https://bugs.kde.org/show_bug.cgi?id=377880 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||steph1121...@gmail.com --- Comment #39 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 388500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388500] Problem with the keyboard shortcuts in Gwenview (duplicate of shortcut and impossible to save new ones)
https://bugs.kde.org/show_bug.cgi?id=388500 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |DUPLICATE CC||rk...@lab12.net Status|UNCONFIRMED |RESOLVED --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Happy new year. Unfortunately, even though you have a "fresh" Mint install, the software shipped there is quite old. The problem has long been fixed in newer versions. > Furthermore it is impossible to save new shortcuts Try this: https://bugs.kde.org/show_bug.cgi?id=377880#c38 *** This bug has been marked as a duplicate of bug 377880 *** -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 388458] Wrong size of rectangles around annotation icons (e.g. popup note) for PDF documents
https://bugs.kde.org/show_bug.cgi?id=388458 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- > widgets are huge, while PDF page looks the same In general Okular should display documents based on the physical dimensions as specified in the PDF, e.g. for 100% zoom of an A5-sized document you should be able to get the same size measurements with a ruler as when measuring a real A5 paper on your desk. IOW, this depends on the (hardware) DPI of the monitor, but not a user-set (virtual) DPI to scale UI elements. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387900] print units and max value limit
https://bugs.kde.org/show_bug.cgi?id=387900 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC||rk...@lab12.net Ever confirmed|0 |1 --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- Can confirm the problem. When approaching the maximum value, the "Keep ratio" setting also breaks down. The values do not even respect the page size. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 388458] Wrong size of rectangles around annotation icons (e.g. popup note) for PDF documents
https://bugs.kde.org/show_bug.cgi?id=388458 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for digging into this, looking forward to the Phabricator review. > can't test the latter due to lacking hidpi setup HiDPI testing should be easy with something like "QT_SCALE_FACTOR=2.4 okular". Ref. https://doc.qt.io/qt-5/highdpi.html -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 338742] Annotations incompatible with gzip
https://bugs.kde.org/show_bug.cgi?id=338742 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Patch: https://phabricator.kde.org/D9580 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388353] Scrolling with the touchpad is too fast in the view mode
https://bugs.kde.org/show_bug.cgi?id=388353 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for testing again. > I already have it set to browse. It was the first change I made. That's what I suspected ;) I only mentioned it in case somebody else reading the bug stumbles about this (in general it is important to note any changes from the default config when reporting a bug). > the problem is still there I think the next step (once someone finds the time) would be to fix the code. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 291176] Documentation wish: add that document archive must have ".okular" extension
https://bugs.kde.org/show_bug.cgi?id=291176 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/oku ||lar/9f0aa37906c9230ad1a4896 ||1f88ab2d654eec0e6 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Git commit 9f0aa37906c9230ad1a48961f88ab2d654eec0e6 by Henrik Fehlauer. Committed on 01/01/2018 at 07:41. Pushed by rkflx into branch 'master'. Document ".okular" filename extension Summary: In general Okular makes it very hard to get the filename extension for document archives wrong when saving. Still it would be nice to document this. Test Plan: `meinproc5` still happy. Reviewers: lueck, yurchor Reviewed By: yurchor Subscribers: #okular Tags: #okular Differential Revision: https://phabricator.kde.org/D9577 M +1-1doc/index.docbook https://commits.kde.org/okular/9f0aa37906c9230ad1a48961f88ab2d654eec0e6 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 377880] Gwenview There are two actions (Cut, Delete)
https://bugs.kde.org/show_bug.cgi?id=377880 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||myod...@outlook.com --- Comment #37 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 388380 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388380] 2 actions for same shortcut
https://bugs.kde.org/show_bug.cgi?id=388380 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||rk...@lab12.net Resolution|--- |DUPLICATE --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- *** This bug has been marked as a duplicate of bug 377880 *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388353] Scrolling with the touchpad is too fast in the view mode
https://bugs.kde.org/show_bug.cgi?id=388353 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for the report. I don't have access to a touchpad right now so cannot reproduce, but at least I want to mention that beforehand you'd have to go to Gwenview's settings → Image View → Mouse wheel behaviour and select "Browse". I suspect the touchpad is creating a lot of very small scroll increments and this needs special handling in the code compared to the "traditional" way of scrolling (could probably copied from elsewhere, e.g. the fix for Bug 378584). (Regarding scrolling in QML based UIs like the "Add widgets" dialog: I believe this is a known problem depending on library versions and input stack. Unrelated to Gwenview, though.) @RaitaroH: One more thing: Could you also test whether scrolling (i.e. panning after zooming in in View mode) is also too fast when selecting "Scroll" instead of "Browse" in the settings? (And possibly anywhere else?) Thanks! -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 377880] Gwenview There are two actions (Cut, Delete)
https://bugs.kde.org/show_bug.cgi?id=377880 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||mugom...@gmail.com --- Comment #36 from Henrik Fehlauer <rk...@lab12.net> --- *** Bug 388315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388315] Gwenview Ambigous shortcut message
https://bugs.kde.org/show_bug.cgi?id=388315 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |DUPLICATE CC||rk...@lab12.net Status|UNCONFIRMED |RESOLVED --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- *** This bug has been marked as a duplicate of bug 377880 *** -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 388144] "Copy to" and "Move to" ignore entered filename
https://bugs.kde.org/show_bug.cgi?id=388144 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1 CC||rk...@lab12.net Status|UNCONFIRMED |CONFIRMED --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for reporting, can confirm the bug. It's a regression introduced by 9056aa941e0d which was not caught during review – sorry for that. We'll fix it for 17.12.1. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824
--- Comment #9 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 50e6fa3ffc490eca33b8e2025120ec041b333fee by Henrik Fehlauer.
Committed on 20/12/2017 at 23:57.
Pushed by rkflx into branch 'Applications/17.12'.
Fix expanding of baloo URLs in folders sidebar tree view
D8332 resulted in baloo URLs like `timeline:/yesterday` appearing in
Gwenview, however accessing those in the {nav Folders} sidebar led to
error dialogs. 86d754546bd1 already solved this for directly clicking on
entries, here we apply the same fix for expanding those entries, i.e.
clicking on the small arrows in the tree view.
M +4-0lib/placetreemodel.cpp
https://commits.kde.org/gwenview/50e6fa3ffc490eca33b8e2025120ec041b333fee
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 345980] File name and other info lost from titlebar after image modification
https://bugs.kde.org/show_bug.cgi?id=345980 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|REOPENED|RESOLVED Latest Commit||https://commits.kde.org/gwe ||nview/5a7d105ae9dead6214953 ||bfcb3f184c0399be42b Resolution|--- |FIXED --- Comment #7 from Henrik Fehlauer <rk...@lab12.net> --- Git commit 5a7d105ae9dead6214953bfcb3f184c0399be42b by Henrik Fehlauer, on behalf of Peter Mühlenpfordt. Committed on 17/12/2017 at 07:25. Pushed by rkflx into branch 'Applications/17.12'. Update titlebar after image modification Summary: In some cases the titlebar information (filename, size, zoom) is lost after an image has been modified. This patch fixes the caption update and thereby also the missing `*` on modified images. Test Plan: Case 1: 1. Open image in view mode, which fits in window (100% zoom) 2. Scale (Shift-R) or crop (Shift-C) image -> Titlebar info is lost Case 2: 1. Open big image in view mode, which is zoomed to fit in window 2. Scale image with Shift-R (do not save) 3. Go to another big image (zoomed to fit) 3. Scale image with Shift-R -> Titlebar info is lost Reviewers: rkflx Reviewed By: rkflx Subscribers: ngraham Differential Revision: https://phabricator.kde.org/D9293 M +9-6app/mainwindow.cpp M +1-0app/mainwindow.h https://commits.kde.org/gwenview/5a7d105ae9dead6214953bfcb3f184c0399be42b -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
Henrik Fehlauer <rk...@lab12.net> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/92e63330ecdcb15691000
||36a9a7f5245522fe720
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #9 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 92e63330ecdcb1569100036a9a7f5245522fe720 by Henrik Fehlauer, on
behalf of Kapil Lamba.
Committed on 16/12/2017 at 07:15.
Pushed by rkflx into branch 'Applications/17.12'.
Correct margin for left sidebar
Summary:
Sidebar content too close to the left boundary of the window.
This patch adds left margin to some of the sidebar contents.
Test Plan:
Before:
{F5524922}
After:
{F5524923}
Reviewers: #kde_applications, ngraham, rkflx
Reviewed By: ngraham, rkflx
Subscribers: #kde_applications
Tags: #kde_applications
Differential Revision: https://phabricator.kde.org/D9145
M +3-1app/semanticinfocontextmanageritem.cpp
M +7-1app/sidebar.cpp
M +3-1app/sidebar.h
https://commits.kde.org/gwenview/92e63330ecdcb1569100036a9a7f5245522fe720
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 383850] Gwenview shows unreadable paths in Recent Folders
https://bugs.kde.org/show_bug.cgi?id=383850
--- Comment #3 from Henrik Fehlauer <rk...@lab12.net> ---
Since KDE Frameworks 5.41 (more specifically: 7eb6333bdb48), there is another
problem caused by the superfluous "/":
- Access "Today"
- Go back to Start Page, notice new entry in Recent Folders ("timeline:/today")
- Right-click, Add to Places, note the extra "/" in the new Places entry
("timeline:/today/")
- Click on new Places entry
- Result (with a Debug build, at least):
ASSERT: "path.endsWith(QLatin1String("/today"))" in file
~/kio/src/filewidgets/kfileplacesmodel.cpp, line 124
Aborted (core dumped)
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824 --- Comment #8 from Henrik Fehlauer <rk...@lab12.net> --- > - 8 more entries in the folders sidebar, making it too much for efficient > visual orientation. Either group all timeline related entries or replicate the > entire grouping from Places panel. To expand on this usability problem: Currently it is not clear that the time related entries are about "Recently Saved" items and thus could easily be confused with similar functions of other photo managers, i.e. automatic categorization based on the metadata's timestamp. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387906] Icon/thumbnail size on start page quite large compared to Browse mode
https://bugs.kde.org/show_bug.cgi?id=387906 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Summary|Icon/thumbnail size on |Icon/thumbnail size on |start page should respect |start page quite large |setting from Browse mode|compared to Browse mode -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387906] Icon/thumbnail size on start page should respect setting from Browse mode
https://bugs.kde.org/show_bug.cgi?id=387906 --- Comment #1 from Henrik Fehlauer <rk...@lab12.net> --- On second thoughts: Maybe the original intention was to give more space to the thumbnail overlays on the folders, so you could better judge what a folder will contain? Note that's not so much an issue once you entered some folder. Still, the large size / few entries are a bit annoying. Maybe another structure would fit better, i.e. a vertical list, where each row would start with the folder icon, with some preview images next to it. Next recent folder on next row. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- You are not wrong, but the fix for the other bug is probably some simple function call, while the representation of a search URL requires much more thinking/designing/coding to get right. Anyway, that's hardly the most important issue here. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383850] Gwenview shows unreadable paths in Recent Folders
https://bugs.kde.org/show_bug.cgi?id=383850 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- If anybody tackles this: There's also this annoying problem of duplicate entries, i.e. some with / and some with // at the end. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- >> - Recent Folders tab on the Start Page shows long and unreadable >> baloosearch:/ URLs with percent encoding. > May be related to or the same issue as Bug 383850. Not really, see https://en.wikipedia.org/wiki/Percent_encoding. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387907] Thumbnails not displayed for tag folders
https://bugs.kde.org/show_bug.cgi?id=387907 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #2 from Henrik Fehlauer <rk...@lab12.net> --- I guess I can set the status to CONFIRMED, then. If the next comment would have a patch attached, that would be nice… :D -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387824] gwenview fails PlaceTreeModelTest autotest with frameworks 5.41
https://bugs.kde.org/show_bug.cgi?id=387824
Henrik Fehlauer <rk...@lab12.net> changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
CC||rk...@lab12.net
--- Comment #1 from Henrik Fehlauer <rk...@lab12.net> ---
Already noticed it working locally but not on the CI too, but didn't have time
to look into it yet. Having a bug increased priority, though ;)
Thanks for pointing out the connection to KF 5.41. Some digging and bisecting
shows this is caused by 7eb6333bdb48 in KIO ("Added baloo urls into places
model"), i.e. https://phabricator.kde.org/D8332.
Besides the test, this results in new entries in the Places tab on the Start
Page:
- 4 entries for "Recently Saved" (which seem sensible)
- 4 entries for "Search For" (where Images and Videos make sense, but Documents
and Audio Files not so much – will D9332 help with this?)
Unfortunately, besides showing those entries, Gwenview stumbles a bit when
accessing the virtual folders:
- Error messages when tree-expanding those from the sidebar.
- Access via Places panel works, but not via folders sidebar.
- ASSERT: "subjobs().isEmpty()" and coredump when quickly switching back and
forth between search results and Start Page.
New usability issues, too:
- Need to scroll to access "Devices" in Places panel (viewing images on
external devices is an important feature). Perhaps make the icon size
configurable and the default size as small as in Dolphin?
- 8 more entries in the folders sidebar, making it too much for efficient
visual orientation. Either group all timeline related entries or replicate the
entire grouping from Places panel.
- Recent Folders tab on the Start Page shows long and unreadable baloosearch:/
URLs with percent encoding.
To make things worse, simply reverting to 5.40 does not work, because the
entries are now saved in .local/share/user-places.xbel permanently.
In general Gwenview should not show broken functionality, so one of the
following things need to be done (haven't looked at the code yet, not sure
whether this is simple or not):
- Block those entries completely and also handle users who used 5.41 before
Gwenview could ship such a fix.
- Fix Gwenview to handle these entries properly and only show those that make
sense. ← Preferred solution.
- (I guess the patch in KIO itself is fine, although a bit risky wrt.
expectations for the apps.)
Once that's done, we'll know the magic number to be able to fix the failing
test properly. However, it is currently unclear who would be willing to work on
those items. I'll be availabe to review and test, at least.
--
You are receiving this mail because:
You are watching all bug changes.
[okular] [Bug 332835] Feature request: Insert text and replace text annotation
https://bugs.kde.org/show_bug.cgi?id=332835 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Certainly would be nice to have. I don't see why it is urgent though, because you could also use underline or highlighting annotations as a workaround. Simone: Could you detail why you "really need" this? Is this about the visual representation? Do you want to see those as a separate category in the Reviews sidebar? Is Okular failing to show text insertions from Adobe Reader? Other reasons? (Nevertheless, I think attaching the screenshot added value to the bug, thanks.) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387907] New: Thumbnails not displayed for tag folders
https://bugs.kde.org/show_bug.cgi?id=387907 Bug ID: 387907 Summary: Thumbnails not displayed for tag folders Product: gwenview Version: 17.08.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: gwenview-bugs-n...@kde.org Reporter: rk...@lab12.net Target Milestone: --- After tagging some images via the Information sidebar (and having to restart Gwenview – another bug…), accessing them from the Tags tab on the Start Page does not work completely. Specifically, while items are shown and have the correct filename, they only contain an error image and not the correct thumbnail as displayed when accessed through a normal folder. Note this only affects raster images, SVGs are fine apparently. Probably the same root cause also prevents Gwenview from actually displaying an image in View mode from the tags URL afterwards. Only a red error message is shown. -- You are receiving this mail because: You are watching all bug changes.
