Re: Compiler version
On Monday 02 July 2012 09:09:53 Ivan Cukic wrote: Debian Stable (Squeeze) is also 4.5 by default. Debian Stable (Squeeze) is 4.4.5 by default, with GCC 4.3.5 being provided too. Yes, that is the reason I excluded Debian from the distros to watch in this case. Debian stable will not ship 4.10 in any form, and from my experience, people who use debian on the desktop, and care about having latest kde packages, use testing or sid. (myself included) Not in all cases - I use Debian stable (although I'll probably update to testing quite soon). -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm
Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/#review15457
---
Ship it!
Ship It!
- Maks Orlovich
On June 18, 2012, 10:23 p.m., Bernd Buschinski wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/
---
(Updated June 18, 2012, 10:23 p.m.)
Review request for kdelibs.
Description
---
kjs: FunctionObject prototype attribute should be [[Writable]]: true,
[[Enumerable]]: false, [[Configurable]]: false
ECMA Edition 5.1r6 - 15.3.5.2
the prototype must have DontEnum property otherwise it shows up as enumerable
key.
I expected that this must be fixed in the function_object.cpp constructor,
but its never used in for code like
function foo() {};
Diffs
-
kjs/bytecode/codes.def ae0a59f
kjs/function_object.cpp 4000212
kjs/nodes.cpp 0b0749a
Diff: http://git.reviewboard.kde.org/r/105122/diff/
Testing
---
Thanks,
Bernd Buschinski
Re: Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review15458 --- kjs/date_object.cpp http://git.reviewboard.kde.org/r/105387/#comment12087 Same fix here? (And perhaps in other spots?) Really, this probably needs some cleanup to not dupe this chunk of code; the spec defines one in terms of the other, after all. - Maks Orlovich On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated June 29, 2012, 6:06 p.m.) Review request for kdelibs. Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement Date.toISOString
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/#review15459 --- kjs/date_object.cpp http://git.reviewboard.kde.org/r/105386/#comment12089 what if hour becomes negative here? - Maks Orlovich On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/ --- (Updated June 29, 2012, 6:06 p.m.) Review request for kdelibs. Description --- kjs: Implement Date.toISOString mostly copied from ToUTCString but with different format and behavior, -MM-DDTHH:mm:ss:sssZ and exception throwing on invalid date Diffs - kjs/date_object.h ed45720 kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105386/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Range needs a prototype
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105388/#review15460
---
Ship it!
Ship It!
- Maks Orlovich
On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105388/
---
(Updated June 29, 2012, 6:06 p.m.)
Review request for kdelibs.
Description
---
kjs: Range needs a prototype
some websites do stuff like
if (Range.prototype.someFunction !== undefined)
{
Range.prototype.someFunction = ourOwnFunction;
}
the problem is we report no prototype, and thus we have
Range - undefined.someFunction
which will always fail and throw an exception.
But Range should have a prototype, so this patch adds its valid prototype and
makes some websites happy.
Diffs
-
khtml/ecma/kjs_range.cpp 500ebbd
Diff: http://git.reviewboard.kde.org/r/105388/diff/
Testing
---
Thanks,
Bernd Buschinski
Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/#review15461 --- Ship it! kjs/array_object.cpp http://git.reviewboard.kde.org/r/105391/#comment12090 I was thinking you could get rid of the if (element-isObject()) conditional as well. - Maks Orlovich On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/ --- (Updated July 4, 2012, 10:27 p.m.) Review request for kdelibs. Description --- kjs: Use toPrimitive in Array.join to get the correct String the default value case for String is present here, as testcase S15.4.4.5_A3.2_T2 shows Diffs - kjs/array_object.cpp 0da29b0 Diff: http://git.reviewboard.kde.org/r/105391/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement JSON.parse
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15462 --- kjs/jsonlexer.cpp http://git.reviewboard.kde.org/r/105056/#comment12091 What about two commas in a row? kjs/jsonlexer.cpp http://git.reviewboard.kde.org/r/105056/#comment12093 what if this puts you past the end of the string? - Maks Orlovich On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:50 p.m.) Review request for kdelibs. Description --- kjs: Implement JSON.parse Diffs - kjs/CMakeLists.txt 1188064 kjs/interpreter.cpp cf1acf1 kjs/json_object.h PRE-CREATION kjs/json_object.cpp PRE-CREATION kjs/jsonlexer.h PRE-CREATION kjs/jsonlexer.cpp PRE-CREATION kjs/libkjs.map e9f679f Diff: http://git.reviewboard.kde.org/r/105056/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement Date.toISOString
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/ --- (Updated July 6, 2012, 5:47 p.m.) Review request for kdelibs. Changes --- oh yes, even one minute can change the hour, day, month and even year Description --- kjs: Implement Date.toISOString mostly copied from ToUTCString but with different format and behavior, -MM-DDTHH:mm:ss:sssZ and exception throwing on invalid date Diffs (updated) - kjs/date_object.h ed45720 kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105386/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated July 6, 2012, 6:30 p.m.) Review request for kdelibs. Changes --- kjs: Mark Date Infinity as invalid cleanup Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs (updated) - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement JSON.parse
On July 6, 2012, 3:12 p.m., Maks Orlovich wrote: kjs/jsonlexer.cpp, line 309 http://git.reviewboard.kde.org/r/105056/diff/7/?file=71399#file71399line309 What about two commas in a row? propAdded handles this (tested), we will hit the TokComma case 2 times in a row case TokComma: // Skip Comma and parse next Array Element // if we found a comma without a leading property, this is invalid syntax if (!propAdded) return 0; propAdded = false; - Bernd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15462 --- On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:50 p.m.) Review request for kdelibs. Description --- kjs: Implement JSON.parse Diffs - kjs/CMakeLists.txt 1188064 kjs/interpreter.cpp cf1acf1 kjs/json_object.h PRE-CREATION kjs/json_object.cpp PRE-CREATION kjs/jsonlexer.h PRE-CREATION kjs/jsonlexer.cpp PRE-CREATION kjs/libkjs.map e9f679f Diff: http://git.reviewboard.kde.org/r/105056/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement JSON.parse
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 6, 2012, 7:11 p.m.) Review request for kdelibs. Description --- kjs: Implement JSON.parse Diffs (updated) - kjs/CMakeLists.txt 1188064 kjs/interpreter.cpp cf1acf1 kjs/json_object.h PRE-CREATION kjs/json_object.cpp PRE-CREATION kjs/jsonlexer.h PRE-CREATION kjs/jsonlexer.cpp PRE-CREATION kjs/libkjs.map e9f679f Diff: http://git.reviewboard.kde.org/r/105056/diff/ Testing --- Thanks, Bernd Buschinski
Question about the shutdown dialog's reboot list implementation
Hi, I am working on a patch for bug #297209 (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help but notice that since the Shutdown Dialog was QMLified, the code that shows the reboot list (when long-clicking the Reboot button) has been moved in the QML code of the theme (http://lxr.kde.org/source/kde/kde-workspace/ksmserver/themes/default/main.qml#319), which means that every theme should duplicate this code. I have a proper fix for the above mentioned bug written in C++ (generate a proper QMenu with submenus) which applies perfectly on the 4.8 branch (which is C++ only), so I was thinking maybe generate the menu in the C++ part of the code and pass it on to the QML theme? Being a total QML newbie I don't know if that's possible, plus after a quick search I can't figure out how to implement submenus for the context menu in QML (it uses a custom ContextMenu component). I wouldn't like to dig in QML just for this and I think it makes more sense if the list was centrally generated and not in every theme. Still, if the code should reside in the theme, I would appreciate any pointers as to how implement submenus in the context menu. -- Konstantinos Smanis
khtml/kmultipart/kmultipart.cpp uses wrong signal
Hi, for this trivial bugfix I'd rather not go through reviewboard: Error: Object::connect: No such signal KHTMLPartBrowserExtension::openURLNotify() Object::connect: (sender name: 'KHTMLBrowserExtension') Object::connect: No such signal KHTMLPartBrowserExtension::setLocationBarURL(QString) Object::connect: (sender name: 'KHTMLBrowserExtension') Patch: --- a/khtml/kmultipart/kmultipart.cpp +++ b/khtml/kmultipart/kmultipart.cpp @@ -356,8 +356,8 @@ void KMultiPart::setPart( const QString mimeType ) // Forward signals from the part's browser extension // this is very related (but not exactly like) KHTMLPart::processObjectRequest -connect( childExtension, SIGNAL(openURLNotify()), - m_extension, SIGNAL(openURLNotify()) ); +connect( childExtension, SIGNAL(openUrlNotify()), + m_extension, SIGNAL(openUrlNotify()) ); connect( childExtension, SIGNAL(openUrlRequestDelayed(KUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)), m_extension, SIGNAL(openUrlRequest(KUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)) ); @@ -380,8 +380,8 @@ void KMultiPart::setPart( const QString mimeType ) connect( childExtension, SIGNAL(enableAction(const char*,bool)), m_extension, SIGNAL(enableAction(const char*,bool)) ); -connect( childExtension, SIGNAL(setLocationBarURL(QString)), - m_extension, SIGNAL(setLocationBarURL(QString)) ); +connect( childExtension, SIGNAL(setLocationBarUrl(QString)), + m_extension, SIGNAL(setLocationBarUrl(QString)) ); connect( childExtension, SIGNAL(setIconUrl(KUrl)), m_extension, SIGNAL(setIconUrl(KUrl)) ); connect( childExtension, SIGNAL(loadingProgress(int)), -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at signature.asc Description: This is a digitally signed message part.
Re: Review Request: More kio_sftp login related fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104642/#review15480 --- This review has been submitted with commit 51d580a019c67a7bf6751db8391738aa27c8ef66 by Dawit Alemayehu to branch master. - Commit Hook On April 26, 2012, 3:42 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104642/ --- (Updated April 26, 2012, 3:42 a.m.) Review request for KDE Runtime and Andreas Schneider. Description --- This is the last one of the sftp login fixes series and addresses the following problems: #1. Correctly handle login failure that results from a different username being used when setting the SSH_OPTIONS_USER option and calling ssh_userauth_password. I think this might have been due to a regression caused by my previous patch. Nonetheless, this patch addresses it. #2. Changed public key authentication so that incorrect public key passwords generate a retry dialog instead of simply continuing to the next available authentication method. Diffs - kioslave/sftp/kio_sftp.h f497c0b kioslave/sftp/kio_sftp.cpp e38c629 Diff: http://git.reviewboard.kde.org/r/104642/diff/ Testing --- Testing for #1: === 1.) Make sure a ssh server is running on your system. 2.) Attempt to login into your system: sftp://127.0.0.1. 3.) When prompted for credentials, enter a user name other than the currently logged in user. Current Behavior: Login attempt will simply fail eventually and and error page is displayed. New (Fixed) Behavior: Successfully log into the server with the specified user name. Testing for #2: === 1.) Create a ssh key with password protection and add it to the authorized_keys file. 2.) Make sure the ssh public key is in your .ssh directory. 3.) Attempt to login into your system: sftp://127.0.0.1 4.) When prompted for the passpharse for the key, enter a bogus password. Current behavior: No retry dialog is ever shown for an invalid or improper ssh key passphrase and the process simply moves on to the next authentication method. New(Fixed) behavior: Show a retry dialog if the failure is due to invalid password. If the user then presses cancel on the retry dialog, simply behave the same way as if the cancel button is pressed on the password dialog. That is continue onto the next authentication method. Thanks, Dawit Alemayehu
Re: Question about the shutdown dialog's reboot list implementation
Em Friday 06 July 2012, Konstantinos Smanis escreveu: Hi, Hi, I am working on a patch for bug #297209 (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help but notice that since the Shutdown Dialog was QMLified, the code that shows the reboot list (when long-clicking the Reboot button) has been moved in the QML code of the theme (http://lxr.kde.org/source/kde/kde-workspace/ksmserver/themes/default/main. qml#319), which means that every theme should duplicate this code. I have a proper fix for the above mentioned bug written in C++ (generate a proper QMenu with submenus) which applies perfectly on the 4.8 branch (which is C++ only), so I was thinking maybe generate the menu in the C++ part of the code and pass it on to the QML theme? Being a total QML newbie I don't know if that's possible, plus after a quick search I can't figure out how to implement submenus for the context menu in QML (it uses a custom ContextMenu component). I wouldn't like to dig in QML just for this and I think it makes more sense if the list was centrally generated and not in every theme. Still, if the code should reside in the theme, I would appreciate any pointers as to how implement submenus in the context menu. I am the one that implemented the QML shutdown menu. I moved the code that creates the reboot menu to QML to give the possibility to create different QML themes that do not necessarily need to handle all the options ksmserver implements or to show the reboot entries using any QML component available (not necessarily a menu). It's not possible to use QMenu (or other QWidgets subclasses) in QML as far as I know. I think we can implement submenus in the default theme (in QML). For a quick fix you can try passing the correct grub index to the rebootOptions context variable (this must be done in shutdowndlg.cpp) and then assign it to variable itemData[itemIndex] in main.qml. That should make it select the correct boot option. The menu will still be linear (without submenus), we can fix that later. -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br
Re: Question about the shutdown dialog's reboot list implementation
Em Friday 06 July 2012, Konstantinos Smanis escreveu: On Sat, Jul 7, 2012 at 1:02 AM, Lamarque V. Souza lamar...@kde.org wrote: Em Friday 06 July 2012, Konstantinos Smanis escreveu: Hi, Hi, I am working on a patch for bug #297209 (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help but notice that since the Shutdown Dialog was QMLified, the code that shows the reboot list (when long-clicking the Reboot button) has been moved in the QML code of the theme (http://lxr.kde.org/source/kde/kde-workspace/ksmserver/themes/default/ma in. qml#319), which means that every theme should duplicate this code. I have a proper fix for the above mentioned bug written in C++ (generate a proper QMenu with submenus) which applies perfectly on the 4.8 branch (which is C++ only), so I was thinking maybe generate the menu in the C++ part of the code and pass it on to the QML theme? Being a total QML newbie I don't know if that's possible, plus after a quick search I can't figure out how to implement submenus for the context menu in QML (it uses a custom ContextMenu component). I wouldn't like to dig in QML just for this and I think it makes more sense if the list was centrally generated and not in every theme. Still, if the code should reside in the theme, I would appreciate any pointers as to how implement submenus in the context menu. I am the one that implemented the QML shutdown menu. I moved the code that creates the reboot menu to QML to give the possibility to create different QML themes that do not necessarily need to handle all the options ksmserver implements or to show the reboot entries using any QML component available (not necessarily a menu). It's not possible to use QMenu (or other QWidgets subclasses) in QML as far as I know. I think we can implement submenus in the default theme (in QML). For a quick fix you can try passing the correct grub index to the rebootOptions context variable (this must be done in shutdowndlg.cpp) and then assign it to variable itemData[itemIndex] in main.qml. That should make it select the correct boot option. The menu will still be linear (without submenus), we can fix that later. -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br It already works fine without even touching the ksmserver stuff (my only modifications are in kdm's parsing) but it looks quite ugly without submenus: http://i50.tinypic.com/96bw35.png In the screenshot above, the root menu should only contain 4 items, the second of which should be a submenu. As I mentioned, I have already implemented the transformation from a linear list to a menu with levels, but it is in C++ if that's going to be of any help at all. PS: The 'nested test' submenu in the screenshot is in fact 'nested test' in the config file (for my testing purposes). I guess the ampersand is erroneously treated as an accelerator while it shouldn't. Needs to be fixed as well. Ok, so it's a GUI only problem now. I need to figure out how to create submenus with the custom contextmenu component or use the one from kde-runtime if it supports submenus. -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br
