Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review13110
---
This review has been submitted with commit
d5b2e642a75ed4f042121326957dff06be80ea91 by Lamarque V. Souza to branch KDE/4.8.
- Commit Hook
On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review12971
---
bump. what's the status of this?
- Aleix Pol Gonzalez
On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review13003
---
Ship it!
Ship It!
- Laszlo Papp
On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote:
experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14
http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line14
I didn't check, but how is INCLUDE_INSTALL_DIR set ?
Is it done by via find_package(KDE4) ?
In this case, INCLUDE_INSTALL_DIR is a relative path under Windows, so
the config file wouldn't work properly under Windows.
Lamarque Vieira Souza wrote:
I do not know, INCLUDE_INSTALL_DIR was already used in
libkdeclarative/CMakeLists.txt before I created this patch. I am just using
it.
Any more questions about this patch? Can I push it?
- Lamarque Vieira
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11151
---
On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote:
experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12
http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line12
You may want to use something like
KDeclarative_SOURCE_DIR, which is defined if there is a project call
like
project(KDeclarative)
in the KDeclarative CMakeLists.txt. You could then also check whether
this variable is actually set, and error out if not.
Lamarque Vieira Souza wrote:
Both KDECLARATIVE_INCLUDE_DIRS and PROJECT_SOURCE_DIR contain the same
value. What is the difference in using one or the other?
Alexander Neundorf wrote:
KDeclarative_SOURCE_DIR, not KDECLARATIVE_INCLUDE_DIRS.
KDeclarative_SOURCE_DIR is only set if you are inside the expected source
tree (which should then contain a respective project() calls).
I meant KDeclarative_SOURCE_DIR in my in my last comment, not
KDECLARATIVE_INCLUDE_DIRS. Actually the correct name is kdeclarative_SOURCE_DIR
according to CMakeCache.txt. I still do not understand why using
kdeclarative_SOURCE_DIR is better than the current implementation.
- Lamarque Vieira
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11151
---
On March 5, 2012, 9:55 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote:
experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14
http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line14
I didn't check, but how is INCLUDE_INSTALL_DIR set ?
Is it done by via find_package(KDE4) ?
In this case, INCLUDE_INSTALL_DIR is a relative path under Windows, so
the config file wouldn't work properly under Windows.
I do not know, INCLUDE_INSTALL_DIR was already used in
libkdeclarative/CMakeLists.txt before I created this patch. I am just using it.
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote:
experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12
http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line12
You may want to use something like
KDeclarative_SOURCE_DIR, which is defined if there is a project call
like
project(KDeclarative)
in the KDeclarative CMakeLists.txt. You could then also check whether
this variable is actually set, and error out if not.
Both KDECLARATIVE_INCLUDE_DIRS and PROJECT_SOURCE_DIR contain the same value.
What is the difference in using one or the other?
- Lamarque Vieira
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11151
---
On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
On March 2, 2012, 6:57 p.m., Laszlo Papp wrote:
I am a bit of layman in here (thus pardon me), but I would personally
prefer a separated location for these config files. Something like either
cmake/modules or in the experimental subfolder itself right next to the
CTestConfig.cmake (I do not personally know what is the best practice
here). You can see an example for cmake/modules from Stephen in grantlee,
but the cmake example, about it, puts it into the $projectroot. Admittedly,
it would be nice to hear some kde-buildsystem guy(s) to comment on this,
like Alex, Stephen, etc. :)
Thank you for your effort about it really, by the way!
Alexander Neundorf wrote:
Do you mean the location when installed ?
This has to be ${LIB_INSTALL_DIR}/cmake/KDeclarative/ (ok, some small
variations on this are also supported).
Alex
I still do not get why use a different path than
${LIB_INSTALL_DIR}/cmake/KDeclarative/. Just because the library is
experimental? By the way, why is libkdeclarative still experimental? Device
Notifier from kde-workspace 4.8.0 already depends on it. Shouldn't we upgrade
libkdeclarative to stable?
- Lamarque Vieira
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11090
---
On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote:
experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12
http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line12
You may want to use something like
KDeclarative_SOURCE_DIR, which is defined if there is a project call
like
project(KDeclarative)
in the KDeclarative CMakeLists.txt. You could then also check whether
this variable is actually set, and error out if not.
Lamarque Vieira Souza wrote:
Both KDECLARATIVE_INCLUDE_DIRS and PROJECT_SOURCE_DIR contain the same
value. What is the difference in using one or the other?
KDeclarative_SOURCE_DIR, not KDECLARATIVE_INCLUDE_DIRS.
KDeclarative_SOURCE_DIR is only set if you are inside the expected source tree
(which should then contain a respective project() calls).
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11151
---
On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 5, 2012, 9:55 p.m.)
Review request for kdelibs.
Changes
---
Add set(KDECLARATIVE_FOUND true) to satisfy macro_log_feature calls.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs (updated)
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Changes
---
Small changes.
Description (updated)
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing (updated)
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
Re: Review Request: Add cmake config for kdeclarative library.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11090
---
I am a bit of layman in here (thus pardon me), but I would personally prefer a
separated location for these config files. Something like either cmake/modules
or in the experimental subfolder itself right next to the CTestConfig.cmake
(I do not personally know what is the best practice here). You can see an
example for cmake/modules from Stephen in grantlee, but the cmake example,
about it, puts it into the $projectroot. Admittedly, it would be nice to hear
some kde-buildsystem guy(s) to comment on this, like Alex, Stephen, etc. :)
Thank you for your effort about it really, by the way!
- Laszlo Papp
On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
---
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Description
---
Currently kdeclarative library does not install the KDeclarativeConfig.cmake
and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative
and so other KDE programs cannot find the library using cmake's find_package
macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the
kdeclarative library name in their CMakeLists.txt, which is not ideal. Once
this patch is submitted we need to fix their CMakeLists.txt to use
find_package(KDeclarative REQUIRED).
Diffs
-
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing
---
I can now compile kde-workspace/ksmserver without using the custom made
FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
