Re: Review Request 122471: Enable Compilation of about Protocol
On Feb. 8, 2015, 9:19 a.m., Laurent Montel wrote: about/kio_about.cpp, line 59 https://git.reviewboard.kde.org/r/122471/diff/1/?file=347423#file347423line59 QApplication app(argc, argv); app.setApplicationName(QLatin1String(kio_about)); = you remove KComponentData which is in kdelibs4support Well, QCoreApplication is enough. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75584 --- On Feb. 7, 2015, 10:23 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 7, 2015, 10:23 p.m.) Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Re: Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75584 --- about/kio_about.cpp https://git.reviewboard.kde.org/r/122471/#comment52281 QApplication app(argc, argv); app.setApplicationName(QLatin1String(kio_about)); = you remove KComponentData which is in kdelibs4support - Laurent Montel On fév. 7, 2015, 10:23 après-midi, David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated fév. 7, 2015, 10:23 après-midi) Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Re: Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75586 --- What Laurent said, plus a bug in the commit log: you ported away from KUrl, not QUrl :-) - David Faure On Feb. 7, 2015, 10:23 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 7, 2015, 10:23 p.m.) Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Re: Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75619 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2015, 11:23 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 7, 2015, 11:23 p.m.) Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Re: Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 9, 2015, 6:03 a.m.) Review request for kde-workspace and David Faure. Changes --- Porting away from KUrl,KDE_EXPORT and KComponentData. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs (updated) - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Re: Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75657 --- Seems good. Did you changed commit message as David told you ? Otherwise ship it. - Laurent Montel On fév. 9, 2015, 6:03 matin, David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated fév. 9, 2015, 6:03 matin) Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
Review Request 122471: Enable Compilation of about Protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- Review request for kde-workspace and David Faure. Repository: kio-extras Description --- Basically porting away from QUrl and KDE_EXPORT Diffs - CMakeLists.txt 3379ce7 about/kio_about.h 620d6aa about/kio_about.cpp d7396d8 Diff: https://git.reviewboard.kde.org/r/122471/diff/ Testing --- Tested compilation and installation: $ find /home/david/kio-install/ -name *about* /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez
