D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel edited the summary of this revision.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel created this revision.
shrapnel added reviewers: VDG, Zren.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shrapnel requested review of this revision.

REVISION SUMMARY
  File containing taiwanese holidays

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/plan2/holiday_tw_zh

To: shrapnel, #vdg, Zren
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/60/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 04:03:44 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/52/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 16 Apr 2020 04:03:44 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34937/62151)40%
(17733/43906)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10282)46%
(4583/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4465/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8344)43%
(2076/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 551 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/551/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Apr 2020 04:03:44 +
 Build duration:
6 min 4 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34929/62149)40%
(17725/43910)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10283)46%
(4580/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4461/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D28870: Updated test file for Logtalk syntax highlighting

[Paulo Moura]

pmoura retitled this revision from "Updated test file for syntax highlighting" 
to "Updated test file for Logtalk syntax highlighting".
pmoura edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28870

To: pmoura, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28796: Update Logtalk language syntax support

[Paulo Moura]

pmoura added a comment.


  See https://phabricator.kde.org/D28870

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D28870: Updated test file for syntax highlighting

[Paulo Moura]

pmoura created this revision.
pmoura added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
pmoura requested review of this revision.

REVISION SUMMARY
  Updated test file for syntax highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28870

AFFECTED FILES
  autotests/input/highlight.lgt

To: pmoura, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Proposal: "Noteworthy" label for Promo application updates

[Nate Graham]

On 4/15/20 3:40 PM, Albert Astals Cid wrote:

El dimecres, 15 d’abril de 2020, a les 16:04:53 CEST, Nate Graham va escriure:

I support a standardized tag/keyword/whatever to attract promo attention
to something. However if we use a GitLab tag, then we won't be capturing
information from Phabricator patches during the time before we've fully
transitioned to GitLab. Should we instead use a new NOTEWORTHY: Bugzilla
keyword (like BUG: or FEATURE:) or wait do do this until after the
GitLab migration is complete?


You mean something like CHANGELOG ;)

We already have it documented at 
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

People (me included) just sadly don't use it.


Oh man, look at that.

Sounds like we already have exactly what we need, we just need to start 
using it! I can start doing that for reviews I participate in.


What would be the workflow for the promo folks being able to collect a 
list of all commits with this keyword? grep through git logs?


Nate

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Instead of copying all positions and applying the the shift on the
  copies, apply the shift when comparing the positions.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28865

AFFECTED FILES
  src/engine/phraseanditerator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28863: [Extractor] Fix idle monitoring

[Stefan Brüns]

bruns added a dependent revision: D28864: [Extractor] Better balance idle and 
busy mode.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28863

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28864: [Extractor] Better balance idle and busy mode

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Add an additional delay of 500ms after each batch when the computer is
  in use. Skip any delay if the file has not been indexed.
  
  Depends on D28863 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28864

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractor/app.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns added a dependent revision: D28863: [Extractor] Fix idle monitoring.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28863: [Extractor] Fix idle monitoring

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Resume events are only signaled when KIdleTime has been explicitly told
  to do so.
  
  Depends on D28862 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28863

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  IdleStateMonitor is just a wrapper around KIdleTime, which can be
  implemented in a few lines inline.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4e7626c9488b: [OrpostingIterator] Allow skipping 
elements, implement skipTo (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28845?vs=80163=80235

REVISION DETAIL
  https://phabricator.kde.org/D28845

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28844: [PhraseAndIterator] Replace recursive next() implementation

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c00cf2022763: [PhraseAndIterator] Replace recursive 
next() implementation (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28844?vs=80161=80234

REVISION DETAIL
  https://phabricator.kde.org/D28844

AFFECTED FILES
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28843: [AndPostingIterator] Replace recursive next() implementation

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5d20560ef6d6: [AndPostingIterator] Replace recursive 
next() implementation (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28843?vs=80160=80233

REVISION DETAIL
  https://phabricator.kde.org/D28843

AFFECTED FILES
  src/engine/andpostingiterator.cpp
  src/engine/andpostingiterator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Proposal: "Noteworthy" label for Promo application updates

[Albert Astals Cid]

El dimecres, 15 d’abril de 2020, a les 16:04:53 CEST, Nate Graham va escriure:
> I support a standardized tag/keyword/whatever to attract promo attention 
> to something. However if we use a GitLab tag, then we won't be capturing 
> information from Phabricator patches during the time before we've fully 
> transitioned to GitLab. Should we instead use a new NOTEWORTHY: Bugzilla 
> keyword (like BUG: or FEATURE:) or wait do do this until after the 
> GitLab migration is complete?

You mean something like CHANGELOG ;)

We already have it documented at 
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

People (me included) just sadly don't use it.

Cheers,
  Albert

> 
> Nate
> 
> 
> 
> On 4/15/20 6:19 AM, Julian wrote:
> > Hello everyone,
> > 
> > As you all are probably aware, KDE Promo writes monthly updates on what 
> > happens within our applications and also promotes the releases done by 
> > the Release Service (like Dolphin 20.04, Kate 20.04, Kontact, etc.). For 
> > these updates, we need to get all important new features and bug fixes 
> > that are present in the latest releases.
> > 
> > Up until now, we have reached out to developers every time we wanted to 
> > compile such feature lists. This approach has several drawbacks:
> > 
> > - Projects occasionally forget to add their new features. This leaves us 
> > with the choice to either seek out all changes ourselves (which is very 
> > time consuming) or omit the application in the writeup (which is not 
> > good either)- Smaller projects might be left out because we do not know 
> > that they have released something cool- There is an inevitable waiting 
> > period between us asking for a feature list and the completion of the 
> > list. This can lead to delays in the announcement process and lowers the 
> > quality of the announcement (for example, because translators don't have 
> > the time to translate the text before it is made public)
> > 
> > We would therefore like to propose a different approach.
> > 
> >   1. Get a standardized "Noteworthy" label added on Invent. 2. Whenever 
> > a noteworthy change is merged (that is, a cool new feature or an 
> > important bug fix), the reviewers add said label. 3. When Promo drafts 
> > release notes or other updates, we can filter for said label and 
> > instantly see all relevant changes.
> > 
> > This ensures that no important contributions are overlooked and results 
> > in a much smoother workflow for Promo. We'd like to get feedback from 
> > developers on this proposal and if no major objections are raised, 
> > implement this workflow change as soon as code hosting is fully 
> > transitioned to GitLab.
> > 
> > Best regards,Julian / xyquadrat on behalf of KDE Promo
> > 
> > P.S.: Please note that we still need your notes on changes for the 20.04 
> > release, however. Visit https://share.kde.org/s/SJqzmemQ3PsrmGR and add 
> > in noteworthy features and bug fixes there.
> > 
> 
> 

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb added a comment.


  I now generate the CSS from aether-sass. The code can be found 
https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss.
  And all tree wikis are using it.
  
  @ochurlaud should I create a sysadmin request for you to get access to the 
repo in invent so that you can edit it if you need?

REPOSITORY
  R264 KApiDox

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> trashimpl.cpp:1092
> +TrashSizeCache trashSize(trashPath);
> +TrashSizeCache::SizeAndModTime res = 
> trashSize.calculateSizeAndLatestModDate();
> +size += res.size;

It's actually this call which triggers the unittest failure.

I wonder if maybe this happens at the wrong time

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28861: Sonnet add Malayalam trigram

[Aiswarya Kaitheri Kandoth]

aiswaryak created this revision.
aiswaryak created this object with visibility "All Users".
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aiswaryak requested review of this revision.

REVISION SUMMARY
  Add Malayalam trigram which is absent in the current list of trigrams in 
Sonnet.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28861

AFFECTED FILES
  data/trigrams/ml_IN

To: aiswaryak
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Abstract Software]

abstractdevelop added a comment.


  Hey, thanks for this @poboiko  I used to have to implement this myself, so 
this will be very useful in my app, O20.Word. ;)

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure added a comment.


  TestTrash::renameDirInTrash makes the dir cache invalid (it still lists 
trashDirFromHome). I think because of the optimization that we don't always 
care about the size... but this had the side effect of keeping the cache 
uptodate I wonder if the test is too strict and an old cache isn't better 
than keeping it coherent at extra cost... I'll dig further.

INLINE COMMENTS

> trashimpl.cpp:411
>  
> -const qulonglong pathSize = DiscSpaceUtil::sizeOfPath(origPath);
> -

This was done unconditionally...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D26034: Replace KLocalSocket with QLocalSocket

[David Faure]

dfaure added a comment.


  It built but apparently the unittests for KIO are disabled on CI :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krichtextedit.cpp:346
> +// level=2 look the same
> +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0;
> +

If boundedLevel is 6, the size adjustement will be -1?
Does this mean a heading that's smaller than normal text?

> krichtextedit.cpp:375
> +
> +cursor.mergeBlockCharFormat(chrfmt);
> +setTextCursor(cursor);

This seems to duplicate what happened with selectCursor already. Why are two 
cursors necessary to change the style of one paragraph?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb updated this revision to Diff 80229.
ognarb added a comment.


  - Fix typo in path
  - Add information about there to find the source of the css files

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80228=80229

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb updated this revision to Diff 80228.
ognarb added a comment.
This revision is now accepted and ready to land.


  - Use version from cdn

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80156=80228

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: Disable shortcuts in GitLab invent.kde.org

[Ben Cooksley]

On Thu, Apr 16, 2020 at 6:41 AM David Hurka  wrote:
>

Hi David,

> According to this help page, it should be possible to disable shortcuts in
> gitlab:
> https://docs.gitlab.com/ee/user/shortcuts.html
> But the said option is not available in our GitLab instance. Is there any way
> to disable shortcuts?

I've just checked, and the option is definitely available to me on our instance.
You have tried pressing ? when on any screen in our Gitlab yes?

If you have, i'd be inclined to suspect that Falkon is interfering in
the proper operation of Gitlab.

>
> I really want to disable them, because they don’t have any advantage over
> Falkons spatial navigation, and do a lot of harm. It happens so often to me
> that I unfocus the text boxes for some reason, and then trigger various of
> these shortcuts instead. :(
>
>

Cheers,
Ben

D28854: [KRichTextWidget] Add support for headings

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R310 KTextWidgets

BRANCH
  textwidget-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Proposal: "Noteworthy" label for Promo application updates

[Ben Cooksley]

On Thu, Apr 16, 2020 at 2:05 AM Nate Graham  wrote:
>
> I support a standardized tag/keyword/whatever to attract promo attention
> to something. However if we use a GitLab tag, then we won't be capturing
> information from Phabricator patches during the time before we've fully
> transitioned to GitLab. Should we instead use a new NOTEWORTHY: Bugzilla
> keyword (like BUG: or FEATURE:) or wait do do this until after the
> GitLab migration is complete?

The Gitlab migration (for code hosting and review) is a matter of
weeks away at this stage, so the window of time you're thinking of
there is very small.

>
> Nate
>

Cheers,
Ben

>
>
> On 4/15/20 6:19 AM, Julian wrote:
> > Hello everyone,
> >
> > As you all are probably aware, KDE Promo writes monthly updates on what
> > happens within our applications and also promotes the releases done by
> > the Release Service (like Dolphin 20.04, Kate 20.04, Kontact, etc.). For
> > these updates, we need to get all important new features and bug fixes
> > that are present in the latest releases.
> >
> > Up until now, we have reached out to developers every time we wanted to
> > compile such feature lists. This approach has several drawbacks:
> >
> > - Projects occasionally forget to add their new features. This leaves us
> > with the choice to either seek out all changes ourselves (which is very
> > time consuming) or omit the application in the writeup (which is not
> > good either)- Smaller projects might be left out because we do not know
> > that they have released something cool- There is an inevitable waiting
> > period between us asking for a feature list and the completion of the
> > list. This can lead to delays in the announcement process and lowers the
> > quality of the announcement (for example, because translators don't have
> > the time to translate the text before it is made public)
> >
> > We would therefore like to propose a different approach.
> >
> >   1. Get a standardized "Noteworthy" label added on Invent. 2. Whenever
> > a noteworthy change is merged (that is, a cool new feature or an
> > important bug fix), the reviewers add said label. 3. When Promo drafts
> > release notes or other updates, we can filter for said label and
> > instantly see all relevant changes.
> >
> > This ensures that no important contributions are overlooked and results
> > in a much smoother workflow for Promo. We'd like to get feedback from
> > developers on this proposal and if no major objections are raised,
> > implement this workflow change as soon as code hosting is fully
> > transitioned to GitLab.
> >
> > Best regards,Julian / xyquadrat on behalf of KDE Promo
> >
> > P.S.: Please note that we still need your notes on changes for the 20.04
> > release, however. Visit https://share.kde.org/s/SJqzmemQ3PsrmGR and add
> > in noteworthy features and bug fixes there.
> >
>

Disable shortcuts in GitLab invent.kde.org

[David Hurka]

According to this help page, it should be possible to disable shortcuts in 
gitlab:
https://docs.gitlab.com/ee/user/shortcuts.html
But the said option is not available in our GitLab instance. Is there any way 
to disable shortcuts?

I really want to disable them, because they don’t have any advantage over 
Falkons spatial navigation, and do a lot of harm. It happens so often to me 
that I unfocus the text boxes for some reason, and then trigger various of 
these shortcuts instead. :(

D28796: Update Logtalk language syntax support

[Paulo Moura]

pmoura added a comment.


  There is a more recent version of that file. How to proceed? By creating a 
new review request for that file with a diff? Or is there a way to associate it 
with this review request?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

Re: Polish translation of "Cancel"

[Nate Graham]

On 4/15/20 11:29 AM, Nicolás Alvarez wrote:

I started reading that bug report, then I realized how *incredibly long* it was 
and switched to fast skimming.

Is there a single person apart from NSLW who is in favor of Zaniechaj?


Not that I can see.

Nate

D28811: Add drawer on mobile and clean code

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.


  OK it's clearer:
  
  Please add somewhere that it's a generated css so that no-one tries to change 
it by hand and ship it

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28814: TypeScript: add the "awaited" type operator

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1f1f03198aa7: TypeScript: add the awaited 
type operator (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28814?vs=80064=80222

REVISION DETAIL
  https://phabricator.kde.org/D28814

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28814: TypeScript: add the "awaited" type operator

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks ;=) Even with test.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-awaited-typescript

REVISION DETAIL
  https://phabricator.kde.org/D28814

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28796: Update Logtalk language syntax support

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Change looks reasonable, but could that testfile be added to our autotests 
directory? (or the file we have there extended)
  The current auto test file is autotests/input/highlight.lgt I assume.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28845

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28844: [PhraseAndIterator] Replace recursive next() implementation

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28844

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28843: [AndPostingIterator] Replace recursive next() implementation

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28843

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Polish translation of "Cancel"

[Konrad Kostecki]

"Zaniechaj" is a prehistoric naming for modern "anuluj", both means cancel.
First came with AmigaOS translation, second with Windows and last one is
what everybody used to. Personally I don't think there's any point to
debate on this.

śr., 15 kwi 2020, 19:30 użytkownik Nicolás Alvarez <
nicolas.alva...@gmail.com> napisał:

> El 15 abr. 2020, a la(s) 11:46, Nate Graham  escribió:
> >
> > [+ kde-devel mailing list since I don't know if I got the right
> localization mailing list and couldn't find a polish-specific one]
> >
> >
> > Hello translators,
> > I don't speak any Polish, but it's come to my attention that some native
> Polish speakers are complaining about the Polish translation of the word
> "Cancel", with no resolution on the issue:
> https://bugs.kde.org/show_bug.cgi?id=404286
> >
> > The bug has 150 votes and a lot of discussion. I think there's a fairly
> strong argument in favor of consistency. Given that consistency was even
> selected as an explicit KDE goal this year, my sense is that it would be
> good to be consistent with the translation used by the wider software
> world, even if it's maybe not perfect.
>
> I started reading that bug report, then I realized how *incredibly long*
> it was and switched to fast skimming.
>
> Is there a single person apart from NSLW who is in favor of Zaniechaj?
>
> --
> Nicolás

Re: Polish translation of "Cancel"

[Nicolás Alvarez]

El 15 abr. 2020, a la(s) 11:46, Nate Graham  escribió:
> 
> [+ kde-devel mailing list since I don't know if I got the right localization 
> mailing list and couldn't find a polish-specific one]
> 
> 
> Hello translators,
> I don't speak any Polish, but it's come to my attention that some native 
> Polish speakers are complaining about the Polish translation of the word 
> "Cancel", with no resolution on the issue: 
> https://bugs.kde.org/show_bug.cgi?id=404286
> 
> The bug has 150 votes and a lot of discussion. I think there's a fairly 
> strong argument in favor of consistency. Given that consistency was even 
> selected as an explicit KDE goal this year, my sense is that it would be good 
> to be consistent with the translation used by the wider software world, even 
> if it's maybe not perfect.

I started reading that bug report, then I realized how *incredibly long* it was 
and switched to fast skimming.

Is there a single person apart from NSLW who is in favor of Zaniechaj?

-- 
Nicolás

D28839: [PostingIterator] Make sure skipTo also works for first element

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:dd1b7a6d02a5: [PostingIterator] Make sure skipTo also 
works for first element (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28839?vs=80154=80221

REVISION DETAIL
  https://phabricator.kde.org/D28839

AFFECTED FILES
  src/engine/postingiterator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28850: Updated Romanian holidays

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:28ad589a1fbe: Updated Romanian holidays (authored by 
sionescu, committed by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28850?vs=80179=80220#toc

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28850?vs=80179=80220

REVISION DETAIL
  https://phabricator.kde.org/D28850

AFFECTED FILES
  holidays/plan2/holiday_ro_ro

To: sionescu, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/19/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 15 Apr 2020 16:34:35 +
 Build duration:
2 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 303 lines...][2020-04-15T16:35:34.354Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] Scanning dependencies of target symlink_autogen[2020-04-15T16:35:34.354Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] [ 33%] Automatic MOC for target symlink[2020-04-15T16:35:34.354Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] [ 33%] Built target symlink_autogen[2020-04-15T16:35:34.354Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] Scanning dependencies of target newline_autogen[2020-04-15T16:35:34.354Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.354Z] [ 37%] Automatic MOC for target newline[2020-04-15T16:35:34.616Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.616Z] [ 37%] Built target newline_autogen[2020-04-15T16:35:34.616Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.616Z] Scanning dependencies of target symlink[2020-04-15T16:35:34.616Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.616Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:34.616Z] [ 40%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:34.616Z] [ 44%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-04-15T16:35:36.007Z] [ 48%] Linking CXX executable ../bin/symlink[2020-04-15T16:35:36.007Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:36.007Z] [ 48%] Built target symlink[2020-04-15T16:35:36.007Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:36.007Z] Scanning dependencies of target newline[2020-04-15T16:35:36.007Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:36.007Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:36.007Z] [ 51%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:36.007Z] [ 55%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-04-15T16:35:37.381Z] [ 59%] Linking CXX executable ../bin/newline[2020-04-15T16:35:37.381Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.381Z] [ 59%] Built target newline[2020-04-15T16:35:37.381Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.381Z] Scanning dependencies of target dupe_autogen[2020-04-15T16:35:37.381Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.381Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.381Z] [ 62%] Automatic MOC for target dupe[2020-04-15T16:35:37.381Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.381Z] [ 62%] Built target dupe_autogen[2020-04-15T16:35:37.381Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.637Z] Scanning dependencies of target scalable_autogen[2020-04-15T16:35:37.637Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.637Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build'[2020-04-15T16:35:37.637Z] [ 66%] Automatic MOC for target scalable[2020-04-15T16:35:37.637Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 311 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/311/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Apr 2020 16:34:35 +
 Build duration:
1 min 54 sec and counting
   CONSOLE OUTPUT
  [...truncated 303 lines...][2020-04-15T16:35:39.750Z] [ 25%] Built target newline_autogen[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] [ 25%] Built target dupe_autogen[2020-04-15T16:35:39.750Z] [ 25%] Built target scalable_autogen[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] Scanning dependencies of target breeze-icons-mkdir[2020-04-15T16:35:39.750Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-04-15T16:35:39.750Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:39.750Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] [ 25%] Built target breeze-icons-dark-mkdir[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] [ 25%] Built target breeze-icons-mkdir[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] Scanning dependencies of target qrcAlias[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:40.009Z] Scanning dependencies of target symlink[2020-04-15T16:35:40.009Z] Scanning dependencies of target newline[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] [ 33%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:40.009Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:40.009Z] Scanning dependencies of target dupe[2020-04-15T16:35:40.009Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] make[2]: Entering directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:40.009Z] [ 40%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-04-15T16:35:40.009Z] [ 44%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-04-15T16:35:40.009Z] [ 48%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-04-15T16:35:40.009Z] [ 51%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:40.009Z] [ 55%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-04-15T16:35:43.301Z] [ 59%] Linking CXX executable bin/qrcAlias[2020-04-15T16:35:43.301Z] [ 62%] Linking CXX executable ../bin/dupe[2020-04-15T16:35:43.301Z] [ 66%] Linking CXX executable ../bin/newline[2020-04-15T16:35:43.301Z] [ 70%] Linking CXX executable ../bin/symlink[2020-04-15T16:35:43.600Z] make[2]: Leaving directory '/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build'[2020-04-15T16:35:43.600Z] make[2]: Leaving directory 

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/21/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 15 Apr 2020 16:34:35 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 181 lines...][2020-04-15T16:34:58.844Z]  * Qt5Test[2020-04-15T16:34:58.844Z]  * Qt5 (required version >= 5.12.0)[2020-04-15T16:34:58.844Z] [2020-04-15T16:34:58.844Z] -- Configuring done[2020-04-15T16:34:59.773Z] -- Generating done[2020-04-15T16:34:59.773Z] CMake Warning:[2020-04-15T16:34:59.773Z]   Manually-specified variables were not used by the project:[2020-04-15T16:34:59.773Z] [2020-04-15T16:34:59.773Z] BUILD_QCH[2020-04-15T16:34:59.773Z] [2020-04-15T16:34:59.773Z] [2020-04-15T16:34:59.773Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-04-15T16:35:00.468Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-04-15T16:35:00.468Z] Scanning dependencies of target scalable_autogen[2020-04-15T16:35:00.468Z] Scanning dependencies of target qrcAlias_autogen[2020-04-15T16:35:00.468Z] Scanning dependencies of target breeze-generate-24px-versions[2020-04-15T16:35:00.468Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-04-15T16:35:00.468Z] Scanning dependencies of target symlink_autogen[2020-04-15T16:35:00.468Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-04-15T16:35:00.468Z] Scanning dependencies of target breeze-icons-mkdir[2020-04-15T16:35:00.468Z] Scanning dependencies of target newline_autogen[2020-04-15T16:35:00.468Z] Scanning dependencies of target dupe_autogen[2020-04-15T16:35:00.468Z] [  7%] Generating 24px icons[2020-04-15T16:35:00.468Z] [  7%] Automatic MOC for target scalable[2020-04-15T16:35:00.468Z] [ 11%] Automatic MOC for target symlink[2020-04-15T16:35:00.468Z] [ 14%] Automatic MOC for target qrcAlias[2020-04-15T16:35:00.468Z] [ 18%] Automatic MOC for target newline[2020-04-15T16:35:00.468Z] [ 22%] Generating 24px icons dark[2020-04-15T16:35:00.468Z] [ 25%] Automatic MOC for target dupe[2020-04-15T16:35:00.468Z] Using POSIX-style sed arguments[2020-04-15T16:35:00.468Z] [ 25%] Built target breeze-icons-dark-mkdir[2020-04-15T16:35:00.468Z] Using POSIX-style sed arguments[2020-04-15T16:35:00.468Z] [ 25%] Built target breeze-icons-mkdir[2020-04-15T16:35:00.726Z] [ 25%] Built target qrcAlias_autogen[2020-04-15T16:35:00.726Z] Scanning dependencies of target qrcAlias[2020-04-15T16:35:00.726Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-04-15T16:35:00.726Z] [ 33%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:00.984Z] [ 33%] Built target newline_autogen[2020-04-15T16:35:00.984Z] [ 33%] Built target dupe_autogen[2020-04-15T16:35:00.984Z] [ 33%] Built target symlink_autogen[2020-04-15T16:35:00.984Z] [ 33%] Built target scalable_autogen[2020-04-15T16:35:00.984Z] Scanning dependencies of target newline[2020-04-15T16:35:00.984Z] Scanning dependencies of target dupe[2020-04-15T16:35:00.984Z] Scanning dependencies of target symlink[2020-04-15T16:35:00.984Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:00.984Z] Scanning dependencies of target scalable[2020-04-15T16:35:00.984Z] [ 40%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-04-15T16:35:00.984Z] [ 44%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:00.984Z] [ 48%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-04-15T16:35:00.984Z] [ 59%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:00.984Z] [ 59%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-04-15T16:35:00.984Z] [ 59%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-04-15T16:35:00.984Z] [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-04-15T16:35:01.546Z] [ 66%] Linking CXX executable bin/qrcAlias[2020-04-15T16:35:01.546Z] [ 66%] Built target qrcAlias[2020-04-15T16:35:01.546Z] Scanning dependencies of target breeze-icons-dark-rcc[2020-04-15T16:35:01.546Z] Scanning dependencies of target breeze-icons-rcc[2020-04-15T16:35:01.546Z] [ 70%] Generating res/breeze-icons-dark.qrc[2020-04-15T16:35:01.546Z] [ 74%] Generating res/breeze-icons.qrc[2020-04-15T16:35:02.110Z] /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.14/autotests/scalabletest.cpp:76:26: warning: result of comparison of constant -1 with _expression_ of type 

D28755: Breeze Icons cannot be built from read-only source location

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0a5dd2972b62: Allow building from a read-only source 
location (authored by marten).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28755?vs=79867=80219

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze, ngraham
Cc: ngraham, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham updated this revision to Diff 80218.
ngraham added a comment.


  Simpler enabled handling

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80217=80218

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28855: put minimumkeepsize actually in the netpref KCM

[Harald Sitter]

sitter added a comment.


  Coding style is actually wildly inconsistent in that file, so I've stuck to 
what similar other lines have.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28855

To: sitter, ngraham, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28855: put minimumkeepsize actually in the netpref KCM

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> netpref.cpp:87
> +connect(cb_globalMarkPartial, ::toggled,
> +partialWidget, [partialWidget](bool checked) { 
> partialWidget->setEnabled(checked); });
> +globalLayout->addWidget(partialWidget);

Why not "::setEnabled" instead of the lambda?

> netpref.cpp:89
> +globalLayout->addWidget(partialWidget);
> +auto partialLayout = new QFormLayout(gb_Global);
> +partialLayout->setContentsMargins(20, 0, 0, 0); // indent below mark 
> partial

This triggers this warning:

  QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a 
layout

I've just found out that QWidget::setLayout(QLayout *layout) will take 
ownership of "layout":
https://doc.qt.io/qt-5/qwidget.html#setLayout
so I guess there is no need to set a parent for partialLayout when 
instantiating it.

> netpref.cpp:92
> +partialWidget->setLayout(partialLayout);
> +sb_globalMinimumKeepSize = new KPluralHandlingSpinBox( this );
> +sb_globalMinimumKeepSize->setSuffix( ki18np( " byte", " bytes" ) );

Coding style, no space after ( or before ), IIUC.

> netpref.cpp:93
> +sb_globalMinimumKeepSize = new KPluralHandlingSpinBox( this );
> +sb_globalMinimumKeepSize->setSuffix( ki18np( " byte", " bytes" ) );
> +connect(sb_globalMinimumKeepSize, 
> QOverload::of(::valueChanged),

Same.

> netpref.cpp:96
> +this, ::configChanged);
> +partialLayout->addRow(i18nc( "@label:spinbox", "Minimum size required to 
> keep on cancel:" ),
> +  sb_globalMinimumKeepSize);

"If cancelled, automatically delete partially uploaded files smaller than"

And same coding style as before.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28855

To: sitter, ngraham, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham updated this revision to Diff 80217.
ngraham added a comment.


  Use TapHandler instead of MultiPointTouchArea

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80054=80217

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Méven Car]

meven added a comment.


  A consequence of this is the deviceName is used in fstab device description :
  
  F8240164: Screenshot_20200415_180517.png 

  
  Making planner the need for D28590 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

[Grzegorz Szymaszek]

On Wed, Apr 15, 2020 at 09:30:34AM -0600, Nate Graham  wrote:
> Shouldn't the mailing list be using standard KDE infrastructure?

Shouldn’t the Polish translation use common vocabulary instead of
reviving words that no one uses in real life? I’m afraid both answers
are “it should”.


-- 
Grzegorz


signature.asc
Description: PGP signature

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb added a comment.


  POC of sharing this code with the wikis: 
https://wikisandbox.kde.org/Welcome_to_KDE_TechBase

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: Polish translation of "Cancel"

[Nate Graham]

On 4/15/20 9:27 AM, Grzegorz Szymaszek wrote:

Hi,

On Wed, Apr 15, 2020 at 08:45:17AM -0600, Nate Graham  wrote:

[+ kde-devel mailing list since I don't know if I got the right localization
mailing list and couldn't find a polish-specific one]


FWIW, there are three mailing lists hosted at SourceForge:
https://sourceforge.net/p/kdei18n-pl/mailman/


That's surprising. Shouldn't the mailing list be using standard KDE 
infrastructure?


Nate

Re: Polish translation of "Cancel"

[Grzegorz Szymaszek]

Hi,

On Wed, Apr 15, 2020 at 08:45:17AM -0600, Nate Graham  wrote:
> [+ kde-devel mailing list since I don't know if I got the right localization
> mailing list and couldn't find a polish-specific one]

FWIW, there are three mailing lists hosted at SourceForge:
https://sourceforge.net/p/kdei18n-pl/mailman/


Regards

-- 
Grzegorz


signature.asc
Description: PGP signature

D28856: Save disabling of desktop file components in kglobalshortcutsrc

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> globalshortcutsregistry.cpp:274
> +auto disabledComponents = KConfigGroup(&_config, 
> "disabledComponents").readEntry("disabled", QStringList());
>  for (const QString  : groupList)
>  {

good point

> globalshortcutsregistry.cpp:333
>  for (const QString  : lstDesktopFiles) {
> -if (_components.contains(desktopFile)) {
> +if (_components.contains(desktopFile) || 
> disabledComponents.contains(desktopFile)) {
>  continue;

It actually is if you follow the constructor chain

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> globalshortcutsregistry.cpp:274
> +auto disabledComponents = KConfigGroup(&_config, 
> "disabledComponents").readEntry("disabled", QStringList());
>  for (const QString  : groupList)
>  {

`disabledComponents` is the group name, right? It would also be part of 
`groupList`, so it would try to load it as shortcut...

> globalshortcutsregistry.cpp:333
>  for (const QString  : lstDesktopFiles) {
> -if (_components.contains(desktopFile)) {
> +if (_components.contains(desktopFile) || 
> disabledComponents.contains(desktopFile)) {
>  continue;

Is `desktopFile` the equivalent to `component->uniqueName()`? I would assume 
no, so this check might need to be moved after the `KServiceActionComponent` 
construction

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added a comment.


  This has fixed the issues I was seeing with installation and uninstallation, 
nice! However I'm not seeing a very long hang when installing certain global 
themes--for example Sweet KDE and Layan Look and Feel Theme. It does ultimately 
work, but the dialog freezes for multiple minutes before finally becoming 
interactive again.

INLINE COMMENTS

> installation.cpp:105
> +// installed in knewstuff no longer will be, but since it never worked 
> right anyway... we'll
> +// simply have to live with that.
> +if (postInstallationCommand.startsWith(QLatin1String("kpackagetool5 
> -t")) &&

Oof.

Is there really no way around this? I mean, it did more or less work before the 
new QtQuick dialog was rolled out.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added a comment.


  In D28745#648036 , @meven wrote:
  
  > This is gonna have an hefty toll on perf as it will add a `getmntent` 
syscall to every thumbnail generation.
  >  Using `Solid::Device::listFromType` would leverage Solid always up-to-date 
(using events rather thane sysalls) device cache.
  >  I am not sure in the end this is preferable though.
  
  
  Unfortunately I'm new to the project and have no idea what would be the best 
way of checking if path is on encrypted filesystem.
  
  One thing I could do is to move check into thumbForDirectory and transfer it 
through drawSubThumbnail and createSubThumbnail. Which will run the check once 
per directory, instead of running it up to four times.
  The big downside however is that we no longer will be able to skip the check 
if thumbnail already exist, so that likely would be slower in most cases.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D28856: Save disabling of desktop file components in kglobalshortcutsrc

[David Redondo]

davidre updated this revision to Diff 80206.
davidre added a comment.


  foo

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28856?vs=80205=80206

BRANCH
  disable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28856

AFFECTED FILES
  src/runtime/globalshortcutsregistry.cpp
  src/runtime/globalshortcutsregistry.h
  src/runtime/kserviceactioncomponent.cpp

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

[David Redondo]

davidre created this revision.
davidre added reviewers: davidedmundson, fvogt, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Works for writable and not writable files. Additional positive we don't have 
to modify the desktop file
  That means a kcm doesn't need to do anything special as the component is 
enabled again automagically upon doRegister().

REPOSITORY
  R268 KGlobalAccel

BRANCH
  disable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28856

AFFECTED FILES
  src/runtime/globalshortcutsregistry.cpp
  src/runtime/globalshortcutsregistry.h
  src/runtime/kserviceactioncomponent.cpp

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28855: put minimumkeepsize actually in the netpref KCM

[Harald Sitter]

sitter added a comment.


  And didn't we have a better spinny box for byte units somewhere? Where the 
user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28855

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Fabian Vogt]

fvogt added a comment.


  In D24956#648968 , @davidedmundson 
wrote:
  
  > > [14:12]  DavidRedondo1: my understanding is that a system might 
ship "konsole opens with control+t". The UI allows you to remove that. This 
would remove the entry in kglobalshortcutsrc, but because it's still  in the 
system defaults file as soon as you log in again it'll add it back
  >
  > [14:25]  d_ed, fvogt Apparently the runtime writes the 
hidden thing when a component is cleanedUp 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n135
  >  [14:27]  Does that fail or something when the file is not 
writeable?
  >  [14:31]  I think it fails
  >  [14:31]  I just tested it
  >
  > if it is indeed broken...then we may as well just merge this.
  
  
  It might not be broken for imported desktop files, in which case this would 
be a noticable regression. Not tested though.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol, davidedmundson
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28855: put minimumkeepsize actually in the netpref KCM

[Harald Sitter]

sitter added a comment.


  F8240046: Screenshot_20200415_164836.png 

  
  I'm very open for better labels, it's a horrible concept to explain in a few 
words.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28855

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[David Redondo]

davidre added a comment.


  In D24956#648991 , @meven wrote:
  
  > In D24956#648968 , 
@davidedmundson wrote:
  >
  > > > [14:12]  DavidRedondo1: my understanding is that a system might 
ship "konsole opens with control+t". The UI allows you to remove that. This 
would remove the entry in kglobalshortcutsrc, but because it's still  in the 
system defaults file as soon as you log in again it'll add it back
  > >
  > > [14:25]  d_ed, fvogt Apparently the runtime writes the 
hidden thing when a component is cleanedUp 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n135
  >
  >
  > This is addressed in D25088 
  
  
  This has the same failure that it only works for writable files. I have the 
idea to save in kglobalshortcutsrc if a desktopfile is disabled

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol, davidedmundson
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28855: put minimumkeepsize actually in the netpref KCM

[Harald Sitter]

sitter updated this revision to Diff 80204.
sitter added a comment.


  improve label a tad

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28855?vs=80203=80204

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28855

AFFECTED FILES
  src/kcms/kio/netpref.cpp
  src/kcms/kio/netpref.h

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Méven Car]

meven added a comment.


  In D24956#648968 , @davidedmundson 
wrote:
  
  > > [14:12]  DavidRedondo1: my understanding is that a system might 
ship "konsole opens with control+t". The UI allows you to remove that. This 
would remove the entry in kglobalshortcutsrc, but because it's still  in the 
system defaults file as soon as you log in again it'll add it back
  >
  > [14:25]  d_ed, fvogt Apparently the runtime writes the 
hidden thing when a component is cleanedUp 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n135
  
  
  This is addressed in D25088 

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol, davidedmundson
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Polish translation of "Cancel"

[Nate Graham]

[+ kde-devel mailing list since I don't know if I got the right 
localization mailing list and couldn't find a polish-specific one]



Hello translators,
I don't speak any Polish, but it's come to my attention that some native 
Polish speakers are complaining about the Polish translation of the word 
"Cancel", with no resolution on the issue: 
https://bugs.kde.org/show_bug.cgi?id=404286


The bug has 150 votes and a lot of discussion. I think there's a fairly 
strong argument in favor of consistency. Given that consistency was even 
selected as an explicit KDE goal this year, my sense is that it would be 
good to be consistent with the translation used by the wider software 
world, even if it's maybe not perfect.


However not being familiar with the language, I thought I would bring up 
the subject here for wider visibility.


Nate

D28855: put minimumkeepsize actually in the netpref KCM

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  I didn't even know it was a thing! by the looks of it the setting only
  applies to retention of .part files on aborting transfers (that is, files
  must be at least this size so they get retained on aborting transfers).
  so the setting is in a form inside a widget and that widget's enabled
  state is contient on partial marking being enabled
  
  CCBUG: 419987

TEST PLAN
  look at the kcm and toggle the button

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28855

AFFECTED FILES
  src/kcms/kio/netpref.cpp
  src/kcms/kio/netpref.h

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Igor Poboiko]

poboiko updated this revision to Diff 80202.
poboiko added a comment.


  Added a unit-test testing for everything I could come up with 
  (at least 4 "behavior nuances" from the commit message)
  
  Address other feedback as well (const'ify, @since version)

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28854?vs=80193=80202

BRANCH
  textwidget-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28854

AFFECTED FILES
  autotests/krichtextedittest.cpp
  autotests/krichtextedittest.h
  src/widgets/krichtextedit.cpp
  src/widgets/krichtextedit.h
  src/widgets/krichtextwidget.cpp
  src/widgets/krichtextwidget.h

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28850: Updated Romanian holidays

[Allen Winter]

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  looks fine.  I tested it.
  
  can someone commit this please?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28850

To: sionescu, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 550 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/550/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Apr 2020 14:12:20 +
 Build duration:
6 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34935/62150)40%
(17721/43910)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10283)46%
(4578/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8496/14316)51%
(4466/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1798/4288)36%
(1303/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/59/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 15 Apr 2020 14:12:20 +
 Build duration:
6 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/51/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 15 Apr 2020 14:12:20 +
 Build duration:
5 min 31 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34936/62151)40%
(17731/43906)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10282)46%
(4578/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4465/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D24956: Consider desktop files with NoDisplay attribute

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > [14:12]  DavidRedondo1: my understanding is that a system might ship 
"konsole opens with control+t". The UI allows you to remove that. This 
would remove the entry in kglobalshortcutsrc, but because it's still  in the 
system defaults file as soon as you log in again it'll add it back
  
  [14:25]  d_ed, fvogt Apparently the runtime writes the hidden 
thing when a component is cleanedUp 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n135
  [14:27]  Does that fail or something when the file is not 
writeable?
  [14:31]  I think it fails
  [14:31]  I just tested it
  
  if it is indeed broken...then we may as well just merge this.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol, davidedmundson
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as 
deprecated (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28851?vs=80190=80201

REVISION DETAIL
  https://phabricator.kde.org/D28851

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kstatusbarofflineindicator.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yeah, it's from before Solid existed... KIO was the only place for this kind 
of stuff back then.

REPOSITORY
  R241 KIO

BRANCH
  offl

REVISION DETAIL
  https://phabricator.kde.org/D28851

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Proposal: "Noteworthy" label for Promo application updates

[Nate Graham]

I support a standardized tag/keyword/whatever to attract promo attention 
to something. However if we use a GitLab tag, then we won't be capturing 
information from Phabricator patches during the time before we've fully 
transitioned to GitLab. Should we instead use a new NOTEWORTHY: Bugzilla 
keyword (like BUG: or FEATURE:) or wait do do this until after the 
GitLab migration is complete?


Nate



On 4/15/20 6:19 AM, Julian wrote:

Hello everyone,

As you all are probably aware, KDE Promo writes monthly updates on what 
happens within our applications and also promotes the releases done by 
the Release Service (like Dolphin 20.04, Kate 20.04, Kontact, etc.). For 
these updates, we need to get all important new features and bug fixes 
that are present in the latest releases.


Up until now, we have reached out to developers every time we wanted to 
compile such feature lists. This approach has several drawbacks:


- Projects occasionally forget to add their new features. This leaves us 
with the choice to either seek out all changes ourselves (which is very 
time consuming) or omit the application in the writeup (which is not 
good either)- Smaller projects might be left out because we do not know 
that they have released something cool- There is an inevitable waiting 
period between us asking for a feature list and the completion of the 
list. This can lead to delays in the announcement process and lowers the 
quality of the announcement (for example, because translators don't have 
the time to translate the text before it is made public)


We would therefore like to propose a different approach.

  1. Get a standardized "Noteworthy" label added on Invent. 2. Whenever 
a noteworthy change is merged (that is, a cool new feature or an 
important bug fix), the reviewers add said label. 3. When Promo drafts 
release notes or other updates, we can filter for said label and 
instantly see all relevant changes.


This ensures that no important contributions are overlooked and results 
in a much smoother workflow for Promo. We'd like to get feedback from 
developers on this proposal and if no major objections are raised, 
implement this workflow change as soon as code hosting is fully 
transitioned to GitLab.


Best regards,Julian / xyquadrat on behalf of KDE Promo

P.S.: Please note that we still need your notes on changes for the 20.04 
release, however. Visit https://share.kde.org/s/SJqzmemQ3PsrmGR and add 
in noteworthy features and bug fixes there.

D28701: Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir added reviewers: ngraham, mart, davidedmundson.
leinir added a comment.


  Tagging in those active in the referenced bug, except for the reporter who 
doesn't have a phabricator account

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25705: Deprecate KIO::pixmapForUrl

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> pixmaploader.h:37
>   *
> + * @deprecated since 5.70, use KIO::iconNameForUrl()
> + * to get the icon name and use QIcon::fromTheme().pixmap()

`@deprecated` should go after `@return` here, cmp. 
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella planned changes to this revision.
nicolasfella added a comment.


  Seems like I missed some usages

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella updated this revision to Diff 80199.
nicolasfella added a comment.


  - Fix update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=80197=80199

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella updated this revision to Diff 80197.
nicolasfella added a comment.


  - Update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=72413=80197

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28854: [KRichTextWidget] Add support for headings

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Can you improve autotest KRichTextEditTest ?

INLINE COMMENTS

> krichtextedit.cpp:346
> +// level=2 look the same
> +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0;
> +

const int

> krichtextedit.h:351
> + *
> + * @since FIXME
> + */

since @5.70

> krichtextwidget.cpp:499
> +d->action_heading_level = new KSelectAction(i18nc("@title:menu", 
> "Heading Level"), this);
> +QStringList listStyles = {i18nc("@item:inmenu no heading",   
>   "Basic text"),
> +  i18nc("@item:inmenu heading level 1 
> (largest)",  "Title"),

const QStringList

> krichtextwidget.h:233
> + *
> + * @since FIXME
> + */

@since 5.70

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir retitled this revision from "[WIP] Add KPackage support to 
KNewStuffCore" to "Add KPackage support to KNewStuffCore".
leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 80195.
leinir added a comment.


  Think we're at the point where testing would be good, now. This update
  means we now attempt to adopt already installed kpackages if you try and
  install the package from knewstuff, and removal of entries installed
  using the previous implementation should now also happen during a fallback
  step, intended to make life a bit simpler for those who have used this
  before...
  
  - Add a KPackageType property to Installation, for fallback purposes
  - Add documentation for the new knsrc bits
  - Handle adopting an already installed kpackage item
  - Also uninstall not-adopted-but-there possibly installed kpackage bits

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=80184=80195

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/downloaddialog.h

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25267: Improve XCF support

[Christoph Feck]

cfeck added a comment.


  Thanks for your work, Martin! Could you please add a note (or resolve) bug 
360821?

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D25267

To: sandsmark, aacid, cfeck, apol, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D10989: Check for nullptr in indexForNode

[Jaime Torres Amate]

jtamate abandoned this revision.
jtamate added a comment.




REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10989

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, mpyne, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Fabian Vogt]

fvogt added a comment.


  In D24956#648905 , @davidedmundson 
wrote:
  
  > kglobalshortcutseditor.cpp
  >  needs updating to match
  >
  > I think you're right with your reasoning about NoDisplay, but we do want 
something to be able to mask system files. From the spec should we be checking 
Hidden= ?
  
  
  `Hidden=true` is equivalent to not having the file at all according to the 
spec, so it would make sense. There's also D25088 
 open.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[David Edmundson]

davidedmundson added a comment.


  kglobalshortcutseditor.cpp
  needs updating to match
  
  I think you're right with your reasoning about NoDisplay, but we do want 
something to be able to mask system files. From the spec should we be checking 
Hidden= ?

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidedmundson, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Proposal: "Noteworthy" label for Promo application updates

[Julian]

Hello everyone,
As you all are probably aware, KDE Promo writes monthly updates on what happens 
within our applications and also promotes the releases done by the Release 
Service (like 
Dolphin 20.04, Kate 20.04, Kontact, etc.). For these updates, we need to get 
all important 
new features and bug fixes that are present in the latest releases. 
Up until now, we have reached out to developers every time we wanted to compile 
such 
feature lists. This approach has several drawbacks:
- Projects occasionally forget to add their new features. This leaves us with 
the choice to 
either seek out all changes ourselves (which is very time consuming) or omit 
the 
application in the writeup (which is not good either)- Smaller projects might 
be left out 
because we do not know that they have released something cool- There is an 
inevitable 
waiting period between us asking for a feature list and the completion of the 
list. This can 
lead to delays in the announcement process and lowers the quality of the 
announcement 
(for example, because translators don't have the time to translate the text 
before it is 
made public) 
We would therefore like to propose a different approach.
 1. Get a standardized "Noteworthy" label added on Invent. 2. Whenever a 
noteworthy 
change is merged (that is, a cool new feature or an important bug fix), the 
reviewers add 
said label. 3. When Promo drafts release notes or other updates, we can filter 
for said label 
and instantly see all relevant changes. 
This ensures that no important contributions are overlooked and results in a 
much 
smoother workflow for Promo. We'd like to get feedback from developers on this 
proposal 
and if no major objections are raised, implement this workflow change as soon 
as code 
hosting is fully transitioned to GitLab.
Best regards,Julian / xyquadrat on behalf of KDE Promo 


P.S.: Please note that we still need your notes on changes for the 20.04 
release, however. 
Visit https://share.kde.org/s/SJqzmemQ3PsrmGR[1] and add in noteworthy features 
and 
bug fixes there.


[1] https://share.kde.org/s/SJqzmemQ3PsrmGR

D28854: [KRichTextWidget] Add support for headings

[Igor Poboiko]

poboiko edited the test plan for this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, mlaurent, ahmadsamir, dfaure.
Herald added a project: Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  This patch adds support of different headings (essentially, HTML h1..h6 tags).
  Those might be pretty useful when formatting a rich text (I'm having KJots - 
note taking app - in mind)
  
  `QTextBlockFormat` supports `headingLevel` since Qt 5.12; however, as stated 
in the documentation,
  `setHeadingLevel` does not adjust style (font size, etc), so we have to take 
care of it on our own.
  
  It also adds a `KSelectAction` to choose between different headings.
  
  There are few behavior nuances:
  
  1. If user presses `Enter` at the end of heading line, cursor should switch 
to `basic text`
  2. If user presses `Enter` in the middle of the heading, line just breaks 
into two headings
  3. If user presses `Backspace` at the beginning of a line after the heading, 
the line is merged with the previous one (and thus becomes heading itself)
  4. The same with `Delete` at the end of heading line: the next line should 
become heading too.

TEST PLAN
  See the video of `KRichTextEditor` from `KXmlGui` (I had to add 
`format_heading_level` to rc-file).

REPOSITORY
  R310 KTextWidgets

BRANCH
  textwidget-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28854

AFFECTED FILES
  src/widgets/krichtextedit.cpp
  src/widgets/krichtextedit.h
  src/widgets/krichtextwidget.cpp
  src/widgets/krichtextwidget.h

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Aleix Pol Gonzalez]

apol added a comment.


  +1 This makes sense to me

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns