D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Kåre Särs
sars added a comment.


  I'm starting to think that we need an option for enabling/disabling this 
change/feature. I would not want to have the extra space between the lines, but 
at the same time I can see that actually not seeing the whole character is not 
an acceptable situation...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, 
kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, 
demsking, cullmann, dhaumann


Re: Mentors needed

2020-05-04 Thread Valorie Zimmerman
Are we discussing the same student, Agisilaos Kounelis who proposed "Port
QtQuickControls Calendar widget to QtQuickControls2 module" ? If so, they
have not withdrawn. If this indeed the student, if they will not
participate officially then need to *now* mark "Withdraw."

Valorie

On Mon, May 4, 2020 at 2:12 AM Alexa M  wrote:

> Hi,
>
> The student decided to not to participate in GSoC this year due to other 
> university
> obligations running late because of the current situation including uncertain
> exams dates and he was afraid he would not be able to comply.
>
> Best,
> AlexandraB
>
> On Fri, May 1, 2020, 00:06 Timothée Giet  wrote:
>
>> Le 30/04/2020 à 22:07, Timothée Giet a écrit :
>>
>> Le 30/04/2020 à 21:38, Valorie Zimmerman a écrit :
>>
>> Hello folks, we have a project about porting a QtQuickControls module to
>> QtQuickControls2 with only one mentor who marked "I want to mentor" on the
>> GSoC webapp.
>>
>> If you have already signed into the GSoC webapp as a mentor, and would
>> like to help out with this project, please mark "I want to mentor" in the
>> app.
>>
>> If you have the skills needed to mentor but have not yet logged into the
>> app, please:
>>
>> 1. ensure that you are subscribed to KDE-Soc-Mentor mail list [1]
>>
>> 2. write to kde-soc-managem...@kde.org and ask to be invited to the
>> webapp.
>>
>> Thanks!
>>
>> Valorie
>>
>> 1. https://mail.kde.org/mailman/listinfo/kde-soc-mentor
>>
>> --
>> http://about.me/valoriez - pronouns: she/her
>>
>>
>> I may not be the best mentor this project, but as GCompris would benefit
>> a lot from the output of this proposal (this missing module is the main
>> blocker we have to migrate to QtQuickControls2), I'm ok to backup-mentor
>> it... At least I can provide generic advices and testing.
>>
>> But some help from someone more specialist of Qt internals would be
>> welcome!
>>
>> Timothée
>>
>> On second thought, as I'm not so sure I can provide valuable help to
>> mentor this project, I unchecked the "want to mentor" button there... but
>> again, if there's anyone else willing to help mentoring this project, it
>> would be awesome.
>>
>> Timo.
>>
>

-- 
http://about.me/valoriez - pronouns: she/her


Fw: Re: Adding the Abstract Games Suite to the KDE Applications

2020-05-04 Thread The Abstract Developers




Sorry about that ;)

‐‐‐ Original Message ‐‐‐
On Monday, May 4, 2020 10:04 AM, The Abstract Developers 
 wrote:

> Yes, we definitely can re-license. We have been wanting for a long time to 
> convert to the nonrestrictive 2-Clause BSD, which appears to be on their 
> list. However, we would prefer not to use GPL. We can give you the reasons 
> upon request.
>
> Thanks,
> The Abstract Developers




D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Frederick Yin
fakefred added a comment.


  In D25339#663322 , @rjvbb wrote:
  
  > but that's hardly the domain of application for a text editing framework.
  
  
  It's "KTextEditor", not "KCodeEditor". This rendering issue, though not from 
an "intended purpose", makes it painful to write CJK LaTeX articles in Kile. 
Now that KDE declares to be serving a worldwide userbase, the foundation of 
numerous applications has to see some change somehow.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, 
kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D29436: Use font: instead of font.pointSize: where possible

2020-05-04 Thread Nathaniel Graham
ngraham retitled this revision from "Use theme.smallestFont instead of various 
ad-hoc alternatives" to "Use font: instead of font.pointSize: where possible".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham added a reviewer: cblack.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 81959.
ngraham added a comment.


  Revert a thing that shoudnta been thunged

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29436?vs=81957=81959

BRANCH
  use-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29436

AFFECTED FILES
  examples/applets/testcomponents/contents/ui/ThemePage.qml
  examples/applets/testtheme/contents/ui/FontTest.qml

To: ngraham, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29436: Use theme.smallestFont instead of various ad-hoc alternatives

2020-05-04 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Diff should be fairly self-explanatory. We should be using
  `font: theme.smallestFont` so that we're capturing style
  information about the smallest font too, and we should be using
  this theme font instead of some random variation of the general
  font.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  use-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29436

AFFECTED FILES
  examples/applets/testcomponents/contents/ui/ThemePage.qml
  examples/applets/testtheme/contents/ui/FontTest.qml
  src/declarativeimports/calendar/qml/DayDelegate.qml

To: ngraham, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 81956.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use the whole font, not just the point size

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29434?vs=81951=81956

BRANCH
  ExpandableListItem-small-subtitle-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29434

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, #vdg, broulik
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> ExpandableListItem.qml:434
>  visible: text.length > 0
> +font.pointSize: theme.smallestFont.pointSize
>  

`font: theme.smallestFont`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29434

To: ngraham, #plasma, #vdg, broulik
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


Re: Mentors needed

2020-05-04 Thread Alexa M
Hi Valorie,

Mentoring shouldn't be a problem. I'll ask him about part time.

Best,
Alexandra

On Tue, May 5, 2020, 00:15 Valorie Zimmerman 
wrote:

> On Mon, May 4, 2020 at 2:12 AM Alexa M  wrote:
>
>> Hi,
>>
>> The student decided to not to participate in GSoC this year due to other 
>> university
>> obligations running late because of the current situation including uncertain
>> exams dates and he was afraid he would not be able to comply.
>>
>> Best,
>> AlexandraB
>>
>
> That's unfortunate. Is is possible the student will still be able to work
> on this project part-time if we can find mentoring for him?
>
> Valorie
>
> On Fri, May 1, 2020, 00:06 Timothée Giet  wrote:
>>
>>> Le 30/04/2020 à 22:07, Timothée Giet a écrit :
>>>
>>> Le 30/04/2020 à 21:38, Valorie Zimmerman a écrit :
>>>
>>> Hello folks, we have a project about porting a QtQuickControls module to
>>> QtQuickControls2 with only one mentor who marked "I want to mentor" on the
>>> GSoC webapp.
>>>
>>> ::some old snipped::
>>>
>>> I may not be the best mentor this project, but as GCompris would benefit
>>> a lot from the output of this proposal (this missing module is the main
>>> blocker we have to migrate to QtQuickControls2), I'm ok to backup-mentor
>>> it... At least I can provide generic advices and testing.
>>>
>>> But some help from someone more specialist of Qt internals would be
>>> welcome!
>>>
>>> Timothée
>>>
>>> On second thought, as I'm not so sure I can provide valuable help to
>>> mentor this project, I unchecked the "want to mentor" button there... but
>>> again, if there's anyone else willing to help mentoring this project, it
>>> would be awesome.
>>>
>>> Timo.
>>>
>>


D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz added a comment.


  I committed this one for Weisi Dai

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29374

To: weisi, winterz, davidedmundson
Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
This revision was automatically updated to reflect the committed changes.
Closed by commit R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb 
(authored by weisi, committed by winterz).

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29374?vs=81773=81953

REVISION DETAIL
  https://phabricator.kde.org/D29374

AFFECTED FILES
  holidays/plan2/holiday_gb-sct_en-gb

To: weisi, winterz, davidedmundson
Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread David Faure
dfaure added a comment.


  Yep, doing it already.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D29427

To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  5.70 wants this as appended commit, no?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D29427

To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment.


  Yes, please!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29434

To: ngraham, #plasma, #vdg, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, VDG, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We're moving towards using the small font for subtitles in Kirigami 
BasicListItem (D29432 )
  so we should probably do the same here since it has the same title + subtitle 
layout.

TEST PLAN
  Before: F8284752: Screenshot_20200504_155734.png 

  
  After: F8284751: Screenshot_20200504_155648.png 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ExpandableListItem-small-subtitle-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29434

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, #vdg, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:8a282319bc9e: [KBookmarkMenu] Assign m_actionCollection 
early to prevent crash (authored by ahmadsamir).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29427?vs=81934=81950

REVISION DETAIL
  https://phabricator.kde.org/D29427

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  l-bookmarkmenu-assign-actioncoll (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29427

To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz accepted this revision.
winterz added a comment.


  do you need me to commit this for you?
  
  my fault.  I should have run the test that looks for the syntax errors .. I 
don't recall doing that.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29374

To: weisi, winterz, davidedmundson
Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Allen Winter
winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  I don't know German and I don't know the Berlin holidays.
  but the tests pass and in general things look fine.

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29415

To: vkrause, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Mentors needed

2020-05-04 Thread Valorie Zimmerman
On Mon, May 4, 2020 at 2:12 AM Alexa M  wrote:

> Hi,
>
> The student decided to not to participate in GSoC this year due to other 
> university
> obligations running late because of the current situation including uncertain
> exams dates and he was afraid he would not be able to comply.
>
> Best,
> AlexandraB
>

That's unfortunate. Is is possible the student will still be able to work
on this project part-time if we can find mentoring for him?

Valorie

On Fri, May 1, 2020, 00:06 Timothée Giet  wrote:
>
>> Le 30/04/2020 à 22:07, Timothée Giet a écrit :
>>
>> Le 30/04/2020 à 21:38, Valorie Zimmerman a écrit :
>>
>> Hello folks, we have a project about porting a QtQuickControls module to
>> QtQuickControls2 with only one mentor who marked "I want to mentor" on the
>> GSoC webapp.
>>
>> ::some old snipped::
>>
>> I may not be the best mentor this project, but as GCompris would benefit
>> a lot from the output of this proposal (this missing module is the main
>> blocker we have to migrate to QtQuickControls2), I'm ok to backup-mentor
>> it... At least I can provide generic advices and testing.
>>
>> But some help from someone more specialist of Qt internals would be
>> welcome!
>>
>> Timothée
>>
>> On second thought, as I'm not so sure I can provide valuable help to
>> mentor this project, I unchecked the "want to mentor" button there... but
>> again, if there's anyone else willing to help mentoring this project, it
>> would be awesome.
>>
>> Timo.
>>
>


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Shinjo Park
pshinjo added a comment.


  In D25339#663462 , @rjvbb wrote:
  
  > This patch is only needed when mixing a main Latin1 (like) alphanumeric 
font with occasional glyphs from a font that have a different, taller height?
  
  
  Yes, though the "occasion" will highly depend on the user locale. For someone 
this will likely never happen, for someone this will happen everyday.
  
  > Am I right that any text that uses only a single font will see some form of 
significant loss of the number of lines that fit within a given vertical space?
  
  Yes, given that the font contains all required glyphs to represent the string 
"AHIygあ你말" is limited. That's also visible in my test 2. Previous tests were 
done in artificially high font size (32pt for example) and less dense texts so 
the original authors might overlooked this problem.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, 
kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir added a reviewer: nicolasfella.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D29427

To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread René J . V . Bertin
rjvbb added a comment.


  This patch is only needed when mixing a main Latin1 (like) alphanumeric font 
with occasional glyphs from a font that have a different, taller height?
  
  Am I right that any text that uses only a single font will see some form of 
significant loss of the number of lines that fit within a given vertical space?
  
  >   Test 3 - Ubuntu Mono + Noto Sans Mono CJK KR 9pt. For me the right hand 
side is a regression, since neither Cyrillic nor Korean scripts are clearly 
visible when both of them are in the same line. Also in this setup most of 
Korean texts are cut by half even when there are only Korean texts. Compare it 
with the other lines where only Cyrillic is visible:...
  
  
  
  > But this part is the raison d'etre for this patch: provide enough font 
height for non-latin-1 text. Also not considered is glyphs from other scripts, 
such as Cyrillic, Arabic, ... What could be another solution?
  
  If local lineheight adaptation isn't possible with the current implementation 
(not even by inserting 1 or more virtual linebreaks?) then the behaviour 
introduced with this patch c/should become optional. Selected automatically if 
possible (with an off toggle in the settings dialog) but otherwise via a menu 
action that's not too well hidden so people who need to turn it on and off on 
any kind of regular basis can do so without having to hunt the command down too 
much.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, 
kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 80 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/80/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 04 May 2020 20:17:25 +
 Build duration:
5 min 14 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(272/408)67%
(272/408)56%
(35061/62309)40%
(17778/43992)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9870/10339)46%
(4607/9916)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8510/14375)51%
(4469/8738)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)78%
(379/486)56%
(184/326)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(425/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4287)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
 

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 59 - Still unstable!

2020-05-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/59/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 04 May 2020 19:52:40 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.kmoretoolstest

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 32 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/32/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 04 May 2020 19:52:42 +
 Build duration:
6 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5NewStuff-5.70.0.xmlacc/KF5NewStuffCore-5.70.0.xmlacc/KF5NewStuffQuick-5.70.0.xmlcompat_reports/KF5NewStuff_compat_report.htmlcompat_reports/KF5NewStuffCore_compat_report.htmllogs/KF5NewStuff/5.70.0/log.txtlogs/KF5NewStuffCore/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)16%
(12/76)16%
(12/76)13%
(967/7235)10%
(411/3954)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(90/90)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)71%
(199/279)43%
(63/148)src22%
(2/9)22%
(2/9)2%
(22/964)0%
(0/342)src.attica0%
(0/2)0%
(0/2)0%
(0/364)0%
(0/203)src.core17%
(4/23)17%
(4/23)10%
(237/2340)9%
(155/1698)src.core.jobs0%
(0/7)0%
(0/7)0%
(0/267)0%
(0/117)src.kmoretools60%
(3/5)60%
(3/5)47%
(419/897)33%
(155/470)src.qtquick0%
(0/10)0%
(0/10)0%
(0/713)0%
(0/322)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/140)src.ui0%
(0/8)0%
(0/8)0%
(0/750)0%
(0/307)src.upload0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/50)tests0%
(0/5)0%
(0/5)0%
(0/150)0%
(0/61)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/129)0%
(0/24)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 195 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/195/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 May 2020 19:52:38 +
 Build duration:
5 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5NewStuff-5.70.0.xmlacc/KF5NewStuffCore-5.70.0.xmlacc/KF5NewStuffQuick-5.70.0.xmlcompat_reports/KF5NewStuff_compat_report.htmlcompat_reports/KF5NewStuffCore_compat_report.htmllogs/KF5NewStuff/5.70.0/log.txtlogs/KF5NewStuffCore/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)16%
(12/76)16%
(12/76)13%
(967/7235)10%
(411/3954)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(90/90)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)71%
(199/279)43%
(63/148)src22%
(2/9)22%
(2/9)2%
(22/964)0%
(0/342)src.attica0%
(0/2)0%
(0/2)0%
(0/364)0%
(0/203)src.core17%
(4/23)17%
(4/23)10%
(237/2340)9%
(155/1698)src.core.jobs0%
(0/7)0%
(0/7)0%
(0/267)0%
(0/117)src.kmoretools60%
(3/5)60%
(3/5)47%
(419/897)33%
(155/470)src.qtquick0%
(0/10)0%
(0/10)0%
(0/713)0%
(0/322)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/140)src.ui0%
(0/8)0%
(0/8)0%
(0/750)0%
(0/307)src.upload0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/50)tests0%
(0/5)0%
(0/5)0%
(0/150)0%
(0/61)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/129)0%
(0/24)

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 34 - Fixed!

2020-05-04 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/34/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 04 May 2020 19:52:35 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D28932: Store filename terms just once

2020-05-04 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7605f4d7f7c4: Store filename terms just once (authored by 
bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28932?vs=80439=81937

REVISION DETAIL
  https://phabricator.kde.org/D28932

AFFECTED FILES
  autotests/integration/querytest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Shinjo Park
pshinjo added a comment.


  In D25339#563370 , @xuetianweng 
wrote:
  
  > And what I'd like to point is, for CJK users, it is uncommon for them to 
select a single font to cover all the characters, because such fonts are really 
rare. People usually select one latin only font and just let system 
(fontconfig) select the fallback for them.
  
  
  This statement is valid even for non-CJK users who only occasionally see the 
said characters.
  
  For all screenshots, left hand side is git master+this patch, right hand side 
is Kate 19.12.3/Frameworks 5.68.0 on Ubuntu 20.04.
  
  Test 1 - Hack + Noto Sans Mono CJK KR 9pt (Hack does not contain CJK glyphs, 
so for missing glyphs the latter will be used). Notice that only in the left 
hand side the underline in my e-mail address is visible:
  
  F8284453: Screenshot_20200504_210144.png 

  
  Test 2 - Nanum Square 9pt (contains both Latin-1 and Korean glyphs):
  
  F8284455: Screenshot_20200504_210313.png 

  
  Test 3 - Ubuntu Mono + Noto Sans Mono CJK KR 9pt. For me the right hand side 
is a regression, since neither Cyrillic nor Korean scripts are clearly visible 
when both of them are in the same line. Also in this setup most of Korean texts 
are cut by half even when there are only Korean texts. Compare it with the 
other lines where only Cyrillic is visible:
  
  F8284485: Screenshot_20200504_213506.png 

  
  I can also confirm about 6-7 lines of loss, but for me the right hand side 
has issues. Need to find some compromise.

INLINE COMMENTS

> katerenderer.cpp:1040
>  m_fontHeight = qMax(1, qCeil(m_fontMetrics.ascent() + 
> m_fontMetrics.descent()));
> +// Try to use representitve character from English, Chinese, Japanese
> +// and Korean to calculate the line height.

I think this causes the regression mentioned in

In D25339#663322 , @rjvbb wrote:

> I can't speak for the special cases where this change would improve matters, 
> but for me it introduces a clear regression (waste of vertical space: 12 
> lines less) in a basic ascii code editing context. Font used is Ubuntu Mono 
> 10pt.


But this part is the raison d'etre for this patch: provide enough font height 
for non-latin-1 text. Also not considered is glyphs from other scripts, such as 
Cyrillic, Arabic, ... What could be another solution?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, 
kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The deprecated ctor that took a KActionCollection param called the new
  ctor (that doesn't take an actionCollection before) m_actionCollection was
  assigned. This caused the menu actions never to get added to the
  actionCollection as it was still nullptr. This caused crashes in
  applications that still use the deprecated ctor, e.g. this bug in
  konsole https://bugs.kde.org/show_bug.cgi?id=420820.
  
  Since we can't assign m_actionCollection in the initializer list because
  then the constructor delegation would follow a member initializer
  (info courtsey of the compiler), introduce a helper init method to
  reduce code duplication between the two ctor's.
  
  Thanks to Friedrich W. H. Kossebau for figuring it out
  https://phabricator.kde.org/D28800#663274.
  
  CCBUG: 420820

TEST PLAN
  make && ctest

REPOSITORY
  R294 KBookmarks

BRANCH
  l-bookmarkmenu-assign-actioncoll (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29427

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28932: Store filename terms just once

2020-05-04 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Sorry for the delay. Makes sense.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28932

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread René J . V . Bertin
rjvbb requested changes to this revision.
rjvbb added a comment.
This revision now requires changes to proceed.


  I can't speak for the special cases where this change would improve matters, 
but for me it introduces a clear regression (waste of vertical space: 12 lines 
less) in a basic ascii code editing context. Font used is Ubuntu Mono 10pt.
  
  F8284297: image.png 
  
  Granted, the current display (left) is a tad crowded but I actually like it 
like that for code editing. For reading prose it might be too much, but that's 
hardly the domain of application for a text editing framework.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, 
rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D29200: test the extractNothing flag

2020-05-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:5e1ed919bdf6: test the extractNothing flag (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29200?vs=81237=81928

REVISION DETAIL
  https://phabricator.kde.org/D29200

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/epubextractortest.h
  autotests/exiv2extractortest.cpp
  autotests/exiv2extractortest.h
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  autotests/indexerextractortests.cpp
  autotests/indexerextractortests.h
  autotests/odfextractortest.cpp
  autotests/odfextractortest.h
  autotests/office2007extractortest.cpp
  autotests/office2007extractortest.h
  autotests/popplerextractortest.cpp
  autotests/popplerextractortest.h
  autotests/postscriptdscextractortest.cpp
  autotests/postscriptdscextractortest.h
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  autotests/xmlextractortest.cpp
  autotests/xmlextractortest.h

To: astippich, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29199: honor the extractMetaData flag

2020-05-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:538c34b58057: honor the extractMetaData flag (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29199?vs=81258=81927

REVISION DETAIL
  https://phabricator.kde.org/D29199

AFFECTED FILES
  src/extractors/epubextractor.cpp
  src/extractors/exiv2extractor.cpp
  src/extractors/ffmpegextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/plaintextextractor.cpp
  src/extractors/popplerextractor.cpp
  src/extractors/postscriptdscextractor.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/xmlextractor.cpp

To: astippich, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D28800: Always create actioncollection

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added inline comments.

INLINE COMMENTS

> kbookmarkmenu.cpp:69
>  {
>  m_actionCollection = actionCollection;
>  }

This resetting of m_actionCollection in the constructor taking an 
actionCollection still results in issues, as this  KBookmarkMenu constructor 
taking an actionCollection calls the other constructors not taking an 
actioncollection, but only resets the m_actionCollection afterwards.

As a result the addActions() call in the other constructor will operate on an 
actionCollection object which is then hidden here again. And also the 
actionCollection passed will not have any actions added.

So any code which tries to access actions unconditionally from the 
actionCollection using the action id, like "add_bookmark", will get a nullptr 
and then go boom.

Like happens for Konsole which got built still using the old constructor taking 
a actionCollection, see https://bugs.kde.org/show_bug.cgi?id=420820

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29231: Add keyboard_shortcuts_inhibit protocol

2020-05-04 Thread Nathaniel Graham
ngraham added a dependent revision: D29272: Add support to keyboard shortcuts 
inhibitor.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29420: Generate DBus interface

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We already use a generated interface in kstatusnotifieritem, but not in 
notifybypopup.
  
  Compile-time checks++
  code--

TEST PLAN
  Spawned, updated, closed notifications, triggered actions

REPOSITORY
  R289 KNotifications

BRANCH
  geninterface

REVISION DETAIL
  https://phabricator.kde.org/D29420

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81918.
alex added a comment.


  Merge branch master

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29123?vs=81476=81918

BRANCH
  arcpatch-D29123_1

REVISION DETAIL
  https://phabricator.kde.org/D29123

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28932: Store filename terms just once

2020-05-04 Thread Stefan Brüns
bruns added a comment.


  This has been pending for more than two weeks now, without any sort of review 
...
  
  @ngraham If you have any questions, please ask!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28932

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29396: Suppress find_package_handle_standard_args package name mismatch warning.

2020-05-04 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:8d181637a033: Suppress find_package_handle_standard_args 
package name mismatch warning. (authored by xuetianweng).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29396?vs=81832=81908

REVISION DETAIL
  https://phabricator.kde.org/D29396

AFFECTED FILES
  modules/ECMFindModuleHelpers.cmake

To: xuetianweng, #frameworks, #build_system, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Volker Krause
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The generic DE file doesn't really work anymore since Berlin got creative
  in adding non-standard public holidays.

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29415

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_de-be_de

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment.


  > If I understand correctly, it is necessary to use dbus spectacle in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.
  
  I don't think that's a good reason. We have lots of applications that do that 
without having to be launched by dbus: plasmashell, krunner, yakuake, etc. It's 
done by using KDBusService.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  warnaboutdeprecatedemptynonnullheader

REVISION DETAIL
  https://phabricator.kde.org/D29414

AFFECTED FILES
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 37 - Unstable!

2020-05-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/37/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 04 May 2020 14:35:43 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_dialogstatetest

D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68d5995c6352: Add smallFont to Kirigami plasma style 
(authored by cblack).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29412?vs=81897=81898

REVISION DETAIL
  https://phabricator.kde.org/D29412

AFFECTED FILES
  src/declarativeimports/kirigamiplasmastyle/Theme.qml

To: cblack, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cblack/smallfont-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29412

To: cblack, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  F8283833: ksnip_20200504-102619.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cblack/smallfont-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29412

AFFECTED FILES
  src/declarativeimports/kirigamiplasmastyle/Theme.qml

To: cblack, #kirigami
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29409: Add documentation line on KCM translations

2020-05-04 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> configmodule.h:98
> + *
> + * Translation domain will be set to "kcm_componentName" from the KAboutData 
> as described above.
> + *

You probably want to use backticks instead of quotes as this is referring to 
something codewise.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29409

To: davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29409: Add documentation line on KCM translations

2020-05-04 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29409

AFFECTED FILES
  src/quickaddons/configmodule.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29336: Remove galago from method/variable naming

2020-05-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2012f675aed2: Remove galago from method/variable naming 
(authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29336?vs=81680=81892

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment.


  > Maybe we need something similar to `X-GNOME-UsesNotifications=true`
  
  Or we just also use that :D

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment.


  In D29405#662963 , @apol wrote:
  
  > Won't this make it harder to put together the notifications kcm?
  
  
  Good point, we use the notifyrc file to know which apps send notifications 
ahead of time. Maybe we need something similar to 
`X-GNOME-UsesNotifications=true`

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment.


  We want to phase out notifyrc files for several reasons:
  
  - They are an overkill for many simple use cases
  - A common pitfall when using KNotifications are missing or incorrect 
notifyrc files
  - Most of the information in there is duplicate/overridden at runtime anyway
  - We want to reduce the level of detail of the configurability anyway since 
it currently is quite an overkill
  
  See T11875  for some discussion

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D17816: Support for xattrs on kio copy/move

2020-05-04 Thread Nathaniel Graham
ngraham added a comment.


  Ping @cochise

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a comment.


  In D29406#662932 , @apol wrote:
  
  > This should be documented somewhere, as is it's really confusing.
  
  
  I am not sure where to document this, but agrees this is needed.
  Will look on existing documentation to find the place.
  (Maybe add a comment in the application.desktop file)
  
  > I'm not sure it wouldn't be better to have spectacle launched again there 
instead of going through dbus (which is a change I admittedly don't understand 
very well).
  
  If I understand correctly, it is necessary to use `dbus spectacle`in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29336: Remove galago from method/variable naming

2020-05-04 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  nogalago

REVISION DETAIL
  https://phabricator.kde.org/D29336

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment.


  What's the advantage?
  Won't this make it harder to put together the notifications kcm?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a dependent revision: D29407: ScreenshotEffect: Use Service 
Property to authorize screenshot without confirmation.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment.


  This should be documented somewhere, as is it's really confusing.
  
  I'm not sure it wouldn't be better to have spectacle launched again there 
instead of going through dbus (which is a change I admittedly don't understand 
very well).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven created this revision.
meven added reviewers: Frameworks, davidedmundson, apol, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Sometimes Exec entries are replaced by qdbus invocation such as in D19225 

  Add a property X-KDE-Original-Executable to allow to specify the original 
Exec path.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29406

AFFECTED FILES
  src/services/application.desktop

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  In KNotificationManager when reading the actions default to Popup when no 
actions are found. In notifybypopup default to 
QGuiApplication::applicationDisplayName() when reading the app name. The logic 
for the icon is not changed, worst case we get empty which may get overridden 
by the user.
  
  Other backends are still todo

TEST PLAN
  Deleted notifyrc file from KDE Connect. Still get notifications. As a side 
effect the pairing notification now shows "KDE Connect Daemon" instead of "KDE 
Connect". This could be changed with a new setter or x-kde-display-appname

REPOSITORY
  R289 KNotifications

BRANCH
  nonotifyrc

REVISION DETAIL
  https://phabricator.kde.org/D29405

AFFECTED FILES
  src/knotificationmanager.cpp
  src/notifybypopup.cpp

To: nicolasfella, #frameworks, broulik, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29256: [server] Introduce mapped() signal

2020-05-04 Thread Vlad Zahorodnii
zzag closed this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29256

To: zzag, #kwin, davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29381: Thumbnail text: use libmagic to detect encoding

2020-05-04 Thread Harald Sitter
sitter added a comment.


  I have zero background knowledge here, but it really feels like there must be 
an existing solution to this problem other than libmagic. Like how does kate 
figure out the encoding of a text file.

INLINE COMMENTS

> Findlibmagic.cmake:1
> +# - Try to find libssh
> +# Once done this will define

bad copypaste

> Findlibmagic.cmake:64
> +
> +
> +endif (LIBMAGIC_INCLUDE_DIR AND LIBMAGIC_LIBRARIES)

It's more idiomatic to define an imported target, see some of the newer finders 
in ECM.

I do also rather wonder if we couldn't just use FindPkgConfig's imported 
target, in theory pkgconfig also works on windows. I may well be ignorant of 
the finer points of windows support though.

> textcreator.cpp:38
> +#include 
> +#if LIBMAGIC_FOUND
> +  #include "magic.h"

TBH, I would make libmagic required for building the thumbnail plugin. I can't 
see much of a rationale for why we'd want to support "broken"/insufficient 
encoding detection when there's code that makes it better.

> textcreator.cpp:65
> +#if LIBMAGIC_FOUND
> +static QTextCodec* codecFromFile(const QString )
> +{

`*` on wrong side of space

> textcreator.cpp:67
> +{
> +magic_t m = magic_open(MAGIC_MIME_ENCODING);
> +magic_load(m, nullptr);

better name than m? (:

> textcreator.cpp:69
> +magic_load(m, nullptr);
> +const char *ret = magic_file(m, path.toLocal8Bit() );
> +auto codecName = QString(ret).toUpper().toLocal8Bit();

excess whitespace towards the end. I also wonder if qfile::encodename would be 
better

> textcreator.cpp:70
> +const char *ret = magic_file(m, path.toLocal8Bit() );
> +auto codecName = QString(ret).toUpper().toLocal8Bit();
> +magic_close(m);

I guess you could just toUpper on a QBA instead of going through a temporary 
QString since ret is an encoding identifier ajnd would be always an ascii 
string.
Also, can be const it seems.

> textcreator.cpp:78
> +if (strcmp(ret, "unknown-8bit")) {
> +// use latin for unkwnwn 8bit as it is quite versatile
> +return QTextCodec::codecForName("latin-1");

unkwnwn typo

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81873.
alex added a comment.


  Increase @since to 5.71

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29201?vs=81856=81873

BRANCH
  service_path_append (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29201

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h
  src/kpluginselector_p.h

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/33/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 04 May 2020 10:53:22 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  [...truncated 135 lines...][2020-05-04T10:54:02.153Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2020-05-04T10:54:02.153Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/display/redirect'[2020-05-04T10:54:02.153Z] MAIL  = '/var/mail/jenkins'[2020-05-04T10:54:02.153Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/33/display/redirect?page=changes'[2020-05-04T10:54:02.153Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:54:02.153Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-05-04T10:54:02.153Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:54:02.153Z] EDITOR= 'vi'[2020-05-04T10:54:02.153Z] ENV   = '/home/jenkins/.shrc'[2020-05-04T10:54:02.153Z] HUDSON_HOME   = '/home/production/data'[2020-05-04T10:54:02.153Z] BUILD_ID  = '33'[2020-05-04T10:54:02.153Z] OLDPWD= '/usr/home/jenkins'[2020-05-04T10:54:02.153Z] PWD   = '/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:54:02.153Z] _ = '/usr/local/bin/java'[2020-05-04T10:54:02.153Z] TERM  = 'su'[2020-05-04T10:54:02.153Z] NODE_LABELS   = 'FreeBSD Builder Theta FreeBSDQt5.14'[2020-05-04T10:54:02.153Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 FreeBSDQt5.14-33'[2020-05-04T10:54:02.153Z] BUILD_DISPLAY_NAME= '#33'[2020-05-04T10:54:02.153Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/33/display/redirect'[2020-05-04T10:54:02.153Z] USER  = 'jenkins'[2020-05-04T10:54:02.153Z] HOME  = '/home/jenkins'[2020-05-04T10:54:02.153Z] BUILD_URL = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/33/'[2020-05-04T10:54:02.153Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/'[2020-05-04T10:54:02.153Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:54:02.153Z] SHELL = '/bin/sh'[2020-05-04T10:54:02.153Z] WORKSPACE = '/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:54:02.153Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:54:02.153Z] NODE_NAME = 'FreeBSD Builder Theta'[2020-05-04T10:54:02.153Z] BLOCKSIZE = 'K'[2020-05-04T10:54:02.153Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:54:02.153Z] SHLVL = '0'[2020-05-04T10:54:02.153Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:54:02.153Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-05-04T10:54:02.153Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-05-04T10:54:02.153Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-05-04T10:54:02.153Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-05-04T10:54:02.153Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-05-04T10:54:02.153Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-05-04T10:54:02.153Z] QT_SELECT = 'qt5'[2020-05-04T10:54:02.153Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:54:02.153Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:54:02.153Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-05-04T10:54:02.153Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-05-04T10:54:02.153Z] [2020-05-04T10:54:02.153Z] [2020-05-04T10:54:02.153Z] == Commencing Configuration:[2020-05-04T10:54:02.153Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14"[2020-05-04T10:54:02.736Z] -- The C compiler identification is Clang 8.0.1[2020-05-04T10:54:03.042Z] -- The CXX compiler 

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.14 - Build # 32 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/32/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 04 May 2020 10:45:47 +
 Build duration:
7 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 137 lines...][2020-05-04T10:53:15.118Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2020-05-04T10:53:15.118Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/display/redirect'[2020-05-04T10:53:15.118Z] MAIL  = '/var/mail/jenkins'[2020-05-04T10:53:15.118Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/32/display/redirect?page=changes'[2020-05-04T10:53:15.118Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:53:15.118Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-05-04T10:53:15.118Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:53:15.118Z] EDITOR= 'vi'[2020-05-04T10:53:15.118Z] ENV   = '/home/jenkins/.shrc'[2020-05-04T10:53:15.118Z] HUDSON_HOME   = '/home/production/data'[2020-05-04T10:53:15.118Z] BUILD_ID  = '32'[2020-05-04T10:53:15.118Z] OLDPWD= '/usr/home/jenkins'[2020-05-04T10:53:15.118Z] PWD   = '/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:53:15.118Z] _ = '/usr/local/bin/java'[2020-05-04T10:53:15.118Z] TERM  = 'su'[2020-05-04T10:53:15.118Z] NODE_LABELS   = 'FreeBSD Builder Iota FreeBSDQt5.14'[2020-05-04T10:53:15.118Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 FreeBSDQt5.14-32'[2020-05-04T10:53:15.118Z] BUILD_DISPLAY_NAME= '#32'[2020-05-04T10:53:15.118Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/32/display/redirect'[2020-05-04T10:53:15.118Z] USER  = 'jenkins'[2020-05-04T10:53:15.118Z] HOME  = '/home/jenkins'[2020-05-04T10:53:15.118Z] BUILD_URL = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/32/'[2020-05-04T10:53:15.118Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.14/'[2020-05-04T10:53:15.118Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:53:15.118Z] SHELL = '/bin/sh'[2020-05-04T10:53:15.118Z] WORKSPACE = '/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14'[2020-05-04T10:53:15.118Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:53:15.118Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-05-04T10:53:15.118Z] BLOCKSIZE = 'K'[2020-05-04T10:53:15.118Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:53:15.118Z] SHLVL = '0'[2020-05-04T10:53:15.118Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:53:15.118Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-05-04T10:53:15.118Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-05-04T10:53:15.118Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-05-04T10:53:15.118Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-05-04T10:53:15.118Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-05-04T10:53:15.118Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-05-04T10:53:15.118Z] QT_SELECT = 'qt5'[2020-05-04T10:53:15.118Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:53:15.118Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:53:15.118Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-05-04T10:53:15.118Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-05-04T10:53:15.118Z] [2020-05-04T10:53:15.118Z] [2020-05-04T10:53:15.118Z] == Commencing Configuration:[2020-05-04T10:53:15.118Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 FreeBSDQt5.14"[2020-05-04T10:53:15.385Z] -- The C compiler identification is Clang 8.0.1[2020-05-04T10:53:15.385Z] -- The CXX compiler 

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 58 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/58/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 04 May 2020 10:45:47 +
 Build duration:
4 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-05-04T10:50:33.492Z] PSMODULEPATH  = '%ProgramFiles%\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules'[2020-05-04T10:50:33.492Z] PUBLIC= 'C:\Users\Public'[2020-05-04T10:50:33.492Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/58/display/redirect?page=changes'[2020-05-04T10:50:33.492Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/58/display/redirect'[2020-05-04T10:50:33.492Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:50:33.492Z] SYSTEMDRIVE   = 'C:'[2020-05-04T10:50:33.492Z] SYSTEMROOT= 'C:\Windows'[2020-05-04T10:50:33.492Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2020-05-04T10:50:33.492Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2020-05-04T10:50:33.492Z] UCRTVERSION   = '10.0.18362.0'[2020-05-04T10:50:33.492Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2020-05-04T10:50:33.492Z] USERDOMAIN= 'DESKTOP-L331S90'[2020-05-04T10:50:33.492Z] USERNAME  = 'Jenkins'[2020-05-04T10:50:33.492Z] USERPROFILE   = 'C:\Users\Jenkins'[2020-05-04T10:50:33.492Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2020-05-04T10:50:33.492Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2020-05-04T10:50:33.492Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\'[2020-05-04T10:50:33.492Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.24.28127\'[2020-05-04T10:50:33.492Z] VCTOOLSVERSION= '14.24.28314'[2020-05-04T10:50:33.492Z] VISUALSTUDIOVERSION   = '16.0'[2020-05-04T10:50:33.492Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2020-05-04T10:50:33.492Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2020-05-04T10:50:33.492Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2020-05-04T10:50:33.492Z] VSCMD_ARG_TGT_ARCH= 'x64'[2020-05-04T10:50:33.492Z] VSCMD_VER = '16.4.3'[2020-05-04T10:50:33.492Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2020-05-04T10:50:33.492Z] WINDIR= 'C:\Windows'[2020-05-04T10:50:33.492Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0'[2020-05-04T10:50:33.492Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2020-05-04T10:50:33.492Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2020-05-04T10:50:33.492Z] WINDOWSSDKLIBVERSION  = '10.0.18362.0\'[2020-05-04T10:50:33.492Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\'[2020-05-04T10:50:33.492Z] WINDOWSSDKVERSION = '10.0.18362.0\'[2020-05-04T10:50:33.492Z] WORKSPACE = 'C:/CI/Job Build'[2020-05-04T10:50:33.492Z] __DOTNET_ADD_64BIT= '1'[2020-05-04T10:50:33.492Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-05-04T10:50:33.492Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-05-04T10:50:33.492Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\knewstuff;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-05-04T10:50:33.492Z] PKG_CONFIG_PATH   = 'C:\CI\Software Installs\knewstuff\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-05-04T10:50:33.492Z] QT_PLUGIN_PATH= 'C:\CI\Software Installs\knewstuff\lib\plugins;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-05-04T10:50:33.492Z] QML2_IMPORT_PATH  = 'C:\CI\Software Installs\knewstuff\lib\qml'[2020-05-04T10:50:33.492Z] XDG_DATA_DIRS = 'C:\CI\Software 

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 194 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/194/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 May 2020 10:48:08 +
 Build duration:
1 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-05-04T10:49:45.660Z] HOME  = '/home/jenkins/'[2020-05-04T10:49:45.660Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:49:45.660Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2020-05-04T10:49:45.660Z] OSTYPE= 'linux'[2020-05-04T10:49:45.660Z] JOB_NAME  = 'Frameworks/knewstuff/kf5-qt5 SUSEQt5.12'[2020-05-04T10:49:45.660Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-05-04T10:49:45.660Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/194/display/redirect'[2020-05-04T10:49:45.660Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-05-04T10:49:45.660Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.12'[2020-05-04T10:49:45.660Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:49:45.660Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-05-04T10:49:45.660Z] NODE_NAME = 'Docker Swarm-33d72e3afcc4'[2020-05-04T10:49:45.660Z] HOST  = '33d72e3afcc4'[2020-05-04T10:49:45.660Z] LESSOPEN  = 'lessopen.sh %s'[2020-05-04T10:49:45.660Z] USER  = 'jenkins'[2020-05-04T10:49:45.660Z] MORE  = '-sl'[2020-05-04T10:49:45.660Z] CSHEDIT   = 'emacs'[2020-05-04T10:49:45.660Z] SHLVL = '2'[2020-05-04T10:49:45.660Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 SUSEQt5.12-194'[2020-05-04T10:49:45.660Z] WINDOWMANAGER = 'xterm'[2020-05-04T10:49:45.660Z] PAGER = 'less'[2020-05-04T10:49:45.660Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:49:45.660Z] CVS_RSH   = 'ssh'[2020-05-04T10:49:45.660Z] LIBGL_DEBUG   = 'quiet'[2020-05-04T10:49:45.660Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:49:45.660Z] NODE_LABELS   = 'Docker Swarm-33d72e3afcc4 SUSEQt5.12'[2020-05-04T10:49:45.660Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-05-04T10:49:45.660Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-05-04T10:49:45.660Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-05-04T10:49:45.660Z] PROFILEREAD   = 'true'[2020-05-04T10:49:45.660Z] MAIL  = '/var/spool/mail/jenkins'[2020-05-04T10:49:45.660Z] HOSTTYPE  = 'x86_64'[2020-05-04T10:49:45.660Z] BUILD_ID  = '194'[2020-05-04T10:49:45.660Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-05-04T10:49:45.660Z] OLDPWD= '/home/jenkins'[2020-05-04T10:49:45.660Z] LC_CTYPE  = 'C.UTF-8'[2020-05-04T10:49:45.660Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:49:45.660Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-05-04T10:49:45.660Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-05-04T10:49:45.660Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-05-04T10:49:45.660Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-05-04T10:49:45.660Z] QT_SELECT = 'qt5'[2020-05-04T10:49:45.660Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:49:45.660Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:49:45.660Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-05-04T10:49:45.660Z] [2020-05-04T10:49:45.660Z] [2020-05-04T10:49:45.660Z] == Commencing Configuration:[2020-05-04T10:49:45.660Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.12"[2020-05-04T10:49:45.917Z] -- The C compiler identification is GNU 9.3.1[2020-05-04T10:49:46.175Z] -- The CXX compiler identification is GNU 9.3.1[2020-05-04T10:49:46.175Z] -- Check for working C compiler: /usr/bin/cc[2020-05-04T10:49:46.175Z] -- Check for working C compiler: /usr/bin/cc - works[2020-05-04T10:49:46.175Z] -- Detecting C compiler ABI info[2020-05-04T10:49:46.432Z] -- Detecting C compiler ABI info - done[2020-05-04T10:49:46.432Z] -- Detecting C compile 

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 31 - Still Failing!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/31/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 04 May 2020 10:47:21 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-05-04T10:48:15.856Z] HOME  = '/home/jenkins/'[2020-05-04T10:48:15.856Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:48:15.856Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.14'[2020-05-04T10:48:15.856Z] OSTYPE= 'linux'[2020-05-04T10:48:15.856Z] JOB_NAME  = 'Frameworks/knewstuff/kf5-qt5 SUSEQt5.14'[2020-05-04T10:48:15.856Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-05-04T10:48:15.856Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/31/display/redirect'[2020-05-04T10:48:15.856Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/display/redirect'[2020-05-04T10:48:15.856Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.14'[2020-05-04T10:48:15.856Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:48:15.856Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-05-04T10:48:15.856Z] NODE_NAME = 'Docker Swarm-27abb5e2332a'[2020-05-04T10:48:15.856Z] HOST  = '27abb5e2332a'[2020-05-04T10:48:15.856Z] LESSOPEN  = 'lessopen.sh %s'[2020-05-04T10:48:15.856Z] USER  = 'jenkins'[2020-05-04T10:48:15.856Z] MORE  = '-sl'[2020-05-04T10:48:15.856Z] CSHEDIT   = 'emacs'[2020-05-04T10:48:15.856Z] SHLVL = '2'[2020-05-04T10:48:15.856Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 SUSEQt5.14-31'[2020-05-04T10:48:15.856Z] WINDOWMANAGER = 'xterm'[2020-05-04T10:48:15.856Z] PAGER = 'less'[2020-05-04T10:48:15.856Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:48:15.856Z] CVS_RSH   = 'ssh'[2020-05-04T10:48:15.856Z] LIBGL_DEBUG   = 'quiet'[2020-05-04T10:48:15.856Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:48:15.857Z] NODE_LABELS   = 'Docker Swarm-27abb5e2332a SUSEQt5.14'[2020-05-04T10:48:15.857Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-05-04T10:48:15.857Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-05-04T10:48:15.857Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-05-04T10:48:15.857Z] PROFILEREAD   = 'true'[2020-05-04T10:48:15.857Z] MAIL  = '/var/spool/mail/jenkins'[2020-05-04T10:48:15.857Z] HOSTTYPE  = 'x86_64'[2020-05-04T10:48:15.857Z] BUILD_ID  = '31'[2020-05-04T10:48:15.857Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-05-04T10:48:15.857Z] OLDPWD= '/home/jenkins'[2020-05-04T10:48:15.857Z] LC_CTYPE  = 'C.UTF-8'[2020-05-04T10:48:15.857Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:48:15.857Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-05-04T10:48:15.857Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-05-04T10:48:15.857Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-05-04T10:48:15.857Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-05-04T10:48:15.857Z] QT_SELECT = 'qt5'[2020-05-04T10:48:15.857Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:48:15.857Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:48:15.857Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-05-04T10:48:15.857Z] [2020-05-04T10:48:15.857Z] [2020-05-04T10:48:15.857Z] == Commencing Configuration:[2020-05-04T10:48:15.857Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.14"[2020-05-04T10:48:16.121Z] -- The C compiler identification is GNU 9.3.1[2020-05-04T10:48:16.121Z] -- The CXX compiler identification is GNU 9.3.1[2020-05-04T10:48:16.121Z] -- Check for working C compiler: /usr/bin/cc[2020-05-04T10:48:16.386Z] -- Check for working C compiler: /usr/bin/cc - works[2020-05-04T10:48:16.386Z] -- Detecting C compiler ABI info[2020-05-04T10:48:16.386Z] -- Detecting C compiler ABI info - done[2020-05-04T10:48:16.386Z] -- Detecting C compile 

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 193 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/193/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 May 2020 10:45:47 +
 Build duration:
2 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-05-04T10:47:44.236Z] HOME  = '/home/jenkins/'[2020-05-04T10:47:44.236Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:47:44.236Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2020-05-04T10:47:44.236Z] OSTYPE= 'linux'[2020-05-04T10:47:44.236Z] JOB_NAME  = 'Frameworks/knewstuff/kf5-qt5 SUSEQt5.12'[2020-05-04T10:47:44.236Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-05-04T10:47:44.236Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/193/display/redirect'[2020-05-04T10:47:44.236Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-05-04T10:47:44.236Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.12'[2020-05-04T10:47:44.236Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:47:44.236Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-05-04T10:47:44.236Z] NODE_NAME = 'Docker Swarm-f12dc08a0ffb'[2020-05-04T10:47:44.236Z] HOST  = 'f12dc08a0ffb'[2020-05-04T10:47:44.236Z] LESSOPEN  = 'lessopen.sh %s'[2020-05-04T10:47:44.236Z] USER  = 'jenkins'[2020-05-04T10:47:44.236Z] MORE  = '-sl'[2020-05-04T10:47:44.236Z] CSHEDIT   = 'emacs'[2020-05-04T10:47:44.236Z] SHLVL = '2'[2020-05-04T10:47:44.236Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 SUSEQt5.12-193'[2020-05-04T10:47:44.236Z] WINDOWMANAGER = 'xterm'[2020-05-04T10:47:44.236Z] PAGER = 'less'[2020-05-04T10:47:44.236Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:47:44.236Z] CVS_RSH   = 'ssh'[2020-05-04T10:47:44.236Z] LIBGL_DEBUG   = 'quiet'[2020-05-04T10:47:44.236Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:47:44.236Z] NODE_LABELS   = 'Docker Swarm-f12dc08a0ffb SUSEQt5.12'[2020-05-04T10:47:44.237Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-05-04T10:47:44.237Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-05-04T10:47:44.237Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-05-04T10:47:44.237Z] PROFILEREAD   = 'true'[2020-05-04T10:47:44.237Z] MAIL  = '/var/spool/mail/jenkins'[2020-05-04T10:47:44.237Z] HOSTTYPE  = 'x86_64'[2020-05-04T10:47:44.237Z] BUILD_ID  = '193'[2020-05-04T10:47:44.237Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-05-04T10:47:44.237Z] OLDPWD= '/home/jenkins'[2020-05-04T10:47:44.237Z] LC_CTYPE  = 'C.UTF-8'[2020-05-04T10:47:44.237Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:47:44.237Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-05-04T10:47:44.237Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-05-04T10:47:44.237Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-05-04T10:47:44.237Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-05-04T10:47:44.237Z] QT_SELECT = 'qt5'[2020-05-04T10:47:44.237Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:47:44.237Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:47:44.237Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-05-04T10:47:44.237Z] [2020-05-04T10:47:44.237Z] [2020-05-04T10:47:44.237Z] == Commencing Configuration:[2020-05-04T10:47:44.237Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.12"[2020-05-04T10:47:47.545Z] -- The C compiler identification is GNU 9.3.1[2020-05-04T10:47:50.834Z] -- The CXX compiler identification is GNU 9.3.1[2020-05-04T10:47:50.834Z] -- Check for working C compiler: /usr/bin/cc[2020-05-04T10:47:51.400Z] -- Check for working C compiler: /usr/bin/cc - works[2020-05-04T10:47:51.400Z] -- Detecting C compiler ABI info[2020-05-04T10:47:51.657Z] -- Detecting C compiler ABI info - done[2020-05-04T10:47:51.961Z] -- Detecting C compile 

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.14 - Build # 30 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/30/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 04 May 2020 10:45:47 +
 Build duration:
1 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-05-04T10:47:16.921Z] HOME  = '/home/jenkins/'[2020-05-04T10:47:16.921Z] JENKINS_URL   = 'https://build.kde.org/'[2020-05-04T10:47:16.921Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.14'[2020-05-04T10:47:16.921Z] OSTYPE= 'linux'[2020-05-04T10:47:16.921Z] JOB_NAME  = 'Frameworks/knewstuff/kf5-qt5 SUSEQt5.14'[2020-05-04T10:47:16.921Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-05-04T10:47:16.921Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/30/display/redirect'[2020-05-04T10:47:16.921Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.14/display/redirect'[2020-05-04T10:47:16.921Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.14'[2020-05-04T10:47:16.921Z] HUDSON_URL= 'https://build.kde.org/'[2020-05-04T10:47:16.921Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-05-04T10:47:16.921Z] NODE_NAME = 'Docker Swarm-a5c447a641b1'[2020-05-04T10:47:16.921Z] HOST  = 'a5c447a641b1'[2020-05-04T10:47:16.921Z] LESSOPEN  = 'lessopen.sh %s'[2020-05-04T10:47:16.921Z] USER  = 'jenkins'[2020-05-04T10:47:16.921Z] MORE  = '-sl'[2020-05-04T10:47:16.921Z] CSHEDIT   = 'emacs'[2020-05-04T10:47:16.921Z] SHLVL = '2'[2020-05-04T10:47:16.921Z] BUILD_TAG = 'jenkins-Frameworks-knewstuff-kf5-qt5 SUSEQt5.14-30'[2020-05-04T10:47:16.921Z] WINDOWMANAGER = 'xterm'[2020-05-04T10:47:16.921Z] PAGER = 'less'[2020-05-04T10:47:16.921Z] EXECUTOR_NUMBER   = '0'[2020-05-04T10:47:16.921Z] CVS_RSH   = 'ssh'[2020-05-04T10:47:16.921Z] LIBGL_DEBUG   = 'quiet'[2020-05-04T10:47:16.921Z] STAGE_NAME= 'Configuring Build'[2020-05-04T10:47:16.921Z] NODE_LABELS   = 'Docker Swarm-a5c447a641b1 SUSEQt5.14'[2020-05-04T10:47:16.921Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-05-04T10:47:16.921Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-05-04T10:47:16.921Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-05-04T10:47:16.921Z] PROFILEREAD   = 'true'[2020-05-04T10:47:16.921Z] MAIL  = '/var/spool/mail/jenkins'[2020-05-04T10:47:16.921Z] HOSTTYPE  = 'x86_64'[2020-05-04T10:47:16.921Z] BUILD_ID  = '30'[2020-05-04T10:47:16.921Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-05-04T10:47:16.921Z] OLDPWD= '/home/jenkins'[2020-05-04T10:47:16.921Z] LC_CTYPE  = 'C.UTF-8'[2020-05-04T10:47:16.921Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-05-04T10:47:16.921Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-05-04T10:47:16.921Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-05-04T10:47:16.921Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-05-04T10:47:16.921Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-05-04T10:47:16.921Z] QT_SELECT = 'qt5'[2020-05-04T10:47:16.921Z] LANG  = 'en_US.UTF-8'[2020-05-04T10:47:16.921Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-05-04T10:47:16.921Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-05-04T10:47:16.921Z] [2020-05-04T10:47:16.921Z] [2020-05-04T10:47:16.921Z] == Commencing Configuration:[2020-05-04T10:47:16.921Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/knewstuff/kf5-qt5 SUSEQt5.14"[2020-05-04T10:47:16.921Z] -- The C compiler identification is GNU 9.3.1[2020-05-04T10:47:17.177Z] -- The CXX compiler identification is GNU 9.3.1[2020-05-04T10:47:17.177Z] -- Check for working C compiler: /usr/bin/cc[2020-05-04T10:47:17.177Z] -- Check for working C compiler: /usr/bin/cc - works[2020-05-04T10:47:17.177Z] -- Detecting C compiler ABI info[2020-05-04T10:47:17.177Z] -- Detecting C compiler ABI info - done[2020-05-04T10:47:17.177Z] -- Detecting C compile 

D29222: Fix update auto selection

2020-05-04 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:12642a1c0174: Fix update auto selection (authored by 
leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29222?vs=81412=81869

REVISION DETAIL
  https://phabricator.kde.org/D29222

AFFECTED FILES
  src/core/cache.cpp
  src/core/engine.cpp

To: leinir, #frameworks, #plasma, bugseforuns, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:3f38da8a70d8: Add KPackage support to KNewStuffCore 
(authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=81859=81868

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/core/jobs/kpackagejob.cpp
  src/core/jobs/kpackagejob.h
  src/downloaddialog.h

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29222: Fix update auto selection

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update-autoselection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29222

To: leinir, #frameworks, #plasma, bugseforuns, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 81859.
leinir added a comment.


  Since we have had a new Frameworks release while this is waiting
  for the thumbs up, increase the @since to the next version.
  
  - Merge branch 'master' into add-kpackage-support
  - Merge branch 'master' into add-kpackage-support
  - I was trying to avoid this. Update @since to 0.71

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=80862=81859

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/core/jobs/kpackagejob.cpp
  src/core/jobs/kpackagejob.h
  src/downloaddialog.h

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex added a reviewer: mart.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81856.
alex added a comment.


  Linebreak

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29201?vs=81855=81856

BRANCH
  service_path_append (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29201

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h
  src/kpluginselector_p.h

To: alex, #plasma, ngraham, meven, broulik
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81855.
alex added a comment.


  Improve documentation
  
  Is that what you had in mind :-) ?
  
  And should I maybe add a comment to make this the default in KF6?

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29201?vs=81799=81855

BRANCH
  service_path_append (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29201

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h
  src/kpluginselector_p.h

To: alex, #plasma, ngraham, meven, broulik
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-05-04 Thread Frederick Yin
fakefred added a comment.


  So I tested this, great improvements regarding line height can be seen: 
  F8283136: kate_1.png 
  
  在使用本身就是 CJK 的字体时,显示仍然正常。
  F8283141: kate_2.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks
Cc: fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, 
LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, 
dhaumann


Re: Mentors needed

2020-05-04 Thread Alexa M
Hi,

The student decided to not to participate in GSoC this year due to
other university
obligations running late because of the current situation including uncertain
exams dates and he was afraid he would not be able to comply.

Best,
AlexandraB

On Fri, May 1, 2020, 00:06 Timothée Giet  wrote:

> Le 30/04/2020 à 22:07, Timothée Giet a écrit :
>
> Le 30/04/2020 à 21:38, Valorie Zimmerman a écrit :
>
> Hello folks, we have a project about porting a QtQuickControls module to
> QtQuickControls2 with only one mentor who marked "I want to mentor" on the
> GSoC webapp.
>
> If you have already signed into the GSoC webapp as a mentor, and would
> like to help out with this project, please mark "I want to mentor" in the
> app.
>
> If you have the skills needed to mentor but have not yet logged into the
> app, please:
>
> 1. ensure that you are subscribed to KDE-Soc-Mentor mail list [1]
>
> 2. write to kde-soc-managem...@kde.org and ask to be invited to the
> webapp.
>
> Thanks!
>
> Valorie
>
> 1. https://mail.kde.org/mailman/listinfo/kde-soc-mentor
>
> --
> http://about.me/valoriez - pronouns: she/her
>
>
> I may not be the best mentor this project, but as GCompris would benefit a
> lot from the output of this proposal (this missing module is the main
> blocker we have to migrate to QtQuickControls2), I'm ok to backup-mentor
> it... At least I can provide generic advices and testing.
>
> But some help from someone more specialist of Qt internals would be
> welcome!
>
> Timothée
>
> On second thought, as I'm not so sure I can provide valuable help to
> mentor this project, I unchecked the "want to mentor" button there... but
> again, if there's anyone else willing to help mentoring this project, it
> would be awesome.
>
> Timo.
>


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Marco Martin
mart added a comment.


  indeed, a bit more documentation then go for it

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 79 - Failure!

2020-05-04 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/79/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 04 May 2020 09:03:39 +
 Build duration:
5 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 80 lines...][2020-05-04T09:05:16.685Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2020-05-04T09:05:16.685Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:16.903Z] Checking out Revision 85f8d51e658e9b75ca3788e598995aee62bc8bba (origin/master)[2020-05-04T09:05:16.994Z] Commit message: "kwayland-server is unstable only for now"[2020-05-04T09:05:16.884Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-05-04T09:05:16.905Z]  > git config core.sparsecheckout # timeout=10[2020-05-04T09:05:16.945Z]  > git checkout -f 85f8d51e658e9b75ca3788e598995aee62bc8bba # timeout=10[Pipeline] checkout[2020-05-04T09:05:26.430Z] No credentials specified[2020-05-04T09:05:26.433Z] Cloning the remote Git repository[2020-05-04T09:05:27.372Z] Checking out Revision efbc6aa56a7fe4c3cf788cdec224bf73a5e54865 (origin/master)[2020-05-04T09:05:27.393Z] Commit message: "Fix missing whitespace after "Platform(s):" on front page"[2020-05-04T09:05:26.435Z] Cloning repository https://anongit.kde.org/kapidox[2020-05-04T09:05:26.435Z]  > git init /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.14/ci-tooling/kapidox # timeout=10[2020-05-04T09:05:26.441Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2020-05-04T09:05:26.441Z]  > git --version # timeout=10[2020-05-04T09:05:26.450Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:27.160Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2020-05-04T09:05:27.162Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:27.167Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2020-05-04T09:05:27.173Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2020-05-04T09:05:27.173Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:27.368Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-05-04T09:05:27.373Z]  > git config core.sparsecheckout # timeout=10[2020-05-04T09:05:27.375Z]  > git checkout -f efbc6aa56a7fe4c3cf788cdec224bf73a5e54865 # timeout=10[Pipeline] checkout[2020-05-04T09:05:52.435Z] No credentials specified[2020-05-04T09:05:52.438Z] Cloning the remote Git repository[2020-05-04T09:05:52.439Z] Cloning repository https://anongit.kde.org/kde-dev-scripts[2020-05-04T09:05:52.440Z]  > git init /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.14/ci-tooling/kde-dev-scripts # timeout=10[2020-05-04T09:05:52.460Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-05-04T09:05:52.460Z]  > git --version # timeout=10[2020-05-04T09:05:52.479Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:53.760Z] Checking out Revision de1e2fd97aae301bf39e4015b456a247721a155c (origin/master)[2020-05-04T09:05:53.794Z] Commit message: "Add myself (davidhurka) to relicensecheck.pl"[2020-05-04T09:05:53.516Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-05-04T09:05:53.518Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:53.526Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-05-04T09:05:53.530Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-05-04T09:05:53.531Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-05-04T09:05:53.756Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-05-04T09:05:53.762Z]  > git config core.sparsecheckout # timeout=10[2020-05-04T09:05:53.764Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-05-04T09:07:13.703Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kio --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-05-04T09:07:28.657Z] Traceback (most recent call last):[2020-05-04T09:07:28.657Z]   File "/usr/lib64/python3.8/urllib/request.py", line 1319, in do_open[2020-05-04T09:07:28.657Z] h.request(req.get_method(), req.selector, req.data, headers,[2020-05-04T09:07:28.657Z]   File "/usr/lib64/python3.8/http/client.py", line 

D28499: [LauncherJobs] Emit description

2020-05-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:692d9bc81f00: [LauncherJobs] Emit description (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28499?vs=79700=81849#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28499?vs=79700=81849

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29381: Thumbnail text: use libmagic to detect encoding

2020-05-04 Thread Méven Car
meven added a comment.


  In D29381#662084 , @pino wrote:
  
  > why not KEncodingProber from the KCodecs framework, like also the commented 
bits hint about?
  
  
  I tested first KEncodingProber, it just returns bad data, returning "UTF-8" 
sometimes for what it is not, or "windows-something" for what is ISO-8859.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-04 Thread David Faure
dfaure updated this revision to Diff 81840.
dfaure added a comment.


  Remove local-files fast path.
  
  This also showed a small mistake in the handling of error texts
  (this job isn't a KIO::Job so we need to call buildErrorString ourselves).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29385?vs=81830=81840

BRANCH
  2020_05_openurljob

REVISION DETAIL
  https://phabricator.kde.org/D29385

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/krununittest.cpp
  autotests/openurljobtest.cpp
  autotests/openurljobtest.h
  src/core/kurlauthorized.h
  src/gui/CMakeLists.txt
  src/gui/applicationlauncherjob.cpp
  src/gui/applicationlauncherjob.h
  src/gui/openurljob.cpp
  src/gui/openurljob.h
  src/gui/openurljobhandlerinterface.cpp
  src/gui/openurljobhandlerinterface.h
  src/widgets/CMakeLists.txt
  src/widgets/jobuidelegate.cpp
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/krun.cpp
  src/widgets/widgetsopenurljobhandler.cpp
  src/widgets/widgetsopenurljobhandler.h

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-04 Thread David Faure
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> previewjob.cpp:717
> +qreal imgDevicePixelRatio;
> +str >> width >> height >> iFormat >> imgDevicePixelRatio;
>  QImage::Format format = static_cast(iFormat);

This here also breaks compatibility. Add a KF6 TODO to start the serialization 
with a version number.

Meanwhile a hack is needed, like `if (iFormat & 0x1000) { iFormat &= 0xFFF; str 
>> imgDevicePixelRatio; }`
and of course setting that 0x1000 flag in the slaves that have been updated to 
provide the pixelratio.

> thumbcreator.h:183
>  class KIOWIDGETS_DEPRECATED_VERSION(5, 0, "Use ThumbCreator")
>  KIOWIDGETS_EXPORT ThumbCreatorV2 : public ThumbCreator
>  {

You need to do like we once did: define an interface that inherits from 
ThumbCreator.
Call it V3

In the job, use dynamic_cast to test whether the object provided by the 
kioslave supports the V3 interface or not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29197: filenamesearch: Implement stat to display metainfo

2020-05-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:951e2f2d49a8: filenamesearch: Implement stat to display 
metainfo (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29197?vs=81232=81837

REVISION DETAIL
  https://phabricator.kde.org/D29197

AFFECTED FILES
  filenamesearch/CMakeLists.txt
  filenamesearch/kio_filenamesearch.cpp
  filenamesearch/kio_filenamesearch.h

To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-04 Thread Méven Car
meven created this revision.
meven added reviewers: dfaure, broulik, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Allow users of KPreviewJob to request a devicePixelRatio for generated 
thumbnails.
  The result image is not guaranteed to have this ratio, and users should paint 
it accordingly.
  
  The patch currently breaks binary compatibility though.
  I would like to have some feedback how to work out this issue.
  
  An update to kio-extras thumbnail is in the works.

REPOSITORY
  R241 KIO

BRANCH
  preview-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29397

AFFECTED FILES
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/thumbcreator.h

To: meven, dfaure, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns