Re: further coinstallability
On 25/11/2013 07:45, Stephen Kelly wrote: Jonathan Riddell wrote: developer files matter to some people to be co-installable. Header files and others can probably be moved to a separate directory Can you be more specific about why this is easy with header files? Does this refer to installing to a include/KF5 directory? We are currently doing this. Passing, for example, -DINCLUDE_INSTALL_DIR=/usr/include/kf5/ just works and CMake takes care of the rest. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113975: Make some KSSL files public API
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113975/ --- (Updated Nov. 25, 2013, 11:39 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- I was trying to get KHTML to build standalone, the only missing part I have is these files need to be public API and in the correct namespace. Diffs - tier3/kio/src/core/CMakeLists.txt 1944435 Diff: http://git.reviewboard.kde.org/r/113975/diff/ Testing --- Everything still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113996: Install needed private headers for FrameworksIntegration
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44385 --- This review has been submitted with commit 6fd9c9878fdfc0d055b228c2a9892a16b16d862b by Aleix Pol to branch frameworks. - Commit Hook On Nov. 22, 2013, 10:50 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/ --- (Updated Nov. 22, 2013, 10:50 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- There are 2 headers to install: - kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it should be installed - kiconengine_p.h: I have no idea, but it's still needed. (note it's also needed by kicon.cpp in kde4support). Diffs - tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf tier3/kiconthemes/src/CMakeLists.txt 4b3c978 tier3/kiconthemes/src/kiconengine_p.h Diff: http://git.reviewboard.kde.org/r/113996/diff/ Testing --- FrameworksIntegration builds modularized, monolithic kdelibs still build as well. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44384 --- This review has been submitted with commit 12a3023c7134afd957e39886363294d04e3cfe88 by Aleix Pol to branch frameworks. - Commit Hook On Nov. 22, 2013, 6:23 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 6:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 25, 2013, 12:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #915
See http://build.kde.org/job/plasma-framework_master_qt5/915/changes Changes: [mklapetek] Make the calendar applet follow current locale with first day in week [mklapetek] Add some docs to Calendar binginds -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1858625735532192458.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework dca0a11..ff47006 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at dca0a11 SVN_SILENT made messages (.desktop file) Removing build/ Success build forhudson.tasks.Shell@824cabd Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision ff4700684564804b920eb68f7d369c699e5a16de (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7824458875956796633.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: strigidaemon - Branch master qt5 - Branch stable libstreamanalyzer - Branch master extra-cmake-modules - Branch master libstreams - Branch master kactivities - Branch frameworks strigiclient - Branch master kdelibs - Branch frameworks attica - Branch master strigiutils - Branch master phonon - Branch master polkit-qt-1 - Branch qt5 == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Error at /srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KF5/KF5Config.cmake:26 (find_package): Could not find a package configuration file provided by KActivities with any of the following names: KActivitiesConfig.cmake kactivities-config.cmake Add the installation prefix of KActivities to CMAKE_PREFIX_PATH or set KActivities_DIR to a directory containing one of the above files. If KActivities provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:45 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/plasma-framework_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113996: Install needed private headers for FrameworksIntegration
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/ --- (Updated Nov. 25, 2013, 12:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- There are 2 headers to install: - kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it should be installed - kiconengine_p.h: I have no idea, but it's still needed. (note it's also needed by kicon.cpp in kde4support). Diffs - tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf tier3/kiconthemes/src/CMakeLists.txt 4b3c978 tier3/kiconthemes/src/kiconengine_p.h Diff: http://git.reviewboard.kde.org/r/113996/diff/ Testing --- FrameworksIntegration builds modularized, monolithic kdelibs still build as well. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1755
See http://build.kde.org/job/kdelibs_frameworks_qt5/1755/changes Changes: [aleixpol] Fix some porting notes [aleixpol] Reduce private headers usage from KDE4Support [aleixpol] Install needed headers for FrameworksIntegration -- [...truncated 5607 lines...] Linking CXX executable test5 Generating test8a.cpp, test8a.h http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kconfig/autotests/kconfig_compiler/test7.h:0: Note: No relevant classes found. No output generated. [ 55%] Generating test8a.moc [ 55%] Generating test9.cpp, test9.h http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kconfig/autotests/kconfig_compiler/test8a.h:0: Note: No relevant classes found. No output generated. [ 55%] [ 55%] Scanning dependencies of target test6 Scanning dependencies of target test7 Generating test8b.moc Generating test9.moc [ 55%] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kconfig/autotests/kconfig_compiler/test8b.h:0: Note: No relevant classes found. No output generated. Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test6.dir/test6main.cpp.o [ 55%] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kconfig/autotests/kconfig_compiler/test9.h:0: Note: No relevant classes found. No output generated. [ 55%] Built target test4 Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test7.dir/test7main.cpp.o [ 55%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test7.dir/test7.cpp.o [ 55%] [ 55%] [ 55%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test6.dir/test6.cpp.o Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test7.dir/test7_automoc.cpp.o Scanning dependencies of target test8 Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test6.dir/test6_automoc.cpp.o Linking CXX executable test7 [ 55%] Scanning dependencies of target test9 [ 55%] Generating test_dpointer.cpp, test_dpointer.h Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test8.dir/test8main.cpp.o [ 55%] [ 55%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/klocalsocket_unix.cpp.o Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test9.dir/test9main.cpp.o [ 56%] Linking CXX executable test6 Generating test_dpointer.moc http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier1/kconfig/autotests/kconfig_compiler/test_dpointer.h:0: Note: No relevant classes found. No output generated. [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test8.dir/test8a.cpp.o [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test9.dir/test9.cpp.o Scanning dependencies of target test_dpointer [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test8.dir/test8b.cpp.o [ 56%] [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test9.dir/test9_automoc.cpp.o [ 56%] Built target test5 [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer_main.cpp.o Linking CXX executable test9 Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test8.dir/test8_automoc.cpp.o [ 56%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/klauncher_interface.cpp.o Linking CXX executable test8 [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer.cpp.o [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer_automoc.cpp.o [ 56%] Built target test7 Linking CXX executable test_dpointer [ 56%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/kpasswdserver_interface.cpp.o [ 56%] Built target test6 [ 56%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/KIOCore_automoc.cpp.o [ 56%] Built target test9 [ 56%] Generating test_signal.cpp, test_signal.h [ 56%] [ 56%] Generating test_signal.moc Built target test8 Scanning dependencies of target kjs_bin Scanning dependencies of target test_signal Scanning dependencies of target solidextensionplugin [ 56%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/kjs_bin.dir/kjs.cpp.o [ 56%] [ 56%] [ 56%] [ 56%] Built target test_dpointer Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal_main.cpp.o Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal.cpp.o Building CXX object tier1/solid/src/imports/CMakeFiles/solidextensionplugin.dir/solidextensionplugin.cpp.o [ 56%] Building CXX object tier1/kconfig/autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal_automoc.cpp.o [ 56%] Building CXX object tier1/solid/src/imports/CMakeFiles/solidextensionplugin.dir/devices.cpp.o [ 56%] Building CXX object
Re: Review Request 113910: Add basic KArchive examples
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 12:35 p.m.) Review request for KDE Frameworks. Changes --- Simplify the example. Add REQUIRED keyword Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on: License? Currently BSD. Code comments. More, less? Readability? Other examples I'm working on: helloworld with qmake something with KCompressionDevice perhaps a minimal ark like example Diffs (updated) - tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/helloworld/main.cpp PRE-CREATION tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1756
See http://build.kde.org/job/kdelibs_frameworks_qt5/1756/changes Changes: [aleixpol] Add superbuild entries for tier4 -- [...truncated 5542 lines...] Linking CXX executable kptyprocesstest [ 53%] [ 53%] Built target kdeinit5 Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/process.cpp.o [ 53%] Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/kcookie.cpp.o Linking CXX shared library libkrossqtsplugin.so [ 53%] [ 53%] Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/su.cpp.o Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/ssh.cpp.o [ 53%] Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/stub.cpp.o [ 53%] Built target kross [ 53%] [ 53%] Building CXX object tier3/kdesu/src/CMakeFiles/KDESu.dir/KDESu_automoc.cpp.o Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/kremoteencoding.cpp.o [ 53%] Linking CXX shared library libKDESu.so Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/sessiondata.cpp.o [ 53%] Built target kdeinit_kded5 [ 54%] [ 54%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/slavebase.cpp.o Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/dataslave.cpp.o [ 54%] [ 54%] [ 54%] Scanning dependencies of target backgroundtest Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/dataprotocol.cpp.o Built target krossqts Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/authinfo.cpp.o [ 54%] [ 54%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/slaveinterface.cpp.o Building CXX object tier1/sonnet/tests/CMakeFiles/backgroundtest.dir/backgroundtest.cpp.o [ 54%] Built target kptyprocesstest [ 54%] [ 54%] [ 54%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/slave.cpp.o Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/job.cpp.o Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/job_error.cpp.o http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kio/src/core/slaveinterface.cpp:357:6: warning: unused parameter ‘host’ [-Wunused-parameter] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kio/src/core/slaveinterface.cpp:357:6: warning: unused parameter ‘slaveid’ [-Wunused-parameter] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kio/src/core/slaveinterface.cpp:367:6: warning: unused parameter ‘host’ [-Wunused-parameter] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kio/src/core/slaveinterface.cpp:367:6: warning: unused parameter ‘slaveid’ [-Wunused-parameter] [ 54%] Building CXX object tier1/sonnet/tests/CMakeFiles/backgroundtest.dir/backgroundtest_automoc.cpp.o Scanning dependencies of target test_configdialog [ 54%] Linking CXX executable backgroundtest Building CXX object tier1/sonnet/tests/CMakeFiles/test_configdialog.dir/test_configdialog.cpp.o [ 54%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/scheduler.cpp.o Scanning dependencies of target test_dialog [ 54%] [ 54%] Building CXX object tier1/sonnet/tests/CMakeFiles/test_configdialog.dir/test_configdialog_automoc.cpp.o [ 54%] Scanning dependencies of target test_dictionarycombobox Built target KDESu Building CXX object tier1/sonnet/tests/CMakeFiles/test_dialog.dir/test_dialog.cpp.o [ 54%] Linking CXX executable test_configdialog Building CXX object tier1/sonnet/tests/CMakeFiles/test_dialog.dir/test_dialog_automoc.cpp.o [ 54%] Building CXX object tier1/sonnet/tests/CMakeFiles/test_dictionarycombobox.dir/test_dictionarycombobox.cpp.o [ 54%] Building CXX object tier1/sonnet/tests/CMakeFiles/test_dictionarycombobox.dir/test_dictionarycombobox_automoc.cpp.o Scanning dependencies of target test_highlighter Linking CXX executable test_dialog [ 54%] Linking CXX executable test_dictionarycombobox Building CXX object tier1/sonnet/tests/CMakeFiles/test_highlighter.dir/test_highlighter.cpp.o [ 54%] Built target KJS [ 54%] Scanning dependencies of target test_textedit Building CXX object tier1/sonnet/tests/CMakeFiles/test_highlighter.dir/test_highlighter_automoc.cpp.o [ 54%] Building CXX object tier1/sonnet/tests/CMakeFiles/test_textedit.dir/test_textedit.cpp.o Linking CXX executable test_highlighter Scanning dependencies of target kconfigguitest [ 54%] [ 54%] Building CXX object tier1/kconfig/autotests/CMakeFiles/kconfigguitest.dir/kconfigguitest.cpp.o Building CXX object tier1/sonnet/tests/CMakeFiles/test_textedit.dir/test_textedit_automoc.cpp.o Linking CXX executable test_textedit [ 54%] [ 54%] Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/slaveconfig.cpp.o Building CXX object tier1/kconfig/autotests/CMakeFiles/kconfigguitest.dir/kconfigguitest_automoc.cpp.o [ 54%] Built target backgroundtest [ 54%] [ 54%] Built target krossqtsplugin Linking CXX executable kconfigguitest Building CXX object tier3/kio/src/core/CMakeFiles/KIOCore.dir/kprotocolmanager.cpp.o http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kio/src/core/kprotocolmanager.cpp:677:5: warning:
Build failed in Jenkins: plasma-framework_master_qt5 #916
See http://build.kde.org/job/plasma-framework_master_qt5/916/changes Changes: [mklapetek] Revert capitalizing the month's name -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7285436395903804238.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 655769c..580d7d1 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 655769c Fixed the assertion Removing build/ Removing install/ Success build forhudson.tasks.Shell@824cabd Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 580d7d198ad5030641c3f4014c42a7e0555ac617 (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson4614469018808491552.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: strigidaemon - Branch master qt5 - Branch stable libstreamanalyzer - Branch master extra-cmake-modules - Branch master libstreams - Branch master kactivities - Branch frameworks strigiclient - Branch master kdelibs - Branch frameworks attica - Branch master strigiutils - Branch master phonon - Branch master polkit-qt-1 - Branch qt5 == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Error at /srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KF5/KF5Config.cmake:26 (find_package): Could not find a package configuration file provided by KActivities with any of the following names: KActivitiesConfig.cmake kactivities-config.cmake Add the installation prefix of KActivities to CMAKE_PREFIX_PATH or set KActivities_DIR to a directory containing one of the above files. If KActivities provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:45 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/plasma-framework_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1757
See http://build.kde.org/job/kdelibs_frameworks_qt5/1757/changes
Changes:
[aleixpol] Rename includes following publication of KIconEngine
--
[...truncated 7489 lines...]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/rendering/render_form.cpp:2431:2:
warning: #warning Physical wrap mode needs testing (also in ::selection*)
[-Wcpp]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/rendering/render_form.cpp:
In member function ‘virtual void khtml::RenderLineEdit::updateFromElement()’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/rendering/render_form.cpp:1258:116:
warning: ‘void KLineEdit::setClickMessage(const QString)’ is deprecated
(declared at
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier2/kcompletion/src/klineedit.h:351)
[-Wdeprecated-declarations]
[ 86%]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/misc/AtomicString.cpp:
In static member function ‘static DOM::DOMStringImpl*
khtml::AtomicString::add(const QChar*, int)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/misc/AtomicString.cpp:163:35:
warning: narrowing conversion of ‘length’ from ‘int’ to ‘unsigned int’ inside
{ } [-Wnarrowing]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/misc/AtomicString.cpp:
In static member function ‘static DOM::DOMStringImpl*
khtml::AtomicString::add(const QChar*)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/misc/AtomicString.cpp:183:33:
warning: narrowing conversion of ‘length’ from ‘int’ to ‘unsigned int’ inside
{ } [-Wnarrowing]
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/misc/guess_ja.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/misc/kencodingdetector.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/editing/jsediting.cpp.o
Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/editing/editing.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/editing/editor.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/editing/htmlediting_impl.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_binding.cpp.o
[ 86%] [ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_dom.cpp.o
Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_html.cpp.o
[ 86%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_window.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_navigator.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_proxy.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_css.cpp.o
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/editing/htmlediting_impl.cpp:153:17:
warning: ‘DOM::Position khtml::leadingWhitespacePosition(const
DOM::Position)’ defined but not used [-Wunused-function]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/editing/htmlediting_impl.cpp:168:17:
warning: ‘DOM::Position khtml::trailingWhitespacePosition(const
DOM::Position)’ defined but not used [-Wunused-function]
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_range.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_traversal.cpp.o
In file included from
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/css/parser.cpp:133:0:
cssproperties.gperf:167:62: warning: ‘__gnu_inline__’ attribute ignored
[-Wattributes]
In file included from
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/css/parser.cpp:134:0:
cssvalues.gperf:152:63: warning: ‘__gnu_inline__’ attribute ignored
[-Wattributes]
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_events.cpp.o
[ 87%] In file included from
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier4/khtml/src/ecma/kjs_traversal.cpp:22:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier4/khtml/src/kjs_traversal.lut.h:54:1:
warning: narrowing conversion of ‘(DOM::NodeFilter::ShowCode)4294967295u’ from
‘unsigned int’ to ‘int’ inside { } [-Wnarrowing]
Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_views.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_mozilla.cpp.o
[ 87%] [ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/JSTimeRanges.cpp.o
Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/JSMediaError.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/ecma/JSHTMLElement.cpp.o
[ 87%] Building CXX object
tier4/khtml/src/CMakeFiles/KHtml.dir/JSHTMLMediaElement.cpp.o
[ 87%]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier4/khtml/src/JSTimeRanges.cpp:97:10:
warning: unused parameter ‘exec’ [-Wunused-parameter]
[ 87%] Building CXX object
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review44397 --- Any chance for a review? We really need to tie up loose ends now. - Kevin Ottens On Nov. 18, 2013, 6:04 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 18, 2013, 6:04 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:965 #18 0x77ba3d1c in KStartupInfo::qt_static_metacall (_o=0x7fffdc60, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffbf70) at /opt/build/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/moc_kstartupinfo.cpp:106 #19 0x75ef8c9f in QMetaObject::activate (sender=0x684d50, signalOffset=3, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3530 #20 0x75ef84f0 in QMetaObject::activate (sender=0x684d50, m=0x763ab980 QTimer::staticMetaObject, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3405 #21 0x75f88fc3 in QTimer::timeout (this=0x684d50) at .moc/moc_qtimer.cpp:189 #22 0x75f03bc5 in QTimer::timerEvent (this=0x684d50, e=0x7fffca30) at kernel/qtimer.cpp:255 #23 0x75ef2314 in QObject::event (this=0x684d50, e=0x7fffca30) at kernel/qobject.cpp:1101 #24 0x7710e24e in QApplicationPrivate::notify_helper (this=0x60f010,
Re: Review Request 112880: Added KColorSchemeToken class.
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many pre-exams in university. Any news? we need to get in or discard all the old patches now. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Oct. 6, 2013, 7:24 p.m.) Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * Diffs - kdeui/CMakeLists.txt b439e04 includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113503: make dbus dependency optional in JobWidgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ --- (Updated Nov. 25, 2013, 1:56 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs and Stephen Kelly. Repository: kdelibs Description --- Make dbus dependency optional in JobWidgets Many don't have dbus available on all platforms, especially windows, but JobWidgets is very much useful without it. Diffs - tier2/kjobwidgets/CMakeLists.txt ca53024 tier2/kjobwidgets/src/CMakeLists.txt 0a575a6 tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 Diff: http://git.reviewboard.kde.org/r/113503/diff/ Testing --- build tested on windows without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114004: Install kio/connection_p.h
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114004/ --- (Updated Nov. 25, 2013, 1:57 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- kinit/src/klauncher/klauncher.h needs connection_p.h, so install it. Diffs - tier3/kinit/src/klauncher/klauncher.h aa4527a tier3/kio/src/core/CMakeLists.txt 1944435 Diff: http://git.reviewboard.kde.org/r/114004/diff/ Testing --- kdelibs still builds. kinit builds standalone with this patch + other changes (going to be posted separately). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/#review44401 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 5:52 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/ --- (Updated Nov. 22, 2013, 5:52 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Split kfileaudiopreview out from kmediaplayer Diffs - staging/kfileaudiopreview/CMakeLists.txt PRE-CREATION staging/CMakeLists.txt 3ca6fbbb119c904ae2ef4682b424d7d68c1fddde staging/kfileaudiopreview/README PRE-CREATION staging/kmediaplayer/CMakeLists.txt 71d1471eda5c870a50c383cebbea7e6bae057bce staging/kmediaplayer/autotests/CMakeLists.txt b35dd2afe9d6dfc24fe354849a894968c930133e staging/kmediaplayer/src/CMakeLists.txt 307aa0f6994b948c1ca2455d33be6a7075f669df staging/kmediaplayer/src/kfileaudiopreview/CMakeLists.txt staging/kmediaplayer/src/kfileaudiopreview/Messages.sh staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.h staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp staging/kmediaplayer/src/kfileaudiopreview/mediacontrols.h staging/kmediaplayer/src/kfileaudiopreview/mediacontrols.cpp staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h Diff: http://git.reviewboard.kde.org/r/114037/diff/ Testing --- CMake runs, builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114044: Remove unused dependencies in kcoreaddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114044/#review44402 --- This review has been submitted with commit 6a2020aa8c80c05d83faf7509aa09ec3e4cfe6df by Michael Palimaka to branch frameworks. - Commit Hook On Nov. 22, 2013, 6:53 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114044/ --- (Updated Nov. 22, 2013, 6:53 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- I cannot find any source reference to QtConcurrent and QtNetwork, so remove it. Diffs - tier1/kcoreaddons/CMakeLists.txt d797f173cbc78cf7e01ee60c35e3e7a53af69621 tier1/kcoreaddons/autotests/CMakeLists.txt 19ea80a909b2af7cea0177b3a3c6c21d342ee2d0 tier1/kcoreaddons/tests/CMakeLists.txt 1df24743921206e7b0a3690c3047d0fc3fcec651 Diff: http://git.reviewboard.kde.org/r/114044/diff/ Testing --- Builds with QtConcurrent and QtNetwork packages not present. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114050: Add manual test app for enableBlurBehind.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/#review44403 --- tier1/kwindowsystem/tests/blurbehindtest.cpp http://git.reviewboard.kde.org/r/114050/#comment31754 Space before * and not after please (applies to the whole file). - Kevin Ottens On Nov. 23, 2013, 12:15 a.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/ --- (Updated Nov. 23, 2013, 12:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Added a simple app to test enableBlurBehind. It shows a semi-transparent window, with buttons to enable or disable the blur. It can enable blur for the whole window, or for a region below the buttons (rectangle or circle). If blurring a region, currently it won't update the region when the window is resized. Maybe it should :) Diffs - tier1/kwindowsystem/tests/CMakeLists.txt fbf3d26a14e6697cb4039bdb89743cbe23c4a290 tier1/kwindowsystem/tests/blurbehindtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114050/diff/ Testing --- File Attachments Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/11/23/1ef7d9bb-84e4-422c-9782-a63f02021639__blur-behind-test.png Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114090: [tier2/ki18n] Improve dependency specification
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/#review44404 --- Ship it! Ship It! - Kevin Ottens On Nov. 24, 2013, 10:17 p.m., Johannes Huber wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/ --- (Updated Nov. 24, 2013, 10:17 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Qt test and concurrent is only used in sub directory, so move it there. Diffs - tier2/ki18n/CMakeLists.txt cd876ef tier2/ki18n/autotests/CMakeLists.txt ea22bda Diff: http://git.reviewboard.kde.org/r/114090/diff/ Testing --- Builds with and without autotests subdirectory. Thanks, Johannes Huber ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113910: Add basic KArchive examples
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44406 --- tier1/karchive/examples/tarlocalfiles/main.cpp http://git.reviewboard.kde.org/r/113910/#comment31755 Put the } and the else if on the same line please. Sorry I didn't spot it the previous time... - Kevin Ottens On Nov. 25, 2013, 12:35 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 12:35 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on: License? Currently BSD. Code comments. More, less? Readability? Other examples I'm working on: helloworld with qmake something with KCompressionDevice perhaps a minimal ark like example Diffs - tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/helloworld/main.cpp PRE-CREATION tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113910: Add basic KArchive examples
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 2:46 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on: License? Currently BSD. Code comments. More, less? Readability? Other examples I'm working on: helloworld with qmake something with KCompressionDevice perhaps a minimal ark like example Diffs (updated) - tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION tier1/karchive/examples/helloworld/main.cpp PRE-CREATION tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114111: Fix KIconThemes standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- summary ^ it complains about KGuiAddons in cmake. it fixes this.. Diffs - tier3/kiconthemes/CMakeLists.txt d1191d1 Diff: http://git.reviewboard.kde.org/r/114111/diff/ Testing --- compiles, links, installs. Thanks, Bhushan Shah ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114111: Fix KIconThemes standalone build
On Nov. 25, 2013, 3:49 p.m., Maarten De Meyer wrote: Are you sure this is needed? KConfigWidgets already includes KGuiAddons and KIconThemes doesn't link with KGuiAddons directly. You say it complains so you are still able to build? Next version of CMake should fix this. Bhushan Shah wrote: No I am not able to run cmake, it fails.. Alex Merry wrote: Yeah, this is apparently a known bug with current versions of CMake (pre-3.0.0). But we have to support 2.8.12, so we need to include the private dependencies of the things we link to. Bhushan Shah wrote: @Alex Merry so ship it? Although... KGuiAddons is a *public* dependency of KConfigWidgets, so the KConfigWidgetsConfig.cmake file should include KGuiAddons. So I'm surprised this is needed. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/#review44430 --- On Nov. 25, 2013, 3:32 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/ --- (Updated Nov. 25, 2013, 3:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- summary ^ it complains about KGuiAddons in cmake. it fixes this.. Diffs - tier3/kiconthemes/CMakeLists.txt d1191d1 Diff: http://git.reviewboard.kde.org/r/114111/diff/ Testing --- compiles, links, installs. Thanks, Bhushan Shah ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114111: Fix KIconThemes standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/ --- (Updated Nov. 25, 2013, 9:50 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- summary ^ it complains about KGuiAddons in cmake. it fixes this.. Diffs - tier3/kiconthemes/CMakeLists.txt d1191d1 Diff: http://git.reviewboard.kde.org/r/114111/diff/ Testing --- compiles, links, installs. Thanks, Bhushan Shah ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114038: Integrate KAboutData and QCommandLineParser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- (Updated Nov. 25, 2013, 4:26 p.m.) Review request for KDE Frameworks. Changes --- adopted david's suggestions Repository: kdelibs Description --- There was a functionality regression from KDE4 where every application would get an --authors and a --license argument automatically. This patch makes it possible to let KAboutData configure QCommandLineParser to add the missing arguments and react if those are required. Diffs (updated) - tier1/kcoreaddons/src/lib/kaboutdata.h b56832c tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad Diff: http://git.reviewboard.kde.org/r/114038/diff/ Testing --- Made kbuildsycoca5 use it and made sure it works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114038: Integrate KAboutData and QCommandLineParser
On Nov. 24, 2013, 10:58 a.m., David Faure wrote: tier1/kcoreaddons/src/lib/kaboutdata.cpp, line 957 http://git.reviewboard.kde.org/r/114038/diff/1/?file=219248#file219248line957 (LOL, most likely someone forgot to call addAuthor, but OK :) Wrong usage of tr() (this will use QCoreApplication as context). Use tr() (might need Q_DECLARE_TR_FUNCTIONS in the header, since this isn't a QObject), or use translate() with a context, like in the example program in this patch. I used the same we used to have in KCmdLineArgs. I agree it looks a bit aggressive though :). As if there was any kind of anonymity going on... I'll fix the ::tr usage. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/#review44296 --- On Nov. 22, 2013, 6:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- (Updated Nov. 22, 2013, 6:07 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- There was a functionality regression from KDE4 where every application would get an --authors and a --license argument automatically. This patch makes it possible to let KAboutData configure QCommandLineParser to add the missing arguments and react if those are required. Diffs - tier1/kcoreaddons/src/lib/kaboutdata.h f9dee8e tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad Diff: http://git.reviewboard.kde.org/r/114038/diff/ Testing --- Made kbuildsycoca5 use it and made sure it works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114090: [tier2/ki18n] Improve dependency specification
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/#review3 --- This review has been submitted with commit 77f3ded7cad2f78de89cb0713d9527ef8228da56 by Johannes Huber to branch frameworks. - Commit Hook On Nov. 24, 2013, 10:17 p.m., Johannes Huber wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/ --- (Updated Nov. 24, 2013, 10:17 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Qt test and concurrent is only used in sub directory, so move it there. Diffs - tier2/ki18n/CMakeLists.txt cd876ef tier2/ki18n/autotests/CMakeLists.txt ea22bda Diff: http://git.reviewboard.kde.org/r/114090/diff/ Testing --- Builds with and without autotests subdirectory. Thanks, Johannes Huber ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
On Nov. 25, 2013, 1:48 p.m., Kevin Ottens wrote: Any chance for a review? We really need to tie up loose ends now. I think that this is a very nice piece of work, and the new data-driven test also looks good to me. The only thing I'm concerned about is the run time of the test - I like unit testing very much, but tests with a very long run time might make people avoid make test, and thus bear the risk that we see more regressions in the future. Maybe this review request is not the best place to discuss this issue though, in particular if it should go in soon in order to not delay the splitting (and also to fix the crash, of course). Maybe one could discuss requirements for unit tests at some later point. (One possible solution would be to make this a manual test. Yes, it would mean that people will run this test less often, but if it prevents that people stop running make test altogether, maybe it's still worth considering). I don't really feel qualified to approve changes in kwindowsystem though ;-) - Frank --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review44397 --- On Nov. 18, 2013, 6:04 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 18, 2013, 6:04 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review6 --- AFAIK the rule for Qt unittests is that they should run in under 5 seconds. They don't all manage that, nor do we, but it gives an indication. 30 seconds or more is definitely too much. For the silent case the timeout - is for what reason ever - multiplied by 20. is this something that comes from our own code, from Qt, or from X itself? Depending on the answer, we could imagine some hidden symbol or env var in order to tune that behavior from unittests. - David Faure On Nov. 18, 2013, 6:04 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 18, 2013, 6:04 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:965 #18 0x77ba3d1c in KStartupInfo::qt_static_metacall (_o=0x7fffdc60, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffbf70) at /opt/build/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/moc_kstartupinfo.cpp:106 #19 0x75ef8c9f in QMetaObject::activate (sender=0x684d50, signalOffset=3, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3530 #20 0x75ef84f0 in QMetaObject::activate (sender=0x684d50, m=0x763ab980 QTimer::staticMetaObject, local_signal_index=0, argv=0x0) at
Jenkins build is back to stable : kdelibs_frameworks_qt5 #1767
See http://build.kde.org/job/kdelibs_frameworks_qt5/1767/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114038: Integrate KAboutData and QCommandLineParser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/#review44452 --- Ship it! Ship It! - David Faure On Nov. 25, 2013, 4:26 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- (Updated Nov. 25, 2013, 4:26 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- There was a functionality regression from KDE4 where every application would get an --authors and a --license argument automatically. This patch makes it possible to let KAboutData configure QCommandLineParser to add the missing arguments and react if those are required. Diffs - tier1/kcoreaddons/src/lib/kaboutdata.h b56832c tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad Diff: http://git.reviewboard.kde.org/r/114038/diff/ Testing --- Made kbuildsycoca5 use it and made sure it works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review44453 --- Ship it! I understood that it is important not to have to add KLocalizedString includes where they weren't needed so far. I won't have the time in the next few days to make a tighter implementation along the lines I suggested, and there is actually no harm committing this one. - Chusslove Illich On Sept. 17, 2013, 9:56 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/ --- (Updated Sept. 17, 2013, 9:56 p.m.) Review request for KDE Frameworks and Alexander Neundorf. Repository: kdelibs Description --- It builds and installs, but doesn't seem to be usable from within kdelibs, i.e. ki18n_wrap_ui in knewstuff/src/CMakeLists.txt fails with this. I suspect one more thing is needed to make it work from within kdelibs builds. Diffs - tier2/ki18n/CMakeLists.txt d0ed448 tier2/ki18n/KI18nConfig.cmake.in 18b6e2f tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112785/diff/ Testing --- Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review requests
Review board doesn't appear to be sending emails for my review requests, so -- since some of them are a dependency of Kevin's repo splitting -- here they are: Fix KIO superbuild dependencies https://git.reviewboard.kde.org/r/114127/ Move kmediaplayer to tier3 https://git.reviewboard.kde.org/r/114128/ Move kfileaudiopreview to tier4 https://git.reviewboard.kde.org/r/114129/ Alex PS: I've logged a ticket with sysadmin, so hopefully the email thing will get fixed. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
imageformat plugins
It occurred to me that KGuiAddons might not be the best place for the imageformat plugins, and that they should maybe become their own framework (either tier1 or tier4). The only thing that relates the KGuiAddons library and the imageformat plugins is that they are both to do with QtGui. Each can be used without the other just fine, and there is no particular reason why someone wanting the library should want to install the plugins or vice versa. What do other people think about this? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1768
See http://build.kde.org/job/kdelibs_frameworks_qt5/1768/changes Changes: [aleixpol] Integrate KAboutData and QCommandLineParser [aleixpol] Port makekdewidgets to KAboutData -- [...truncated 3959 lines...] [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/sycoca/kmemfile.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/plugin/klibrary.cpp.o http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/services/kplugininfo.cpp: In static member function ‘static QListKPluginInfo KPluginInfo::fromServices(const List, const KConfigGroup)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/services/kplugininfo.cpp:234:29: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/services/kplugininfo.cpp:137) [-Wdeprecated-declarations] Scanning dependencies of target kbuildsycoca5-manpage-man-kbuildsycoca5 [ 32%] Generating kbuildsycoca5.8 Scanning dependencies of target makekdewidgets [ 32%] Building CXX object tier3/kdewidgets/src/CMakeFiles/makekdewidgets.dir/makekdewidgets.cpp.o [ 32%] Building CXX object tier3/kdewidgets/src/CMakeFiles/makekdewidgets.dir/makekdewidgets_automoc.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/plugin/kpluginfactory.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/video.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagevolume.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storageaccess.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/video.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/smartcardreader.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o [ 32%] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kdewidgets/src/makekdewidgets.cpp:7:30: fatal error: klocalizedstring.h: No such file or directory compilation terminated. make[2]: Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/smartcardreader.cpp.o *** [tier3/kdewidgets/src/CMakeFiles/makekdewidgets.dir/makekdewidgets.cpp.o] Error 1 make[1]: *** [tier3/kdewidgets/src/CMakeFiles/makekdewidgets.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeacadapter.cpp.o [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/internetgateway.cpp.o http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/plugin/kpluginfactory.cpp: In member function ‘virtual QObject* KPluginFactory::create(const char*, QWidget*, QObject*, const QVariantList, const QString)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/plugin/kpluginfactory.cpp:138:114: warning: ‘virtual KParts::Part* KPluginFactory::createPartObject(QWidget*, QObject*, const char*, const QStringList)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/plugin/kpluginfactory.cpp:112) [-Wdeprecated-declarations] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/plugin/kpluginfactory.cpp:143:62: warning: ‘virtual QObject* KPluginFactory::createObject(QObject*, const char*, const QStringList)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier3/kservice/src/plugin/kpluginfactory.cpp:102) [-Wdeprecated-declarations] [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/plugin/kpluginloader.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/plugin/kplugintrader.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/plugin/kdbusservicestarter.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/kdeinit/ktoolinvocation_x11.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/klauncher_iface.cpp.o [ 32%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/KService_automoc.cpp.o Warn: AUTHOR sect.: no personblurb|contrib for Darian Lanx kbuildsycoca5 Note: AUTHOR sect.: see see http://docbook.sf.net/el/contrib kbuildsycoca5 Note: AUTHOR sect.: see see http://docbook.sf.net/el/personblurb kbuildsycoca5 [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakeacadapter.cpp.o Note: Writing kbuildsycoca5.8 [ 32%] [ 32%] Built target kbuildsycoca5-manpage-man-kbuildsycoca5 [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeaudiointerface.cpp.o Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakebattery.cpp.o [ 32%] Building CXX object
Build failed in Jenkins: kdelibs_frameworks_qt5 #1769
See http://build.kde.org/job/kdelibs_frameworks_qt5/1769/changes Changes: [aleixpol] makekdewidgets doesn't depend on i18n -- [...truncated 5096 lines...] Linking CXX shared library libKCrash.so [ 47%] Building CXX object tier2/kjobwidgets/src/CMakeFiles/KJobWidgets.dir/jobviewifacev2.cpp.o Linking CXX static library libkauth_tests_static.a [ 47%] Built target KCrash [ 47%] Building CXX object tier2/kjobwidgets/src/CMakeFiles/KJobWidgets.dir/KJobWidgets_automoc.cpp.o [ 47%] Built target kauth_tests_static [ 47%] Building CXX object tier2/kcompletion/src/CMakeFiles/KCompletion.dir/kpixmapprovider.cpp.o Scanning dependencies of target ktranscripttest [ 47%] Building CXX object tier2/ki18n/autotests/CMakeFiles/ktranscripttest.dir/ktranscripttest.cpp.o [ 47%] Building CXX object tier2/ki18n/autotests/CMakeFiles/ktranscripttest.dir/ktranscripttest_automoc.cpp.o [ 47%] Building CXX object tier2/ki18n/autotests/CMakeFiles/klocalizedstringtest.dir/klocalizedstringtest_automoc.cpp.o Scanning dependencies of target checkXML-manpage-man-checkXML Scanning dependencies of target meinproc5-manpage-man-meinproc5 [ 47%] [ 47%] Generating checkXML.1 Generating meinproc5.8 Linking CXX executable klocalizedstringtest [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/operations.cpp.o [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/regexp.cpp.o [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/function_object.cpp.o [ 47%] Built target klocalizedstringtest Scanning dependencies of target kdeoptions-manpage-man-kdeoptions Linking CXX shared library libKJobWidgets.so [ 47%] [ 47%] Building CXX object tier2/kcompletion/src/CMakeFiles/KCompletion.dir/kzoneallocator.cpp.o Generating kdeoptions.7 Linking CXX executable ktranscripttest Scanning dependencies of target qtoptions-manpage-man-qtoptions [ 47%] Generating qtoptions.7 [ 47%] Building CXX object tier2/kcompletion/src/CMakeFiles/KCompletion.dir/KCompletion_automoc.cpp.o [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/string_object.cpp.o Scanning dependencies of target kwallettest [ 47%] Building CXX object tier2/kwallet/tests/CMakeFiles/kwallettest.dir/kwallettest.cpp.o [ 47%] Built target ktranscripttest [ 47%] Building CXX object tier2/kwallet/tests/CMakeFiles/kwallettest.dir/kwallettest_automoc.cpp.o Warn: meta author : no refentry/info/author meinproc5Note: meta source : no *info/productname or alternative checkXML Note: meta source : see http://docbook.sf.net/el/productname checkXMLNote: meta author : see http://docbook.sf.net/el/author meinproc5 Note: meta source : no refentry/refmeta/refmiscinfo@class=source checkXML Warn: meta author : no author data, so inserted a fixmemeinproc5 Note: meta source : see http://docbook.sf.net/el/refmiscinfo checkXML Note: meta version: no *info/productnumber or alternative checkXML Note: meta version: see http://docbook.sf.net/el/productnumber checkXML Note: meta version: no refentry/refmeta/refmiscinfo@class=version checkXML Note: meta version: see http://docbook.sf.net/el/refmiscinfo checkXML Warn: meta source : no fallback for source, so inserted a fixmecheckXML [ 47%] Warn: AUTHOR sect.: no personblurb|contrib for Lauri Watts checkXML Note: AUTHOR sect.: see see http://docbook.sf.net/el/contrib checkXML Note: AUTHOR sect.: see see http://docbook.sf.net/el/personblurb checkXML Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/bool_object.cpp.o Note: Writing checkXML.1 Note: Writing meinproc5.8 In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kcompletion/src/KCompletion_automoc.cpp:2:0: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kcompletion/src/moc_kcombobox.cpp: In member function ‘virtual int KComboBox::qt_metacall(QMetaObject::Call, int, void**)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kcompletion/src/moc_kcombobox.cpp:254:65: warning: ‘void KComboBox::setUrlDropsEnabled(bool)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/tier2/kcompletion/src/../../../../tier2/kcompletion/src/kcombobox.h:309) [-Wdeprecated-declarations] [ 47%] Built target checkXML-manpage-man-checkXML [ 47%] Linking CXX shared library libKCompletion.so [ 47%] Built target KJobWidgets [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/number_object.cpp.o [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/internal.cpp.o Built target meinproc5-manpage-man-meinproc5 [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/ExecState.cpp.o [ 47%] Building CXX object tier1/kjs/src/kjs/CMakeFiles/KJS.dir/Parser.cpp.o Linking CXX executable kwallettest Warn: AUTHOR sect.: no personblurb|contrib for Lauri Watts kdeoptions Note: AUTHOR sect.: see see
Jenkins build is back to normal : kdelibs_frameworks_qt5 #1770
See http://build.kde.org/job/kdelibs_frameworks_qt5/1770/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
