Re: Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115617: Don't perform XLib calls if we are not on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Don't perform XLib calls if we are not on X11 Check whether we are on platform xcb and only perform XLib calls if we are on this platform. This makes KApplication based apps to start on Wayland. Diffs - src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 Diff: https://git.reviewboard.kde.org/r/115617/diff/ Testing --- Konsole starts on Wayland. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Reviewboard is weird. I added that comment, but the mail sent by reviewboard doesn't show that anywhere. It makes it look like Martin made that change. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ---BeginMessage--- --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ---End Message--- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Mon, Feb 10, 2014 at 10:21 PM, David Faure fa...@kde.org wrote: On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Reviewboard is weird. I added that comment, but the mail sent by reviewboard doesn't show that anywhere. It makes it look like Martin made that change. Looks like Reviewboard doesn't track the person who makes changes to the metadata - so it assumes the author of the Review Request made it. Normally, this would be a valid assumption as only they have the permission to do so, unless someone has admin access (which you do). Guess you might want to file an issue with upstream. Thanks, Ben -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 -- Forwarded message -- From: Martin Gräßlin mgraess...@kde.org To: Dawit Alemayehu ada...@kde.org, Bernhard Beschow bbesc...@cs.tu-berlin.de Cc: KDE Frameworks kde-frameworks-devel@kde.org Date: Mon, 10 Feb 2014 09:15:23 + Subject: Re: Review Request 115613: Drop platform name from default user agent string This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. By Martin Gräßlin. *Updated Feb. 10, 2014, 9:15 a.m.* Changes Adding more people for review. IMHO Dawit has final say on what the UA string should look like. *Repository: * kio Description Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp (f81b6797887eebd868c36b98e867eb055b05a1e2) View Diff https://git.reviewboard.kde.org/r/115613/diff/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115606: Ommit ontologies/ dir from installing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49423 --- As far as I'm concerned it can be nuked. But let's wait for Ivan. - Vishesh Handa On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- (Updated Feb. 9, 2014, 7:58 p.m.) Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- So kf5 kactivities can be co-installed with kactivities4. First approach is just to comment out the dir. I don't know what are the plans, so potentially i can git rm the dir, considering the emerge of baloo with 4.13 Diffs - src/CMakeLists.txt 8a00cf8 Diff: https://git.reviewboard.kde.org/r/115606/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115619: Add -platform to the args and remove X specific args on non X
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115619/ --- Review request for KDE Frameworks. Repository: kcrash Description --- Add -platform to the args and remove X specific args on non X This makes sure that the crash handler for apps started on Wayland are not opened on X. Diffs - src/kcrash.cpp c3a234ad1772940801fa010ce3cf846bf2030ba5 Diff: https://git.reviewboard.kde.org/r/115619/diff/ Testing --- crashing an application on Wayland doesn't open DrKonqi on X anymore (but DrKonqi crashes :-( ) Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115606: Ommit ontologies/ dir from installing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49428 --- Ship it! Commenting out is ok, but remove CMakeLists.txt from the ontologies dir as well. The ontologies can remain to provide documentation for the relations we create later for baloo. - Ivan Čukić On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- (Updated Feb. 9, 2014, 7:58 p.m.) Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- So kf5 kactivities can be co-installed with kactivities4. First approach is just to comment out the dir. I don't know what are the plans, so potentially i can git rm the dir, considering the emerge of baloo with 4.13 Diffs - src/CMakeLists.txt 8a00cf8 Diff: https://git.reviewboard.kde.org/r/115606/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115620: Fix build when CMAKE_SOURCE_DIR contains spaces in its path
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115620/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- = subject Diffs - CMakeLists.txt b2e9876bb05eef29b6451d00905b331da8e7e5aa Diff: https://git.reviewboard.kde.org/r/115620/diff/ Testing --- It builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49429 --- I'd rather have it names plasmapkg2, the 5 prefix sounds weird in the Plasma context. (Most of the other visible Plasma bits carry version 2.0). - Sebastian Kügler On Feb. 9, 2014, 7:45 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 9, 2014, 7:45 p.m.) Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kde5 in path
Hello,
i ecm there is references to kde5
./kde-modules/KDEInstallDirs.cmake: _set_fancy(LIBEXEC_INSTALL_DIR
${LIB_INSTALL_DIR}/kde5/libexec The install dir for libexec
executables (default is ${LIB_INSTALL_DIR}/kde5/libexec))
./kde-modules/KDEInstallDirs.cmake:_set_fancy(SERVICES_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/kde5/services The install dir for service
(desktop, protocol, ...) files)
./kde-modules/KDEInstallDirs.cmake:_set_fancy(SERVICETYPES_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/kde5/servicetypes The install dir for
servicestypes desktop files)
./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/applications/kde5 The XDG apps dir)
shouldn't it be kf5 ? instead ?
Regards
Nicolas Lécureuil
Mageia KDE Team
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kde5 in path
On 09/02/14 23:55, Nicolas Lécureuil wrote:
./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR
${SHARE_INSTALL_PREFIX}/applications/kde5 The XDG apps dir)
Personally, I'm still of the view that XDG_APPS_INSTALL_DIR should just
be ${SHARE_INSTALL_PREFIX}/applications; did we ever reach a conclusion
on that?
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 11:39 a.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Fixed indentation. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs (updated) - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115606: Ommit ontologies/ dir from installing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- (Updated Feb. 10, 2014, 11:43 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- So kf5 kactivities can be co-installed with kactivities4. First approach is just to comment out the dir. I don't know what are the plans, so potentially i can git rm the dir, considering the emerge of baloo with 4.13 Diffs - src/CMakeLists.txt 8a00cf8 Diff: https://git.reviewboard.kde.org/r/115606/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115606: Ommit ontologies/ dir from installing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49432 --- This review has been submitted with commit a70ef082e63bdfc032096afa079e692710f9f358 by Hrvoje Senjan to branch frameworks. - Commit Hook On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- (Updated Feb. 9, 2014, 7:58 p.m.) Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- So kf5 kactivities can be co-installed with kactivities4. First approach is just to comment out the dir. I don't know what are the plans, so potentially i can git rm the dir, considering the emerge of baloo with 4.13 Diffs - src/CMakeLists.txt 8a00cf8 Diff: https://git.reviewboard.kde.org/r/115606/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:45 a.m.) Review request for KDE Frameworks, Plasma and Sebastian Kügler. Changes --- Renamed to plasmapkg2 Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs (updated) - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49433 --- Ship it! Ship It! - Sebastian Kügler On Feb. 10, 2014, 11:45 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:45 a.m.) Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49435 --- This review has been submitted with commit cc34d2c17ef44f4aabb10986d27b5a4dc088baf2 by Hrvoje Senjan to branch master. - Commit Hook On Feb. 10, 2014, 11:45 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:45 a.m.) Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:53 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115605: Rename plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49438 --- Ehh, the 2 doesn't make sense anymore since the plasma library is now following the kde frameworks version numbering. Right now it's version is 4.96.0 and is going to be 5.0 once all of frameworks is released in it's final state. For reference: http://quickgit.kde.org/?p=plasma-framework.gita=blobdiffh=f873539cd0814e3d512ae37278feb57738f5fdc9hp=8fb14bba0ca3983cb3503ea780c66b932816a1a1hb=f9e5cc949ff3719ec553955fba09f4efbc189c07f=CMakeLists.txt - Mark Gaiser On Feb. 10, 2014, 11:53 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:53 a.m.) Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115616: Add platform to qt options in KCmdLineArgs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/#review49439 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 10, 2014, 9:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/ --- (Updated Feb. 10, 2014, 9:14 a.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Add platform to qt options in KCmdLineArgs It's needed to start KApplications on Wayland. Diffs - src/kdecore/kcmdlineargs.cpp 2b5ed04c03a6a66cf776dfc09d8c0ca49ac432ae Diff: https://git.reviewboard.kde.org/r/115616/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115541: Build fix for Mac OS X
On Feb. 8, 2014, 10:07 a.m., David Faure wrote:
Urgh, we were hoping this wouldn't be an issue.
This commit would break #include attica/event.h, so it cannot go in.
All namespaced frameworks do it this way already btw, see kparts for
instance:
-- Up-to-date:
/d/kde/inst/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart
-- Up-to-date:
/d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h
Since there is no filename clash, what is the issue if these end up in the
same folder on Mac OSX?
Harald Fernengel wrote:
Here's the layout after make install on OS X:
include/KF5/KParts/textextension.h contains:
#include /tmp/kf5-kparts-ty2Y/src/textextension.h
^^^ this is broken, points to the temporary build dir...? What should
this include?
Then, we have include/KF5/KParts/KParts/ which contains both lower case
and upper case headers.
include/KF5/KParts/KParts/textextension.h is the actual header
include/KF5/KParts/KParts/TextExtension contains:
#include kparts/textextension.h
David Faure wrote:
Ah, I see. The local forwarding includes which are supposed to only be
used during compilation of kparts, get installed because they end up in
KParts/ instead of kparts/ (and the cmakelists.txt file just installs the
whole directory).
I can think of two solutions...
1) put local forwarders into ./local/kparts instead of ./kparts, to
ensure they stay out of ./KParts
2) change cmakelists.txt to install a list of camelcase headers instead
of just the whole directory (which gives surprises with an unclean
builddir, installing old stuff still lying around)
The first one seems simpler.
In kparts/src:
- target_include_directories(KF5Parts PUBLIC
$BUILD_INTERFACE:${KParts_BINARY_DIR})
+ target_include_directories(KF5Parts PUBLIC
$BUILD_INTERFACE:${KParts_BINARY_DIR}/local)
And in CEM:
diff --git a/modules/ECMGenerateHeaders.cmake
b/modules/ECMGenerateHeaders.cmake
index e98a22e..38839f2 100644
--- a/modules/ECMGenerateHeaders.cmake
+++ b/modules/ECMGenerateHeaders.cmake
@@ -50,7 +50,7 @@ function(ECM_GENERATE_HEADERS)
endif()
if(NOT EGH_OUTPUT_DIR)
-set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR})
+set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/local)
endif()
# Make sure EGH_RELATIVE is /-terminated when it's not empty
Can you try it?
Ok, let's use Attica again as example as with the ECMGenerateHeaders.cmake
change, the dependencies for KParts don't compile any more :)
So, I applied the CEM patch, then in Attica, I now have e.g.
src/local/Attica/topic.h that contains: #include
/tmp/kf5-attica-yJxM/src/topic.h
Installing that dir:
-install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Attica DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel)
+install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/local/Attica DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel)
gives me the same brokenness?
How would the install rule look like for Attica?
- Harald
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/#review49240
---
On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/
---
(Updated Feb. 7, 2014, 7:37 p.m.)
Review request for KDE Frameworks.
Repository: attica
Description
---
Case-insensitive filesystems don't like the Attica vs. attica pathes, when
installing, the headers would all be messed up. Instead, install everything
to include/KF5/Attica to be in line with the other frameworks.
Note - this might not be the best solution, but we need one in order to
deploy on Mac OS X :)
Diffs
-
src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d
Diff: https://git.reviewboard.kde.org/r/115541/diff/
Testing
---
Only on Mac OS X
Thanks,
Harald Fernengel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: let's get ready for Google Summer of Code 2014
Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for_KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. On Mon, Feb 10, 2014 at 2:47 AM, Mark Gaiser mark...@gmail.com wrote: On Mon, Feb 10, 2014 at 12:51 AM, Aleix Pol aleix...@kde.org wrote: On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser mark...@gmail.com wrote: On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote: On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote: Hey everyone :) It is time to get ready for GSoC 2014. It's another great chance to get some large projects done this year and welcome new enthusiastic people to KDE. I am working on our application. I have started our ideas page at http://community.kde.org/GSoC/2014/Ideas Please go and add projects proposals that you think would be awesome to have a student work on them. Please only add proposals where either you or someone you know are willing to mentor them. If you have ideas but don't have a mentor for them please find a mentor first on the appropriate mailinglist. The ideas page needs to be in good shape by 14 February at 19:00 UTC. Go go go go! ;-) http://community.kde.org/GSoC/2014/Ideas In case of questions please ask on #kde-soc or kde-soc-men...@kde.org. Hey folks :) *poke* about this. The ideas page is still looking rather empty and the application deadline is getting closer. Please help with filling up the ideas page. If you have questions or are unsure about a project please ping me to discuss it. Cheers Lydia (only leaving kde-soc-mentor in cc) I do have an idea for KIO in the next GSoC. Revive the KioFuse code to todays KIO version and update it. The start is there [1] and it's even working on kdelibs 4.0 (don't know it's current state). But it would be very wonderful if that could be working and then integrated in Dolphin (and obviously in my Accretion ^_^) Having this would resolve the issue that opening a network file from Dolphin in (for example) mplayer downloads the entire file to your hdd/ssd before opening it in mplayer. The code is here, the opportunity (due to GSoC) is here. All we need now is a student willing to take on this massive task and someone to mentor the student. [1] http://techbase.kde.org/Projects/KioFuse ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Hi Mark, Feel free to add the proposal yourself. :) It's a wiki. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel I know :) Posting this here to see if anyone would be interested in mentoring this. Will add it to the wiki somewhere tomorrow. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115624: Rename kross man page to match binary name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115624/ --- Review request for KDE Frameworks. Repository: kross Description --- Some time ago, kross was renamed to kf5kross, but the man page was forgotten. Diffs - docs/kross/CMakeLists.txt 8e34a0733ba5a713088b6b7902f72e634cf94739 docs/kross/man-kross.1.docbook e2e6dd1572c3955197700bbcb1e60f38998d3643 Diff: https://git.reviewboard.kde.org/r/115624/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Do not create NETRootInfo/NETWinInfo instances on non-x11 This makes KDialog non-crashy on Wayland. Diffs - src/kdeui/kdialog.cpp bf0f2a2f272acde91d2c6e107f0bd6c125500486 Diff: https://git.reviewboard.kde.org/r/115625/diff/ Testing --- DrKonqi no longer crashes on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/#review49449 --- Ship it! Ship It! - David Edmundson On Feb. 10, 2014, 1:43 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/ --- (Updated Feb. 10, 2014, 1:43 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Do not create NETRootInfo/NETWinInfo instances on non-x11 This makes KDialog non-crashy on Wayland. Diffs - src/kdeui/kdialog.cpp bf0f2a2f272acde91d2c6e107f0bd6c125500486 Diff: https://git.reviewboard.kde.org/r/115625/diff/ Testing --- DrKonqi no longer crashes on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014, David Faure wrote: * OK if I run astyle-kdelibs in both, to harmonize coding style? (drawback: it makes forward-porting changes from 4.x harder) +1 if you can do it. + Can you add both to http://community.kde.org/Frameworks/List? This includes figuring out who to write down as maintainer :) + plasma-framework/README.md should be completed with a description + according to http://community.kde.org/Frameworks/Policies, the autotests and tests in plasma-framework should move to the toplevel. + In kactivities, the actual autotests like ./tests/core should move to an autotests subdir. the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) + kactivites needs a README.md, a kactivities.yaml and a .reviewboardrc Both frameworks need to be ported to ecm_generate_headers and ecm_generate_pri_file. Do you want to look at that too? sure.. but what I need to do for that exactly? ;) Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5 alpha 1 : modules, versions
the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5 alpha 1 : modules, versions
On Monday 10 February 2014, Ivan Čukić wrote: the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ok. i suppose kdesrc-build has to be updated beforehand tough to pick up the correct ones? (how?) -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115617: Don't perform XLib calls if we are not on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/#review49452 --- Ship it! Ship It! - Alexander Richardson On Feb. 10, 2014, 10:17 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- (Updated Feb. 10, 2014, 10:17 a.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Don't perform XLib calls if we are not on X11 Check whether we are on platform xcb and only perform XLib calls if we are on this platform. This makes KApplication based apps to start on Wayland. Diffs - src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 Diff: https://git.reviewboard.kde.org/r/115617/diff/ Testing --- Konsole starts on Wayland. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: let's get ready for Google Summer of Code 2014
On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for _KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. Not you? -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: let's get ready for Google Summer of Code 2014
On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for _KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. Not you? No, certainly not. I know a bit about KIO, but others know _way_ more. And guiding a student requires someone with more in depth knowledge then i have. (looking at David Faure ^_-) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: let's get ready for Google Summer of Code 2014
On Monday 10 February 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_ support_for _KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. Not you? No, certainly not. I know a bit about KIO, but others know _way_ more. And guiding a student requires someone with more in depth knowledge then i have. (looking at David Faure ^_-) Please only add projects where a mentor is willing to take part of GSoC. Looking at persons that are swamped with other work is nice, but that won't help the potential student who is interested in the project just to find out there is no mentor available. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- Review request for KDE Frameworks and Jekyll Wu. Repository: kde-runtime Description --- The parsed command line values are kept in the DrKonqi singleton which replaces the static access to the KCmdLineArgs. Diffs - drkonqi/drkonqi.h 95e64dc drkonqi/drkonqi.cpp ccb1c42 drkonqi/drkonqibackends.cpp 064d07d drkonqi/drkonqidialog.cpp 3fc1549 drkonqi/main.cpp 1337dbe Diff: https://git.reviewboard.kde.org/r/115629/diff/ Testing --- crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49455 --- drkonqi/main.cpp https://git.reviewboard.kde.org/r/115629/#comment34891 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want to create it in the beginning of the main function body. - Aleix Pol Gonzalez On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- (Updated Feb. 10, 2014, 4:06 p.m.) Review request for KDE Frameworks and Jekyll Wu. Repository: kde-runtime Description --- The parsed command line values are kept in the DrKonqi singleton which replaces the static access to the KCmdLineArgs. Diffs - drkonqi/drkonqi.h 95e64dc drkonqi/drkonqi.cpp ccb1c42 drkonqi/drkonqibackends.cpp 064d07d drkonqi/drkonqidialog.cpp 3fc1549 drkonqi/main.cpp 1337dbe Diff: https://git.reviewboard.kde.org/r/115629/diff/ Testing --- crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote: drkonqi/main.cpp, line 74 https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want to create it in the beginning of the main function body. Martin Gräßlin wrote: I'm fine with changing it, but I'd like the opinion of one of the people who are more familiar with the code base. It used to have the QApplication pointer and I don't know why. I assume it's because it used to either create a QApplication or a KApplication. If that's the only reason I'm happy to change the code, otherwise I would keep it with the pointer variant. Fair enough, other than that +1. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49455 --- On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- (Updated Feb. 10, 2014, 4:06 p.m.) Review request for KDE Frameworks and Jekyll Wu. Repository: kde-runtime Description --- The parsed command line values are kept in the DrKonqi singleton which replaces the static access to the KCmdLineArgs. Diffs - drkonqi/drkonqi.h 95e64dc drkonqi/drkonqi.cpp ccb1c42 drkonqi/drkonqibackends.cpp 064d07d drkonqi/drkonqidialog.cpp 3fc1549 drkonqi/main.cpp 1337dbe Diff: https://git.reviewboard.kde.org/r/115629/diff/ Testing --- crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
New framework: KRunner
Hi, During the last sprint, it was decided to split KRunner out of the plasma framework, since it seems like we want to use it but then there are a couple of alternatives. To that end, I created a new repository (kde:krunner) that contains the relevant code and I'll remove it from plasma and add a dependency on krunner from kde-workspace. I'll do it by tomorrow, so it doesn't come up as a surprise. For the moment, I marked it as a tier3, arguably it should be tier4 since there's the possibility of ending up deprecating it, but we're still not there. Cheers! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49457 --- Add explanation for #define - Ivan Romanov On Feb. 10, 2014, 5:39 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 5:39 p.m.) Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 5:35 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Added explanation for #define as a comment. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs (updated) - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting 2014-w7 Reminder
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49463 --- Ship it! Ship It! - Ivan Romanov On Feb. 10, 2014, 11:35 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 11:35 p.m.) Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 6:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. - Dawit Alemayehu On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 10:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. Martin Gräßlin wrote: ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? Probably not very reliable, but maybe qEnvironmentVariableIsSet(DISPLAY)? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 10:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 7:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. Martin Gräßlin wrote: ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? Alexander Richardson wrote: Probably not very reliable, but maybe qEnvironmentVariableIsSet(DISPLAY)? ... and risking a break when we switch to Wayland? If there are sites out there that need to see the X11 string, we should simply lie, and always send it for Linux. We aren't a Mozilla browser either... - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115635: Make kconfig_compiler signals actually useful
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Make kconfig_compiler signals actually useful Previously the classes generated by kconfig_compiler would only emit the defined signals when using the setters provided by that class. However, when using e.g. KConfigDialog which uses KConfigSkeletonItem::setProperty() to change the items no signal was generated. This patch fixes this by using a wrapper KConfigSkeletonItem subclass that calls a private itemChanged() method in the generated class which updates the set of changed properties. As soon as the item is saved (usrWriteConfig() in the generated class is called) the signal will be emitted Diffs - src/core/kcoreconfigskeleton.h c1a158771a785151902cd0a36aa672623618b99e src/core/kcoreconfigskeleton.cpp d9b95b4b0f236f82b1d4831432d3e7637ef19365 src/kconfig_compiler/kconfig_compiler.cpp 0c4254a296348e02e596e9b10b76ff446f26bb65 Diff: https://git.reviewboard.kde.org/r/115635/diff/ Testing --- Unit test from https://git.reviewboard.kde.org/r/115634/ passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Add kconfig_compiler autotest that checks whether signals are emitted Currently this works when using the setters, however when using setProperty() on the KCoreConfigSkeleton* (as done by KConfigDialog) no signals are emitted. Diffs - autotests/kconfig_compiler/CMakeLists.txt a2ebb9453bacb2c7507bc9477b6753a34bbcd434 autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp PRE-CREATION autotests/kconfig_compiler/signals_test.kcfg PRE-CREATION autotests/kconfig_compiler/signals_test_no_singleton.kcfgc PRE-CREATION autotests/kconfig_compiler/signals_test_no_singleton_dpointer.kcfgc PRE-CREATION autotests/kconfig_compiler/signals_test_singleton.kcfgc PRE-CREATION autotests/kconfig_compiler/signals_test_singleton_dpointer.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115634/diff/ Testing --- Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is applied, then they pass. Rather ugly code IMO, open for suggestions to improve it... Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/#review49503 --- This review has been submitted with commit b49f6ae40d76842bca8bb8c4ed69bf304bac4ecb by Martin Gräßlin to branch master. - Commit Hook On Feb. 10, 2014, 1:43 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/ --- (Updated Feb. 10, 2014, 1:43 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Do not create NETRootInfo/NETWinInfo instances on non-x11 This makes KDialog non-crashy on Wayland. Diffs - src/kdeui/kdialog.cpp bf0f2a2f272acde91d2c6e107f0bd6c125500486 Diff: https://git.reviewboard.kde.org/r/115625/diff/ Testing --- DrKonqi no longer crashes on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115617: Don't perform XLib calls if we are not on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/#review49502 --- This review has been submitted with commit d0f36b22cbc510026b9b40ce27d174767c35c49f by Martin Gräßlin to branch master. - Commit Hook On Feb. 10, 2014, 9:17 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- (Updated Feb. 10, 2014, 9:17 a.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Don't perform XLib calls if we are not on X11 Check whether we are on platform xcb and only perform XLib calls if we are on this platform. This makes KApplication based apps to start on Wayland. Diffs - src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 Diff: https://git.reviewboard.kde.org/r/115617/diff/ Testing --- Konsole starts on Wayland. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115617: Don't perform XLib calls if we are not on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- (Updated Feb. 11, 2014, 6:39 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Don't perform XLib calls if we are not on X11 Check whether we are on platform xcb and only perform XLib calls if we are on this platform. This makes KApplication based apps to start on Wayland. Diffs - src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 Diff: https://git.reviewboard.kde.org/r/115617/diff/ Testing --- Konsole starts on Wayland. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115616: Add platform to qt options in KCmdLineArgs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/#review49501 --- This review has been submitted with commit c3e78df2bc504fc65e97f15018cea260b2c5dbc8 by Martin Gräßlin to branch master. - Commit Hook On Feb. 10, 2014, 9:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/ --- (Updated Feb. 10, 2014, 9:14 a.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Add platform to qt options in KCmdLineArgs It's needed to start KApplications on Wayland. Diffs - src/kdecore/kcmdlineargs.cpp 2b5ed04c03a6a66cf776dfc09d8c0ca49ac432ae Diff: https://git.reviewboard.kde.org/r/115616/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115616: Add platform to qt options in KCmdLineArgs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/ --- (Updated Feb. 11, 2014, 6:39 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Add platform to qt options in KCmdLineArgs It's needed to start KApplications on Wayland. Diffs - src/kdecore/kcmdlineargs.cpp 2b5ed04c03a6a66cf776dfc09d8c0ca49ac432ae Diff: https://git.reviewboard.kde.org/r/115616/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115639: Ensure X11 specific code is only called on platform X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Ensure X11 specific code is only called on platform X11 Global search for HAVE_X11 in kde4support and adjusted the dangerous parts. Diffs - src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 Diff: https://git.reviewboard.kde.org/r/115639/diff/ Testing --- compiles, kcolordlgtest does no longer crash on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Fwd: Re: Re: HAVE_X11 usage in KIO/core
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
---BeginMessage---
Well that was done for compatibility with what Firefox/Chromium.
The latest stable version (version 27) sends the following user agent
string:
Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0
And the latest Chromium (version 32) seems to send the following string by
default:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko)
Chrome/32.0.1700.107 Safari/537.36
So removing the platform name from the user-agent string might have
consequences for those that check for it?
Regards,
Dawit A.
On Sat, Feb 8, 2014 at 4:29 AM, David Faure fa...@kde.org wrote:
Any opinion?
-- Forwarded Message --
Subject: Re: HAVE_X11 usage in KIO/core
Date: Saturday 08 February 2014, 00:55:22
From: Albert Astals Cid aa...@kde.org
To: kde-frameworks-devel@kde.org
El Divendres, 7 de febrer de 2014, a les 15:25:42, Kevin Krammer va
escriure:
On Friday, 2014-02-07, 09:51:27, Martin Gräßlin wrote:
On Friday 07 February 2014 09:38:41 Kevin Krammer wrote:
On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote:
I'm wondering what to do about it. The best would be to use
QGuiApplication::platformName, but it's a core app. Also finding
X11
in
CMakeLists to get the HAVE_X11 defined looks very wrong to me and
not
future safe (Wayland).
My guess is that platform() in this context means operating system,
not
windowing/display system.
See the comment I pasted, it's explicitly saying it's the windowing
system
and not the OS...
Ah, didn't see that. Does it actually make sense?
If yes than this obviously has be to be done at runtime, at least for
platforms with multiple UI systems:
#if defined(Q_OS_MAC)
return QL1S(Macintosh)
#elfi defined(Q_OS_WINDOWS)
return QL1S(Windows)
#else
const QVariant platformName = qApp ? qApp-property(platformName) :
QVariant();
if (platformName.isValid()) {
const QString name = platformName.toString();
if (!name.isEmpty())
return name;
}
#endif
return QL1S(Unknown);
Sincerely, just drop it.
We will change from sending
Mozilla/5.0 (compatible; Konqueror/4.0; Linux; X11; i686; en_US)
KHTML/4.0.1
(like Gecko)
to
Mozilla/5.0 (compatible; Konqueror/4.0; Linux; i686; en_US) KHTML/4.0.1
(like
Gecko)
will anyone ever care?
Cheers,
Albert
Cheers,
Kevin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
---End Message---
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
