Re: Problems found by the CI system
On Tue, Mar 25, 2014 at 12:37 AM, Vishesh Handa m...@vhanda.in wrote: On Monday, March 24, 2014 06:59:24 PM Ben Cooksley wrote: Baloo developers, please take a look at the failure in this log - http://build.kde.org/view/FAILED/job/baloo_stable/80/console. When referencing projects outside your own, it is imperative the correct include statements are used in the CMake logic. I've pushed a commit. That should hopefully fix it. Unfortunately it seems the build still fails - http://build.kde.org/view/FAILED/job/baloo_stable/81/console Please note that this is the stable build (KDE/4.13 branch). Thanks for fixing the master branch though - all it's tests are now passing. Could you perhaps add some hook to email me about these failures? We don't have a dedicated mailing list for Baloo and I'm not sure if notifying kde- devel would be a good idea. I've now configured it to send you emails for both the Baloo master and stable builds. -- Vishesh Handa Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Ensure that pluginVersion gets resolved for multiple KPluginLoader If the library was already loaded the KPluginLoader did not resolve the pluginVersion, so any check for the pluginVersion failed. Diffs - autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 autotests/pluginversiontest.cpp PRE-CREATION src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e Diff: https://git.reviewboard.kde.org/r/117049/diff/ Testing --- see included unit test Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116982: Remove KDE 4 refs in khtml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/ --- (Updated March 25, 2014, 10:08 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Add FIXME to testregression docs about updating them kcmshell4 - kcmshell5 Reword or resolve ### KDE4 TODOs Those that are just simple binary compatibility issues are resolved, others are replaced with TODO. Diffs - src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e src/ecma/debugger/breakpointsdock.cpp 3570bd07d705e60274d1a44f6bd344b613ec64c1 src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad Diff: https://git.reviewboard.kde.org/r/116982/diff/ Testing --- Builds, installs, autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116982: Remove KDE 4 refs in khtml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/#review54076 --- This review has been submitted with commit 11755097e051de40a41a8a7e0497bc31040d3588 by Alex Merry to branch master. - Commit Hook On March 22, 2014, 6:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/ --- (Updated March 22, 2014, 6:46 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Add FIXME to testregression docs about updating them kcmshell4 - kcmshell5 Reword or resolve ### KDE4 TODOs Those that are just simple binary compatibility issues are resolved, others are replaced with TODO. Diffs - src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e src/ecma/debugger/breakpointsdock.cpp 3570bd07d705e60274d1a44f6bd344b613ec64c1 src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad Diff: https://git.reviewboard.kde.org/r/116982/diff/ Testing --- Builds, installs, autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116982: Remove KDE 4 refs in khtml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/#review54075 --- This review has been submitted with commit f4b23002eb69a54eaef03750bbf7ff6868eecb21 by Alex Merry to branch master. - Commit Hook On March 22, 2014, 6:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/ --- (Updated March 22, 2014, 6:46 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Add FIXME to testregression docs about updating them kcmshell4 - kcmshell5 Reword or resolve ### KDE4 TODOs Those that are just simple binary compatibility issues are resolved, others are replaced with TODO. Diffs - src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e src/ecma/debugger/breakpointsdock.cpp 3570bd07d705e60274d1a44f6bd344b613ec64c1 src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad Diff: https://git.reviewboard.kde.org/r/116982/diff/ Testing --- Builds, installs, autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116982: Remove KDE 4 refs in khtml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/#review54074 --- This review has been submitted with commit 73654f6eb6b803240a1a6eec4feadf27748407d5 by Alex Merry to branch master. - Commit Hook On March 22, 2014, 6:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/ --- (Updated March 22, 2014, 6:46 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Add FIXME to testregression docs about updating them kcmshell4 - kcmshell5 Reword or resolve ### KDE4 TODOs Those that are just simple binary compatibility issues are resolved, others are replaced with TODO. Diffs - src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e src/ecma/debugger/breakpointsdock.cpp 3570bd07d705e60274d1a44f6bd344b613ec64c1 src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad Diff: https://git.reviewboard.kde.org/r/116982/diff/ Testing --- Builds, installs, autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 25, 2014, 10:10 a.m.) Review request for Documentation and KDE Frameworks. Changes --- Remove spurious whitespace. Repository: kded Description --- Update the kded5 man page Diffs (updated) - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/#review54077 --- This review has been submitted with commit 58b38d26dda467153a9b8f4659ed43e62478f145 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 3:48 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- (Updated March 23, 2014, 3:48 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- (Updated March 25, 2014, 10:11 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/#review54078 --- This review has been submitted with commit f0727f1d00aa3109a8252888ca6c2e7cd88ff0f3 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 3:48 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- (Updated March 23, 2014, 3:48 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/#review54079 --- This review has been submitted with commit ea58ba763ffc2fd5bf8a615772077d2a9d7c2120 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 3:48 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- (Updated March 23, 2014, 3:48 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/#review54080 --- This review has been submitted with commit 0f66cb5ac7eb909cd431865cf46f6e9f2ae69afe by Alex Merry to branch master. - Commit Hook On March 23, 2014, 3:48 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- (Updated March 23, 2014, 3:48 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116999: kparts: Remove/resolve old porting comments and TODOs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/#review54082 --- This review has been submitted with commit 2ea7f0c96f183c7edaf69ae42d8c34efe06a7e29 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 4:33 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- (Updated March 23, 2014, 4:33 p.m.) Review request for KDE Frameworks. Repository: kparts Description --- Remove old porting comments and TODOs Use QMetaObject::indexOfMethod instead of iterating through methods Diffs - src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 Diff: https://git.reviewboard.kde.org/r/116999/diff/ Testing --- builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116999: kparts: Remove/resolve old porting comments and TODOs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- (Updated March 25, 2014, 10:16 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kparts Description --- Remove old porting comments and TODOs Use QMetaObject::indexOfMethod instead of iterating through methods Diffs - src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 Diff: https://git.reviewboard.kde.org/r/116999/diff/ Testing --- builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116999: kparts: Remove/resolve old porting comments and TODOs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/#review54081 --- This review has been submitted with commit 9d47171cdaa9946251b058625b68f70e6e17e125 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 4:33 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- (Updated March 23, 2014, 4:33 p.m.) Review request for KDE Frameworks. Repository: kparts Description --- Remove old porting comments and TODOs Use QMetaObject::indexOfMethod instead of iterating through methods Diffs - src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 Diff: https://git.reviewboard.kde.org/r/116999/diff/ Testing --- builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117003: Remove kde3 compatibility code for DocPath in desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/ --- (Updated March 25, 2014, 10:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfig Description --- Remove kde3 compatibility code for DocPath in desktop files LXR suggests nothing still sets that (everything is X-DocPath now). Diffs - src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 Diff: https://git.reviewboard.kde.org/r/117003/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117023: Use the full path for kconf_update when running it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/#review54085 --- This review has been submitted with commit e1ad9a6192d1e2be6fcb17c8a1e961104d921752 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 4:19 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/ --- (Updated March 24, 2014, 4:19 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Use the full path for kconf_update when running it It is not on $PATH, so we cannot just expect QProcess to find it. Export the location of kconf_update in CMake This is for the benefit of kded, which needs to run this binary. Diffs - src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 Diff: https://git.reviewboard.kde.org/r/117023/diff/ Testing --- Builds, installs. Checked the define passed to the compiler by eye. Not sure how to test the actual code. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117023: Use the full path for kconf_update when running it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/#review54084 --- This review has been submitted with commit d53cf39a20d3f3f23883ca9a6b154041ee094a8d by Alex Merry to branch master. - Commit Hook On March 24, 2014, 4:19 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/ --- (Updated March 24, 2014, 4:19 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Use the full path for kconf_update when running it It is not on $PATH, so we cannot just expect QProcess to find it. Export the location of kconf_update in CMake This is for the benefit of kded, which needs to run this binary. Diffs - src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 Diff: https://git.reviewboard.kde.org/r/117023/diff/ Testing --- Builds, installs. Checked the define passed to the compiler by eye. Not sure how to test the actual code. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117023: Use the full path for kconf_update when running it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/ --- (Updated March 25, 2014, 10:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfig Description --- Use the full path for kconf_update when running it It is not on $PATH, so we cannot just expect QProcess to find it. Export the location of kconf_update in CMake This is for the benefit of kded, which needs to run this binary. Diffs - src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 Diff: https://git.reviewboard.kde.org/r/117023/diff/ Testing --- Builds, installs. Checked the define passed to the compiler by eye. Not sure how to test the actual code. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117023: Use the full path for kconf_update when running it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/ --- (Updated March 25, 2014, 10:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfig Description --- Use the full path for kconf_update when running it It is not on $PATH, so we cannot just expect QProcess to find it. Export the location of kconf_update in CMake This is for the benefit of kded, which needs to run this binary. Diffs - src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 Diff: https://git.reviewboard.kde.org/r/117023/diff/ Testing --- Builds, installs. Checked the define passed to the compiler by eye. Not sure how to test the actual code. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117003: Remove kde3 compatibility code for DocPath in desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/#review54083 --- This review has been submitted with commit c8f3b3684e42d5b1e788642863782741703acbd2 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 5:36 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/ --- (Updated March 23, 2014, 5:36 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Remove kde3 compatibility code for DocPath in desktop files LXR suggests nothing still sets that (everything is X-DocPath now). Diffs - src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 Diff: https://git.reviewboard.kde.org/r/117003/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54087 --- This review has been submitted with commit 69d9bfa7b8b9c2e2de80f951c5bda4805437a555 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 2:07 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 24, 2014, 2:07 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Fix up KLibLoader autotests They now test the actual current state of KLibLoader (eg: only Qt5-style plugins using KPluginFactory are supported). Improve KLibLoader documentation Also, add some extra deprecation warnings. Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning There is no code left to load these plugins, which have been deprecated since kdelibs 4.0. Use KPluginLoader in KLibLoader::factory() This actually has some chance of succeeding (KLibrary::factory() always returns 0). Diffs - src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 autotests/klibloadertest_module.h autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 autotests/klibloadertest4_module.h autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe Diff: https://git.reviewboard.kde.org/r/117020/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54086 --- This review has been submitted with commit e42500075e60b84f7fc770d15a668d9bce3b344b by Alex Merry to branch master. - Commit Hook On March 24, 2014, 2:07 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 24, 2014, 2:07 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Fix up KLibLoader autotests They now test the actual current state of KLibLoader (eg: only Qt5-style plugins using KPluginFactory are supported). Improve KLibLoader documentation Also, add some extra deprecation warnings. Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning There is no code left to load these plugins, which have been deprecated since kdelibs 4.0. Use KPluginLoader in KLibLoader::factory() This actually has some chance of succeeding (KLibrary::factory() always returns 0). Diffs - src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 autotests/klibloadertest_module.h autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 autotests/klibloadertest4_module.h autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe Diff: https://git.reviewboard.kde.org/r/117020/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 25, 2014, 10:33 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Fix up KLibLoader autotests They now test the actual current state of KLibLoader (eg: only Qt5-style plugins using KPluginFactory are supported). Improve KLibLoader documentation Also, add some extra deprecation warnings. Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning There is no code left to load these plugins, which have been deprecated since kdelibs 4.0. Use KPluginLoader in KLibLoader::factory() This actually has some chance of succeeding (KLibrary::factory() always returns 0). Diffs - src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 autotests/klibloadertest_module.h autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 autotests/klibloadertest4_module.h autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe Diff: https://git.reviewboard.kde.org/r/117020/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54088 --- This review has been submitted with commit 0fba4b63532a592757e7a33280547362250e8303 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 2:07 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 24, 2014, 2:07 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Fix up KLibLoader autotests They now test the actual current state of KLibLoader (eg: only Qt5-style plugins using KPluginFactory are supported). Improve KLibLoader documentation Also, add some extra deprecation warnings. Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning There is no code left to load these plugins, which have been deprecated since kdelibs 4.0. Use KPluginLoader in KLibLoader::factory() This actually has some chance of succeeding (KLibrary::factory() always returns 0). Diffs - src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 autotests/klibloadertest_module.h autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 autotests/klibloadertest4_module.h autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe Diff: https://git.reviewboard.kde.org/r/117020/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54089 --- This review has been submitted with commit b6133f2fe506e195a8a8e964c43ef8de21fd4423 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 2:07 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 24, 2014, 2:07 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Fix up KLibLoader autotests They now test the actual current state of KLibLoader (eg: only Qt5-style plugins using KPluginFactory are supported). Improve KLibLoader documentation Also, add some extra deprecation warnings. Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning There is no code left to load these plugins, which have been deprecated since kdelibs 4.0. Use KPluginLoader in KLibLoader::factory() This actually has some chance of succeeding (KLibrary::factory() always returns 0). Diffs - src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 autotests/klibloadertest_module.h autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 autotests/klibloadertest4_module.h autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe Diff: https://git.reviewboard.kde.org/r/117020/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116981: Use new terminology in webkit docs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/ --- (Updated March 25, 2014, 10:39 a.m.) Review request for KDE Frameworks. Changes --- Change capitalisation of KDE Frameworks and Plasma Desktop. Repository: kdewebkit Description --- Use new terminology in webkit docs. KDE frameworks intead of KDE, etc. Diffs (updated) - src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 Diff: https://git.reviewboard.kde.org/r/116981/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116981: Use new terminology in webkit docs.
On March 24, 2014, 6:58 p.m., Kevin Ottens wrote: src/kgraphicswebview.h, line 153 https://git.reviewboard.kde.org/r/116981/diff/1/?file=256195#file256195line153 Probably need to be checked with the plasma people, but I think they say just Plasma nowadays because of the upcoming generic shell. This is an inherently desktop interaction (shift-clicking), so I went with Plasma Desktop, after consulting Eike Hein. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/#review54012 --- On March 25, 2014, 10:39 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/ --- (Updated March 25, 2014, 10:39 a.m.) Review request for KDE Frameworks. Repository: kdewebkit Description --- Use new terminology in webkit docs. KDE frameworks intead of KDE, etc. Diffs - src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 Diff: https://git.reviewboard.kde.org/r/116981/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117024: Use the KF5::kconf_update target to locate kconf_update
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117024/#review54091 --- This review has been submitted with commit aae70e413f86c4da5fba14c164af117af23ca9e1 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 4:19 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117024/ --- (Updated March 24, 2014, 4:19 p.m.) Review request for KDE Frameworks. Repository: kded Description --- Use the KF5::kconf_update target to locate kconf_update kconf_update is an internal executable to KConfig, and so is not on $PATH. It is also not a kdeinit executable, although we still use kdeinit to launch it just for consistency (of environment etc). Diffs - src/CMakeLists.txt a081a5bf9a4b57101d4f2db48941fc1e1e51fbb2 src/kded.cpp fb1cfcbab4c1a7b74009493930ae48ecea52c013 Diff: https://git.reviewboard.kde.org/r/117024/diff/ Testing --- Builds, installs. Ran kded5, and kdeinit5 printed kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' from launcher. kdeinit5: preparing to launch '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' and no related errors. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117024: Use the KF5::kconf_update target to locate kconf_update
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117024/ --- (Updated March 25, 2014, 10:43 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kded Description --- Use the KF5::kconf_update target to locate kconf_update kconf_update is an internal executable to KConfig, and so is not on $PATH. It is also not a kdeinit executable, although we still use kdeinit to launch it just for consistency (of environment etc). Diffs - src/CMakeLists.txt a081a5bf9a4b57101d4f2db48941fc1e1e51fbb2 src/kded.cpp fb1cfcbab4c1a7b74009493930ae48ecea52c013 Diff: https://git.reviewboard.kde.org/r/117024/diff/ Testing --- Builds, installs. Ran kded5, and kdeinit5 printed kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' from launcher. kdeinit5: preparing to launch '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' and no related errors. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117052: Add ECMSetupQtTranslations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- This simplifies translation handling for frameworks using Qt translation system. Diffs - modules/ECMTrLoader.cpp.in PRE-CREATION modules/ECMSetupQtTranslations.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117052/diff/ Testing --- Here is a patch which make kbookmarks use it: http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the Messages.sh part of the patch are being reviewed for inclusion in the l10n-kde4 repository. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #178
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/178/changes Changes: [notmart] New default theme: welcome Breeze! -- [...truncated 71 lines...] kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so (found version 1.9) -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so (found version 1.9) -- Found XCB_SHAPE: /usr/lib64/libxcb-shape.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so;/usr/lib64/libxcb-shape.so (found version 1.9) found components: XCB COMPOSITE DAMAGE SHAPE -- Found OpenGL: /usr/lib64/libGL.so -- Found EGL: /usr/lib64/libEGL.so -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Warning (dev) at src/declarativeimports/accessdenied/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/core/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmacomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmaextracomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/calendar/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/plasmapkg/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #178
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/178/changes Changes: [notmart] New default theme: welcome Breeze! -- [...truncated 72 lines...] kwindowsystem - Branch master kguiaddons - Branch master cmake - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so (found version 1.9) -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so (found version 1.9) -- Found XCB_SHAPE: /usr/lib64/libxcb-shape.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so;/usr/lib64/libxcb-shape.so (found version 1.9) found components: XCB COMPOSITE DAMAGE SHAPE -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found OpenGL: /usr/lib64/libGL.so -- Found EGL: /usr/lib64/libEGL.so -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Warning (dev) at src/declarativeimports/accessdenied/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/core/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmacomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmaextracomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/calendar/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/plasmapkg/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #179
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/179/changes Changes: [notmart] prepare a proper push -- [...truncated 70 lines...] cmake - Branch master kconfig - Branch master kross - Branch master kwindowsystem - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so (found version 1.9) -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so (found version 1.9) -- Found XCB_SHAPE: /usr/lib64/libxcb-shape.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so;/usr/lib64/libxcb-shape.so (found version 1.9) found components: XCB COMPOSITE DAMAGE SHAPE -- Found OpenGL: /usr/lib64/libGL.so -- Found EGL: /usr/lib64/libEGL.so -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Warning (dev) at src/declarativeimports/accessdenied/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/core/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmacomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmaextracomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/calendar/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/plasmapkg/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #179
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/179/changes Changes: [notmart] prepare a proper push -- [...truncated 68 lines...] solid - Branch master kxmlgui - Branch master cmake - Branch master kconfig - Branch master kross - Branch master kwindowsystem - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so (found version 1.9) -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so (found version 1.9) -- Found XCB_SHAPE: /usr/lib64/libxcb-shape.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so;/usr/lib64/libxcb-shape.so (found version 1.9) found components: XCB COMPOSITE DAMAGE SHAPE -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found OpenGL: /usr/lib64/libGL.so -- Found EGL: /usr/lib64/libEGL.so -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Warning (dev) at src/declarativeimports/accessdenied/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/core/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmacomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/plasmaextracomponents/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/declarativeimports/calendar/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/plasmapkg/CMakeLists.txt:1
Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #180
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/180/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #180
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/180/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116930: Fix device not open warning messages at build time
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/#review54104
---
This review has been submitted with commit
4acf489ebdcdf8581093487a39de59cf41ed222d by Aurélien Gâteau to branch master.
- Commit Hook
On March 23, 2014, 8:12 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/
---
(Updated March 23, 2014, 8:12 p.m.)
Review request for KDE Frameworks and Sebastian Kügler.
Repository: kservice
Description
---
The device not open message appears when one registers a factory without a
.json file.
The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:
class MyPlugin : public KPluginFactory
{
Q_OBJECT
Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE )
When moc parses such code, it tries to read a json file named and
rightfully complains.
Diffs
-
src/plugin/kpluginfactory.h 3880d29
Diff: https://git.reviewboard.kde.org/r/116930/diff/
Testing
---
Rebuilt kde-workspace from scratch. No more message.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116930: Fix device not open warning messages at build time
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/
---
(Updated March 25, 2014, 1:18 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Sebastian Kügler.
Repository: kservice
Description
---
The device not open message appears when one registers a factory without a
.json file.
The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:
class MyPlugin : public KPluginFactory
{
Q_OBJECT
Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE )
When moc parses such code, it tries to read a json file named and rightfully
complains.
Diffs
-
src/plugin/kpluginfactory.h 3880d29
Diff: https://git.reviewboard.kde.org/r/116930/diff/
Testing
---
Rebuilt kde-workspace from scratch. No more message.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/#review54118 --- This review has been submitted with commit 2fe5e49ea9efcff020ffa4b0c35e57273e1625c8 by Martin Gräßlin to branch master. - Commit Hook On March 20, 2014, 1:40 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/ --- (Updated March 20, 2014, 1:40 p.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove support for _NET_WM_TAKE_ACTIVITY This was a proposed protocol [1] which never got adopted and no toolkit is making use of it. It's not implemented in either Qt4 or Qt5 and also not in GTK [2]. Only KWin had support for it, but didn't announce it in NET::Supported. This is a SIC-change, but according to lxr nothing except KWin used these methods and there they are already in the process of getting removed. [1] https://mail.gnome.org/archives/wm-spec-list/2004-April/msg00013.html [2] https://bugzilla.gnome.org/show_bug.cgi?id=154260 Diffs - autotests/netrootinfotestwm.cpp e5fb0fa2b60bf434c84f89ce5e81deb93e3d2467 src/netwm.h 640686a3cf4723bfd6e5aaad0b301f86f0a463ed src/netwm.cpp d9956d2b8191405847ff84cb401126fa7a2f2fbf src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116926/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117052: Add ECMSetupQtTranslations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54111 --- The docs need cleaning up, but I'd like to concentrate on the API first. I'd rather this followed the convention of other file-generating macros in getting the user to provide a variable name to store the file(s) in, rather than always using ECM_QT_TRANSLATION_LOADER. I also think that the installation should be handled by the caller. Provide a variable to store the qmfiles in, and require the caller to install them in a subdir podir of something in QStandardPaths::GenericDataLocation. That way, the project can make use of the user-configurable DATA_INSTALL_DIR from KDEInstallDirs, for example, or their own installation path code. I could imagine that an option to specify the name of the loader file could potentially be useful to avoid clashes, but let's leave that until someone says they want it. - Alex Merry On March 25, 2014, 10:48 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/ --- (Updated March 25, 2014, 10:48 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- This simplifies translation handling for frameworks using Qt translation system. Diffs - modules/ECMTrLoader.cpp.in PRE-CREATION modules/ECMSetupQtTranslations.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117052/diff/ Testing --- Here is a patch which make kbookmarks use it: http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the Messages.sh part of the patch are being reviewed for inclusion in the l10n-kde4 repository. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/#review54116 --- For the record: support in KWin got removed with commit 3e6c2250f703a0384598a454f67ada98d673d36a - Martin Gräßlin On March 20, 2014, 2:40 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/ --- (Updated March 20, 2014, 2:40 p.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove support for _NET_WM_TAKE_ACTIVITY This was a proposed protocol [1] which never got adopted and no toolkit is making use of it. It's not implemented in either Qt4 or Qt5 and also not in GTK [2]. Only KWin had support for it, but didn't announce it in NET::Supported. This is a SIC-change, but according to lxr nothing except KWin used these methods and there they are already in the process of getting removed. [1] https://mail.gnome.org/archives/wm-spec-list/2004-April/msg00013.html [2] https://bugzilla.gnome.org/show_bug.cgi?id=154260 Diffs - autotests/netrootinfotestwm.cpp e5fb0fa2b60bf434c84f89ce5e81deb93e3d2467 src/netwm.h 640686a3cf4723bfd6e5aaad0b301f86f0a463ed src/netwm.cpp d9956d2b8191405847ff84cb401126fa7a2f2fbf src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116926/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/ --- (Updated March 25, 2014, 2:21 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdesu Description --- Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set If kdesu is compiled with X11 it required the DISPLAY variable to be set. This is no longer correct as it might have been compiled with X11 but is run on Wayland. Thus the code checks now also for WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support should become more complete, I do not know how it behaves if we compile without X11 support. Unfortunately there are no autotests and no test applications which one could use. Diffs - src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 Diff: https://git.reviewboard.kde.org/r/115717/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/#review54115 --- This review has been submitted with commit 343853139c72b8f4f4d2739a4ba6ad2bd3b7a050 by Martin Gräßlin to branch master. - Commit Hook On March 21, 2014, 7:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- (Updated March 21, 2014, 7:15 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove deprecation for NET::timestampCompare and NET::timestampDiff The deprecated note recommended to use the methods in KXUtils namespace, but those are in a private header and that's not going to change. As the methods are used by applications (e.g. KWin) it should not get deprecated if there is no replacement. Diffs - src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116941/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review54114 --- This review has been submitted with commit c04277a151710381a1b7451c07f5f58ecfabfe4d by Martin Gräßlin to branch master. - Commit Hook On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 19, 2014, 6:19 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 25, 2014, 2:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116998: Clean up kde4 stuff in knewstuff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/ --- Review request for KDE Frameworks. Repository: knewstuff Description --- Remove reference to KDE4_BUILD_TESTS CMake option Clean up comments about KConfig Fix KUrl-QUrl porting QUrl::setPath() does not behave like KUrl::setPath(). Also removed two very old FIXMEs: the purpose of the condition is clear now (but it was probably unnecessary when it used KUrl from kdelibs4), and no-one noticed any issues with the icon URLs during KDE 4, so KUrl probably did behave as expected. Remove completely out-of-date README.kdxs Diffs - docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224 src/staticxml/staticxmlprovider.cpp 56a25654a70a3628573d85adf4a1c49010f23309 src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1 tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852 Diff: https://git.reviewboard.kde.org/r/116998/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- (Updated March 25, 2014, 2:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove deprecation for NET::timestampCompare and NET::timestampDiff The deprecated note recommended to use the methods in KXUtils namespace, but those are in a private header and that's not going to change. As the methods are used by applications (e.g. KWin) it should not get deprecated if there is no replacement. Diffs - src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116941/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116998: Clean up kde4 stuff in knewstuff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54127 --- src/staticxml/staticxmlprovider.cpp https://git.reviewboard.kde.org/r/116998/#comment37842 iconurl = QUrl::fromLocalFile(xmldata.attribute(icon)); Or am i missing something obvious now? - Mark Gaiser On March 25, 2014, 2:37 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/ --- (Updated March 25, 2014, 2:37 p.m.) Review request for KDE Frameworks. Repository: knewstuff Description --- Remove reference to KDE4_BUILD_TESTS CMake option Clean up comments about KConfig Fix KUrl-QUrl porting QUrl::setPath() does not behave like KUrl::setPath(). Also removed two very old FIXMEs: the purpose of the condition is clear now (but it was probably unnecessary when it used KUrl from kdelibs4), and no-one noticed any issues with the icon URLs during KDE 4, so KUrl probably did behave as expected. Remove completely out-of-date README.kdxs Diffs - docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224 src/staticxml/staticxmlprovider.cpp 56a25654a70a3628573d85adf4a1c49010f23309 src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1 tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852 Diff: https://git.reviewboard.kde.org/r/116998/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/ --- (Updated March 25, 2014, 2:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove support for _NET_WM_TAKE_ACTIVITY This was a proposed protocol [1] which never got adopted and no toolkit is making use of it. It's not implemented in either Qt4 or Qt5 and also not in GTK [2]. Only KWin had support for it, but didn't announce it in NET::Supported. This is a SIC-change, but according to lxr nothing except KWin used these methods and there they are already in the process of getting removed. [1] https://mail.gnome.org/archives/wm-spec-list/2004-April/msg00013.html [2] https://bugzilla.gnome.org/show_bug.cgi?id=154260 Diffs - autotests/netrootinfotestwm.cpp e5fb0fa2b60bf434c84f89ce5e81deb93e3d2467 src/netwm.h 640686a3cf4723bfd6e5aaad0b301f86f0a463ed src/netwm.cpp d9956d2b8191405847ff84cb401126fa7a2f2fbf src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116926/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116998: Clean up kde4 stuff in knewstuff
On March 25, 2014, 3:23 p.m., Mark Gaiser wrote: src/staticxml/staticxmlprovider.cpp, line 80 https://git.reviewboard.kde.org/r/116998/diff/1/?file=256388#file256388line80 iconurl = QUrl::fromLocalFile(xmldata.attribute(icon)); Or am i missing something obvious now? Heh, that was silly of me :-) - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54127 --- On March 25, 2014, 2:37 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/ --- (Updated March 25, 2014, 2:37 p.m.) Review request for KDE Frameworks. Repository: knewstuff Description --- Remove reference to KDE4_BUILD_TESTS CMake option Clean up comments about KConfig Fix KUrl-QUrl porting QUrl::setPath() does not behave like KUrl::setPath(). Also removed two very old FIXMEs: the purpose of the condition is clear now (but it was probably unnecessary when it used KUrl from kdelibs4), and no-one noticed any issues with the icon URLs during KDE 4, so KUrl probably did behave as expected. Remove completely out-of-date README.kdxs Diffs - docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224 src/staticxml/staticxmlprovider.cpp 56a25654a70a3628573d85adf4a1c49010f23309 src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1 tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852 Diff: https://git.reviewboard.kde.org/r/116998/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Final kde-runtime splitting plan
Hi there Today Aleix and I are starting to split kde-runtime so we have gone through all the components again making sure that everything has a suitable destination. The result is this [1] wiki. Please, check that you are ok with the destination of each component and also check the things that have been targeted as **REMOVE** should be really removed (we believe so). Cheers ! [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/ --- (Updated March 25, 2014, 3:44 p.m.) Review request for KDE Frameworks. Changes --- Fix issue spotted by Mark. Summary (updated) - Remove reference to KDE4_BUILD_TESTS CMake option Repository: knewstuff Description --- Remove reference to KDE4_BUILD_TESTS CMake option Clean up comments about KConfig Fix KUrl-QUrl porting QUrl::setPath() does not behave like KUrl::setPath(). Also removed two very old FIXMEs: the purpose of the condition is clear now (but it was probably unnecessary when it used KUrl from kdelibs4), and no-one noticed any issues with the icon URLs during KDE 4, so KUrl probably did behave as expected. Remove completely out-of-date README.kdxs Diffs (updated) - docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224 src/staticxml/staticxmlprovider.cpp 56a25654a70a3628573d85adf4a1c49010f23309 src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1 tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852 Diff: https://git.reviewboard.kde.org/r/116998/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- Review request for KDE Frameworks. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117061: Explicitly state link interface for libKF5XsltKde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Explicitly state link interface for libKF5XsltKde Diffs - src/CMakeLists.txt ac144147e0a52c4b77bc0a28b89a953e08444d78 Diff: https://git.reviewboard.kde.org/r/117061/diff/ Testing --- Builds and installs. So does KIO (which apparently uses this library, according to the comment). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117062: Remove KDirWatch::DNotify, it has been unused for ages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- Remove KDirWatch::DNotify, it has been unused for ages Diffs - autotests/kdirwatch_unittest.cpp de92ac7e5030ac2a49ffbbc926a691a5830de761 src/lib/io/kdirwatch.h 353f0e5545f19d07116339b73f0719d88394bfd2 src/lib/io/kdirwatch.cpp cf9497ac1bc70c71d71491b760461346d9fcc0e1 src/lib/io/kdirwatch_p.h 37876e63c1058f41508c5e883599dac252a004a2 Diff: https://git.reviewboard.kde.org/r/117062/diff/ Testing --- Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117059: Explicitly state link interface for libKF5Activites
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/ --- Review request for KDE Frameworks and Plasma. Repository: kactivities Description --- Explicitly state link interface for libKF5Activites Diffs - src/lib/core/CMakeLists.txt 7edd2e34bc5ccec6ae526c0305d090afdaf9f306 Diff: https://git.reviewboard.kde.org/r/117059/diff/ Testing --- Compiles, installs. plasa-framework, kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Explicitly specify link interface libraries for libKF5PlasmaQuick The headers may not be public (yet?), but it doesn't hurt to have this stuff specified properly. Diffs - src/plasmaquick/CMakeLists.txt 83af22ecaf235c26115aa741d3c288bc71c269e9 Diff: https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117062: Remove KDirWatch::DNotify, it has been unused for ages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/#review54130 --- Ship it! Yep, now's the time to do this change :-) Just one odd whitespace thing. src/lib/io/kdirwatch.cpp https://git.reviewboard.kde.org/r/117062/#comment37845 ? - Alex Merry On March 25, 2014, 5 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/ --- (Updated March 25, 2014, 5 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Remove KDirWatch::DNotify, it has been unused for ages Diffs - autotests/kdirwatch_unittest.cpp de92ac7e5030ac2a49ffbbc926a691a5830de761 src/lib/io/kdirwatch.h 353f0e5545f19d07116339b73f0719d88394bfd2 src/lib/io/kdirwatch.cpp cf9497ac1bc70c71d71491b760461346d9fcc0e1 src/lib/io/kdirwatch_p.h 37876e63c1058f41508c5e883599dac252a004a2 Diff: https://git.reviewboard.kde.org/r/117062/diff/ Testing --- Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117059: Explicitly state link interface for libKF5Activites
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/#review54131 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 25, 2014, 5:35 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/ --- (Updated March 25, 2014, 5:35 p.m.) Review request for KDE Frameworks and Plasma. Repository: kactivities Description --- Explicitly state link interface for libKF5Activites Diffs - src/lib/core/CMakeLists.txt 7edd2e34bc5ccec6ae526c0305d090afdaf9f306 Diff: https://git.reviewboard.kde.org/r/117059/diff/ Testing --- Compiles, installs. plasa-framework, kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/#review54132 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 25, 2014, 5:36 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/ --- (Updated March 25, 2014, 5:36 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Explicitly specify link interface libraries for libKF5PlasmaQuick The headers may not be public (yet?), but it doesn't hurt to have this stuff specified properly. Diffs - src/plasmaquick/CMakeLists.txt 83af22ecaf235c26115aa741d3c288bc71c269e9 Diff: https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117061: Explicitly state link interface for libKF5XsltKde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/#review54133 --- Ship it! Ship It! - Luigi Toscano On March 25, 2014, 5:44 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/ --- (Updated March 25, 2014, 5:44 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Explicitly state link interface for libKF5XsltKde Diffs - src/CMakeLists.txt ac144147e0a52c4b77bc0a28b89a953e08444d78 Diff: https://git.reviewboard.kde.org/r/117061/diff/ Testing --- Builds and installs. So does KIO (which apparently uses this library, according to the comment). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117065: Remove KDE4 TODO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117065/ --- Review request for KDE Frameworks. Repository: kcodecs Description --- Remove KDE4 TODO This was actually (at least mostly) done for KDE Platform 4. It's probably not worth changing any of the others and risk breaking code. Diffs - src/kcharsets.cpp 6bbbefc47535f38611839464824c6b537426c496 Diff: https://git.reviewboard.kde.org/r/117065/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #333
See http://build.kde.org/job/ktexteditor_master_qt5/333/changes Changes: [cullmann] make constructor explict for the helper class -- [...truncated 409 lines...] Removing autotests/input/indent/ruby/array8/actual Removing autotests/input/indent/ruby/array9/actual Removing autotests/input/indent/ruby/basic1/actual Removing autotests/input/indent/ruby/basic2/actual Removing autotests/input/indent/ruby/basic3/actual Removing autotests/input/indent/ruby/basic4/actual Removing autotests/input/indent/ruby/block-comment1/actual Removing autotests/input/indent/ruby/block-comment2/actual Removing autotests/input/indent/ruby/block-comment3/actual Removing autotests/input/indent/ruby/block-comment4/actual Removing autotests/input/indent/ruby/block-comment5/actual Removing autotests/input/indent/ruby/block-comment6/actual Removing autotests/input/indent/ruby/block-comment7/actual Removing autotests/input/indent/ruby/block-comment8/actual Removing autotests/input/indent/ruby/block01/actual Removing autotests/input/indent/ruby/block02/actual Removing autotests/input/indent/ruby/comment1/actual Removing autotests/input/indent/ruby/comment2/actual Removing autotests/input/indent/ruby/comment3/actual Removing autotests/input/indent/ruby/comment4/actual Removing autotests/input/indent/ruby/comment5/actual Removing autotests/input/indent/ruby/comment6/actual Removing autotests/input/indent/ruby/do1/actual Removing autotests/input/indent/ruby/do2/actual Removing autotests/input/indent/ruby/do3/actual Removing autotests/input/indent/ruby/do4/actual Removing autotests/input/indent/ruby/do5/actual Removing autotests/input/indent/ruby/do6/actual Removing autotests/input/indent/ruby/do7/actual Removing autotests/input/indent/ruby/empty-file1/actual Removing autotests/input/indent/ruby/hash1/actual Removing autotests/input/indent/ruby/hash10/actual Removing autotests/input/indent/ruby/hash11/actual Removing autotests/input/indent/ruby/hash12/actual Removing autotests/input/indent/ruby/hash16/actual Removing autotests/input/indent/ruby/hash17/actual Removing autotests/input/indent/ruby/hash18/actual Removing autotests/input/indent/ruby/hash19/actual Removing autotests/input/indent/ruby/hash2/actual Removing autotests/input/indent/ruby/hash20/actual Removing autotests/input/indent/ruby/hash21/actual Removing autotests/input/indent/ruby/hash22/actual Removing autotests/input/indent/ruby/hash3/actual Removing autotests/input/indent/ruby/hash4/actual Removing autotests/input/indent/ruby/hash5/actual Removing autotests/input/indent/ruby/hash6/actual Removing autotests/input/indent/ruby/hash7/actual Removing autotests/input/indent/ruby/hash8/actual Removing autotests/input/indent/ruby/hash9/actual Removing autotests/input/indent/ruby/heredoc1/actual Removing autotests/input/indent/ruby/heredoc2/actual Removing autotests/input/indent/ruby/heredoc3/actual Removing autotests/input/indent/ruby/heredoc4/actual Removing autotests/input/indent/ruby/heredoc5/actual Removing autotests/input/indent/ruby/heredoc6/actual Removing autotests/input/indent/ruby/if10/actual Removing autotests/input/indent/ruby/if11/actual Removing autotests/input/indent/ruby/if20/actual Removing autotests/input/indent/ruby/if21/actual Removing autotests/input/indent/ruby/if22/actual Removing autotests/input/indent/ruby/if30/actual Removing autotests/input/indent/ruby/if31/actual Removing autotests/input/indent/ruby/multiline1/actual Removing autotests/input/indent/ruby/multiline10/actual Removing autotests/input/indent/ruby/multiline2/actual Removing autotests/input/indent/ruby/multiline3/actual Removing autotests/input/indent/ruby/multiline4/actual Removing autotests/input/indent/ruby/multiline5/actual Removing autotests/input/indent/ruby/multiline6/actual Removing autotests/input/indent/ruby/multiline7/actual Removing autotests/input/indent/ruby/multiline8/actual Removing autotests/input/indent/ruby/multiline9/actual Removing autotests/input/indent/ruby/no-do1/actual Removing autotests/input/indent/ruby/no-do2/actual Removing autotests/input/indent/ruby/no-do3/actual Removing autotests/input/indent/ruby/no-do4/actual Removing autotests/input/indent/ruby/ops1/actual Removing autotests/input/indent/ruby/ops11/actual Removing autotests/input/indent/ruby/ops12/actual Removing autotests/input/indent/ruby/ops13/actual Removing autotests/input/indent/ruby/ops14/actual Removing autotests/input/indent/ruby/ops15/actual Removing autotests/input/indent/ruby/ops16/actual Removing autotests/input/indent/ruby/ops17/actual Removing autotests/input/indent/ruby/ops18/actual Removing autotests/input/indent/ruby/ops2/actual Removing autotests/input/indent/ruby/ops21/actual Removing autotests/input/indent/ruby/ops22/actual Removing autotests/input/indent/ruby/ops23/actual Removing autotests/input/indent/ruby/ops24/actual Removing autotests/input/indent/ruby/ops25/actual Removing autotests/input/indent/ruby/ops26/actual Removing
Re: Final kde-runtime splitting plan
El Dimarts, 25 de març de 2014, a les 16:18:22, Àlex Fiestas va escriure: Hi there Today Aleix and I are starting to split kde-runtime so we have gone through all the components again making sure that everything has a suitable destination. The result is this [1] wiki. Please, check that you are ok with the destination of each component and also check the things that have been targeted as **REMOVE** should be really removed (we believe so). Can you give a rationale of why we're removing the following things? kfile4 kio_cgi kio settings Cheers, Albert Cheers ! [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117061: Explicitly state link interface for libKF5XsltKde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/ --- (Updated March 25, 2014, 7:38 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Explicitly state link interface for libKF5XsltKde Diffs - src/CMakeLists.txt ac144147e0a52c4b77bc0a28b89a953e08444d78 Diff: https://git.reviewboard.kde.org/r/117061/diff/ Testing --- Builds and installs. So does KIO (which apparently uses this library, according to the comment). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117061: Explicitly state link interface for libKF5XsltKde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/#review54136 --- This review has been submitted with commit 5f6e0ccd85c155aea2444a465bbc4fb29326e3f6 by Alex Merry to branch master. - Commit Hook On March 25, 2014, 4:44 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117061/ --- (Updated March 25, 2014, 4:44 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Explicitly state link interface for libKF5XsltKde Diffs - src/CMakeLists.txt ac144147e0a52c4b77bc0a28b89a953e08444d78 Diff: https://git.reviewboard.kde.org/r/117061/diff/ Testing --- Builds and installs. So does KIO (which apparently uses this library, according to the comment). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117059: Explicitly state link interface for libKF5Activites
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/#review54137 --- This review has been submitted with commit 0b6cc52e8f3635d224cfd2dfeb860dad2ed5830d by Alex Merry to branch master. - Commit Hook On March 25, 2014, 5:35 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/ --- (Updated March 25, 2014, 5:35 p.m.) Review request for KDE Frameworks and Plasma. Repository: kactivities Description --- Explicitly state link interface for libKF5Activites Diffs - src/lib/core/CMakeLists.txt 7edd2e34bc5ccec6ae526c0305d090afdaf9f306 Diff: https://git.reviewboard.kde.org/r/117059/diff/ Testing --- Compiles, installs. plasa-framework, kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117059: Explicitly state link interface for libKF5Activites
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117059/ --- (Updated March 25, 2014, 7:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kactivities Description --- Explicitly state link interface for libKF5Activites Diffs - src/lib/core/CMakeLists.txt 7edd2e34bc5ccec6ae526c0305d090afdaf9f306 Diff: https://git.reviewboard.kde.org/r/117059/diff/ Testing --- Compiles, installs. plasa-framework, kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/ --- (Updated March 25, 2014, 7:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Explicitly specify link interface libraries for libKF5PlasmaQuick The headers may not be public (yet?), but it doesn't hurt to have this stuff specified properly. Diffs - src/plasmaquick/CMakeLists.txt 83af22ecaf235c26115aa741d3c288bc71c269e9 Diff: https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/#review54138 --- This review has been submitted with commit 9aabcbe067e7f506598d7de1a67867d27862fc2b by Alex Merry to branch master. - Commit Hook On March 25, 2014, 5:36 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117060/ --- (Updated March 25, 2014, 5:36 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Explicitly specify link interface libraries for libKF5PlasmaQuick The headers may not be public (yet?), but it doesn't hurt to have this stuff specified properly. Diffs - src/plasmaquick/CMakeLists.txt 83af22ecaf235c26115aa741d3c288bc71c269e9 Diff: https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #188
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/188/changes Changes: [alex.merry] Explicitly specify link interface libraries for libKF5PlasmaQuick -- Started by upstream project plasma-framework_master_qt5 build number 188 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson8632353502588275583.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework c884479..9aabcbe master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at c884479 don't lose the final position on showEvent Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@7fae3d8d Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 9aabcbe067e7f506598d7de1a67867d27862fc2b (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson1999100778474919664.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: kauth - Branch master qt5 - Branch stable ki18n - Branch master kwidgetsaddons - Branch master threadweaver - Branch master kwallet - Branch master kdnssd - Branch master polkit-qt-1 - Branch qt5 kdoctools - Branch master knotifications - Branch master kconfigwidgets - Branch master kidletime - Branch master kdesupport-svn - Branch master kcoreaddons - Branch master kiconthemes - Branch master kparts - Branch master kjobwidgets - Branch master kcrash - Branch master cmake - Branch master kio - Branch master extra-cmake-modules - Branch master kdbusaddons - Branch master kcodecs - Branch master sonnet - Branch master kactivities - Branch master kitemmodels - Branch master phonon - Branch master karchive - Branch master kunitconversion - Branch master kglobalaccel - Branch master kdeclarative - Branch master ktexteditor - Branch master kjs - Branch master kcompletion - Branch master ktextwidgets - Branch master kwindowsystem - Branch master kservice - Branch master kitemviews - Branch master solid - Branch master kross - Branch master kxmlgui - Branch master kconfig - Branch master kbookmarks - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:59 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #188
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/188/changes Changes: [alex.merry] Explicitly specify link interface libraries for libKF5PlasmaQuick -- Started by upstream project plasma-framework_master_qt5 build number 188 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson2568629977366255973.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 141df3d..9aabcbe master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 141df3d if a containment gets removed, remove from bookeeping Success build forhudson.tasks.Shell@7fae3d8d Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 9aabcbe067e7f506598d7de1a67867d27862fc2b (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson3539525632965494237.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: kauth - Branch master qt5 - Branch stable kdesupport-svn - Branch master ki18n - Branch master kwidgetsaddons - Branch master threadweaver - Branch master kwallet - Branch master polkit-qt-1 - Branch qt5 kdoctools - Branch master knotifications - Branch master kconfigwidgets - Branch master cmake - Branch master kcoreaddons - Branch master kiconthemes - Branch master kparts - Branch master kjobwidgets - Branch master kcrash - Branch master kio - Branch master kxmlgui - Branch master kdbusaddons - Branch master phonon - Branch master kcodecs - Branch master sonnet - Branch master kactivities - Branch master kitemmodels - Branch master kdnssd - Branch master karchive - Branch master kitemviews - Branch master kglobalaccel - Branch master extra-cmake-modules - Branch master kross - Branch master kservice - Branch master ktexteditor - Branch master kjs - Branch master kdeclarative - Branch master kcompletion - Branch master ktextwidgets - Branch master kbookmarks - Branch master kunitconversion - Branch master solid - Branch master kguiaddons - Branch master kconfig - Branch master kwindowsystem - Branch master kidletime - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:59 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #334
See http://build.kde.org/job/ktexteditor_master_qt5/334/changes Changes: [cullmann] fold extendedattribute = attribute -- [...truncated 409 lines...] Removing autotests/input/indent/ruby/array8/actual Removing autotests/input/indent/ruby/array9/actual Removing autotests/input/indent/ruby/basic1/actual Removing autotests/input/indent/ruby/basic2/actual Removing autotests/input/indent/ruby/basic3/actual Removing autotests/input/indent/ruby/basic4/actual Removing autotests/input/indent/ruby/block-comment1/actual Removing autotests/input/indent/ruby/block-comment2/actual Removing autotests/input/indent/ruby/block-comment3/actual Removing autotests/input/indent/ruby/block-comment4/actual Removing autotests/input/indent/ruby/block-comment5/actual Removing autotests/input/indent/ruby/block-comment6/actual Removing autotests/input/indent/ruby/block-comment7/actual Removing autotests/input/indent/ruby/block-comment8/actual Removing autotests/input/indent/ruby/block01/actual Removing autotests/input/indent/ruby/block02/actual Removing autotests/input/indent/ruby/comment1/actual Removing autotests/input/indent/ruby/comment2/actual Removing autotests/input/indent/ruby/comment3/actual Removing autotests/input/indent/ruby/comment4/actual Removing autotests/input/indent/ruby/comment5/actual Removing autotests/input/indent/ruby/comment6/actual Removing autotests/input/indent/ruby/do1/actual Removing autotests/input/indent/ruby/do2/actual Removing autotests/input/indent/ruby/do3/actual Removing autotests/input/indent/ruby/do4/actual Removing autotests/input/indent/ruby/do5/actual Removing autotests/input/indent/ruby/do6/actual Removing autotests/input/indent/ruby/do7/actual Removing autotests/input/indent/ruby/empty-file1/actual Removing autotests/input/indent/ruby/hash1/actual Removing autotests/input/indent/ruby/hash10/actual Removing autotests/input/indent/ruby/hash11/actual Removing autotests/input/indent/ruby/hash12/actual Removing autotests/input/indent/ruby/hash16/actual Removing autotests/input/indent/ruby/hash17/actual Removing autotests/input/indent/ruby/hash18/actual Removing autotests/input/indent/ruby/hash19/actual Removing autotests/input/indent/ruby/hash2/actual Removing autotests/input/indent/ruby/hash20/actual Removing autotests/input/indent/ruby/hash21/actual Removing autotests/input/indent/ruby/hash22/actual Removing autotests/input/indent/ruby/hash3/actual Removing autotests/input/indent/ruby/hash4/actual Removing autotests/input/indent/ruby/hash5/actual Removing autotests/input/indent/ruby/hash6/actual Removing autotests/input/indent/ruby/hash7/actual Removing autotests/input/indent/ruby/hash8/actual Removing autotests/input/indent/ruby/hash9/actual Removing autotests/input/indent/ruby/heredoc1/actual Removing autotests/input/indent/ruby/heredoc2/actual Removing autotests/input/indent/ruby/heredoc3/actual Removing autotests/input/indent/ruby/heredoc4/actual Removing autotests/input/indent/ruby/heredoc5/actual Removing autotests/input/indent/ruby/heredoc6/actual Removing autotests/input/indent/ruby/if10/actual Removing autotests/input/indent/ruby/if11/actual Removing autotests/input/indent/ruby/if20/actual Removing autotests/input/indent/ruby/if21/actual Removing autotests/input/indent/ruby/if22/actual Removing autotests/input/indent/ruby/if30/actual Removing autotests/input/indent/ruby/if31/actual Removing autotests/input/indent/ruby/multiline1/actual Removing autotests/input/indent/ruby/multiline10/actual Removing autotests/input/indent/ruby/multiline2/actual Removing autotests/input/indent/ruby/multiline3/actual Removing autotests/input/indent/ruby/multiline4/actual Removing autotests/input/indent/ruby/multiline5/actual Removing autotests/input/indent/ruby/multiline6/actual Removing autotests/input/indent/ruby/multiline7/actual Removing autotests/input/indent/ruby/multiline8/actual Removing autotests/input/indent/ruby/multiline9/actual Removing autotests/input/indent/ruby/no-do1/actual Removing autotests/input/indent/ruby/no-do2/actual Removing autotests/input/indent/ruby/no-do3/actual Removing autotests/input/indent/ruby/no-do4/actual Removing autotests/input/indent/ruby/ops1/actual Removing autotests/input/indent/ruby/ops11/actual Removing autotests/input/indent/ruby/ops12/actual Removing autotests/input/indent/ruby/ops13/actual Removing autotests/input/indent/ruby/ops14/actual Removing autotests/input/indent/ruby/ops15/actual Removing autotests/input/indent/ruby/ops16/actual Removing autotests/input/indent/ruby/ops17/actual Removing autotests/input/indent/ruby/ops18/actual Removing autotests/input/indent/ruby/ops2/actual Removing autotests/input/indent/ruby/ops21/actual Removing autotests/input/indent/ruby/ops22/actual Removing autotests/input/indent/ruby/ops23/actual Removing autotests/input/indent/ruby/ops24/actual Removing autotests/input/indent/ruby/ops25/actual Removing autotests/input/indent/ruby/ops26/actual Removing
Build failed in Jenkins: ktexteditor_master_qt5 #335
See http://build.kde.org/job/ktexteditor_master_qt5/335/changes Changes: [cullmann] extendedattribute folded, default style == normal is default -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/ktexteditor_master_qt5/ws/ Running Prebuild steps [ktexteditor_master_qt5] $ /bin/sh -xe /tmp/hudson8795762636612850489.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/ktexteditor 3368efa..b7badfe master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 3368efa fold extendedattribute = attribute Removing build/ Success build forhudson.tasks.Shell@66950fac Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/ktexteditor Checking out Revision b7badfe0b0d0c2b48e3a0873cb1fa6789f75c545 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [ktexteditor_master_qt5] $ /bin/sh -xe /tmp/hudson4983693285757869753.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: ktexteditor - Branch master == Build Dependencies: kcrash - Branch master knotifications - Branch master kdoctools - Branch master kbookmarks - Branch master kcodecs - Branch master extra-cmake-modules - Branch master kauth - Branch master qt5 - Branch stable kparts - Branch master kconfigwidgets - Branch master ktextwidgets - Branch master kwidgetsaddons - Branch master karchive - Branch master kio - Branch master cmake - Branch master kcoreaddons - Branch master kjobwidgets - Branch master solid - Branch master kglobalaccel - Branch master kdbusaddons - Branch master kxmlgui - Branch master sonnet - Branch master kiconthemes - Branch master phonon - Branch master kitemviews - Branch master kconfig - Branch master kguiaddons - Branch master kservice - Branch master polkit-qt-1 - Branch qt5 kcompletion - Branch master ki18n - Branch master kwindowsystem - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:41 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/ktexteditor_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project ktexteditor. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: ktexteditor_master_qt5 #335
See http://build.kde.org/job/ktexteditor_master_qt5/335/changes Changes: [cullmann] extendedattribute folded, default style == normal is default snip CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:41 (find_package) Hmm, somehow that is unrelated to my code work, or? I didn't touch the CMake find parts :/ Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : ktexteditor_master_qt5 #336
See http://build.kde.org/job/ktexteditor_master_qt5/336/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #189
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/189/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: ktexteditor_master_qt5 #335
On 25/03/14 19:52, Christoph Cullmann wrote: CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:41 (find_package) Hmm, somehow that is unrelated to my code work, or? I didn't touch the CMake find parts :/ Occasionally, Jenkins manages to grab a really old version of a repo when building on a slave that hasn't had an update in the meantime. I'm not sure why (it might be related to anongit). This happened to KNotifications, then things that depended on it broke. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: ktexteditor_master_qt5 #335
On 25/03/14 19:52, Christoph Cullmann wrote: CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:41 (find_package) Hmm, somehow that is unrelated to my code work, or? I didn't touch the CMake find parts :/ Occasionally, Jenkins manages to grab a really old version of a repo when building on a slave that hasn't had an update in the meantime. I'm not sure why (it might be related to anongit). This happened to KNotifications, then things that depended on it broke. ;) Somehow, looking at some errors on build.kde.org I am happy I use a homebrew buildfarm at work ;) Thanks for rebuild trigger! Looks my changes are OK, don't want to mess stuff up that short before the SIC freeze during my last minute fixes. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: ktexteditor_master_qt5 #335
On 25/03/14 20:16, Christoph Cullmann wrote: On 25/03/14 19:52, Christoph Cullmann wrote: CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.97.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.96.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:41 (find_package) Hmm, somehow that is unrelated to my code work, or? I didn't touch the CMake find parts :/ Occasionally, Jenkins manages to grab a really old version of a repo when building on a slave that hasn't had an update in the meantime. I'm not sure why (it might be related to anongit). This happened to KNotifications, then things that depended on it broke. ;) Somehow, looking at some errors on build.kde.org I am happy I use a homebrew buildfarm at work ;) Thanks for rebuild trigger! Looks my changes are OK, don't want to mess stuff up that short before the SIC freeze during my last minute fixes. Speaking of... can you resolve the ktexteditor entry at http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References ? It probably just needs a documentation update. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: ktexteditor_master_qt5 #335
Occasionally, Jenkins manages to grab a really old version of a repo when building on a slave that hasn't had an update in the meantime. I'm not sure why (it might be related to anongit). This happened to KNotifications, then things that depended on it broke. ;) Somehow, looking at some errors on build.kde.org I am happy I use a homebrew buildfarm at work ;) Thanks for rebuild trigger! Looks my changes are OK, don't want to mess stuff up that short before the SIC freeze during my last minute fixes. Speaking of... can you resolve the ktexteditor entry at http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References ? It probably just needs a documentation update. Alex Done I don't really understand the KTextEditor: kde4 is mentioned in a changelog comment, as I no longer find a changelog file ;) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117062: Remove KDirWatch::DNotify, it has been unused for ages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/#review54143 --- This review has been submitted with commit 20d9ba89d66fdbfc562a3bca9cdaab93fcf7a6ed by Alex Richardson to branch master. - Commit Hook On March 25, 2014, 5 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/ --- (Updated March 25, 2014, 5 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Remove KDirWatch::DNotify, it has been unused for ages Diffs - autotests/kdirwatch_unittest.cpp de92ac7e5030ac2a49ffbbc926a691a5830de761 src/lib/io/kdirwatch.h 353f0e5545f19d07116339b73f0719d88394bfd2 src/lib/io/kdirwatch.cpp cf9497ac1bc70c71d71491b760461346d9fcc0e1 src/lib/io/kdirwatch_p.h 37876e63c1058f41508c5e883599dac252a004a2 Diff: https://git.reviewboard.kde.org/r/117062/diff/ Testing --- Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117062: Remove KDirWatch::DNotify, it has been unused for ages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117062/ --- (Updated March 25, 2014, 9:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcoreaddons Description --- Remove KDirWatch::DNotify, it has been unused for ages Diffs - autotests/kdirwatch_unittest.cpp de92ac7e5030ac2a49ffbbc926a691a5830de761 src/lib/io/kdirwatch.h 353f0e5545f19d07116339b73f0719d88394bfd2 src/lib/io/kdirwatch.cpp cf9497ac1bc70c71d71491b760461346d9fcc0e1 src/lib/io/kdirwatch_p.h 37876e63c1058f41508c5e883599dac252a004a2 Diff: https://git.reviewboard.kde.org/r/117062/diff/ Testing --- Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Final kde-runtime splitting plan
Àlex Fiestas ha scritto: Hi there Today Aleix and I are starting to split kde-runtime so we have gone through all the components again making sure that everything has a suitable destination. The result is this [1] wiki. Please, check that you are ok with the destination of each component and also check the things that have been targeted as **REMOVE** should be really removed (we believe so). Why kreadconfig (which includes kreadconfig and kwriteconfig) is going to be in plasma-workspace? Isn't it useful for every KConfig-based component/application? Maybe kde cli tools could be the target... Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kio_master_qt5 #116
See http://build.kde.org/job/kio_master_qt5/116/changes Changes: [arichardson.kde] move uname() call into the !defined(Q_OS_WIN) block [arichardson.kde] Windows doesn't have utimes(), only utime() [arichardson.kde] move m_usercache and m_groupcache into #if HAVE_POSIX_ACL [arichardson.kde] kcookiejar: use WId instead of long/qulonglong -- [...truncated 896 lines...] Scanning dependencies of target kio_ftp Scanning dependencies of target kded_kssld Generating kuiserver_interface.cpp, kuiserver_interface.h Scanning dependencies of target kio_file Scanning dependencies of target kioslave [ 47%] [ 47%] Scanning dependencies of target kio_ghelp [ 48%] Scanning dependencies of target kio_help Generating ui_certificateparty.h [ 48%] [ 48%] Building CXX object src/kssld/CMakeFiles/kded_kssld.dir/kssld.cpp.o Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave.cpp.o Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o [ 48%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/ftp.cpp.o [ 48%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help.cpp.o Scanning dependencies of target kio_http [ 48%] [ 48%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/http.cpp.o Generating ui_sslinfo.h [ 48%] Generating ui_kpropertiesdesktopadvbase.h [ 49%] Generating ui_kpropertiesdesktopbase.h [ 50%] Generating fileundomanager_adaptor.moc [ 50%] Generating kuiserver_interface.moc [ 51%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave_automoc.cpp.o Linking CXX executable kioslave Scanning dependencies of target KF5KIOWidgets [ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/accessmanager.cpp.o [ 51%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/kio_http_cache_cleaner_automoc.cpp.o [ 51%] Built target kioslave [ 51%] [ 51%] [ 52%] Building CXX object src/kssld/CMakeFiles/kded_kssld.dir/kded_kssld_automoc.cpp.o Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpauthentication.cpp.o [ 52%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.o Linking CXX executable kio_http_cache_cleaner Linking CXX shared module kded_kssld.so [ 52%] [ 52%] Built target kded_kssld [ 52%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpfilter.cpp.o [ 52%] [ 52%] Built target kio_http_cache_cleaner [ 52%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/kio_ftp_automoc.cpp.o Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/kio_http_automoc.cpp.o [ 52%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o [ 53%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o [ 54%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_automoc.cpp.o [ 54%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_automoc.cpp.o [ 55%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_automoc.cpp.o Scanning dependencies of target dataprotocoltest Scanning dependencies of target kded_proxyscout Scanning dependencies of target globaltest Linking CXX shared module kio_ftp.so [ 56%] [ 57%] Linking CXX shared module kio_http.so Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.o [ 58%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/proxyscout.cpp.o Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.o [ 58%] Built target kio_ftp [ 58%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_automoc.cpp.o [ 58%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/accessmanagerreply_p.cpp.o [ 58%] Built target kio_http [ 58%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/script.cpp.o Linking CXX shared module kio_ghelp.so Linking CXX shared module kio_help.so [ 58%] Built target kio_ghelp [ 58%] [ 59%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/downloader.cpp.o Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/fileundomanager.cpp.o Linking CXX executable globaltest [ 59%] Built target kio_help [ 59%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/discovery.cpp.o Linking CXX shared module kio_file.so [ 59%] Built target globaltest [ 60%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/kded_proxyscout_automoc.cpp.o [ 60%] Built target kio_file [ 60%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_automoc.cpp.o Scanning dependencies of target jobremotetest [ 60%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.o [ 61%] [ 61%] Building CXX object
Jenkins build is back to normal : kio_master_qt5 #117
See http://build.kde.org/job/kio_master_qt5/117/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117071: Re-enable i18n in KPluginLoader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/ --- Review request for KDE Frameworks. Repository: kservice Description --- Re-enable i18n in KPluginLoader Diffs - src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e Diff: https://git.reviewboard.kde.org/r/117071/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117071: Re-enable i18n in KPluginLoader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/#review54148 --- Ship it! Who would have thought that TEMP_KF5_REENABLE would be a thing... I just checked and it's being used in kde4support as well. - Aleix Pol Gonzalez On March 26, 2014, 12:15 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/ --- (Updated March 26, 2014, 12:15 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Re-enable i18n in KPluginLoader Diffs - src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e Diff: https://git.reviewboard.kde.org/r/117071/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117071: Re-enable i18n in KPluginLoader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/#review54149 --- This review has been submitted with commit edab5fac772c73ca2dd5aa239cdb3e7544fd2098 by Alex Merry to branch master. - Commit Hook On March 26, 2014, 12:15 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/ --- (Updated March 26, 2014, 12:15 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Re-enable i18n in KPluginLoader Diffs - src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e Diff: https://git.reviewboard.kde.org/r/117071/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117071: Re-enable i18n in KPluginLoader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117071/ --- (Updated March 26, 2014, 2:20 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Re-enable i18n in KPluginLoader Diffs - src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e Diff: https://git.reviewboard.kde.org/r/117071/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117072/#review54150 --- Ship it! Yay unit tests!! - Aleix Pol Gonzalez On March 26, 2014, 2:22 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117072/ --- (Updated March 26, 2014, 2:22 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Add autotests for KPluginLoader and KPluginFactory Diffs - autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d autotests/kpluginfactorytest.cpp PRE-CREATION autotests/kpluginloadertest.cpp PRE-CREATION autotests/multiplugin.h PRE-CREATION autotests/multiplugin.cpp PRE-CREATION autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 autotests/unversionedplugin.h PRE-CREATION autotests/unversionedplugin.cpp PRE-CREATION autotests/versionedplugin.h PRE-CREATION autotests/versionedplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117072/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kservice_master_qt5 #84
See http://build.kde.org/job/kservice_master_qt5/84/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kservice_master_qt5 #85
See http://build.kde.org/job/kservice_master_qt5/85/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117074: KPluginFactory: remove argumented contructor and componentName()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/ --- Review request for KDE Frameworks. Repository: kservice Description --- KPluginFactory: remove argumented contructor and componentName() The Qt plugin system does not pass any arguments to its root object, so the component name will never get set in normal use. So there's no point having a method to return it, or in accepting it in the constructor. This was the oddly-ported version of a method that returned a KComponentData, and did not exist in kdelibs 4, hence it is being removed rather than deprecated. KDE_NO_DEPRECATED - KSERVICE_NO_DEPRECATED Diffs - src/services/kplugininfo.h 821a1b1fba3cb8624e415b6fd07f65ba2739b286 src/services/kplugininfo.cpp c48bd5e39ddb597256a269701cfd8efcc5328989 src/sycoca/ksycoca.h aa4b31c87c79e8182191851b161c0236e2fb35ce src/sycoca/ksycoca.cpp 0b014e0921e0f0a89dbd6ea8da3950c1f0bbcc25 src/kdeinit/ktoolinvocation.h 42d327fa8b651f7e1531505994d1fce202f437cd src/kdeinit/ktoolinvocation.cpp c0d5fde4e1791c114b13fe9f3ce21b97356c661b src/plugin/kexportplugin.h 15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd src/plugin/kpluginfactory.h 5d93b5f8f73ff49baabb516b991e96d6bd8a src/plugin/kpluginfactory.cpp cf71906d47aba4decca7d261d84ca1cb67913e7e src/plugin/kpluginfactory_p.h 103ae5029e508e22c99a727ef5b7568269ba7580 Diff: https://git.reviewboard.kde.org/r/117074/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/ --- (Updated March 26, 2014, 4:05 a.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- KPluginFactory: remove argumented contructor and componentName() The Qt plugin system does not pass any arguments to its root object, so the component name will never get set in normal use. So there's no point having a method to return it, or in accepting it in the constructor. This was the oddly-ported version of a method that returned a KComponentData, and did not exist in kdelibs 4, hence it is being removed rather than deprecated. KDE_NO_DEPRECATED - KSERVICE_NO_DEPRECATED Diffs - src/services/kplugininfo.h 821a1b1fba3cb8624e415b6fd07f65ba2739b286 src/services/kplugininfo.cpp c48bd5e39ddb597256a269701cfd8efcc5328989 src/sycoca/ksycoca.h aa4b31c87c79e8182191851b161c0236e2fb35ce src/sycoca/ksycoca.cpp 0b014e0921e0f0a89dbd6ea8da3950c1f0bbcc25 src/kdeinit/ktoolinvocation.h 42d327fa8b651f7e1531505994d1fce202f437cd src/kdeinit/ktoolinvocation.cpp c0d5fde4e1791c114b13fe9f3ce21b97356c661b src/plugin/kexportplugin.h 15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd src/plugin/kpluginfactory.h 5d93b5f8f73ff49baabb516b991e96d6bd8a src/plugin/kpluginfactory.cpp cf71906d47aba4decca7d261d84ca1cb67913e7e src/plugin/kpluginfactory_p.h 103ae5029e508e22c99a727ef5b7568269ba7580 Diff: https://git.reviewboard.kde.org/r/117074/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
