D5821: KViewStateSerializer: Fix crash when view is destroyed before state serializer
cfeck added a comment. ping? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5821 To: cfeck, #frameworks Cc: mlaurent
D6054: Use explicit flag values or explicit constructor instead of nullptr
This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6054?vs=15034=15063 REVISION DETAIL https://phabricator.kde.org/D6054 AFFECTED FILES autotests/kstartupinfo_unittest.cpp autotests/kwindowinfox11test.cpp autotests/kwindowsystemx11test.cpp autotests/netwininfotestwm.cpp src/kstartupinfo.cpp src/kwindowinfo.cpp src/kwindowinfo.h src/kwindowsystem.h src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/netwm.cpp src/platforms/xcb/netwm.h To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6054: Use explicit flag values or explicit constructor instead of nullptr
kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum values could be used instead of the default constructors. Would both be more expressive and also more balanced when used next to other flag sets assembled by the enum values (similar to Something to consider for the future perhaps... REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6047: WIP: Support XDG v6
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.h:80 > We need the serial Ids here, otherwise it's not very usable; especially as > the pong doesn't have an elapsed time. > > A kjob like API wrapping this might be perfect for here? so storing all the ids of pings in progress somewhere to make a more recent ping not cancel an older one still pending? > davidedmundson wrote in xdgshell_interface_p.h:41 > I don't understand this timer, all it's used for is for making us not emit a > pong if it comes in after a timeout? send ping, if a pong doesn't arrive after a timeout, consider it dead.. I copied it as-is from wl_shell iirc, so assumed this would be the expected behavior. REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: mart, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
Mac(/bug?) Control + Tab shortcut doesn't do anything
Hello, I just discovered that the Control+Tab and Control+Shift+Tab shortcuts don't work in KF5 applications on Mac: - In a pure Qt application I can assign Control+Tab to an action (using Qt::Meta+Qt::Key_Tab, evidently) and pressing the key combination will trigger the action. - In KF5, I can use for installed KActionCollection::setDefaultShortcut() to define the Control+Tab shortcut; it will show up but never trigger - trying to define it via the KXmlGui shortcut editor shows the same behaviour: it's like pressing the key combination is not detected. Qt is capable of detecting it, so one explanation would be that somewhere in KF5 code there is a filter on Qt::Meta+Qt::Key_Tab (because Command+Tab is a reserved shortcut bringing up the app switcher?). If that's the case, it should filter out Qt::CTRL+Qt::Key_Tab, but I cannot find any such filter. FWIW, the shortcut works just fine when I use Qt's XCB QPA plugin on Mac. Thanks, René
KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 11 - Fixed!
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 14:57:43 + Build duration: 7 min 24 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report85% (23/27)89% (297/332)89% (297/332)68% (33650/49567)52% (17099/33057)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (49/49)100% (49/49)93% (4300/4613)49% (2034/4130)autotests.src.vimode100% (16/16)100% (16/16)99% (5525/5569)54% (897/1658)src.buffer88% (15/17)88% (15/17)91% (1696/1869)76% (1294/1694)src.completion100% (16/16)100% (16/16)56% (1748/3102)43% (1192/2798)src.completion.expandingtree100% (5/5)100% (5/5)40% (184/464)22% (79/354)src.dialogs0% (0/4)0% (0/4)0% (0/875)0% (0/258)src.document100% (4/4)100% (4/4)58% (1876/3225)49% (1575/3238)src.export100% (4/4)100% (4/4)85% (106/125)70% (106/152)src.include.ktexteditor100% (14/14)100% (14/14)84% (206/245)63% (145/230)src.inputmode100% (8/8)100% (8/8)53% (172/325)45% (40/89)src.mode83% (5/6)83% (5/6)39% (165/427)37% (99/265)src.printing0% (0/4)0% (0/4)0% (0/885)0% (0/294)src.render100% (9/9)100% (9/9)75% (912/1217)67% (624/932)src.schema22% (2/9)22% (2/9)1% (21/1538)1% (7/697)src.script100% (14/14)100% (14/14)66% (700/1055)53% (295/556)src.search100% (7/7)100% (7/7)74% (1043/1418)63% (588/929)src.spellcheck71% (5/7)71% (5/7)28% (375/1336)25% (207/820)src.swapfile50% (1/2)50% (1/2)33%
KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 14:04:22 + Build duration: 6 min 32 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katesyntaxtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report81% (22/27)88% (290/330)88% (290/330)68% (33451/49515)51% (16877/32993)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (47/47)100% (47/47)93% (4252/4561)49% (1997/4066)autotests.src.vimode100% (16/16)100% (16/16)99% (5525/5569)54% (897/1658)src.buffer88% (15/17)88% (15/17)91% (1696/1869)76% (1294/1694)src.completion100% (16/16)100% (16/16)56% (1748/3102)43% (1192/2798)src.completion.expandingtree100% (5/5)100% (5/5)40% (184/464)22% (79/354)src.dialogs0% (0/4)0% (0/4)0% (0/875)0% (0/258)src.document100% (4/4)100% (4/4)58% (1859/3225)47% (1517/3238)src.export0% (0/4)0% (0/4)0% (0/125)0% (0/152)src.include.ktexteditor93% (13/14)93% (13/14)82% (202/245)63% (145/230)src.inputmode100% (8/8)100% (8/8)53% (172/325)45% (40/89)src.mode83% (5/6)83% (5/6)39% (165/427)37% (99/265)src.printing0% (0/4)0% (0/4)0% (0/885)0% (0/294)src.render100% (9/9)100% (9/9)75% (912/1217)67% (624/932)src.schema22% (2/9)22% (2/9)1% (21/1538)1% (7/697)src.script100% (14/14)100% (14/14)66% (700/1055)53% (295/556)src.search100% (7/7)100% (7/7)74% (1043/1418)63% (588/929)src.spellcheck71% (5/7)71% (5/7)28% (375/1336)25% (207/820)src.swapfile50% (1/2)50% (1/2)33%
Re: Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130138/ --- (Updated June 1, 2017, 1:27 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- Apparently, exceptions are disabled when building *.mm files. The alternative would be to set target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions") in order to force exception to be on for *.mm files. However, since exceptions aren't used in the code, let's just build without. Diffs - src/plugins/nsspellchecker/CMakeLists.txt f8c99d1ea080b1e28f60c57f8f588ed059c96711 Diff: https://git.reviewboard.kde.org/r/130138/diff/ Testing --- Thanks, Harald Fernengel
Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130139/ --- (Updated June 1, 2017, 1:27 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and René J.V. Bertin. Repository: kinit Description --- Seems that some versions of clang default to build *.mm files with exceptions disabled, so compilation would fail with: include/QtCore/qlist.h:522:9: error: cannot use 'throw' with exceptions disabled Diffs - src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 Diff: https://git.reviewboard.kde.org/r/130139/diff/ Testing --- Thanks, Harald Fernengel
Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files
> On May 25, 2017, 2:36 p.m., René J.V. Bertin wrote: > > See also https://phabricator.kde.org/D5972 agree that it should be fixed in ecm. Hope the fix can make it to the next release of kf5-ecm so I can remove my hack from homebrew - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130139/#review103244 --- On May 25, 2017, 11:37 a.m., Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130139/ > --- > > (Updated May 25, 2017, 11:37 a.m.) > > > Review request for KDE Frameworks and René J.V. Bertin. > > > Repository: kinit > > > Description > --- > > Seems that some versions of clang default to build *.mm files with > exceptions disabled, so compilation would fail with: > > include/QtCore/qlist.h:522:9: error: cannot use 'throw' with exceptions > disabled > > > Diffs > - > > src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 > > Diff: https://git.reviewboard.kde.org/r/130139/diff/ > > > Testing > --- > > > Thanks, > > Harald Fernengel > >
Re: Review Request 123075: do not require X11 on Mac OS X
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/ --- (Updated June 1, 2017, 1:20 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Michael Palimaka. Repository: kdesu Description --- do not require X11 on Mac OS X Diffs - CMakeLists.txt 9623483d6f11f9cdb7d7dc19decfd7cf5e86d079 Diff: https://git.reviewboard.kde.org/r/123075/diff/ Testing --- Thanks, Harald Fernengel
KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 8 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 12:53:43 + Build duration: 7 min 11 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katesyntaxtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report81% (22/27)88% (290/330)88% (290/330)68% (33453/49515)51% (16878/32993)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (47/47)100% (47/47)93% (4252/4561)49% (1997/4066)autotests.src.vimode100% (16/16)100% (16/16)99% (5525/5569)54% (897/1658)src.buffer88% (15/17)88% (15/17)91% (1696/1869)76% (1294/1694)src.completion100% (16/16)100% (16/16)56% (1750/3102)43% (1194/2798)src.completion.expandingtree100% (5/5)100% (5/5)40% (184/464)22% (79/354)src.dialogs0% (0/4)0% (0/4)0% (0/875)0% (0/258)src.document100% (4/4)100% (4/4)58% (1859/3225)47% (1517/3238)src.export0% (0/4)0% (0/4)0% (0/125)0% (0/152)src.include.ktexteditor93% (13/14)93% (13/14)82% (202/245)63% (145/230)src.inputmode100% (8/8)100% (8/8)53% (172/325)45% (40/89)src.mode83% (5/6)83% (5/6)39% (165/427)37% (99/265)src.printing0% (0/4)0% (0/4)0% (0/885)0% (0/294)src.render100% (9/9)100% (9/9)75% (912/1217)67% (624/932)src.schema22% (2/9)22% (2/9)1% (21/1538)1% (7/697)src.script100% (14/14)100% (14/14)66% (700/1055)53% (295/556)src.search100% (7/7)100% (7/7)74% (1043/1418)63% (588/929)src.spellcheck71% (5/7)71% (5/7)28% (375/1336)25% (207/820)src.swapfile50% (1/2)50% (1/2)33%
D6047: WIP: Support XDG v6
davidedmundson added a comment. Comments for Marco: INLINE COMMENTS > xdgshell_interface.h:80 > > +void ping(); > + We need the serial Ids here, otherwise it's not very usable; especially as the pong doesn't have an elapsed time. A kjob like API wrapping this might be perfect for here? > xdgshell_interface_p.h:41 > +quint32 pingSerial = 0; > +QScopedPointer pingTimer; > + I don't understand this timer, all it's used for is for making us not emit a pong if it comes in after a timeout? REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6053: Use explicit flag values or explicit constructor instead of nullptr
This revision was automatically updated to reflect the committed changes. Closed by commit R236:ff2e1d8e22fe: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6053?vs=15033=15047 REVISION DETAIL https://phabricator.kde.org/D6053 AFFECTED FILES src/kassistantdialog.h src/keditlistwidget.cpp src/kfontrequester.cpp src/kpagedialog.h src/kpagewidgetmodel.cpp src/kpassworddialog.h src/kruler.h src/kseparator.h To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk
D6053: Use explicit flag values or explicit constructor instead of nullptr
cfeck accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk
D6054: Use explicit flag values or explicit constructor instead of nullptr
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6053: Use explicit flag values or explicit constructor instead of nullptr
kossebau added inline comments. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, the constructor called would be (as before) `QFlags::QFlags(Zero zero = Q_NULLPTR)`, so still default to 0 internally, so with no flag set. (cmp. also https://code.woboq.org/qt5/qtbase/src/corelib/global/qflags.h.html#_ZN6QFlagsC1EMNS_7PrivateEi) REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk
D6053: Use explicit flag values or explicit constructor instead of nullptr
kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, `QFontDialog::FontDialogOptions` is a `QFlags<>` which has a default constructor which initializes all members. REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk
