KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 57 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/57/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 22 Nov 2017 06:48:59 + Build duration: 1 hr 5 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest
KDE CI: Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.9 - Build # 27 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20WindowsMSVCQt5.9/27/ Project: Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 22 Nov 2017 06:48:59 + Build duration: 43 min and counting JUnit Tests Name: (root) Failed: 9 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kdatetimetestFailed: TestSuite.kdebug_unittestFailed: TestSuite.kdelibs4support-klocaletestFailed: TestSuite.klibloadertestFailed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstestFailed: TestSuite.ktimezonestestFailed: TestSuite.kuniqueapptestFailed: TestSuite.kurltest
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 22 Nov 2017 06:48:59 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kurltest
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 22 Nov 2017 06:48:59 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
D8791: Avoid inconsistent passworddialog
ngraham added a comment. @dfaure, does this look sane and sensible to you? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8791 To: cryptodude, dfaure, cfeck, ngraham Cc: ngraham, #frameworks
D8098: Strip down and re-write the baloo tags KIO slave
smithjd marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham
D8098: Strip down and re-write the baloo tags KIO slave
smithjd updated this revision to Diff 22712. smithjd added a comment. Make work with kioclient. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22107=22712 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.kde.org/D8098 AFFECTED FILES src/kioslaves/tags/kio_tags.cpp src/kioslaves/tags/kio_tags.h src/kioslaves/tags/tags.protocol To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham
D8098: Strip down and re-write the baloo tags KIO slave
smithjd retitled this revision from "Strip down and re-write the tags KIO slave." to "Strip down and re-write the baloo tags KIO slave". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham
KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 48 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/48/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 18:35:12 + Build duration: 4 hr 3 min and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.kateindenttest_testRubyFailed: TestSuite.katetextbuffertestFailed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_keys
D8862: Extend KFilePlacesModel API
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.cpp:913
>
> +bool KFilePlacesModel::movePlace(int row, int before)
> +{
This should get its own unittest, especially since there are lots of edge cases.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mwolff, dfaure, ngraham, #frameworks
D8862: Extend KFilePlacesModel API
dfaure added a comment.
This seems to be bundling several unrelated additions into the same commit?
Please have one commit per feature / change / addition.
I know that phabricator makes it difficult to have one review per commit, but
at least the commits should be separate.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:893
> +
> +QCOMPARE(expectedScheme, convertedUrl.scheme());
> +QCOMPARE(expectedUrl, convertedUrl);
expectedScheme is part of the expectedUrl already, so I don't see much point in
this separate data column and check.
> kfileplacesmodel.cpp:933
> +
> +before = before == -1 ? d->items.count() : before;
> +
This would fit better in the if/else above.
Just do `before = d->items.count()` in the if (before == -1) case, no need for
the ternary operator nor the no-op (before = before).
> kfileplacesmodel.cpp:935
> +
> +if (row == before || row + 1 == before) {
> +return false;
Can you explain this condition? I understand the idea of an early exit if
nothing to do, but I'm surprised that two different values of `before` would
lead to "nothing to do".
There is only one current position
> kfileplacesmodel.h:52
> +GroupRole = 0x0a5b64ee,
> +IconNameRole = 0x00a45c00
> };
///< @since 5.41
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mwolff, dfaure, ngraham, #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
dfaure added a comment. Relative completions in KUrlCompletion defaults to $HOME but that can be configured with KUrlCompletion::setDir. Maybe KUrlNavigator should get a setter too, so that apps can set a base directory that makes sense to them? They have more context for setting a correct base dir (e.g. an image app would set the Pictures dir, dolphin can set the currently viewed directory, etc.) Note: I am very much against using the working directory (as in QDir::currentPath()), because the concept of "working directory" makes little sense in most graphical applications (you don't see it, you can't change it...) and is just an artefact of how the application was launched. IMHO that's even worse than the home dir as base ;-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.9 - Build # 17 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.9/17/ Project: Frameworks krunner kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 17:51:24 + Build duration: 3 hr 58 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest
D7660: Fix a regression caused by changing backspace key behavior
cullmann added a comment. If I don't misread the current diff, all things got done. Can you commit or shall I do so for you? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D7660: Fix a regression caused by changing backspace key behavior
cullmann accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D8862: Extend KFilePlacesModel API
renatoo updated this revision to Diff 22703. renatoo added a comment. Created a public function 'moveItem' to be used by external apps REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8862?vs=22673=22703 REVISION DETAIL https://phabricator.kde.org/D8862 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h src/filewidgets/kfileplacesview.cpp To: renatoo, dfaure, mwolff Cc: mwolff, dfaure, ngraham, #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
emateli updated this revision to Diff 22702. emateli added a comment. - remove QDir::homePath + minor code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8920?vs=22671=22702 BRANCH relative-files REVISION DETAIL https://phabricator.kde.org/D8920 AFFECTED FILES autotests/kurlnavigatortest.cpp src/filewidgets/kurlnavigator.cpp src/widgets/kurifilter.cpp To: emateli, #frameworks, dfaure Cc: #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 47 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/47/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 13:09:37 + Build duration: 5 hr 25 min and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.kateindenttest_testRubyFailed: TestSuite.katetextbuffertestFailed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_keys
KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.9 - Build # 16 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.9/16/ Project: Frameworks krunner kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 13:01:42 + Build duration: 4 hr 48 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest
KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 30 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.9/30/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 21 Nov 2017 12:06:41 + Build duration: 5 hr 32 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kcolorbuttontest
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 101 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/101/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 21 Nov 2017 13:09:37 + Build duration: 24 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.katesyntaxtest
D8925: Don't do unnecessary QString allocations to convert parts of it into strings
This revision was automatically updated to reflect the committed changes. Closed by commit R282:9eb778022c36: Dont do unnecessary QString allocations to convert parts of it into strings (authored by apol). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8925?vs=22691=22694 REVISION DETAIL https://phabricator.kde.org/D8925 AFFECTED FILES src/manager.cpp To: apol, #frameworks, jgrulich
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Tue, 21 Nov 2017 13:09:37 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report82% (23/28)89% (299/337)89% (299/337)68% (33701/49230)52% (17514/33918)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (49/49)100% (49/49)93% (4290/4627)49% (2110/4316)autotests.src.vimode88% (14/16)88% (14/16)96% (5297/5530)51% (866/1698)src.buffer88% (15/17)88% (15/17)91% (1704/1881)77% (1326/1724)src.completion100% (16/16)100% (16/16)57% (1778/3116)43% (1242/2897)src.completion.expandingtree100% (5/5)100% (5/5)40% (186/461)22% (79/362)src.dialogs0% (0/4)0% (0/4)0% (0/827)0% (0/240)src.document100% (4/4)100% (4/4)59% (1880/3193)48% (1681/3485)src.export100% (4/4)100% (4/4)86% (107/125)69% (118/170)src.include.ktexteditor100% (14/14)100% (14/14)92% (227/248)65% (146/226)src.inputmode100% (8/8)100% (8/8)59% (178/301)44% (34/77)src.mode83% (5/6)83% (5/6)40% (170/420)37% (103/275)src.part0% (0/1)0% (0/1)0% (0/8)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/830)0% (0/296)src.render100% (9/9)100% (9/9)76% (922/1219)65% (617/944)src.schema22% (2/9)22% (2/9)1% (21/1501)1% (6/729)src.script100% (17/17)100% (17/17)70% (739/1057)59% (307/519)src.search100% (7/7)100% (7/7)73% (1099/1501)63% (609/965)src.spellcheck75%
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Tue, 21 Nov 2017 13:09:37 + Build duration: 7 min 26 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katefoldingtestFailed: TestSuite.katesyntaxtestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_view Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report82% (23/28)89% (299/337)89% (299/337)68% (33689/49224)52% (17514/33916)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (49/49)100% (49/49)93% (4279/4624)49% (2108/4316)autotests.src.vimode88% (14/16)88% (14/16)96% (5297/5530)51% (866/1698)src.buffer88% (15/17)88% (15/17)91% (1704/1881)77% (1326/1724)src.completion100% (16/16)100% (16/16)57% (1778/3116)43% (1242/2897)src.completion.expandingtree100% (5/5)100% (5/5)40% (186/461)22% (79/362)src.dialogs0% (0/4)0% (0/4)0% (0/827)0% (0/240)src.document100% (4/4)100% (4/4)59% (1880/3193)48% (1681/3485)src.export100% (4/4)100% (4/4)86% (107/125)69% (118/170)src.include.ktexteditor100% (14/14)100% (14/14)92% (227/248)65% (146/226)src.inputmode100% (8/8)100% (8/8)59% (178/301)44% (34/77)src.mode83% (5/6)83% (5/6)40% (170/420)37% (103/275)src.part0% (0/1)0% (0/1)0% (0/8)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/830)0% (0/296)src.render100% (9/9)100% (9/9)76% (922/1219)65% (617/944)src.schema22% (2/9)22% (2/9)1% (21/1501)1% (6/729)src.script100% (17/17)100% (17/17)70% (739/1057)59% (307/519)src.search100% (7/7)100% (7/7)73% (1099/1501)63% (609/965)src.spellcheck75%
KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Tue, 21 Nov 2017 13:01:42 + Build duration: 6 min 7 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report50% (2/4)57% (13/23)57% (13/23)29% (417/1449)21% (186/866)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests60% (3/5)60% (3/5)49% (53/109)23% (13/56)src91% (10/11)91% (10/11)31% (364/1163)25% (173/700)src.declarative0% (0/5)0% (0/5)0% (0/136)0% (0/106)tests0% (0/2)0% (0/2)0% (0/41)0% (0/4)
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 35 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/35/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 21 Nov 2017 13:01:42 + Build duration: 3 min 46 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertest
KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks krunner kf5-qt5 SUSEQt5.7 Date of build: Tue, 21 Nov 2017 13:01:42 + Build duration: 1 min 43 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report50% (2/4)57% (13/23)57% (13/23)29% (417/1449)21% (186/866)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests60% (3/5)60% (3/5)49% (53/109)23% (13/56)src91% (10/11)91% (10/11)31% (364/1163)25% (173/700)src.declarative0% (0/5)0% (0/5)0% (0/136)0% (0/106)tests0% (0/2)0% (0/2)0% (0/41)0% (0/4)
D8925: Don't do unnecessary QString allocations to convert parts of it into strings
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D8925 To: apol, #frameworks, jgrulich
D8436: use a single QML engine
This revision was automatically updated to reflect the committed changes. Closed by commit R296:fcecbc5c67f7: use a single QML engine (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21224=22693 REVISION DETAIL https://phabricator.kde.org/D8436 AFFECTED FILES src/quickaddons/configmodule.cpp To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8436: use a single QML engine
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH arcpatch-D8436 REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8923: Offer QWindow API for KJobWidgets:: decorators
kfunk added inline comments. INLINE COMMENTS > apol wrote in kjobwidgets.cpp:67 > Note I didn't change any code, I just moved it around. > > Removing the cast still seems to work, so I'll do that. > Note I didn't change any code, I just moved it around. Whoops, sorry. Didn't notice. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D8923 To: apol, #frameworks Cc: kfunk
D8925: Don't do unnecessary QString allocations to convert parts of it into strings
apol created this revision. apol added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. REVISION SUMMARY Don't pass unnecessary variable to lambda REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D8925 AFFECTED FILES src/manager.cpp To: apol, #frameworks, jgrulich
D8851: Set enable_blur_behind hint on demand.
This revision was automatically updated to reflect the committed changes. Closed by commit R236:5491f35c32c2: Set enable_blur_behind hint on demand. (authored by davidedmundson). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8851?vs=22475=22690 REVISION DETAIL https://phabricator.kde.org/D8851 AFFECTED FILES src/ktooltipwidget.cpp To: davidedmundson, elvisangelaccio, broulik Cc: #frameworks
D8923: Offer QWindow API for KJobWidgets:: decorators
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > kfunk wrote in kjobwidgets.cpp:67 > `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef > QT_PREPEND_NAMESPACE(quintptr) WId;` > > Besides: `QVariant::fromValue(window->winId())` should work just fine, or? Note I didn't change any code, I just moved it around. Removing the cast still seems to work, so I'll do that. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D8923 To: apol, #frameworks Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
apol updated this revision to Diff 22686. apol marked an inline comment as done. apol added a comment. Remove cast REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22685=22686 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
kfunk added inline comments.
INLINE COMMENTS
> kjobwidgets.cpp:67
> +if (window) {
> +job->setProperty("window-id",
> QVariant::fromValue(qptrdiff(window->winId(;
> +}
`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef
QT_PREPEND_NAMESPACE(quintptr) WId;`
Besides: `QVariant::fromValue(window->winId())` should work just fine, or?
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D8923
To: apol, #frameworks
Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
apol updated this revision to Diff 22685. apol added a comment. Better API REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22684=22685 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks
D8923: Offer QWindow API for KJobWidgets:: decorators
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY This way we can do the same with non-widget windows REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I like the use of the 3-args QUrl::fromUserInput, I added it to Qt for such purposes. I don't like the hardcoded QDir::homePath(), this has to be done better... In KUrlNavigator it could be a setter. In KUriFilter, I would rather not do it there, but handle that in the caller, if possible? INLINE COMMENTS > kurlnavigatortest.cpp:216 > > +m_navigator->setHomeUrl(QDir::homePath()); > m_navigator->setLocationUrl(QUrl()); Does this line have any effect? This is only for the "go home" functionality, says the API docs, not for resolving relative paths, right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
