KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/25/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 04:03:10 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 04:03:30 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 04:03:10 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/81/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 04:03:21 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 04:03:10 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/21/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 04:03:30 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/40/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 04:02:55 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 04:02:50 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/21/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 04:03:30 +
 Build duration:
6 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/38/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 04:02:55 +
 Build duration:
7 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/30/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 04:02:50 +
 Build duration:
6 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 04:02:55 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 02:19:04 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/35/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 02:19:04 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 02:19:04 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/12/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 01:48:08 +
 Build duration:
5 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/57)30%
(17/57)21%
(443/2102)21%
(259/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)60%
(112/188)src100%
(8/8)100%
(8/8)68%
(205/302)47%
(111/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
(6/10)tests0%
 

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/12/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 01:48:08 +
 Build duration:
3 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/13/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 01:48:08 +
 Build duration:
2 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/57)30%
(17/57)21%
(443/2102)21%
(264/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)68%
(205/302)47%
(111/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
(6/10)tests0%

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 14 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/14/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 29 Jan 2018 00:16:13 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/11/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 29 Jan 2018 00:16:13 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/11/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Jan 2018 00:16:13 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/57)30%
(17/57)21%
(431/2102)20%
(249/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)90%
(139/155)55%
(103/188)src100%
(8/8)100%
(8/8)68%
(204/302)47%
(110/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
   

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 12 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/12/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 29 Jan 2018 00:16:18 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/57)30%
(17/57)21%
(431/2102)20%
(249/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)90%
(139/155)55%
(103/188)src100%
(8/8)100%
(8/8)68%
(204/302)47%
(110/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
  

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[René J . V . Bertin]

rjvbb added a comment.


  >   In the code shown by this patch ;) Line 80.
  
  Right. Doh. The line that causes other side-effects when you comment it out :)
  
  >   But the test you suggested that I do above is further proof anyhow.
  
  
  
  >   
  >   But even without setStyleName call (i.e. with your patch) I get the bug, 
due to call to QFont::fromString.
  
  That's the problem with the styleName: once you caught one it's almost 
impossible to get rid of in code. You can set an empty styleName, but that 
doesn't restore the pre-styleName state completely. The only safe way I know of 
is to convert to string, remove the stylename and recreate a QFont fromString, 
or write out the equivalent set of operations like I did for QtCurve.
  
  Still, not setting style names in the platform plugin, AND taking care not to 
set it in KFontRequester should improve the situation - but it will not take 
care of your tainted settings files for you, of course. :)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 13 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/13/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 28 Jan 2018 22:24:47 +
 Build duration:
8 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 95.35 KB...]-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Could not set up the appstream test. appstreamcli is missing.-- Found KF5CoreAddons: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found Gettext: C:/CM/msvc2017x64d/dev-utils/bin/msgmerge.exe  -- Found PythonInterp: C:/Program Files/Python36-32/python.exe (found version "3.6.2") -- Found KF5I18n: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5Config: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found suitable version "5.43.0", minimum required is "5.7.0") found components:  CoreAddons I18n Config -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- qmlplugindump failed for Ubuntu.OnlineAccounts.-- Could NOT find Ubuntu.OnlineAccounts-QMLModule (missing: Ubuntu.OnlineAccounts-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kdeconnect.-- Could NOT find org.kde.kdeconnect-QMLModule (missing: org.kde.kdeconnect-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kquickcontrolsaddons.-- Could NOT find org.kde.kquickcontrolsaddons-QMLModule (missing: org.kde.kquickcontrolsaddons-QMLModule_FOUND) CMake Warning at src/plugins/CMakeLists.txt:28 (find_package):  By not providing "FindKAccounts.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package configuration file provided by  "KAccounts", but CMake did not find one.  Could not find a package configuration file provided by "KAccounts" with  any of the following names:KAccountsConfig.cmakekaccounts-config.cmake  Add the installation prefix of "KAccounts" to CMAKE_PREFIX_PATH or set  "KAccounts_DIR" to a directory containing one of the above files.  If  "KAccounts" provides a separate development package or SDK, be sure it has  been installed.CMake Warning at src/plugins/phabricator/CMakeLists.txt:3 (message):  The phabricator plugin depends on having the 'arc' script available in the  PATH-- The following REQUIRED packages have been found: * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- The following OPTIONAL packages have not been found: * KAccounts   Used to find your system-wide defined, for now only for YouTube.-- Configuring doneCMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/10/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Jan 2018 22:24:47 +
 Build duration:
2 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 108.59 KB...]-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found suitable version "5.43.0", minimum required is "5.7.0") found components:  CoreAddons I18n Config -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- qmlplugindump failed for Ubuntu.OnlineAccounts.-- Could NOT find Ubuntu.OnlineAccounts-QMLModule (missing: Ubuntu.OnlineAccounts-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kdeconnect.-- Could NOT find org.kde.kdeconnect-QMLModule (missing: org.kde.kdeconnect-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kquickcontrolsaddons.-- Could NOT find org.kde.kquickcontrolsaddons-QMLModule (missing: org.kde.kquickcontrolsaddons-QMLModule_FOUND) -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") Merging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/youtube/google-youtube.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/youtube/google-youtube.serviceMerging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/twitter-microblog.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/twitter-microblog.serviceMerging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/nextcloud/nextcloud-upload.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/nextcloud/nextcloud-upload.serviceCMake Warning at src/plugins/phabricator/CMakeLists.txt:3 (message):  The phabricator plugin depends on having the 'arc' script available in the  PATH-- The following OPTIONAL packages have been found: * KAccounts   Used to find your system-wide defined, for now only for YouTube.-- The following REQUIRED packages have been found: * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * PkgConfig * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D9070#197332, @rjvbb wrote:
  
  > What happens when you remove the `,Regular`
  
  
  That fixes the problem indeed.
  
  >>   Workaround: enabling the line that calls 
QApplication::setDesktopSettingsAware(false).
  >>   Proof that this code is guilty: commenting out the fromString line makes 
it work, too.
  > 
  > Which line is that, where?
  
  In the code shown by this patch ;) Line 80.
  But the test you suggested that I do above is further proof anyhow.
  
  >>   What really confuses me is: why isn't it all set up so that this 
platform-plugin code provides *default* fonts, and so that what apps do 
overrides that?
  > 
  > That is what used to be the case, and that's why I think the commit that 
added the setStyleName call to kfontsettingsdata.cpp ought to be reverted. (I 
haven't gone back to re-read the commit message, but IIRC it was mostly made to 
align with the way fonts are saved, without questioning whether they should 
always be saved like that.)
  
  But even without setStyleName call (i.e. with your patch) I get the bug, due 
to call to QFont::fromString.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 11 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/11/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 28 Jan 2018 22:24:47 +
 Build duration:
1 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 127.81 KB...] * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * PkgConfig * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Warning (dev) in src/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/qrc_standard-plugin-types.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Warning (dev) in src/widgets/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/widgets/qrc_purposewidgets-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning (dev) in tests/tool/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/tests/tool/qrc_sharetool-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/10/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 28 Jan 2018 22:24:47 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 102.94 KB...] * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * PkgConfig * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Warning (dev) in src/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/qrc_standard-plugin-types.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Warning (dev) in src/widgets/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/widgets/qrc_purposewidgets-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning (dev) in tests/tool/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/tests/tool/qrc_sharetool-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

save and restore the geometry of KMainWindow

[Alexander Semke]

Hi,

KMainWindow takes care of saving/restoring the state of the main window, 
menus and toolbars.
Also, the size of the main window is correctly stored and restored. 
However, I don't see how
to save and restore the position of the main window. I checked couple of 
KDE programs
like dolphin, konsole, etc. - nothing restores the last window position 
correctly. I also tried to
to do saveGeometry() to KConfigGroup in the destructor and to 
restoreGeometry() in
the constructor but this doesn't seem to work. Is this because of the 
window manager ignoring
the geometry hints as mentioned in 
http://doc.qt.io/qt-5/application-windows.html#window-geometry ?


Can somebody point to an application doing this correctly?

Thanks and Regards,
Alexander

D9550: Don't set the LD_LIBRARY_PATH in prefix.sh

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:34babd2ffc86: Dont set the LD_LIBRARY_PATH in 
prefix.sh (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9550?vs=24473=26159

REVISION DETAIL
  https://phabricator.kde.org/D9550

AFFECTED FILES
  kde-modules/prefix.sh.cmake

To: apol, #frameworks, dfaure, ngraham, graesslin
Cc: graesslin, ngraham, #build_system, michaelh

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/12/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 28 Jan 2018 22:15:42 +
 Build duration:
5 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 100.10 KB...]-- Found KF5I18n: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5Config: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found suitable version "5.43.0", minimum required is "5.7.0") found components:  CoreAddons I18n Config -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- qmlplugindump failed for Ubuntu.OnlineAccounts.-- Could NOT find Ubuntu.OnlineAccounts-QMLModule (missing: Ubuntu.OnlineAccounts-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kdeconnect.-- Could NOT find org.kde.kdeconnect-QMLModule (missing: org.kde.kdeconnect-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kquickcontrolsaddons.-- Could NOT find org.kde.kquickcontrolsaddons-QMLModule (missing: org.kde.kquickcontrolsaddons-QMLModule_FOUND) CMake Warning at src/plugins/CMakeLists.txt:28 (find_package):  By not providing "FindKAccounts.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package configuration file provided by  "KAccounts", but CMake did not find one.  Could not find a package configuration file provided by "KAccounts" with  any of the following names:KAccountsConfig.cmakekaccounts-config.cmake  Add the installation prefix of "KAccounts" to CMAKE_PREFIX_PATH or set  "KAccounts_DIR" to a directory containing one of the above files.  If  "KAccounts" provides a separate development package or SDK, be sure it has  been installed.CMake Warning at src/plugins/phabricator/CMakeLists.txt:3 (message):  The phabricator plugin depends on having the 'arc' script available in the  PATH-- The following REQUIRED packages have been found: * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- The following OPTIONAL packages have not been found: * KAccounts   Used to find your system-wide defined, for now only for YouTube.-- Configuring doneCMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error in src/CMakeLists.txt:  Cannot find source file:C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/src/standard-plugin-types.qrc  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/9/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Jan 2018 22:15:42 +
 Build duration:
4 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 112.40 KB...]-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found suitable version "5.43.0", minimum required is "5.7.0") found components:  CoreAddons I18n Config -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- qmlplugindump failed for Ubuntu.OnlineAccounts.-- Could NOT find Ubuntu.OnlineAccounts-QMLModule (missing: Ubuntu.OnlineAccounts-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kdeconnect.-- Could NOT find org.kde.kdeconnect-QMLModule (missing: org.kde.kdeconnect-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kquickcontrolsaddons.-- Could NOT find org.kde.kquickcontrolsaddons-QMLModule (missing: org.kde.kquickcontrolsaddons-QMLModule_FOUND) -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") Merging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/youtube/google-youtube.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/youtube/google-youtube.serviceMerging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/twitter-microblog.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/twitter-microblog.serviceMerging translations into /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/nextcloud/nextcloud-upload.service.CREATED /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/plugins/nextcloud/nextcloud-upload.serviceCMake Warning at src/plugins/phabricator/CMakeLists.txt:3 (message):  The phabricator plugin depends on having the 'arc' script available in the  PATH-- The following OPTIONAL packages have been found: * KAccounts   Used to find your system-wide defined, for now only for YouTube.-- The following REQUIRED packages have been found: * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * PkgConfig * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error in src/CMakeLists.txt:  Cannot find source file:/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/src/standard-plugin-types.qrc  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/10/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 28 Jan 2018 22:15:42 +
 Build duration:
2 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 128.63 KB...] * ECM (required version >= 5.40.0) * Qt5Qml * Qt5Gui * Qt5DBus * Qt5Widgets * Qt5Network * Qt5Test * Qt5 (required version >= 5.2) * Qt5Core * KF5CoreAddons (required version >= 5.7.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.7.0) * KF5Config (required version >= 5.7.0) * KF5 (required version >= 5.7.0) * PkgConfig * KF5KIO (required version >= 5.7.0)-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Warning (dev) in src/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/qrc_standard-plugin-types.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Warning (dev) in src/widgets/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/src/widgets/qrc_purposewidgets-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning (dev) in tests/tool/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build/tests/tool/qrc_sharetool-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/9/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 28 Jan 2018 22:15:42 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 109.36 KB...]-- The following RUNTIME packages have not been found: * Ubuntu.OnlineAccounts-QMLModule, Ubuntu.OnlineAccounts is a runtime dependency * org.kde.kdeconnect-QMLModule, org.kde.kdeconnect is a runtime dependency * org.kde.kquickcontrolsaddons-QMLModule, org.kde.kquickcontrolsaddons is a runtime dependency-- Configuring doneCMake Warning (dev) in src/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/qrc_standard-plugin-types.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at src/quick/CMakeLists.txt:3 (add_library):  Cannot find source file:/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/qrc_standard-plugin-types.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Warning (dev) in src/widgets/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/src/widgets/qrc_purposewidgets-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning (dev) in tests/tool/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build/tests/tool/qrc_sharetool-resources.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error in src/CMakeLists.txt:  Cannot find source file:/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/src/standard-plugin-types.qrc  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error in src/quick/CMakeLists.txt:  Cannot find source file:/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/src/quick/qmlfiles.qrc  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: purposequickpluginCMake Error: Cannot determine link language for target "purposequickplugin".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10167: No need to initialize m_usableAdapterwith nullptr

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D10167

To: aacid, dhaumann, drosca
Cc: drosca, #frameworks, michaelh

D10167: No need to initialize m_usableAdapterwith nullptr

[Albert Astals Cid]

aacid updated this revision to Diff 26156.
aacid retitled this revision from "Initialize m_usableAdapter with nullptr" to 
"No need to initialize m_usableAdapterwith nullptr".
aacid edited the summary of this revision.
aacid removed a subscriber: dhaumann.
aacid added a comment.


  update message

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10167?vs=26155=26156

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10167

AFFECTED FILES
  src/manager_p.cpp

To: aacid, dhaumann, drosca
Cc: drosca, #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10167

To: aacid, dhaumann, drosca
Cc: dhaumann, drosca, #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

[Albert Astals Cid]

aacid updated this revision to Diff 26155.
aacid added a comment.


  remove the line altogether

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10167?vs=26153=26155

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10167

AFFECTED FILES
  src/manager_p.cpp

To: aacid, dhaumann, drosca
Cc: dhaumann, drosca, #frameworks, michaelh

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

[Dominik Haumann]

dhaumann added a comment.


  +1, but someone else must approve.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10166

To: aacid
Cc: dhaumann, #frameworks, #build_system, michaelh

D10168: Use nullptr for passing a null pointer to crc32

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  I'm a bit unconvinced, wihtout it we get a warning if we enable 
-Wzero-as-null-pointer-constant
  but using Z_NULL seems to be more "what the library wants"
  
  If we don't want this, this would be a reason against enabling 
-Wzero-as-null-pointer-constant
  for all the frameworks as i've suggested in the other review

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10168

AFFECTED FILES
  src/kgzipfilter.cpp
  src/kzip.cpp

To: aacid
Cc: #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Since it is a shared pointer then it doesn't need explicit initialization and 
this line can just be removed.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D10167

To: aacid, dhaumann, drosca
Cc: dhaumann, drosca, #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10167

To: aacid, dhaumann
Cc: dhaumann, drosca, #frameworks, michaelh

D10167: Initialize m_usableAdapter with nullptr

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  instead of 0 since it's a [shared] pointer

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10167

AFFECTED FILES
  src/manager_p.cpp

To: aacid
Cc: drosca, #frameworks, michaelh

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

[Albert Astals Cid]

aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
aacid requested review of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10166

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: aacid
Cc: #frameworks, #build_system, michaelh

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26149.
michaelh added a comment.


  Change execution order in setFileItem

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26135=26149

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I don't feel confident approving the security-related fixes in here. Maybe 
Thiago or Oswald could have a look...

INLINE COMMENTS

> fdreceiver.cpp:61
>  }
> +::unlink(m_path.toStdString().c_str());
>  }

This will break if the path contains non-ascii characters.

Either use QFile::remove, or use a QByteArray (or std::string) everywhere to 
avoid a conversion from 16-bit to 8-bit, or third option, do the conversion 
properly here, using QFile::encodeName(m_path).

> sharefd_p.h:51
>  {
> -return reinterpret_cast();
> +return (strlen(addr.sun_path) > 0) ? reinterpret_cast sockaddr*>() : nullptr;
>  }

Is strlen needed? It seems to me that sun_path will be null if make_address 
failed, so a simple null-pointer check would be enough here. Plus I remember 
some implementations of strlen breaking on null pointers...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> filemetadataprovider.cpp:106
>  
> +
>  }

unrelated whitespace change

> filemetadataprovider.h:119
>  
> +
> +private:

unrelated whitespace change

REPOSITORY
  R824 Baloo Widgets

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26135.
michaelh added a comment.


  Correct yet another update error

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26131=26135

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/39/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Jan 2018 14:51:16 +
 Build duration:
8 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/34/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 28 Jan 2018 14:51:16 +
 Build duration:
8 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 28 Jan 2018 14:51:16 +
 Build duration:
6 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh updated this revision to Diff 26134.
michaelh added a comment.


  Correct typo

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10105?vs=26132=26134

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10152: Match also spdx keys LGPL-2.1 & LGPL-2.1+

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:e5825110c889: Match also spdx keys LGPL-2.1  
LGPL-2.1+ (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10152?vs=26091=26133#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10152?vs=26091=26133

REVISION DETAIL
  https://phabricator.kde.org/D10152

AFFECTED FILES
  autotests/kaboutdatatest.cpp
  src/lib/kaboutdata.cpp

To: kossebau, davidedmundson, apol
Cc: #frameworks, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh added a comment.


  @elvisangelaccio: Sorry for this updating mess. These nested branches are 
just too error-prone for me, because they look so similar. Won't do that again.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh updated this revision to Diff 26132.
michaelh marked an inline comment as done.
michaelh added a comment.


  Add Q_ASSERT

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10105?vs=26079=26132

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26131.

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26129=26131

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26129.
michaelh added a comment.


  Add Q_ASSERT

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26120=26129

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D8281: Allow to use IcoTool for Windows icons

[Aleix Pol Gonzalez]

apol added a comment.


  Hi, what happened with this?
  @vpinon were you able to look into @cgiboudeaux concerns?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8281

To: vpinon, dfaure, apol, kfunk, #windows
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> michaelh wrote in filemetadataprovider.cpp:141
> I've been thinking about this...
> 
> We already have guards against files.isEmpty() in
> 
>   355if (!urls.isEmpty()) {
> 
> and
> 
>   373  } else if (items.size() == 1)  {
> 
> Unless I got something wrong files cannot be empty at this point.
> Maybe it is wiser to clarify this with
> 
>   Q_ASSERT(!files.isEmpty)

Yeah I think you got it right. `fetchJob->data()` should not be empty as long 
as we passed a non-empty list of urls to `FileFetchJob`.

Which means an assert about this is a good idea, indeed.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10159: Highlight Khronos Collada and glTF files

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ddaac7d8c7dc: Highlight Khronos Collada and glTF files 
(authored by vkrause).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10159?vs=26118=26124

REVISION DETAIL
  https://phabricator.kde.org/D10159

AFFECTED FILES
  data/syntax/json.xml
  data/syntax/xml.xml

To: vkrause, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh

D10158: Fix ini highlighting of values containing ; or # characters

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:08f85b409b4c: Fix ini highlighting of values containing ; 
or # characters (authored by vkrause).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10158?vs=26116=26122

REVISION DETAIL
  https://phabricator.kde.org/D10158

AFFECTED FILES
  autotests/folding/test.ini.fold
  autotests/html/test.ini.html
  autotests/input/test.ini
  autotests/reference/test.ini.ref
  data/syntax/ini.xml

To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann
Cc: #frameworks, michaelh

D10158: Fix ini highlighting of values containing ; or # characters

[Hannah von Reth]

vonreth added a comment.


  yay thanks

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10158

To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann
Cc: #frameworks, michaelh

D10136: AppArmor: new keywords, improvements & fixes

[Nibaldo González]

nibags added a comment.


  Thanks!
  With (^|\s) I mean that it is not necessarily the first word of a line, 
rather after a space.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10136

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #framework_syntax_highlighting, #frameworks, michaelh, 
genethomas, cullmann, vkrause

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26120.
michaelh added a comment.


  Revert incorrect diff update

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26117=26120

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10158: Fix ini highlighting of values containing ; or # characters

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10158

To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann
Cc: #frameworks, michaelh

D10159: Highlight Khronos Collada and glTF files

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10159

To: vkrause, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[René J . V . Bertin]

rjvbb added a comment.


  >   Unfortunately, this patch doesn't fix it. The text still isn't bold.
  
  No, this patch is written to be as transparent as possible. It won't impose a 
stylename, but will not remove it either.
  
  What happens when you remove the `,Regular`, i.e.
  
[General]
font=Noto Sans,7,-1,5,50,0,0,0,0,0
  
  Normally you should get a bold font again then?
  
  >   Workaround: enabling the line that calls 
QApplication::setDesktopSettingsAware(false).
  >   Proof that this code is guilty: commenting out the fromString line makes 
it work, too.
  
  Which line is that, where?
  
  >   What really confuses me is: why isn't it all set up so that this 
platform-plugin code provides *default* fonts, and so that what apps do 
overrides that?
  
  That is what used to be the case, and that's why I think the commit that 
added the setStyleName call to kfontsettingsdata.cpp ought to be reverted. (I 
haven't gone back to re-read the commit message, but IIRC it was mostly made to 
align with the way fonts are saved, without questioning whether they should 
always be saved like that.)
  
  I'd be happy to modify the patch so it strips the style names from the 
initial-defaults table as well as the call to setStyleName(). I could even go 
so far as to add code that strips the styleName if the font can be represented 
without it - but this also has a side-effect.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26117.
michaelh added a comment.


  Apply suggested changes

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=26071=26117

BRANCH
  unittest

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/filemetadatawidgettest.cpp
  autotests/filemetadatawidgettest.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10159: Highlight Khronos Collada and glTF files

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  Those are XML and JSON respectively.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10159

AFFECTED FILES
  data/syntax/json.xml
  data/syntax/xml.xml

To: vkrause, #framework_syntax_highlighting
Cc: #frameworks, michaelh

D10135: Put built-in holiday definitions into qrc

[Dominik Haumann]

dhaumann added a comment.


  Ok, I can see that now ;) Thanks.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D10135

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D10158: Fix ini highlighting of values containing ; or # characters

[Volker Krause]

vkrause created this revision.
vkrause added reviewers: Framework: Syntax Highlighting, vonreth.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  ;/# are part of values, not start inline comments, at least not in general
  purpose ini files.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10158

AFFECTED FILES
  autotests/folding/test.ini.fold
  autotests/html/test.ini.html
  autotests/input/test.ini
  autotests/reference/test.ini.ref
  data/syntax/ini.xml

To: vkrause, #framework_syntax_highlighting, vonreth
Cc: #frameworks, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh marked 2 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataprovider.cpp:141
> Why not? `insertEditableData()` just sets some defaults, how is it related to 
> `files`?

I've been thinking about this...

We already have guards against files.isEmpty() in

  355if (!urls.isEmpty()) {

and

  373  } else if (items.size() == 1)  {

Unless I got something wrong files cannot be empty at this point.
Maybe it is wiser to clarify this with

  Q_ASSERT(!files.isEmpty)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10135: Put built-in holiday definitions into qrc

[Volker Krause]

vkrause added a comment.


  In https://phabricator.kde.org/D10135#197280, @dhaumann wrote:
  
  > - What's missing (or I miss something) is that it could be that entries 
exist twice, if in resource and on disk. Since this is not the case right now, 
this is probably not an issue.
  
  
  In that case we prefer the on-disk version, that's what the change in 
HolidayRegionPrivate does.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D10135

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  @genethomas Unfortunately we are so late with the review that your patch does 
not apply cleanly anymore. Could you update your patch?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8649

To: genethomas, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10135: Put built-in holiday definitions into qrc

[Dominik Haumann]

dhaumann added a comment.


  I'm late to the game, but in general looks good.
  
  Minor comments:
  
  - What's missing (or I miss something) is that it could be that entries exist 
twice, if in resource and on disk. Since this is not the case right now, this 
is probably not an issue.
  - holidays/holidays.qrc is manually maintained and not auto-generated. This 
is probably fine as well since we don't expect as many changes as e.g. in the 
syntax-highlighting repo...

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D10135

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D10136: AppArmor: new keywords, improvements & fixes

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c0f5d9ec6eec: AppArmor: new keywords, improvements  
fixes (authored by nibags, committed by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10136?vs=26036=26114

REVISION DETAIL
  https://phabricator.kde.org/D10136

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #framework_syntax_highlighting, #frameworks, michaelh, 
genethomas, cullmann, vkrause

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/33/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 28 Jan 2018 11:02:05 +
 Build duration:
6 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

D10136: AppArmor: new keywords, improvements & fixes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good and test passes. Just one minor comment that is not really 
relevant for now - will push in a second.

INLINE COMMENTS

> apparmor.xml:709
>attribute="Profile Head" String="profile_head"/>
> -  attribute="Profile Head" String="(\s|^\s*)\^(?=\S)"/>  
> +  attribute="Profile Head" String="(^|\s)\^(?=\S)"/>
>String="profile_options"/>

Are you looking for \b when using (^|\s) ? Or maybe even for 
firstNonSpace="true" ?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  apparmor-v4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10136

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #framework_syntax_highlighting, #frameworks, michaelh, 
genethomas, cullmann, vkrause

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 28 Jan 2018 11:02:05 +
 Build duration:
6 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/38/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Jan 2018 11:02:06 +
 Build duration:
3 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

D10155: Use the much faster urls() method from QMimeData

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:18e4d245d3d5: Use the much faster urls() method from 
QMimeData (authored by jtamate).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10155?vs=26110=26113

REVISION DETAIL
  https://phabricator.kde.org/D10155

AFFECTED FILES
  src/lib/io/kurlmimedata.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10155: Use the much faster urls() method from QMimeData

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  paste (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10155

To: jtamate, #frameworks, dfaure
Cc: michaelh

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[David Faure]

dfaure added a comment.


  I've been hitting a very similar bug where a Qt app was trying to use a bold 
font, and this had no effect when running in a plasma workspace, because of 
this code in kfontsettingsdata.cpp.
  
  Testcase (couldn't be simpler...) 
http://www.davidfaure.fr/2018/qlabel_inherited_font.cpp
  with this in ~/.config/kdeglobals:
  
[General]
font=Noto Sans,7,-1,5,50,0,0,0,0,0,Regular
  
  Unfortunately, this patch doesn't fix it. The text still isn't bold.
  
  Workaround: enabling the line that calls 
QApplication::setDesktopSettingsAware(false).
  Proof that this code is guilty: commenting out the fromString line makes it 
work, too.
  
  What really confuses me is: why isn't it all set up so that this 
platform-plugin code provides *default* fonts, and so that what apps do 
overrides that? (sorry that I didn't dig as far as some of you guys did)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:137
> +
> +if (files.size() == 0) {
> +emit loadingFinished();

`files.isEmpty()`

> michaelh wrote in filemetadataprovider.cpp:141
> We can leave early here, I think. 
> Without a file
> 
>   149  insertEditableData() 
> 
> does not make much sense.

Why not? `insertEditableData()` just sets some defaults, how is it related to 
`files`?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10155: Use the much faster urls() method from QMimeData

[Jaime Torres Amate]

jtamate updated this revision to Diff 26110.
jtamate added a comment.


  - Use the much faster urls() method from QMimeData
  
  Using hasUrls() and fixed a typo in the comment

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10155?vs=26096=26110

BRANCH
  paste (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10155

AFFECTED FILES
  src/lib/io/kurlmimedata.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate updated this revision to Diff 26109.
jtamate added a comment.


  Reverting to first patch.
  
  The lambda syntax has some problems with private d_func pointers under dolphin
  
  Thread 1 "dolphin" received signal SIGSEGV, Segmentation fault.
  0x721b5b4c in KJob::d_func (this=0x4000) at 
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.h:651
  651 Q_DECLARE_PRIVATE(KJob)
  (gdb) where
  #0  0x721b5b4c in KJob::d_func (this=0x4000) at 
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.h:651
  #1  0x721b3a77 in KJob::totalAmount (this=0x4000, 
unit=KJob::Bytes) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:235
  #2  0x739a22f3 in KIO::SimpleJobPrivate::slotTotalSize 
(this=0xd4de80, size=2097152) at 
/g/5kde/frameworks/kio/src/core/simplejob.cpp:268
  #3  0x739a1332 in 
KIO::SimpleJobPrivate::::operator()(KIO::filesize_t) 
const (__closure=0xdd0bc0, size=2097152)
  
at /g/5kde/frameworks/kio/src/core/simplejob.cpp:153
  
  #4  0x739a4120 in QtPrivate::FunctorCall, 
QtPrivate::List, void, 
KIO::SimpleJobPrivate::start(KIO::Slave*):: 
>::call(KIO::SimpleJobPrivate:: &, void **) (f=..., 
arg=0x7fffcc50)
  
at /usr/include/qt5/QtCore/qobjectdefs_impl.h:130

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10124?vs=26047=26109

BRANCH
  start (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10124

AFFECTED FILES
  src/core/simplejob.cpp

To: jtamate, #frameworks
Cc: broulik, ngraham, anthonyfieroni, michaelh

D10155: Use the much faster urls() method from QMimeData

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Ah I guess it's faster because QMimeData skips the encoding/decoding via 
QByteArray when both drag and drop are in the same process? That's not 
something we can do ourselves (for the "kde uri list" mimetype), unless we call 
the protected QMimeData::retrieveData, I guess. Hmm.

INLINE COMMENTS

> kurlmimedata.cpp:76
>  if (ba.isEmpty()) {
>  ba = mimeData->data(QString::fromLatin1(secondMimeType));
> +// If extracting uris from test/uri-list, use the much faster 
> QMimeData method urls()

But then why call this at all, if you don't need the bytearray?
Just make it

  if (mimeData->hasUrls())

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10155

To: jtamate, #frameworks, dfaure
Cc: michaelh

D8532: [WIP] Restrict file extractor with Seccomp

[David Kahles]

davidk updated this revision to Diff 26108.
davidk added a comment.


  Update TODO items.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8532?vs=21469=26108

BRANCH
  seccomp

REVISION DETAIL
  https://phabricator.kde.org/D8532

AFFECTED FILES
  CMakeLists.txt
  cmake/FindSeccomp.cmake
  config.h.cmake
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/CMakeLists.txt
  src/file/extractor/autotests/seccomp_test.cpp
  src/file/extractor/main.cpp
  src/file/extractor/seccomp_filter.cpp
  src/file/extractor/seccomp_filter.h

To: davidk, apol, ossi
Cc: #frameworks, michaelh

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Indeed.
  
  Fixed in shared-mime-info 1.10 (commit 009f22a, 
https://bugs.freedesktop.org/show_bug.cgi?id=101667)
  
  Fix proposed for Qt: https://codereview.qt-project.org/218155

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8998: Add FindSeccomp to find-modules

[David Kahles]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c30802019895: Add FindSeccomp to find-modules (authored 
by davidk).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8998?vs=26106=26107

REVISION DETAIL
  https://phabricator.kde.org/D8998

AFFECTED FILES
  find-modules/FindSeccomp.cmake

To: davidk, graesslin, cgiboudeaux
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D8998: Add FindSeccomp to find-modules

[David Kahles]

davidk added a comment.


  Thanks for your review.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin, cgiboudeaux
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D8998: Add FindSeccomp to find-modules

[David Kahles]

davidk updated this revision to Diff 26106.
davidk added a comment.


  Fix version.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8998?vs=24751=26106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8998

AFFECTED FILES
  find-modules/FindSeccomp.cmake

To: davidk, graesslin, cgiboudeaux
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D8998: Add FindSeccomp to find-modules

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> FindSeccomp.cmake:21
> +#
> +# Since 5.42.0.
> +

5.44.0

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin, cgiboudeaux
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D8998: Add FindSeccomp to find-modules

[David Kahles]

davidk added a comment.


  @cgiboudeaux is it ready to go now?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin
Cc: cgiboudeaux, #frameworks, #build_system, michaelh

D10081: Don't assert if used incorrectly from dbus

[Martin Flöser]

graesslin updated this revision to Diff 26098.
graesslin added a comment.


  Remove the usless assert Roman found

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10081?vs=25895=26098

BRANCH
  dont-assert-on-dbus-misusage

REVISION DETAIL
  https://phabricator.kde.org/D10081

AFFECTED FILES
  src/runtime/component.cpp

To: graesslin, #frameworks
Cc: romangg, michaelh

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/37/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 28 Jan 2018 08:24:35 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33889/49378)52%
(17762/34216)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4381/4672)49%
(2166/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1781/3121)43%
(1245/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(887/1218)63%
(592/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

D10155: Use the much faster urls() method from QMimeData

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  When requesting a list of text/uri-list, use the much faster QMimeData
  urls() method.
  The unittests pass (the desktop: protocol) and
  CCBUG: 342056
  is half solved. The paste speed is as fast as drag in local files
  and with fish: files.
  The lock in X11 plasma or kwin still needs another patch.

TEST PLAN
  Select 2000 files in one folder, cut and paste them in another disk.

REPOSITORY
  R244 KCoreAddons

BRANCH
  paste (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10155

AFFECTED FILES
  src/lib/io/kurlmimedata.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/36/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Jan 2018 08:24:35 +
 Build duration:
7 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33874/49372)52%
(17761/34214)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4370/4669)49%
(2164/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(887/1218)63%
(592/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

D10145: Improve line height

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2d6a2b517868: improve line heigh computation try to avoid 
cutting of parts of glyphs (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10145?vs=26067=26095

REVISION DETAIL
  https://phabricator.kde.org/D10145

AFFECTED FILES
  src/render/katerenderer.cpp

To: cullmann, #ktexteditor
Cc: dhaumann, rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars

D10145: Improve line height

[Christoph Cullmann]

cullmann added a comment.


  Thanks for testing, will apply that then now ;=)
  
  For the vertical lines: yes, that is exactly the same effect you get with 
some font sizes horizontally.
  
  Hope they fix that in bug https://bugreports.qt.io/browse/QTBUG-66036

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: dhaumann, rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars