KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/98/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 08 Apr 2018 03:30:23 +
 Build duration:
1 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 190 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/190/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 08 Apr 2018 03:29:53 +
 Build duration:
1 hr 11 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/60/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 08 Apr 2018 03:29:53 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31682/59755)38%
(18635/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8605/9158)49%
(5275/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)59%
(8427/14384)50%
(4910/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3888/7876)33%
(1639/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 211 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/211/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Apr 2018 03:29:53 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31626/59753)38%
(18609/48993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8605/9158)49%
(5274/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8360/14382)50%
(4882/9743)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3889/7876)33%
(1640/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/123/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Apr 2018 03:30:23 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.10 - Build # 9 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.10/9/
 Project:
Frameworks kcrash kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sun, 08 Apr 2018 02:26:08 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kcrashtest

KNewStuff - CMake targets hardcoding paths

[Ben Cooksley]

Hi all,

On Windows the Binary Factory has recently struck an issue with
KNewStuff where the paths supplied in the newstuffqmlplugin target it
installs are hardcoded.

This can be seen at the bottom of
https://binary-factory.kde.org/view/Windows%2032-bit/job/Peruse_Nightly_win32/12/consoleText

Could someone please take a look and change it so that this is
relative like all the other Frameworks (and other parts of KNewStuff)

Thanks,
Ben

D11888: Handle adjacent special characters correctly

[Stefan Brüns]

bruns removed a task: T3: Add string "Your system default" to translation.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

[Stefan Brüns]

bruns removed a task: T2: sudoku activity string must be changed: ".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12037

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

[Stefan Brüns]

bruns updated this revision to Diff 31638.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12037?vs=31632=31638

BRANCH
  b392620_fix_term_stack

REVISION DETAIL
  https://phabricator.kde.org/D12037

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D11888: Handle adjacent special characters correctly

[Stefan Brüns]

bruns updated this revision to Diff 31636.
bruns added a task: T3: Add string "Your system default" to translation.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11888?vs=31550=31636

BRANCH
  t3

REVISION DETAIL
  https://phabricator.kde.org/D11888

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12007: Add test case for parsing of double opening '(('

[Stefan Brüns]

bruns marked 2 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12007

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12007: Add test case for parsing of double opening '(('

[Stefan Brüns]

bruns updated this revision to Diff 31634.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12007?vs=31547=31634

BRANCH
  b#392620_unittest

REVISION DETAIL
  https://phabricator.kde.org/D12007

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D11888: Handle adjacent special characters correctly

[Stefan Brüns]

bruns added a dependent revision: D12037: Immediately apply termInConstruction 
when term is complete.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12007: Add test case for parsing of double opening '(('

[Stefan Brüns]

bruns added a dependent revision: D12037: Immediately apply termInConstruction 
when term is complete.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12007

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

[Stefan Brüns]

bruns added dependencies: D11888: Handle adjacent special characters correctly, 
D12007: Add test case for parsing of double opening '(('.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12037

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Term::Or and Term::And delimit the term in construction, but did not
  add the term to the stack. This necessitated to save the last seen
  operation, but use the previous operation from the stack when adding
  to it. Unfortunately the last seen operation was not restored correctly
  after pushing and popping from the stack.
  
  Instead of adding more state to the parser, immediately add a completed
  term to the stack, which allows to remove the temporary last operation.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  t2

REVISION DETAIL
  https://phabricator.kde.org/D12037

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham added a comment.


  Phabricator is //really// bad at showing file changes that involve symlinks 
(specifically, turning a file into a symlink), so for code-oriented people, 
here's the little shell script I used to produce these changes:
  
cd repos/breeze-icons

for DIR in icons/actions/16 icons/actions/22 icons-dark/actions/16 
icons-dark/actions/22; do
ln -fsn configure.svg $DIR/configure_kile.svg
ln -fsn configure.svg $DIR/configure_project.svg
done

for DIR in icons/actions/16 icons/actions/22 icons/actions/24 
icons/actions/32 icons-dark/actions/16 icons-dark/actions/22 
icons-dark/actions/24 icons-dark/actions/32; do
mv $DIR/configure.svg $DIR/document-properties.svg
mv $DIR/configure-shortcuts.svg $DIR/configure.svg
ln -s ../../devices/22/input-keyboard.svg $DIR/configure-shortcuts.svg
ln -fsn configure.svg $DIR/settings-configure.svg
ln -fsn configure.svg $DIR/games-config-options.svg
ln -fsn configure.svg $DIR/games-config-custom.svg
ln -fsn configure.svg $DIR/gtk-preferences.svg
ln -fsn configure.svg $DIR/step_object_Controller.svg
done

for DIR in icons/actions/16 icons/actions/22 icons/actions/24 
icons-dark/actions/16 icons-dark/actions/22 icons-dark/actions/24; do
ln -fsn configure.svg $DIR/configure-toolbars.svg
done

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma
Cc: sharvey, #frameworks, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma
Cc: sharvey, #frameworks, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now, the Breeze icon for "Configure" is sub-optimal and nondescript, 
and has little visual connection to the idea of "configure me! Settings over 
here!"
  
  ["before" image goes here]
  
  There is already a better icon: a "two sliders" symbol that's currently used 
for configuring shortcuts, for some odd reason. Plasma instead deliberately 
uses this "two sliders" icon in many places (e.g. KRunner) and System Settings 
already uses "two sliders" iconography in its own icon. Also, the Breeze icon 
theme uses this icon for "configure" in GTK apps. It's very much a more 
appropriate icon.
  
  This patch uses the superior "two sliders" icon for "configure" in all 
contexts, and adjusts symlinks to maintain compatibility for places where the 
existing icon should be used.
  
  Also, the "configure shortcuts" icon changes to one that looks like a 
keyboard, which seems more appropriate given the feature itself.
  
  Possible further improvements in subsequent patches:
  
  - Improve the `input-keyboard` icon to look better at menu item size
  - Create a new icon for "configure toolbars" so we don't have to use the same 
"two sliders" icon for it

TEST PLAN
  Deploy change, switch to Breeze Dark and then back to Breeze light again
  
  [images go here]
  
  Also tested with Breeze dark.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-consistent-configure-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12034

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/actions/16/configure-toolbars.svg
  icons-dark/actions/16/configure.svg
  icons-dark/actions/16/configure_kile.svg
  icons-dark/actions/16/configure_project.svg
  icons-dark/actions/16/document-properties.svg
  icons-dark/actions/16/games-config-custom.svg
  icons-dark/actions/16/games-config-options.svg
  icons-dark/actions/16/gtk-preferences.svg
  icons-dark/actions/16/settings-configure.svg
  icons-dark/actions/16/step_object_Controller.svg
  icons-dark/actions/22/configure-shortcuts.svg
  icons-dark/actions/22/configure-toolbars.svg
  icons-dark/actions/22/configure.svg
  icons-dark/actions/22/configure_kile.svg
  icons-dark/actions/22/configure_project.svg
  icons-dark/actions/22/document-properties.svg
  icons-dark/actions/22/games-config-custom.svg
  icons-dark/actions/22/games-config-options.svg
  icons-dark/actions/22/gtk-preferences.svg
  icons-dark/actions/22/settings-configure.svg
  icons-dark/actions/22/step_object_Controller.svg
  icons-dark/actions/24/configure-shortcuts.svg
  icons-dark/actions/24/configure-toolbars.svg
  icons-dark/actions/24/configure.svg
  icons-dark/actions/24/document-properties.svg
  icons-dark/actions/24/games-config-custom.svg
  icons-dark/actions/24/games-config-options.svg
  icons-dark/actions/24/gtk-preferences.svg
  icons-dark/actions/24/settings-configure.svg
  icons-dark/actions/24/step_object_Controller.svg
  icons-dark/actions/32/configure-shortcuts.svg
  icons-dark/actions/32/configure.svg
  icons-dark/actions/32/document-properties.svg
  icons-dark/actions/32/games-config-custom.svg
  icons-dark/actions/32/games-config-options.svg
  icons-dark/actions/32/gtk-preferences.svg
  icons-dark/actions/32/settings-configure.svg
  icons-dark/actions/32/step_object_Controller.svg
  icons/actions/16/configure-shortcuts.svg
  icons/actions/16/configure-toolbars.svg
  icons/actions/16/configure.svg
  icons/actions/16/configure_kile.svg
  icons/actions/16/configure_project.svg
  icons/actions/16/document-properties.svg
  icons/actions/16/games-config-custom.svg
  icons/actions/16/games-config-options.svg
  icons/actions/16/gtk-preferences.svg
  icons/actions/16/settings-configure.svg
  icons/actions/16/step_object_Controller.svg
  icons/actions/22/configure-shortcuts.svg
  icons/actions/22/configure-toolbars.svg
  icons/actions/22/configure.svg
  icons/actions/22/configure_kile.svg
  icons/actions/22/configure_project.svg
  icons/actions/22/document-properties.svg
  icons/actions/22/games-config-custom.svg
  icons/actions/22/games-config-options.svg
  icons/actions/22/gtk-preferences.svg
  icons/actions/22/settings-configure.svg
  icons/actions/22/step_object_Controller.svg
  icons/actions/24/configure-shortcuts.svg
  icons/actions/24/configure-toolbars.svg
  icons/actions/24/configure.svg
  icons/actions/24/document-properties.svg
  icons/actions/24/games-config-custom.svg
  icons/actions/24/games-config-options.svg
  icons/actions/24/gtk-preferences.svg
  icons/actions/24/settings-configure.svg
  icons/actions/24/step_object_Controller.svg
  icons/actions/32/configure-shortcuts.svg
  icons/actions/32/configure.svg
  icons/actions/32/document-properties.svg
  icons/actions/32/games-config-custom.svg
  

D10803: handle more tags in taglibextractor

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibextractortest.cpp:82
> Hmm, I disagree since they are simple and they don't leave room for ambiguity

Maybe just add a Prefix or Suffix for all QStrings?
Same applies to any Int values, you can never tell if the right property has 
been fetched.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: bruns, vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, 
astippich, spoorun, alexeymin

D11982: Use statbuf consistently

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  This obviously needs some cleanup, but this should not hold up this request 
...
  
  We should check if instead of replicating the code in the individual ioslaves 
we could push the createFileUdsEntry to the ResultIterator.

REPOSITORY
  R293 Baloo

BRANCH
  statbuf (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11982

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich added a comment.


  @mgallien this should be safe to land now since KF 5.45 has been tagged, 
right?

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, bruns, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, bruns, alexeymin

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[David Faure]

dfaure added a comment.


  s/thread/process/. It's not about threads it's about two processes: the (GUI) 
application, and the kioslave.
  
  But you present all this in a rather convoluted way, it's much simpler. The 
SimpleJob for asking a kioslave to delete a file is KIO::file_delete which 
exactly what this patch ends up calling.
  
  The issue is choosing when to call unlink directly and when to ask the slave 
to do it. Or indeed markg's idea of sending the full list of files to the slave 
in one go, with a new MultiDeleteJob (including progress information). However 
for many small files this might be slower (that long list needs to be sent 
over...).
  
  Since the bug report is about the "one big file" case, I'd say let's not fix 
what ain't broken (the many small files case), and let's just do "if local and 
small, delete in-process, otherwise use kioslave", i.e. just adding a size 
check for the fast path.
  
  The optimized way to do it would be, rather than a stat() in this method, to 
change DeleteJobPrivate::slotEntries so that it puts big files into a separate 
list, for instance.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns updated this revision to Diff 31623.
bruns added a reviewer: michaelh.
bruns added a comment.


  cleanup

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11828?vs=31008=31623

BRANCH
  speedup_orpostingoperator

REVISION DETAIL
  https://phabricator.kde.org/D11828

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12014: [kcoreaddons] convert to new connect syntax

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12014

To: jtamate, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

[David Faure]

dfaure added a comment.


  This calls for unittests. UndoManager has unittests here in kio, but if this 
requires kio_desktop then the test needs to be where kio_desktop is.

INLINE COMMENTS

> copyjob.cpp:2095
>  ++m_processedFiles;
> -emit q->copyingDone(q, *m_currentStatSrc, 
> finalDestUrl(*m_currentStatSrc, dest), QDateTime() /*mtime unknown, and not 
> needed*/, true, true);
> +// Bug 391606: finalDestUrl needs the resolved URL to slook up the 
> trash file name
> +// which is why we're passing m_currentSrcURL instead of 
> m_currentStatSrc to it

slook?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11987

To: broulik, #frameworks, dfaure
Cc: michaelh, ngraham, bruns

D12028: taglibextractortest: Add test for files with empty metadata

[Michael Heidelbach]

michaelh added a dependent revision: D12029: taglibextractor: Fix empty genre 
bug.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12028

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D12029: taglibextractor: Fix empty genre bug

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: mgallien, Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  Depends on D12028 

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  nometa-pass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12029

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D12028: taglibextractortest: Add test for files with empty metadata

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: mgallien, Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  Indicates a bug in `kfilemetadata` delivering genre property when genre has 
no value.

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  nometa (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12028

AFFECTED FILES
  autotests/samplefiles/no-meta/test.flac
  autotests/samplefiles/no-meta/test.m4a
  autotests/samplefiles/no-meta/test.mp3
  autotests/samplefiles/no-meta/test.mpc
  autotests/samplefiles/no-meta/test.ogg
  autotests/samplefiles/no-meta/test.opus
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D12025: Terminate query execution early if subterm returns empty result set

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Leaf queries may return an empty result set, which is signalled by
  returning a nullptr. Immediately break if the query is part of an
  Term::And, and omit it if it is a Term::Or.
  As creating the PostingOperator implicitly executes the database
  query, it is beneficial to omit queries whose result is not used
  anyway.

REPOSITORY
  R293 Baloo

BRANCH
  terminate_empty_terms_early

REVISION DETAIL
  https://phabricator.kde.org/D12025

AFFECTED FILES
  src/engine/transaction.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:e63a234d55d9: Dont impose using the default client 
(authored by rjvbb).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11183?vs=31594=31608

REVISION DETAIL
  https://phabricator.kde.org/D11183

AFFECTED FILES
  src/core/loader.cpp

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D11183: Sonnet: don't impose the default client

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb set the repository for this revision to R246 Sonnet.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb updated this revision to Diff 31594.
rjvbb added a comment.


  Unnecessary rebump, pardon, rebase.
  
  What's holding this up?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11183?vs=30657=31594

REVISION DETAIL
  https://phabricator.kde.org/D11183

AFFECTED FILES
  src/core/loader.cpp

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/59/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 10:35:42 +
 Build duration:
1 hr 25 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31903/59771)38%
(18749/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8603/9158)49%
(5273/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)59%
(8428/14384)50%
(4910/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1641/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/30/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 11:46:29 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/29/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 11:20:18 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 60 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/60/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 11:20:18 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D12006: Make list of subterms in debug output easier to spot

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:04f972a7f551: Make list of subterms in debug output 
easier to spot (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12006?vs=31546=31586

REVISION DETAIL
  https://phabricator.kde.org/D12006

AFFECTED FILES
  src/lib/term.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12005: Fix merging of terms in the AdvancedQueryParser

[Stefan Brüns]

bruns updated this revision to Diff 31585.
bruns added a comment.


  rebased

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12005?vs=31543=31585

BRANCH
  baloo_term_cleanup_2

REVISION DETAIL
  https://phabricator.kde.org/D12005

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D11826: Simplify Term operator&& and ||

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b0dcc732ca98: Simplify Term operator and || 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11826?vs=31581=31582

REVISION DETAIL
  https://phabricator.kde.org/D11826

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/term.cpp
  src/lib/term.h

To: bruns, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, bruns, 
alexeymin

D12017: taglibextractortest: Test for multiple values

[Michael Heidelbach]

michaelh created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  - Create new set of audio sample files
  - Add 2 artists and genres each using Picard
  - Add tests for multiple artists and genres
  
  Some tests are expected to fail this may be due to an implementation error or 
because picard was doing it wrong

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib-multi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12017

AFFECTED FILES
  autotests/samplefiles/multi/test.flac
  autotests/samplefiles/multi/test.m4a
  autotests/samplefiles/multi/test.mp3
  autotests/samplefiles/multi/test.mpc
  autotests/samplefiles/multi/test.ogg
  autotests/samplefiles/multi/test.opus
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: michaelh
Cc: #frameworks, astippich, mgallien, ashaposhnikov, michaelh, spoorun, 
ngraham, bruns, alexeymin

D11826: Simplify Term operator&& and ||

[Stefan Brüns]

bruns updated this revision to Diff 31581.
bruns added a comment.


  rebased

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11826?vs=31541=31581

BRANCH
  baloo_term_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D11826

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/term.cpp
  src/lib/term.h

To: bruns, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, bruns, 
alexeymin

D12016: [ktexteditor] much faster positionFromCursor

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Kate.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Use static variables to store information about last call.
  As most of the time the cursor is close to the previous position, avoid to 
calculate every time the size of the lines from the beginning of the document, 
just calculate it from the previous cursor position.

TEST PLAN
  Open a callgrind log file with 2.840.605 lines
  Go to the end of the file, and then play with the PageUp, PageDown and cursor 
keys.
  Before: it was unable to do continuous PageUp refreshes.
  After: the PageUp at any part of the file as as fast as in the beginning of 
the document.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

AFFECTED FILES
  src/view/kateviewaccessible.h

To: jtamate, #kate
Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, 
sars, dhaumann

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 210 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/210/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 10:35:42 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31842/59770)38%
(18720/48993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8605/9158)49%
(5271/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8356/14383)50%
(4881/9743)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3889/7876)33%
(1640/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 189 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/189/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 10:35:42 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D11998: Ensure that the model is set when resetResizing is called

[Fabian Kosmale]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bff960d67162: Ensure that the model is set when 
resetResizing is called (authored by fabiank).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11998?vs=31525=31578

REVISION DETAIL
  https://phabricator.kde.org/D11998

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/8/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:25 +
 Build duration:
2 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)22%
(465/2108)23%
(283/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)75%
(227/303)55%
(130/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
(6/10)tests0%
  

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/9/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:58 +
 Build duration:
1 hr 54 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(222/248)90%
(222/248)84%
(23799/28385)52%
(11686/22526)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(39/40)98%
(39/40)98%
(6/11397)49%
(7650/15483)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(68/70)97%
(68/70)84%
(5591/6627)65%
(1761/2706)src.server96%
(110/114)96%
(110/114)86%
(6733/7838)64%
(2055/3212)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/12/
 Project:
Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 07 Apr 2018 07:47:55 +
 Build duration:
1 hr 55 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/7/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:06 +
 Build duration:
1 hr 51 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)47%
(41/87)47%
(41/87)40%
(4073/10109)34%
(2393/7136)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)99%
(1354/1371)49%
(662/1344)src52%
(30/58)52%
(30/58)35%
(2719/7814)31%
(1731/5657)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/275)0%
(0/67)tests0%
(0/12)0%
(0/12)0%
(0/589)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/22)

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 9 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/9/
 Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 07 Apr 2018 07:47:48 +
 Build duration:
1 hr 50 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kglobalshortcuttest

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/12/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:03 +
 Build duration:
1 hr 46 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(46/58)79%
(46/58)75%
(7167/9602)54%
(4041/7520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)96%
(3042/3176)51%
(1716/3359)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src93%
(14/15)93%
(14/15)57%
(795/1395)46%
(339/739)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3323/4670)59%
(1983/3366)tests0%
(0/5)0%
(0/5)0%
(0/280)0%
(0/50)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/58/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:07 +
 Build duration:
1 hr 43 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31678/59755)38%
(18625/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8605/9158)49%
(5274/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)59%
(8418/14383)50%
(4906/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3894/7877)33%
(1640/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/10/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:45 +
 Build duration:
1 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)31%
(453/1450)22%
(192/858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)51%
(58/114)26%
(15/58)src90%
(9/10)90%
(9/10)34%
(395/1158)26%
(177/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/4)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/23/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:33 +
 Build duration:
1 hr 30 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D11176#241716 , @dfaure wrote:
  
  > Reference: 
https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/
 but also reproducible locally.
  
  
  Thanks for the report. *Fixed*

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/12/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:29 +
 Build duration:
1 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 09:05:22 +
 Build duration:
4 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(20/20)100%
(20/20)66%
(1958/2973)47%
(1041/2205)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)92%
(379/410)50%
(221/438)src100%
(12/12)100%
(12/12)62%
(1579/2563)46%
(820/1767)

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/8/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:04 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)88%
(21/24)88%
(21/24)46%
(1663/3633)38%
(848/2230)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(273/379)51%
(129/252)src.imageformats94%
(17/18)94%
(17/18)44%
(1386/3120)37%
(717/1920)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks ki18n kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 09:05:22 +
 Build duration:
46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:55 +
 Build duration:
1 hr 20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(20/20)100%
(20/20)66%
(1958/2973)47%
(1041/2205)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)92%
(379/410)50%
(221/438)src100%
(12/12)100%
(12/12)62%
(1579/2563)46%
(820/1767)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/14/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:18 +
 Build duration:
1 hr 15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 122 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/122/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:49:20 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:49:25 +
 Build duration:
1 hr 5 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)21%
(436/2108)20%
(253/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)92%
(143/155)55%
(104/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)67%
(32/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
 

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[Méven Car]

meven added a comment.


  In term of comparison to the FileCopyJob for instance, the difference I can 
spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft 
instanciates a subJob in this case a DirectCopyJob that will do the work, using 
internally SimpleJobPrivate.
  This internal SimpleJobPrivate is executed in a slave thread as I understand, 
allowing the UI thread to run during the file copy.
  
  I guess the right way to fix that would be to refactor the delete operation 
in the same manner: using a SimpleJob to benefit from the slave thread, the Job 
API provides.
  
  The downside is that it requires much more code editing.
  Does it make sense ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/38/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:58 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(222/248)90%
(222/248)84%
(23799/28385)52%
(11685/22526)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(39/40)98%
(39/40)98%
(6/11397)49%
(7650/15483)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(68/70)97%
(68/70)84%
(5591/6627)65%
(1760/2706)src.server96%
(110/114)96%
(110/114)86%
(6733/7838)64%
(2055/3212)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.9 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks threadweaver kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:36 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:25 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:49:06 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)47%
(41/87)47%
(41/87)40%
(4075/10109)34%
(2394/7136)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)99%
(1354/1371)49%
(662/1344)src52%
(30/58)52%
(30/58)35%
(2721/7814)31%
(1732/5657)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/275)0%
(0/67)tests0%
(0/12)0%
(0/12)0%
(0/589)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/22)

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:49:03 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(46/58)79%
(46/58)75%
(7179/9602)54%
(4055/7520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)96%
(3041/3176)51%
(1718/3359)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src93%
(14/15)93%
(14/15)57%
(794/1395)46%
(340/739)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3337/4670)59%
(1994/3366)tests0%
(0/5)0%
(0/5)0%
(0/280)0%
(0/50)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 209 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/209/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:07 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31626/59755)38%
(18603/48993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8605/9158)49%
(5274/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8366/14383)50%
(4886/9743)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3893/7877)33%
(1639/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/97/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:20 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:45 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(416/1448)21%
(184/858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)51%
(58/114)26%
(15/58)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/4)

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/48/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:50 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:48 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8117)48%
(3182/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2794)62%
(1365/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:49:03 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm

D12014: [kcoreaddons] convert to new connect syntax

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Convert to the new connect syntax.
  As the job2 parameter was not used, remove it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12014

AFFECTED FILES
  src/lib/jobs/kjobuidelegate.cpp
  src/lib/jobs/kjobuidelegate.h

To: jtamate, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/46/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:33 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:47:29 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:58 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 38 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:52 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktextwidgets-krichtextedittest

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/16/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:48:03 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(19/24)79%
(19/24)42%
(1532/3631)36%
(799/2230)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(283/379)59%
(149/252)src.imageformats83%
(15/18)83%
(15/18)40%
(1245/3118)34%
(648/1920)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:47:55 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.ki18n_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(20/20)100%
(20/20)66%
(1957/2973)47%
(1038/2205)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)92%
(379/410)50%
(221/438)src100%
(12/12)100%
(12/12)62%
(1578/2563)46%
(817/1767)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:48 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:44 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 188 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/188/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:07 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:41 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/70/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:47:18 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/40/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:33 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/35/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:29 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:48:03 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks ki18n kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:55 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ki18n_install

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/53/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 07 Apr 2018 07:47:18 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 59 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/59/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:46:40 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11998: Ensure that the model is set when resetResizing is called

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Apr 2018 07:35:05 +
 Build duration:
9 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)56%
(126/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 73 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/73/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Apr 2018 07:35:05 +
 Build duration:
4 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)56%
(126/224)