D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 36976.
jtamate edited the summary of this revision.
jtamate added a comment.


  Use 3 entries instead of replace().
  Now it will work with any kio version.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13813?vs=36975=36976

REVISION DETAIL
  https://phabricator.kde.org/D13813

AFFECTED FILES
  src/tests/kfileitemmodeltest.cpp

To: jtamate, #dolphin, #frameworks
Cc: bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, 
firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 36975.
jtamate added a comment.


  Updated the patch with context.
  
  It will not work with kio previous to 5.47, unless there is a way to check 
the kio version at compile time or runtime.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13813?vs=36955=36975

REVISION DETAIL
  https://phabricator.kde.org/D13813

AFFECTED FILES
  src/tests/kfileitemmodeltest.cpp

To: jtamate, #dolphin, #frameworks
Cc: bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, 
firef, andrebarros, emmanuelp

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 105 - Still unstable!

2018-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/105/
 Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sun, 01 Jul 2018 04:15:24 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 102 - Failure!

2018-06-30 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/102/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 01 Jul 2018 03:39:28 +
 Build duration:
9 min 8 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.9’Ready to run at Sun Jul 01 03:48:33 UTC 2018Resuming build at Sun Jul 01 03:48:33 UTC 2018 after Jenkins restartRunning on Docker Swarm-f9b4a0354bd0 in /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[Pipeline] }[Pipeline] // stage[Pipeline] }java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution.onResume(AbstractSynchronousNonBlockingStepExecution.java:70)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:999)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:977)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:906)	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 31 - Still Unstable!

2018-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/31/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 01 Jul 2018 03:39:28 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Christoph Feck 
cfeck added a comment.


  I think the comment can be omitted. It doesn't add information to the code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 added a comment.


  Unit test is there... and it passes... always... with or without the 
kmainwindow.cpp patch :-/
  Is there some simpler way to initialize/kill QApplication for each mainwindow 
creation/deletion, other than adding new test that uses QTEST_APPLESS_MAIN 
instead of QTEST_MAIN?

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 updated this revision to Diff 36973.
maxrd2 added a comment.


  Added unit test

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13808?vs=36938=36973

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

AFFECTED FILES
  autotests/kmainwindow_unittest.cpp
  autotests/kmainwindow_unittest.h
  src/kmainwindow.cpp

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13813: make this test work again with new uds implementation

2018-06-30 Thread Stefan Brüns 
bruns added a comment.


  @jtamate , can you please use arc diff to upload patches - arc sucks, but 
having no patch context sucks even more ...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks
Cc: bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, 
firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Thomas Marshall 
tmarshall added a comment.


  @elvisangelaccio The check has to come before the check for 
`name.startsWith('.')` because that's what launches the "The name  starts 
with a ." dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 added a comment.


  The change in qt affects when the window close event is handled in queue, it 
didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a 
bit sooner, but it's still gets triggered by same close event - i think that 
stayed like it always was.
  Also KMainWindow code is made to autosave settings (if not disabled) every 
time some relevant widget changes, so am pretty sure that this patch won't ever 
cause it to save incorrect settings.
  Window/widget visibility and size is unlikely to change by user after they 
click to close window.
  
  However to be 100% sure will submit the test.

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Elvis Angelaccio 
elvisangelaccio added subscribers: dfaure, elvisangelaccio.
elvisangelaccio added a comment.


  Hmm, shouldn't this check be at the kio_file level @dfaure ?
  If we put it here, it will still fail when you try to create a folder name 
"." **not** by using the knewfilemenu in dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham
Cc: elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Elvis Angelaccio 
elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

2018-06-30 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Will it still work if we link against an old kio version?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks
Cc: elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Thomas Marshall 
tmarshall added a comment.


  How am I to provide my name and email? Just in a comment?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham
Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, 
navarromorales, isidorov, firef, andrebarros, emmanuelp

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

2018-06-30 Thread Ralf Habacker 
This revision was automatically updated to reflect the committed changes.
Closed by commit R235:892865d441b4: Port remaining uses of qDebug() to 
qcDebug(ATTICA) (authored by habacker).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13798?vs=36898=36967

REVISION DETAIL
  https://phabricator.kde.org/D13798

AFFECTED FILES
  src/atticabasejob.cpp
  src/buildservicejobparser.cpp
  src/parser.cpp
  src/postfiledata.cpp
  src/postjob.cpp
  src/projectparser.cpp
  src/provider.cpp
  src/providermanager.cpp
  src/publisherparser.cpp
  src/putjob.cpp
  src/remoteaccountparser.cpp

To: habacker, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13816: Make KItinerary work as a static library

2018-06-30 Thread Volker Krause 
vkrause added a reviewer: Frameworks.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Wolfgang Bauer 
wbauer added a comment.


  I just like to note that VirtualBox has the same problem with Qt 5.11.1, that 
the toolbar and the status bar disappear on next start if you close the window:
  http://bugzilla.opensuse.org/show_bug.cgi?id=1099589
  So it does not only affect applications using KMainWindow...

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Albert Astals Cid 
aacid added a comment.


  Can we get an auto test?

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice, I think this is looking great. +1 on the latest wording. A lovely first 
patch!
  
  To land it for you, we'll need your full name and email address, so it would 
be great if you could provide that now. In the future, if you submit your patch 
using `arc` (see 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches)
 this will happen automatically via the git authorship information, so we won't 
have to bug you.
  
  Any comments from the #frameworks 
 folks?

INLINE COMMENTS

> tmarshall wrote in knewfilemenu.cpp:873
> I get `newfilemenu.cpp:873:74: error: ‘Error’ is not a member of 
> ‘QMessageBox’`
> 
> `QMessageBox::Critical` seems to work though.

Correct: `QMessageBox::Error` does not exist; it's `QMessageBox::Critical`. See 
https://doc.qt.io/qt-5/qmessagebox.html#Icon-enum

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham
Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, 
navarromorales, isidorov, firef, andrebarros, emmanuelp

D13814: Speedup sort

2018-06-30 Thread Jaime Torres Amate 
jtamate added a dependency: D13813: make this test work again with new uds 
implementation.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate 
jtamate added a dependent revision: D13814: Speedup sort.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13814: Speedup sort

2018-06-30 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: Dolphin, Frameworks.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Use a lambda function instead of a class.
  This way the member QCollator is not copied and initialized several times.

TEST PLAN
  Sorting in a directory with 82874 images:
  [TIME] Sorting: 19883  (before)
  [TIME] Sorting: 4198 (after)
  
  kfileitemmodelbenchmark before: ..   Passed   29.36 sec
  kfileitemmodelbenchmark after:..   Passed   20.39 sec

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp

To: jtamate, #dolphin, #frameworks
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: Dolphin, Frameworks.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  With the new uds implementation, when some data is meant to replace an old 
one, it has to use replace() instead of insert() to avoid an assert of data 
already exists.

TEST PLAN
  before: crash in the uds assert
  after: passes the test

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

AFFECTED FILES
  src/tests/kfileitemmodeltest.cpp

To: jtamate, #dolphin, #frameworks
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

2018-06-30 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13798

To: habacker, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Thomas Marshall 
tmarshall marked an inline comment as done.
tmarshall added inline comments.

INLINE COMMENTS

> bruns wrote in knewfilemenu.cpp:873
> Should be QMessageBox::Error in this case

I get `newfilemenu.cpp:873:74: error: ‘Error’ is not a member of ‘QMessageBox’`

`QMessageBox::Critical` seems to work though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks
Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, 
navarromorales, isidorov, firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Thomas Marshall 
tmarshall updated this revision to Diff 36954.
tmarshall marked 2 inline comments as done.
tmarshall added a comment.


  Changed `QMessageBox::Warning` to `QMessageBox::Critical` and updated the 
error message.
  
  New:
  
  F5981803: image.png 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13805?vs=36952=36954

REVISION DETAIL
  https://phabricator.kde.org/D13805

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: tmarshall, #dolphin, #frameworks
Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, 
navarromorales, isidorov, firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in knewfilemenu.cpp:874
> This message might be a little bit too terse. How about something that helps 
> explain the reason as well, like this?
> 
> > "" has a special meaning for the operating system and cannot be used 
> > as the name for a folder.

> ... and cannot be used as the name for a folder.

or for anything else.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, 
isidorov, firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:873
> +
> +KMessageBox::createKMessageBox(confirmDialog, buttonBox, 
> QMessageBox::Warning,
> +   i18n("Cannot create directory with name 
> \"%1\"", name),

Should be QMessageBox::Error in this case

> ngraham wrote in knewfilemenu.cpp:874
> This message might be a little bit too terse. How about something that helps 
> explain the reason as well, like this?
> 
> > "" has a special meaning for the operating system and cannot be used 
> > as the name for a folder.

> Folder " could not be created:
>  "" is reserved for use by the operating system.

We should probably use an error message similar to the one returned from the 
KIO job in case something goes wrong.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, 
isidorov, firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Thomas Marshall 
tmarshall updated this revision to Diff 36952.
tmarshall added a comment.


  Fixed a type in the comment and improved the wording of the error message.
  
  New:
  
  F5981755: image.png 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13805?vs=36922=36952

REVISION DETAIL
  https://phabricator.kde.org/D13805

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: tmarshall, #dolphin, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, 
firef, andrebarros, bruns, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-06-30 Thread Nathaniel Graham 
ngraham added a reviewer: Frameworks.
ngraham added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:859
>  } else {
> +// Test to see if the user has give "." or ".." as a name
> +if (name == "." || name == "..") {

has give -> has given

> knewfilemenu.cpp:874
> +KMessageBox::createKMessageBox(confirmDialog, buttonBox, 
> QMessageBox::Warning,
> +   i18n("Cannot create directory with name 
> \"%1\"", name),
> +   QStringList(),

This message might be a little bit too terse. How about something that helps 
explain the reason as well, like this?

> "" has a special meaning for the operating system and cannot be used as 
> the name for a folder.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, 
firef, andrebarros, bruns, emmanuelp

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

2018-06-30 Thread Nathaniel Graham 
ngraham added a comment.


  What you say theoretically makes sense, but try it out: the document appears 
in the Recent Documents menu for both Kate and KWrite, while multi-app 
aggregator UIs continue to not accumulate duplicates.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13804

To: ngraham, broulik, #dolphin, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect added a comment.


  I found Equinox days culculated by kholidays may be wrong.
  For example, kholidays says March 22th is Vernal Equinox Day in 2018, but 
actual Japanese Vernal Equinox Day is March 21th in 2018.
  
  I think Equinox Days should be kept.
  
  I also want to know how to hide automatically-calculated equinox days. I will 
send another patch later.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect added a comment.


  Fixed. Please review.
  
  I know equinox days can be automatically calculated, but in this review 
request I just revert the commit.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect updated this revision to Diff 36951.
phanect added a comment.


  Revert "updated Japanese holidays (in Japanese and English)"
  

  
  This reverts commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 
.
  This commit includes a lot of unintendet reverts from f604468 
 
("Update Japanese holidays")

REPOSITORY
  R175 PIM: KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13812?vs=36949=36951

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13812

AFFECTED FILES
  holidays/plan2/holiday_jp_en-us
  holidays/plan2/holiday_jp_ja

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Hard to tell if the qt behavior change is a bug or a feature, but the fix 
makes sense to me.
  
  (BTW I've been experiencing this regression in zanshin)

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect added a comment.


  Sorry, something wrong.
  In this commit only two files should be edited (holiday_jp_en-us and 
holiday_jp_ja) but tons of files is edited actually.
  I will fix it.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect edited the summary of this revision.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-06-30 Thread Jumpei Ogawa 
phanect retitled this revision from "GIT_SILENT: prepare 5.5.1" to "Revert 
"updated Japanese holidays (in Japanese and English)"".
phanect edited the summary of this revision.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: GIT_SILENT: prepare 5.5.1

2018-06-30 Thread Jumpei Ogawa 
phanect created this revision.
phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent.
phanect added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.
phanect requested review of this revision.

REVISION SUMMARY
  Revert "updated Japanese holidays (in Japanese and English)"
  
  This reverts commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 
.
  This commit includes a lot of unintendet reverts from 
f6044686a1768565bcf3d91489f1b080d64c8666 
 
(Update Japanese holidays)

REPOSITORY
  R175 PIM: KHolidays

BRANCH
  fix-jp-destruction

REVISION DETAIL
  https://phabricator.kde.org/D13812

AFFECTED FILES
  .krazy
  .reviewboardrc
  CMakeLists.txt
  KF5HolidaysConfig.cmake.in
  README.md
  autotests/CMakeLists.txt
  autotests/testholidayregion.cpp
  autotests/testholidayregion.h
  autotests/testlunar.cpp
  autotests/testlunar.h
  autotests/testseasons.cpp
  autotests/testseasons.h
  autotests/testsunriseset.cpp
  autotests/testsunriseset.h
  autotests/testzodiac.cpp
  docs/Doxyfile.local
  holidays/CMakeLists.txt
  holidays/holidays.qrc
  holidays/plan2/holiday_ar_es
  holidays/plan2/holiday_ba-srp_sr
  holidays/plan2/holiday_ba-srp_sr@ijekavian
  holidays/plan2/holiday_ba-srp_sr@ijekavianlatin
  holidays/plan2/holiday_ba-srp_sr@latin
  holidays/plan2/holiday_br_pt-br
  holidays/plan2/holiday_de-bb_de
  holidays/plan2/holiday_de-bw_de
  holidays/plan2/holiday_de-by_de
  holidays/plan2/holiday_de-hh_de
  holidays/plan2/holiday_de-mv_de
  holidays/plan2/holiday_de-nw_de
  holidays/plan2/holiday_de-rp_de
  holidays/plan2/holiday_de-sh_de
  holidays/plan2/holiday_de-sl_de
  holidays/plan2/holiday_de-sn_de
  holidays/plan2/holiday_de-st_de
  holidays/plan2/holiday_de-th_de
  holidays/plan2/holiday_de_de
  holidays/plan2/holiday_dz_ar
  holidays/plan2/holiday_dz_fr
  holidays/plan2/holiday_es_es
  holidays/plan2/holiday_fi_fi
  holidays/plan2/holiday_fr_fr
  holidays/plan2/holiday_gf_fr
  holidays/plan2/holiday_gp_fr
  holidays/plan2/holiday_gt_es
  holidays/plan2/holiday_hr_hr
  holidays/plan2/holiday_in_en-gb
  holidays/plan2/holiday_is_is
  holidays/plan2/holiday_jp_en-us
  holidays/plan2/holiday_jp_ja
  holidays/plan2/holiday_kr_ko
  holidays/plan2/holiday_mq_fr
  holidays/plan2/holiday_mu_en
  holidays/plan2/holiday_mx_es
  holidays/plan2/holiday_nc_fr
  holidays/plan2/holiday_pa_en
  holidays/plan2/holiday_pa_es
  holidays/plan2/holiday_pf_fr
  holidays/plan2/holiday_pl_pl
  holidays/plan2/holiday_pt_pt
  holidays/plan2/holiday_re_fr
  holidays/plan2/holiday_rs_sr
  holidays/plan2/holiday_rs_sr@ijekavian
  holidays/plan2/holiday_rs_sr@ijekavianlatin
  holidays/plan2/holiday_rs_sr@latin
  holidays/plan2/holiday_ru_ru
  holidays/plan2/holiday_si_sl
  holidays/plan2/holiday_sk_sk
  holidays/plan2/holiday_th_en-gb
  holidays/plan2/holiday_tr_en-gb
  holidays/plan2/holiday_tr_tr
  holidays/plan2/holiday_ua_uk
  holidays/plan2/holiday_us_en-us
  holidays/plan2/holiday_ve_es
  holidays/plan2/holiday_wf_fr
  holidays/plan2/holiday_yt_fr
  metainfo.yaml
  src/CMakeLists.txt
  src/astroseasons.cpp
  src/astroseasons.h
  src/declarative/CMakeLists.txt
  src/declarative/holidayregionsmodel.h
  src/declarative/holidaysmodel.h
  src/declarative/kholidaysdeclarativeplugin.h
  src/holiday.cpp
  src/holiday.h
  src/holiday_p.h
  src/holidayregion.cpp
  src/holidayregion.h
  src/lunarphase.cpp
  src/parsers/holidayparserdriver.cpp
  src/parsers/plan2/FlexLexer.h
  src/parsers/plan2/holidayparserdriverplan.cpp
  src/parsers/plan2/holidayparserdriverplan_p.h
  src/parsers/plan2/holidayscannerplan.cpp
  src/parsers/plan2/holidayscannerplan.lpp
  src/parsers/plan2/holidayscannerplan_p.h
  src/parsers/qcalendarsystem.cpp
  src/parsers/qcalendarsystem_p.h
  src/sunriseset.cpp
  src/zodiac.cpp
  src/zodiac.h

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Nathaniel Graham 
ngraham added reviewers: KDE Applications, dfaure, elvisangelaccio, broulik, 
cfeck.
ngraham added a comment.


  The bug report indicates that this patch is for adapting to a change in Qt 
5.11. Is this patch fully backwards-compatible with older Qt versions? If so, 
we'll need to guard this behind a Qt version check.
  
  Also, is the new behavior in Qt is a bug rather than an intended behavioral 
change? If so, we'll need for a Qt bug report to be mentioned in the comment.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks for your continued work on this. I continue to believe that in order 
to move forward, it needs to be broken up into separate atomic commits:
  
  - One to add a color parsing function to `KWidgetsAddons` so other local 
clients can use it
  - Another to adopt that functionality in `KMessageWidget`
  - A third one to add the background brightness introspection/calculation 
functionality
  - Fourth and fifth ones to adopt the brightness processing in 
`KMessageWidget` as well as in the Kirigami `inlineMessage` widget
  
  Why all this work? Three good reasons:
  
  - **Principle:** commits should be atomic.
  - **Practicality**: the first two commits are non-controversial and will 
probably be committed quickly, and then we don't have to gate them on the 
result of a discussion about the more controversial brightness matching part.
  - **Consistency**: if we change the visual style of `KMessageWidget`, we need 
to make the same change in Kirigami's `inlineMessage` or else we're missing the 
point of why the original change was made in the first place--to keep 
consistency between the two implementations. A reasonable amount of consistency 
between Kirigami and QWidgets-based Desktop apps is important to avoid 
generating the perception that Kirigami is a "mobile first" framework that just 
produces "big dumb phone apps on the desktop." We want people to 
enthusiastically adopt Kirigami for desktop apps, and that won't happen if the 
same control looks and feels needlessly different from the QWidget version.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D11828: Simplify orPostingIterator and make it faster

2018-06-30 Thread Stefan Brüns 
bruns updated this revision to Diff 36944.
bruns added a comment.


  remove extra parentheses

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11828?vs=31623=36944

BRANCH
  speedup_orpostingoperator

REVISION DETAIL
  https://phabricator.kde.org/D11828

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo, michaelh, #frameworks
Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb marked 8 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb updated this revision to Diff 36943.
rjvbb added a comment.


  Turns out it's trivial to check if and what custom theme was activated 
through the KColorSchemeManager.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13777?vs=36939=36943

REVISION DETAIL
  https://phabricator.kde.org/D13777

AFFECTED FILES
  src/kmessagewidget.cpp

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb added a comment.


  A few examples showing the subtle effect of brightness matching, comparing to 
the Breeze theme (the brightness reference):
  
  Oxygen:
  F5979829: breeze-vs-oxygen-vs-oxygen-matched.png 

  
  Obsidian Coast
  F5979830: breeze-vs-obsidian-vs-obsidian-matched.png 

  
  My own theme:
  F5979835: breeze-vs-graphite-vs-graphite-matched.png 


REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-06-30 Thread René J . V . Bertin 
rjvbb updated this revision to Diff 36939.
rjvbb added a comment.


  Using the theme's normal foreground colour for message text for more reliable 
readability with darker themes.
  
  Brightness matching to the fallback colour should never occur here, at least 
not when the palette text colour is black (as it tends to be in my testing). 
Brightness matching would make the resulting colour just about as dark 
(matching to a darker colour almost always succeeds).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13777?vs=36886=36939

REVISION DETAIL
  https://phabricator.kde.org/D13777

AFFECTED FILES
  src/kmessagewidget.cpp

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 added a comment.


  Relative bug is here https://bugs.kde.org/show_bug.cgi?id=395988

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 updated this revision to Diff 36938.
maxrd2 added a comment.


  Cleaned up indentation.

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13808?vs=36937=36938

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

AFFECTED FILES
  src/kmainwindow.cpp

To: maxrd2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-06-30 Thread Mladen Milinkovic 
maxrd2 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
maxrd2 requested review of this revision.

REVISION SUMMARY
  BUG: 395988
  In certain cases KMainWindow::saveMainWindowSettings() could have been
  called after mainwindow started destroying itself. Window settings would
  be saved with incorrect child widget states. e.g. some widgets would be
  saved as hidden even if they were visible before destroying

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

AFFECTED FILES
  src/kmainwindow.cpp

To: maxrd2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 10 - Unstable!

2018-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 30 Jun 2018 08:05:42 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtestFailed: TestSuite.kconfigcore-test_kconf_update

D13792: Remove unused include

2018-06-30 Thread Boudewijn Rempt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fa20aaadecf9: Remove unused include (authored by rempt).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13792?vs=36873=36935

REVISION DETAIL
  https://phabricator.kde.org/D13792

AFFECTED FILES
  src/core/kconfigbackend.cpp

To: rempt, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns