D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  mtp_next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a task: T9658: Rethink blur-by-default for Breeze SDDM login 
screen theme for Plasma 5.15.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and 
increase UI contrast so it's not required.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16018: Fix align of doxygen comments

[Bernd Buschinski]

buschinski changed the repository for this revision from R32 KDevelop to R39 
KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

[Bernd Buschinski]

buschinski added a comment.


  This did not work for templates as "isComment" uses line attributes and at 
the time the template is inserted it is always "C/C++ Code/Data"-attribute 
never a comment. It only becomes a "doxygen comment"-attribute after the 
template "editing" is finished.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

[Bernd Buschinski]

buschinski updated this revision to Diff 43088.
buschinski edited the summary of this revision.
buschinski edited the test plan for this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16018?vs=43050=43088

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  autotests/src/templatehandler_test.cpp
  autotests/src/templatehandler_test.h
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, 
antismap, michaelh, iodelay, vbspam, ngraham, bruns, demsking, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowd, sars, dhaumann

D16018: Fix align of doxygen comments

[Bernd Buschinski]

buschinski added a comment.


  In D16018#338441 , @cullmann wrote:
  
  > ...
  >  For the code:
  >  Hmm, why do you use rtrim? That removes trailing spaces, that won't help 
the startsWith checks. Or do I misread that?
  
  
  You are absolutely right, this makes no sense. I further investigate & fix.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham removed a dependent revision: D16031: [SDDM theme] remove blur and 
increase UI contrast so it's not required.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added a comment.


  In D15859#338583 , @mkoller wrote:
  
  > file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works 
since it's standard URL syntax.
  >  file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, 
since it's not a valid URL syntax.
  >
  > 443 is not enabled, so I can't test it, but given the fact that
  >  file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  >  is also not a valid URL syntax, I know it will not work.
  
  
  Oh, you "know"...
  
  See the comment in 
https://www.roelvanlisdonk.nl/2010/05/21/how-to-create-a-windows-explorer-shortcut-on-the-desktop-to-a-sharepoint-document-library/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and 
increase UI contrast so it's not required.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Properties' entry in the places panel context menu

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15999: Add icons with added background to system.svgz

[Filip Fila]

filipf added a comment.


  Would the background be grey and the icon itself black in all color schemes? 
(apropos how Inkscape shows it:)
  
  Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  
  They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  For some reason `arc` doesn't want to apply this:
  
Checking patch dev/null => icons-dark/actions/22/hint.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/actions/16/hint.svg => 
icons-dark/actions/16/visibility-visible.svg...
Checking patch dev/null => icons-dark/actions/16/visibility.svg...
error: dev/null: does not exist in index
  
  Giving up, too frustrating and I've got other things to do

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16028

To: ngraham, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

[Nathaniel Graham]

ngraham updated this revision to Diff 43081.
ngraham added a comment.


  Do it right

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16028?vs=43080=43081

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16028

AFFECTED FILES
  icons-dark/actions/16/hint.svg
  icons-dark/actions/16/visibility-hidden.svg
  icons-dark/actions/16/visibility-visible.svg
  icons-dark/actions/16/visibility.svg
  icons-dark/actions/22/hint.svg
  icons-dark/actions/22/visibility-hidden.svg
  icons-dark/actions/22/visibility-visible.svg
  icons-dark/actions/22/visibility.svg
  icons-dark/actions/24/hint.svg
  icons-dark/actions/24/visibility-hidden.svg
  icons-dark/actions/24/visibility-visible.svg
  icons-dark/actions/24/visibility.svg
  icons/actions/16/hint.svg
  icons/actions/16/visibility-hidden.svg
  icons/actions/16/visibility-visible.svg
  icons/actions/16/visibility.svg
  icons/actions/22/hint.svg
  icons/actions/22/visibility-hidden.svg
  icons/actions/22/visibility-visible.svg
  icons/actions/22/visibility.svg
  icons/actions/24/hint.svg
  icons/actions/24/visibility-hidden.svg
  icons/actions/24/visibility-visible.svg
  icons/actions/24/visibility.svg

To: ngraham, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch renames these icons so that their names follow the convention and 
bear some connection to what they look like and are for.
  
  Compatibility symlinks are put in place so that no icon changes are required 
for existing software.

TEST PLAN
  Icons for the Hidden Files actions in Dolphin remain the same

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16028

AFFECTED FILES
  icons-dark/actions/16/hint.svg
  icons-dark/actions/16/visibility-hidden.svg
  icons-dark/actions/16/visibility-visible.svg
  icons-dark/actions/16/visibility.svg
  icons-dark/actions/22/hint.svg
  icons-dark/actions/22/visibility-hidden.svg
  icons-dark/actions/22/visibility-visible.svg
  icons-dark/actions/22/visibility.svg
  icons-dark/actions/24/hint.svg
  icons-dark/actions/24/visibility-hidden.svg
  icons-dark/actions/24/visibility-visible.svg
  icons-dark/actions/24/visibility.svg
  icons/actions/16/hint.svg
  icons/actions/16/visibility-hidden.svg
  icons/actions/16/visibility-visible.svg
  icons/actions/16/visibility.svg
  icons/actions/22/hint.svg
  icons/actions/22/visibility-hidden.svg
  icons/actions/22/visibility-visible.svg
  icons/actions/22/visibility.svg
  icons/actions/24/hint.svg
  icons/actions/24/visibility-hidden.svg
  icons/actions/24/visibility-visible.svg
  icons/actions/24/visibility.svg

To: ngraham, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a task: T9390: Next Gen MTP.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  Awesome job, Andreas <3

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

akrutzler added a comment.


  Great! Is there anything else left to do @elvisangelaccio and @mlaurent 
before I land this?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

akrutzler retitled this revision from "[RFC] kio_mtp: Move MTP device handling 
from kioslave to kiod-module" to "[mtp] Move MTP device handling from kioslave 
to kiod-module".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

akrutzler updated this revision to Diff 43074.
akrutzler marked 4 inline comments as done.
akrutzler added a comment.


  - Rebase
  - Reserve memory for lists/vectors in advance.
  - Prepend "static" to all class-level functions
  - Fix typos

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15277?vs=42685=43074

BRANCH
  mtp_next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15277

AFFECTED FILES
  mtp/CMakeLists.txt
  mtp/devicecache.cpp
  mtp/devicecache.h
  mtp/filecache.cpp
  mtp/filecache.h
  mtp/kio_mtp.cpp
  mtp/kio_mtp.h
  mtp/kio_mtp_helpers.cpp
  mtp/kio_mtp_helpers.h
  mtp/kiod_module/CMakeLists.txt
  mtp/kiod_module/kmtpd.cpp
  mtp/kiod_module/kmtpd.h
  mtp/kiod_module/kmtpd.json
  mtp/kiod_module/mtpdevice.cpp
  mtp/kiod_module/mtpdevice.h
  mtp/kiod_module/mtpstorage.cpp
  mtp/kiod_module/mtpstorage.h
  mtp/shared/CMakeLists.txt
  mtp/shared/kmtpdeviceinterface.cpp
  mtp/shared/kmtpdeviceinterface.h
  mtp/shared/kmtpdinterface.cpp
  mtp/shared/kmtpdinterface.h
  mtp/shared/kmtpfile.cpp
  mtp/shared/kmtpfile.h
  mtp/shared/kmtpstorageinterface.cpp
  mtp/shared/kmtpstorageinterface.h
  mtp/shared/org.kde.kmtp.daemon.xml
  mtp/shared/org.kde.kmtp.device.xml
  mtp/shared/org.kde.kmtp.storage.xml

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15973: Add a 'Properties' entry in the places panel context menu

[Thomas Surrel]

thsurrel updated this revision to Diff 43071.
thsurrel added a comment.


  Show the KPropertiesDialog from the view instead of the model

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=43035=43071

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 265 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/265/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 18:23:18 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31514/60003)36%
(15947/43898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3788/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8355/14347)50%
(4660/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(527/1025)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

D15973: Add a 'Properties' entry in the places panel context menu

[Andres Betts]

abetts retitled this revision from "Add a 'Propreties' entry in the places 
panel context menu" to "Add a 'Properties' entry in the places panel context 
menu".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15510: Introduce HKDF

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> qca_basic.h:1081
>  
> +class QCA_EXPORT HKDF : public Algorithm
> +{

Missing class documentation.

Missing \since tag.

> qca-botan.cpp:234
> +public:
> +BotanHKDFContext( const QString , QCA::Provider *p, const 
> QString ) : QCA::HKDFContext(p, type)
> +{

remove space after '('

> qca-botan.cpp:250
> +
> +Context *clone() const
> +{

override?

> qca-botan.cpp:261
> + m_hkdf->kdf(key.data(), keyLength, (const Botan::byte*)secret.data(), 
> secret.size(),
> + (const Botan::byte*)salt.data(), salt.size(), (const 
> Botan::byte*)info.data(), info.size());
> + QCA::SecureArray retval(QByteArray((const char*)key.data(), 
> key.size()));

I'm allergic to C casts, after seeing them misused. Would static_cast work 
here? Otherwise reinterpret_cast?

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 420 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/420/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 18:23:18 +
 Build duration:
4 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 197.00 KB...][  3%] Built target docs-kcontrol5-useragent-index-cache-bz2Scanning dependencies of target KF5Service_QCHScanning dependencies of target KF5ConfigWidgets_QCHScanning dependencies of target KF5CoreAddons_QCH[  3%] Built target KF5Config_QCHScanning dependencies of target KF5Solid_QCHScanning dependencies of target KF5WidgetsAddons_QCH[  3%] Built target KF5CoreAddons_QCH[  3%] Built target KF5ConfigWidgets_QCHScanning dependencies of target KF5Auth_QCH[  3%] Built target KF5Service_QCH[  3%] Built target KF5Solid_QCH[  3%] Built target KF5WidgetsAddons_QCHScanning dependencies of target KF5Bookmarks_QCHScanning dependencies of target KF5Completion_QCH[  3%] Built target KF5Auth_QCHScanning dependencies of target KF5JobWidgets_QCHScanning dependencies of target KF5Codecs_QCHScanning dependencies of target KF5KIOCore_autogenScanning dependencies of target protocoltojson_autogen[  3%] Built target KF5Completion_QCH[  3%] Built target KF5JobWidgets_QCH[  3%] Built target KF5Bookmarks_QCH[  3%] Built target KF5Codecs_QCH[  4%] Generating moc_predefs.hScanning dependencies of target KF5KIONTLM_autogen[  4%] Automatic MOC for target protocoltojsonScanning dependencies of target kded_kcookiejar_autogenScanning dependencies of target kcookiejar5_autogen[  4%] Automatic MOC for target KF5KIONTLM[  4%] Automatic MOC for target kded_kcookiejarScanning dependencies of target ktelnetservice5_autogen[  5%] Automatic MOC for target kcookiejar5[  5%] Automatic MOC for target KF5KIOCore[  5%] Automatic MOC for target ktelnetservice5[  5%] Built target protocoltojson_autogen[  5%] Built target kcookiejar5_autogenScanning dependencies of target kpac_dhcp_helper_autogenScanning dependencies of target lockingtest_autogen[  5%] Automatic MOC for target lockingtest[  6%] Automatic MOC for target kpac_dhcp_helper[  6%] Built target KF5KIONTLM_autogen[  6%] Built target ktelnetservice5_autogen[  6%] Built target kpac_dhcp_helper_autogenScanning dependencies of target httpheaderdispositiontest_autogenScanning dependencies of target httpheadertokenizetest_autogen[  6%] Automatic MOC for target httpheaderdispositiontestScanning dependencies of target httpfiltertest_autogen[  6%] Automatic MOC for target httpheadertokenizetest[  6%] Automatic MOC for target httpfiltertest[  6%] Built target httpheadertokenizetest_autogen[  6%] Built target httpheaderdispositiontest_autogen[  6%] Built target lockingtest_autogenScanning dependencies of target KF5KIO_QCH[  6%] Generating src/KF5KIO.qch, src/KF5KIO.tags[  6%] Built target kded_kcookiejar_autogen[  6%] Generating org.kde.KCookieServer.xmlScanning dependencies of target protocoltojsonScanning dependencies of target KF5KIONTLM[  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.o[  6%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.o[  6%] Built target httpfiltertest_autogen[  6%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.hqdbusxml2cpp: Cannot process input: '/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.10/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.make[2]: *** [src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/build.make:66: src/ioslaves/http/kcookiejar/kcookieserveradaptor.cpp] Error 1make[1]: *** [CMakeFiles/Makefile2:2787: src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.o[  6%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[  6%] Generating kcookieserverinterface.mocScanning dependencies of target kcookiejar5[  6%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.o[  6%] Built target KF5KIOCore_autogen[  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.o[  6%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.o[  6%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.o[  6%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.o[  7%] Linking CXX shared library ../../bin/libKF5KIONTLM.so[  7%] Built target KF5KIONTLM[  8%] Linking CXX executable ../../bin/protocoltojson[  8%] Built target protocoltojson[  8%] Linking CXX executable ../../../../bin/kcookiejar5Building up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[  8%] Built target 

D15973: Add a 'Propreties' entry in the places panel context menu

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodel.cpp:957
>  
> +void KFilePlacesModel::requestProperties(const QModelIndex , QWidget 
> *parent)
> +{

Why is this in the model, rather than being in the view?
It shows a dialog, that sounds more like something for the view.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1c7b47cb677b: allow non-local file:// redirect to a 
Windows WebDav URL (authored by mkoller).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15859?vs=42626=43070#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15859?vs=42626=43070

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works 
since it's standard URL syntax.
  file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, since 
it's not a valid URL syntax.
  
  443 is not enabled, so I can't test it, but given the fact that
  file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  is also not a valid URL syntax, I know it will not work.
  
  And since https://www.webdavsystem.com/server/access/windows
  only talks about UNC path syntax, I even have no clue if this weird syntax 
will ever end up that way in a file:// URL.
  
  I have no idea how my colleagues did produce the file:// URL - for sure not 
manually.
  I just see that I received mails with a file:// URL, not with a UNC syntax

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added a comment.


  There are a few things which would be good to test:
  
  Try if the following URLs work (on windows):
  
  - file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document
  - file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document
  - file://some.server@SSL/DavWWWRoot/pwa/some/path/to/a/document
  
  Check if SSL is enabled on the server:
  $> telnet some.server 443
  With dolphin:
  
  - webdavs://some.server/DavWWWRoot/pwa/some/path/to/a/document
  
  At least one of "@80", ":80" should work on windows, as it just states the 
default explicitly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#338464 , @dfaure wrote:
  
  > I don't really know, but see https://phabricator.kde.org/D4254 for the full 
reasoning of the unittest.
  
  
  As far as I understand it, the themes are marked as scalable with a directory 
scope (icon theme spec 
),
 but there is no guarantee a theme is "complete".
  
  AFAICS, it is sufficient to link the 48px config icon and the other 22px 
icons into the "scalable" directory.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D15859: allow non-local file:// redirect to a M$-WebDav URL

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  +2, assuming the commit log doesn't have M$ anymore (the phab review does, 
but you don't use arc apparently so I guess the two things are unrelated)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D11236: [KCrash] Establish socket to allow change of ptrace scope

[David Faure]

dfaure added a reviewer: ossi.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

[David Faure]

dfaure added a comment.


  This looks like the kind of commit where a review by Oswald Buddenhagen 
 would be useful.

INLINE COMMENTS

> kcrash.cpp:672
> +// wait while DrKonqi is running and the socket connection 
> exists
> +while (kill(pid, 0) >= 0 && pollDrKonqiSocket(pid, sockfd) 
> >= 0);
> +closeDrKonqiSocket(socketpath, sockfd);

Use {} rather than ';' for the body of the while loop, otherwise many tools 
(and humans...) will think the ';' is an error.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D16007: [KNewFileMenu] Don't open an empty QFile

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16007

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

[David Faure]

dfaure added a comment.


  I don't really know, but see https://phabricator.kde.org/D4254 for the full 
reasoning of the unittest.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D14072: Don't try to restore invalid user places

[David Faure]

dfaure added a comment.


  Possible fix in https://phabricator.kde.org/D16020

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

[David Faure]

dfaure created this revision.
dfaure added a reviewer: jtamate.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

TEST PLAN
  kfileplacesmodeltest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16020

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: dfaure, jtamate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14072: Don't try to restore invalid user places

[David Faure]

dfaure added a comment.


  More generally, please please run the unittests after changing a class. I 
hate that I currently am the one doing this, on the day of the release, which 
forces me to bugfix such things, or delay the release.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14072: Don't try to restore invalid user places

[David Faure]

dfaure added a comment.


  This commit breaks kfileplacesmodeltest.
  
  $ bin/kfileplacesmodeltest testInitialState testInitialList 
testInternalBookmarksHaveIds
  
  - Start testing of KFilePlacesModelTest *
  
  Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 
shared (dynamic) debug build; by GCC 7.3.1 20180323 [gcc-7-branch revision 
258812])
  QDEBUG : KFilePlacesModelTest::initTestCase() 18:21:44.046 
kfileplacesmodeltest(22234) 
?[32mSolid::Backends::Fake::FakeManager::parseMachineFile?[0m void 
Solid::Backends::Fake::FakeManager::parseMachineFile() Parsing fake computer 
XML:  "/d/kde/src/5/frameworks/kio/autotests/fakecomputer.xml"
  
  PASS   : KFilePlacesModelTest::initTestCase()
  PASS   : KFilePlacesModelTest::testInitialState()
  PASS   : KFilePlacesModelTest::testInitialList()
  FAIL!  : KFilePlacesModelTest::testInternalBookmarksHaveIds() 
'!ids.contains(id)' returned FALSE. (Duplicated ID found!)
  
Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesmodeltest.cpp(315)]
  
  PASS   : KFilePlacesModelTest::cleanupTestCase()
  Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted, 75ms
  
  - Finished testing of KFilePlacesModelTest *
  
  I have debugged it a little bit but I don't really understand the overall 
logic.
  
  Many bookmarks have a UDI (like 
/org/kde/solid/fakehw/fstab/thehost/solidpath) and no URL, and those are the 
ones that are duplicated now.
  
  When this code is called again, those bookmarks are now skipped in the first 
iteration, and therefore added by the next foreach (the one which says "Add 
bookmarks for the remaining devices, they were previous unknown").
  
  Maybe this skipping should only be done for bookmarks with an empty UDI?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16018: Fix align of doxygen comments

[Christoph Cullmann]

cullmann added a comment.


  Hi, thanks for the patch to improve the indentation handling.
  A case to reproduce would help.
  For me, the identation is messed up in Kate if I do indent/unindent of such 
comments and the "keep extra spaces" option is off.
  But I think that has nothing to do with this bug.
  
  For the code:
  Hmm, why do you use rtrim? That removes trailing spaces, that won't help the 
startsWith checks. Or do I misread that?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

To: buschinski, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16018: Fix align of doxygen comments

[Bernd Buschinski]

buschinski created this revision.
buschinski added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
buschinski requested review of this revision.

REVISION SUMMARY
  After 
  https://bugs.kde.org/show_bug.cgi?id=360456
  
https://cgit.kde.org/ktexteditor.git/commit/?id=58baf7c318d4641a243ea18f04ef15ee017509e3
  
  the align of doxygen comments in templates stopped working.
  
  Without the patch:
  
/**
* foo
*/
void foo();
  
  with the patch:
  
/**
 * foo
 */
void foo();
  
  TODO: the added testcase does work with and without the patch. I can not 
create a reproducible test and need some help.
  
  currently only reproducible with kdevelop

TEST PLAN
  - start kdevelop
  - open any c/cpp file with functions
  - select the function / click in the name
  - Code -> Document Declaration
  
  -> not properly align
  
  - LD_PRELOAD=libKF5TextEditor.so kdevelop (with the patch)
  - repeat the rest of the steps
  
  -> correctly aligned

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 43051.
pstefan added a comment.


  Fix z-layering issue for the "-translucent" icons.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=43009=43051

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#337514 , @dfaure wrote:
  
  > This commit breaks the unittest "scalabletest" :
  >
  > FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  >
  >   firewall-applet-panic
  >   firewall-applet
  >   firewall-applet-error
  >   firewall-applet-shields_up
  >Loc: 
[/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  >
  > FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  >
  >   firewall-applet-panic
  >   firewall-applet
  >   firewall-applet-error
  >   firewall-applet-shields_up
  >Loc: 
[/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  >   
  >
  > Please fix ;)
  
  
  I'm afraid I don't understand the error or what to do about it. Aren't SVGs 
naturally scalable? Isn't the scalable directory unused in the Breeze icon 
theme because every icon is scalable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in main.cpp:204
> I'm not sure this check is needed - the other one (`posOfNonNumeric < 0`) 
> seem to be covering this case.
> There shouldn't be an empty `QByteArray`, right?

See `word[0]` access directly after.
I have fixed to many "shouldn't be" errors/crashes due to corrupt DB values in 
the past.

> poboiko wrote in main.cpp:211
> Same note here. The fewer code to maintain - the better :)

This is the exact case I have had - "X.
The code after (`word.indexOf('-', 2)`) requires a check for length >= 3 here 
(code correctness), semantics require >= 4.

> poboiko wrote in main.cpp:218
> I think we should `i18n()` those messages as well

I am not really sure:
balooctl -x is a quite low level debug tool. This is a diagnostic message only 
printed in case of DB errors. Translated strings make search on the web harder.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16001: ktextedit: lazy load the QTextToSpeech object

[Pino Toscano]

pino closed this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D16001

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich updated this revision to Diff 43038.
astippich added a comment.


  - fixup spaces

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15829?vs=43034=43038

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich added a comment.


  In D15829#338296 , @safaalfulaij 
wrote:
  
  > Thanks!
  >  I think this solved all my issues. I can for meter unit change the 
formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and 
choose to keep the dot or remove it in the `unitString`s translation. (`"bit"` 
-> `".bit"`, `"m"` -> `"m"`)
  >  By the way, shouldn't that also be the case for English? I don't see 
people write `"1 m"` but `"1m"`, `"200 B"` but `"200B"`, same for `Hz`, not 
sure about `bit`s. The space is not there when abbreviation is used.
  
  
  Great! Now looking forward to feedback from @bruns regarding the 
implementation :)
  Scientifically it is correct to put a (small) space between value and unit.

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Safa Alfulaij]

safaalfulaij added inline comments.

INLINE COMMENTS

> kformatprivate.cpp:124
> +{ KFormat::UnitPrefix::Milli, 1e-3,  bpow(-10), tr("m", "SI prefix 
> for 10^⁻3") , QString() },
> +{ KFormat::UnitPrefix::Unity, 1.0,   1.0  , QString()
>   , QString()},
> +{ KFormat::UnitPrefix::Kilo,  1e3,   bpow(10) , tr("k", "SI prefix 
> for 10^3")  , tr("Ki", "IEC binary prefix for 2^10")},

Space before `}`?

> kformatprivate.cpp:125
> +{ KFormat::UnitPrefix::Unity, 1.0,   1.0  , QString()
>   , QString()},
> +{ KFormat::UnitPrefix::Kilo,  1e3,   bpow(10) , tr("k", "SI prefix 
> for 10^3")  , tr("Ki", "IEC binary prefix for 2^10")},
> +{ KFormat::UnitPrefix::Mega,  1e6,   bpow(20) , tr("M", "SI prefix 
> for 10^6")  , tr("Mi", "IEC binary prefix for 2^20") },

Space before `}`?

> kformatprivate.cpp:127
> +{ KFormat::UnitPrefix::Mega,  1e6,   bpow(20) , tr("M", "SI prefix 
> for 10^6")  , tr("Mi", "IEC binary prefix for 2^20") },
> +{ KFormat::UnitPrefix::Giga,  1e9,   bpow(30) , tr("G", "SI prefix 
> for 10^9")  , tr("Gi", "IEC binary prefix for 2^30")  },
> +{ KFormat::UnitPrefix::Tera,  1e12,  bpow(40) , tr("T", "SI prefix 
> for 10^12") , tr("Ti", "IEC binary prefix for 2^40") },

Extra space after `}`?

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Safa Alfulaij]

safaalfulaij accepted this revision.
safaalfulaij added a comment.
This revision is now accepted and ready to land.


  Thanks!
  I think this solved all my issues. I can for meter unit change the formatting 
so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep 
the dot or remove it in the `unitString`s translation. (`"bit"` -> `".bit"`, 
`"m"` -> `"m"`)
  By the way, shouldn't that also be the case for English? I don't see people 
write `"1 m"` but `"1m"`, `"200 B"` but `"200B"`, same for `Hz`, not sure about 
`bit`s. The space is not there when abbreviation is used.

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16001: ktextedit: lazy load the QTextToSpeech object

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  lazy-qtexttospeech (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16001

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel updated this revision to Diff 43035.
thsurrel added a comment.


  Don't use this->

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=42984=43035

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich updated this revision to Diff 43034.
astippich added a comment.


  - add seperate, translatable string for IEC binary prefixes

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15829?vs=42563=43034

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 43031.
astippich added a comment.


  - update aiff and wav test files so that they are smaller

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15833?vs=42551=43031

BRANCH
  taglib_extractor_additional_tests

REVISION DETAIL
  https://phabricator.kde.org/D15833

AFFECTED FILES
  autotests/samplefiles/test.aif
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.wav
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:1c564d0b5eb4: Start drawing emblems in the bottom-right 
corner (authored by ngraham).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15947?vs=42864=43030

REVISION DETAIL
  https://phabricator.kde.org/D15947

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #vdg, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15968: kreadconfig: make the tool slightly more useful

[David Faure]

dfaure added a comment.


  Will you port the kreadconfig usage in startkde to add --ignore-globals 
--ignore-cascading in order to preserve performance?
  
  Maybe it would be better to preserve behaviour compatibility and rather make 
globals and cascading "opt in"?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D15968

To: apol, #frameworks
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  emblems-start-in-bottom-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15947

To: ngraham, #vdg, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich added a comment.


  In D15833#333933 , @svuorela wrote:
  
  > What's the origin/license of these files ? How are they created ?
  
  
  Forgot to mention it, I added this information to the summary.
  
  In D15833#333944 , @bruns wrote:
  
  > In D15833#333933 , @svuorela 
wrote:
  >
  > > What's the origin/license of these files ? How are they created ?
  >
  >
  > The files contain just silence.
  >
  > @astippich - can you convert the wav file to 8bit (32bit float currently), 
so it becomes smaller. Same for aiff, probably.
  
  
  Good idea, will update.
  
  In D15833#334084 , @bruns wrote:
  
  > Please lower bitdepth.
  >  Also, can you provide the commandline or the like to generate the files? - 
probably this is also stuff for an accompanying `README` file.
  
  
  I went the stupid way and converted them from the existing files, so I didn't 
really generate them.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Alexander Stippich]

astippich added a comment.


  In D15825#334087 , @bruns wrote:
  
  > There are some more common tags with identical values, i.e. AlbumArtist, 
Composer and Lyrics - any reason you kept these?
  
  
  These are the tags directly supported by taglib (e.g. tag->artist() ) which 
don't require manual reading of tags. These are only the supported tags for the 
mime types tested in D15833 

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15825

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 43028.
astippich added a comment.


  - explicitly test for supported mimetype

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15825?vs=42529=43028

BRANCH
  refactor_taglib_extractor_tests

REVISION DETAIL
  https://phabricator.kde.org/D15825

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/159/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:11:18 +
 Build duration:
1 hr 30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5192/13181)29%
(2743/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1702/3505)39%
(1033/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(955/1559)43%
(428/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
 

D16007: [KNewFileMenu] Don't open an empty QFile

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Fixes the following Qt warning when opening the context menu in dolphin:
  
QFSFileEngine::open: No file name specified

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16007

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/61/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:10:33 +
 Build duration:
1 hr 20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24773/28426)53%
(9800/18333)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11672/11759)50%
(6189/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5735/6771)65%
(1508/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6932/7965)66%
(1934/2931)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 264 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/264/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:07:42 +
 Build duration:
1 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31542/6)36%
(15976/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)43%
(3795/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8366/14347)50%
(4669/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3847/7922)33%
(1531/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
  

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/30/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:10:46 +
 Build duration:
1 hr 17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7106/9495)55%
(3480/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3010/3137)52%
(1266/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1378)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/55/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:08:37 +
 Build duration:
1 hr 11 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1153/2121)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/77/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:08:21 +
 Build duration:
1 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/39/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:05:37 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick updated this revision to Diff 43020.
croick added a comment.


  - check for interrupted signal calls when polling
  - create path string to socket only once
  - add comments

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=34673=43020

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks
Cc: lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/23/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:07:36 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1613/3581)36%
(715/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(272/378)53%
(76/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3069)35%
(637/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/60/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:05:09 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10159/23441)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2776)49%
(5804/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/59/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 10:03:41 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 234 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/234/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:11:18 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 88 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/88/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:10:33 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24714/28425)53%
(9759/18333)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11617/11758)50%
(6156/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5735/6771)65%
(1508/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6928/7965)66%
(1926/2931)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/42/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:10:46 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9495)55%
(3472/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1260/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)44%
(293/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/77/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:08:37 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1153/2121)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 419 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/419/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:07:42 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(31446/59998)36%
(15919/43880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3789/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8286/14345)50%
(4631/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/118/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:08:21 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/29/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:07:36 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1484/3579)32%
(647/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(282/378)53%
(77/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3067)32%
(568/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/116/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:05:09 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6330/8428)43%
(10156/23445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5800/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/65/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:05:36 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/56/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:06:01 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D16001: ktextedit: lazy load the QTextToSpeech object

[Pino Toscano]

pino created this revision.
pino added a reviewer: mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pino requested review of this revision.

REVISION SUMMARY
  Create the QTextToSpeech object on demand, i.e. only at the first
  request to speak a text. While this will make the the first request
  slower (but only the first), the creation of each KTextEdit widget is
  faster again.

TEST PLAN
  Builds fine, unit tests runs fine, ktextedittest still works as
  expected.

REPOSITORY
  R310 KTextWidgets

BRANCH
  lazy-qtexttospeech (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16001

AFFECTED FILES
  src/widgets/ktextedit.cpp

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/115/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 10:03:40 +
 Build duration:
6 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan edited the summary of this revision.
pstefan added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan created this revision.
pstefan added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Added duplicates of system.svgz' icons' with added background.
  The background color is hardcoded atm.
  
  For reference see T9658  and B398741 and 
B398742

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Igor Poboiko]

poboiko added a comment.


  I never experienced such corruption, though, but sanity check shouldn't hurt.

INLINE COMMENTS

> main.cpp:204
> +if (arr.length() <= 1) {
> +stream << "Malformed term (short): " << arr <<  "\n";
> +continue;

I'm not sure this check is needed - the other one (`posOfNonNumeric < 0`) seem 
to be covering this case.
There shouldn't be an empty `QByteArray`, right?

> main.cpp:211
>  if (word[0] == QLatin1Char('X')) {
> -int posOfNonNumeric = 1;
> -while (word[posOfNonNumeric] != '-') {
> -posOfNonNumeric++;
> +if (word.length() < 4) {
> +// 'X-

Same note here. The fewer code to maintain - the better :)

> main.cpp:218
> +if ((posOfNonNumeric < 0) || ((posOfNonNumeric + 1) 
> == word.length())) {
> +stream << "Malformed property term (no data): " 
> << word <<  "\n";
> +continue;

I think we should `i18n()` those messages as well

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15973: Add a 'Propreties' entry in the places panel context menu

[Elvis Angelaccio]

elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfileplacesmodel.cpp:963
> +
> +KPropertiesDialog::showDialog(this->url(index), parent);
> +}

We usually don't use `this->`

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns