KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/47/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 18 Oct 2018 05:28:20 +
 Build duration:
5 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7105/9495)55%
(3479/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3010/3137)52%
(1265/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4658)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/35/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 18 Oct 2018 05:28:21 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7096/9495)55%
(3466/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1261/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3310/4658)59%
(1909/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D16281: update epub test data and test for comment property

2018-10-17 Thread Stefan Brüns 
bruns added a comment.


  In D16281#344995 , @cfeck wrote:
  
  > Phabricator says the MIME Type was changed from application/epub+zip to 
application/zip. Is this a problem in Phabricator or in your file?
  
  
  The file no longer is spec compliant, as the first file in the zip container 
has to be the "mimetype" file, see OPF 
.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Stefan Brüns 
bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Christoph Feck 
cfeck added a comment.


  Phabricator says the MIME Type was changed from application/epub+zip to 
application/zip. Is this is problem in Phabricator or in your file?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16283: implement more tags for asf metadata

2018-10-17 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:720
> +//map the rating values of WMP to Baloo rating
> +//0->0, 1->2, 25->4, 50->6,7 5->8, 99->10
> +if (rating == 0) {

`// 0->0, 1->2, 25->4, 50->6, 75->8, 99->10`

> taglibextractor.cpp:736
> +lstASF = asfTags->attribute("WM/AlbumArtist");
> +if (!lstASF.isEmpty()) {
> +for (TagLib::ASF::AttributeList::ConstIterator it = lstASF.begin(); 
> it != lstASF.end(); ++it) {

you don't need the `isEmpty()` here, as you iterate over it.

> taglibextractor.cpp:737
> +if (!lstASF.isEmpty()) {
> +for (TagLib::ASF::AttributeList::ConstIterator it = lstASF.begin(); 
> it != lstASF.end(); ++it) {
> +if (!data.albumArtists.isEmpty()) {

I think you can write instead:
`for (const auto& attribute : qAsConst(lstAsf)) { ... }`,
as `TagLib::List` has `begin()` and `end()`

> taglibextractor.cpp:739
> +if (!data.albumArtists.isEmpty()) {
> +data.albumArtists += ", ";
> +}

this makes me always wonder why we don't do:

  // decltype(data.albumArtists) == QStringList
  for (attribute : lstAsf) {
QString t = TStringToQString(attribute.toString());
data.albumArtists << contactsFromString(t);
  }

> taglibextractor.h:28
>  #include 
>  
>  namespace TagLib

Side note - I think `tfilestream.h` is no longer needed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16283

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16283: implement more tags for asf metadata

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  for some reason the TagLib::ASF::File tag() function returns only an invalid 
pointer, so I decided to use the dynamic_cast here.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16283

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16283: implement more tags for asf metadata

2018-10-17 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  add some more tags for asf audio files

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_asf

REVISION DETAIL
  https://phabricator.kde.org/D16283

AFFECTED FILES
  autotests/samplefiles/test.wma
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16282: extract ape tags from ape and wavpack files

2018-10-17 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  extend the existing support of ape tags to all types
  that use the ape tag system

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_ape_wavpack

REVISION DETAIL
  https://phabricator.kde.org/D16282

AFFECTED FILES
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  In preparation of D12114 , which I plan 
to commandeer

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Alexander Stippich 
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  update the test data for epub and test for
  the comment property in the epub autotest

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_test_preparation

REVISION DETAIL
  https://phabricator.kde.org/D16281

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-17 Thread Alexander Stippich 
astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in embeddedimagedata.cpp:73
> `supportedMimeTypes()` ?
> capital `T`, see `ImageType` and `QMimeType`

The "read" is supposed to mark that only read operations for these mimetypes 
are supported. I plan to add support for writing add some points, and the 
supported formats may differ.
Or maybe one could use extractionMimeTypes() ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16197

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-17 Thread Alexander Stippich 
astippich updated this revision to Diff 43819.
astippich added a comment.


  - use QVERIFY
  - use capital T
  - add since 5.52 tag and rephrase documentation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16197?vs=43601=43819

BRANCH
  mimetypes_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D16197

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15070: Bindings: Support using sys paths for python install directory

2018-10-17 Thread Stefan Brüns 
bruns added a comment.


  In D15070#344884 , @cgiboudeaux 
wrote:
  
  > In D15070#344871 , @bruns wrote:
  >
  > > As all the raised concerns have been dealed with, can we give this a try 
while the next KF release is still somewhat in the future?
  >
  >
  > No, the empty if must be removed. Code that does nothing is useless.
  
  
  Its not empty, there is a comment inside. Of course I can add a 
`set(KDE_INSTALL_PYTHON${pyversion}DIR ${KDE_INSTALL_PYTHON${pyversion}DIR})` 
if you insist ...
  
  And if you restructure it you either end up with a lengthy if condition - `if 
(NOT KDE_INSTALL_PYTHON${pyversion}DIR AND 
KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)` - or another nesting level. Both 
are significantly harder to read.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D16196: add a description property to KFileMetaData

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  ping. would be great to get this in before the string freeze

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16196

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize 
handling of all types (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16179?vs=43546=43818

REVISION DETAIL
  https://phabricator.kde.org/D16179

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  Ok. Thanks!

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15070: Bindings: Support using sys paths for python install directory

2018-10-17 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  In D15070#344871 , @bruns wrote:
  
  > As all the raised concerns have been dealed with, can we give this a try 
while the next KF release is still somewhat in the future?
  
  
  No, the empty if must be removed. Code that does nothing is useless.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Stefan Brüns 
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Preferably, do such independent changes (restructuring, coding 
style/optimization) as two separate reviews.

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-17 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Feel free to push this for 5.52 (you'd have to adapt the @since 5.53 again).
  
  I only have minor comments that should not hold back this patch. One thing 
that pops into my eyes is that there are still some "todo" comments, which even 
talk about cornercases / bugs. Since I think you know what you are doing, I 
leave it up to you to decide wither it's ok as is or whether there need to be 
more fixes.
  
  In any case, it was never my (and I think I can also safely say) nor any 
other's intention to hold this patch back. So yes, pinging more often is ok 
imo. Luckily, you are not a first-time contributor (who would be very much 
discouraged by our review delays), so I am sure / hope we'll see more patches 
from you in the future as well! :-)

INLINE COMMENTS

> abstractannotationitemdelegate.h:66
> +/**
> + * The view where the annotation is shown
> + */

Is the view pointer always valid when the style option is passed as argument? 
If so, I suggest to add this as comment to avoid unnecessary if() calls / error 
handling etc...

> kateannotationitemdelegate.h:20
> +
> +#ifndef __KATE_ANNOTATIONITEMDELEGATE_H__
> +#define __KATE_ANNOTATIONITEMDELEGATE_H__

All keywords starting with __ are reserved, I suggest to remove __ at the 
beginning and at the end.

REPOSITORY
  R39 KTextEditor

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D15070: Bindings: Support using sys paths for python install directory

2018-10-17 Thread Stefan Brüns 
bruns added a comment.


  As all the raised concerns have been dealed with, can we give this a try 
while the next KF release is still somewhat in the future?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 243 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/243/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Oct 2018 16:07:20 +
 Build duration:
6 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13121)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3492)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 168 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/168/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 17 Oct 2018 15:59:10 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13181)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1700/3506)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 242 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/242/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Oct 2018 15:55:18 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13121)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3492)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 167 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/167/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 17 Oct 2018 15:55:18 +
 Build duration:
3 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)40%
(50/126)40%
(50/126)37%
(4853/13152)28%
(2625/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)91%
(1014/1116)49%
(533/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)47%
(1627/3496)38%
(993/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private42%
(8/19)42%
(8/19)48%
(745/1540)37%
(369/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

D16272: apply eexist workaround from listDir to stat as well

2018-10-17 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:cf34ba609dc4: apply eexist workaround from listDir to 
stat as well (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16272?vs=43793=43795

REVISION DETAIL
  https://phabricator.kde.org/D16272

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16272: apply eexist workaround from listDir to stat as well

2018-10-17 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D16272

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16272: apply eexist workaround from listDir to stat as well

2018-10-17 Thread Harald Sitter 
sitter edited the test plan for this revision.
sitter added a reviewer: broulik.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16272

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16272: apply eexist workaround from listDir to stat as well

2018-10-17 Thread Harald Sitter 
sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  knetattach stats() without first doing a listDir() so in the event that
  the url requires authentication it won't work and error out on the EEXISTS.
  listDir has a fallback hack for this which was missing from stat.
  
  stat now has this workaround as well and correctly brings up an auth
  dialog on shares that require it.
  
  BUG: 399699

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D16272

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Stefan Brüns 
bruns marked 3 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Stefan Brüns 
bruns marked 3 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:91
> There is `Transaction::documentId(const QByteArray& path)`, which can resolve 
> it using `DocumentUrlDB`.
> I believe it still would be cheaper than reindexing several files multiple 
> times.

But it is racy - if the file is replaced in the meantime, inode and filename no 
longer match. This is not completely unlikely when dealing with temporary files.

It would make the code also significantly more complex, and I want it simple 
here. It should only be hit in exceptional cases.

Also, it is not to uncommon to have a batch of size one from the start, i.e. 
when adding/modifying files.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Igor Poboiko 
poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in filecontentindexer.cpp:91
> Yes, its a binary search.
> Because we only have IDs here, and the progress reporting works on strings.

There is `Transaction::documentId(const QByteArray& path)`, which can resolve 
it using `DocumentUrlDB`.
I believe it still would be cheaper than reindexing several files multiple 
times.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

2018-10-17 Thread Stefan Brüns 
bruns closed this revision.
bruns added a comment.


  Sorry, submitted this one twice - D16254 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16237

To: bruns, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:91
> Do I understand correctly, that's a binary-search-like way to find the file 
> actually causing `extractor` to crash, and it will reindex some of the files 
> in a batch ~log2(batchsize) times?
> Why don't we rely instead on its progress reporting, via 
> `startedIndexingFile` / `finishedIndexingFile`?

Yes, its a binary search.
Because we only have IDs here, and the progress reporting works on strings.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 241 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/241/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Oct 2018 11:43:12 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13121)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3492)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 166 - Still Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/166/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 17 Oct 2018 11:43:12 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13181)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1700/3506)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:75
> Is it OK to use `QObject::connect` inside a `while` loop? Those are not 
> `Qt::UniqueConnection`, won't they fire multiple times (more and more, 
> actually)?

given `loop` lives on the stack it is destroyed when the scope is left and the 
connection severed

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

2018-10-17 Thread Igor Poboiko 
poboiko added inline comments.

INLINE COMMENTS

> filecontentindexer.cpp:75
> +bool hadErrors = false;
> +connect(, ::failed, , [, 
> ]() { hadErrors = true; loop.quit(); });
> +

Is it OK to use `QObject::connect` inside a `while` loop? Those are not 
`Qt::UniqueConnection`, won't they fire multiple times (more and more, 
actually)?

> filecontentindexer.cpp:91
> +batchSize = idList.size() / 2;
> +}
> +process.start();

Do I understand correctly, that's a binary-search-like way to find the file 
actually causing `extractor` to crash, and it will reindex some of the files in 
a batch ~log2(batchsize) times?
Why don't we rely instead on its progress reporting, via `startedIndexingFile` 
/ `finishedIndexingFile`?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-17 Thread Luca Beltrame 
lbeltrame added a comment.


  +1, looks fine to me as far as I understand.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

2018-10-17 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16237

To: bruns, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 283 - Unstable!

2018-10-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/283/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 17 Oct 2018 04:34:15 +
 Build duration:
4 hr 25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiocore-threadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(260/397)65%
(260/397)53%
(31998/59990)38%
(16494/43892)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(55/56)98%
(55/56)95%
(9044/9515)48%
(4260/8920)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8348/14317)50%
(4660/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3895/7935)34%
(1591/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1769/4316)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 155 - Fixed!

2018-10-17 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/155/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Oct 2018 07:01:06 +
 Build duration:
2 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(12/24)67%
(114/170)67%
(114/170)60%
(5489/9159)42%
(2074/4972)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)95%
(239/252)67%
(63/94)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(719/719)55%
(190/348)autotests.unit.file100%
(11/11)100%
(11/11)98%
(862/883)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(405/416)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)80%
(1716/2136)59%
(668/1139)src.file63%
(24/38)63%
(24/38)52%
(842/1614)43%
(434/1018)src.file.extractor14%
(1/7)14%
(1/7)9%
(18/192)7%
(5/68)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(21/21)75%
(6/8)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/233)0%
(0/191)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)47%
(464/977)43%
(255/599)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/70)0%