KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 87 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/87/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 20 Nov 2018 07:14:22 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testRegion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)87%
(25541/29246)54%
(10134/18844)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(11995/12072)50%
(6359/12625)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5918/6971)65%
(1535/2372)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7194/8257)67%
(2071/3088)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 113 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Nov 2018 07:14:22 +
 Build duration:
4 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)87%
(25544/29246)54%
(10136/18844)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(11998/12072)50%
(6361/12625)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5918/6971)65%
(1535/2372)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7194/8257)67%
(2071/3088)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Nov 2018 07:06:27 +
 Build duration:
5 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(237/257)92%
(237/257)87%
(25526/29249)54%
(10129/18852)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(11983/12073)50%
(6353/12625)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(72/73)99%
(72/73)85%
(5916/6972)65%
(1535/2376)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(116/116)100%
(116/116)87%
(7193/8258)67%
(2072/3092)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D17028: Loader: Avoid Q_FOREACH

[loh tar]

loh.tar added a comment.


  @davidedmundson  Wow, that was fast :-)
  
  I have now done a search for more Q_FOREACH/foreach. Please let me know if 
you want each as own diff or all in once.
  
data/parsetrigrams.cpp
src/core/guesslanguage.cpp
src/plugins/hspell/hspelldict.cpp
src/plugins/hunspell/hunspellclient.cpp
src/plugins/voikko/voikkodict.cpp

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 265 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/265/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Nov 2018 04:36:50 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/125)35%
(44/125)27%
(3599/13095)19%
(1821/9433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(665/1520)30%
(301/990)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
 

D17000: Make sure there is only one MTime per document in the MTimeDB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5b24bd42e4b6: Make sure there is only one MTime per 
document in the MTimeDB (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17000?vs=45773=45857

REVISION DETAIL
  https://phabricator.kde.org/D17000

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17001: Add unittest for document replacement

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:40ef654f7857: Add unittest for document replacement 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17001?vs=45774=45858

REVISION DETAIL
  https://phabricator.kde.org/D17001

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16999: Extend diagnostic output for DB autotests

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:933db065c975: Extend diagnostic output for DB autotests 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16999?vs=45772=45856

REVISION DETAIL
  https://phabricator.kde.org/D16999

AFFECTED FILES
  autotests/integration/dbstate.h
  src/engine/documenttimedb.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16983: Add 48px firewall-applet* icons

[Noah Davis]

ndavis added a comment.


  In D16983#362552 , @aacid wrote:
  
  > These symlinks as they stand are not poinless, they are wrong.
  >
  > Icon sets are not "targeting a particular piece of software", icon sets are 
system wide and any software can ask for a given icon, so 
firewall-applet-shields_up symlinking to firewall-config in size 48 when in 
size 32 are clearly different is wrong.
  
  
  Do you think the firewall-applet icons should be moved to status/ as well?

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-firewall-applet-48px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16983

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17033

To: ndavis, #vdg, #breeze
Cc: andreask, kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

[Andreas Kainz]

andreask added a comment.


  Thanks for the update, I will work with the new colors also in LibO. We have 
there an issue on OS-X cause the contrast was not good enough and the new 
darker color will give an better contrast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17033

To: ndavis, #vdg, #breeze
Cc: andreask, kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17033

To: ndavis, #vdg, #breeze
Cc: kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The old colors were Icon Grey (#4d4d4d) and an undocument white color 
(#f2f2f2). The new colors are Shade Black (#232629) and Cardboard Grey 
(#eff0f1).
  
  With this change, icons in GTK applications will be the same color as icons 
in Qt applications with the Breeze and Breeze Dark colorschemes.
  
  I used `sed --follow-symlinks -i 's/4d4d4d/232629/' *.svg` and `sed 
--follow-symlinks -i 's/f2f2f2/eff0f1/' *.svg` in each directory containing 
monochrome icons, excluding the color icons in `apps/16` and `apps/22`

TEST PLAN
  I'm unsure how to prove that everything is as it should be with such a 
massive amount of small changes, but I did look through the diff for every file 
in `git-dag` and found no mistakes.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-primary-monochrome-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17033

AFFECTED FILES
  icons-dark/actions/12/object-fill.svg
  icons-dark/actions/12/object-stroke-style.svg
  icons-dark/actions/12/object-stroke.svg
  icons-dark/actions/12/transform-affect-gradient.svg
  icons-dark/actions/12/transform-affect-pattern.svg
  icons-dark/actions/12/transform-affect-rounded-corners.svg
  icons-dark/actions/12/transform-affect-stroke.svg
  icons-dark/actions/16/PrePostCondition.svg
  icons-dark/actions/16/accept_signal.svg
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/address-book-new.svg
  icons-dark/actions/16/adjustcol.svg
  icons-dark/actions/16/adjustrow.svg
  icons-dark/actions/16/aggregation.svg
  icons-dark/actions/16/akonadi-phone-home.svg
  icons-dark/actions/16/align-horizontal-baseline.svg
  icons-dark/actions/16/align-horizontal-bottom-out.svg
  icons-dark/actions/16/align-horizontal-center.svg
  icons-dark/actions/16/align-horizontal-left-out.svg
  icons-dark/actions/16/align-horizontal-left-to-anchor.svg
  icons-dark/actions/16/align-horizontal-left.svg
  icons-dark/actions/16/align-horizontal-right-out.svg
  icons-dark/actions/16/align-horizontal-right-to-anchor.svg
  icons-dark/actions/16/align-horizontal-right.svg
  icons-dark/actions/16/align-horizontal-top-out.svg
  icons-dark/actions/16/align-vertical-baseline.svg
  icons-dark/actions/16/align-vertical-bottom-out.svg
  icons-dark/actions/16/align-vertical-bottom.svg
  icons-dark/actions/16/align-vertical-center.svg
  icons-dark/actions/16/align-vertical-top-out.svg
  icons-dark/actions/16/align-vertical-top.svg
  icons-dark/actions/16/amarok_cart_add.svg
  icons-dark/actions/16/amarok_cart_remove.svg
  icons-dark/actions/16/amarok_cart_view.svg
  icons-dark/actions/16/amarok_change_language.svg
  icons-dark/actions/16/amarok_scripts.svg
  icons-dark/actions/16/anchor.svg
  icons-dark/actions/16/application-exit.svg
  icons-dark/actions/16/application-menu.svg
  icons-dark/actions/16/appointment-new.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/artifact.svg
  icons-dark/actions/16/association.svg
  icons-dark/actions/16/atmosphere.svg
  icons-dark/actions/16/autocorrection.svg
  icons-dark/actions/16/automated-tasks.svg
  icons-dark/actions/16/bitmap-trace.svg
  icons-dark/actions/16/black_sum.svg
  icons-dark/actions/16/bookmark-new.svg
  icons-dark/actions/16/bookmark-remove.svg
  icons-dark/actions/16/bordertool.svg
  icons-dark/actions/16/call-start.svg
  icons-dark/actions/16/call-stop.svg
  icons-dark/actions/16/category.svg
  icons-dark/actions/16/category2parent.svg
  icons-dark/actions/16/character-set.svg
  icons-dark/actions/16/check_constraint.svg
  icons-dark/actions/16/child2category.svg
  icons-dark/actions/16/choice-rhomb.svg
  icons-dark/actions/16/chronometer-pause.svg
  icons-dark/actions/16/chronometer.svg
  icons-dark/actions/16/circular-arrow-shape.svg
  icons-dark/actions/16/code-block.svg
  icons-dark/actions/16/code-class.svg
  icons-dark/actions/16/code-context.svg
  icons-dark/actions/16/code-function.svg
  icons-dark/actions/16/code-typedef.svg
  icons-dark/actions/16/code-variable.svg
  icons-dark/actions/16/color-gradient.svg
  icons-dark/actions/16/color-picker-black.svg
  icons-dark/actions/16/color-picker-grey.svg
  icons-dark/actions/16/color-picker-white.svg
  icons-dark/actions/16/color-picker.svg
  icons-dark/actions/16/colors-luma.svg
  icons-dark/actions/16/combined_fragment.svg
  icons-dark/actions/16/compass.svg
  icons-dark/actions/16/composition.svg
  icons-dark/actions/16/configure.svg
  icons-dark/actions/16/containment.svg
  icons-dark/actions/16/crosshairs.svg
  icons-dark/actions/16/curve-connector.svg
  icons-dark/actions/16/dashboard-show.svg
  icons-dark/actions/16/database-index.svg
  icons-dark/actions/16/debug-execute-from-cursor.svg
  icons-dark/actions/16/debug-execute-to-cursor.svg
  

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

[Kevin Funk]

kfunk created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  Direct leak of 3960 byte(s) in 15 object(s) allocated from:
  
#0 0x544cc0 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7f0dd8a3e2bd in 
PlasmaQuick::AppletQuickItem::AppletQuickItem(Plasma::Applet*, QQuickItem*) 
/home/kfunk/devel/src/kf5/plasma-framework/src/plasmaquick/appletquickitem.cpp:472:9
#2 0x7f0dcb7b365b in 
AppletInterface::AppletInterface(DeclarativeAppletScript*, QList 
const&, QQuickItem*) 
/home/kfunk/devel/src/kf5/plasma-framework/src/scriptengines/qml/plasmoid/appletinterface.cpp:50:7
#3 0x7f0dcb7aede1 in DeclarativeAppletScript::init() 
/home/kfunk/devel/src/kf5/plasma-framework/src/scriptengines/qml/plasmoid/declarativeappletscript.cpp:87:27
...
  
  ASAN: Fix memory leak in Corona
  
  KPackagePrivate::internalPackage already existed, the re-assignment to a
  new value causes a memory leak.
  
  Trace:
  Indirect leak of 112 byte(s) in 1 object(s) allocated from:
  
#0 0x544cc0 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7f905829163f in 
KPackage::Package::Package(KPackage::PackageStructure*) 
/home/kfunk/devel/src/kf5/kpackage/src/kpackage/package.cpp:51:9
#2 0x7f9058fad786 in Plasma::Package::Package(Plasma::PackageStructure*) 
/home/kfunk/devel/src/kf5/plasma-framework/src/plasma/package.cpp:66:34
#3 0x7f9058f14dee in Plasma::Corona::package() const 
/home/kfunk/devel/src/kf5/plasma-framework/src/plasma/corona.cpp:78:13
#4 0x5d9eb9 in ShellCorona::ShellCorona(QObject*) 
/home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:132:70
#5 0x65c31d in ShellManager::loadHandlers() 
/home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
  
  ASAN: Fix memory leak in DataSource
  
  Trace:
  Direct leak of 216 byte(s) in 27 object(s) allocated from:
  
#0 0x544cc0 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7fb2e9cd77d9 in Plasma::DataSource::setEngine(QString const&) 
/home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/core/datasource.cpp:93:28
#2 0x7fb2e9d5c8f1 in Plasma::DataSource::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) 
/home/kfunk/devel/build/kf5/plasma-framework/src/declarativeimports/core/corebindingsplugin_autogen/EWIEGA46WW/moc_datasource.cpp:330:21
  
  ASAN: Fix memory leak in CalendarPlugin
  
  Trace:
  Indirect leak of 24 byte(s) in 1 object(s) allocated from:
  
#0 0x508a17 in __interceptor_malloc 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x508a17)
#1 0x7fcf92aa6230 in QHashData::allocateNode(int) 
/home/kfunk/devel/src/qt5.11/qtbase/src/corelib/tools/qhash.cpp:479:79
#2 0x7fcf7a851d10 in QHash::detach() 
/home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qhash.h:275:51
#3 0x7fcf7a8519c9 in QHash::insert(int const&, QByteArray 
const&) 
/home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qhash.h:769:5
#4 0x7fcf7a859736 in 
EventPluginsModel::EventPluginsModel(EventPluginsManager*) 
/home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/calendar/eventpluginsmanager.cpp:42:17
#5 0x7fcf7a854c55 in EventPluginsManager::EventPluginsManager(QObject*) 
/home/kfunk/devel/src/kf5/plasma-framework/src/declarativeimports/calendar/eventpluginsmanager.cpp:185:19
...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17031

AFFECTED FILES
  src/declarativeimports/calendar/calendarplugin.cpp
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/datasource.h
  src/plasma/corona.cpp
  src/plasmaquick/appletquickitem.cpp

To: kfunk
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 329 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/329/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 19 Nov 2018 21:58:35 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)54%
(32100/59977)38%
(16585/43998)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4279/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8376/14294)51%
(4686/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3896/7945)34%
(1603/4739)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1019)37%
(315/852)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4293)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(703/1356)43%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 328 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/328/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 19 Nov 2018 21:47:26 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(263/398)66%
(263/398)54%
(32277/59971)38%
(16662/43976)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4277/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8365/14294)51%
(4677/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3898/7945)34%
(1605/4739)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1019)37%
(315/852)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4293)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
   

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4f5b4fd218ca: [ioslaves/trash] Handle broken symlinks in 
deleted subdirectories (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17021?vs=45824=45845

REVISION DETAIL
  https://phabricator.kde.org/D17021

AFFECTED FILES
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/tests/testtrash.h
  src/ioslaves/trash/trashimpl.cpp

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added reviewers: Kate, KTextEditor.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good from my perspective! Let's see what the #kate 
 folks think.

INLINE COMMENTS

> slenz wrote in kateview.cpp:543
> I think they both make sense, but "Toggle Comment" seems to be the 
> established standard. Three out of my four installed editors used that 
> wording (the last one only used "Comment").

OK, let's let the Kate folks have final say then.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D17008_1

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg, ngraham, #kate, #ktexteditor
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, 
cullmann, sars, dhaumann

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar added a comment.


  The added stuff at the ConfigWidget looks to me not perfect but OK. 
Suggestions are welcome. Some thoughts/questions
  
  - Most UI member are named m_foo but some without the m_ prefix. I can't 
recognize a rule why and chose for my new stuff a name without the prefix due 
to the way how they are used later, by ui-dot (ui.foo). So my offer is to 
rename all uniform, let me know which you prefer
  - The DictionaryComboBox and the new QListWidget (languageList) is somehow 
reduntant. Would be nice to include the "default language information" into the 
languageList. But how? The only idea I had was to add an icon to the "default 
language" by a double click.
  - Changes at the selected languages appear not direct in the 
DictionaryComboBox, only at next run. The same rules to the list itself. It 
would be a little unsettled to reorder the list by each change.
  - Not investigated if in Settings::setPreferredLanguages is calling 
d->loader->changed() is needed. Guess it is, but why not in every setFoo 
function?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17028: Loader: Avoid Q_FOREACH

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 327 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/327/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 19 Nov 2018 21:35:16 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32052/59954)38%
(16545/43972)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4275/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8365/14293)51%
(4675/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3897/7945)34%
(1604/4739)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1019)37%
(315/852)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4293)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
(682/1356)42%
  

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Silas Lenz]

slenz marked an inline comment as done.
slenz added inline comments.

INLINE COMMENTS

> ngraham wrote in katepart5ui.rc:2
> You need to bump the version to 79 or else the changes won't take effect.

That might explain why the changes only sometimes appeared. Fixed :)

> ngraham wrote in kateview.cpp:543
> Could we also change this string to say "Comment/Uncomment" Rather than 
> "Toggle comment"? I know that's //technically// correct because this is a 
> toggle action, but generally one doesn't associate "toggling" things with 
> text editing.

I think they both make sense, but "Toggle Comment" seems to be the established 
standard. Three out of my four installed editors used that wording (the last 
one only used "Comment").

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg, ngraham
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, 
cullmann, sars, dhaumann

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar created this revision.
Herald added a project: Frameworks.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...to ease the switch between dictionaries you usually need

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

AFFECTED FILES
  src/core/settings.cpp
  src/core/settings_p.h
  src/core/speller.cpp
  src/core/speller.h
  src/ui/configui.ui
  src/ui/configwidget.cpp
  src/ui/dictionarycombobox.cpp

To: loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16984: [RenameDialog] Fix layout when using the NoRename flag

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bb00649dc6e0: [RenameDialog] Fix layout when using the 
NoRename flag (authored by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16984?vs=45740=45843

REVISION DETAIL
  https://phabricator.kde.org/D16984

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: elvisangelaccio, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Silas Lenz]

slenz updated this revision to Diff 45841.
slenz added a comment.


  Increment menubar file version number

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17008?vs=45788=45841

BRANCH
  arcpatch-D17008_1

REVISION DETAIL
  https://phabricator.kde.org/D17008

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: slenz, #vdg, ngraham
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, 
cullmann, sars, dhaumann

D16985: Fix apidox of RenameDialog_Option

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d9e33ad398b0: Fix apidox of RenameDialog_Option (authored 
by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16985?vs=45742=45840

REVISION DETAIL
  https://phabricator.kde.org/D16985

AFFECTED FILES
  src/core/jobuidelegateextension.h

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17028: Loader: Avoid Q_FOREACH

[loh tar]

loh.tar created this revision.
Herald added a project: Frameworks.
loh.tar requested review of this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

AFFECTED FILES
  src/core/loader.cpp

To: loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17021

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[loh tar]

loh.tar created this revision.
Herald added a project: Frameworks.
loh.tar requested review of this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

AFFECTED FILES
  examples/dictionarycombobox.cpp

To: loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16983: Add 48px firewall-applet* icons

[Albert Astals Cid]

aacid added a comment.


  These symlinks as they stand are not poinless, they are wrong.
  
  Icon sets are not "targeting a particular piece of software", icon sets are 
system wide and any software can ask for a given icon, so 
firewall-applet-shields_up symlinking to firewall-config in size 48 when in 
size 32 are clearly different is wrong.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-firewall-applet-48px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16983

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D16983: Add 48px firewall-applet* icons

[Noah Davis]

ndavis added a subscriber: sitter.
ndavis added a comment.


  @sitter sent me an email saying that it would be better to put the 
firewall-applet icons into `status/`. He's probably right and it would mean I 
don't need to make a bunch of pointless symlinks.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-firewall-applet-48px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16983

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Lovely, this is just what I wanted. It's cool that the feature was already 
there. :) I like how you preserve the old shortcuts for compatibility. Just a 
few changes needed from my perspective:

INLINE COMMENTS

> katepart5ui.rc:2
>  
>  
>  

You need to bump the version to 79 or else the changes won't take effect.

> kateview.cpp:543
>  a = ac->addAction(QStringLiteral("tools_toggle_comment"));
>  a->setText(i18n("Toggle Comment"));
> +ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::Key_Slash));

Could we also change this string to say "Comment/Uncomment" Rather than "Toggle 
comment"? I know that's //technically// correct because this is a toggle 
action, but generally one doesn't associate "toggling" things with text editing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg, ngraham
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, 
cullmann, sars, dhaumann

Re: firewall-applet icons break breeze auto tests

[Noah Davis]

On Monday, November 19, 2018 6:53:28 AM EST Harald Sitter wrote:
> I am CCing Andreas Kainz on this as he may have input on where the
> firewall-* icons should go.
> From a quick look though I am convinced the majority/all of these
> icons should be in status/ not apps/. They are used in the system tray
> from what I understand, not actual application icons. apps/ is
> basically only for icons that would show up in the applications menu.
> 
> (the scalable test that is failing also does not apply to status/, so
> by moving the icons to the correct directory you'd fix the test)
> 
> HS

I put the icons into apps/ because the applet's hicolor icons are also placed 
into apps, but you may be right that status/ would be a better location. I did 
not know that apps/ was for icons that show up in the application menu, but 
that makes sense.

signature.asc
Description: This is a digitally signed message part.

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.cpp:77
> +KMessageBox::information(d->window, tr("This will hide the menu bar 
> completely."
> +" You can show it again by 
> typing %1.").arg(d->q->shortcut().toString()),
> +tr("Hide menu bar"),

If shortcut() returns a QKeySequence (i think it does), you want 
toString(NativeText)

Not a native speaker but i don't think "typing" is what you want, i'd say 
"pressing".

Also what if there's no shortcut?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

[David Edmundson]

davidedmundson edited the summary of this revision.
davidedmundson added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17021

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The trash ioslave currently handles:
  
  - working symlinks at the toplevel
  - broken symlinks at the toplevel
  - working symlinks in subdirectories
  
  but broken symlinks in a subdirectory gets lost.
  
  This is because subdirs are populated from a QDir::listEntries in the
  subdirectory folder, which by default filters out broken symlinks.
  
  It's important to list them so that we we restore the directory as
  otherwise we lose data. The symlink could become non-dead once files are
  restored.
  
  BUG: 400990

TEST PLAN
  Relevant unit test

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17021

AFFECTED FILES
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/tests/testtrash.h
  src/ioslaves/trash/trashimpl.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16946: Port more search providers to HTTPS

[Volker Krause]

vkrause added a comment.


  In D16946#361950 , @apol wrote:
  
  > About the rest, probably not, do you think that there's any that would be a 
big loss? I would assume by now that if they don't work with https it's 
probably because it's abandoned.
  
  
  The remaining non-https ones are:
  
  - ctan_cat
  - dictfr
  - freecode
  - freedb
  - grec
  - hyperdictionary[_thesaurus]
  - magnatune
  - rae
  - uspto
  - voila
  
  Some of them might be broken, I can only automate testing if the service 
responds, not if it responds with something sensible, and sometimes that's even 
hard to determine manually...

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16946

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 45821.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=45812=45821

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli marked 3 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17019: actually initialize kcrash properly

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17019

To: sitter, #baloo, #frameworks, apol
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17019: actually initialize kcrash properly

[Harald Sitter]

sitter created this revision.
sitter added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  to successfully use kcrash when linking with as-needed (which is a default
  flag on many linux distros) one also needs to call KCrash::initialize.
  
  without this kcrash may not be available for most users.
  
  https://markmail.org/thread/zv5pheijaze72bzs

TEST PLAN
  builds; extractor links to kcrash as expected

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17019

AFFECTED FILES
  src/file/extractor/main.cpp

To: sitter, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.h:57
> +/**
> + * Sets the parent window for message box with the user remainder.
> + *  @param window the window that will be parent for the message box

remainder -> reminder

> ktoggleshowmenubaraction.h:64
> + * If set to true, this action will remind the user through a message box
> + * on how to show back the menu bar using the keyborad shortcut.
> + * Default: false

show back the menu bar -> show the menu bar again

keyborad -> keyboard

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Nathaniel Graham]

ngraham added reviewers: Frameworks, KDE Applications.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Nathaniel Graham]

ngraham added subscribers: broulik, cfeck.
ngraham added a comment.


  Sounds like you know more than I do at this point. :) Let's see if this 
approach makes sense to @cfeck or @broulik.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks
Cc: cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16930: Android: improve clang support

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:06061b0e3ce4: Android: improve clang support (authored by 
apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16930?vs=45606=45816

REVISION DETAIL
  https://phabricator.kde.org/D16930

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake
  toolchain/deployment-file.json.in
  toolchain/specifydependencies.cmake

To: apol, #build_system, #android, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16852#362344 , @ngraham wrote:
  
  > you could tackle the patch to make Dolphin's default window size a tad 
taller.
  
  
  I'll poke around.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16852: Add Documents to the default list of Places

[Nathaniel Graham]

ngraham added a comment.


  Well, the extra space gained from D15739  
would also be taken up by D7446 . :)
  
  I wasn't suggesting that you fix T9795  
(it's beyond me too!), but rather than you could tackle the patch to make 
Dolphin's default window size a tad taller.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added inline comments.

INLINE COMMENTS

> cfeck wrote in ktoggleshowmenubaraction.h:28
> reminds
> 
> Additionally, "show back" does not sound like proper english, but I am not a 
> native english speaker.

Unfortunately, me too, ... any suggestion is appreciated

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 45812.
lsartorelli marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=45811=45812

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 45811.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=45807=45811

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17017: Fix assert when cleaning up symlinks in PreviewJob

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  When previewing files in a KIOslave KIO will copy the file out to a
  temporary directory and then run the preview on that.
  
  If I have a symlink in a slave (for example trashing a symlink) the
  preview job will copy the symlink to the temporary directory.
  
  QFileInfo follows symlinks for methods like isDir(), in this case we
  shouldn't assert as QFile::remove will correctly just cleanup the
  symlink.

TEST PLAN
  Created a symlink to a directory
  Trashed it
  Opened trash:// in dolphin with previews enabled
  Used to hit an assert
  Now don't

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17017

AFFECTED FILES
  src/widgets/previewjob.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.cpp:21
> +
> +#include "ktoggleshowmenubaraction.h"
> +

Do we still follow the rule "include own headers first"?

> ktoggleshowmenubaraction.h:28
> + * An action to hide or show the menubar of a window.
> + * The action by default remind the user how to show back
> + * the menu bar using the keyboard shortcut.

reminds

Additionally, "show back" does not sound like proper english, but I am not a 
native english speaker.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added a dependent revision: D17016: Show menu bar, how to 
re-enable, common shortcut dialog.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added a dependent revision: D17016: Show menu bar, how to 
re-enable, common shortcut dialog.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17014

To: lsartorelli, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  I had submitted this with the intention of being a follow-up to D15739 
, as that would clear a slot for this. I 
think right now, T9795  is outside my skill 
set. I'd be glad to make D15739  a parent 
to this and wait for that to land.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 45807.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=45798=45807

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  If anyone wonders:
  
  - These are 2 different commits for the same
  - Using find-modules/FindQHelpGenerator.cmake is not an option. Same reason 
as the one that made using query_qmake impossible.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.cpp:26
> +
> +#define i18n QString::fromLatin1
> +

What's this for?

> ktoggleshowmenubaraction.h:49
> + */
> +KToggleShowMenuBarAction(QWidget *window, QObject *parent);
> +

I know we typically use `window` here for legacy reasons, but given there's 
`QWindow` in Qt 5, might be better to use `widget` for all of this now?
Just asking, you don't have to change this now, unless someone else comments :)

> ktoggleshowmenubaraction.h:78
> +
> +
> +private:

There's an extra empty line

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
cgiboudeaux requested review of this revision.

REVISION SUMMARY
  In Qt >= 5.12, the qhelpgenerator and qcollectiongenerator tools were fused, 
only qhelpgenerator remains.
  
  Allow using ECMQueryQmake inside ECM.
  
  Due to project(ECM) specifying the "NONE" language, find_package(Qt5Core)
  cannot succeed.
  
  if the Qt5::qmake target doesn't exist, we now look for the qmake executable.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17015

AFFECTED FILES
  cmake/FindQHelpGenerator.cmake
  docs/CMakeLists.txt
  modules/ECMQueryQmake.cmake

To: cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added a dependent revision: D17014: Show menu bar, how to 
re-enable, common shortcut dialog.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli created this revision.
lsartorelli added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
lsartorelli requested review of this revision.

REVISION SUMMARY
  Provide a common message ,encapsulated into the ShowMenuBarAction, with a 
reminder about how to re-enable the menu bar with a keyboard shortcut sequence.
  
  The message dialog is optional by default and can be enabled if needed.
  
  The message dialog pops up only after the menu bar become hided.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17014

AFFECTED FILES
  autotests/kstandardactiontest.cpp
  src/kstandardaction.cpp
  src/kstandardaction.h

To: lsartorelli, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added a dependency: D17013: Show menu bar, how to re-enable, common 
shortcut dialog.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17014

To: lsartorelli, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli created this revision.
lsartorelli added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
lsartorelli requested review of this revision.

REVISION SUMMARY
  Provide a common message ,encapsulated into the ShowMenuBarAction, with a 
reminder about how to re-enable the menu bar with a keyboard shortcut sequence.
  
  The message dialog is optional by default and can be enabled if needed.
  
  The message dialog pops up only after the menu bar become hided.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 264 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/264/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Nov 2018 11:54:20 +
 Build duration:
3 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/125)35%
(44/125)27%
(3599/13095)19%
(1821/9433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(665/1520)30%
(301/990)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb updated this revision to Diff 45797.
rjvbb added a comment.


  Well, apparently the contextmenu CAN change during a session (at least on Mac 
and when I open it in different opened-at-session-load documents when the 
initial project load and parsing activity is still in progress).
  
  Using a QPointer fixes that but I left in debugging traces for good 
measure.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16882?vs=45782=45797

REVISION DETAIL
  https://phabricator.kde.org/D16882

AFFECTED FILES
  kdevplatform/shell/textdocument.cpp
  kdevplatform/shell/textdocument.h

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb set the repository for this revision to R32 KDevelop.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 111 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Nov 2018 11:47:45 +
 Build duration:
7 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(237/257)92%
(237/257)87%
(25526/29249)54%
(10130/18852)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(11983/12073)50%
(6353/12625)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(72/73)99%
(72/73)85%
(5916/6972)65%
(1536/2376)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(116/116)100%
(116/116)87%
(7193/8258)67%
(2072/3092)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16301: Remove ComponentInstaller

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:38098e96e3d8: Remove ComponentInstaller (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16301?vs=43874=45796

REVISION DETAIL
  https://phabricator.kde.org/D16301

AFFECTED FILES
  autotests/CMakeLists.txt
  src/plasma/CMakeLists.txt
  src/plasma/private/componentinstaller.cpp
  src/plasma/private/componentinstaller_p.h
  src/plasma/private/dataenginemanager.cpp
  src/plasma/scripting/scriptengine.cpp

To: broulik, #plasma, mart
Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

Re: firewall-applet icons break breeze auto tests

[Harald Sitter]

On Sun, Nov 18, 2018 at 6:33 PM Noah Davis  wrote:
> > My *guess* is that whoever decided 16, 22 and 32 are "fixed" even if they
> > are SVG while 48 is not, is that sometimes in the 16, 22, 32 sizes you have
> > to "sacrifice" some details because since you know it'll be shown in small
> > sizes it looks better creating a "different" version of the actual icon,
> > but at 48 they decided "this is going to be good enough so that it'll have
> > all the details that if you scale it up it'll look good".

^ This is absolutely correct.
What's more in breeze specifically there is a huge visual difference.
Small icons are generally not only less detailed but also monochrome.

> I see now, I didn't know about that feature. I guess I just need to symlink
> firewall-config.svg to firewall-applet.svg and the test will pass.

I am CCing Andreas Kainz on this as he may have input on where the
firewall-* icons should go.
>From a quick look though I am convinced the majority/all of these
icons should be in status/ not apps/. They are used in the system tray
from what I understand, not actual application icons. apps/ is
basically only for icons that would show up in the applications menu.

(the scalable test that is failing also does not apply to status/, so
by moving the icons to the correct directory you'd fix the test)

HS

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin, davidedmundson
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16301: Remove ComponentInstaller

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16301

To: broulik, #plasma, mart
Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin, davidedmundson
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov added a comment.


  https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html
  
  > std::bind can be hard to read and can result in larger object files and 
binaries due to type information that will not be produced by equivalent 
lambdas.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Silas Lenz]

slenz edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Silas Lenz]

slenz created this revision.
slenz added a reviewer: VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
slenz requested review of this revision.

REVISION SUMMARY
  Adds a menu item to toggle comments and adds CTRL + / as a shortcut. Also 
removes "Comment"/"Uncomment" menu items (but keeps the shortcuts to avoid 
breaking muscle memory).
  
  BUG: 387654

TEST PLAN
  Test both old and new shortcuts and the new menu item.

REPOSITORY
  R39 KTextEditor

BRANCH
  toggle-comment-expose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17008

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: slenz, #vdg
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel added a comment.


  Simply calling setFocus() was not working (I used this in D16914 
). My understanding is that the widget 
containing this has to be completely built before trying to set the focus, 
adding the timer ensures that. Correct me if this is wrong.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb set the repository for this revision to R240 Extra CMake Modules.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb updated this revision to Diff 45786.
rjvbb added a comment.


  This implements and uses my idea of an 
`ecm_add__compiler_flags_if_supported`  function set for C and C++. It 
uses compiler ID+version conditions to determine if flag(s) are supported when 
those conditions are known and reliable - otherwise and only then does it 
resort to querying the compiler.
  
  I do not particularly care whether or not the KDE*CompilerSettings modules 
use the `SUPPORTED_IF` feature but I think it should be there as a courtesy to 
devs who have reasons to avoid querying the compiler (and for compilers where 
CMake's querying algorithm doesn't work).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16894?vs=45567=45786

REVISION DETAIL
  https://phabricator.kde.org/D16894

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake
  modules/ECMAddCompilerFlag.cmake

To: rjvbb, #build_system, kfunk
Cc: kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb added a comment.


  >   E.g. I would have expected before looking at things that each view has 
their own separate context menu instance, possibly even created on the fly per 
display :)
  
  I think that is what I would have expected too (maybe not per display :)), 
and that's one reason I didn't feel like delving into KXMLGUI. That kind of 
dynamic approach would surely have made things much more complex in that 
framework. Instead, it looks like that GUI "skeleton" is created once and 
reused, and that must of course be a lot simpler.
  This also implies that it must be evident for anyone knowning KXMLGUI that 
the context menu instance for `aboutToShowContextMenu` signals is shared among 
views. As to the using a custom context menu feature: I suppose that devs using 
that are expected to know what they're doing...
  
  FWIW, this is exactly why I've subscribed the frameworks ML to this diff. Do 
you think we need to make a more targeted effort to draw KTextEditor developer 
attention to these last few comments?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16108: When re-using runners when reloading, reload their configuration

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:770f8d64a495: When re-using runners when reloading, 
reload their configuration (authored by broulik).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16108?vs=43321=45784

REVISION DETAIL
  https://phabricator.kde.org/D16108

AFFECTED FILES
  src/runnermanager.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16108: When re-using runners when reloading, reload their configuration

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16108

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb set the repository for this revision to R32 KDevelop.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb updated this revision to Diff 45782.
rjvbb added a comment.


  Another fix: use the active MainWindow as the parent of the contextMenuData 
instance and do NOT delete it in the `TextDocumentPrivate` dtor.
  
  Also, do not assume there will ever only be a single MainWindow in a KDevelop 
session: the least we can do is reset `TextDocumentPrivate::contextMenuData` 
when that instance is deleted.
  
  This should round up any issues with the new approach; I don't see anything 
that cries for immediate improval. Instead it'd be nice if this could make the 
5.3.1 release, being a bugfix.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16882?vs=45761=45782

REVISION DETAIL
  https://phabricator.kde.org/D16882

AFFECTED FILES
  kdevplatform/shell/textdocument.cpp
  kdevplatform/shell/textdocument.h

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16985: Fix apidox of RenameDialog_Option

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix-renameflags-apidox

REVISION DETAIL
  https://phabricator.kde.org/D16985

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns