D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49046.
jgrulich added a comment.


  Use QPointF instead of QSizeF and bump interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49028=49046

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  CMakeLists.txt
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> copyjob.cpp:1119
> +KJob *job = KIO::copy_xattr((*it).uSource, (*it).uDest);
> +job->exec();
>  //this is required for the undo feature

Here, too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D17816: Support for xattrs on kio copy/move

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> filecopyjob.cpp:519
> +KJob *job = KIO::copy_xattr(d->m_src, d->m_dest);
> +job->exec();
>  if (d->m_move) {

This waits (i.e. spawns a separate event loop) until the job is finished. 
Should use a subjob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D18114: FakeInput: add support for pointer move with absolute coordinates

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fake-input.xml:44
>
> +  
> +  

New requests can only be added at end. Since is missing.

> fakeinput_interface.cpp:85
>  pointerMotionCallback,
> +pointerMotionAbsoluteCallback,
>  buttonCallback,

Must be last, new requests only at end.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Root]

rooty updated this revision to Diff 49041.
rooty added a comment.


  Fix blunder and bring back search field, place "Search..." in search field

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18046?vs=48876=49041

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D10446: Add KLanguageName

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D10446

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

[Christoph Feck]

cfeck added a comment.


  What is the status of this patch? It missed the 5.54 deadline, so the version 
would need to be adjusted.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18081: Make translations work

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  arcpatch-D18081

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 08 Jan 2019 21:39:45 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D18089: KLauncher: handle process dying with exitStatus 0

[David Faure]

dfaure added a comment.


  Looks good. This assumes that no process exits cleanly (code 0) while not 
showing anything to the user, but even if that happened, better no klauncher 
error in that case, than an error in a normal case like the kate one.

INLINE COMMENTS

> klauncher.cpp:340
> +request->status = KLaunchRequest::Done;
> +qCDebug(KLAUNCHER) << pid << "died with exitStatus= 0, 
> requestDone. status=" << request->status ;
>  } else {

To make this less scary (since it's not an error) I would suggest

  << "exited without error, request done. status=" <<

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added a comment.


  Two more small comments from my side, otherwise looks cool :) Thanks for the 
perseverance!
  
  I can't approve it because the review is on my name ^_^
  
  Maybe @apol can give it the ship it?

INLINE COMMENTS

> klanguagenametest.cpp:80
> +}
> +};
> +

Do you think it makes sense adding this?

  void testNoString()
  {
  // Qt doesn't have za support so no string at all
  QCOMPARE(KLanguageName::nameForCode("za"), QString());
  }

> sitter wrote in klanguagename.cpp:30
> Do you mean both being **a** code or both being **the** code?
> 
> a code
> ==
> 
> `parts.at(0)` is the code of the current locale. The only way I found to get 
> the 639 code from qlocale is by splitting name 
> http://doc.qt.io/qt-5/qlocale.html#name
> 
> Perhaps a comment is needed to explain this?
> 
> the code
> 
> 
> Both params being the variable `code` wouldn't be right I think. The 
> documentation for `nameForCode` says it will ideally give you the localized 
> name of code in the system language.
> 
>   LANGUAGE=en nameForCode('en') => 'English'
>   LANGUAGE=fr nameForCode('en') => 'anglaise'
> 
> which internally is
> 
>   nameForCodeInLocale('en', 'en')
>   nameForCodeInLocale('en', 'fr')

Ar, ignore me i was reading the code wrong. Sorry for the noise

> klanguagename.h:34
> + *
> + * @since 5.44
> + *

Needs to be 5.55 i think

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D17730: Review KateStatusBar

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:dce48b397818: Review KateStatusBar (authored by loh.tar, 
committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48813=49037

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 08 Jan 2019 21:00:05 +
 Build duration:
2 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 08 Jan 2019 20:35:10 +
 Build duration:
6 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D17730: Review KateStatusBar

[Christoph Cullmann]

cullmann added a comment.


  Btw., I can resize both Kate and KWrite like I want, like in the screenshots 
visible above.

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D17730: Review KateStatusBar

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think the current state can go in.
  
  Here with and without this patch two tests fail:
  
  The following tests FAILED:
  
24 - kateindenttest_testCppstyle (Failed)
67 - vimode_emulatedcommandbar (Failed)
  
  (perhaps due to Qt 5.12)

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18081: Make translations work

[Albert Astals Cid]

aacid updated this revision to Diff 49034.
aacid added a comment.


  remove unrelated cmake changes

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18081?vs=48932=49034

BRANCH
  arcpatch-D18081

REVISION DETAIL
  https://phabricator.kde.org/D18081

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp
  src/kpackagetool/main.cpp
  src/kpackagetool/options.h

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[loh tar]

loh.tar added a comment.


  Nice trick ;-) Can't promise to do it, will see

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17852

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17730: Review KateStatusBar

[loh tar]

loh.tar added a comment.


  > It was stated that it broke tests, should this be addressed now?
  
  As shown in the pic, the bar forces no width anymore (at least it seems so)
  Your comments at the bug report are interesting, but I'm not sure to do it. I 
had Christoph promised to add options to customize what is shown, so that was 
on my mental list.

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18079

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D18076

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18116: Don't show document load trouble twice

[loh tar]

loh.tar added a comment.


  I have it only poor tested with our big S file, so no test was made with 
other trouble causing stuff.
  This need a patch in Kate, will try to link that
  
  KateBuffer::openFile
  
  - There is no distingues from
1. "create new file by command line" and
2. "restore files of session"
  - When..
1. is the error wrong
2. makes to me "new file" not much sense
  
  Is there a way to check wat is going on, 1) or 2) ? Guess, yes, and you can 
point me

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D4716: Add some more directives to MIPS assembler highlighting

[Alex Richardson]

arichardson added a comment.


  Sorry, was busy with other stuff so completely forgot about this. I'll update 
this soon.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4716

To: arichardson, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Since there are fancy "in view" messages which show all loading trouble
  are the still existent popup dialogs redundant, hence removed

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/document/katebuffer.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[Dominik Haumann]

dhaumann added a comment.


  I think this change makes sense.
  
  I would like to have a unit test for this. Doing so is simple: Add a function 
in autotest/src/kateview_test.h/cpp and add one bracket matching call, then 
check the new cursor position. Then, do the same in overwrite mode.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17852

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D4716: Add some more directives to MIPS assembler highlighting

[Dominik Haumann]

dhaumann added a comment.


  @arichardson friendly ping :-) In case you don't have the time, it's also OK 
to paste some example code in a comment here (MIT licensed, please). Then, we 
can proceed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4716

To: arichardson, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  What do we do with this?
  
  I think some of the checks are a bit too aggressive, such as folding multiple 
regexps into a single one: This makes the regexps much less readable and 
therefore hard to maintain.
  
  @jpoelen Shall we abandon this, or do you still would like to see some parts 
of this committed?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, vkrause, 
#framework_syntax_highlighting, dhaumann, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, sars, #frameworks

D17730: Review KateStatusBar

[Dominik Haumann]

dhaumann added a comment.


  Hm, what is the current state of this patch?
  
  It was stated that it broke tests, should this be addressed now?
  
  Btw, I added a detailed comment to 
https://bugs.kde.org/show_bug.cgi?id=402904 that explains a proper solution to 
shrinking the statusbar:
  
  1. by allowing compact notations (e.g. "Line 1, Column 1" would shrink to "L 
1, C 1")
  2. by allowing to hide widgets that are less important

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> copyxattrjob.cpp:114
> +}
> +QByteArray keylist(listlen, Qt::Uninitialized);
> +// get the key list

indentation

> copyxattrjob.h:33
> + *
> + * The CopyXattrJob copies extended attributes from a file or dir o another
> + * @see KIO::copy_xattr()

"... **t**o another."

> copyxattrjob.h:59
> + * @param dest The file where we put the xattrs.
> + * @param flags Can be HideProgressInfo, Overwrite and Resume here. WARNING:
> + * Setting Resume means that the data will be appended to @p dest if @p dest 
> exists.

There are no params

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fakeinput.h:139
> + **/
> +void requestPointerMoveAbsolute(const QSizeF );
>  /**

Wouldn't QPointF be a better choice?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fake-input.xml:19
>]]>
>
>

Version of the interface has to be bumped.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a dependent revision: D18115: Add support for fake pointer move 
with absolute coordinates.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a reviewer: davidedmundson.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  For remote desktop support, we need to move with the pointer using absolute 
position.

TEST PLAN
  I tested this with xdg-desktop-portal-kde and krfb and it worked.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17986: Build the Java side with Gradle, as AAR instead of JAR

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:054b4548ce1e: Build the Java side with Gradle, as AAR 
instead of JAR (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17986?vs=48881=49026#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17986?vs=48881=49026

REVISION DETAIL
  https://phabricator.kde.org/D17986

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGradle.cmake
  cmake/modules/local.properties.in
  cmake/modules/settings.gradle.in
  src/CMakeLists.txt
  src/KF5Notifications-android-dependencies.xml
  src/android/AndroidManifest.xml
  src/android/CMakeLists.txt
  src/android/build.gradle
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/org/kde/knotifications/KNotification.java
  src/org/kde/knotifications/NotifyByAndroid.java

To: vkrause, apol
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D17951: Haskell: Make = a special symbol

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:8d0af2fe0d22: Haskell: Make = a special symbol (authored 
by xialiyao, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17951?vs=49016=49018

REVISION DETAIL
  https://phabricator.kde.org/D17951

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.lhs.ref
  data/syntax/haskell.xml

To: xialiyao, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17951: Haskell: Make = a special symbol

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17951

To: xialiyao, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17998: test to fix cpp indenter

[Christoph Cullmann]

cullmann abandoned this revision.
cullmann added a comment.


  See
  
  https://codereview.qt-project.org/#/c/249358/
  
  There will be a fix in Qt (perhaps 5.12.1)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17998

To: cullmann, dhaumann, carewolf, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17951: Haskell: Make = a special symbol

[Li-yao Xia]

xialiyao updated this revision to Diff 49016.
xialiyao added a comment.


  Bumped version number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17951?vs=48642=49016

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17951

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.lhs.ref
  data/syntax/haskell.xml

To: xialiyao, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 08 Jan 2019 16:46:44 +
 Build duration:
5 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D17932: Improvements to completion

[Christoph Cullmann]

cullmann added a reviewer: KDevelop.
cullmann added a comment.


  Perhaps some KDevelop people have feedback, given they use that mostly ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, head7, kfunk, sars, dhaumann

D17951: Haskell: Make = a special symbol

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Beside the missing version increase, this looks good for me.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17951

To: xialiyao, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17999: ViewConfig: Add option to paste at cursor position by mouse

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e1b5f3177d42: ViewConfig: Add option to paste at cursor 
position by mouse (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17999?vs=48999=49012

REVISION DETAIL
  https://phabricator.kde.org/D17999

AFFECTED FILES
  src/dialogs/editconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[Dominik Haumann]

dhaumann accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[loh tar]

loh.tar added a comment.


  In D17999#389148 , @cullmann wrote:
  
  > "Paste by mouse at cursor position" should be ok, then I will push this, ok?
  
  
  Well, a last close look is nerver bad.

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[loh tar]

loh.tar updated this revision to Diff 48999.
loh.tar added a comment.


  Back to "Paste by mouse at cursor position"

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17999?vs=48778=48999

REVISION DETAIL
  https://phabricator.kde.org/D17999

AFFECTED FILES
  src/dialogs/editconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[Christoph Cullmann]

cullmann added a comment.


  "Paste by mouse at cursor position" should be ok, then I will push this, ok?

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[loh tar]

loh.tar added a comment.


  Sure, can do it. Which one have it to be ?
  
  - Paste clipboard contents at cursor location
  - Paste clipboard contents at cursor position
  - Paste by mouse at cursor position (This one was liked by Dominik, IIRC)

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[Christoph Cullmann]

cullmann added a comment.


  I can live with the checkbox, too, as the first iteration, but I think you 
need to change the text in the UI file, atm there is still that "mouse cursor 
position", should it no be "cursor position"?

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

[loh tar]

loh.tar added a comment.


  To avoid further comments I like to add that I don't like to do the requested 
change. Please improve it later, if needed.

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> katedocument.cpp:4016
>  // behavior when deleting from the start of a line, just when 
> explicitly
>  // calling the join command
>  Kate::TextLine tl = kateTextLine(line + 1);

Can one point me why this is needed/desired? I'm often annoyed from the keeped 
space

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

[loh tar]

loh.tar updated this revision to Diff 48994.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  Try to be smart

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17128?vs=48486=48994

REVISION DETAIL
  https://phabricator.kde.org/D17128

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 48960.
cochise added a comment.


  For some reason the added kio was not included

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=48959=48960

BRANCH
  xattr-copy-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/ConfigureChecks.cmake
  src/core/config-kiocore.h.cmake
  src/core/copyjob.cpp
  src/core/copyxattrjob.cpp
  src/core/copyxattrjob.h
  src/core/filecopyjob.cpp

To: cochise, dfaure
Cc: bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 48959.
cochise marked an inline comment as done.
cochise added a comment.


  All use cases working, added a new KIO to copy xattr
  
  Working on copy and move with or without overwrite for calls of 
  KIO::copy, KIO::copyAs and KIO::file_copy of files and directories.
  Due the last problems with the method to copy xattrs being private, I
  created a new KIO::copy_xattr. Not very async, but the operation should
  be fast enough.
  Some more work on the tests, removed the ones that don't make sense for
  the case and added checks to preent breackage if xattrs ar not supported.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=48733=48959

BRANCH
  xattr-copy-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/ConfigureChecks.cmake
  src/core/config-kiocore.h.cmake
  src/core/copyjob.cpp
  src/core/filecopyjob.cpp

To: cochise, dfaure
Cc: bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D10446: Add KLanguageName

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in klanguagename.cpp:30
> should the second param be code too?
> 
> I mean if we read the docs we say both are code (ISO 639-1), so both should 
> be the same and not only the first part?

Do you mean both being **a** code or both being **the** code?

a code
==

`parts.at(0)` is the code of the current locale. The only way I found to get 
the 639 code from qlocale is by splitting name 
http://doc.qt.io/qt-5/qlocale.html#name

Perhaps a comment is needed to explain this?

the code


Both params being the variable `code` wouldn't be right I think. The 
documentation for `nameForCode` says it will ideally give you the localized 
name of code in the system language.

  LANGUAGE=en nameForCode('en') => 'English'
  LANGUAGE=fr nameForCode('en') => 'anglaise'

which internally is

  nameForCodeInLocale('en', 'en')
  nameForCodeInLocale('en', 'fr')

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/28/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 08 Jan 2019 09:17:23 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel added a comment.


  I'm on strike until my device notifier patches are reviewed ;)
  
  More seriously, I did not have the time to look into gammaray. I will as soon 
as I can, but don't hesitate to tell me if you want to take over this patch.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

D18089: KLauncher: handle process dying with exitStatus 0

[Ahmad Samir]

ahmadsamir updated this revision to Diff 48948.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Fix commit message

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18089?vs=48947=48948

BRANCH
  klauncher-kateSessionManager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18089

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle process dying with exitStatus 0

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle process dying with exitStatus 0

[Ahmad Samir]

ahmadsamir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When a process dies with exitStatus 0, it could well be the app exited
  cleanly, and there's no need to display an error message.
  
  For example starting kate from a widget on the panel/desktop, where it
  shows the session chooser dialog before ever entering the main app event
  loop, then quitting/closing the dialog without starting kate. In a case
  like that matchesPendingRequest() will always return false as the service
  name hasn't (and won't) been changed from the unique x.xxx to org.kde.kate.
  
  BUG: 389678
  FIXED-IN: 5.55.0

TEST PLAN
  Before applying the diff:
  
  - set kate to "manually choose a session" on startup and add a kate widget to 
the desktop/panel and start kate from that widget
  - in the session chooser dialog, select quit (or close in newer versions)
  - an error message is displayed "KDEInit could not launch /usr/bin/kate"

REPOSITORY
  R303 KInit

BRANCH
  klauncher-kateSessionManager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18089

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: ahmadsamir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns