KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 16 Aug 2019 03:08:12 +
 Build duration:
5 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: Frameworks.
brute4s99 added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  by this patch, apps with a set WindowIcon will have that icon as fallback 
icon for their notifications invoked through NotifyBySnore backend for 
KNotifications on Windows 10.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63846.
brute4s99 added a comment.


  took inspiration from NotifyByAndroid. Now I can see all types of 
notifications perfectly well!

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23133?vs=63674=63846

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Only interpolation with variable (`#{$...}`) and beginning of the string 
(`"${...}..."`) was highlighted.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_scss_interpolation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23195

AFFECTED FILES
  autotests/folding/highlight.scss.fold
  autotests/html/highlight.scss.html
  autotests/html/review128925-2.scss.html
  autotests/input/highlight.scss
  autotests/reference/highlight.scss.ref
  autotests/reference/review128925-2.scss.ref
  data/syntax/scss.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23194: Making FileJob behave consistently.

[Alexander Saoutkin]

feverfew edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

[Alexander Saoutkin]

feverfew edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

[Alexander Saoutkin]

feverfew created this revision.
feverfew added reviewers: dfaure, fvogt, chinmoyr, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This patch does the following:
  
  1. Makes sure the close() signal is actually emitted when close() is called.
  2. Documents the FileJob functions more accurately, and ensures the file 
slave acts similarly to the two other slaves that implement these functions
  
  (smb/sftp).
  
  3. Fixes an issue when purposefully reading 0 bytes.

TEST PLAN
  The application I am developing on that depends on FileJob now successfully 
receives the close() signal when required and does not experience the bug 
  mentioned when reading 0 bytes. 
  Existing read/write/seek functionality is not broken.
  Tests also pass.

REPOSITORY
  R241 KIO

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

AFFECTED FILES
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Alexander Saoutkin]

feverfew abandoned this revision.
feverfew added inline comments.

INLINE COMMENTS

> feverfew wrote in file.cpp:524
> I think that would be appropriate for a separate revision which I'm doing. 
> This revision is only to handle the case outlined in the summary.

Actually I've realised using the other function would allow me to solve this 
problem much more cleanly. I'll abandon this revision and upload a new patch 
that addresses this problem (and others).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23193: Add support for Belarusian currency

[Shubham]

shubham added reviewers: Frameworks, ngraham.
shubham added a subscriber: Frameworks.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23193

To: shubham, #frameworks, ngraham
Cc: #frameworks, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23193: Add support for Belarusian currency

[Shubham]

shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  FEATURE: 339448

REPOSITORY
  R292 KUnitConversion

BRANCH
  currency

REVISION DETAIL
  https://phabricator.kde.org/D23193

AFFECTED FILES
  src/currency.cpp
  src/unit.h

To: shubham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Alexander Saoutkin]

feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in file.cpp:524
> This doesn't support error reporting. Why not refactor this loop using 
> read(char *, qint64)? I believe you can accommodate your changes inside the 
> loop cleanly then.

I think that would be appropriate for a separate revision which I'm doing. This 
revision is only to handle the case outlined in the summary.

> chinmoyr wrote in file.cpp:538
> here `bytes` being negative should be an error..no?

bytes is unsigned, so it is not a worry for us.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

[Christoph Cullmann]

cullmann added a comment.


  If the highlighting still is OK after removing them, sure, but it looks like 
the language wanted explicitly have different colors for stuff using the same 
default style. Perhaps one could use some of the new default styles in some 
places.
  And I would always update the version, to allow people to update properly.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23135

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

[jonathan poelen]

jpoelen added a comment.


  If it is better not to have a hard-coded color, wouldn't it be better to 
remove them once and for all? Without necessarily incrementing the version.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23135

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23134: fix additionalDeliminator attribute

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ff06ba217e40: fix additionalDeliminator attribute 
(authored by jpoelen, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23134?vs=63771=63835#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23134?vs=63771=63835

REVISION DETAIL
  https://phabricator.kde.org/D23134

AFFECTED FILES
  autotests/folding/fix_d399348.addDelim.fold
  autotests/html/fix_d399348.addDelim.html
  autotests/input/fix_d399348.addDelim
  autotests/input/syntax/fix_d399348_additional_deliminators.xml
  autotests/reference/fix_d399348.addDelim.ref
  src/lib/rule.cpp

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23134: fix additionalDeliminator attribute

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the test.
  With git diff -w the patch looks fine.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_wordDelimiters (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23134

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23137: C++: contracts are not in C++20

[Christoph Cullmann]

cullmann closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23137

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23137: C++: contracts are not in C++20

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I agree with this.
  It wasn't accepted for C++20, we can add it with the right syntax after it 
got into the next standard.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp_no_contract (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23137

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann added a comment.


  I think the current way we handle that is OK.
  If people start to include keywords between "incompatible" languages, any 
chosen direction is not really desirable.
  If somebody has time, for sure it makes sense to document the current status 
quo.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, vkrause, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  I don't think using the original word delimiters is a good thing. Let's 
imagine that c.xml lists the functions of the libc and a language that allows 
them to be used as `ffi.C.printf` (luajit for the curious). The separators of 
the 2 languages are not the same and `puts'plop'` works for one, but not for 
the other. If we rely on the C delimiters, it will not work anymore. I think we 
can find other examples and perhaps counter-examples.
  
  Currently, if we want to keep the word delimiters, we can always create a 
context in the referenced file (or another syntax file) and make an 
`IncludeRule`. It's ugly, the current checker complains if the context is not 
used, but I don't think that happens in nature. From what I see, the languages 
that share word lists are either syntactically similar or radically different.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, vkrause, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> file.cpp:524
>  while (true) {
>  QByteArray res = mFile->read(bytes);
>  

This doesn't support error reporting. Why not refactor this loop using 
read(char *, qint64)? I believe you can accommodate your changes inside the 
loop cleanly then.

> file.cpp:538
>  }
>  if (bytes <= 0) {
>  break;

here `bytes` being negative should be an error..no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63830.
meven added a comment.


  run uncrustify-kf5

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63786=63830

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven updated this revision to Diff 63829.
meven added a comment.


  run uncrustify-kf5

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22144?vs=62464=63829

BRANCH
  arcpatch-D22144

REVISION DETAIL
  https://phabricator.kde.org/D22144

AFFECTED FILES
  CMakeLists.txt
  kio-extras.categories
  recentlyused/CMakeLists.txt
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h
  recentlyused/recentlyused.json

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D22775: Allow date range filtering of resource events using Date Term

[Méven Car]

meven added a comment.


  gentle ping @ivan
  
  Waiting for this to move on on D22144  
and then D7446 

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22775

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23131: Define install location for JAR/AAR files for Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6faff48245c2: Define install location for JAR/AAR files 
for Android (authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23131?vs=63672=63820

REVISION DETAIL
  https://phabricator.kde.org/D23131

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: vkrause, #build_system, #android, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D22471: [KProcessList] Split command line and process name

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:969e01dc8d60: [KProcessList] Split command line and 
process name (authored by davidedmundson).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22471?vs=61784=63812

REVISION DETAIL
  https://phabricator.kde.org/D22471

AFFECTED FILES
  autotests/kprocesslisttest.cpp
  src/lib/util/kprocesslist.cpp
  src/lib/util/kprocesslist.h
  src/lib/util/kprocesslist_p.h
  src/lib/util/kprocesslist_unix.cpp

To: davidedmundson
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/13/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 15 Aug 2019 15:01:15 +
 Build duration:
6 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in renamefiledialog.cpp:60
> Just run `uncrustify-kf5` from the repo kde-dev-scripts.

I am very happy to learn about this one.

This script cannot work with a single file it seems and most of the files in 
this directory are modified by the script.
So I won't use it here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven updated this revision to Diff 63796.
meven added a comment.


  Group boolean fields together

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=62026=63796

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R285:e64b8314e201: Avoid enabling kcrash if its only 
included via a plugin (authored by davidedmundson).

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23171?vs=63787=63790

REVISION DETAIL
  https://phabricator.kde.org/D23171

AFFECTED FILES
  src/kcrash.cpp

To: davidedmundson, mart
Cc: mart, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  the logic is awesome, the checking with the static is not super pretty but 
saves significantly useless checks

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23171

To: davidedmundson, mart
Cc: mart, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

davidedmundson added a comment.


  Alternatively we could just kill the Q_COREAPP_STARTUP_FUNCTION as most apps 
already explicitly call KCrash::initialize() to get round distros compiling 
with link-as-needed?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D23171

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If a Qt app happens to load our plasma-integration plugin it shouldn't
  change how bug reporting works.
  
  There's no point showing drkonqi if there's not an
  appropriate KDE product.
  
  Worse, our crash handling can interfere with that processes own signal
  handling.
  
  This patch is effectively a copy of
  02b523bad09aab062355e46771889b0f3709692f 
 in 
kxmlgui for enabling auto-
  accelerators only if the lib is linked directly.
  
  BUG: 401637

TEST PLAN
  Changed the crashtest app in drkonqi to not directly link - didn't get drkonqi
  Re-enabled linking. Got drkonqi

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23171

AFFECTED FILES
  src/kcrash.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63786.
meven marked 9 inline comments as done.
meven added a comment.


  Remove unnecessary pointer use, code formatting

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63724=63786

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 15 Aug 2019 08:56:53 +
 Build duration:
1 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23157: Expose technology property in battery interface

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:eb82729b438f: Expose technology property in battery 
interface (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23157?vs=63745=63784

REVISION DETAIL
  https://phabricator.kde.org/D23157

AFFECTED FILES
  src/solid/devices/frontend/battery.h

To: meven, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23157: Expose technology property in battery interface

[Méven Car]

meven retitled this revision from "Add technology property to battery 
interface" to "Expose technology property in battery interface".

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23157

To: meven, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

[Christoph Cullmann]

cullmann closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23135

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23112: Add a event Spy for GtkFileChooser recent files

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:68
> +QDateTime visited;
> +QList *applications;
> +

No need for this to be a pointer to a list. Make it just `QList 
applications`.

> GtkEventSpy.cpp:70
> +
> +Bookmark(){
> +applications = new QList();

The constructor will not be needed once `applications` stops being a pointer.

> GtkEventSpy.cpp:76
> +
> +QString Bookmark::latestApplication() const {
> +Application current = applications->first();

`{` which starts a function should be on a new line (I don't care much about 
this, but let's follow the KF5 style)

> GtkEventSpy.cpp:77-78
> +QString Bookmark::latestApplication() const {
> +Application current = applications->first();
> +for (const Application  : qAsConst(*applications)) {
> +if (app.modified > current.modified) {

When you make `applications` not to be a pointer `qAsConst` will not be needed 
as this is a `const` member function.

> GtkEventSpy.cpp:89
> +public:
> +BookmarkHandler(){
> +current = nullptr;

Replace with:

  BookmarkHandler()
  : current(nullptr)
  {
  }

> GtkEventSpy.cpp:91
> +current = nullptr;
> +marks = QList();
> +}

No need for this - marks are already default-constructed.

> GtkEventSpy.cpp:113
> +if (qName == QStringLiteral("bookmark")) {
> +current = new Bookmark();
> +current->href = QUrl(attributes.value("href"));

No need for dynamic allocation. Make it a normal variable instead of a pointer.

> GtkEventSpy.cpp:185
> +reader.setErrorHandler();
> +QXmlInputSource *source = new QXmlInputSource();
> +

No need for dynamic allocation. Make it a normal variable instead of a pointer.

> meven wrote in GtkEventSpy.cpp:143
> It is to just extract the executable name, we don't want to have an exploding 
> number of initiatingAgent for every argument and parameter that might come 
> through here.

I meant it will be a problem if someone decides to have a space in the 
executable like `my\ aweomse\ binary`. But this should not be an issue at the 
moment.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23157: Add technology property to battery interface

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23157

To: meven, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns